If the AX.25 dialect chosen by the sysadmin is set to DAMA master / 3
(or DAMA slave / 2, if CONFIG_AX25_DAMA_SLAVE=n) ax25_kick() will fall
through the switch statement without calling ax25_send_iframe() or any
other function that would eventually free skbn thus leaking the packet.
Fix by
On Sat, 2006-18-03 at 15:10 +1000, Russell Stuart wrote:
[..]
I guess there are a couple of points here I don't understand:
- I don't see how 2.4 was buggy, but perhaps we have different
definitions of buggy. I regard giving the wrong result as
buggy. Neither algorithm does that.
Took off stoopid lartc. Please dont cc that list again since i keep
forgetting to remove it in my responses.
I only did the 8 bit test - I may go back and do the 16 bit
but now i am almost sure that the majority of the results will produce
similar results. So i dont know if i should bother.
Russell,
Your scheme for least square fit for evaluating the hash results
seems to be mostly fine for worst case lookups (I havent found a spot
where it lied about this at least). The only problem is it doesnt take
into consideration the spread as well and thus the memory utilization
aspect. So
On Sun, 2006-19-03 at 11:32 -0500, jamal wrote:
I only did the 8 bit test - I may go back and do the 16 bit
but now i am almost sure that the majority of the results will produce
similar results. So i dont know if i should bother.
I repeated with 256 buckets only and 16 bits. The number of
It looks like netlink_recvmsg() has recvfrom return sematics - when
userspace buffer is too small the return value is the number of octets
actually copied, not the number which _would_ be copied, if there was
enough space.
This makes using MSG_PEEK to ensure that the buffer is large enough buggy.
From: Ralf Baechle DL5RB [EMAIL PROTECTED]
Date: Sun, 19 Mar 2006 12:42:46 +
If the AX.25 dialect chosen by the sysadmin is set to DAMA master / 3
(or DAMA slave / 2, if CONFIG_AX25_DAMA_SLAVE=n) ax25_kick() will fall
through the switch statement without calling ax25_send_iframe() or any
This patch adds NAPI support for the Broadcom Sibyte SB1xxx family. The
changes are limited to adding a new config key SBMAC_NAPI to the
drivers/net/Kconfig and by adding the poll op and interrupt support to
drivers/net/sb1250-mac.c.
This patch also has a fix to drivers/net/sb1250-mac.c, the
On Sun, Mar 19, 2006 at 05:12:32PM -0600, Tom Rix wrote:
This patch also has a fix to drivers/net/sb1250-mac.c, the dma descriptor
table ptr is allocated, aligned and the aligned ptr is freed. If the ptr
was not already aligned (usually is) then the free would not work of what
was returned
On Fri, 2006-03-17 at 09:34 -0500, jamal wrote:
If you are unable to do this then I will. I just dont have time until this
Sunday.
I will not respond to any further emails which do not contain data - instead
I am going to produce mine.
After that wrist-slap I spent some time putting together
From: Adrian Bunk [EMAIL PROTECTED]
The Coverity checker (CID: 59) noted that the call to prism2_hw_reset()
was dead code. Move prism2_hw_reset() call to a place where it is
actually executed.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index:
From: Adrian Bunk [EMAIL PROTECTED]
The Coverity checker (CID: 273) spotted this inconsequent NULL checking
(unconditionally dereferencing directly after checking for NULL
isn't a good idea). Return immediately to avoid this.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Signed-off-by: Jouni
This set of patches fixes issues in Host AP driver found by Coverity. I
don't think any of these are critical, but anyway, these should be
fixed at some point. The diffs are against wireless-2.6 master branch,
but should apply to more or less any recent version of Host AP with
small offset
From: Eugene Teo [EMAIL PROTECTED]
The Coverity checker (CID: 930) spotted this double free on error path
(allocation failure). Do not free these here since generic error path
will take care of this.
Signed-off-by: Eugene Teo [EMAIL PROTECTED]
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
The Coverity checker (CID: 452, 453, 454, 455, 456) spotted this
unlikely read overrun of CIS buffer. Abort if CISTPL_CONFIG or
CISTPL_MANFID would not fit in buffer.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/drivers/net/wireless/hostap/hostap_plx.c
The Coverity checker (CID: 58) spotted this duplicated idx != 0
validation for unicast keys in prism2_ioctl_siwencodeext().
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/drivers/net/wireless/hostap/hostap_ioctl.c
The Coverity checker (CID: 659, 660) spotted this resource leak on
PCI probe error path. Free private data structure if pci_enable_device()
fails.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/drivers/net/wireless/hostap/hostap_pci.c
On Sun, 2006-03-19 at 11:47 -0500, jamal wrote:
Your scheme for least square fit for evaluating the hash results
seems to be mostly fine for worst case lookups (I havent found a spot
where it lied about this at least). The only problem is it doesnt take
into consideration the spread as well
Slightly improve the wording of the description of MV643XX_ETH
in Kconfig. This difference was found between the mainline and
linux-mips kernel trees.
Signed-off-by: Martin Michlmayr [EMAIL PROTECTED]
--- linux-2.6/drivers/net/Kconfig 2006-03-13 18:55:59.0 +
+++
From: Broadcom Corporation
Add support for the BCM1x55 and BCM1x80 chips. The BCM1x80 features
four Ethernet devices. This patch has been in the linux-mips tree
for several months and has also been tested by Debian.
Signed-off-by: Andy Isaacson [EMAIL PROTECTED]
Signed-off-by: Mark E Mason
There are three changes between the Linus' and linux-mips git trees
regarding the declaner driver. Two are cosmetic and one fixes a
call to the wrong function.
Signed-off-by: Martin Michlmayr [EMAIL PROTECTED]
Acked-by: Maciej W. Rozycki [EMAIL PROTECTED]
--- linux-2.6/drivers/net/declance.c
On Sun, 2006-03-19 at 11:32 -0500, jamal wrote:
Conclusion
--
Other than fixing a bug, then new hash is at least equal to the old
hash in about 16% of the cases and better in the rest(80% of the
time).
This is true in the case of both memory abuse and worst case lookups.
I
22 matches
Mail list logo
