[PATCH 06/11] ixgb: Fix TSO

2006-04-21 Thread Jeff Kirsher
- this fixes an issue of premature desc writeback by hardware Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_main.c | 17 +++-- 1 files changed, 15 insert

[PATCH 10/11] ixgb: clean up whitespace

2006-04-21 Thread Jeff Kirsher
- remove trailing whitespace Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb.h | 28 drivers/net/ixgb/ixgb_ethtool.c | 68 ++

[PATCH 07/11] ixgb: Fixed flow control parameters

2006-04-21 Thread Jeff Kirsher
- make default flow control only have *sending* of flow control packets enabled - fix to disable / enable flow control correctly Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ix

[PATCH 03/11] ixgb: Fix hard coded numbers

2006-04-21 Thread Jeff Kirsher
- removed hard coded numbers and used constants instead Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_ethtool.c |4 +++- drivers/net/ixgb/ixgb_main.c|8 +++

[PATCH 11/11] ixgb: Add prefetch

2006-04-21 Thread Jeff Kirsher
- This patch is to improve performance by adding prefetch to the ixgb driver - Add driver comments Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_main.c | 10

[PATCH 00/11] ixgb: driver update (upstream)

2006-04-21 Thread Jeff Kirsher
The following patches were diff's against Garzik's latest "upstream" branch and can be pulled from the following location: git://lost.foo-projects.org/linux-2.6.git ixgb-upstream The following series implements... 01. Fix compilation errors by initializing variables 02. Fix the use of dprintk r

[PATCH 04/11] ixgb: Fix duplicate code

2006-04-21 Thread Jeff Kirsher
- created function ixgb_set_speed_duplex to remove duplicate code Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_ethtool.c | 35 ++- 1

[PATCH 08/11] ixgb: Add support for copper 10GbE

2006-04-21 Thread Jeff Kirsher
- Add support for Copper 10GbE device ID 109E Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_hw.h |1 + drivers/net/ixgb/ixgb_ids.h |4 +++- drivers/net/ixgb

[PATCH 09/11] ixgb: Add performance enhancements to the buffer_info struct

2006-04-21 Thread Jeff Kirsher
Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_main.c | 36 1 files changed, 20 insertions(+), 16 deletions(-) diff --git a/drive

[PATCH 02/11] ixgb: Fix the use of dprintk rather than printk

2006-04-21 Thread Jeff Kirsher
- use DPRINTK and msglvl instead of printk - allow ethtool control of msglvl Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb.h |8 +- drivers/net/ixgb/ix

[PATCH 05/11] ixgb: Fix timeout code

2006-04-21 Thread Jeff Kirsher
- aligned timeout code to match e1000 Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb.h |1 + drivers/net/ixgb/ixgb_ethtool.c |1 + drivers/net/ixgb/ixgb

[PATCH 01/11] ixgb: Fix compilation errors by initializing variables

2006-04-21 Thread Jeff Kirsher
- initialized varaibles - rev'd driver version Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

Re: Hotplug race on name change

2006-04-21 Thread Herbert Xu
Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > Introduces new races in netdev_register_sysfs if the name changes, because > netdev_register_sysfs runs without RTNL at this point. So if some application > gets > in and changes the device name while netdev_register_sysfs is running, then > the cl

Re: Fw: Bug: PPP dropouts in >=2.6.16

2006-04-21 Thread Andi Kleen
On Friday 21 April 2006 19:15, Jesse Brandeburg wrote: > On 4/21/06, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > We do seem to have had a few reports of ppp regressions around this > > timeframe. > > me too. I couldn't use 2.6.16 at home on my pppoe connected router > because it was so slow.

[patch 5/5] s2io driver updates

2006-04-21 Thread Ananda Raju
Hi, The following patch contains fix related to init and shutdown of adapter as per user guide. The list of changes include 1. shutdown gracefully. 2. Need to mask/unmask interrupts in ISR required fro Xframe-E 3. Tx FIFO should be enabled after WRR calend

[patch 4/5] s2io driver updates

2006-04-21 Thread Ananda Raju
Hi, This patch contains additional statistics counters added to s2io driver these statistics are very much usefull in debugging the driver. Signed-off-by: Ananda Raju <[EMAIL PROTECTED]> --- diff -upNr bug_fixes1/drivers/net/s2io-regs.h stat_enhancement/drivers/net/s2io-regs.h -

[patch 3/5] s2io driver updates

2006-04-21 Thread Ananda Raju
Hi, This patch contains some of the bug fixes done for S2io driver. Following are the brief description of changes 1. Continuing with initialization if we get minimum required MSI-X vectors 2. fix for ethtool online link test fails 3. make wait_for_cmd_com

Re: Fw: [Bug 6421] New: kernel 2.6.10-2.6.16 on alpha: arch/alpha/kernel/io.c, iowrite16_rep() BUG_ON((unsigned long)src & 0x1) triggered

2006-04-21 Thread Andrew Morton
Ingo Oeser <[EMAIL PROTECTED]> wrote: > > Stephen Hemminger wrote: > > Looks like PIO at unaligned addresses doesn't work on alpha... > > Maybe this should be fixed similiar to ioread32_rep in > arch/alpha/kernel/io.c? > I think so, but Ivan thinks networking is bust: Ivan Kokshaysky <[EMAIL

[patch 2/5] s2io driver updates

2006-04-21 Thread Ananda Raju
hi, This patch contains the modification and bug fixes with respect to input parameters and outupt dmesages. following is brief description of the changes. 1. Set default values for rx_ring_sz[0..7] and tx_fifo_len[0..7] 2. verify few basic load parameter

[patch 1/5] s2io driver updates

2006-04-21 Thread Ananda Raju
hi, This patch contains all the changes that were done to improve performance of s2io driver. one line description of the changes are 1. For Non NAPI case the rx interrupt handler is being called unconditionally 2. code optimization and addin

Re: [PATCH 16/17] d80211: fix monitor interfaces

2006-04-21 Thread Johannes Berg
On Fri, 2006-04-21 at 23:05 +0200, Jiri Benc wrote: > Not necessary. It was just an example of the worst case. In typical > case, you will receive something more - probably all data and management > frames but no control frames. Ah right, yeah makes sense then I guess. So monitor is a way of tell

Re: [PATCH 9/10] d80211: rename master interface

2006-04-21 Thread Jiri Benc
On Fri, 21 Apr 2006 14:02:54 -0700, Stephen Hemminger wrote: > On Fri, 21 Apr 2006 22:53:29 +0200 (CEST) > Jiri Benc <[EMAIL PROTECTED]> wrote: > > - memcpy(mdev->name, "wlan%d", 7); > > + memcpy(mdev->name, "wmaster%d", 10); > > Why not use strlcpy or strncpy? and use sizeof(mdev->name) or I

Re: [PATCH 8/10] d80211: get rid of default management interface

2006-04-21 Thread Jiri Benc
On Fri, 21 Apr 2006 22:59:58 +0200, Johannes Berg wrote: > What's the management interface used for? In some small discussion > didn't we say that we'd rather move to having one netlink socket for > this? Yes, it's just a temporary solution. > Maybe then we can get away with not having native 802

Re: [PATCH 9/10] d80211: rename master interface

2006-04-21 Thread Stephen Hemminger
On Fri, 21 Apr 2006 22:53:29 +0200 (CEST) Jiri Benc <[EMAIL PROTECTED]> wrote: > Rename master interface to wmasterX to better reflect its purpose. > > Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> > > --- > > net/d80211/ieee80211.c |2 +- > net/d80211/ieee80211_i.h |2 +- > 2 files c

Re: [PATCH 16/17] d80211: fix monitor interfaces

2006-04-21 Thread Jiri Benc
On Fri, 21 Apr 2006 23:01:28 +0200, Johannes Berg wrote: > Yes, but didn't you just say that when monitor_during_oper == 0 then > it's equivalent to promisc mode? Not necessary. It was just an example of the worst case. In typical case, you will receive something more - probably all data and manag

Re: [PATCH 8/10] d80211: get rid of default management interface

2006-04-21 Thread Johannes Berg
On Fri, 2006-04-21 at 22:53 +0200, Jiri Benc wrote: > Default management interface (wlanXap) confuses users. It is only needed for > AP mode (and only until interfaces are converted to use native 802.11 > frames). What's the management interface used for? In some small discussion didn't we say th

Re: [PATCH 16/17] d80211: fix monitor interfaces

2006-04-21 Thread Jiri Benc
On Fri, 21 Apr 2006 22:52:58 +0200, Johannes Berg wrote: > > and this will work - independently of the value of monitor_during_oper. > > The difference is that in case of monitor_during_oper == 0, you won't > > probably receive much more frames from mon0 than from sta0. But - you > > will most like

Re: [PATCH 16/17] d80211: fix monitor interfaces

2006-04-21 Thread Johannes Berg
On Fri, 2006-04-21 at 22:57 +0200, Jiri Benc wrote: > On Fri, 21 Apr 2006 22:52:58 +0200, Johannes Berg wrote: > > > and this will work - independently of the value of monitor_during_oper. > > > The difference is that in case of monitor_during_oper == 0, you won't > > > probably receive much more f

[PATCH 9/10] d80211: rename master interface

2006-04-21 Thread Jiri Benc
Rename master interface to wmasterX to better reflect its purpose. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c |2 +- net/d80211/ieee80211_i.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) 784f203467e4421aa0ecac34cb1647f4bdfe51be diff --git a/net

[PATCH 3/10] d80211: fix Oops caused by packets sent directly to master device

2006-04-21 Thread Jiri Benc
Sending packets to master interface directly causes dereferencing of pointer containing random data. The same problem happens when originating virtual interface is removed while a packet is queued. We really shouldn't store pointer to ieee80211_sub_if_data in skb->cb. Store ifindex there instead.

Re: [PATCH 16/17] d80211: fix monitor interfaces

2006-04-21 Thread Johannes Berg
On Fri, 2006-04-21 at 22:49 +0200, Jiri Benc wrote: > > "Hard" monitor mode means the card is operating in a true rfmon mode - > i.e. you get everything on the given channel. "Soft" monitor mode means > that you will get only frames the device is willing to give you at the > time - this probably m

[PATCH 4/10] d80211: don't use pointer in ieee80211_tx_control

2006-04-21 Thread Jiri Benc
A problem similar to the one with ieee80211_sub_if_data and skb->cb happens to ieee80211_sub_if_data and ieee80211_tx_control. When originating interface is removed while packet is sent to the driver, bad things will happen. Use ifindex instead. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> ---

[PATCH 10/10] d80211: add one default interface

2006-04-21 Thread Jiri Benc
The wireless card is useless with master interface (wmasterX) only. Adding at least one virtual interface is necessity for every user. To save users a lot of pain (and to maintain backward compatibility) we should add one virtual interface by default. It is called wlanX (hopefully the name users ar

[PATCH 7/10] d80211: get rid of default AP interface

2006-04-21 Thread Jiri Benc
There is no need for default non-removable AP interface (wlanX), it just confuses users. This patch removes it and renames master interface from wlanX.11 to wlanX. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c | 78 +- ne

[PATCH 8/10] d80211: get rid of default management interface

2006-04-21 Thread Jiri Benc
Default management interface (wlanXap) confuses users. It is only needed for AP mode (and only until interfaces are converted to use native 802.11 frames). This patch removes default management interface. When a new interface is switched to AP mode, a management interface is created automatically.

[PATCH 5/10] d80211: per-interface SSID

2006-04-21 Thread Jiri Benc
Allow SSID to be set independently for each interface. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- include/net/d80211.h |9 ++-- net/d80211/ieee80211.c |6 - net/d80211/ieee80211_i.h |3 +++ net/d80211/ieee80211_ioctl.c | 47 +

[PATCH 6/10] d80211: per-interface generic_elem

2006-04-21 Thread Jiri Benc
Allow generic element to be set independently for each interface. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- include/net/d80211.h | 12 +++- net/d80211/ieee80211.c |6 -- net/d80211/ieee80211_i.h |2 ++ net/d80211/ieee80211_iface.c |1 + net/d80

[PATCH 0/10] d80211: bugfixes and reducing number of interfaces

2006-04-21 Thread Jiri Benc
Following patches can be also obtained from: git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git master The main purpose of these patches is to reduce the number of network interfaces presented to userspace; there are also some important bugfixes among them (mainly 3rd patch). Jiri Be

[PATCH 1/10] d80211: fix SIOCGIWESSID ioctl

2006-04-21 Thread Jiri Benc
Flags for SIOCGIWESSID ioctl were not set, thus SSID was never displayed by iwconfig. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211_ioctl.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) 56d18689a4964cc2e906cfb5164b31649735774a diff --git a/net/d80211/i

[PATCH 2/10] d80211: use is_multicast_ether_addr

2006-04-21 Thread Jiri Benc
Replace custom MULTICAST_ADDR macro with is_multicast_ether_addr function. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c | 29 +++-- net/d80211/ieee80211_i.h |2 -- 2 files changed, 15 insertions(+), 16 deletions(-) f01885676fc8b7adb838

Re: [PATCH 0/17] d80211 patches

2006-04-21 Thread Jiri Benc
On Fri, 21 Apr 2006 22:52:08 +0200, Michael Buesch wrote: > Can you please send your hacky patch for the bcm43xx > to me, so I can come up with a clean one? Sure, actually I planned to do it in a few minutes :-) drivers/net/wireless/bcm43xx-d80211/bcm43xx.h |1 drivers/net/wireless/bc

Re: [PATCH 16/17] d80211: fix monitor interfaces

2006-04-21 Thread Jiri Benc
On Fri, 21 Apr 2006 22:29:29 +0200, Johannes Berg wrote: > On Fri, 2006-04-21 at 22:11 +0200, Jiri Benc wrote: > > > Also, "soft" and "hard" monitor modes are introduced. > > What's the distinction? The code might want some comments about what > that > > > + /* Device is capable of perform

Re: [PATCH 0/17] d80211 patches

2006-04-21 Thread Michael Buesch
On Friday 21 April 2006 22:11, you wrote: > Please note that these changes break d80211 drivers. Can you please send your hacky patch for the bcm43xx to me, so I can come up with a clean one? (I think you already sent it to me, but I lost it :) ) Thanks. -- Greetings Michael. pgpOvX9t94ZnP.pgp

Re: e1000_down and tx_timeout worker race cleaning the transmit buffers

2006-04-21 Thread Andy Gospodarek
On 4/21/06, Michael Chan <[EMAIL PROTECTED]> wrote: > On Fri, 2006-04-21 at 16:01 -0400, Andy Gospodarek wrote: > > > I just hate to see extra resources used to solve problems that good > > coding can solve (not that my suggestion is necessarily a 'good' one), > > so I was trying to think of a way

[RFC] netdev sysfs failure handling

2006-04-21 Thread Stephen Hemminger
In case of sysfs failure, don't let device be brought up. It can be cleared by unregister_netdevice so module can be unloaded normally. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.17.orig/net/core/dev.c 2006-04-21 12:21:45.0 -0700 +++ sky2-2.6.17/net/core/dev.c

Re: e1000_down and tx_timeout worker race cleaning the transmit buffers

2006-04-21 Thread Michael Chan
On Fri, 2006-04-21 at 16:01 -0400, Andy Gospodarek wrote: > I just hate to see extra resources used to solve problems that good > coding can solve (not that my suggestion is necessarily a 'good' one), > so I was trying to think of a way to resolve this without explicitly > adding another workqueue

Re: [PATCH 16/17] d80211: fix monitor interfaces

2006-04-21 Thread Johannes Berg
On Fri, 2006-04-21 at 22:11 +0200, Jiri Benc wrote: > Also, "soft" and "hard" monitor modes are introduced. What's the distinction? The code might want some comments about what that > + /* Device is capable of performing full monitor mode even during > +* normal operation. */ actu

[PATCH 4/17] d80211: add IBSS and monitor interface types

2006-04-21 Thread Jiri Benc
Add constants for IBSS and monitor interface types. These constants are used in subsequent patches. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211_i.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) b5f3ee77e4da0c6cbe98000f1380d3df92a949d4 diff --git a/net/d8

[PATCH 7/17] d80211: rename IEEE80211_SUB_IF_TYPE_ constants

2006-04-21 Thread Jiri Benc
As we're going to expose IEEE80211_SUB_IF_TYPE_* constants to drivers, the prefix IEEE80211_SUB_IF_TYPE_ is no longer appropriate. The constants are going to mean the type of 802.11 interface, not the type of sub-interface structure (which is not visible to drivers at all). This patch renames them

[PATCH 14/17] d80211: set_multicast_list

2006-04-21 Thread Jiri Benc
Add set_multicast_list callback. The version of set_multicast_list in struct net_device cannot be used by a driver, because the driver is interested in cumulative flags and cumulative multicast list from all interfaces. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- include/net/d80211.h

[PATCH 15/17] d80211: fix handling of received frames

2006-04-21 Thread Jiri Benc
Make sure that every frame reaches every interface it belongs to. Previously, some packet (most notably multicast ones) were not delivered to all interface they should be delivered to. This also allows monitor interfaces to work easily, even together with regular interfaces. On a typical setup (i.

[PATCH 9/17] d80211: remove obsolete stuff

2006-04-21 Thread Jiri Benc
Because any number of interfaces may be added, bss_devs and sta_devs arrays cannot be fixed-size arrays. We can make them linked lists, but they are needed for optimalization only (and even that is questionable with subsequent patches). Let's remove them; we will probably want something similar lat

[PATCH 5/17] d80211: non-shared interface types

2006-04-21 Thread Jiri Benc
This patch removes "iwmode" variable (local->conf.mode) shared by all interfaces. Instead, every interface has its own type (STA/IBSS/AP/WDS). Please note, that - Actual SIOCSIWMODE ioctl is disabled by this patch and is implemented by one of subsequent patches. - There is no way to ask the driv

[PATCH 13/17] d80211: master interface auto up/down

2006-04-21 Thread Jiri Benc
There is no reason to put master interface to UP/DOWN state manually. Calling of hw->open and hw->stop callbacks logically belongs to ieee80211_master_open and ieee80211_master_stop functions, but then we need to refuse putting master interface to UP state when there is no other interface running,

[PATCH 1/17] d80211: Replace MODULE_PARM with module_param

2006-04-21 Thread Jiri Benc
From: Jouni Malinen <[EMAIL PROTECTED]> MODULE_PARM macro was removed and this broke net/d80211 build. Fix this by using module_param instead of MODULE_PARM. Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211_ioctl.c |4 ++

[PATCH 6/17] d80211: remove local->bssid variable

2006-04-21 Thread Jiri Benc
BSSID shouldn't be common for all interfaces. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c |4 ++-- net/d80211/ieee80211_i.h |1 - net/d80211/ieee80211_sta.c |8 ++-- 3 files changed, 4 insertions(+), 9 deletions(-) 78d82ec5d0282693656a09add9894

[PATCH 8/17] d80211: ask driver for allowed iface combinations

2006-04-21 Thread Jiri Benc
Not all combinations of interfaces (in fact, very few combination of interfaces) are possible to be UP together. When an interface is going UP, let's ask the driver if this is possible. Please note that ieee80211_if_init_conf structure is not complete yet - new fields will need to be added to allo

[PATCH 3/17] d80211: allow WDS remote to by set by WE

2006-04-21 Thread Jiri Benc
Setting of address of WDS remote peer wasn't possible by a WE call. Remote WDS peer can be understood as a remote AP and SIOCSIWAP/SIOCGIWAP are unused in WDS mode, so let's use them. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c | 25 +

[PATCH 2/17] d80211: symlinks to wiphy in sysfs

2006-04-21 Thread Jiri Benc
This patch adds symlinks under /sys/net/*/wiphy pointing to /sys/class/ieee80211/phyX. This allows new interfaces to be added by writing a new name to e.g. /sys/net/wlan0/wiphy/add_iface. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211_dev.c | 16 + net/d8

[PATCH 12/17] d80211: interface types changeable by SIOCSIWMODE

2006-04-21 Thread Jiri Benc
Allow type of interface to be set by SIOCSIWMODE. All of functions responsible for adding/removing/initialization of interfaces were moved to a new file ieee80211_iface.c. Function for removing interface was split into two parts: one for deinitialization of the interface and one for deallocation of

[PATCH 0/17] d80211 patches

2006-04-21 Thread Jiri Benc
Hi John, please pull to your wireless-dev tree from git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git up to obtain following patches. They were all posted to netdev previously and are all discussed with Jouni (except 7th patch, but that is quite simple and shouldn't cause any harm).

[PATCH 10/17] d80211: fix interface configuration

2006-04-21 Thread Jiri Benc
This patch fixes some problems in interface configuration. - Pass interface ID to add_interface and remove_interface callbacks. This ID is used by a driver when calling ieee80211_beacon_get and ieee80211_get_buffered_bc functions. - New configuration callback, config_interface, is introduced.

[PATCH 16/17] d80211: fix monitor interfaces

2006-04-21 Thread Jiri Benc
This patch allows monitor interfaces to be set by SIOCSIWMODE and to receive frames. Also, "soft" and "hard" monitor modes are introduced. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- include/net/d80211.h | 10 ++ net/d80211/ieee80211.c | 67 ++

[PATCH 17/17] d80211: fix AP interfaces

2006-04-21 Thread Jiri Benc
This allows interfaces of IEEE80211_IF_TYPE_MGMT type (wlan%dap interfaces) to be put UP. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) 906a789aa674216a18ad5dc13c0635bc5664b793 diff --git a/net/d80211/ieee802

[PATCH 11/17] d80211: rename adm_status to radio_enabled

2006-04-21 Thread Jiri Benc
PRISM2_PARAM_ADM_STATUS is not much descriptive name. This patch renames it to PRISM2_PARAM_RADIO_ENABLED, sets radio_enabled to 1 by default (this is no problem as radio must not be enabled until at least one network interface is running) and removes automatic setting of adm_status when interface

[PATCH 1/2] class device: add attribute_group creation

2006-04-21 Thread Stephen Hemminger
Extend the support of attribute groups in class_device's to allow groups to be created as part of the registration process. This allows network device's to avoid race between registration and creating groups. Note that unlike attributes that are a property of the class object, the groups are a pro

[PATCH 2/2] netdev: create attribute_groups with class_device_add

2006-04-21 Thread Stephen Hemminger
Atomically create attributes when class device is added. This avoids the race between registering class_device (which generates hotplug event), and the creation of attribute groups. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.17.orig/net/core/dev.c 2006-04-21 12:20:58.0

Re: e1000_down and tx_timeout worker race cleaning the transmit buffers

2006-04-21 Thread Andy Gospodarek
On 4/21/06, Michael Chan <[EMAIL PROTECTED]> wrote: > On Fri, 2006-04-21 at 09:27 -0400, Andy Gospodarek wrote: > > > > > Isn't the only possibility for a linkwatch deadlock when the > > __LINK_STATE_LINKWATCH_PENDING but is set in dev->state? > > This device that you're about to close may be on th

tune back idle cwnd closing?

2006-04-21 Thread Zach Brown
My apologies if this is a FAQ, I couldn't find it in the archives. We have some dudes who are syncing large amounts of data across a dedicated long fat pipe at somewhat irregular intervals that are, sadly, longer than the rto. They feel the pain of having to reopen the window between transmission

Re: Fw: Bug: PPP dropouts in >=2.6.16

2006-04-21 Thread Andrew Morton
"Jesse Brandeburg" <[EMAIL PROTECTED]> wrote: > > On 4/21/06, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > We do seem to have had a few reports of ppp regressions around this > > timeframe. > > me too. I couldn't use 2.6.16 at home on my pppoe connected router > because it was so slow. I did

Re: Fw: [Bug 6421] New: kernel 2.6.10-2.6.16 on alpha: arch/alpha/kernel/io.c, iowrite16_rep() BUG_ON((unsigned long)src & 0x1) triggered

2006-04-21 Thread Ingo Oeser
Stephen Hemminger wrote: > Looks like PIO at unaligned addresses doesn't work on alpha... Maybe this should be fixed similiar to ioread32_rep in arch/alpha/kernel/io.c? This may slow it down, but will not break it. > Begin forwarded message: > > Date: Fri, 21 Apr 2006 02:35:45 -0700 > From: [E

Fw: [Bug 6421] New: kernel 2.6.10-2.6.16 on alpha: arch/alpha/kernel/io.c, iowrite16_rep() BUG_ON((unsigned long)src & 0x1) triggered

2006-04-21 Thread Stephen Hemminger
Looks like PIO at unaligned addresses doesn't work on alpha... Begin forwarded message: Date: Fri, 21 Apr 2006 02:35:45 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bug 6421] New: kernel 2.6.10-2.6.16 on alpha: arch/alpha/kernel/io.c, iowrite16_rep() BUG_ON((unsigned long)src &

Hotplug race on name change

2006-04-21 Thread Stephen Hemminger
This: > Without that patch, there is a race when registering network interfaces > and renaming it with udev rules, because initially the "address" in > sysfs doesn't contain useful data. See > http://marc.theaimsgroup.com/?t=11446033892&r=1&w=2 > > Breaking the recommended way of assigning

How does LED blinking work in e1000 driver?

2006-04-21 Thread Tony Chung
Hi, Can someone explain how does LED blinking work in the e1000 driver? For the copper version work, please verify my understanding: 1. The blinking of the four LEDs is control by the LEDCTL register through a 32 bit value. That is 8 bit per LED. This is already described in the Intel software

Re: Fw: Bug: PPP dropouts in >=2.6.16

2006-04-21 Thread Jesse Brandeburg
On 4/21/06, Andrew Morton <[EMAIL PROTECTED]> wrote: > > We do seem to have had a few reports of ppp regressions around this > timeframe. me too. I couldn't use 2.6.16 at home on my pppoe connected router because it was so slow. I didn't have time to debug. I can probably try patches and provid

Re: [PATCH 0/10] [IOAT] I/OAT patches repost

2006-04-21 Thread Ingo Oeser
David S. Miller wrote: > The first thing an application is going to do is touch that data. So > I think it's very important to prewarm the caches and the only > straightforward way I know of to always warm up the correct cpu's > caches is copy_to_user(). Hmm, what if the application is sth. like

Re: [PATCH 0/10] [IOAT] I/OAT patches repost

2006-04-21 Thread Rick Jones
David S. Miller wrote: From: Rick Jones <[EMAIL PROTECTED]> Date: Thu, 20 Apr 2006 18:00:37 -0700 Actually, that brings-up a question - presently, and for reasons that are lost to me in the mists of time - netperf will "access" the buffer before it calls recv(). I'm wondering if that should

Re: e1000_down and tx_timeout worker race cleaning the transmit buffers

2006-04-21 Thread Michael Chan
On Fri, 2006-04-21 at 09:27 -0400, Andy Gospodarek wrote: > > Isn't the only possibility for a linkwatch deadlock when the > __LINK_STATE_LINKWATCH_PENDING but is set in dev->state? This device that you're about to close may be on the linkwatch list, or other devices may also be on the linkwat

Re: Van Jacobson's net channels and real-time

2006-04-21 Thread Ingo Oeser
Hi David, nice to see you getting started with it. I'm not sure about the queue logic there. 1867 /* Caller must have exclusive producer access to the netchannel. */ 1868 int netchannel_enqueue(struct netchannel *np, struct netchannel_buftrailer *bp) 1869 { 1870unsigned long tail; 1871 1872

Re: Congestion Avoidance Monitoring Tools

2006-04-21 Thread Stephen Hemminger
On Thu, 20 Apr 2006 22:26:14 -0700 Piet Delaney <[EMAIL PROTECTED]> wrote: > I'm upgrading our 2.6.12 kernel to 2.6.13, which includes significant > congestion avoidance code additions and changes. I was wondering if > there are any tools folks can recommend for testing the kernel to make > sure t

Question on using Linux as a router

2006-04-21 Thread Serge Goodenko
Hi everybody! I got the following question. When I use linux as a router (via ip forwarding) what kernel variables (maybe some queues?) represent the closest analogue of usual hardware router input and output buffers? May this be, say, backlog queue or something else? The things I need to get

Re: e1000_down and tx_timeout worker race cleaning the transmit buffers

2006-04-21 Thread Andy Gospodarek
On Thu, Apr 20, 2006 at 06:24:36PM -0700, Michael Chan wrote: > On Fri, 2006-04-21 at 12:40 +1000, Herbert Xu wrote: > > > One simple solution is to establish a separate queue for RTNL-holding > > users or vice versa for non-RTNL holding networking users. That > > would allow the drivers to safel

Fw: Bug: PPP dropouts in >=2.6.16

2006-04-21 Thread Andrew Morton
We do seem to have had a few reports of ppp regressions around this timeframe. Begin forwarded message: Date: Thu, 20 Apr 2006 23:28:24 +0200 (CEST) From: Nuri Jawad <[EMAIL PROTECTED]> To: linux-kernel@vger.kernel.org Subject: Bug: PPP dropouts in >=2.6.16 Good evening, I've recently had pr

Re: Congestion Avoidance Monitoring Tools

2006-04-21 Thread Piet Delaney
On Fri, 2006-04-21 at 08:57 +0200, Andi Kleen wrote: > On Friday 21 April 2006 07:59, Tom Young wrote: > > On Thu, 2006-04-20 at 22:26 -0700, Piet Delaney wrote: > > > I'm upgrading our 2.6.12 kernel to 2.6.13, which includes significant > > > congestion avoidance code additions and changes. I was