From: Guillaume Chazarain [EMAIL PROTECTED]
Date: Wed, 19 Jul 2006 14:47:34 +0200
Shuya MAEDA wrote :
while (__delta USEC_PER_SEC){ ... }, but I think it should be
while (__delta = USEC_PER_SEC){ ... }. Is it right?
I agree, good catch :-)
Applied, thanks a lot.
-
To unsubscribe from
Christoph Hellwig made a comment about how the names in ieee80211.h make more
sense, and I also agree. This should also make patches for migrating fullmac
drivers to d80211 smaller.
Hopefully I didn't miss anything in the transition. Patch is bzip2ed since a
49kb patch seems a little big for
From: Henrik Kretzschmar [EMAIL PROTECTED]
[NET] initialisation cleanup for ULI526x-net-driver
removes the unneeded local variable rc
replace pci_module_init() with pci_register_driver()
two coding style issues on switch
Signed-off-by: Henrik Kretzschmar [EMAIL PROTECTED]
---
diff -ruN
From: Henrik Kretzschmar [EMAIL PROTECTED]
[NET] initialisation cleanup for ULI526x-net-driver
removes the unneeded local variable rc
replace pci_module_init() with pci_register_driver()
two coding style issues on switch
Signed-off-by: Henrik Kretzschmar [EMAIL PROTECTED]
---
diff -ruN
On Mon, 24 Jul 2006 01:39:30 -0700, Michael Wu wrote:
Christoph Hellwig made a comment about how the names in ieee80211.h make more
sense, and I also agree. This should also make patches for migrating fullmac
drivers to d80211 smaller.
Could you split the patch to two patches (one for the
On Sun, 23 Jul 2006 01:43:25 -0700, Michael Wu wrote:
This patch moves the MACSTR/MAC2STR macros to d80211.h
so that they are available to drivers. It also converts the adm8211
and bcm43xx drivers to use this macro.
I really dislike those MACSTR/MAC2STR names. I always fail to remember
which
On Sun, Jul 23, 2006 at 11:13:52AM -0500, Larry Finger wrote:
Michael Buesch wrote:
On Sunday 23 July 2006 17:59, Larry Finger wrote:
Do you have the same problem on other git trees?
I saw some people running into this error when cloning Linus'
linux-2.6.git. I couldn't reproduce it, using
Jeff,
Any status on accepting this patch, I've got some additional fixes
that are based on having access to genphy_update_link()
- kumar
On Jun 5, 2006, at 6:45 PM, Nathaniel Case wrote:
On Mon, 2006-06-05 at 17:08 -0500, Andy Fleming wrote:
Looks good. Feel free to send these patches
On Monday 24 July 2006 06:54, Jiri Benc wrote:
I really dislike those MACSTR/MAC2STR names. I always fail to remember
which one is which. What about renaming them when we are touching them?
And why not to use MAC_FMT/MAC_ARG names as used in net/ieee80211.h? ;-)
I dislike MACSTR/MAC2STR too,
On 7/23/06, Michael Wu [EMAIL PROTECTED] wrote:
Hi,
This patch series converts a number of fullmac wireless drivers to use
d80211.h instead of ieee80211.h.
Nice work
The remaining drivers are hostap, atmel, zd1211rw and ipw*.
I've been working on zd1211rw, give me a week. Anyone
Christophe Devriese [EMAIL PROTECTED] wrote:
[...]
Would it be acceptable to have an interface flag IFF_SILENT that can be set on
an interface, which prevents it from receiving packets in both forwarding
paths ?
Starting with kernel version 2.6.17, there is code in skb_bond()
to
Todd Showalter wrote:
I've been having trouble with the sky2 driver. It appears to work
most of the time, but it will quite often wedge during transfers. The
2.6.17.* kernels actually seem worse than 2.6.16.19, but none of them
work perfectly.
What typically happens is that after
On Mon, 24 Jul 2006 14:38:39 -0400
Todd Showalter [EMAIL PROTECTED] wrote:
On Mon, 24 Jul 2006 10:53:03 -0700, Stephen Hemminger
[EMAIL PROTECTED] wrote:
There is a receive problem that shows up under load, that is fixed
in the latest version (2.6.18 git), the patch is queued for the
On Wed, 19 Jul 2006 13:01:50 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Wed, 19 Jul 2006 15:52:04 -0400
As a related note, I am looking into fixing inet hash tables to use RCU.
IBM had posted a patch a long time ago, which would be
On Mon, 24 Jul 2006 11:45:33 -0700, Stephen Hemminger
[EMAIL PROTECTED] wrote:
I suspect that probably isn't a sky2 driver problem.
Does it go away if you turn of TCP window scaling:
sysctl -w net.ipv4.tcp_window_scaling=0
If so, you probably have a middlebox in your path that is not
Sukadev Bhattiprolu [EMAIL PROTECTED] wrote:
| Andrew,
|
| Javier Achirica, one of the major contributors to drivers/net/wireless/airo.c
| took a look at this patch, and doesn't have any problems with it. It doesn't
| fix any bugs and is just a cleanup, so it certainly isn't a candidate
| for
On Fri, 2006-07-21 at 05:06 -0700, Toralf Förster wrote:
Compiling (an exotic ?) config I got:
...
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
drivers/built-in.o: In function `bnx2_set_rx_mode':
bnx2.c:(.text+0xd741e): undefined reference to `crc32_le'
From: Patrick McHardy [EMAIL PROTECTED]
Date: Wed, 19 Jul 2006 14:42:35 +0200
Stefan Rompf wrote:
[VLAN]: Fix link state propagation
When the queue of the underlying device is stopped at initialization time
or the device is marked not present, the state will be propagated to the
vlan
Hello!
Also, there is some code for refcnt's in it that looks wrong.
Yes, it is disgusting. rcu does not allow to increase socket refcnt
in lookup routine.
Ben's version looks cleaner here, it does not touch refcnt
in rcu lookups. But it is dubious too:
do_time_wait:
+ sock_hold(sk);
From: Wei Yongjun [EMAIL PROTECTED]
Date: Wed, 05 Jul 2006 05:19:54 -0400
In my test, those direct state transition can not be counted to
tcpAttemptFails. Following is my patch:
Signed-off-by: Wei Yongjun [EMAIL PROTECTED]
This change can be implemented more simply, I believe.
Except for
Ben Greear [EMAIL PROTECTED] wrote:
Jay Vosburgh wrote:
Another possibility would be to have __vlan_hwaccel_rx check the
VLAN_DEV_INFO(skb-dev)-real_dev, and if that's a bonding device, apply
the same logic found in skb_bond(). Or, if there's some way to ask the
question is dev a VLAN
Jay Vosburgh wrote:
Ben Greear [EMAIL PROTECTED] wrote:
Jay Vosburgh wrote:
Another possibility would be to have __vlan_hwaccel_rx check the
VLAN_DEV_INFO(skb-dev)-real_dev, and if that's a bonding device, apply
the same logic found in skb_bond(). Or, if there's some way to ask
From: Wei Yongjun [EMAIL PROTECTED]
Date: Thu, 06 Jul 2006 04:01:18 -0400
- TCP_INC_STATS(TCP_MIB_OUTSEGS);
+ if (!(tcb-sacked TCPCB_LOST))
+ TCP_INC_STATS(TCP_MIB_OUTSEGS);
This test is not accurate enough. For example, timer based
retransmits will not set the
On Mon, 24 Jul 2006 16:34:46 -0500
Larry Finger [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
Michael Buesch spotted this typo. The impact is that the incorrect value
was being computed for blinking LED and interrupt moderation values.
Signed-off-by: Stephen Hemminger [EMAIL
Okay, Fix both typo's in one patch .The impact is that the incorrect value
was being computed for blinking LED and interrupt moderation values.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- skge-2.6.orig/drivers/net/skge.c
+++ skge-2.6/drivers/net/skge.c
@@ -516,10 +516,7 @@ static int
From: Roland Dreier [EMAIL PROTECTED]
Date: Tue, 04 Jul 2006 13:34:27 -0700
Well, here's a quick overview, leaving out some of the details. The
difference between TOE and iWARP/RDMA is really the interface that
they present.
Thanks for the description Roland. It helps me understand the
From: Tom Tucker [EMAIL PROTECTED]
Date: Wed, 05 Jul 2006 12:09:42 -0500
A TOE net stack is closed source firmware. Linux engineers have no way
to fix security issues that arise. As a result, only non-TOE users will
receive security updates, leaving random windows of vulnerability for
each
From: Steve Wise [EMAIL PROTECTED]
Date: Wed, 05 Jul 2006 12:50:34 -0500
However, iWARP devices _could_ integrate with netfilter. For most
devices the connection request event (SYN) gets passed up to the host
driver. So the driver can enforce filter rules then.
This doesn't work. In order
From: Christoph Hellwig [EMAIL PROTECTED]
Date: Fri, 7 Jul 2006 11:10:08 +0200
skbuff.h has an #ifndef CONFIG_HAVE_ARCH_DEV_ALLOC_SKB to allow
architectures to reimplement __dev_alloc_skb. It's not set on any
architecture and now that we have an architecture-overrideable
NET_SKB_PAD there is
From: Christoph Hellwig [EMAIL PROTECTED]
Date: Fri, 7 Jul 2006 11:09:57 +0200
dev_alloc_skb is designated for RX descriptors, not TX. (Some drivers
use it for the latter anyway, but that's a different story)
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Also applied, thanks a lot.
-
That TOE/iWARP could end-up being precluded by NAT seems so ironic from a POE2E
standpoint.
rick jones
Purity Of End To END
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
This should fix the problem reported in
http://bugzilla.kernel.org/show_bug.cgi?id=6186
where the skb is used after freed. The code in IP multicast route.
Code was reusing an skb which could lead to use after free or double free.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
From: Rick Jones [EMAIL PROTECTED]
Date: Mon, 24 Jul 2006 15:34:30 -0700
That TOE/iWARP could end-up being precluded by NAT seems so ironic
from a POE2E standpoint.
To be honest we do not have a pure end to end internet, and some of
our failed experiments in the past prove this :-)
For
skbuff.h has an #ifndef CONFIG_HAVE_ARCH_DEV_ALLOC_SKB to allow
architectures to reimplement __dev_alloc_skb. It's not set on any
architecture and now that we have an architecture-overrideable
NET_SKB_PAD there is not point at all to have one either.
I missed this when hch first posted it,
[EMAIL PROTECTED] wrote:
From: Steve Wise [EMAIL PROTECTED]
Date: Wed, 05 Jul 2006 12:50:34 -0500
However, iWARP devices _could_ integrate with netfilter. For most
devices the connection request event (SYN) gets passed up to the host
driver. So the driver can enforce filter rules then.
On Tuesday 25 July 2006 00:34, Rick Jones wrote:
That TOE/iWARP could end-up being precluded by NAT seems so ironic from a
POE2E
standpoint.
Yes, it's sad, but reality unfortunately.
There is even precedent: the VJ stateless TW recycling scheme also
turned out to not work because of NAT
[EMAIL PROTECTED] wrote:
From: Tom Tucker [EMAIL PROTECTED]
Date: Wed, 05 Jul 2006 12:09:42 -0500
A TOE net stack is closed source firmware. Linux engineers have no
way to fix security issues that arise. As a result, only non-TOE
users will receive security updates, leaving random windows
For example, my idea to allow ESTABLISHED TCP socket demux to be done
before netfilter is flawed. Connection tracking and NAT can change
the packet ID and loop it back to us to hit exactly an ESTABLISHED TCP
socket, therefore we must always hit netfilter first.
Hmm, how does this happen?
I
Hi,
This patch contains some of the bug fixes and enhancements done to
s2io driver. Following are the brief description of changes
1. Introduced macro S2IO_PARM_INT for declaring integer load parameter
2. UDP_RR test failure, memset txdl after Tx completion
Hi,
This patch contains some of the bug fixes and enhancements done to
s2io driver. Following are the brief description of changes
1. code cleanup to handle gso modification better
2. Move repeated code in rx path, to a common function
On Tuesday 25 July 2006 01:22, David Miller wrote:
From: Andi Kleen [EMAIL PROTECTED]
Date: Tue, 25 Jul 2006 01:10:25 +0200
All the original costs of route, netfilter, TCP socket lookup all
reappear as we make VJ netchannels fit all the rules of real practical
systems, eliminating
This appears to be a mistake, but I didn't follow the GSO stuff
very closely, so there could be some non-obvious reason.
[XFRM]: Fix protocol field value for outgoing IPv6 GSO packets
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
---
commit 8035f60a607630459e4440dbbc5a20f3cfbf97ac
tree
On Tue, Jul 25, 2006 at 02:09:26AM +0200, Patrick McHardy wrote:
This appears to be a mistake, but I didn't follow the GSO stuff
very closely, so there could be some non-obvious reason.
Yes it definitely was a mistake! Thanks for picking this up Patrick.
[XFRM]: Fix protocol field value for
This all sounds like the discussions we had within HP-UX between 10.20 and 11.0
concerning Inbound Packet Scheduling vs Thread Optimized Packet Scheduling. IPS
was done by the 10.20 stack at the handoff between the driver and netisr. If
the packet was not an IP datagram fragment, parts of the
From: Rick Jones [EMAIL PROTECTED]
Date: Mon, 24 Jul 2006 17:29:05 -0700
Nirvana I suppose would be the addition of a field in the header
which could be used for the determination of where to process. A
Transport Protocol option I suppose, maybe the IPv6 flow id, but
knuth only knows if
David Miller wrote:
From: Rick Jones [EMAIL PROTECTED]
Date: Mon, 24 Jul 2006 17:29:05 -0700
Nirvana I suppose would be the addition of a field in the header
which could be used for the determination of where to process. A
Transport Protocol option I suppose, maybe the IPv6 flow id, but
knuth
It would have to be done in such a way as to not make the PAWS
tests fail by accident. But I think it's doable.
CPU ID and higher-order generation number such that whenever the process
migrates to a lower-numbered CPU, the generation number is bumped to make the
timestamp larger than before?
Tom Walter Dillig wrote:
[109]
452 net/ieee80211/softmac/ieee80211softmac_io.c
Possible null dereference of variable *pkt in function call
(include/asm/string.h:__constant_c_and_count_memset) checked at
(453:net/ieee80211/softmac/ieee80211softmac_io.c)
Either I'm misunderstanding, or this is
Tom Walter Dillig wrote:
[109]
452 net/ieee80211/softmac/ieee80211softmac_io.c
Possible null dereference of variable *pkt in function call
(include/asm/string.h:__constant_c_and_count_memset) checked at
(453:net/ieee80211/softmac/ieee80211softmac_io.c)
Either I'm misunderstanding, or this is
On Tue, 25 Jul 2006 01:00:54 +0100
Daniel Drake [EMAIL PROTECTED] wrote:
Tom Walter Dillig wrote:
[109]
452 net/ieee80211/softmac/ieee80211softmac_io.c
Possible null dereference of variable *pkt in function call
(include/asm/string.h:__constant_c_and_count_memset) checked at
Even enough bits for 1024 or 2048 CPUs in the single system image?
MSI-X supports 255 sub interrupts max, most hardware probably much less
(e.g. 8 seems to be a popular number).
It can be always hashed to the existing CPUs.
It's a nice idea but I think standard hashing + processing in
Add NAPI support to the via-rhine driver so that it can handle higher speeds
and doesn't get overloaded by interrupts as easily.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/via-rhine.c | 75 +++
1 files changed, 63
From: Rick Jones [EMAIL PROTECTED]
Date: Mon, 24 Jul 2006 17:55:24 -0700
Even enough bits for 1024 or 2048 CPUs in the single system image? I have
seen
1024 touted by SGI, and with things going so multi-core, perhaps 16384 while
sounding initially bizzare would be in the realm of
Ben Greear [EMAIL PROTECTED] wrote:
Jay Vosburgh wrote:
Sadly, elegance remains elusive, since the by the time skb_bond
is called, the slave device the packet arrived on isn't available
(vlan-real_dev points to 'bond0' by this point), and that information
is needed to decide whether to
On Tuesday 25 July 2006 02:29, Rick Jones wrote:
This all sounds like the discussions we had within HP-UX between 10.20 and
11.0
concerning Inbound Packet Scheduling vs Thread Optimized Packet Scheduling.
We've also talking about this for many years, just no code so far.
Or rather Linux so
On Sunday 23 July 2006 08:32, Anthony DeRobertis wrote:
Andreas Kleen wrote:
You need to use iommu=soft swiotlb=force
The standard IOMMU is also broken on VIA, but forced swiotlb should
work.
Didn't work :-(
swiotlb=force is unfortunately broken right now.
But which this patch
[IPROUTE]: Add support for multipath route realms
Routing realms exist per nexthop, but iproute currently only allows to send
a single route realm, which is refused by the kernel for multipath routes.
Add support for specifying per nexthop realms. Old kernels only return the
first realm back to
Hello!
gregkh-driver-network-class_device-to-device.patch, which briefly
appeared in Linux 2.6.18-rc1-mm1 broke MadWifi, which is copying the
physical device information from the master network device to the
virtual network devices:
SET_NETDEV_DEV(dev, mdev-class_dev.dev);
The same code exists
On Wed, 19 Jul 2006, Stephen Hemminger wrote:
This should fix the problem reported in
http://bugzilla.kernel.org/show_bug.cgi?id=6186
where the skb is used after freed. The code in IP multicast route.
Code was reusing an skb which could lead to use after free or double free.
On Mon, Jul 24, 2006 at 03:06:13PM -0700, David Miller ([EMAIL PROTECTED])
wrote:
Don't get too excited about VJ netchannels, more and more roadblocks
to their practicality are being found every day.
For example, my idea to allow ESTABLISHED TCP socket demux to be done
before netfilter is
60 matches
Mail list logo
