Re: [RFC] avoid unnecessary alignement overhead in skb->data allocation.

2006-08-07 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > > I don't know if I want to eat an entire extra allocation for every SKB > just to handle broken e1000 cards that can't be bothered to support > non-power-of-2 receive buffer sizes and a proper MTU setting. > > I guess we might have to, but this is extrem

Re: [RFC] avoid unnecessary alignement overhead in skb->data allocation.

2006-08-07 Thread Evgeniy Polyakov
On Mon, Aug 07, 2006 at 05:17:13PM +1000, Herbert Xu ([EMAIL PROTECTED]) wrote: > David Miller <[EMAIL PROTECTED]> wrote: > > > > I don't know if I want to eat an entire extra allocation for every SKB > > just to handle broken e1000 cards that can't be bothered to support > > non-power-of-2 receiv

Re: [RFC] avoid unnecessary alignement overhead in skb->data allocation.

2006-08-07 Thread Evgeniy Polyakov
On Mon, Aug 07, 2006 at 05:28:16PM +1000, Herbert Xu ([EMAIL PROTECTED]) wrote: > On Mon, Aug 07, 2006 at 11:24:23AM +0400, Evgeniy Polyakov wrote: > > > > > I'd hope not. Apparently they are capable of putting data into > > > individual pages and chaining them together. The only problem > > > >

Re: [RFC] avoid unnecessary alignement overhead in skb->data allocation.

2006-08-07 Thread Herbert Xu
On Mon, Aug 07, 2006 at 11:24:23AM +0400, Evgeniy Polyakov wrote: > > > I'd hope not. Apparently they are capable of putting data into > > individual pages and chaining them together. The only problem > > Unfortunately not all chips are capable to do this. No not all chips are capable of header

Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-08-07 Thread Wei Yongjun
I used tcb->end_seq instead of tcb->seq. And add a new condition 'tcb- seq == tcb->end_seq' to make ACK segment to be counted. On Sunday 06 August 2006 22:48, Herbert Xu wrote: > On Sun, Aug 06, 2006 at 07:44:47PM -0700, David Miller wrote: > > From: Herbert Xu <[EMAIL PROTECTED]> > > Date: Mon, 0

Re: [RFC] avoid unnecessary alignement overhead in skb->data allocation.

2006-08-07 Thread Herbert Xu
On Mon, Aug 07, 2006 at 11:31:03AM +0400, Evgeniy Polyakov wrote: > > Only if they form contiguous region? > Jesse, is it possible for every e1000 chip to split frame into several > page-sized chunks i.e. create some kind of receiving scatter-gather? Actually, it was Chris Leech who raised this p

Re: Packet reordering in pcap capture file

2006-08-07 Thread Alan Shieh
Stephen Hemminger wrote: On Sat, 05 Aug 2006 03:28:38 -0400 Alan Shieh <[EMAIL PROTECTED]> wrote: Hi everyone, I sometimes see packets stored out of order in pcap files that generated by "tcpdump -i any" on kernel 2.4.26 with all packets arriving and departing on an e1000 NIC. That is, the

Re: [RFC] avoid unnecessary alignement overhead in skb->data allocation.

2006-08-07 Thread Eric Dumazet
On Monday 07 August 2006 08:01, Evgeniy Polyakov wrote: > Hello. > > Attached patch allows to avoid unnecessary alignment overhead > in skb->data allocation. > Main idea is to allocate struct skb_shared_info from cache when > addition of sizeof(struct skb_shared_info) ens up in different order > al

Re: [RFC] avoid unnecessary alignement overhead in skb->data allocation.

2006-08-07 Thread Evgeniy Polyakov
On Mon, Aug 07, 2006 at 10:05:57AM +0200, Eric Dumazet ([EMAIL PROTECTED]) wrote: > > + if ((1UL << order) > size + sizeof(void *) + sizeof(struct > > skb_shared_info)) { + data = kmalloc(size + sizeof(struct > > skb_shared_info), gfp_mask); + if (!data) > > +

Re: [patch] RFC: matching interface groups

2006-08-07 Thread Balazs Scheidler
On Fri, 2006-08-04 at 12:06 +0200, Patrick McHardy wrote: > Balazs Scheidler wrote: > > The use-case is as follows: > > > > * I have two different subsystems creating interfaces dynamically (for > > example pptpd and serial pppd lines, each creating dynamic pppX > > interfaces), > > * I would like

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread jamal
On Sun, 2006-06-08 at 16:16 -0700, Jesse Brandeburg wrote: [..] > > As for specifics, for TX_WAKE_THRESHOLD, i noticed that we were > starting the queue after every packet was cleaned, so when the ring > went full there was a lot of queue thrash. indeed this is what used to happen and was bad

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Edgar E. Iglesias
On Mon, Aug 07, 2006 at 08:50:36AM -0400, jamal wrote: > On Sun, 2006-06-08 at 16:16 -0700, Jesse Brandeburg wrote: > [..] > > > > As for specifics, for TX_WAKE_THRESHOLD, i noticed that we were > > starting the queue after every packet was cleaned, so when the ring > > went full there was a lot o

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread jamal
On Mon, 2006-07-08 at 17:21 +0200, Edgar E. Iglesias wrote: [..] > I have a question regarding your patch. In clean_tx_irq, it seems you dont > clean the ring unless fdesc < tx_ring->prunet. Won't this cause deadlocks for > local TCP connections if transmit goes quiet? > I have not tested the TC

forcedeth gigabit detection

2006-08-07 Thread Frank v Waveren
(sorry about sending this to you twice Carl-Daniel, I sent this to @oss.sgi.com by accident) The nforce2 builtin network on my A7N8X-delux motherboard won't detect as gigabit-capable using the forcedeth driver. I'm using the forcedeth driver that comes with linux 2.6.17 (which is 0.54). Ethtool

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Edgar E. Iglesias
On Mon, Aug 07, 2006 at 11:40:49AM -0400, jamal wrote: > > On Mon, 2006-07-08 at 17:21 +0200, Edgar E. Iglesias wrote: > [..] > > I have a question regarding your patch. In clean_tx_irq, it seems you dont > > clean the ring unless fdesc < tx_ring->prunet. Won't this cause deadlocks > > for > > lo

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Jamal Hadi Salim
On Mon, 2006-07-08 at 17:59 +0200, Edgar E. Iglesias wrote: > Ok, I thought you wanted the code inside the ifdefs to be considered. If not, > I guess there is no problem. Yes, the forwarding case does not suffer from > any deadlocks issues that I am aware of. > >From my tests: It does _not_ prov

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Edgar E. Iglesias
On Mon, Aug 07, 2006 at 11:40:49AM -0400, jamal wrote: > > On Mon, 2006-07-08 at 17:21 +0200, Edgar E. Iglesias wrote: > [..] > > I have a question regarding your patch. In clean_tx_irq, it seems you dont > > clean the ring unless fdesc < tx_ring->prunet. Won't this cause deadlocks > > for > > lo

Re: [PATCH] limit rt cache size

2006-08-07 Thread Alexey Kuznetsov
Hello! > During OpenVZ stress testing we found that UDP traffic with > random src can generate too much excessive rt hash growing > leading finally to OOM and kernel panics. > > It was found that for 4GB i686 system (having 1048576 total pages and > 225280 normal zone pages) kernel allocates the

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Edgar E. Iglesias
On Mon, Aug 07, 2006 at 12:31:59PM -0400, Jamal Hadi Salim wrote: > On Mon, 2006-07-08 at 17:59 +0200, Edgar E. Iglesias wrote: > > > Ok, I thought you wanted the code inside the ifdefs to be considered. If > > not, > > I guess there is no problem. Yes, the forwarding case does not suffer from >

[PATCH 1/7] [NEIGH]: Convert neighbour deletion to new netlink api

2006-08-07 Thread Thomas Graf
Fixes: Return ENOENT if the neighbour is not found (was EINVAL) Return EAFNOSUPPORT if no table matches the specified address family. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/core/neighbour.c ===

[PATCHSET] Convert neighbour code to new netlink api

2006-08-07 Thread Thomas Graf
Pretty much straight forward, some minor fixes that go along with it. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/7] [NEIGH]: Convert neighbour addition to new netlink api

2006-08-07 Thread Thomas Graf
Fixes: Return EAFNOSUPPORT if no table matches the specified address family. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/core/neighbour.c === --- net-2.6.19.git.orig/net/core/neighbour.c +++ net-2

[PATCH 3/7] [NEIGH]: Convert neighbour dumping to new netlink api

2006-08-07 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/core/neighbour.c === --- net-2.6.19.git.orig/net/core/neighbour.c +++ net-2.6.19.git/net/core/neighbour.c @@ -1898,48 +1898,49 @@ out: return skb->len;

[PATCH 4/7] [NEIGH]: Move netlink neighbour bits to linux/neighbour.h

2006-08-07 Thread Thomas Graf
Moves netlink neighbour bits to linux/neighbour.h. Also moves bits to be exported to userspace from net/neighbour.h to linux/neighbour.h and removes __KERNEL__ guards, userspace is not supposed to be using it. rtnetlink_rcv_msg() is not longer required to parse attributes for the neighbour layer,

[PATCH 5/7] [NEIGH]: Convert neighbour table modification to new netlink api

2006-08-07 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/core/neighbour.c === --- net-2.6.19.git.orig/net/core/neighbour.c +++ net-2.6.19.git/net/core/neighbour.c @@ -1751,28 +1751,61 @@ static inline struct neigh_parm

[PATCH 6/7] [NEIGH]: Convert neighbour table dumping to new netlink api

2006-08-07 Thread Thomas Graf
Also fixes skipping of already dumped neighbours. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/core/neighbour.c === --- net-2.6.19.git.orig/net/core/neighbour.c +++ net-2.6.19.git/net/core/neighbour.c @@ -

[PATCH 7/7] [NEIGH]: Move netlink neighbour table bits to linux/neighbour.h

2006-08-07 Thread Thomas Graf
rtnetlink_rcv_msg() is not longer required to parse attributes for the neighbour tables layer, remove dependency on obsolete and buggy rta_buf. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/include/linux/neighbour.h ==

Re: [PATCH wireless-dev] d80211: Switch d80211_mgmt.h to ieee80211.h style definitions

2006-08-07 Thread Jouni Malinen
On Sat, Aug 05, 2006 at 01:45:33AM -0700, Michael Wu wrote: > d80211: Switch d80211_mgmt.h to ieee80211.h style definitions > > This patch switches a number of defines in d80211_mgmt.h to enums taken from > ieee80211.h and makes the corresponding changes in net/d80211. > include/net/d80211_mgmt

Re: 802.11/crypto questions

2006-08-07 Thread Jouni Malinen
On Tue, Aug 01, 2006 at 07:40:52AM +0200, Johannes Berg wrote: > Since there's been lots of talk about multi-STA or multi-BSSID devices > (more than one client, more than one AP on the same PHY) and I was just > looking into some crypto stuff on bcm43xx, it got me wondering. > > The bcm43xx has a

[-mm patch] net/: make code static

2006-08-07 Thread Adrian Bunk
This patch makes needlessly global code static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- BTW: It doesn't seem to be intended that the new ipv4/fib_rules.c:fib4_rules_cleanup() is completely unused? include/net/ip6_fib.h |4 net/ipv4/cipso_ipv4.c |

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread jamal
On Mon, 2006-07-08 at 18:29 +0200, Edgar E. Iglesias wrote: > Assuming you would get the code inside the jamal ifdefs working without > deadlocks, you now have a tx_irq function which if fdesc >= tx_ring->prunet > essentially just checks for hw lockups. Let's speculate and further assume you > cou

Re: [Fwd: [IPROUTE2]: Explicit BNF definition for actions]

2006-08-07 Thread Stephen Hemminger
On Sat, 05 Aug 2006 12:42:35 -0400 jamal <[EMAIL PROTECTED]> wrote: > > Stephen, > > This is the one after the last one you responded to. Your git tree is > not uptodate so i cant tell if you are missing it or not ;-> > > I dont think i will be making more updates for this release - more to > c

Re: [PATCH 9/9] [NET]: Move netlink interface bits to linux/if.h

2006-08-07 Thread Stephen Hemminger
On Fri, 04 Aug 2006 23:23:14 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Sat, 05 Aug 2006 22:42:18 -0700 > > > Thomas Graf wrote: > > > -/* The struct should be in sync with struct net_device_stats */ > > > -struct rtnl_link_stats > >

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread jamal
On Mon, 2006-07-08 at 19:04 +0200, Edgar E. Iglesias wrote: > > I'll give you an example. Thanks - that matches my understanding. > A TCP flow sends X data and later waits for a response, host is now quietly > waiting. Assume fdesc >= tx_ring->prunet, so we dont free any skbs, right? > I am h

[PATCH] tiacx sparse cleanups

2006-08-07 Thread Randy.Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> tiacx sparse cleanups: - use NULL instead of 0 for pointer value - use C99 struct initializers - use ANSI function declaration Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/net/wireless/tiacx/common.c |2 drivers/net/wireless/tiacx/ioctl.

Re: [Fwd: [IPROUTE2]: Explicit BNF definition for actions]

2006-08-07 Thread jamal
On Mon, 2006-07-08 at 10:49 -0700, Stephen Hemminger wrote: > I needed to merge the branch in, the git tree is now up to date. I have never gathered the energy to figure that stuff out so i dont envy you. In any case, seems to be missing the majority of the patches i sent, including this one who

Re: [PATCH wireless-dev] d80211: Switch d80211_mgmt.h to ieee80211.h style definitions

2006-08-07 Thread Michael Wu
On Monday 07 August 2006 10:20, Jouni Malinen wrote: > Changing WLAN_STATUS_* and WLAN_REASON_* to be enum's while keeping > their old names is fine. However, I would rather not change the names of > the information element IDs (WLAN_EID_*) into MFIE_TYPE_*. What is that > 'MFIE' anyway? Management

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Edgar E. Iglesias
On Mon, Aug 07, 2006 at 02:00:24PM -0400, jamal wrote: > On Mon, 2006-07-08 at 19:04 +0200, Edgar E. Iglesias wrote: > > > > > I'll give you an example. > > Thanks - that matches my understanding. > > > A TCP flow sends X data and later waits for a response, host is now quietly > > waiting. Ass

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread jamal
On Mon, 2006-07-08 at 20:47 +0200, Edgar E. Iglesias wrote: > I think we are out of sync :) Imagine that, eh? ;-> > My, fault I haven't been clear enough. > Not just your transmit but also my receive is at fault ;-> (aka, I may not be listening as well as i should). Now two machines or CPUs y

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Edgar E. Iglesias
On Mon, Aug 07, 2006 at 03:03:33PM -0400, jamal wrote: > On Mon, 2006-07-08 at 20:47 +0200, Edgar E. Iglesias wrote: > > > I think we are out of sync :) > > Imagine that, eh? ;-> > > > My, fault I haven't been clear enough. > > > > Not just your transmit but also my receive is at fault ;-> (a

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread jamal
On Mon, 2006-07-08 at 21:14 +0200, Edgar E. Iglesias wrote: > > If yes, what is the likelihood they will sit there forever? I think > > perhaps some TX interupts will happen, no? > > with jamal undefined, absolutely. With jamal defined, TX interrupts will come > but I couldnt find a way into e100

[PATCH]: e1000: Janitor: Use #defined values for literals

2006-08-07 Thread Linas Vepstas
Resending patch from 23 June 2006; there was some confusion about whether a similar patch had already been applied; seems it wasn't. Minor janitorial patch: use #defines for literal values. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/e1000/e1000_main.c |4 ++-- 1 file

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-08-07 Thread Auke Kok
Linas Vepstas wrote: Resending patch from 23 June 2006; there was some confusion about whether a similar patch had already been applied; seems it wasn't. Minor janitorial patch: use #defines for literal values. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Acked-by: Auke Kok <[EMAIL PROTEC

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-08-07 Thread Jeff Garzik
hopefully queued-by, as well... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Edgar E. Iglesias
On Mon, Aug 07, 2006 at 03:34:30PM -0400, jamal wrote: > On Mon, 2006-07-08 at 21:14 +0200, Edgar E. Iglesias wrote: > > > > If yes, what is the likelihood they will sit there forever? I think > > > perhaps some TX interupts will happen, no? > > > > with jamal undefined, absolutely. With jamal de

Excess use of packed attribute

2006-08-07 Thread Stephen Hemminger
After reading: http://bugzilla.kernel.org/show_bug.cgi?id=6693 I noticed there were stupid uses of packed attribute in several network headers. Silly offenders:include/net/ipx.h include/net/ieee80211.h include/net/ip6_tunnel.h

[PATCH 0/9] tulip patches from parisc-linux

2006-08-07 Thread Kyle McMartin
[Val asked that I split this out, instead of just publishing a git tree, so here goes nothing. I don't think I've ever used git-send-email before, but hopefully I won't screw up too badly.] The following patch series brings the mainline tulip driver in synch with the modifications made in parisc-l

Reboot-Shutdown signal through net device.

2006-08-07 Thread moto
Within our PCI Network Device there is a special feature, that allows out-of-band signaling-messeging (by using special interrupt and shared registers) to control system state: Reboot, Shutdown. What would be an acceptable method of executing such controls? So, the sequence is: 1. Device Driv

[PATCH] ipx: header length validation needed

2006-08-07 Thread Stephen Hemminger
IPX is not checking for non-linear (and short packets) in it's receive routine. This is serious because it may mean it ends up reading past end of skb. This maybe related to this bug, because sky2 will copy small packets into small skb's. http://bugzilla.kernel.org/show_bug.cgi?id=6693 Signe

[PATCH 1/9] [TULIP] Fix PHY init and reset

2006-08-07 Thread Kyle McMartin
From: Grant Grundler <[EMAIL PROTECTED]> A whole slew of fixes for tulip_select_media for: - Flush posted MMIO writes as per PCI spec - Polling the reset bit (bit 15) is required to determine when the "init" sequence can be sent. This fixes tulip on HP PA-RISC systems, which use DP83840A and

[PATCH 7/9] [TULIP] Defer tulip_select_media() to process context

2006-08-07 Thread Kyle McMartin
From: Francois Romieu <[EMAIL PROTECTED]> Move tulip_select_media() processing to a workqueue, instead of delaying in interrupt context. [Edit by Kyle to use kevent thread, instead of creating its own workqueue.] Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> --- drivers/net/tulip/21142.c

[PATCH 9/9] [TULIP] Fix section mismatch in de2104x.c

2006-08-07 Thread Kyle McMartin
From: Helge Deller <[EMAIL PROTECTED]> WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to .init.text:de_init_one from .data.rel.local after 'de_driver' (at offset 0x20) WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to .exit.text:de_remove_one from .data.re

[PATCH 3/9] [TULIP] Make tulip_stop_rxtx() failure case slightly more informative

2006-08-07 Thread Kyle McMartin
From: Grant Grundler <[EMAIL PROTECTED]> Signed-off-by: Grant Grundler <[EMAIL PROTECTED]> Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> --- drivers/net/tulip/tulip.h |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/tulip/tulip.h b/drivers/net/tulip/tu

[PATCH 5/9] [TULIP] Flush MMIO writes in reset sequence

2006-08-07 Thread Kyle McMartin
From: Grant Grundler <[EMAIL PROTECTED]> The obvious safe registers to read is one from PCI config space. Signed-off-by: Grant Grundler <[EMAIL PROTECTED]> Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> --- drivers/net/tulip/tulip_core.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

[PATCH 6/9] [TULIP] Fix IRQ/DMA race

2006-08-07 Thread Kyle McMartin
From: Grant Grundler <[EMAIL PROTECTED]> IRQs are racing with tulip_down(). DMA can be restarted by tulip_interrupt() _after_ we call tulip_stop_rxtx() and the DMA buffers are unmapped. The result is an MCA (hard crash on ia64) because of an IO TLB miss. Signed-off-by: Grant Grundler <[EMAIL PRO

[PATCH 8/9] [TULIP] Make DS21143 printout match lspci output

2006-08-07 Thread Kyle McMartin
From: Thibaut Varene <[EMAIL PROTECTED]> Signed-off-by: Thibaut Varene <[EMAIL PROTECTED]> Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> --- drivers/net/tulip/tulip_core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tul

[PATCH 4/9] [TULIP] Clean tulip.h so it can be used by winbond-840.c

2006-08-07 Thread Kyle McMartin
From: Grant Grundler <[EMAIL PROTECTED]> Include "tulip.h" in winbond-840.c and clean up lots of redundant definitions. Signed-off-by: Grant Grundler <[EMAIL PROTECTED]> Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> --- drivers/net/tulip/tulip.h | 17 ++ drivers/net/tulip/tuli

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Brandeburg, Jesse
On Mon, 7 Aug 2006, jamal wrote: > -#define E1000_TX_WEIGHT 64 > - /* weight of a sort for tx, to avoid endless transmit > cleanup */ > - if (count++ == E1000_TX_WEIGHT) break; > + /* avoid endless transmit cleanup */ > + if (count++ == tx_rin

[PATCH 2/9] [TULIP] Print physical address in tulip_init_one

2006-08-07 Thread Kyle McMartin
From: Grant Grundler <[EMAIL PROTECTED]> As the cookie returned by pci_iomap() is fairly useless... Signed-off-by: Grant Grundler <[EMAIL PROTECTED]> Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> --- drivers/net/tulip/tulip_core.c | 10 -- 1 files changed, 8 insertions(+), 2 deletio

Re: forcedeth gigabit detection

2006-08-07 Thread Krzysztof Halasa
Frank v Waveren <[EMAIL PROTECTED]> writes: > The nforce2 builtin network on my A7N8X-delux motherboard won't detect > as gigabit-capable using the forcedeth driver. Asustek doesn't seem to indicate it has gigabit ports, are you sure your mb does have them? Perhaps it's a different version, some

[PATCH] Replace pci_module_init with pci_register_driver in drivers/net

2006-08-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/3c59x.c |2 +- drivers/net/8139cp.c |2 +- drivers/net/8139too.c |2 +- drivers/net/acenic.c |2 +- drivers/net/amd8111e.c

[RFC: -mm patch] bcm43xx_main.c: remove 3 functions

2006-08-07 Thread Adrian Bunk
This patch removes three no longer used functions (that are even generating gcc warnings). This patch doesn't look right, but it is the result of 58e5528ee464d38040b9489e10033c9387a10d56 in git-netdev... Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/wireless/bcm43xx/bcm43xx_

Re: forcedeth gigabit detection

2006-08-07 Thread Frank v Waveren
You know, I suddenly feel very foolish. Sorry for having wasted everyone's time, and thanks for your keen eye. On Tue, Aug 08, 2006 at 12:19:24AM +0200, Krzysztof Halasa wrote: > Frank v Waveren <[EMAIL PROTECTED]> writes: > > > The nforce2 builtin network on my A7N8X-delux motherboard won't dete

Re: [PATCH] fix alloc_skb comment typo

2006-08-07 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sat, 5 Aug 2006 14:59:06 +0200 > Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Applied, thanks Christoph. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info

tg3: tg3_stop_block timed out

2006-08-07 Thread Bernd Schubert
Hi, I have seen a few reports like this, but now broadcom seems to actively support tg3, so I decided to send this. ... [many hamilton not responding messages] 4554928.798000] nfs: server hamilton not responding, still trying [4554935.319000] nfs: server hamilton not responding, still trying [455

[PATCH RESEND 1/2] in-kernel sockets API

2006-08-07 Thread Sridhar Samudrala
Dave, Could you consider this for inclusion into 2.6.19 tree? Thanks Sridhar This patch implements wrapper functions that provide a convenient way to access the sockets API for in-kernel users like sunrpc, cifs & ocfs2 etc and any future users. Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED

[PATCH RESEND 2/2] update sunrpc to use in-kernel sockets API

2006-08-07 Thread Sridhar Samudrala
Update sunrpc to use in-kernel sockets API. Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> --- net/sunrpc/svcsock.c | 38 ++ net/sunrpc/xprtsock.c |8 2 files changed, 18 insertions(+), 28 delet

Re: tg3: tg3_stop_block timed out

2006-08-07 Thread Michael Chan
On Tue, 2006-08-08 at 00:43 +0200, Bernd Schubert wrote: > Hi, > > I have seen a few reports like this, but now broadcom seems to actively > support tg3, so I decided to send this. > > ... [many hamilton not responding messages] > 4554928.798000] nfs: server hamilton not responding, still trying

Re: [PATCH] move skb->dev assignment into netdev_alloc_skb

2006-08-07 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sat, 5 Aug 2006 15:01:09 +0200 > All caller of netdev_alloc_skb need to assign skb->dev shortly > afterwards. Move it into common code. > > I also had to fixup a little bit of the surrounding control flow in > e1000 - it was just too convoluted.

Re: Excess use of packed attribute

2006-08-07 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 7 Aug 2006 13:34:23 -0700 > Silly offenders: include/net/ipx.h > include/net/ieee80211.h > include/net/ip6_tunnel.h > include/net/ndisc.h > include/li

Re: [PATCH RESEND 1/2] in-kernel sockets API

2006-08-07 Thread Stephen Hemminger
On Mon, 07 Aug 2006 16:00:29 -0700 Sridhar Samudrala <[EMAIL PROTECTED]> wrote: > Dave, > > Could you consider this for inclusion into 2.6.19 tree? > > Thanks > Sridhar > > This patch implements wrapper functions that provide a convenient way to > access the sockets API for in-kernel users like

[PATCH wireless-dev 2/6] d80211: Fix PS-Poll frame dropping

2006-08-07 Thread Jouni Malinen
Fixed PS-Poll processing for STAs that are not authenticated or associated: - 80211.ko dropped these frames even though it should have sent them to hostapd (this was broken by addition of IBSS support) Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c =

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Herbert Xu
On Mon, Aug 07, 2006 at 03:03:33PM -0400, jamal wrote: > > -#define E1000_TX_WEIGHT 64 > - /* weight of a sort for tx, to avoid endless transmit > cleanup */ > - if (count++ == E1000_TX_WEIGHT) break; > + /* avoid endless transmit cleanup */ > +

Re: [PATCH] ipx: header length validation needed

2006-08-07 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 7 Aug 2006 13:46:36 -0700 > IPX is not checking for non-linear (and short packets) in it's > receive routine. This is serious because it may mean it ends up > reading past end of skb. This takes care of ipx_rcv() but the rest of the IPX prot

[PATCH wireless-dev 3/6] d80211: Fix PLCP header length comment

2006-08-07 Thread Jouni Malinen
Fixed a typo in a comment: PLCP header length is in microseconds, not milliseconds. Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c === --- wireless-dev.orig/net/d80211/ieee80211.c +++ wire

[PATCH wireless-dev 4/6] d80211: Send Layer 2 Update frames in kernel

2006-08-07 Thread Jouni Malinen
Send Layer 2 Update frame from the 802.11 code in kernel to the netdev that the STA is bound to. If the STA is bound to another VLAN netdev, send another update frame. This fixes an issue in which a local bridge table was not updated when hostapd sent this frame. Signed-off-by: Jouni Malinen <[EMA

[PATCH wireless-dev 6/6] d80211: Fix TKIP replay protection

2006-08-07 Thread Jouni Malinen
Fixed TKIP replay protection for the case where hwaccel is enabled. rx_initialized flag was not set in this case and the TSC validation was skipped for the frames. Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/tkip.c ==

Re: tg3: tg3_stop_block timed out

2006-08-07 Thread Bernd Schubert
Hi Michael, thanks for your help! On Tuesday 08 August 2006 01:07, Michael Chan wrote: > > ... [many hamilton not responding messages] > > 4554928.798000] nfs: server hamilton not responding, still trying > > [4554935.319000] nfs: server hamilton not responding, still trying > > [4555468.94]

[PATCH wireless-dev 0/6] Set of small fixes to net/d80211

2006-08-07 Thread Jouni Malinen
Here's a set of small fixes to net/d80211 from the Devicescape tree. Please consider applying. -- -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majo

[PATCH wireless-dev 1/6] d80211: Fix RTS threshold use

2006-08-07 Thread Jouni Malinen
Fixed dot11RTSThreshold use which was off-by-3: - must add FCS_LEN to the skb->len - frame length needs to be greater than threshold; not greater than or equal Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c ===

[PATCH wireless-dev 5/6] d80211: Fix ieee80211_remove_tx_extra() if key not configured

2006-08-07 Thread Jouni Malinen
QoS header processing mangled unencrypted WMM frames on software retry. The QoS data needs to be removed even when encryption key is not configured. Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c

Re: [PATCH] ipx: header length validation needed

2006-08-07 Thread Stephen Hemminger
This patch will linearize and check there is enough data. It handles the pprop case as well as avoiding a whole audit of the routing code. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipx/af_ipx.c 2006-08-07 13:45:59.0 -0700 +++ b/net/ipx/af_ipx.c 2006-08-07 16:34:00.0

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Brandeburg, Jesse
On Tue, 8 Aug 2006, Herbert Xu wrote: > > -#define E1000_TX_WEIGHT 64 > > - /* weight of a sort for tx, to avoid endless transmit > > cleanup */ > > - if (count++ == E1000_TX_WEIGHT) break; > > + /* avoid endless transmit cleanup */ > > + if (

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread Herbert Xu
On Mon, Aug 07, 2006 at 04:35:36PM -0700, Brandeburg, Jesse wrote: > > e1000 only clears the interrupts when it reads ICR in e1000_intr (before > scheduling napi poll) so any interrupts that occur while polling (and > interrupts are disabled) will cause a new assertion once interrupts are > re-

Re: tg3: tg3_stop_block timed out

2006-08-07 Thread Michael Chan
On Tue, 2006-08-08 at 01:24 +0200, Bernd Schubert wrote: > > tg3.c:v3.49 (Feb 2, 2006) > acpi_bus-0201 [01] bus_set_power : Device is not power manageable > eth1: Tigon3 [partno(BCM95704A6) rev 2003 PHY(5704)] (PCIX:100MHz:64-bit) > 10/100/1000BaseT Ethernet 00:e0:81:2b:aa:28 > eth1: RXc

Re: Excess use of packed attribute

2006-08-07 Thread Sridhar Samudrala
On Mon, 2006-08-07 at 13:34 -0700, Stephen Hemminger wrote: > After reading: > http://bugzilla.kernel.org/show_bug.cgi?id=6693 > > I noticed there were stupid uses of packed attribute in several network > headers. > > Silly offenders: include/net/ipx.h > include/

Re: [RFC] avoid unnecessary alignement overhead in skb->data allocation.

2006-08-07 Thread Jesse Brandeburg
On 8/7/06, Herbert Xu <[EMAIL PROTECTED]> wrote: On Mon, Aug 07, 2006 at 11:31:03AM +0400, Evgeniy Polyakov wrote: > > Only if they form contiguous region? > Jesse, is it possible for every e1000 chip to split frame into several > page-sized chunks i.e. create some kind of receiving scatter-gathe

[PATCH 2/3] FS_ENET: use PAL for mii management

2006-08-07 Thread Vitaly Bordug
This patch should update the fs_enet infrastructure to utilize Phy Abstraction Layer subsystem. Along with the abouve, there are apparent bugfixes, rehaul and improvements. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- drivers/net/fs_enet/Makefile |6 drivers/net/fs_enet/fec.h

[PATCH 1/3] PAL: Support of the fixed PHY

2006-08-07 Thread Vitaly Bordug
This makes it possible for HW PHY-less boards to utilize PAL goodies. Generic routines to connect to fixed PHY are provided, as well as ability to specify software callback that fills up link, speed, etc. information into PHY descriptor (the latter feature not tested so far). Signed-off-by: Vital

[PATCH 3/3] ppc32: board-specific part of fs_enet update

2006-08-07 Thread Vitaly Bordug
This contains board-specific portion to respect driver changes (for 8272ads , 885ads and 866ads). Altered platform_data structures as well as initial setup routines relevant to fs_enet. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- arch/ppc/platforms/85xx/mpc8560_ads.c| 89

[PATCH 0/3] FS_ENET: move to the PAL api

2006-08-07 Thread Vitaly Bordug
These are patches, that utilize Phy Abstraction Layer API in the fs_enet Freescale SoC Ethernet driver. Comments gavered from the community addressed, + minor fixes and improvements. -- Sincerely, Vitaly - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message t

[PATCH 2/3] FS_ENET: use PAL for mii management

2006-08-07 Thread Vitaly Bordug
This patch should update the fs_enet infrastructure to utilize Phy Abstraction Layer subsystem. Along with the above, there are apparent bugfixes, overhaul and improvements. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- drivers/net/fs_enet/Makefile |6 drivers/net/fs_enet/fec.

[PATCH 1/3] PAL: Support of the fixed PHY

2006-08-07 Thread Vitaly Bordug
This makes it possible for HW PHY-less boards to utilize PAL goodies. Generic routines to connect to fixed PHY are provided, as well as ability to specify software callback that fills up link, speed, etc. information into PHY descriptor (the latter feature not tested so far). Signed-off-by: Vital

[PATCH 3/3] ppc32: board-specific part of fs_enet update

2006-08-07 Thread Vitaly Bordug
This contains board-specific portion to respect driver changes (for 8272ads , 885ads and 866ads). Altered platform_data structures as well as initial setup routines relevant to fs_enet. Changes to the mpc8560ads ppc/ code are also introduced, but mainly as reference, since the entire board suppor

Re: [PATCH] move skb->dev assignment into netdev_alloc_skb

2006-08-07 Thread Jesse Brandeburg
On 8/7/06, David Miller <[EMAIL PROTECTED]> wrote: From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sat, 5 Aug 2006 15:01:09 +0200 > All caller of netdev_alloc_skb need to assign skb->dev shortly > afterwards. Move it into common code. > > I also had to fixup a little bit of the surrounding co

Re: [PATCH] Replace pci_module_init with pci_register_driver in drivers/net

2006-08-07 Thread Jesse Brandeburg
On 8/7/06, Pavel Roskin <[EMAIL PROTECTED]> wrote: - pci_rc = pci_module_init(&vortex_driver); + pci_rc = pci_register_driver(&vortex_driver); eisa_rc = vortex_eisa_init(); not sure why this *function name change* really matters, but technically I'm okay with the e100/e1000/

Re: Excess use of packed attribute

2006-08-07 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Mon, 07 Aug 2006 17:02:08 -0700 > All the structures in sctp.h that use packed atrribute define > standard on-wire SCTP chunk/parameter formats. They need to be at the > exact offsets as they go on wire. > I think we saw some issues without the pac

Re: [RFC] avoid unnecessary alignement overhead in skb->data allocation.

2006-08-07 Thread David Miller
From: "Jesse Brandeburg" <[EMAIL PROTECTED]> Date: Mon, 7 Aug 2006 17:09:39 -0700 > also, eth_type_trans wants skb->data to point to header, which would > require us to memcpy data from a page back to skb->data. You merely would need to call pskb_may_pull() right before invoking eth_type_trans.

Re: [PATCH RESEND 1/2] in-kernel sockets API

2006-08-07 Thread Sridhar Samudrala
On Mon, 2006-08-07 at 16:20 -0700, Stephen Hemminger wrote: > On Mon, 07 Aug 2006 16:00:29 -0700 > Sridhar Samudrala <[EMAIL PROTECTED]> wrote: > > > Dave, > > > > Could you consider this for inclusion into 2.6.19 tree? > > > > Thanks > > Sridhar > > > > This patch implements wrapper functions

Re: [PATCH] [e1000]: Remove unnecessary tx_lock

2006-08-07 Thread jamal
On Mon, 2006-07-08 at 22:28 +0200, Edgar E. Iglesias wrote: > > I can see two calls to e1000_prune_tx_ring with jamal _defined_. > Ok, never mind - I think thats the source of our confusion. Just ignore those entries since they are ifdefed out (The second one i dont know how it made it in since

  1   2   >