Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > > furthermore, the tweak allows the shifting of processing from a > > prioritized process context into a highest-priority softirq context. > > (it's not proven that there is any significant /net win/ of > > performance: all that was proven is that if

Re: pktgen

2006-11-29 Thread Alexey Dobriyan
On 11/30/06, David Miller <[EMAIL PROTECTED]> wrote: From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Wed, 29 Nov 2006 23:04:37 +0300 > Looks like worker thread strategically clears it if scheduled at wrong > moment. > > --- a/net/core/pktgen.c > +++ b/net/core/pktgen.c > @@ -3292,7 +3292,6 @@ st

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Thu, 30 Nov 2006 07:47:58 +0100 > furthermore, the tweak allows the shifting of processing from a > prioritized process context into a highest-priority softirq context. > (it's not proven that there is any significant /net win/ of performance: > all t

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > This is why my suggestion is to preempt_disable() as soon as we grab > the socket lock, [...] independently of the issue at hand, in general the explicit use of preempt_disable() in non-infrastructure code is quite a heavy tool. Its effects are heav

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > > yeah, i like this one. If the problem is "too long locked section", > > then the most natural solution is to "break up the lock", not to > > "boost the priority of the lock-holding task" (which is what the > > proposed patch does). > > Ingo you're

Re: Bug 7596 - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > > Attached is the detailed description of the problem and one possible > > solution. > > Thanks. The attachment will be too large for the mailing-list servers > so I uploaded a copy to > http://userweb.kernel.org/~akpm/Linux-TCP-Bottleneck-Analysi

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Thu, 30 Nov 2006 07:17:58 +0100 > > * David Miller <[EMAIL PROTECTED]> wrote: > > > We can make explicitl preemption checks in the main loop of > > tcp_recvmsg(), and release the socket and run the backlog if > > need_resched() is TRUE. > > > > This

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Ingo Molnar
* Wenji Wu <[EMAIL PROTECTED]> wrote: > > That yield() will need to be removed - yield()'s behaviour is truly > > awfulif the system is otherwise busy. What is it there for? > > Please read the uploaded paper, which has detailed description. do you have any URL for that? Ingo - To un

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > We can make explicitl preemption checks in the main loop of > tcp_recvmsg(), and release the socket and run the backlog if > need_resched() is TRUE. > > This is the simplest and most elegant solution to this problem. yeah, i like this one. If the pr

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Mike Galbraith
On Wed, 2006-11-29 at 17:08 -0800, Andrew Morton wrote: > + if (p->backlog_flag == 0) { > + if (!TASK_INTERACTIVE(p) || expired_starving(rq)) { > + enqueue_task(p, rq->expired); > + if (p->static_prio < rq->best

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread Michael Renzmann
Hi. Michael Buesch wrote: IIRC Pavel already explained that getting rid of the HAL per se should be no problem - it could easily be dissolved into the driver, if that is one of the requirements to be fulfilled before the driver (MadWifi or DadWifi) is considered for mainline inclusion. As soon a

Re: Linux 2.6.19

2006-11-29 Thread Phil Oester
On Wed, Nov 29, 2006 at 06:15:37PM -0800, David Miller wrote: > In fact it does, the NDISC code is using MAX_HEADER incorrectly. It > needs to explicitly allocate space for the struct ipv6hdr in 'len'. > Luckily the TCP ipv6 code was doing it right. > > What a horrible bug, this patch should fix

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-29 Thread Andrew Morton
On Thu, 30 Nov 2006 02:04:15 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > > git-netdev-all.patch > > > git-netdev-all-fixup.patch > > > libphy-dont-do-that.patch > > > > Are you able to eliminate libphy-dont-do-that.patch? > > > > > Is a broken-out version of git-netdev-all.pa

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread David Miller
From: Wenji Wu <[EMAIL PROTECTED]> Date: Wed, 29 Nov 2006 19:56:58 -0600 > >We could also pepper tcp_recvmsg() with some very carefully placed > >preemption disable/enable calls to deal with this even with > >CONFIG_PREEMPT enabled. > > I also think about this approach. But since the "problem" hap

Re: Linux 2.6.19

2006-11-29 Thread David Miller
From: Phil Oester <[EMAIL PROTECTED]> Date: Wed, 29 Nov 2006 17:49:04 -0800 > Getting an oops on boot here, caused by commit > e81c73596704793e73e6dbb478f41686f15a4b34 titled > "[NET]: Fix MAX_HEADER setting". > > Reverting that patch fixes things up for me. Dave? I suspect that it might be bec

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Wenji Wu
> That yield() will need to be removed - yield()'s behaviour is truly > awfulif the system is otherwise busy. What is it there for? Please read the uploaded paper, which has detailed description. thanks, wenji - Original Message - From: Andrew Morton <[EMAIL PROTECTED]> Date: Wednesda

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Wenji Wu
Yes, when CONFIG_PREEMPT is disabled, the "problem" won't happen. That is why I put "for 2.6 desktop, low-latency desktop" in the uploaded paper. This "problem" happens in the 2.6 Desktop and Low-latency Desktop. >We could also pepper tcp_recvmsg() with some very carefully placed preemption >di

Re: [PATCH][IPSEC][3/7] inter address family ipsec tunnel

2006-11-29 Thread Kazunori MIYAZAWA
Hello, I found a bug in my previous patch for af_key. The patch breaks transport mode. This is a fixed version. Signed-off-by: Miika Komu <[EMAIL PROTECTED]> Signed-off-by: Diego Beltrami <[EMAIL PROTECTED]> Signed-off-by: Kazunori Miyazawa <[EMAIL PROTECTED]> diff --git a/net/key/af_key.c b/net

Re: [PATCH] [IPVS] transparent proxying

2006-11-29 Thread home_king
hi, Wensong. Thanks for your appraise. > I see that this patch probably makes IPVS code a bit complicated and > packet traversing less efficiently. In my opinion, worry about the side-effect to the packet throughput is not necessary. First, normal packets with mark rarely appear in the NF_IP_FO

Re: pktgen

2006-11-29 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Wed, 29 Nov 2006 23:04:37 +0300 > Looks like worker thread strategically clears it if scheduled at wrong > moment. > > --- a/net/core/pktgen.c > +++ b/net/core/pktgen.c > @@ -3292,7 +3292,6 @@ static void pktgen_thread_worker(struct > > init

Re: [NET_SCHED 07/06]: Fix endless loops (part 5): netem/tbf/hfsc ->requeue failures

2006-11-29 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 20 Nov 2006 16:01:03 +0100 > I forgot to fix one (AFAICT purely theoretical) case .. Also applied to net-2.6.20, thanks a lot Patrick. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTEC

Re: [NET_SCHED 05/06]: Fix endless loops (part 3): HFSC

2006-11-29 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 20 Nov 2006 14:08:46 +0100 (MET) > [NET_SCHED]: Fix endless loops (part 3): HFSC > > Convert HFSC to use qdisc_tree_decrease_len() and add a callback > for deactivating a class when its child queue becomes empty. > > All queue purging goes thr

Re: [NET_SCHED 03/06]: Fix endless loops caused by inaccurate qlen counters (part 1)

2006-11-29 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 20 Nov 2006 14:08:41 +0100 (MET) > [NET_SCHED]: Fix endless loops caused by inaccurate qlen counters (part 1) > > There are multiple problems related to qlen adjustment that can lead > to an upper qdisc getting out of sync with the real number

Re: [NET_SCHED 06/06]: Fix endless loops (part 4): HTB

2006-11-29 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 20 Nov 2006 14:08:48 +0100 (MET) > [NET_SCHED]: Fix endless loops (part 4): HTB > > Convert HTB to use qdisc_tree_decrease_len() and add a callback > for deactivating a class when its child queue becomes empty. > > Signed-off-by: Patrick McHar

Re: [NET_SCHED 04/06]: Fix endless loops (part 2): "simple" qdiscs

2006-11-29 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 20 Nov 2006 14:08:44 +0100 (MET) > [NET_SCHED]: Fix endless loops (part 2): "simple" qdiscs > > Convert the "simple" qdiscs to use qdisc_tree_decrease_qlen() where > necessary: > > - all graft operations > - destruction of old child qdiscs in

Re: [NET_SCHED 01/06]: sch_htb: perform qlen adjustment immediately in ->delete

2006-11-29 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 20 Nov 2006 14:08:37 +0100 (MET) > [NET_SCHED]: sch_htb: perform qlen adjustment immediately in ->delete > > qlen adjustment should happen immediately in ->delete and not in the > class destroy function because the reference count will not hit

Re: [NET_SCHED 02/06]: Set parent classid in default qdiscs

2006-11-29 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 20 Nov 2006 14:08:38 +0100 (MET) > [NET_SCHED]: Set parent classid in default qdiscs > > Set parent classids in default qdiscs to allow walking up the tree > from outside the qdiscs. This is needed by the next patch. > > Signed-off-by: Patrick

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Wed, 29 Nov 2006 17:08:35 -0800 > On Wed, 29 Nov 2006 16:53:11 -0800 (PST) > David Miller <[EMAIL PROTECTED]> wrote: > > > > > Please, it is very difficult to review your work the way you have > > submitted this patch as a set of 4 patches. These pa

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-29 Thread Rafael J. Wysocki
On Thursday, 30 November 2006 00:26, Andrew Morton wrote: > On Thu, 30 Nov 2006 00:08:21 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > On Wednesday, 29 November 2006 22:31, Rafael J. Wysocki wrote: > > > On Wednesday, 29 November 2006 22:30, Andrew Morton wrote: > > > > On Wed, 29 N

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Andrew Morton
On Wed, 29 Nov 2006 16:53:11 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > > Please, it is very difficult to review your work the way you have > submitted this patch as a set of 4 patches. These patches have not > been split up "logically", but rather they have been split up "per > file"

Re: Bug 7596 - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread David Miller
The delays dealt with in your paper might actually help a highly loaded server with lots of sockets and threads trying to communicate. The packet processing delays caused by the scheduling delay paces the TCP sender by controlling the rate at which ACKs go back to that sender. Those ACKs will go

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread David Miller
Please, it is very difficult to review your work the way you have submitted this patch as a set of 4 patches. These patches have not been split up "logically", but rather they have been split up "per file" with the same exact changelog message in each patch posting. This is very clumsy, and impos

Re: [PATCH 1/1] additional ipsec audit patch

2006-11-29 Thread James Morris
On Wed, 29 Nov 2006, James Morris wrote: > On Wed, 29 Nov 2006, Joy Latten wrote: > > > This patch disables auditing in ipsec when CONFIG_AUDITSYSCALL is > > disabled in the kernel. > > > > This patch also includes a bug fix for xfrm_state.c as a result of > > original ipsec audit patch. > > >

Re: [PATCH 1/1] additional ipsec audit patch

2006-11-29 Thread James Morris
On Wed, 29 Nov 2006, Joy Latten wrote: > This patch disables auditing in ipsec when CONFIG_AUDITSYSCALL is > disabled in the kernel. > > This patch also includes a bug fix for xfrm_state.c as a result of > original ipsec audit patch. > > Let me know if it looks ok. Also, the last patch contai

Re: Realtek 8139 driver (8139too.c) TX Timeout doesn't allow interrupt handler to disable receive interrupts at high bi-directional traffic

2006-11-29 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : [...] > Move the poll_enable to after hw_start() or put it inside hw_start. "after" probably The order would be the opposite of the one used in rtl8139_poll (which does __netif_rx_complete then irq_unlock) and it's past 1 AM. It starts to be a bit foggy. --

Re: Realtek 8139 driver (8139too.c) TX Timeout doesn't allow interrupt handler to disable receive interrupts at high bi-directional traffic

2006-11-29 Thread Stephen Hemminger
On Thu, 30 Nov 2006 00:32:19 +0100 Francois Romieu <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> : > > Francois Romieu <[EMAIL PROTECTED]> wrote: > > > Stephen Hemminger <[EMAIL PROTECTED]> : > > > [...] > > > > @@ -1682,12 +1685,11 @@ static void rtl8139_tx_timeout_task (voi

[PATCH 1/1] additional ipsec audit patch

2006-11-29 Thread Joy Latten
This patch disables auditing in ipsec when CONFIG_AUDITSYSCALL is disabled in the kernel. This patch also includes a bug fix for xfrm_state.c as a result of original ipsec audit patch. Let me know if it looks ok. My mail gateway has been acting crazy so I apologize for any replicas being sent f

Re: [Changelog] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Martin Bligh
Wenji Wu wrote: From: Wenji Wu <[EMAIL PROTECTED]> Greetings, For Linux TCP, when the network applcaiton make system call to move data from socket's receive buffer to user space by calling tcp_recvmsg(). The socket will be locked. During the period, all the incoming packet for the TCP socket wi

Re: [PATCH 0/3] NetLabel: add the remaining CIPSO tag types from the IETF draft

2006-11-29 Thread James Morris
On Wed, 29 Nov 2006, Paul Moore wrote: > James Morris wrote: > > All applied to: > > git://git.infradead.org/~jmorris/selinux-net-2.6.20 > > Thanks. > > Did you mean your kernel.org git tree? There's a copy at infradead (which may have still been cloning if you checked it immediately).

Re: Bug 7596 - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Andrew Morton
On Wed, 29 Nov 2006 17:22:10 -0600 Wenji Wu <[EMAIL PROTECTED]> wrote: > From: Wenji Wu <[EMAIL PROTECTED]> > > Greetings, > > For Linux TCP, when the network applcaiton make system call to move data > from > socket's receive buffer to user space by calling tcp_recvmsg(). The socket > will > be

Re: Realtek 8139 driver (8139too.c) TX Timeout doesn't allow interrupt handler to disable receive interrupts at high bi-directional traffic

2006-11-29 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : > Francois Romieu <[EMAIL PROTECTED]> wrote: > > Stephen Hemminger <[EMAIL PROTECTED]> : > > [...] > > > @@ -1682,12 +1685,11 @@ static void rtl8139_tx_timeout_task (voi > > > rtl8139_tx_clear (tp); > > > spin_unlock_irq(&tp->lock); > > > > > > + netif_

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-29 Thread Andrew Morton
On Thu, 30 Nov 2006 00:08:21 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Wednesday, 29 November 2006 22:31, Rafael J. Wysocki wrote: > > On Wednesday, 29 November 2006 22:30, Andrew Morton wrote: > > > On Wed, 29 Nov 2006 21:08:00 +0100 > > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> w

[patch 3/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Wenji Wu
From: Wenji Wu <[EMAIL PROTECTED]> Greetings, For Linux TCP, when the network applcaiton make system call to move data from socket's receive buffer to user space by calling tcp_recvmsg(). The socket will be locked. During the period, all the incoming packet for the TCP socket will go to the back

[patch 2/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Wenji Wu
From: Wenji Wu <[EMAIL PROTECTED]> Greetings, For Linux TCP, when the network applcaiton make system call to move data from socket's receive buffer to user space by calling tcp_recvmsg(). The socket will be locked. During the period, all the incoming packet for the TCP socket will go to the back

[patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Wenji Wu
From: Wenji Wu <[EMAIL PROTECTED]> Greetings, For Linux TCP, when the network applcaiton make system call to move data from socket's receive buffer to user space by calling tcp_recvmsg(). The socket will be locked. During the period, all the incoming packet for the TCP socket will go to the back

[Changelog] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Wenji Wu
From: Wenji Wu <[EMAIL PROTECTED]> Greetings, For Linux TCP, when the network applcaiton make system call to move data from socket's receive buffer to user space by calling tcp_recvmsg(). The socket will be locked. During the period, all the incoming packet for the TCP socket will go to the back

[patch 4/4] - Potential performance bottleneck for Linxu TCP

2006-11-29 Thread Wenji Wu
From: Wenji Wu <[EMAIL PROTECTED]> Greetings, For Linux TCP, when the network applcaiton make system call to move data from socket's receive buffer to user space by calling tcp_recvmsg(). The socket will be locked. During the period, all the incoming packet for the TCP socket will go to the backl

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-29 Thread Rafael J. Wysocki
On Wednesday, 29 November 2006 22:31, Rafael J. Wysocki wrote: > On Wednesday, 29 November 2006 22:30, Andrew Morton wrote: > > On Wed, 29 Nov 2006 21:08:00 +0100 > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > On Wednesday, 29 November 2006 20:54, Rafael J. Wysocki wrote: > > > > On

Re: Realtek 8139 driver (8139too.c) TX Timeout doesn't allow interrupt handler to disable receive interrupts at high bi-directional traffic

2006-11-29 Thread Stephen Hemminger
On Wed, 29 Nov 2006 23:44:00 +0100 Francois Romieu <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> : > [...] > > @@ -1682,12 +1685,11 @@ static void rtl8139_tx_timeout_task (voi > > rtl8139_tx_clear (tp); > > spin_unlock_irq(&tp->lock); > > > > + netif_poll_enable();

Re: Realtek 8139 driver (8139too.c) TX Timeout doesn't allow interrupt handler to disable receive interrupts at high bi-directional traffic

2006-11-29 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : [...] > @@ -1682,12 +1685,11 @@ static void rtl8139_tx_timeout_task (voi > rtl8139_tx_clear (tp); > spin_unlock_irq(&tp->lock); > > + netif_poll_enable(); ^ -> dev > + > /* ...and finally, reset everything */

Re: [PATCH 1/1] add auditing to ipsec

2006-11-29 Thread Steve Grubb
On Monday 27 November 2006 14:11, Joy Latten wrote: > Please let me know if this is acceptable. >From an audit perspective, it looks good. -Steve - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

Re: [PATCH 0/3] NetLabel: add the remaining CIPSO tag types from the IETF draft

2006-11-29 Thread Paul Moore
James Morris wrote: > All applied to: > git://git.infradead.org/~jmorris/selinux-net-2.6.20 Thanks. Did you mean your kernel.org git tree? -- paul moore linux security @ hp - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mo

Re: [PATCH 0/3] NetLabel: add the remaining CIPSO tag types from the IETF draft

2006-11-29 Thread James Morris
All applied to: git://git.infradead.org/~jmorris/selinux-net-2.6.20 Thanks, - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/maj

Re: [Devel] Re: Network virtualization/isolation

2006-11-29 Thread Daniel Lezcano
Brian Haley wrote: Eric W. Biederman wrote: I think for cases across network socket namespaces it should be a matter for the rules, to decide if the connection should happen and what error code to return if the connection does not happen. There is a potential in this to have an ambiguous case w

[patch 10/23] bcm43xx: Drain TX status before starting IRQs

2006-11-29 Thread Chris Wright
-stable review patch. If anyone has any objections, please let us know. -- From: Michael Buesch <[EMAIL PROTECTED]> Drain the Microcode TX-status-FIFO before we enable IRQs. This is required, because the FIFO may still have entries left from a previous run. Those would immediatel

Re: sky2 hang still exists in 2.6.19-rc6 --Bug#396185?

2006-11-29 Thread Berck E. Nash
Stephen Hemminger wrote: That motherboard has dual lan, are you using both of them? I don't have that chip version, so hard to tell if it is using dual port with a single chip or not. There is a hack for the dual port PCI-X version already in the driver, that turns off receive checksums if bo

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-29 Thread Rafael J. Wysocki
On Wednesday, 29 November 2006 22:30, Andrew Morton wrote: > On Wed, 29 Nov 2006 21:08:00 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > On Wednesday, 29 November 2006 20:54, Rafael J. Wysocki wrote: > > > On Tuesday, 28 November 2006 11:02, Andrew Morton wrote: > > > > > > > > Temp

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-29 Thread Andrew Morton
On Wed, 29 Nov 2006 21:08:00 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Wednesday, 29 November 2006 20:54, Rafael J. Wysocki wrote: > > On Tuesday, 28 November 2006 11:02, Andrew Morton wrote: > > > > > > Temporarily at > > > > > > http://userweb.kernel.org/~akpm/2.6.19-rc6-mm2/ >

[PATCH] r8169: Fix iteration variable sign

2006-11-29 Thread Francois Romieu
This changes the type of variable "i" in rtl8169_init_one() from "unsigned int" to "int". "i" is checked for < 0 later, which can never happen for "unsigned". This results in broken error handling. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECT

[PATCH] sundance: use NULL for pointer

2006-11-29 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Use NULL instead of 0 for pointers (cures sparse warnings). drivers/net/sundance.c:1106:16: warning: Using plain integer as NULL pointer drivers/net/sundance.c:1652:16: warning: Using plain integer as NULL pointer Signed-off-by: Randy Dunlap <[EMAIL PROTECT

Re: [PATCH 3/3] NetLabel: add the ranged tag to the CIPSOv4 protocol

2006-11-29 Thread James Morris
On Wed, 29 Nov 2006, [EMAIL PROTECTED] wrote: > +{ > + /* The constant '16' is not random, it is the maximum number of > + * high/low category range pairs as permitted by the CIPSO draft based > + * on a maximum IPv4 header length of 60 bytes - the BUG_ON() assertion > + * does

Re: Realtek 8139 driver (8139too.c) TX Timeout doesn't allow interrupt handler to disable receive interrupts at high bi-directional traffic

2006-11-29 Thread Stephen Hemminger
On Wed, 29 Nov 2006 14:20:31 +0530 "Basheer, Mansoor Ahamed" <[EMAIL PROTECTED]> wrote: > Francois Romieu [mailto:[EMAIL PROTECTED] wrote: > > > Afaics your change may disable the Rx irq right after the poll routine > > > enabled it again. It will not always work either. > > > > The (slow) time

Re: Network virtualization/isolation

2006-11-29 Thread Brian Haley
Eric W. Biederman wrote: I think for cases across network socket namespaces it should be a matter for the rules, to decide if the connection should happen and what error code to return if the connection does not happen. There is a potential in this to have an ambiguous case where two application

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread Stephen Hemminger
On Wed, 29 Nov 2006 08:03:28 -0800 David Kimdon <[EMAIL PROTECTED]> wrote: > On Wed, Nov 29, 2006 at 04:38:56PM +0100, Michael Buesch wrote: > > On Wednesday 29 November 2006 16:24, David Kimdon wrote: > > > On Wed, Nov 29, 2006 at 04:12:33PM +0100, Michael Buesch wrote: > > > > On Wednesday 29 No

Re: [PATCH] lockdep: fix sk->sk_callback_lock locking

2006-11-29 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 29 Nov 2006 23:07:09 +1100 > On Wed, Nov 29, 2006 at 12:42:24PM +0100, Peter Zijlstra wrote: > > > > However I'm not quite sure yet how to teach lockdep about this. The > > proposed patch will shut it up though. > > As a rule I think we should neve

Re: pktgen

2006-11-29 Thread Alexey Dobriyan
On Tue, Nov 28, 2006 at 03:33:25PM -0800, David Miller wrote: > From: Alexey Dobriyan <[EMAIL PROTECTED]> > Date: Wed, 22 Nov 2006 00:22:51 +0300 > > > [CCing netdev, bug in pktgen] > > > > [build modular pktgen] > > while true; do modprobe pktgen && rmmod pktgen; done > > > > BUG: w

[PATCH] r8169: Fix iteration variable sign

2006-11-29 Thread Michael Buesch
This changes the type of variable "i" in rtl8169_init_one() from "unsigned int" to "int". "i" is checked for <0 later, which can never happen for "unsigned". This results in broken error handling. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: linux-2.6/drivers/net/r8169.c =

Re: Intel 82559 NIC corrupted EEPROM

2006-11-29 Thread Jesse Brandeburg
On 11/29/06, John <[EMAIL PROTECTED]> wrote: > Let's go ahead and print the output from e100_load_eeprom > debug patch attached. Loading (then unloading) e100.ko fails the first few times (i.e. the driver claims one of the EEPROMs is corrupted). Thereafter, sometimes it fails, other times it wor

Re: [PATCH 0/3] NetLabel: add the remaining CIPSO tag types from the IETF draft

2006-11-29 Thread Casey Schaufler
--- [EMAIL PROTECTED] wrote: > This patchset consists of three patches that add > support for the remaining two > tag types from the CIPSO draft specification, the > enumerated and range tags. > The most significant part about adding these two > tags is that NetLabel now has > the ability to repr

[PATCH 3/3] NetLabel: add the ranged tag to the CIPSOv4 protocol

2006-11-29 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> Add support for the ranged tag (tag type #5) to the CIPSOv4 protocol. The ranged tag allows for seven, or eight if zero is the lowest category, category ranges to be specified in a CIPSO option. Each range is specified by two unsigned 16 bit fields, each with

[PATCH 0/3] NetLabel: add the remaining CIPSO tag types from the IETF draft

2006-11-29 Thread paul . moore
This patchset consists of three patches that add support for the remaining two tag types from the CIPSO draft specification, the enumerated and range tags. The most significant part about adding these two tags is that NetLabel now has the ability to represent more than 240 categories (limitation im

[PATCH 2/3] NetLabel: add the enumerated tag to the CIPSOv4 protocol

2006-11-29 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> Add support for the enumerated tag (tag type #2) to the CIPSOv4 protocol. The enumerated tag allows for 15 categories to be specified in a CIPSO option, where each category is an unsigned 16 bit field with a maximum value of 65534. See Documentation/netlabel/

[PATCH 1/3] NetLabel: convert to an extensibile/sparse category bitmap

2006-11-29 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> The original NetLabel category bitmap was a straight char bitmap which worked fine for the initial release as it only supported 240 bits due to limitations in the CIPSO restricted bitmap tag (tag type 0x01). This patch converts that straight char bitmap into a

[PATCH 1/1] add auditing to ipsec

2006-11-29 Thread Joy Latten
This patch adds auditing to ipsec. An audit message occurs when an ipsec SA or ipsec policy is created/deleted. Patch was built against linux kernel 2.6.19-rc6. Please let me know if this is acceptable. Regards, Joy Signed-off-by: Joy Latten <[EMAIL PROTECTED]> ---

[SAA9730] Fix build error

2006-11-29 Thread Ralf Baechle
Confusingly NET_PCI is also set for for non-PCI EISA configurations where building this driver will result in a build error due to a reference to pci_release_regions. While at it, remove the EXPERIMENTAL - in all its uglyness and despite the sincerest attempts of the buggy hardware the driver is k

[PATCH 3/4] NetXen: 64-bit memory fixes and driver cleanup

2006-11-29 Thread Amit S. Kale
NetXen: 1G/10G Ethernet Driver updates - These fixes take care of driver on machines with >4G memory - Driver cleanup Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> netxen_nic.h | 41 ++ netxen_nic_ethtool.c | 19 ++-- netxen_nic_hw.c | 10 +- netxe

[PATCH 1/4] NetXen: Fixed /sys mapping between device and driver

2006-11-29 Thread Amit S. Kale
Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> netxen_nic_main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index 145bf47..a055208 100644 --- a/drivers/net/netxen/netxen_nic_main.c +++ b/

[PATCH 0/4] NetXen: 1G/10G Ethernet Driver updates

2006-11-29 Thread Amit S. Kale
I will be sending NetXen: 1G/10G Ethernet Driver updates in subsequent emails. Thanks, --Amit - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] d80211: Reset assoc and auth retry counters

2006-11-29 Thread John W. Linville
On Wed, Nov 29, 2006 at 03:33:07PM +0100, Jiri Benc wrote: > On Wed, 29 Nov 2006 15:27:06 +0100, Ivo Van Doorn wrote: > > Shouldn't this last one be: > > ieee80211_set_disassoc(dev, ifsta, 0) > > > > This one is called from the IOCTL request to dissassociate, > > so the interface should still be a

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread Michael Buesch
On Wednesday 29 November 2006 16:58, Michael Renzmann wrote: > Hi. > > > On Wednesday 29 November 2006 16:24, David Kimdon wrote: > >> There is absolutely no reason why dadwifi can't be merged into the > >> mainline once the hal issue is resolved. > > Last time we talked about that stuff, it was d

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread David Kimdon
On Wed, Nov 29, 2006 at 04:38:56PM +0100, Michael Buesch wrote: > On Wednesday 29 November 2006 16:24, David Kimdon wrote: > > On Wed, Nov 29, 2006 at 04:12:33PM +0100, Michael Buesch wrote: > > > On Wednesday 29 November 2006 15:34, Nick Kossifidis wrote: > > Why do you say that? > > > > There is

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread Michael Renzmann
Hi. > On Wednesday 29 November 2006 16:24, David Kimdon wrote: >> There is absolutely no reason why dadwifi can't be merged into the >> mainline once the hal issue is resolved. > Last time we talked about that stuff, it was decided that > we don't want a HAL... See archives. IIRC Pavel already ex

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread Daniel Drake
On Wed, 2006-11-29 at 15:55 +0200, Nick Kossifidis wrote: > I 've already ported ar5k to linux and it works with madwifi versions > before the bsd-head merge, you can see more infos here -> > http://madwifi.org/wiki/OpenHAL > > If i can help in any way feel free to mail ;-) Thanks, I'm trying it

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread Michael Buesch
On Wednesday 29 November 2006 16:24, David Kimdon wrote: > On Wed, Nov 29, 2006 at 04:12:33PM +0100, Michael Buesch wrote: > > On Wednesday 29 November 2006 15:34, Nick Kossifidis wrote: > > > Good luck then ;-) > > > > > > If anyone wants to help on making ar5k work with newer madwifi > > > versi

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread Michael Buesch
On Wednesday 29 November 2006 16:24, David Kimdon wrote: > On Wed, Nov 29, 2006 at 04:12:33PM +0100, Michael Buesch wrote: > > On Wednesday 29 November 2006 15:34, Nick Kossifidis wrote: > > > Good luck then ;-) > > > > > > If anyone wants to help on making ar5k work with newer madwifi > > > versi

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread David Kimdon
On Wed, Nov 29, 2006 at 10:21:09AM -0500, Dan Williams wrote: > On Wed, 2006-11-29 at 16:12 +0100, Michael Buesch wrote: > > On Wednesday 29 November 2006 15:34, Nick Kossifidis wrote: > > > Good luck then ;-) > > > > > > If anyone wants to help on making ar5k work with newer madwifi > > > version

Re: [PATCH] [IPVS] transparent proxying

2006-11-29 Thread Wensong Zhang
Hi Horms, I see that this patch probably makes IPVS code a bit complicated and packet traversing less efficiently. If I remember correctly, policy-based routing can work with IPVS in kernel 2.2 and 2.4 for transparent cache cluster for a long time. It should work in kernel 2.6 too. For ex

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread David Kimdon
On Wed, Nov 29, 2006 at 04:12:33PM +0100, Michael Buesch wrote: > On Wednesday 29 November 2006 15:34, Nick Kossifidis wrote: > > Good luck then ;-) > > > > If anyone wants to help on making ar5k work with newer madwifi > > versions and fix bugs etc (that 'll also help bsd ppl) plzz mail me. > > W

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread Dan Williams
On Wed, 2006-11-29 at 16:12 +0100, Michael Buesch wrote: > On Wednesday 29 November 2006 15:34, Nick Kossifidis wrote: > > Good luck then ;-) > > > > If anyone wants to help on making ar5k work with newer madwifi > > versions and fix bugs etc (that 'll also help bsd ppl) plzz mail me. > > We can m

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-29 Thread Krzysztof Halasa
Krzysztof Halasa <[EMAIL PROTECTED]> writes: > I wound't care less btw. s/wound/couldn/, eh those foreign languages... -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread Michael Buesch
On Wednesday 29 November 2006 15:34, Nick Kossifidis wrote: > Good luck then ;-) > > If anyone wants to help on making ar5k work with newer madwifi > versions and fix bugs etc (that 'll also help bsd ppl) plzz mail me. > We can make it better. > > Nick > P.S. Why not work on dawifi ? Because it

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-29 Thread Krzysztof Halasa
Jarek Poplawski <[EMAIL PROTECTED]> writes: > And if we talk about names: > > + Spotted by Krzysztof Halasa. I wound't care less btw. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] [IPVS] transparent proxying

2006-11-29 Thread Horms
On Wed, Nov 29, 2006 at 03:15:23PM +0100, Thomas Graf wrote: > * Horms <[EMAIL PROTECTED]> 2006-11-29 15:21 > > This seems to be a pretty clean solution to a real problem. > > > > Ultimately I would like to see IPVS move into the forward chain. > > This seems to be a nice way to explore that, with

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread Nick Kossifidis
Good luck then ;-) If anyone wants to help on making ar5k work with newer madwifi versions and fix bugs etc (that 'll also help bsd ppl) plzz mail me. We can make it better. Nick P.S. Why not work on dawifi ? 2006/11/29, Michael Buesch <[EMAIL PROTECTED]>: On Wednesday 29 November 2006 14:55,

Re: [PATCH] d80211: Reset assoc and auth retry counters

2006-11-29 Thread Jiri Benc
On Wed, 29 Nov 2006 15:27:06 +0100, Ivo Van Doorn wrote: > Shouldn't this last one be: > ieee80211_set_disassoc(dev, ifsta, 0) > > This one is called from the IOCTL request to dissassociate, > so the interface should still be authenticated (with a valid > auth retry counter). Yes, of course. Than

Re: [PATCH] d80211: Reset assoc and auth retry counters

2006-11-29 Thread Ivo Van Doorn
On 11/29/06, Jiri Benc <[EMAIL PROTECTED]> wrote: On Tue, 28 Nov 2006 20:56:05 +0100, Ivo van Doorn wrote: > After a succesfull authentication and association the matching retry counter > must be reset to 0. > Failure to do so will result in failure to authenticate after the interface > has been

Re: [PATCH] [IPVS] transparent proxying

2006-11-29 Thread Thomas Graf
* Horms <[EMAIL PROTECTED]> 2006-11-29 15:21 > This seems to be a pretty clean solution to a real problem. > > Ultimately I would like to see IPVS move into the forward chain. > This seems to be a nice way to explore that, without breaking > any existing setups. > > -- > Horms > H: http://www.

Re: [PATCH] d80211: Reset assoc and auth retry counters

2006-11-29 Thread Jiri Benc
On Tue, 28 Nov 2006 20:56:05 +0100, Ivo van Doorn wrote: > After a succesfull authentication and association the matching retry counter > must be reset to 0. > Failure to do so will result in failure to authenticate after the interface > has been deauthenticated. This does not always happen after t

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread Michael Buesch
On Wednesday 29 November 2006 14:55, Nick Kossifidis wrote: > I 've already ported ar5k to linux and it works with madwifi versions No, you misunderstood me. Madwifi is not a native driver and will never be accepted into mainline. My attempt is to write a native d80211 driver based on the ar5k sou

[DECNet] fib: Fix out of bound access of fib_props[]

2006-11-29 Thread Thomas Graf
Fixes a typo which caused fib_props[] to have the wrong size and makes sure the value used to index the array which is provided by userspace via netlink is checked to avoid out of bound access. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/decnet/dn_fib.c =

  1   2   >