Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 3

2006-12-04 Thread Andrew Victor
hi Stephen, > Use netdev_alloc_skb instead. It sets skb->dev so you don't have to. netdev_alloc_skb() seems to cause 2 function calls [__netdev_alloc_skb() and __alloc_skb()], instead of just 1 for the dev_alloc_skb() case. It might be more efficient if the driver manually sets skb->dev. > Sett

[PATCH 3/5] Update version ipw2200 stamp to 1.2.0

2006-12-04 Thread Zhu Yi
--- drivers/net/wireless/ipw2200.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) 3bce796189a9c6f3e73a06b59817923013b38f44 diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c index 980758c..2b29396 100644 --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/ne

[PATCH 4/5] ipw2200: Fix a typo

2006-12-04 Thread Zhu Yi
Signed-off-by: Pascal Terjan <[EMAIL PROTECTED]> Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- drivers/net/wireless/ipw2100.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) e4968a3ae9ab96f144c0cc7103699b6ecddd1be0 diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/i

[PATCH 2/5] ipw2200: Add IEEE80211_RADIOTAP_TSFT for promiscuous mode

2006-12-04 Thread Zhu Yi
The ipw2200 BSS firmware passes on the TSF information within ipw_rx_frame, but monitor firmware doesn't. I add back the IEEE80211_RADIOTAP_TSFT flags so that we can get the MAC timestamp if we use the rtap interface. We will see the MAC timestamp equals to zero if we capture the packets with a mon

[PATCH 5/5] ipw2200: Fix debug output endian issue

2006-12-04 Thread Zhu Yi
Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- drivers/net/wireless/ipw2200.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) 7c609b56727b70a61fd28f51a445c0e032d47ef0 diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c index 2b29396..5de7ee7 100644 --- a/driv

[PATCH 1/5] ipw2100: Make ipw2100 depends on known working platforms

2006-12-04 Thread Zhu Yi
[ Resubmit, if you still don't like it, I'll drop. ] ipw2100 driver doesn't support big endian by now. Signed-off-by: Karol Lewandowski <[EMAIL PROTECTED]> Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- drivers/net/wireless/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) d

ipw2100/2200 driver updates

2006-12-04 Thread Zhu Yi
Hi, Here are some small updates for ipw2100/2200 drivers. [PATCH 1/5] ipw2100: Make ipw2100 depends on known working platforms [PATCH 2/5] ipw2200: Add IEEE80211_RADIOTAP_TSFT for promiscuous mode [PATCH 3/5] Update version ipw2200 stamp to 1.2.0 [PATCH 4/5] ipw2200: Fix a typo [PATCH 5/5] ipw22

Re: network devices don't handle pci_dma_mapping_error()'s

2006-12-04 Thread Muli Ben-Yehuda
On Mon, Dec 04, 2006 at 10:39:49AM -0800, Stephen Hemminger wrote: > I notice that no current network driver handles dma mapping errors. > Might that be part of the problem. On i386, this never happens, and > it would be rare on most others. IOMMUs are already available on x86-64 and are going t

dm-crypt changes in git-net tree

2006-12-04 Thread Andrew Morton
On x86_64: drivers/md/dm-crypt.c: In function 'crypt_iv_benbi_ctr': drivers/md/dm-crypt.c:235: warning: cast to pointer from integer of different size drivers/md/dm-crypt.c: In function 'crypt_iv_benbi_gen': drivers/md/dm-crypt.c:248: warning: cast from pointer to integer of different size driv

Re: tulip_stop_rxtx() failed

2006-12-04 Thread Valerie Henson
On Thu, Nov 23, 2006 at 01:59:17PM +0200, Meelis Roos wrote: > Background: Motorola Powerstack II (RS/6000 clone), PRep PowerPC > machine, running Debian unstable userspace and latest git kernels. 1 > 21140 onboard, another in PCI slot. > > Occasionally there is the message > :00:06.0: tulip

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 2

2006-12-04 Thread Andrew Victor
hi Stephen, > poll_controller is always called with interrupts already disabled. All the other network drivers I looked at seem to disable the interrupt. > The third argument to interrupt routines was dropped (struct pt_regs) in > 2.6.19. > Maybe that never got fixed in ARM? My mistake - ARM

Re: [PATCH] Add Broadcom PHY support

2006-12-04 Thread Benjamin Herrenschmidt
> I believe that this fiber enabling can be done by defining config_init in the > phy_driver struct. > > struct phy_driver { > > /* Called to initialize the PHY, >* including after a reset */ > int (*config_init)(struct phy_device *phydev); > > }; Well... I don't know fo

Re: [PATCH] Add Broadcom PHY support

2006-12-04 Thread Amy Fong
> On Fri, 2006-09-15 at 16:15 -0400, Amy Fong wrote: > > [PATCH] Add Broadcom PHY support > > > > This patch adds a driver to support the bcm5421s and bcm5461s PHY > > > > Kernel version: linux-2.6.18-rc6 > > > > Signed-off-by: Amy Fong > > Some 5421's need special initialisation (see drivers

Re: [PATCH v2 04/13] Connection Manager

2006-12-04 Thread Roland Dreier
> So will each new NIC implement some parts of TCP stack in theirs drivers? I hope not. The driver we merged (amso1100) did it completely in FW, with a separate MAC and IP interface for the RDMA connections. I think we better understand the Chelsio driver pretty well and think it over carefully

Re: [PATCH v2 04/13] Connection Manager

2006-12-04 Thread Evgeniy Polyakov
On Mon, Dec 04, 2006 at 09:13:59PM -0800, Roland Dreier ([EMAIL PROTECTED]) wrote: > > It is for iwarp/rdma from description. > > Yes, iWARP on top of 10G ethernet. > > > If it is 10ge, then why does it parse incomping packet headers and > > implements initial tcp state machine? > > To estab

Re: [PATCH v2 04/13] Connection Manager

2006-12-04 Thread Roland Dreier
> It is for iwarp/rdma from description. Yes, iWARP on top of 10G ethernet. > If it is 10ge, then why does it parse incomping packet headers and > implements initial tcp state machine? To establish connections to run RDMA over, I guess. iWARP is RDMA over TCP. - R. - To unsubscribe from th

Re: [PATCH v2 04/13] Connection Manager

2006-12-04 Thread Evgeniy Polyakov
On Mon, Dec 04, 2006 at 10:20:51AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: > > > This and a lot of other changes in this driver definitely says you > > > implement your own stack of protocols on top of infiniband hardware. > > > > ...but I do know this driver is for 10-gig ethernet HW. > >

Re: [PATCH v2 04/13] Connection Manager

2006-12-04 Thread Evgeniy Polyakov
On Mon, Dec 04, 2006 at 07:45:52AM -0800, Roland Dreier ([EMAIL PROTECTED]) wrote: > > This and a lot of other changes in this driver definitely says you > > implement your own stack of protocols on top of infiniband hardware. > > ...but I do know this driver is for 10-gig ethernet HW. It is f

Re: Generic Netlink doc now wiki-ized

2006-12-04 Thread Stephen Hemminger
On Mon, 04 Dec 2006 19:34:32 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Mon, 4 Dec 2006 18:39:57 -0500 > > > Clicky clicky... > > > > * http://linux-net.osdl.org/index.php/Generic_Netlink_HOWTO > > Nice. > > We should add a reference to

Re: [PATCH][XFRM] Optimize SA dumping

2006-12-04 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Mon, 04 Dec 2006 15:59:45 -0500 > The SA version Also applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][XFRM] Optimize policy dumping

2006-12-04 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Mon, 04 Dec 2006 15:58:03 -0500 > This one has undergone more scrutiny and testing. Against net-2.6.20 Applied, thanks Jamal. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: RFC: consistent disable_xfrm behaviour

2006-12-04 Thread David Miller
From: Alexey Kuznetsov <[EMAIL PROTECTED]> Date: Mon, 4 Dec 2006 20:20:01 +0300 > > Here's the patch again properly signed off. > > I think it is correct. Patch applied, thanks everyone. I'll push this one to -stable too. - To unsubscribe from this list: send the line "unsubscribe netdev" in th

Re: Generic Netlink doc now wiki-ized

2006-12-04 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Mon, 4 Dec 2006 18:39:57 -0500 > Clicky clicky... > > * http://linux-net.osdl.org/index.php/Generic_Netlink_HOWTO Nice. We should add a reference to this somewhere in the tree probably. - To unsubscribe from this list: send the line "unsubscribe netde

Re: [patch 1/1] atm: Add CPPFLAGS to byteorder.h check

2006-12-04 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 04 Dec 2006 15:05:34 -0800 > From: Ben Collins <[EMAIL PROTECTED]> > > O= builds produced errors in the shell command because of unfound headers. > > Signed-off-by: Ben Collins <[EMAIL PROTECTED]> > Cc: chas williams <[EMAIL PROTECTED]> > Cc: Sam Ravnborg <[EMA

Re: [RFC][GENETLINK] move command capabilities to flags

2006-12-04 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Mon, 4 Dec 2006 22:23:41 +0100 > * jamal <[EMAIL PROTECTED]> 2006-12-04 16:07 > > On Mon, 2006-04-12 at 19:00 +0100, Thomas Graf wrote: > > > * jamal <[EMAIL PROTECTED]> 2006-12-04 12:48 > > > > > > We can resolve that by uping the version for the contr

Re: 2.6.19-git6 header error

2006-12-04 Thread Randy Dunlap
On Mon, 4 Dec 2006 17:03:24 -0800 Randy Dunlap wrote: > linux-2.6.19-git6/usr/include/linux/netfilter.h requires linux/rcupdate.h, > which does not exist in exported headers > make[3]: *** > [/var/linsrc/linux-2.6.19-git6/usr/include/linux/.check.netfilter.h] Error 1 > make[2]: *** [linux] Error

[PATCH] sky2: receive queue watermark tweak

2006-12-04 Thread Stephen Hemminger
This patch makes the receive performance on some systems go from 714MB/s to 941MB/s. It adjusts the watermark of the receive queue to be lower, thereby avoiding excess hardware flow control. This is most important on the systems which have little/no additional buffering. Signed-off-by: Stephen Hem

2.6.19-git6 header error

2006-12-04 Thread Randy Dunlap
linux-2.6.19-git6/usr/include/linux/netfilter.h requires linux/rcupdate.h, which does not exist in exported headers make[3]: *** [/var/linsrc/linux-2.6.19-git6/usr/include/linux/.check.netfilter.h] Error 1 make[2]: *** [linux] Error 2 make[1]: *** [headers_check] Error 2 make: *** [vmlinux] Error

Re: watchdog timeout panic in e1000 driver

2006-12-04 Thread Auke Kok
Kenzo Iwami wrote: Hi, Doesn't this just mean that we need a spinlock or some other kind of semaphore around acquiring, using, and releasing this resource? We keep going around and around about this but I'm pretty sure spinlocks are meant to be able to solve exactly this issue. The problem is

Re: NETDEV-BCM43XX BUG - Failure to associate AP with latest devscape git pull..

2006-12-04 Thread Robert Martin
Paul Collins wrote: (Please use reply-to-all to keep Cc:s intact, and place new material below quoted material.) Robert Martin <[EMAIL PROTECTED]> writes: Paul Collins wrote: Robert Martin <[EMAIL PROTECTED]> writes: Alas, that seems to have been the problem, I was getting di

Re: NETDEV-BCM43XX BUG - Failure to associate AP with latest devscape git pull..

2006-12-04 Thread Paul Collins
(Please use reply-to-all to keep Cc:s intact, and place new material below quoted material.) Robert Martin <[EMAIL PROTECTED]> writes: > Paul Collins wrote: >> Robert Martin <[EMAIL PROTECTED]> writes: >> >>> Alas, that seems to have been the problem, I was getting different >>> frequencies. Onc

'embedded people' and the 'embedded world' (was: Re: [RFC patch] driver for the Opencores Ethernet Controller)

2006-12-04 Thread Lennert Buytenhek
On Mon, Dec 04, 2006 at 10:27:52AM -0800, Dan Nicolaescu wrote: > I didn't know about "platform drivers" before your mail. I guess I > could convert it to that if that is the right thing to do. > (It might be an overkill given that the device is kind of simple and > embedded people prefer small c

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-04 Thread Randy Dunlap
On Sun, 3 Dec 2006 23:28:11 +0100 Ivo van Doorn wrote: > rfkill with the fixes as suggested by Arjan. > - instead of a semaphore a mutex is now being used. > - open_count changing is now locked by the mutex. > > --- > > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig > ind

Re: NETDEV-BCM43XX BUG - Failure to associate AP with latest devscape git pull..

2006-12-04 Thread Robert Martin
I've only had the laptop (Compaq V6000Z series) for about a week, so I'd be unable to tell you if the driver had worked before, but I seem to have had the same problem that Paul Collins did pertaining to frequency mismatch. Setting it manually to the value "iwlist" gave me for the AP makes it

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Lennert Buytenhek
On Mon, Dec 04, 2006 at 10:27:52AM -0800, Dan Nicolaescu wrote: > > > The Opencores Ethernet Controller is Verilog code that can be used to > > > implement an Ethernet device in hardware. It needs to be coupled with > > > a PHY and some buffer memory. Because of that devices that implement > > > t

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Stephen Hemminger
> > > Indentation. See Documentation style. > > What about IRQF_SHARED? > > Not sure, maybe I should make this another driver parameter. On my > platform is not shared... The trouble with devices, is that some poor sop clones the hardware to another board and your assumption is no longer va

Re: NETDEV-BCM43XX BUG - Failure to associate AP with latest devscape git pull..

2006-12-04 Thread Paul Collins
Robert Martin <[EMAIL PROTECTED]> writes: > Paul Collins wrote: >> I started playing with wireless-dev's bcm43xx-d80211 recently and >> noticed that I had to set the frequency manually. When I did that, >> setting the ap manually caused the card to associate immediately. > > Alas, that seems to h

[PATCH 2/3] sky2: add comments to PCI ids

2006-12-04 Thread Stephen Hemminger
Add comments to sky2 driver to show relationship between PCI id and hardware. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c | 48 +++- 1 file changed, 23 insertions(+), 25 deletions(-) --- sky2.orig/drivers/net/sky2.c

[PATCH 3/3] sky2: beter ram buffer partitioning

2006-12-04 Thread Stephen Hemminger
Different chips have different sizes of ram buffers, and some versions have no ram buffer at all!. Be more careful about sizing the ram usage because it maybe a problem if vendor keeps changing sizes. There is the (unlikely) possibility that some of the errors on some of the chips have been cause

[PATCH 1/3] sky2: add PCI for 88ec033

2006-12-04 Thread Stephen Hemminger
Add another new/missing pci id for 88ec033 chip. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-12-04 12:33:26.0 -0800 +++ sky2/drivers/net/sky2.c 2006-12-04 12:38:00.0 -0800 @@ -117,6 +117,7 @@ { PCI_DEVICE(PCI_VENDOR

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Dan Nicolaescu
Stephen Hemminger <[EMAIL PROTECTED]> writes: > On Mon, 04 Dec 2006 10:01:01 -0800 > Dan Nicolaescu <[EMAIL PROTECTED]> wrote: > > > > > Hi, > > > > Here is a driver for the Opencores Ethernet Controller. I started from > > a 2.4 uClinux driver, ported it to 2.6, made it work, c

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 3

2006-12-04 Thread Jeff Garzik
Andrew Victor wrote: A minor fix to the Atmel AT91RM9200 Ethernet driver. 1. Use dev_alloc_skb() instead of alloc_skb(). 2. It is not necessary to adjust skb->len manually. Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> ACK patch content - To unsubscribe from this list: send the line "un

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 1

2006-12-04 Thread Jeff Garzik
NAK. see inline comments in quoted text. Andrew Victor wrote: Please fix your email's subject line per http://linux.yyz.us/patch-format.html The subject is a one-line summary that tells us not only what driver is being update, but also summarizes the changes in the patch. "update 1" tell

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 2

2006-12-04 Thread Jeff Garzik
Andrew Victor wrote: This patch adds NetPoll / NetConsole support to the Atmel AT91RM9200 Ethernet driver. Original patch from Bill Gatliff. Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> ACK patch content, but comments about email description / subject line also apply here. - To unsub

Generic Netlink doc now wiki-ized

2006-12-04 Thread Paul Moore
Clicky clicky... * http://linux-net.osdl.org/index.php/Generic_Netlink_HOWTO I took the latest version of the text document and put it on the OSDL networking wiki. The content is unchanged but I messed with the formatting a fair amount so it meshed with the wiki formatting. That said, I will

Re: [PATCH 1/1] myri10ge: write as 2 32-byte blocks in myri10ge_submit_8rx

2006-12-04 Thread Jeff Garzik
Brice Goglin wrote: In the myri10ge_submit_8rx() routine, write the 64 byte request block as 2 32-byte blocks so that it is handled by the hardware pio write handler if write-combining is enabled. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c |4 +++- 1

Re: Intel 82559 NIC corrupted EEPROM

2006-12-04 Thread Jesse Brandeburg
On 12/1/06, John <[EMAIL PROTECTED]> wrote: > can you try adding mdelay(100); in e100_eeprom_load before the for loop, > and then change the multiple udelay(4) to mdelay(1) in e100_eeprom_read I applied the attached patch. Loading the driver now takes around one minute :-) ouch, but yep, that

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-04 Thread Ivo van Doorn
Hi, > > This patch is a resend of a patch I has been send to the linux kernel > > and netdev list earlier. The most recent version of a few weeks back > > didn't compile since I missed 1 line in my patch that changed > > include/linux/input.h. > > > > This patch will offer the handling of radiokey

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-12-04 Thread Greg KH
On Fri, Dec 01, 2006 at 02:08:28AM +0100, Rafael J. Wysocki wrote: > On Thursday, 30 November 2006 22:32, Rafael J. Wysocki wrote: > > [Trimmed the Cc list a bit.] > > > > On Thursday, 30 November 2006 22:12, Andrew Morton wrote: > > > On Thu, 30 Nov 2006 21:21:27 +0100 > > > "Rafael J. Wysocki" <

[patch 5/8] declance: Fix PMAX and PMAD support

2006-12-04 Thread akpm
From: "Maciej W. Rozycki" <[EMAIL PROTECTED]> The shared buffer used by the LANCE on the PMAX only supports halfword (16-bit) accesses. And the PMAD has the buffer wired differently. This is a change to fix these issues. Tested with a DECstation 2100 (thanks Flo for making this possible) and a

[patch 6/8] declance: Support the I/O ASIC LANCE w/o TURBOchannel

2006-12-04 Thread akpm
From: "Maciej W. Rozycki" <[EMAIL PROTECTED]> The onboard LANCE of I/O ASIC systems is not a TURBOchannel device, at least from the software point of view. Therefore it does not rely on any kernel TURBOchannel bus services and can be supported even if support for TURBOchannel has not been enabled

[patch 1/8] Update smc91x driver with ARM Versatile board info

2006-12-04 Thread akpm
From: Deepak Saxena <[EMAIL PROTECTED]> We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new generic IRQ layer will complain thusly: No IRQF_TRIGGER set_type function for IRQ 25 () Signed-off-by: Deepak Saxena <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Russell

[patch 4/8] bonding: incorrect bonding state reported via ioctl

2006-12-04 Thread akpm
From: Andy Gospodarek <[EMAIL PROTECTED]> This is a small fix-up to finish out the work done by Jay Vosburgh to add carrier-state support for bonding devices. The output in /proc/net/bonding/bondX was correct, but when collecting the same info via an iotcl it could still be incorrect. Signed-off

[patch 7/8] sk98lin debug build fix

2006-12-04 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Fix parenthesis mismatch. Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/sk98lin/skgesirq.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/net/sk98lin/skgesirq.c~sk98lin-debug-build-fix drivers/net/sk98

[patch 2/8] 8139too: force media setting cleanup

2006-12-04 Thread akpm
From: Bernard Lee <[EMAIL PROTECTED]> Setting bit 4 & 5 alone in 8139too module media option does not really force 100Mbps full-duplex mode. When media option bit 0-3 is cleared, 8139too module does not force media setting. Therefore, bit 0-3 requires to be set for bit 4 & 5 to take effect. The

[patch 8/8] net: smc91x add missing bracket

2006-12-04 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/smc91x.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/net/smc91x.h~net-smc91x-add-missing-bracket driv

[patch 1/1] atm: Add CPPFLAGS to byteorder.h check

2006-12-04 Thread akpm
From: Ben Collins <[EMAIL PROTECTED]> O= builds produced errors in the shell command because of unfound headers. Signed-off-by: Ben Collins <[EMAIL PROTECTED]> Cc: chas williams <[EMAIL PROTECTED]> Cc: Sam Ravnborg <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EM

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-04 Thread Dmitry Torokhov
On 12/3/06, Ivo van Doorn <[EMAIL PROTECTED]> wrote: Hi, This patch is a resend of a patch I has been send to the linux kernel and netdev list earlier. The most recent version of a few weeks back didn't compile since I missed 1 line in my patch that changed include/linux/input.h. This patch wil

Re: [RFC][GENETLINK] move command capabilities to flags

2006-12-04 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-12-04 16:07 > On Mon, 2006-04-12 at 19:00 +0100, Thomas Graf wrote: > > * jamal <[EMAIL PROTECTED]> 2006-12-04 12:48 > > > > We can resolve that by uping the version for the controller. > > > User will use that a signal. > > > > Good idea, makes me happy :-) pleas

Re: [PATCH] Add Broadcom PHY support

2006-12-04 Thread Benjamin Herrenschmidt
On Fri, 2006-09-15 at 16:15 -0400, Amy Fong wrote: > [PATCH] Add Broadcom PHY support > > This patch adds a driver to support the bcm5421s and bcm5461s PHY > > Kernel version: linux-2.6.18-rc6 > > Signed-off-by: Amy Fong Some 5421's need special initialisation (see drivers/net/sungem_phy.c),

Re: [PATCH 2/10] cxgb3 - main source file

2006-12-04 Thread Stephen Hemminger
O > + * If we have multiple receive queues per port serviced by NAPI we need one > + * netdevice per queue as NAPI operates on netdevices. We already have one > + * netdevice, namely the one associated with the interface, so we use dummy > + * ones for any additional queues. Note that these netde

[RFC][GENETLINK] move command capabilities to flags

2006-12-04 Thread jamal
On Mon, 2006-04-12 at 19:00 +0100, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-12-04 12:48 > > We can resolve that by uping the version for the controller. > > User will use that a signal. > > Good idea, makes me happy :-) please do that in your patch as well. Ok, here she goes... If

[PATCH][XFRM] Optimize SA dumping

2006-12-04 Thread jamal
The SA version cheers, jamal [XFRM] Optimize SA dumping Same comments as in "[XFRM] Optimize policy dumping" The numbers are (20K SAs): -- 1) before the change .. speedopolis:~# time ./ip xf sta real0m5.321s user0m0.004s sys 0m5.316s 2) after the change ... speedopolis:~# tim

[PATCH][XFRM] Optimize policy dumping

2006-12-04 Thread jamal
Dave, This one has undergone more scrutiny and testing. Against net-2.6.20 cheers, jamal [XFRM] Optimize policy dumping This change optimizes the dumping of Security policies. 1) Before this change .. speedopolis:~# time ./ip xf pol real0m22.274s user0m0.000s sys 0m22.269s 2) Turn

Re: [PATCH][XFRM] Optimize policy dumping

2006-12-04 Thread jamal
On Mon, 2006-04-12 at 18:59 +0100, Patrick McHardy wrote: > jamal wrote: > I'd prefer if you did it since you're already testing the thing :) Ok, will do shortly. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

[PATCH 1/10] cxgb3 - main header files

2006-12-04 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the main header files of the Chelsio T3 network driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h | 250 drivers/net/cxgb3/common.h | 704 ++

[PATCH 10/10] cxgb3 - build files and versioning

2006-12-04 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements build files and versioning for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/Kconfig | 18 ++ drivers/net/Makefile|1 + drivers/net/cxgb3/

[PATCH 4/10] cxgb3 - HW access routines - _REAL_ part 2

2006-12-04 Thread divy
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the HW access routines for the Chelsio T3 network adapter's driver. This patch is split. This is the second part. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> -- +/** + * t3_sge_cqcntxt_op - perform an operation on a completion que

[PATCH 9/10] cxgb3 - register definitions

2006-12-04 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the registers definitions for the Chelsio network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h | 2177 ++ 1 files changed, 2177 insertions(+),

[PATCH 6/10] cxgb3 - on board memory, MAC and PHY

2006-12-04 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements on board memory, MAC and PHY management for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/ael1002.c | 231 ++ drivers/net/cxgb3/mc5.c | 456 +

[PATCH 7/10] cxgb3 - offload header files

2006-12-04 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the offload operations header files for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_ctl_defs.h | 142 drivers/net/cxgb3/cxgb3_defs.h | 99 ++ drivers/n

[PATCH 8/10] cxgb3 - offload capabilities

2006-12-04 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the offload capabilities of the Chelsio network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_offload.c | 1219 + drivers/net/cxgb3/l2t.c | 4

Re: [patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

2006-12-04 Thread Andy Fleming
On Nov 30, 2006, at 12:07, Maciej W. Rozycki wrote: On Mon, 23 Oct 2006, Maciej W. Rozycki wrote: I'm not too enthusiastic about requiring the ethernet drivers to call phy_disconnect in a separate thread after "close" is called. Assuming there's not some sort of "squash work queue" functi

[PATCH 0/10] cxgb3: Chelsio T3 1G/10G ethernet device driver

2006-12-04 Thread Divy Le Ray
Hi, I resubmit the patch supporting the latest Chelsio T3 adapter. It incoporpates feedbacks from Stephen and Jan. This patch adds support for the latest Chelsio adapter, T3. It is built against 2.6.19. A corresponding monolithic patch against 2.6.19 is posted at the following URL: http://servi

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Stephen Hemminger
On Mon, 04 Dec 2006 10:01:01 -0800 Dan Nicolaescu <[EMAIL PROTECTED]> wrote: > > Hi, > > Here is a driver for the Opencores Ethernet Controller. I started from > a 2.4 uClinux driver, ported it to 2.6, made it work, cleaned it up > and added the MII interface. > > The Opencores Ethernet Contro

network devices don't handle pci_dma_mapping_error()'s

2006-12-04 Thread Stephen Hemminger
On Sat, 02 Dec 2006 00:32:55 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Amit S. Kale wrote: > > NetXen: 1G/10G Ethernet driver updates > > - These fixes take care of driver on machines with >4G memory > > - Driver cleanup > > > > Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> > > >

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Dan Nicolaescu
Lennert Buytenhek <[EMAIL PROTECTED]> writes: > On Mon, Dec 04, 2006 at 10:01:01AM -0800, Dan Nicolaescu wrote: > > > The Opencores Ethernet Controller is Verilog code that can be used to > > implement an Ethernet device in hardware. It needs to be coupled with > > a PHY and some buffer

Re: NETDEV-BCM43XX BUG - Failure to associate AP with latest devscape git pull..

2006-12-04 Thread Paul Collins
Dan Williams <[EMAIL PROTECTED]> writes: > On Mon, 2006-12-04 at 21:30 +1300, Paul Collins wrote: >> Robert Martin <[EMAIL PROTECTED]> writes: >> >> > I seem to be having a problem associating with my AP--everything >> > appears fine and I can bring my wireless adapter up (the LED lights up >> >

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Lennert Buytenhek
On Mon, Dec 04, 2006 at 10:01:01AM -0800, Dan Nicolaescu wrote: > The Opencores Ethernet Controller is Verilog code that can be used to > implement an Ethernet device in hardware. It needs to be coupled with > a PHY and some buffer memory. Because of that devices that implement > this controller c

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 3

2006-12-04 Thread Stephen Hemminger
On 04 Dec 2006 14:50:24 +0200 Andrew Victor <[EMAIL PROTECTED]> wrote: > A minor fix to the Atmel AT91RM9200 Ethernet driver. > > 1. Use dev_alloc_skb() instead of alloc_skb(). > 2. It is not necessary to adjust skb->len manually. > > > Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> > > > d

[RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Dan Nicolaescu
Hi, Here is a driver for the Opencores Ethernet Controller. I started from a 2.4 uClinux driver, ported it to 2.6, made it work, cleaned it up and added the MII interface. The Opencores Ethernet Controller is Verilog code that can be used to implement an Ethernet device in hardware. It needs to

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 2

2006-12-04 Thread Stephen Hemminger
On 04 Dec 2006 14:42:08 +0200 Andrew Victor <[EMAIL PROTECTED]> wrote: > This patch adds NetPoll / NetConsole support to the Atmel AT91RM9200 > Ethernet driver. > > Original patch from Bill Gatliff. > > > Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> > > > diff -urN linux-2.6.19-final.orig

Re: [RFC][GENETLINK] move command capabilities to flags

2006-12-04 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-12-04 12:48 > On Mon, 2006-04-12 at 17:31 +0100, Thomas Graf wrote: > > * jamal <[EMAIL PROTECTED]> 2006-12-04 08:01 > > > The savings bytes is one aspect; the other is the cleanliness. > > > transfering a boolean in that many bits is a little of overkill. > > > I t

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 1

2006-12-04 Thread Stephen Hemminger
On 04 Dec 2006 14:26:57 +0200 Andrew Victor <[EMAIL PROTECTED]> wrote: > This patch is an update to the Atmel AT91RM9200 Ethernet driver. > > 1. Remove the global 'at91_dev' variable. > 2. Move the global 'check_timer' variable into the private data > structure. > > > Signed-off-by: Andrew Vic

Re: [PATCH 10/10] chelesio: transmit locking (plus bug fix).

2006-12-04 Thread Stephen Hemminger
On Sun, 3 Dec 2006 11:45:09 +0100 "Eric Lemoine" <[EMAIL PROTECTED]> wrote: > Stephen, > > On 12/2/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > If transmit lock is contended on, then push return code back > > and retry at higher level. > > Looking at qdisc_restart, it seems to me that th

Re: [PATCH][XFRM] Optimize policy dumping

2006-12-04 Thread Patrick McHardy
jamal wrote: > Ok, both looked good except for the test of a single entry. > This was because you would break out of the loop with count of 0. > The patch against yours would look like something attached for the state > case. Dont forget there are two spots on the policy side of things;-> You're r

Re: [RFC][GENETLINK] introduce command names

2006-12-04 Thread jamal
On Mon, 2006-04-12 at 17:34 +0100, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-12-04 08:09 > > Just makes the discovery more knowledgeable. ... ... > > It would be a lot more human friendly to put better readability in the > > commands. > > I don't agree to waste so much text section ju

Re: [RFC][GENETLINK] move command capabilities to flags

2006-12-04 Thread jamal
On Mon, 2006-04-12 at 17:31 +0100, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-12-04 08:01 > > The savings bytes is one aspect; the other is the cleanliness. > > transfering a boolean in that many bits is a little of overkill. > > I think it is better to fix it now than later. > > I know

Re: [PATCH][XFRM] Optimize policy dumping

2006-12-04 Thread jamal
On Mon, 2006-04-12 at 16:55 +0100, Patrick McHardy wrote: > This patch should fix it (and is even simpler), by moving the > check for pol->type != type before sending, we make sure that > last always contains a valid element unless count == 0. > > Also fixed an incorrect gcc warning about last_d

Re: Network virtualization/isolation

2006-12-04 Thread Daniel Lezcano
Dmitry Mishin wrote: On Monday 04 December 2006 19:43, Herbert Poetzl wrote: On Mon, Dec 04, 2006 at 06:19:00PM +0300, Dmitry Mishin wrote: On Sunday 03 December 2006 19:00, Eric W. Biederman wrote: Ok. Just a quick summary of where I see the discussion. We all agree that L2 isolation is nee

Re: RFC: consistent disable_xfrm behaviour

2006-12-04 Thread Alexey Kuznetsov
Hello! > Here's the patch again properly signed off. I think it is correct. Alexey - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] NetXen: whitespace cleaup and more cleanup fixes

2006-12-04 Thread Amit S. Kale
Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> netxen_nic.h | 56 -- netxen_nic_ethtool.c | 53 +--- netxen_nic_hdr.h |6 ++--- netxen_nic_hw.c | 54 +---

Re: Network virtualization/isolation

2006-12-04 Thread Herbert Poetzl
On Mon, Dec 04, 2006 at 08:02:48PM +0300, Dmitry Mishin wrote: > On Monday 04 December 2006 19:43, Herbert Poetzl wrote: > > On Mon, Dec 04, 2006 at 06:19:00PM +0300, Dmitry Mishin wrote: > > > On Sunday 03 December 2006 19:00, Eric W. Biederman wrote: > > > > Ok. Just a quick summary of where I s

Re: [PATCH] [IPVS] transparent proxying

2006-12-04 Thread Wensong Zhang
Hi Jinhua, home_king wrote: > I am afraid that the method used in the patch is not native, it breaks > on IP fragments. > IPVS is a kind of layer-4 switching, it routes packet by checking > layer-4 information > such as address and port number. ip_vs_in() is hooked at NF_IP_LOCAL_IN, so > that

[PATCH 0/2] NetXen: 1G/10G Ethernet Driver updates

2006-12-04 Thread Amit S. Kale
Hi All, We have incorporated feedbacks received during last post. We have removed bounce buffer as well. I will be sending patches shortly. These patches are wrt netdev#master. Thanks, --Amit - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL P

[patch] add net_device_stats support to ethtool

2006-12-04 Thread Dan Nicolaescu
Hi, "ethtool -S" only supports devices that have custom code written to print the stats. A lot of drivers use "struct net_device_stats", so adding code to ethtool would make it very easy for such drivers to add support for "ethtool -S". The drivers would just need to add this: .get_strin

Re: Network virtualization/isolation

2006-12-04 Thread Dmitry Mishin
On Monday 04 December 2006 19:43, Herbert Poetzl wrote: > On Mon, Dec 04, 2006 at 06:19:00PM +0300, Dmitry Mishin wrote: > > On Sunday 03 December 2006 19:00, Eric W. Biederman wrote: > > > Ok. Just a quick summary of where I see the discussion. > > > > > > We all agree that L2 isolation is needed

Re: RFC: consistent disable_xfrm behaviour

2006-12-04 Thread Patrick McHardy
Alexey Kuznetsov wrote: > Hello! > > >>Alexey, do you remember what the original intent of this was? > > > disable_policy was supposed to skip policy checks on input. > It makes sense only on input device. > > disable_xfrm was supposed to skip transformations on output. > It makes sense only o

Re: Network virtualization/isolation

2006-12-04 Thread Eric W. Biederman
Herbert Poetzl <[EMAIL PROTECTED]> writes: > On Mon, Dec 04, 2006 at 06:19:00PM +0300, Dmitry Mishin wrote: >> On Sunday 03 December 2006 19:00, Eric W. Biederman wrote: >> > Ok. Just a quick summary of where I see the discussion. >> > >> > We all agree that L2 isolation is needed at some point.

Re: [NET_SCHED]: cls_fw: fix NULL pointer dereference

2006-12-04 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2006-12-04 17:39 > It just seems this code is entirely useless and the only > thing it does is cause short term unexpected behaviour > during the race I mentioned. Yes, the whole head == NULL branch should be removed. > One thing we should probably do is to m

  1   2   >