Re: [Bug 7635] New: ioctl(fd,TCSBRK,1) on socket yields EFAULT, expected EINVAL/ENOTTY

2006-12-09 Thread Eric Dumazet
David Miller a écrit : From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 8 Dec 2006 14:00:21 -0800 That is not true on BSD or other unix standardish ioctl's. There are no conflicts between the TIOC... values and the SIOC... values There is absolutely nothing that we can do about this und

Re: [Devel] Re: Network virtualization/isolation

2006-12-09 Thread Eric W. Biederman
Herbert Poetzl <[EMAIL PROTECTED]> writes: > On Fri, Dec 08, 2006 at 12:57:49PM -0700, Eric W. Biederman wrote: >> Herbert Poetzl <[EMAIL PROTECTED]> writes: >> >> >> But, ok, it is not the real point to argue so much imho >> >> and waste our time instead of doing things. > >> > well, IMHO bette

[PATCH 0/4] d80211: some header cleanups

2006-12-09 Thread Michael Wu
This patch series implements parts of the 802.11 header cleanup suggestion (http://www.spinics.net/lists/netdev/msg12124.html). It moves the general 802.11 stuff out of net/d80211.h and into the new linux/ieee80211.h. d80211_shared.h is merged into d80211.h. d80211_mgmt.h is merged into linux/i

[PATCH 3/4] d80211: merge d80211_mgmt.h into linux/ieee80211.h

2006-12-09 Thread Michael Wu
d80211: merge d80211_mgmt.h into linux/ieee80211.h This merges d80211_mgmt.h with linux/ieee80211.h, to keep all the general 802.11 definitions in one place. Signed-off-by: Michael Wu <[EMAIL PROTECTED]> --- drivers/net/wireless/d80211/bcm43xx/bcm43xx.h |1 include/linux/ieee80211.h

[PATCH 1/4] d80211: move 802.11 defines to linux/ieee80211.h

2006-12-09 Thread Michael Wu
d80211: move 802.11 defines to linux/ieee80211.h This moves 802.11 defines from net/d80211.h into linux/ieee80211.h. It also renames IEEE80211_DATA_LEN to IEEE80211_MAX_DATA_LEN to better match the other definitions. Signed-off-by: Michael Wu <[EMAIL PROTECTED]> --- include/linux/Kbuild |

[PATCH 4/4] d80211: move d80211_common.h to net/d80211

2006-12-09 Thread Michael Wu
d80211: move d80211_common.h to net/d80211 This moves d80211_common.h to net/d80211/ieee80211_common.h since d80211 drivers should not include this file. Signed-off-by: Michael Wu <[EMAIL PROTECTED]> --- drivers/net/wireless/d80211/bcm43xx/bcm43xx.h |1 include/net/d80211_common.h

[PATCH 2/4] d80211: merge d80211_shared.h into d80211.h

2006-12-09 Thread Michael Wu
merge d80211_shared.h into d80211.h This merges d80211_shared.h into d80211.h. Signed-off-by: Michael Wu <[EMAIL PROTECTED]> --- include/net/d80211.h| 32 +- include/net/d80211_shared.h | 46 --- 2 files changed, 31

Please make CONFIG_CFG80211 harder to enable

2006-12-09 Thread Pavel Roskin
Hello! Somebody please mark CONFIG_CFG80211 in wireless-dev.git as experimental/broken/incomplete/whatever. Not only doesn't it work, but it also breaks Wireless Extensions if enabled, even if CONFIG_D80211 is disabled. Driver developers should know that if they enable CONFIG_CFG80211 they won't

Re: [Bug 7635] New: ioctl(fd,TCSBRK,1) on socket yields EFAULT, expected EINVAL/ENOTTY

2006-12-09 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Sat, 09 Dec 2006 09:06:27 +0100 > Well, as long you/we dont break isattty() (which try an > ioctl(fd,TCGETS,&termios) on the fd), it should be OK. > > So TCGETS *MUST* return an error on a socket (and other non tty files) Actually, did anyone actuall

Re: [PATCH 2.6.17.13 2/2] LARTC: trace control for netem: kernelspace

2006-12-09 Thread Rainer Baumann
Hi Stephens I just wanted to ask you if everything went right with TCN and we will find it in 2.6.20 as you wrote two months ago. Cheers Rainer Stephen Hemminger wrote: > On Tue, 26 Sep 2006 22:17:57 +0200 > Rainer Baumann <[EMAIL PROTECTED]> wrote: > > >> Hi Stephens >> >> We merged your cha

Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-09 Thread Stefan Rompf
Am Freitag, 8. Dezember 2006 22:33 schrieb David Miller: > [IF(L)A_(RTA|PAYLOAD) macros] > > iproute got fixed, dhcpclient and friends should get fixed to not use > them either Today's git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git contains stuff like #ifndef IFA_RTA #def

[NETLINK]: Schedule removal of old macros exported to userspace

2006-12-09 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/Documentation/feature-removal-schedule.txt === --- net-2.6.orig/Documentation/feature-removal-schedule.txt 2006-12-09 11:29:25.0 +0100 +++ net-2.6/Documentati

Re: [Devel] Re: Network virtualization/isolation

2006-12-09 Thread Tomasz Torcz
On Sat, Dec 09, 2006 at 04:50:02AM +0100, Herbert Poetzl wrote: > On Fri, Dec 08, 2006 at 12:57:49PM -0700, Eric W. Biederman wrote: > > Herbert Poetzl <[EMAIL PROTECTED]> writes: > > > > >> But, ok, it is not the real point to argue so much imho > > >> and waste our time instead of doing things.

Re: [PATCH 04/26] rt2x00: EEPROM 93Cx6

2006-12-09 Thread Ivo Van Doorn
Hi > I have checked the adm80211 code as well, it seems to behave quite the > same, with the most notable difference the fact that adm80211 writes the > READ_OPCODE and the word index within a single command, while in > eeprom_93cx6 this is split into 2 seperate write commands. > I have not yet

Re: e100 breakage located

2006-12-09 Thread Amin Azez
Jesse Brandeburg wrote: sorry for the delay, your mail got marked as spam. In the future please copy networking issues to netdev@vger.kernel.org, and be sure to copy the maintainers of the driver you're having problems with (they are in the MAINTAINERS file) On 11/22/06, Amin Azez <[EMAIL PROTE

Re: [NETLINK]: Schedule removal of old macros exported to userspace

2006-12-09 Thread Stefan Rompf
Am Samstag, 9. Dezember 2006 11:39 schrieb Thomas Graf: [Added linux-kernel to CC] > Index: net-2.6/Documentation/feature-removal-schedule.txt > === > --- net-2.6.orig/Documentation/feature-removal-schedule.txt 2006-12-09 NAK. >

Re: [NETLINK]: Schedule removal of old macros exported to userspace

2006-12-09 Thread Thomas Graf
* Stefan Rompf <[EMAIL PROTECTED]> 2006-12-09 12:49 > Am Samstag, 9. Dezember 2006 11:39 schrieb Thomas Graf: > > [Added linux-kernel to CC] > > > Index: net-2.6/Documentation/feature-removal-schedule.txt > > === > > --- net-2.6.orig

Re: [NETLINK]: Schedule removal of old macros exported to userspace

2006-12-09 Thread Stefan Rompf
Am Samstag, 9. Dezember 2006 13:55 schrieb Thomas Graf: > Please calm down a bit. I didn't claim that glibc should be linking to > libnl. glibc is obviously a special case which can simply copy the existing > macros into some internal compat header just like any other application > that doesn't wi

Re: [Devel] Re: Network virtualization/isolation

2006-12-09 Thread Herbert Poetzl
On Sat, Dec 09, 2006 at 12:27:34PM +0100, Tomasz Torcz wrote: > On Sat, Dec 09, 2006 at 04:50:02AM +0100, Herbert Poetzl wrote: > > On Fri, Dec 08, 2006 at 12:57:49PM -0700, Eric W. Biederman wrote: > > > Herbert Poetzl <[EMAIL PROTECTED]> writes: > > > > > > >> But, ok, it is not the real point t

Re: Please make CONFIG_CFG80211 harder to enable

2006-12-09 Thread John W. Linville
On Sat, Dec 09, 2006 at 03:48:43AM -0500, Pavel Roskin wrote: > Hello! > > Somebody please mark CONFIG_CFG80211 in wireless-dev.git as > experimental/broken/incomplete/whatever. Not only doesn't it work, but > it also breaks Wireless Extensions if enabled, even if CONFIG_D80211 is > disabled. >

Re: [Devel] Re: Network virtualization/isolation

2006-12-09 Thread Dmitry Mishin
On Saturday 09 December 2006 09:35, Herbert Poetzl wrote: > On Fri, Dec 08, 2006 at 10:13:48PM -0800, Andrew Morton wrote: > > On Sat, 9 Dec 2006 04:50:02 +0100 > > Herbert Poetzl <[EMAIL PROTECTED]> wrote: > > > > > On Fri, Dec 08, 2006 at 12:57:49PM -0700, Eric W. Biederman wrote: > > > > Herber

Re: [NETLINK]: Schedule removal of old macros exported to userspace

2006-12-09 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Sat, 9 Dec 2006 11:39:53 +0100 > +What:Netlink message and attribute parsing macros > +When:July 2007 > +Why: The old interface which often lead to buggy code has been replaced > + with a new type safe interface. Parts of this interfa

[PATCH] d80211: Fix errorcode in ieee80211_update_hw

2006-12-09 Thread Michael Buesch
ieee80211_update_hw should return a proper error code instead of hardcoded -1. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c === --- wireless-dev.orig/net/d80211/ieee80211.c2006-12-0

Re: [Devel] Re: Network virtualization/isolation

2006-12-09 Thread Kir Kolyshkin
Herbert Poetzl wrote: On Fri, Dec 08, 2006 at 10:13:48PM -0800, Andrew Morton wrote: It's actually happening quite gradually and carefully. hmm, I must have missed a testing phase for the IPC namespace then, not that I think it is broken (well, maybe it is, we do not know yet) You

Re: [NETLINK]: Schedule removal of old macros exported to userspace

2006-12-09 Thread Thomas Graf
* David Miller <[EMAIL PROTECTED]> 2006-12-09 13:45 > You can't deprecate stuff visible to userspace, sorry Thomas, > we just can't do it. It has been done before but I don't want to drag this on any further. I did what I found to be right and obviously I've hit a wall. > Once idea I have is that

Re: [PATCH] 2.6 driver for Silan SC92031 (second try)

2006-12-09 Thread Cesar Eduardo Barros
Andrew Morton escreveu: > On Fri, 08 Dec 2006 18:17:06 -0200 > Cesar Eduardo Barros <[EMAIL PROTECTED]> wrote: > >> From: Cesar Eduardo Barros <[EMAIL PROTECTED]> >> >> +} while(unlikely(cmpxchg(&priv->intr_status, > > You'll have the arm maintainer after you with a pointy stick. > > cmpxchg

Re: [NETLINK]: Schedule removal of old macros exported to userspace

2006-12-09 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Sat, 9 Dec 2006 13:55:33 +0100 > The point is to stop new applications from using the interface which has > resulted in buggy code in the past. You don't get people to use new interface by breaking the build on them in userspace. You get them to do it

Re: [NETLINK]: Schedule removal of old macros exported to userspace

2006-12-09 Thread David Miller
From: Stefan Rompf <[EMAIL PROTECTED]> Date: Sat, 9 Dec 2006 15:58:01 +0100 (MET) > But when even glibc needs internal compat headers to compile with the second > kernel version that provides userspace headers, what is the long-term - even > mid-term - perspective of make headers_install then?

Re: [NETLINK]: Schedule removal of old macros exported to userspace

2006-12-09 Thread David Woodhouse
On Sat, 2006-12-09 at 15:58 +0100, Stefan Rompf wrote: > But when even glibc needs internal compat headers to compile with the second > kernel version that provides userspace headers, what is the long-term - even > mid-term - perspective of make headers_install then? We've only _just_ started pa

Re: [NETLINK]: Schedule removal of old macros exported to userspace

2006-12-09 Thread Jeff Bailey
On 09/12/06, David Miller <[EMAIL PROTECTED]> wrote: You can't deprecate stuff visible to userspace, sorry Thomas, we just can't do it. You can migrate people to "better" interfaces, but you can't pull the rug out from anyone once things like this are visible to userspace. It's permanently ther

Re: [NETLINK]: Schedule removal of old macros exported to userspace

2006-12-09 Thread Al Viro
On Sat, Dec 09, 2006 at 08:42:45PM -0500, Jeff Bailey wrote: > On 09/12/06, David Miller <[EMAIL PROTECTED]> wrote: > >You can't deprecate stuff visible to userspace, sorry Thomas, > >we just can't do it. > > > >You can migrate people to "better" interfaces, but you can't > >pull the rug out from a

Re: [Devel] Re: Network virtualization/isolation

2006-12-09 Thread Herbert Poetzl
On Sun, Dec 10, 2006 at 01:34:14AM +0300, Kir Kolyshkin wrote: > Herbert Poetzl wrote: > >On Fri, Dec 08, 2006 at 10:13:48PM -0800, Andrew Morton wrote: > > > >> > >>It's actually happening quite gradually and carefully. > >> > > > >hmm, I must have missed a testing phase for the > >IPC names