On Mon, Apr 23, 2007 at 08:44:16AM +0200, Jarek Poplawski wrote:
On Fri, Apr 20, 2007 at 04:35:15PM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Mon, 12 Mar 2007 11:24:03 +0100
the ipcomp handler is xfrm6_rcv(), which calls xfrm6_rcv_spi(), which
On Tue, 24 Apr 2007, Herbert Xu wrote:
Hmm, *sigh*. I guess the patch below fixes the problem, but it is a
masterpiece in the field of ugliness. And I am not sure whether it is
completely correct either. Are there any immediate ideas for better
solution with respect to how struct sock
On Fri, 20 Apr 2007 18:51:13 +0900
Keiichi KII [EMAIL PROTECTED] wrote:
I started to do some cleanups and fixups here, but abandoned it when it was
all getting a bit large.
Here are some fixes against this patch:
I'm going to fix my patches by following your reviews and send new patches
on
We don't really have anything that corresponds to netpoll's
connections at higher levels.
I'm tempted to say we should make this work more like the dummy
network device. ie:
modprobe netconsole -o netcon1 [params]
modprobe netconsole -o netcon2 [params]
The configuration of netconsole's looks
Dear Stephen,
Unfortunately the problems with sky2 started again.
From time to time NIC stops working. The system log contains the following
messages:
Apr 24 11:50:43 bullet-lin kernel: sky2 eth0: Link is up at 1000 Mbps, full
duplex, flow control both
Apr 24 11:51:55 bullet-lin kernel: sky2
On Tue, 24 Apr 2007 17:14:28 +0900 Keiichi KII [EMAIL PROTECTED] wrote:
On Fri, 20 Apr 2007 18:51:13 +0900
Keiichi KII [EMAIL PROTECTED] wrote:
I started to do some cleanups and fixups here, but abandoned it when it
was
all getting a bit large.
Here are some fixes against this
This patch adds a comment that was part of my rtnl locking patch for
cfg80211 but which I forgot for the merge.
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
---
include/net/cfg80211.h |4
1 file changed, 4 insertions(+)
--- net-2.6.22.orig/include/net/cfg80211.h 2007-04-24
Oleg Nesterov [EMAIL PROTECTED] wrote:
We only care when del_timer() returns true. In that case, if the timer
function still runs (possible for single-threaded wqs), it has already
passed __queue_work().
Why do you assume that?
Sorry, I should have been more clear. I meant the
Peter Trifonov wrote:
I am running 2.6.20.4 X86-64 kernel
2.6.20.7 has an update for sky2.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Broken by 4a1728a28a193aa388900714bbb1f375e08a6d8e which switched the
return semantics of read_mii_word() but didn't fix usage of
read_mii_word() to conform to the new semantics.
Setting carrier to off based on the NO_CARRIER flag is also incorrect as
that flag only triggers on TX failure and
On 04/24, David Howells wrote:
Oleg Nesterov [EMAIL PROTECTED] wrote:
We only care when del_timer() returns true. In that case, if the timer
function still runs (possible for single-threaded wqs), it has already
passed __queue_work().
Why do you assume that?
Sorry, I
On Tue, 24 Apr 2007 12:24:51 +0400
Peter Trifonov [EMAIL PROTECTED] wrote:
Dear Stephen,
Unfortunately the problems with sky2 started again.
From time to time NIC stops working. The system log contains the following
messages:
Apr 24 11:50:43 bullet-lin kernel: sky2 eth0: Link is up at
Recent ktime_t changes had introduced linkage errors.
| WARNING: __divdi3 [net/ipv4/tcp_veno.ko] undefined!
| WARNING: __divdi3 [net/ipv4/tcp_vegas.ko] undefined!
| WARNING: __divdi3 [net/ipv4/tcp_lp.ko] undefined!
| WARNING: __divdi3 [net/ipv4/tcp_illinois.ko] undefined!
Signed-off-by:
On Tue, 24 Apr 2007 01:29:02 -0700
Andrew Morton [EMAIL PROTECTED] wrote:
On Tue, 24 Apr 2007 17:14:28 +0900 Keiichi KII [EMAIL PROTECTED] wrote:
On Fri, 20 Apr 2007 18:51:13 +0900
Keiichi KII [EMAIL PROTECTED] wrote:
I started to do some cleanups and fixups here, but abandoned it
Dear Stephen,
I bet you have 88e8056 chip. There is some problem with the
Yes.
bus interface and the sky2 driver (and the vendor sk98lin
driver), that causes all sorts of out of order device access
problems. Still investigating
Windows driver works perfectly with it...
I can give
In article [EMAIL PROTECTED] (at Tue, 24 Apr 2007 17:53:24 +0200), Adrian
Bunk [EMAIL PROTECTED] says:
On Wed, Apr 25, 2007 at 12:17:43AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote:
Recent ktime_t changes had introduced linkage errors.
| WARNING: __divdi3 [net/ipv4/tcp_veno.ko] undefined!
|
James Chapman wrote:
+static void pppol2tp_recv_dequeue(struct pppol2tp_session *session)
+{
+ struct sk_buff *skb;
+ struct sk_buff *tmp;
+
+ /* If the pkt at the head of the queue has the nr that we
+ * expect to send up next, dequeue it and any other
+ *
On Tue, 24 Apr 2007 17:53:24 +0200
Adrian Bunk [EMAIL PROTECTED] wrote:
Couldn't this be better solved by adding something like the following
to include/linux/ktime.h ?
static inline s64 ktime_to_us(const ktime_t kt)
{
return (s64) kt.tv.sec * USEC_PER_SEC + kt.tv.nsec / NSEC_PER_USEC;
On Tue, 24 Apr 2007 19:22:34 +0400
Peter Trifonov [EMAIL PROTECTED] wrote:
Dear Stephen,
I bet you have 88e8056 chip. There is some problem with the
Yes.
bus interface and the sky2 driver (and the vendor sk98lin
driver), that causes all sorts of out of order device access
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 00:58:45 +0900 (JST)),
YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] says:
In article [EMAIL PROTECTED] (at Tue, 24 Apr 2007 17:53:24 +0200), Adrian
Bunk [EMAIL PROTECTED] says:
On Wed, Apr 25, 2007 at 12:17:43AM +0900, YOSHIFUJI Hideaki /
Dear Stephen,
Windows driver works perfectly with it...
windows is still 32 bit
I mean WinXP x64. I have not tried 32-bit
Windows and Linux with this NIC.
With best regards,
P. Trifonov
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
On Wed, 25 Apr 2007 01:10:28 +0900 (JST)
YOSHIFUJI Hideaki [EMAIL PROTECTED] wrote:
How about this?
+static inline s64 ktime_to_us(const ktime_t kt)
+{
+ struct timeval tv = ktime_to_timeval(kt);
+ return tv.tv_sec * USEC_PER_SEC + tv.tv_usec;
+}
+
Well, I am afraid it's not
On 04/24, David Howells wrote:
Oleg Nesterov [EMAIL PROTECTED] wrote:
The current code uses del_timer_sync(). It will also return 0. However, it
will spin waiting for timer-function() to complete. So we are just wasting
CPU.
That's my objection to using cancel_delayed_work() as it
Neil Horman wrote:
Hey there-
The sis900 driver appears to have a bug in which the receive routine
passes the skbuff holding the received frame to the network stack before
refilling the buffer in the rx ring. If a new skbuff cannot be allocated, the
driver simply leaves a hole in the rx
Dan Williams wrote:
Broken by 4a1728a28a193aa388900714bbb1f375e08a6d8e which switched the
return semantics of read_mii_word() but didn't fix usage of
read_mii_word() to conform to the new semantics.
Setting carrier to off based on the NO_CARRIER flag is also incorrect as
that flag only triggers
Oleg Nesterov [EMAIL PROTECTED] wrote:
The current code uses del_timer_sync(). It will also return 0. However,
it will spin waiting for timer-function() to complete. So we are just
wasting CPU.
That's my objection to using cancel_delayed_work() as it stands, although in
most cases
On Wed, 25 Apr 2007 01:55:49 +0900 (JST), Atsushi Nemoto [EMAIL PROTECTED]
wrote:
This patch lets RBTX49XX boards use generic platform_driver interface
for the ne driver.
This patch obsolates a patch I send on 1 Mar.
Subject: [PATCH] Fix broken RBTX4927 support in ne.c
Message-Id: [EMAIL
On Tue, Apr 24, 2007 at 12:49:12PM -0400, Jeff Garzik wrote:
Long term, Greg seemed OK with moving the net drivers from drivers/usb/net
to drivers/usb/net, in line with the current policy of placing net drivers
in drivers/net/*, bus agnostic. After that move, sending to netdev and me
This patch lets RBTX49XX boards use generic platform_driver interface
for the ne driver.
* Use platform_device to pass ioaddr and irq to the ne driver.
* Remove unnecessary ifdefs for RBTX49XX from the ne driver.
* Make the ne driver selectable on these boards regardless of CONFIG_ISA
* Add an
Currently ne.c has some codes to support RBTX49XX boards but it is not
complete. Instead of adding more hacks to fix it, this patch add an
generic platform_driver interface to the driver and let RBTX49XX use
it. This is a first step.
* Add platform_driver interface to ne driver.
(Existing
Yoshifuji-san had the right idea, but ktime_to_us needs to be defined
in a way that works on both 64 and 32bit platforms.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
include/linux/ktime.h | 13 +
net/ipv4/tcp_illinois.c |2 +-
net/ipv4/tcp_lp.c |2 +-
On 04/24, David Howells wrote:
Oleg Nesterov [EMAIL PROTECTED] wrote:
Great. I'll send the s/del_timer_sync/del_timer/ patch.
I didn't say I necessarily agreed that this was a good idea. I just meant
that
I agree that it will waste CPU. You must still audit all uses of
Greg KH wrote:
On Tue, Apr 24, 2007 at 12:49:12PM -0400, Jeff Garzik wrote:
Long term, Greg seemed OK with moving the net drivers from drivers/usb/net
to drivers/usb/net, in line with the current policy of placing net drivers
in drivers/net/*, bus agnostic. After that move, sending to
The following casts are unnecessary, just passing void * will do.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
net/core/dev.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 18c51b4..61e9da2 100644
---
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
drivers/net/depca.c |3 +-
drivers/net/hamradio/baycom_ser_fdx.c |6 +++-
drivers/net/sis900.c
Mithlesh Thukral wrote:
hi All,
Thanks Stephen for your suggestion. I am resending the 7 patches
after incorporating the suggestion.
These patches are with respect to netdev#upstream and we wish their inclusion
in 2.6.22 kernel.
Out of these the first 2 patches were already accepted into the
Jan-Bernd Themann wrote:
This patch includes:
- dlpar fix:
certain resources may only be allocated when first
logical port is available, and must be removed when
last logical port has been removed
- sysfs entries:
create symbolic link from each logical port to ehea
Randy Dunlap wrote:
From: Randy Dunlap [EMAIL PROTECTED]
Add kernel-doc notation to drivers/net/mii.c functions.
Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
---
drivers/net/mii.c | 57 ++
1 file changed, 57 insertions(+)
applied
-
To
Kim Phillips wrote:
The RGMII spec allows compliance for devices that implement an internal
delay on TXC or RXC inside the transmitter. This patch adds an RGMII_ID
definition to support RGMII-ID devices in the phylib.
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
this 7 part series
Michael Ellerman wrote:
drivers/net/ibmveth.c:96:46: error: marked inline, but without a definition
drivers/net/ibmveth.c:96: warning: 'ibmveth_rxq_harvest_buffer' declared inline
after being called
drivers/net/ibmveth.c:96: warning: previous declaration of
'ibmveth_rxq_harvest_buffer' was
Stephen Hemminger wrote:
The following casts are unnecessary, just passing void * will do.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
net/core/dev.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index
On Tue, Apr 24, 2007 at 06:03:48PM +0200, Eric Dumazet wrote:
On Tue, 24 Apr 2007 17:53:24 +0200
Adrian Bunk [EMAIL PROTECTED] wrote:
Couldn't this be better solved by adding something like the following
to include/linux/ktime.h ?
static inline s64 ktime_to_us(const ktime_t kt)
{
On Tue, Apr 24, 2007 at 12:49:12PM -0400, Jeff Garzik wrote:
Long term, Greg seemed OK with moving the net drivers from
drivers/usb/net
to drivers/usb/net, in line with the current policy of placing net
drivers
in drivers/net/*, bus agnostic. After that move, sending to netdev and
me
On Tue, Apr 24, 2007 at 10:04:20AM -0700, Stephen Hemminger wrote:
...
+/**
+ * ktime_to_us - convert a ktime_t variable to scalar microseconds
+ * @kt: the ktime_t variable to convert
+ *
+ * Returns the scalar nanoseconds representation of @kt
+ */
+static inline s64
Oleg Nesterov [EMAIL PROTECTED] wrote:
Sure, I'll grep for cancel_delayed_work(). But unless I missed something,
this change should be completely transparent for all users. Otherwise, it
is buggy.
I guess you will have to make sure that cancel_delayed_work() is always
followed by a flush of
Stephen Hemminger a écrit :
+#define ktime_to_us(kt) ((kt).tv64 / NSEC_PER_SEC)
+
#else
Oh dear... how many bogus patches are going to be posted today ?
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
This patch makes two enhancements to msg_set_bits():
1) It now ignores any bits of the new field value that are not
covered by the mask being used. (Previously, if the new value
exceeded the size of the mask the extra bits could corrupt
other fields in the message header word being
Patrick McHardy wrote:
James Chapman wrote:
+static void pppol2tp_recv_dequeue(struct pppol2tp_session *session)
+{
+ struct sk_buff *skb;
+ struct sk_buff *tmp;
+
+ /* If the pkt at the head of the queue has the nr that we
+* expect to send up next, dequeue it and any
On 04/24, David Howells wrote:
Oleg Nesterov [EMAIL PROTECTED] wrote:
Sure, I'll grep for cancel_delayed_work(). But unless I missed something,
this change should be completely transparent for all users. Otherwise, it
is buggy.
I guess you will have to make sure that
http://test.kernel.org/abat/84786/debug/console.log is saying
Starting udevd BUG: at kernel/mutex-debug.c:82 debug_mutex_unlock()
Call Trace:
[80244b71] debug_mutex_unlock+0x161/0x170
[804b759c] __mutex_unlock_slowpath+0x5c/0x160
[80467902] netlink_dump+0x82/0x1e0
On Tue, 2007-04-24 at 20:48 +0300, [EMAIL PROTECTED] wrote:
On Tue, Apr 24, 2007 at 12:49:12PM -0400, Jeff Garzik wrote:
Long term, Greg seemed OK with moving the net drivers from
drivers/usb/net
to drivers/usb/net, in line with the current policy of placing net
drivers
in
On 4/23/07, jamal [EMAIL PROTECTED] wrote:
On Mon, 2007-23-04 at 16:08 -0700, Laurent Chavey wrote:
sorry for the trick question.
I was simply making a modification to the skb tap code
to allow tcpdump to work on the slave interface and not
just the bonded one.
If you dont mind: what is
This patch adds a comment that was part of my rtnl locking patch for
cfg80211 but which I forgot for the merge.
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
Signed-off-by: John W. Linville [EMAIL PROTECTED]
---
include/net/cfg80211.h |4
1 file changed, 4 insertions(+)
---
Results of preliminary tests on net-2.6.22 are available at:
http://developer.osdl.org/shemminger/tcp/net-2.6.22/
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: John W. Linville [EMAIL PROTECTED]
Date: Tue, 24 Apr 2007 16:28:56 -0400
This patch adds a comment that was part of my rtnl locking patch for
cfg80211 but which I forgot for the merge.
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
Signed-off-by: John W. Linville [EMAIL PROTECTED]
From: Andrew Morton [EMAIL PROTECTED]
Date: Tue, 24 Apr 2007 12:42:50 -0700
void debug_mutex_unlock(struct mutex *lock)
{
if (unlikely(!debug_locks))
return;
-- DEBUG_LOCKS_WARN_ON(lock-owner != current_thread_info());
DEBUG_LOCKS_WARN_ON(lock-magic != lock);
Stephen Hemminger wrote:
Results of preliminary tests on net-2.6.22 are available at:
http://developer.osdl.org/shemminger/tcp/net-2.6.22/
Can you redo the hybla graph with a logarithmic scale?
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to
On Tue, 24 Apr 2007 14:20:08 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote:
From: Andrew Morton [EMAIL PROTECTED]
Date: Tue, 24 Apr 2007 12:42:50 -0700
void debug_mutex_unlock(struct mutex *lock)
{
if (unlikely(!debug_locks))
return;
--
From: Jon Paul Maloy [EMAIL PROTECTED]
Date: Tue, 24 Apr 2007 13:21:40 -0400
This patch makes two enhancements to msg_set_bits():
Applied, thanks a lot.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 24 Apr 2007 14:07:32 -0400
Stephen Hemminger wrote:
The following casts are unnecessary, just passing void * will do.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
net/core/dev.c | 10 +-
1 files changed, 5
From: Eric Dumazet [EMAIL PROTECTED]
Date: Tue, 24 Apr 2007 20:48:22 +0200
Stephen Hemminger a écrit :
+#define ktime_to_us(kt)((kt).tv64 / NSEC_PER_SEC)
+
#else
Oh dear... how many bogus patches are going to be posted today ?
Stephen please submit a working
In article [EMAIL PROTECTED] (at Tue, 24 Apr 2007 10:04:20 -0700), Stephen
Hemminger [EMAIL PROTECTED] says:
Yoshifuji-san had the right idea, but ktime_to_us needs to be defined
in a way that works on both 64 and 32bit platforms.
No, this does not cure.
+#define ktime_to_us(kt)
On Tue, 24 Apr 2007 17:19:44 -0400
Chuck Ebbert [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
Results of preliminary tests on net-2.6.22 are available at:
http://developer.osdl.org/shemminger/tcp/net-2.6.22/
Can you redo the hybla graph with a logarithmic scale?
Here it is on a
On Wed, 25 Apr 2007 06:55:39 +0900 (JST)
YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote:
In article [EMAIL PROTECTED] (at Tue, 24 Apr 2007 10:04:20 -0700), Stephen
Hemminger [EMAIL PROTECTED] says:
Yoshifuji-san had the right idea, but ktime_to_us needs to be defined
in a way that
[BNX2]: Fix occasional NETDEV WATCHDOG on 5709.
Tweak a register setting to prevent the tx mailbox from halting.
Update version to 1.5.8.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 0b7aded..e85f5ec 100644
--- a/drivers/net/bnx2.c
On Tue, 2007-04-24 at 14:57 -0700, Stephen Hemminger wrote:
On Wed, 25 Apr 2007 06:55:39 +0900 (JST)
YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote:
In article [EMAIL PROTECTED] (at Tue, 24 Apr 2007 10:04:20 -0700),
Stephen Hemminger [EMAIL PROTECTED] says:
Yoshifuji-san had the
Stephen Hemminger a écrit :
On Wed, 25 Apr 2007 06:55:39 +0900 (JST)
YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote:
In article [EMAIL PROTECTED] (at Tue, 24 Apr 2007 10:04:20 -0700), Stephen
Hemminger [EMAIL PROTECTED] says:
Yoshifuji-san had the right idea, but ktime_to_us needs to be
On Wed, 25 Apr 2007 00:12:38 +0200
Eric Dumazet [EMAIL PROTECTED] wrote:
Stephen Hemminger a écrit :
On Wed, 25 Apr 2007 06:55:39 +0900 (JST)
YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote:
In article [EMAIL PROTECTED] (at Tue, 24 Apr 2007 10:04:20 -0700),
Stephen Hemminger [EMAIL
From: Michael Chan [EMAIL PROTECTED]
Date: Tue, 24 Apr 2007 15:57:45 -0700
[BNX2]: Fix occasional NETDEV WATCHDOG on 5709.
Tweak a register setting to prevent the tx mailbox from halting.
Update version to 1.5.8.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
Applied, thanks Michael.
-
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 00:15:15 +0200), Thomas
Gleixner [EMAIL PROTECTED] says:
On Tue, 2007-04-24 at 14:57 -0700, Stephen Hemminger wrote:
On Wed, 25 Apr 2007 06:55:39 +0900 (JST)
YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote:
In article [EMAIL
handle_bridge does call the tap, so my question is answer there.
thanks,
On 4/24/07, Laurent Chavey [EMAIL PROTECTED] wrote:
On 4/23/07, jamal [EMAIL PROTECTED] wrote:
On Mon, 2007-23-04 at 16:08 -0700, Laurent Chavey wrote:
sorry for the trick question.
I was simply making a
The bridge code by default captures all spanning tree packets and
doesn't forward them. I propose that this might not be a good idea.
If a bridge is not running STP, then it has no way to detect a cycle
in the network (by itself). But if some other machine is running STP,
then if STP BPDU's get
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue, 24 Apr 2007 16:12:26 -0700
The bridge code by default captures all spanning tree packets and
doesn't forward them. I propose that this might not be a good idea.
If a bridge is not running STP, then it has no way to detect a cycle
in the
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED]
Date: Wed, 25 Apr 2007 07:49:32 +0900 (JST)
[TCP]: Fix linkage errors on i386.
To avoid raw division, use ktime_to_timeval() to get usec.
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
This one looks good to me, patch applied.
Thanks.
On Tue, Apr 24, 2007 at 04:12:26PM -0700, Stephen Hemminger wrote:
The bridge code by default captures all spanning tree packets and
doesn't forward them. I propose that this might not be a good idea.
As far as I remember, the original bridge code did pass through BPDUs
when STP was disabled.
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED]
Date: Wed, 25 Apr 2007 00:20:48 +0900 (JST)
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Applied, thanks!
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Jarek Poplawski [EMAIL PROTECTED] wrote:
My proposal is: maybe Eric could change this in
xfrm6_tunnel_rcv() from xfrm6_tunnel.c e.g. like this:
return xfrm6_rcv_spi(skb, spi) 0 ? : 0;
and, if no errors in testing, he could resubmit this patch?
I agree, this is the right fix.
Cheers,
Jeff Garzik [EMAIL PROTECTED] wrote:
@@ -2778,12 +2778,12 @@ int dev_ioctl(unsigned int cmd, void __user *arg)
if (cmd == SIOCGIFCONF) {
rtnl_lock();
- ret = dev_ifconf((char __user *) arg);
+ ret = dev_ifconf(arg);
rtnl_unlock();
David Miller [EMAIL PROTECTED] wrote:
Is it illegal to sleep with a mutex held?
Shouldn't be.
I think I see what might be the problem, nlk-cb_mutex is set
to rtnl_mutex and this is used for other purposes in various
code paths here, maybe there is a double mutex_unlock() or
similar due
This patch makes two enhancements to msg_set_bits():
1) It now ignores any bits of the new field value that are not
covered by the mask being used. (Previously, if the new value
exceeded the size of the mask the extra bits could corrupt
other fields in the message header word being
From: Peter P Waskiewicz Jr [EMAIL PROTECTED]
Signed-off-by: Peter P. Waskiewicz Jr [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
Documentation/networking/multiqueue.txt | 97 +++
1 files changed, 97 insertions(+), 0 deletions(-)
diff --git
From: Peter P Waskiewicz Jr [EMAIL PROTECTED]
Modified tc so PRIO can now have a multiqueue parameter passed to it. This
will turn on multiqueue behavior if a device has more than 1 queue. Also,
running tc qdisc ls dev dev will display if multiqueue is on or off.
Signed-off-by: Peter P.
From: Peter P Waskiewicz Jr [EMAIL PROTECTED]
Update: Fixed band2queue mapping logic - it was reveresed with prio2band.
Added support in the PRIO qdisc to allow tc to turn on multiqueue behavior,
while keeping original PRIO behavior by default. Fixed where
skb-queue_mapping is being reset (prior
This is a redesign and repost of the multiqueue network device support patches.
The new API for base drivers allows multiqueue-capable devices to manage their
individual queues in the network stack. The stack now handles both
non-multiqueue and multiqueue devices on the same codepath. Also,
YOSHIFUJI Hideaki / [EMAIL PROTECTED] wrote:
diff --git a/net/ipv4/Makefile b/net/ipv4/Makefile
index 4ff6c15..3bd25f5 100644
--- a/net/ipv4/Makefile
+++ b/net/ipv4/Makefile
@@ -10,11 +10,11 @@ obj-y := route.o inetpeer.o protocol.o \
tcp_minisocks.o tcp_cong.o \
Hello.
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 12:35:49 +1000), Herbert Xu
[EMAIL PROTECTED] says:
This makes no sense. Why should we include all these proc operations
when PROC_FS is turned off? How about this as a fix (on top of the
above patch):
[IPV4]: Move snmp_mib_init
On Wed, Apr 25, 2007 at 12:35:49PM +1000, Herbert Xu wrote:
[IPV4]: Move snmp_mib_init out of proc.c
The function snmp_mib_init has nothing to do with proc so this patch
moves it out of proc.c and to the only place that uses it. Right now
there is only one user so I'ved made it static
Hi:
[IPV4]: Consolidate common SNMP code
This patch moves the SNMP code shared between IPv4/IPv6 from proc.c
into net/ipv4/af_inet.c. This makes sense because these functions
aren't specific to /proc.
As a result we can again skip proc.o if /proc is disabled.
Signed-off-by: Herbert Xu [EMAIL
Peter P Waskiewicz Jr wrote:
From: Peter P Waskiewicz Jr [EMAIL PROTECTED]
Modified tc so PRIO can now have a multiqueue parameter passed to it. This
will turn on multiqueue behavior if a device has more than 1 queue. Also,
running tc qdisc ls dev dev will display if multiqueue is on or off.
Hi:
[IPV6]: Consolidate common SNMP code
This patch moves the non-proc SNMP code into addrconf.c and reuses
IPv4 SNMP code where applicable.
As a result we can skip proc.o if /proc is disabled.
Note that I've made a number of functions static since they're only
used by addrconf.c for now. If
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 14:04:09 +1000), Herbert Xu
[EMAIL PROTECTED] says:
[IPV4]: Consolidate common SNMP code
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
Acked-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
--yoshfuji
-
To unsubscribe from this list: send the line
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 14:06:37 +1000), Herbert Xu
[EMAIL PROTECTED] says:
Hi:
[IPV6]: Consolidate common SNMP code
This patch moves the non-proc SNMP code into addrconf.c and reuses
IPv4 SNMP code where applicable.
:
Signed-off-by: Herbert Xu [EMAIL
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED]
Date: Wed, 25 Apr 2007 13:19:52 +0900 (JST)
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 14:04:09 +1000), Herbert
Xu [EMAIL PROTECTED] says:
[IPV4]: Consolidate common SNMP code
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
Acked-by:
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED]
Date: Wed, 25 Apr 2007 13:21:03 +0900 (JST)
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 14:06:37 +1000), Herbert
Xu [EMAIL PROTECTED] says:
Hi:
[IPV6]: Consolidate common SNMP code
This patch moves the non-proc SNMP code into
From: David Miller [EMAIL PROTECTED]
Date: Tue, 24 Apr 2007 21:54:29 -0700 (PDT)
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED]
Date: Wed, 25 Apr 2007 13:21:03 +0900 (JST)
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 14:06:37 +1000),
Herbert Xu [EMAIL PROTECTED] says:
Hi:
From: David Miller [EMAIL PROTECTED]
Date: Tue, 24 Apr 2007 22:12:39 -0700 (PDT)
This breaks the build with IPV6 modular:
LD .tmp_vmlinux1
net/built-in.o: In function `snmp6_seq_show':
proc.c:(.text+0x68244): undefined reference to `ipv6_statistics'
proc.c:(.text+0x68250): undefined
On Wed, Apr 25, 2007 at 11:46:50AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
Herbert, as I said before, we could defer that.
It was preparation for future development (per-interface statistics
and netlink interface.
OK, but you better make sure that Adrian Bunk doesn't see them :)
On Tue, Apr 24, 2007 at 10:12:39PM -0700, David Miller wrote:
This breaks the build with IPV6 modular:
LD .tmp_vmlinux1
net/built-in.o: In function `snmp6_seq_show':
proc.c:(.text+0x68244): undefined reference to `ipv6_statistics'
Sorry, got carried away with testing with /proc
98 matches
Mail list logo
