Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-07 Thread Rusty Russell
On Mon, 2007-05-07 at 23:30 -0700, Jeremy Fitzhardinge wrote: > Rusty Russell wrote: > > Looks good, you can slightly improve it to be the model use of new > > module_param types by calling your functions param_set_rx_mode and > > param_get_rx_mode, then simply using "module_param(rx_mode, rx_mode,

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-07 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > Looks good, you can slightly improve it to be the model use of new > module_param types by calling your functions param_set_rx_mode and > param_get_rx_mode, then simply using "module_param(rx_mode, rx_mode, > 0400)" > Cute. I tried it out, but it doesn't yield an obvious

[PATCH v4 2/9] pasemi_mac: Abstract and fix up interrupt restart routines

2007-05-07 Thread Olof Johansson
Abstract out (and fix up) the interrupt restart routines, making sure we start out in a consistent state. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/pasemi_mac.c === --- netdev-2.6.orig/drivers/ne

[PATCH v4 3/9] pasemi_mac: Timer and interrupt fixes

2007-05-07 Thread Olof Johansson
Timer and interrupt fixes: * Be pickier with what kind of interrupts are acked to avoid the device to get out of sync with the driver state * Set RX count threshhold to 1 (for NAPI interrupted mode), TX count threshold to 32. * Set timer thresholds to current max (~16ms). Signed-off-by: Olof

Re: [PATCH v3] [8/10] pasemi_mac: Add msglevel support and "pasemi_mac_debug" module param

2007-05-07 Thread Olof Johansson
On Tue, May 08, 2007 at 01:03:12AM -0400, Jeff Garzik wrote: > Olof Johansson wrote: > >+/* Enable most messages by default */ > >+if (pasemi_mac_debug > 0) > >+mac->msg_enable = DEFAULT_MSG_ENABLE; > >+else > >+mac->msg_enable = pasemi_mac_debug; > >+ > > > us

[PATCH v4 9/9] pasemi_mac: Use local-mac-address instead of mac-address if available

2007-05-07 Thread Olof Johansson
Use local-mac-address in the device tree instead. Fall back to mac-address for older firmware. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/pasemi_mac.c === --- netdev-2.6.orig/drivers/net/pasemi_m

[PATCH v4 0/9] pasemi_mac: fixes and enhancements

2007-05-07 Thread Olof Johansson
Hi, The nine following patches contain a number of fixes and improvements of the pasemi_mac driver: [PATCH v4 1/9] pasemi_mac: Move the IRQ mapping from the PCI layer to the driver [PATCH v4 2/9] pasemi_mac: Abstract and fix up interrupt restart routines [PATCH v4 3/9] pasemi_mac: Timer and inter

[PATCH v4 1/9] pasemi_mac: Move the IRQ mapping from the PCI layer to the driver

2007-05-07 Thread Olof Johansson
Fixes for ethernet IRQ mapping, to be done in the driver instead of in the platform setup code. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: netdev-2.6/arch/powerpc/platforms/pasemi/pci.c === --- netdev-2.6.orig/arch/pow

[PATCH v4 8/9] pasemi_mac: PHY support

2007-05-07 Thread Olof Johansson
PHY support for pasemi_mac. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/pasemi_mac.c === --- netdev-2.6.orig/drivers/net/pasemi_mac.c +++ netdev-2.6/drivers/net/pasemi_mac.c @@ -606,6 +606,114 @@

[PATCH v4 7/9] pasemi_mac: Add msglevel support and "debug" module param

2007-05-07 Thread Olof Johansson
Add msglevel support for pasemi_mac. Move the MODULE_* defines to the top to go together with the variable (similar to tg3). Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/pasemi_mac.c === --- netdev

Re: [PATCH v3] [2/10] [REAL 2/10] pasemi_mac: Move the IRQ mapping from the PCI layer to the driver

2007-05-07 Thread Olof Johansson
On Tue, May 08, 2007 at 01:02:34AM -0400, Jeff Garzik wrote: > Olof Johansson wrote: > >Fixes for ethernet IRQ mapping, to be done in the driver instead of in > >the platform setup code. > > > >Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > patch failed to apply, so I stopped here > > ACK

[PATCH v4 4/9] pasemi_mac: Add SKB reuse / copy-break

2007-05-07 Thread Olof Johansson
Add a copy-break and recycle the SKB in the driver for small packets. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/pasemi_mac.c === --- netdev-2.6.orig/drivers/net/pasemi_mac.c +++ netdev-2.6/driver

[PATCH v4 6/9] pasemi_mac: Logic cleanup / rx performance improvements

2007-05-07 Thread Olof Johansson
Logic cleanup and some performance enhancements to the RX path. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/pasemi_mac.c === --- netdev-2.6.orig/drivers/net/pasemi_mac.c +++ netdev-2.6/drivers/net/

[PATCH v4 5/9] pasemi_mac: Minor cleanup / define fixes

2007-05-07 Thread Olof Johansson
* Remove some unused defines * Fix a couple of wrong chip register defines, and add a few more fields that might be used in the near future. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/pasemi_mac.c =

Re: [PATCH v4 1/9] pasemi_mac: Move the IRQ mapping from the PCI layer to the driver

2007-05-07 Thread Jeff Garzik
Olof Johansson wrote: Fixes for ethernet IRQ mapping, to be done in the driver instead of in the platform setup code. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied 1-9 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED

Re: [PATCH] drivers/net/dm9000: Convert to generic boolean

2007-05-07 Thread Jeff Garzik
Richard Knutsson wrote: Convert to generic boolean. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the b

Re: [PATCH] tc35815: Remove unnecessary skb->dev assignment

2007-05-07 Thread Jeff Garzik
Atsushi Nemoto wrote: Apply changes in commit 4c13eb6657fe9ef7b4dc8f1a405c902e9e5234e0 to newly added piece of code. Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> --- diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c index f1e2dfc..463d600 100644 --- a/drivers/net/tc35815.c +++ b/dr

Re: [PATCH] 3Com PCI 3c905 causes annoying pci_set_power_state() messages

2007-05-07 Thread Jeff Garzik
Bjørn Mork wrote: I don't know if this is the correct place for 3c59x bugs. Couldn't find a maintainer entry for it. Please redirect as appropriate. pci_set_power_state() is a bit weird, causing a failure if a device doesn't support PM and the driver tries to 1) save it's power_state, 2) w

Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

2007-05-07 Thread Jeff Garzik
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0) +#include +#include +#include +#include +#include +#include +#include +#include +#elif LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0) +#include +#include +#include +#include +#include +#include +#endif /* LINUX_VERSION_CODE */ + +#include

Re: Ethernet driver for SNI RM200/RM400 machines

2007-05-07 Thread Jeff Garzik
Thomas Bogendoerfer wrote: I'm currently working on getting LINUX supported on SNI RM200/300/400 machines (MIPS based servers and workstations). Most of the changes are already in Linus tree. What's now missing are some device drivers. One is an ethernet driver for the older EISA only RM200 and R

Re: [PATCH 2.6.21] AT91RM9200 Ethernet: Support additional PHYs

2007-05-07 Thread Jeff Garzik
Andrew Victor wrote: Add support for a number of new PHY's in the AT91RM9200 Ethernet driver. - Teridian 78Q21x3 - SMSC LAN83C185 (Patch from Luca Gamma) - National Semiconductor DP83848 (Patches from Ivan Kuten & Thomas Foldesi) Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> applied bot

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-07 Thread Jeff Garzik
ACK. I shall presume that the ARM folks will apply these patches. You may tack on an "Acked-by: Jeff Garzik <[EMAIL PROTECTED]>" onto the ethernet driver itself. I'll let the ARM folks review the rest. I do agree with the comments in the thread that -- as in your most recent revision -- th

Re: [PATCH 1/5] ne: Add platform_driver

2007-05-07 Thread Jeff Garzik
Atsushi Nemoto wrote: Add a platform_driver interface to ne driver. (Existing legacy ports did not covered by this ne_driver for now) Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> --- drivers/net/ne.c | 91 - 1 files changed, 89 insertio

Re: [PATCH] sky2: re-enable 88E8056 for most motherboards

2007-05-07 Thread Jeff Garzik
Stephen Hemminger wrote: This fixes the regression in 2.6.21 for users with 88e8056 on motherboard. Allow all but the Gigabyte motherboard has some unresolved bus problems. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c | 17 + 1 file changed, 13

Re: [PATCH 1/1] Fix hang on IBM Token Ring PCMCIA card ejection

2007-05-07 Thread Jeff Garzik
Paul Walmsley wrote: From: Paul Walmsley <[EMAIL PROTECTED]> Ejecting a PCMCIA IBM Token Ring card that has not had its dev->open() called will reliably trigger an uninitialized spinlock oops when spinlock debugging is enabled. The system then hangs, occasionally softlockup oopsing. It seems th

Re: [PATCH 1/2] atl1: use dev_printk macros

2007-05-07 Thread Jeff Garzik
Jay Cliburn wrote: Use dev_printk macros for PCI related errors, warnings, debug and info console messages. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_ethtool.c | 19 +++-- drivers/net/atl1/atl1_hw.c | 22 +-- drivers/net/atl1/atl1_main.c|

Re: [PATCH] libertas: fix for wireless Kconfig changes

2007-05-07 Thread Jeff Garzik
John W. Linville wrote: Need to change the libertas Kconfig entry to match changes made for other wireless drivers. Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig index c4b3dc2..cb09e6b 100644 --- a/drivers/net/wir

Re: [PATCH] ehea: Fix skb header access

2007-05-07 Thread Jeff Garzik
Thomas Klein wrote: Adapt to new skb header access functions. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [PATCH 1/2] natsemi: Improve diagnostics for DspCfg workaround

2007-05-07 Thread Jeff Garzik
Mark Brown wrote: The natsemi driver has a workaround for broken hardware which resets itself from time to time. There is a diagnostic message for this workaround but it is not printed by default, making the driver behavior more obscure than it needs to be. Make the message be displayed by defa

Re: [PATCH 1/4] s390: qeth driver connection hang

2007-05-07 Thread Jeff Garzik
Frank Pavlic wrote: From: Ursula Braun <[EMAIL PROTECTED]> Frank Pavlic <[EMAIL PROTECTED]> Connection hangs when using EDDP mode because sk_protocol is NULL when skb has been copied via skb_copy. This results in dropping packets. Also keep MAC address after recovery of Virtual NIC

Re: [PATCH 1/6] myri10ge: support new firmware counters

2007-05-07 Thread Jeff Garzik
Brice Goglin wrote: Add dropped_pause, dropped_bad_phy, dropped_bad_crc32, dropped_unicast_filtered to the set of ethtool counters. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c |9 - drivers/net/myri10ge/myri10ge_mcp.h |6 +- 2 file

Re: [PATCH 2/2] skge: allow WOL except for known broken chips

2007-05-07 Thread Jeff Garzik
Stephen Hemminger wrote: Wake On Lan works correctly on Yukon-FE and other variants. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>a --- drivers/net/skge.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) applied - To unsubscribe from this list: send the line "unsubs

Re: [PATCH] DM9000: fix use of kfree() on net device

2007-05-07 Thread Jeff Garzik
Ben Dooks wrote: The DM9000 network driver is calling kfree() on an netdev causing the system to oops if the probe fails. The right thing to do is call free_netdev(). Thanks to Russell King for spotting this. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> applied - To unsubscribe from this li

Re: [PATCH] smc91x SuperH support

2007-05-07 Thread Jeff Garzik
Nobuhiro Iwamatsu wrote: Hi, all. This patch supports SuperH of smc91x. smc91x installed on the board of SuperH comes to work by applying this patch. Please apply this patch . applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: [PATCH 1/2] NetXen: Fix NetXen driver ping on system-p

2007-05-07 Thread Jeff Garzik
Mithlesh Thukral wrote: NetXen: Fix for driver on System-p This patch will fix a ping issue on system-p. Signed-off by: Milan Bag <[EMAIL PROTECTED]> Signed-off by: Adhiraj Joshi <[EMAIL PROTECTED]> Signed-by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic_init.c |

Re: [PATCH 4/6] myri10ge: limit the number of recoveries

2007-05-07 Thread Jeff Garzik
Brice Goglin wrote: Limit the number of recoveries from a NIC hw watchdog reset to 1 by default. This is tweakable via the myri10ge_reset_recover tunable. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c | 15 +-- 1 file changed, 13 insertions(+

Re: [PATCH 1/2] skge: default WOL should be magic only

2007-05-07 Thread Jeff Garzik
Stephen Hemminger wrote: By default, the skge driver now enables wake on magic and wake on PHY. This is a bad default (bug), wake on PHY means machine will never shutdown if connected to a switch. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>a --- drivers/net/skge.c |2 +- 1 file

Re: [PATCH v3] [9/10] pasemi_mac: PHY support

2007-05-07 Thread Jeff Garzik
Olof Johansson wrote: PHY support for pasemi_mac. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> ACK patches 9-10 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH v3] [1/10] pasemi_mac: A couple of minor bugfixes.

2007-05-07 Thread Jeff Garzik
Olof Johansson wrote: Bugfixes: * Move the wake_queue logic from tx_intr to clean_tx * Always do wake_queue even if queue wasn't full before clean since it's safe to do * Fix polarity in checks in pasemi_mac_close Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied - To unsubscribe

Re: [PATCH v3] [2/10] [REAL 2/10] pasemi_mac: Move the IRQ mapping from the PCI layer to the driver

2007-05-07 Thread Jeff Garzik
Olof Johansson wrote: Fixes for ethernet IRQ mapping, to be done in the driver instead of in the platform setup code. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> patch failed to apply, so I stopped here ACK patches 2-7 - To unsubscribe from this list: send the line "unsubscribe netdev

Re: [PATCH v3] [8/10] pasemi_mac: Add msglevel support and "pasemi_mac_debug" module param

2007-05-07 Thread Jeff Garzik
Olof Johansson wrote: + /* Enable most messages by default */ + if (pasemi_mac_debug > 0) + mac->msg_enable = DEFAULT_MSG_ENABLE; + else + mac->msg_enable = pasemi_mac_debug; + use netif_msg_init() otherwise OK - To unsubscribe from this list: se

Re: [PATCH 12/12] r8169: mac address change support

2007-05-07 Thread Jeff Garzik
Francois Romieu wrote: Merged from Realtek's r8169-6.001 driver. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/drivers/net/r81

Re: [PATCH 11/12] r8169: align the IP header when there is no DMA constraint

2007-05-07 Thread Jeff Garzik
Francois Romieu wrote: Align the IP header when the chipset can DMA at any location (plain 0x8169). Otherwise (0x8136/0x8168) obey the constraint imposed by the hardware. This patch complements the previous alignment rework done for copybreak. Original idea from Philip Craig <[EMAIL PROTECTED]>

Re: [PATCH 09/12] r8169: MSI support

2007-05-07 Thread Jeff Garzik
Francois Romieu wrote: It is currently limited to 0x8136 and 0x8168. 8169sb/8110sb ought to handle it as well where they support MSI. Includes unregister_netdev() fix from Bernhard Walle <[EMAIL PROTECTED]> against BUG_ON(irq_has_action(dev->first_msi_irq)) (2007/02/24). Signed-off-by: Francois

Re: [PATCH 08/12] r8169: cleanup

2007-05-07 Thread Jeff Garzik
Francois Romieu wrote: No functionnal change: - trim the old history log - whitespace/indent/case police - unsigned int where signedness does not matte - removal of obsolete assert - needless cast from void * (dev_instance) Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAI

Different scheduler behavior between 2.4 and 2.6

2007-05-07 Thread Quan Sun
Hi, Recently I met a problem on different scheduler behavior between 2.4.22 and 2.6.18.8. The application works as a proxy, it listen on an interface, connect through another interface. This application works on a box with two Xeon cpu, each of them is hyper-threading. On 2.4.22, CPU0 serve

[last RFC] mlx4 (Mellanox ConnectX adapter) InfiniBand drivers

2007-05-07 Thread Roland Dreier
I've added my InfiniBand drivers for the new Mellanox ConnectX adapter to what's queued up for 2.6.22 in: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-2.6.22 This is still a new driver, with some things missing and undoubtedly some bugs and opportunities for cleanu

Re: [PATCH 0/3] Intel IXP4xx network drivers

2007-05-07 Thread Krzysztof Halasa
Ok, the status of my patches is as follows: [PATCH] Use menuconfig objects II - netdev/wan the "menuconfig" WAN patch by Jan Engelhardt [PATCH 1a/3] WAN Kconfig: change "depends on HDLC" to "select" the Kconfig changes for WAN (HDLC) drivers [PATCH 2a/3] Intel IXP4xx network drive

[PATCH] Intel IXP4xx network drivers v.3 - QMGR

2007-05-07 Thread Krzysztof Halasa
Adds a driver for built-in IXP4xx hardware Queue Manager. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig index 9715ef5..71ef55f 100644 --- a/arch/arm/mach-ixp4xx/Kconfig +++ b/arch/arm/mach-ixp4xx/Kconfig @@ -176,6 +176

[PATCH] Intel IXP4xx network drivers v.2 - NPE

2007-05-07 Thread Krzysztof Halasa
Adds a driver for built-in IXP4xx Network Processor Engines. This patch requires IXP4xx Queue Manager driver and the "fuses" patch. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig index 71ef55f..25f8994 100644 --- a/arch

Re: Getting make net/built-in.o Error with 2.6.21.1 Build

2007-05-07 Thread Satyam Sharma
On 5/8/07, Chris Bergeron <[EMAIL PROTECTED]> wrote: On trying to build a 2.6.21.1 kernel using the configuration at http://pcburn.com/files/kernel/breaks.2.6.21.1.config I'm getting the following error with Networking Support -> Bluetooth Subsystem Support -> HIDP protocol support set to built-i

[PATCH] Intel IXP4xx network drivers v.2

2007-05-07 Thread Krzysztof Halasa
Adds a driver for IXP4xx built-in hardware queue manager. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig index 9715ef5..71ef55f 100644 --- a/arch/arm/mach-ixp4xx/Kconfig +++ b/arch/arm/mach-ixp4xx/Kconfig @@ -176,6 +176

Re: smp_affinity, MSI-X and 2.6.21.1

2007-05-07 Thread Rick Jones
Arjan van de Ven wrote: On Mon, 2007-05-07 at 13:53 -0700, Rick Jones wrote: Folks - Is it a bug, or a feature that after changing a device's smp_affinity via echo "N" >> /proc/irq/M/smp_affinity that the new mask isn't visible via cat /proc/irq/M/smp_affinity until after actual interrupts a

Re: [PATCH v2] Add rtl8187 wireless driver

2007-05-07 Thread Michael Wu
On Monday 07 May 2007 19:25, David Miller wrote: > I know this sounds trite, but when merging and researching up to 450 > patches at a time like I have to, this stuff starts to matter. > > Please put things as high in the directory hierachy as possible and > when you can put the entire driver into

Re: Please pull 'upstream' branch of wireless-2.6

2007-05-07 Thread John W. Linville
On Mon, May 07, 2007 at 07:09:20PM -0400, Jeff Garzik wrote: > John W. Linville wrote: > >Ivo van Doorn (1): > > Add 93cx6 eeprom library > >Michael Wu (1): > > Add rtl8187 wireless driver I presume these are the two parts you question. (Just checking...) > The normal development pro

Re: Please pull 'upstream' branch of wireless-2.6

2007-05-07 Thread Michael Wu
On Monday 07 May 2007 19:09, Jeff Garzik wrote: > The general idea is everything you want in 2.6.22 should be prepared and > in -mm BEFORE 2.6.21 is released, and the 2.6.22 merge window opens. > rtl8187 has been in -mm since 2.6.21-rc2-mm1. -Michael Wu pgpqlzKVzSGGX.pgp Description: PGP signatu

Re: [PATCH v2] Add rtl8187 wireless driver

2007-05-07 Thread David Miller
From: Michael Wu <[EMAIL PROTECTED]> Date: Mon, 7 May 2007 19:17:20 -0400 > On Monday 07 May 2007 11:25, Jeff Garzik wrote: > > I am a bit skeptical that multiple files are needed. It seems like > > drivers/net/wireless/rtl818x.c would be a better path, a la tg3.c. > > > The radio tuning stuff co

Re: [PATCH v2] Add rtl8187 wireless driver

2007-05-07 Thread Michael Wu
On Monday 07 May 2007 11:25, Jeff Garzik wrote: > I am a bit skeptical that multiple files are needed. It seems like > drivers/net/wireless/rtl818x.c would be a better path, a la tg3.c. > The radio tuning stuff could be stuffed into rtl8187_dev.c, but I like to keep it separate since rtl8187_rtl8

Re: smp_affinity, MSI-X and 2.6.21.1

2007-05-07 Thread Arjan van de Ven
On Mon, 2007-05-07 at 13:53 -0700, Rick Jones wrote: > Folks - > > Is it a bug, or a feature that after changing a device's smp_affinity via > echo > "N" >> /proc/irq/M/smp_affinity that the new mask isn't visible via cat > /proc/irq/M/smp_affinity until after actual interrupts are taken?\ tha

Re: Please pull 'upstream' branch of wireless-2.6

2007-05-07 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 15700770ef7c5d12e2f1659d2ddbeb3f658d9f37: Linus Torvalds (1): Merge git://git.kernel.org/.../sam/kbuild are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream D

Re: [PATCH] fib_info_hashfn leads to long hash chains

2007-05-07 Thread David Miller
From: Benjamin LaHaise <[EMAIL PROTECTED]> Date: Sun, 29 Apr 2007 11:03:36 -0400 > Hello > > The patch below fixes a case where fib_find_info() is consume excessive > amounts of CPU during the creation of 1 PPP interfaces. In access > servers, each point to point link has the same local ad

Re: Please pull 'upstream' branch of wireless-2.6

2007-05-07 Thread John W. Linville
On Mon, May 07, 2007 at 05:15:50PM -0400, Dan Williams wrote: > On Mon, 2007-05-07 at 13:51 -0400, John W. Linville wrote: > > John W. Linville (1): > > libertas: fix for wireless Kconfig changes > > So the kconfig changes with s/NET_RADIO/NET_80211 (or whatever it was) > are in for 2.6.22?

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Randy Dunlap
Satyam Sharma wrote: On 5/8/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: On Mon, 07 May 2007 16:31:48 -0400 Jeff Garzik wrote: > Satyam Sharma wrote: > > Yes, mixing select and depends is a recipe for build disasters. Call > > me a rabid fanatic, but I would in fact go as far as to say that this

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Satyam Sharma
On 5/8/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: On Mon, 07 May 2007 16:31:48 -0400 Jeff Garzik wrote: > Satyam Sharma wrote: > > Yes, mixing select and depends is a recipe for build disasters. Call > > me a rabid fanatic, but I would in fact go as far as to say that this > > whole "select" th

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-07 Thread Rusty Russell
On Mon, 2007-05-07 at 14:11 -0700, Jeremy Fitzhardinge wrote: > Christoph Hellwig wrote: > > On Fri, May 04, 2007 at 04:21:16PM -0700, Jeremy Fitzhardinge wrote: > > > >> +/* > >> + * Mutually-exclusive module options to select receive data path: > >> + * rx_copy : Packets are copied by network

[PATCH 4/6] myri10ge: limit the number of recoveries

2007-05-07 Thread Brice Goglin
Limit the number of recoveries from a NIC hw watchdog reset to 1 by default. This is tweakable via the myri10ge_reset_recover tunable. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) Ind

[PATCH 5/6] myri10ge: move the DMA test code into its own function

2007-05-07 Thread Brice Goglin
Move the DMA test code into its own function. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c | 121 ++-- 1 file changed, 68 insertions(+), 53 deletions(-) Index: linux-git/drivers/net/myri10ge/myri10ge.c ==

[PATCH 6/6] myri10ge: replace the chipset whitelist with firmware autodetection

2007-05-07 Thread Brice Goglin
Remove the aligned-completion whitelist, and replace it by using the 1.4.16 firmware's auto-detection features to choose which firmware to load. The driver now loads the aligned firmware, performs a MXGEFW_CMD_UNALIGNED_TEST, and falls back to using the unaligned firmware if: - The firmware is too

[PATCH 2/6] myri10ge: update firmware headers

2007-05-07 Thread Brice Goglin
Update myri10ge firmware headers to those of 1.4.16. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge_mcp.h | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) Index: linux-git/drivers/net/myri10ge/myri10ge_mcp.h ===

[PATCH 3/6] myri10ge: fix restoring of multicast list after reset

2007-05-07 Thread Brice Goglin
Don't count on whatever implementation artifact preserves the multicast list across a reset cmd, and setup multicast filtering as part of our reset routine. The setting of allmulti when adopting firmware with the rx-filter broadcast bug is also moved into the multicast setup routine where it belon

[PATCH 1/6] myri10ge: support new firmware counters

2007-05-07 Thread Brice Goglin
Add dropped_pause, dropped_bad_phy, dropped_bad_crc32, dropped_unicast_filtered to the set of ethtool counters. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c |9 - drivers/net/myri10ge/myri10ge_mcp.h |6 +- 2 files changed, 13 insertio

[PATCH 0/6] myri10ge updates for 2.6.22

2007-05-07 Thread Brice Goglin
Hi Jeff, Here's some updates of myri10ge for 2.6.22. The good news is that the aligned-completion whitelist is now gone. 1. support new firmware counters 2. update firmware headers 3. fix restoring of multicast list after reset 4. limit the number of recoveries 5. move the DMA test code into its

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-07 Thread Jeremy Fitzhardinge
Herbert Xu wrote: > On Sat, May 05, 2007 at 03:05:07AM -0700, Jeremy Fitzhardinge wrote: > >> Sorry, I forgot about it. I was waiting to hear back from network >> people about what this is actually for, and whether we really need it. >> > > We should just change this to use netif_device_a

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-07 Thread Jeremy Fitzhardinge
Christoph Hellwig wrote: > On Fri, May 04, 2007 at 04:21:16PM -0700, Jeremy Fitzhardinge wrote: > >> +/* >> + * Mutually-exclusive module options to select receive data path: >> + * rx_copy : Packets are copied by network backend into local memory >> + * rx_flip : Page containing packet data i

[PATCH 1a/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Krzysztof Halasa
Allow enabling WAN drivers without selecting generic HDLC first, HDLC will be selected automatically. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> --- linux/drivers/net/wan/Kconfig 2007-05-07 22:46:06.0 +0200 +++ linux/drivers/net/wan/Kconfig 2007-05-07 22:45:13.000

Kconfig warnings on latest GIT

2007-05-07 Thread Ismail Dönmez
Hi, Following Kconfig warnings shows up with latest GIT : drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST' drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol 'AT

[PATCH] Use menuconfig objects II - netdev/wan

2007-05-07 Thread Krzysztof Halasa
From: Jan Engelhardt <[EMAIL PROTECTED]> Change Kconfig objects from "menu, config" into "menuconfig" so that the user can disable the whole feature without having to enter the menu first. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> ---

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Jeff Garzik wrote: > Tough, the kernel community has voted against you. > > It makes far more sense to include a driver during kernel configuration, and > have that driver pull in its libraries via 'select'. The lame alternative > requires developers to know which librar

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Krzysztof Halasa
Roman Zippel <[EMAIL PROTECTED]> writes: > Normal dependencies, you basically have to manually make sure they are > correct (and it seems with your patch they aren't). Again, _please_ (with > sugar on top) don't use select unless you have a good reason for it. You perhaps mean WAN dependency, d

smp_affinity, MSI-X and 2.6.21.1

2007-05-07 Thread Rick Jones
Folks - Is it a bug, or a feature that after changing a device's smp_affinity via echo "N" >> /proc/irq/M/smp_affinity that the new mask isn't visible via cat /proc/irq/M/smp_affinity until after actual interrupts are taken? rick jones - To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Satyam Sharma
On 5/8/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > Yes, mixing select and depends is a recipe for build disasters. Call > me a rabid fanatic, but I would in fact go as far as to say that this > whole "select" thing in the Kconfig process is one big BUG, and not a > feature.

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Randy Dunlap
On Mon, 07 May 2007 16:31:48 -0400 Jeff Garzik wrote: > Satyam Sharma wrote: > > Yes, mixing select and depends is a recipe for build disasters. Call > > me a rabid fanatic, but I would in fact go as far as to say that this > > whole "select" thing in the Kconfig process is one big BUG, and not a

Re: Merging SSB upstream

2007-05-07 Thread Michael Buesch
On Monday 07 May 2007 18:43:18 Gary Zambrano wrote: > On Sat, 2007-05-05 at 23:11 -0400, Jeff Garzik wrote: > > Michael Buesch wrote: > > > So, now that mac80211 is merged upstream, I think it's > > > time to merge SSB and the b44-ssb port upstream. > > > Note that bcm43xx-mac80211 is _not_ ready f

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Jeff Garzik
Satyam Sharma wrote: Yes, mixing select and depends is a recipe for build disasters. Call me a rabid fanatic, but I would in fact go as far as to say that this whole "select" thing in the Kconfig process is one big BUG, and not a feature. People are lazy by nature and would rather just "select" a

Re: [PATCH 3/3] Intel IXP4xx network drivers

2007-05-07 Thread Krzysztof Halasa
Christian Hohnstaedt <[EMAIL PROTECTED]> writes: > - the NPE can also be used as DMA engine and for crypto operations. > Both are not network related. > Additionally, the NPE is not only ixp4xx related, but is > also used in IXP23xx CPUs, so it could be placed in > arch/arm/common or arch/

Re: [PATCH 3/3] Intel IXP4xx network drivers

2007-05-07 Thread Krzysztof Halasa
Having thought about it a bit more, a layout similar to the one proposed by you may make sense. Michael-Luke Jones <[EMAIL PROTECTED]> writes: > Despite their name, Network Processing Engines are independent > coprocessors which are only coincidentally attached to MACs for > ethernet / WAN purpos

Re: [PATCH 3/3] Intel IXP4xx network drivers

2007-05-07 Thread Michael-Luke Jones
[Added Lennert Buytenhek to CC list] Hey again, Code placement: Queue Manager & NPE code => arch/arm/mach-ixp4xx WAN driver code => drivers/net/wan Eth code => drivers/net/arm Why would you want such placement? Potential problems: header files would have to be moved to include/asm-arm = heade

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Satyam Sharma
On 5/7/07, Roman Zippel <[EMAIL PROTECTED]> wrote: Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Roman Zippel <[EMAIL PROTECTED]> writes: > > > HDLC doesn't really look like simple library code, what's up with all the > > HDLC_* options? > > Sub-modules. So it's not simple library code, or

[PATCH 2/2] skge: allow WOL except for known broken chips

2007-05-07 Thread Stephen Hemminger
Wake On Lan works correctly on Yukon-FE and other variants. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>a --- drivers/net/skge.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) --- sky2-2.6.21.orig/drivers/net/skge.c 2007-05-07 10:04:06.0 -0700 +++ sky2-2.6.21/

Re: [PATCH 3/3] Intel IXP4xx network drivers

2007-05-07 Thread Christian Hohnstaedt
On Mon, May 07, 2007 at 07:12:49PM +0200, Krzysztof Halasa wrote: > Michael-Luke Jones <[EMAIL PROTECTED]> writes: > > > Code placement: > > Queue Manager & NPE code => arch/arm/mach-ixp4xx > > WAN driver code => drivers/net/wan > > Eth code => drivers/net/arm > > Why would you want such placemen

Re: Merging SSB upstream

2007-05-07 Thread Gary Zambrano
On Sat, 2007-05-05 at 23:11 -0400, Jeff Garzik wrote: > Michael Buesch wrote: > > So, now that mac80211 is merged upstream, I think it's > > time to merge SSB and the b44-ssb port upstream. > > Note that bcm43xx-mac80211 is _not_ ready for upstream, yet. > > > > What do you think? I'd like to merg

[PATCH 1/2] skge: default WOL should be magic only

2007-05-07 Thread Stephen Hemminger
By default, the skge driver now enables wake on magic and wake on PHY. This is a bad default (bug), wake on PHY means machine will never shutdown if connected to a switch. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>a --- drivers/net/skge.c |2 +- 1 file changed, 1 insertion(+), 1 d

Re: [PATCH 10/11][TG3]: Reduce spurious interrupts.

2007-05-07 Thread Michael Chan
On Mon, 2007-05-07 at 10:44 -0700, Rick Jones wrote: > > Mostly I was thinking that not all PIO reads are the same "length" and so the > effect of the PIO read will vary, perhaps considerably, with the platform, > particularly for a very large NUMA platform. > Oh I see. If the PIO read is "lo

Re: Strange soft lockup detected message (looks like spin_lock bug in pcnet32)

2007-05-07 Thread Lennart Sorensen
On Mon, May 07, 2007 at 04:48:37PM +0200, Frederik Deweerdt wrote: > Can you try running on another Geode LX system, just to rule out a > hardware problem on you board? Hmm, I thought I saw it on two systems already, but I should go try that again. -- Len Sorensen - To unsubscribe from this list:

Re: [PATCH 10/11][TG3]: Reduce spurious interrupts.

2007-05-07 Thread Rick Jones
Michael Chan wrote: On Mon, 2007-05-07 at 09:39 -0700, Rick Jones wrote: On how "topologically big" a system has this resurrection of the PIO read been tried so far? If you're asking how much impact the read will have on performance, the answer is that it will depend on whether you frequen

Re: [PATCH 10/11][TG3]: Reduce spurious interrupts.

2007-05-07 Thread Michael Chan
On Mon, 2007-05-07 at 09:39 -0700, Rick Jones wrote: > On how "topologically big" a system has this resurrection of the PIO read > been > tried so far? > If you're asking how much impact the read will have on performance, the answer is that it will depend on whether you frequently get spurious

Re: [PATCH 3/3] Intel IXP4xx network drivers

2007-05-07 Thread Krzysztof Halasa
Michael-Luke Jones <[EMAIL PROTECTED]> writes: > Code placement: > Queue Manager & NPE code => arch/arm/mach-ixp4xx > WAN driver code => drivers/net/wan > Eth code => drivers/net/arm Why would you want such placement? Potential problems: header files would have to be moved to include/asm-arm = he

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Roman Zippel <[EMAIL PROTECTED]> writes: > > > HDLC doesn't really look like simple library code, what's up with all the > > HDLC_* options? > > Sub-modules. So it's not simple library code, or is it? > Anyway, what does the patch "screw" exa

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Krzysztof Halasa
Roman Zippel <[EMAIL PROTECTED]> writes: > HDLC doesn't really look like simple library code, what's up with all the > HDLC_* options? Sub-modules. Anyway, what does the patch "screw" exactly? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: trying to track a change to drivers/isdn/usb-gigaset.c

2007-05-07 Thread Tilman Schmidt
David Miller schrieb: > [ netdev@vger.kernel.org is the place to discuss kernel networking > issues, thanks ] OIC. My bad. I didn't make the connection from "skb" to "networking". Sorry. > It was a change done so that we could hide the skb data buffering > details to the point where we could ch

  1   2   >