Re: [NET]: gen_estimator: fix locking and timer related bugs [Re: [Bugme-new] [Bug 8668] New: HTB Deadlock]

2007-06-27 Thread Jarek Poplawski
On Wed, Jun 27, 2007 at 05:25:45PM +0200, Patrick McHardy wrote: > Patrick McHardy wrote: > > [NET]: gen_estimator: fix locking and timer related bugs > > > > > That one still left a race, we could be reinitalizing the timer > while it is still running. This patch additionally makes sure > each

zd1211rw and mac80211: multicast/v6 doesn't work in 2.6.21.5

2007-06-27 Thread Pekka Savola
Hi, On Fedora 7 (kernel 2.6.21-1.3228.fc7, based on 2.6.21.5), my zd1211rw_mac80211 WLAN USB stick and multicast/v6 no longer works. On Fedora 6 (kernel 2.6.20, no mac80211) it was OK. I get "wlan0: duplicate address detected!" on dmesg when the kernel is trying to autoconfigure a global add

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-06-27 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 25 Jun 2007 22:09:39 +0900 (JST)), OBATA Noboru <[EMAIL PROTECTED]> says: > Please note that this is effective in IPv6 as well. Of course, I'm happy with this. --yoshfuji - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH] RFC: have tcp_recvmsg() check kthread_should_stop() and treat it as if it were signalled

2007-06-27 Thread Satyam Sharma
Hi Oleg, On 6/27/07, Oleg Nesterov <[EMAIL PROTECTED]> wrote: On 06/27, Satyam Sharma wrote: > > Thanks for your comments, I'm still not convinced, however. An perhaps you are right. I don't have a very strong opinion on that. Still I can't understand why it is better if kthread_stop() sends a

Re: [PATCH] NET: Multiqueue network device support.

2007-06-27 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Wed, 27 Jun 2007 20:15:47 -0400 > On Wed, 2007-27-06 at 15:54 -0700, David Miller wrote: > > > The thing that's really important is that the value is not so > > large such that the TX ring can become empty. > > In the case of batching, varying the values mak

Re: [PATCH] NET: Multiqueue network device support.

2007-06-27 Thread jamal
On Wed, 2007-27-06 at 15:54 -0700, David Miller wrote: > The thing that's really important is that the value is not so > large such that the TX ring can become empty. In the case of batching, varying the values makes a difference. The logic is that if you can tune it so that the driver takes "suf

[WIP][PATCHES] Network xmit batching - tg3 support

2007-06-27 Thread jamal
peoplez, I have added support for tg3 on batching. I see equivalent performance improvement for pktgen as i did with e1000 when using gige. I have only tested on two machines (one being a laptop which does 10/100Mbps). Unfortunately in both cases these are considered to be in the class of "buggy

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-06-27 Thread jamal
On Tue, 2007-26-06 at 00:40 +0200, Johannes Berg wrote: > I wonder if we should hold off on this API until we've worked out the > multicast issue. Even if the ACPI thing goes in first, you will have to change a few others that are existing in-kernel that need to be changed sooner or later. So ei

Re: [PATCH] NET: Multiqueue network device support.

2007-06-27 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Wed, 27 Jun 2007 18:32:45 -0400 > On Tue, 2007-26-06 at 13:57 -0700, David Miller wrote: > > From: jamal <[EMAIL PROTECTED]> > > Date: Tue, 26 Jun 2007 09:27:28 -0400 > > > > > Back to the question: Do you recall how this number was arrived at? > > > 128 pac

Re: [PATCH 5/5 2.6.22-rc6] L2TP: Add PPPoL2TP in-kernel documentation

2007-06-27 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Wed, 27 Jun 2007 23:20:38 +0100 > Signed-off-by: James Chapman <[EMAIL PROTECTED]> Also applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Re: [PATCH 4/5 2.6.22-rc6] L2TP: Add PPPoL2TP maintainer

2007-06-27 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Wed, 27 Jun 2007 23:20:38 +0100 > Signed-off-by: James Chapman <[EMAIL PROTECTED]> Patch applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

Re: [PATCH 3/5 2.6.22-rc6] L2TP: PPP over L2TP driver core

2007-06-27 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Wed, 27 Jun 2007 23:20:38 +0100 > This driver handles only L2TP data frames; control frames are handled > by a userspace application. It implements L2TP using the PPPoX socket > family. There is a PPPoX socket for each L2TP session in an L2TP tunnel. >

[PATCH UPDATE #2] Ethernet driver for EISA only SNI RM200/RM400 machines

2007-06-27 Thread Thomas Bogendoerfer
Changes to last version: - spelling fix - cleaned up probe code Thomas. Ethernet driver for EISA only SNI RM200/RM400 machines Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index b0d0d73..af5c90f 100644 --- a/drivers/net/Kconf

Re: [PATCH 2/5 2.6.22-rc6] L2TP: Changes to existing ppp and socket kernel headers for L2TP

2007-06-27 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Wed, 27 Jun 2007 23:20:38 +0100 > Add struct sockaddr_pppol2tp to carry L2TP-specific address > information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't > use the union inside struct sockaddr_pppox because the L2TP-specific > data is larger

Re: [PATCH 1/5 2.6.22-rc6] UDP: Introduce UDP encapsulation type for L2TP

2007-06-27 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Wed, 27 Jun 2007 23:20:38 +0100 > This patch adds a new UDP_ENCAP_L2TPINUDP encapsulation type for UDP > sockets. When a UDP socket's encap_type is UDP_ENCAP_L2TPINUDP, the > skb is delivered to a function pointed to by the udp_sock's > encap_rcv funcp

Re: [PATCH] NET: Multiqueue network device support.

2007-06-27 Thread jamal
On Tue, 2007-26-06 at 13:57 -0700, David Miller wrote: > From: jamal <[EMAIL PROTECTED]> > Date: Tue, 26 Jun 2007 09:27:28 -0400 > > > Back to the question: Do you recall how this number was arrived at? > > 128 packets will be sent out at GiGe in about 80 microsecs, so from a > > feel-the-wind-di

[PATCH 2/5 2.6.22-rc6] L2TP: Changes to existing ppp and socket kernel headers for L2TP

2007-06-27 Thread James Chapman
Add struct sockaddr_pppol2tp to carry L2TP-specific address information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't use the union inside struct sockaddr_pppox because the L2TP-specific data is larger than the current size of the union and we must preserve the size of struct sockaddr_ppp

[PATCH 4/5 2.6.22-rc6] L2TP: Add PPPoL2TP maintainer

2007-06-27 Thread James Chapman
Signed-off-by: James Chapman <[EMAIL PROTECTED]> Index: linux-2.6.22-rc6/MAINTAINERS === --- linux-2.6.22-rc6.orig/MAINTAINERS +++ linux-2.6.22-rc6/MAINTAINERS @@ -2903,6 +2903,11 @@ P: Michal Ostrowski M: [EMAIL PROTECTED]

[PATCH 5/5 2.6.22-rc6] L2TP: Add PPPoL2TP in-kernel documentation

2007-06-27 Thread James Chapman
Signed-off-by: James Chapman <[EMAIL PROTECTED]> Index: linux-2.6.22-rc6/Documentation/networking/l2tp.txt === --- /dev/null +++ linux-2.6.22-rc6/Documentation/networking/l2tp.txt @@ -0,0 +1,169 @@ +This brief document describes how t

[PATCH 1/5 2.6.22-rc6] UDP: Introduce UDP encapsulation type for L2TP

2007-06-27 Thread James Chapman
This patch adds a new UDP_ENCAP_L2TPINUDP encapsulation type for UDP sockets. When a UDP socket's encap_type is UDP_ENCAP_L2TPINUDP, the skb is delivered to a function pointed to by the udp_sock's encap_rcv funcptr. If the skb isn't wanted by L2TP, it returns >0, which causes it to be passed throug

[PATCH 0/5 2.6.22-rc6] L2TP: Introduce PPP-over-L2TP driver

2007-06-27 Thread James Chapman
This patch set adds a driver for PPP over L2TP. Patches to follow. The following changes have been made since the previous version submitted 26-MAY-07. - Add new encap_rcv field to struct udp_sock in udp.h for use by encapsulated sockets. This is set to a protocol specific receive handler for

Re: [MaybeSpam] Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-06-27 Thread noboru . obata . ar
Patrick McHardy wrote: > OBATA Noboru wrote: > > From: OBATA Noboru <[EMAIL PROTECTED]> > > > > Make TCP_RTO_MAX a variable, and allow a user to change it via a > > new sysctl entry /proc/sys/net/ipv4/tcp_rto_max. A user can > > then guarantee TCP retransmission to be more controllable, say, > >

Please pull 'libertas-fixes' branch of wireless-2.6

2007-06-27 Thread John W. Linville
The following changes since commit 189548642c5962e60c3667bdb3a703fe0bed12a6: Linus Torvalds (1): Linus 2.6.22-rc6 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git libertas-fixes Dan Williams (4): libertas: style fixes

[PATCH] rewrite AF_UNIX garbage collector

2007-06-27 Thread Miklos Szeredi
Please review. Apologies if the patch itself is not too readable due to lots of code being replaced, but the end result is quite clear I think. From: Miklos Szeredi <[EMAIL PROTECTED]> Throw out the old mark & sweep garbage collector and put in a refcounting cycle detecting one. The old on

Design intent of IP fragment cache limit?

2007-06-27 Thread Tony Zhang
Hi, I am investigating an IP fragmentation flood DOS attack scenario where the attacker sends a string of fragmented IP packets to exhaust the victim's fragment cache. I've checked the IP fragment reassembly implemention on several UNIX-like OSs. NetBSD/FreeBSD don't handle such scenario. I was ho

Re: [PATCH UPDATE] Extract chip specific code out of lasi_82596.c

2007-06-27 Thread Francois Romieu
Thomas Bogendoerfer <[EMAIL PROTECTED]> : > On Tue, Jun 26, 2007 at 11:47:55PM +0200, Francois Romieu wrote: > > Thomas Bogendoerfer <[EMAIL PROTECTED]> : > > [...] > > > +static inline void init_rx_bufs(struct net_device *dev) [...] > > The driver could use netdev_alloc_skb. > > what's the advant

Re: [PATCH 0/6] iw_cxgb3: Bug Fixes for 2.6.23

2007-06-27 Thread Steve Wise
Roland Dreier wrote: > Here are some bug fixes to the iw_cxgb3 driver that I'd like included > for 2.6.23. NOTE: Patch 1 requires a firmware interface change, so > there is a version bump to 4.3 included in that patch that hits cxgb3. > This will likely conflict with a previous version change

Re: [PATCH 0/6] iw_cxgb3: Bug Fixes for 2.6.23

2007-06-27 Thread Roland Dreier
> Here are some bug fixes to the iw_cxgb3 driver that I'd like included > for 2.6.23. NOTE: Patch 1 requires a firmware interface change, so > there is a version bump to 4.3 included in that patch that hits cxgb3. > This will likely conflict with a previous version change that is in > Jeff's u

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread Peter Korsgaard
> "Greg" == Greg KH <[EMAIL PROTECTED]> writes: Greg> Yeah, this is the cdc_acm driver that is still in the USB drivers/ Greg> directory tree as it is a USB class driver that shows up as a tty device Greg> to userspace. It should not be moved to the networking list unless no Greg> one min

[PATCH 2.6.21.1] ipconfig: add support for multiple user devs

2007-06-27 Thread Sean Kormilo
Update ipconfig to enable users to specify multiple devices on the kernel commandline ip= option. This allows for an arbitrary number of devices to be specified up-to a 255 character limit. Devices are separated by a '/' character. For example, to limit autoconfig requests to eth0 and eth2:

[PATCH 2.6.21.1] ipconfig: add support for multiple user devs

2007-06-27 Thread Sean Kormilo
Update ipconfig to enable users to specify multiple devices on the kernel commandline ip= option. This allows for an arbitrary number of devices to be specified up-to a 255 character limit. Devices are separated by a '/' character. For example, to limit autoconfig requests to eth0 and eth2:

Re: sky2 hangs without any messages

2007-06-27 Thread Stephen Hemminger
On Wed, 23 May 2007 09:54:31 +0200 Tino Keitel <[EMAIL PROTECTED]> wrote: > Hi folks, > > in the last 2 days, I had 2 outages of the NIC of my Mac mini Core Duo. > I checked the kernel log but I found nothing sky2 related. After > reloading the module, the interface worked again. > > Both freeze

a maze of twisty stats, most different

2007-06-27 Thread Rick Jones
It seems that every driver, when providing support for ethtool -S functionality, has considerable lattitude when it comes to the stats provided. Clearly this is very nice for the driver writer(s) as it allows them to provide whatever stats they feel are most "natural" for their NIC(s) and name

[PATCH 6/6] iw_cxgb3: Don't abort after failures sending the mpa reply.

2007-06-27 Thread Steve Wise
iw_cxgb3: Don't abort after failures sending the mpa reply. This bug results in an abort request being sent down _after_ the tid has been released. If the tid happens to have been reused, then the subsequent generation of the tid gets incorrectly aborted. The thread running iwch_accecpt_cr() mu

[PATCH 5/6] iw_cxgb3: Don't post TID_RELEASE message.

2007-06-27 Thread Steve Wise
iw_cxgb3: Don't post TID_RELEASE message. The LLD does this for us in cxgb3_remove_tid(). Also fixed active open failure cases where we shouldn't be releasing the TID as well. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c | 13 ++--- 1 files

[PATCH 3/6] iw_cxgb3: Don't count neg_adv abort_req_rss messages as real aborts.

2007-06-27 Thread Steve Wise
iw_cxgb3: Don't count neg_adv abort_req_rss messages as real aborts. negative advice messages should _not_ count toward the 2 abort requests needed to indicate an abort request. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c | 14 +++--- 1 fil

[PATCH 4/6] iw_cxgb3: ctrl-qp init/clear shouldn't set the gen bit.

2007-06-27 Thread Steve Wise
iw_cxgb3: ctrl-qp init/clear shouldn't set the gen bit. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/cxio_hal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio

[PATCH 1/6] iw_cxgb3: Streaming -> RDMA mode transition fixes.

2007-06-27 Thread Steve Wise
iw_cxgb3: Streaming -> RDMA mode transition fixes. Due to a HW issue, our current scheme to transition the connection from streaming to rdma mode is broken on the passive side. The firmware and driver now support a new transition scheme for the passive side: - driver posts rdma_init_wr (now inc

[PATCH 2/6] iw_cxgb3: TERMINATE WRs can hang the tx ofld queue.

2007-06-27 Thread Steve Wise
iw_cxgb3: TERMINATE WRs can hang the tx ofld queue. Don't set the gen bits nor length bits in the terminate wr. This is done by the LLD driver. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_qp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(

[PATCH 0/6] iw_cxgb3: Bug Fixes for 2.6.23

2007-06-27 Thread Steve Wise
Hey Roland, Here are some bug fixes to the iw_cxgb3 driver that I'd like included for 2.6.23. NOTE: Patch 1 requires a firmware interface change, so there is a version bump to 4.3 included in that patch that hits cxgb3. This will likely conflict with a previous version change that is in Jeff's up

Re: [Devel] Re: [RFD] L2 Network namespace infrastructure

2007-06-27 Thread Kirill Korotaev
Jeff Garzik wrote: > Eric W. Biederman wrote: > >>Jeff Garzik <[EMAIL PROTECTED]> writes: >> >> >>>David Miller wrote: >>> I don't accept that we have to add another function argument to a bunch of core routines just to support this crap, especially since you give no way to turn it off

Re: [NET]: gen_estimator: fix locking and timer related bugs [Re: [Bugme-new] [Bug 8668] New: HTB Deadlock]

2007-06-27 Thread Patrick McHardy
Patrick McHardy wrote: > [NET]: gen_estimator: fix locking and timer related bugs > That one still left a race, we could be reinitalizing the timer while it is still running. This patch additionally makes sure each timer is only initialized once. [NET]: gen_estimator: fix locking and timer rela

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread David Brownell
> > > > @@ -3610,15 +3610,14 @@ > > > > USB CDC ETHERNET DRIVER > > > > P: Greg Kroah-Hartman > > > > I think that may refer to the old cdc ethernet driver > > though ... Greg? The new one, in the usbnet framework, > > is a very different beast... > > Yeah, this is the cdc_acm driver that i

[NET]: gen_estimator: fix locking and timer related bugs [Re: [Bugme-new] [Bug 8668] New: HTB Deadlock]

2007-06-27 Thread Patrick McHardy
Patrick McHardy wrote: Jarek Poplawski wrote: I look at this just now, and maybe it's enough for asking, but definitely not enough for patch. I'll try to check this more in the evening, so I could send something tomorrow. So if it's not only about kindness, feel free to do it sooner and I've no

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread Greg KH
On Wed, Jun 27, 2007 at 01:54:15AM -0700, David Brownell wrote: > On Wednesday 27 June 2007, Jeff Garzik wrote: > > Peter Korsgaard wrote: > > > Questions regarding the USB network drivers should now go to netdev. > > > > > > Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> > > > --- > > > MAIN

Re: [Devel] Re: [RFD] L2 Network namespace infrastructure

2007-06-27 Thread Ben Greear
Kirill Korotaev wrote: Patrick McHardy wrote: I believe OpenVZ stores the current namespace somewhere global, which avoids passing the namespace around. Couldn't you do this as well? yes, we store a global namespace context on current (can be stored in per-cpu as well). do you prefer

Re: [Bugme-new] [Bug 8668] New: HTB Deadlock

2007-06-27 Thread Patrick McHardy
Jarek Poplawski wrote: On Wed, Jun 27, 2007 at 01:44:08PM +0200, Patrick McHardy wrote: BTW, maybe I look at this too short, but is this del_timer() in gen_kill_estimator() enough? I cannot see nothing against a timer just running and doing mod_timer() again... Yes, but nothing bad ca

Re: [Devel] Re: [RFD] L2 Network namespace infrastructure

2007-06-27 Thread Patrick McHardy
Kirill Korotaev wrote: Patrick McHardy wrote: I believe OpenVZ stores the current namespace somewhere global, which avoids passing the namespace around. Couldn't you do this as well? yes, we store a global namespace context on current (can be stored in per-cpu as well). do you prefe

Re: [Devel] Re: [RFD] L2 Network namespace infrastructure

2007-06-27 Thread Kirill Korotaev
Patrick McHardy wrote: > Eric W. Biederman wrote: > >>-- The basic design >> >>There will be a network namespace structure that holds the global >>variables for a network namespace, making those global variables >>per network namespace. >> >>One of those per network namespace global variables will

Re: [Devel] Re: [RFD] L2 Network namespace infrastructure

2007-06-27 Thread Kirill Korotaev
Ben Greear wrote: > Patrick McHardy wrote: > >>Eric W. Biederman wrote: >> >> >>>-- The basic design >>> >>>There will be a network namespace structure that holds the global >>>variables for a network namespace, making those global variables >>>per network namespace. >>> >>>One of those per netw

Re: [PATCH] RFC: have tcp_recvmsg() check kthread_should_stop() and treat it as if it were signalled

2007-06-27 Thread Oleg Nesterov
On 06/27, Satyam Sharma wrote: > > Thanks for your comments, I'm still not convinced, however. An perhaps you are right. I don't have a very strong opinion on that. Still I can't understand why it is better if kthread_stop() sends a signal as well. Contrary, I believe we should avoid signals when

Re: [Bugme-new] [Bug 8668] New: HTB Deadlock

2007-06-27 Thread Jarek Poplawski
On Wed, Jun 27, 2007 at 02:10:13PM +0200, Jarek Poplawski wrote: ... - > So if it's not only about kindness, feel free to do it + > So if it's only about kindness, feel free to do it Sorry! Jarek P. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EM

Re: [Bugme-new] [Bug 8668] New: HTB Deadlock

2007-06-27 Thread Jarek Poplawski
On Wed, Jun 27, 2007 at 01:44:08PM +0200, Patrick McHardy wrote: > Jarek Poplawski wrote: > >On 25-06-2007 11:28, Patrick McHardy wrote: > >... > > > >>It is. This patch I had originally planned for 2.6.23 switches HTB > >>to the generic estimator, which shouldn't suffer from this. > >> > > >

Re: [Bugme-new] [Bug 8668] New: HTB Deadlock

2007-06-27 Thread Patrick McHardy
Jarek Poplawski wrote: On 25-06-2007 11:28, Patrick McHardy wrote: ... It is. This patch I had originally planned for 2.6.23 switches HTB to the generic estimator, which shouldn't suffer from this. BTW, maybe I look at this too short, but is this del_timer() in gen_kill_estimator() eno

Re: [Bugme-new] [Bug 8668] New: HTB Deadlock

2007-06-27 Thread Jarek Poplawski
On 25-06-2007 11:28, Patrick McHardy wrote: ... > It is. This patch I had originally planned for 2.6.23 switches HTB > to the generic estimator, which shouldn't suffer from this. BTW, maybe I look at this too short, but is this del_timer() in gen_kill_estimator() enough? I cannot see nothing again

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread Petko Manolov
On Wed, 27 Jun 2007, Jeff Garzik wrote: Peter Korsgaard wrote: Questions regarding the USB network drivers should now go to netdev. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- MAINTAINERS | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) Index: linux-2.6.22-rc6

Re: [PATCH] 8139cp dev->tx_timeout

2007-06-27 Thread Jarek Poplawski
(second try! sorry) On 27-06-2007 10:36, Jeff Garzik wrote: > [EMAIL PROTECTED] wrote: >> Hello All, >> >> We have been experimenting a couple of interface hangs with the 8139cp >> driver. It appears that the tx buffer stops transmitting and never starts >> up again in some yet unknown conditions

[no subject]

2007-06-27 Thread Jarek Poplawski
Jean-Baptiste Vignaud <[EMAIL PROTECTED]>, "marcin.slusarz" <[EMAIL PROTECTED]>, shemminger <[EMAIL PROTECTED]> Subject: Re: [PATCH] 8139cp dev->tx_timeout References: <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> In-Reply-To: <[EMAIL PROTECTED]> On 27-06-2007 10:36, Jeff Garzik wrote: > [EMAIL PROTECTE

[PATCH 2.6.21.5] 8139cp: dev->tx_timeout

2007-06-27 Thread Mika . Lansirinne
This patch implements the missing dev->tx_timeout for 8139cp driver Signed-off-by: Mika Lansirinne <[EMAIL PROTECTED]> --- diff -ru linux-2.6.21.5/drivers/net/8139cp.c linux-2.6.21.5_8139cp-tx_timeout/drivers/net/8139cp.c --- linux-2.6.21.5/drivers/net/8139cp.c 2007-06-11 21:37:06.0 +0

Re: 2.6.20->2.6.21 - networking dies after random time

2007-06-27 Thread Jarek Poplawski
On Tue, Jun 26, 2007 at 04:24:07PM +0200, Jean-Baptiste Vignaud wrote: > Hello, i have a very similar problem with 2.6.21 also; > > 2 3com NICs and they are failling randomly. > > The kernel is a basic fedora 7 kernel (2.6.21-1.3228.fc7) > I found a bug report and added details here : > https://

Re: [PATCH] 8139cp dev->tx_timeout

2007-06-27 Thread Mika . Lansirinne
Jeff, Thanks for the correction. I'll resend the patch in the correct form. I will also send the results of our test as soon as we have some. -Mika > Seems OK, but I'm definitely interested in hearing test feedback. > > Also, all patches need a Signed-off-by line per > Documentation/Sub

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread David Brownell
On Wednesday 27 June 2007, Jeff Garzik wrote: > Peter Korsgaard wrote: > > Questions regarding the USB network drivers should now go to netdev. > > > > Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> > > --- > > MAINTAINERS | 13 + > > 1 file changed, 5 insertions(+), 8 deletions

Re: [NET 04/05]: dev: secondary unicast address support

2007-06-27 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 27 Jun 2007 10:30:09 +0200 > David Miller wrote: > > From: Patrick McHardy <[EMAIL PROTECTED]> > > Date: Fri, 22 Jun 2007 14:24:12 +0200 (MEST) > > > > > >>[NET]: dev: secondary unicast address support > >> > >>Add support for configuring seco

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread Peter Korsgaard
On 6/27/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Quite true, but for courtesy's sake you should keep the relevant maintainers in the loop, and get their ACKs, when you start changing their MAINTAINERS entries. Sorry, I forgot the CCs. David already agreed with the change: http://thread.gman

Re: [PATCH] 8139cp dev->tx_timeout

2007-06-27 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: Hello All, We have been experimenting a couple of interface hangs with the 8139cp driver. It appears that the tx buffer stops transmitting and never starts up again in some yet unknown conditions. To be able to circumvent this we implemented the missing dev->tx_timeout f

Re: [NET 04/05]: dev: secondary unicast address support

2007-06-27 Thread Patrick McHardy
David Miller wrote: > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Fri, 22 Jun 2007 14:24:12 +0200 (MEST) > > >>[NET]: dev: secondary unicast address support >> >>Add support for configuring secondary unicast addresses on network >>devices. To support this devices capable of filtering multip

[PATCH] 8139cp dev->tx_timeout

2007-06-27 Thread Mika . Lansirinne
Hello All, We have been experimenting a couple of interface hangs with the 8139cp driver. It appears that the tx buffer stops transmitting and never starts up again in some yet unknown conditions. To be able to circumvent this we implemented the missing dev->tx_timeout function which should reset

Re: [NET 04/05]: dev: secondary unicast address support

2007-06-27 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 22 Jun 2007 14:24:12 +0200 (MEST) > [NET]: dev: secondary unicast address support > > Add support for configuring secondary unicast addresses on network > devices. To support this devices capable of filtering multiple > unicast addresses need t

Re: [NET 03/05]: dev_mcast: switch to generic net_device address lists

2007-06-27 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 22 Jun 2007 14:24:10 +0200 (MEST) > [NET]: dev_mcast: switch to generic net_device address lists > > Use generic net_device address lists for multicast list handling. > Some defines are used to keep drivers working. > > Signed-off-by: Patrick

Re: [NET 02/05]: dev: introduce generic net_device address lists

2007-06-27 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 22 Jun 2007 14:24:09 +0200 (MEST) > [NET]: dev: introduce generic net_device address lists > > Introduce struct dev_addr_list and list maintenance functions > based on dev_mc_list and the related functions. This will be > used by follow-up patc

Re: [NET 01/05]: dev_mcast: unexport dev_mc_upload

2007-06-27 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 22 Jun 2007 14:24:07 +0200 (MEST) > [NET]: dev_mcast: unexport dev_mc_upload > > dev_mc_add/dev_mc_delete take care of uploading the list when > necessary and thats the only interface other code should use. > Also remove two incorrect calls in

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread Jeff Garzik
Peter Korsgaard wrote: Questions regarding the USB network drivers should now go to netdev. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- MAINTAINERS | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) Index: linux-2.6.22-rc6/MAINTAINERS =

[PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread Peter Korsgaard
Questions regarding the USB network drivers should now go to netdev. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- MAINTAINERS | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) Index: linux-2.6.22-rc6/MAINTAINERS ==

Re: resend [PATCH 2/5 2.6.21] L2TP: Changes to existing ppp and socket kernel headers for L2TP

2007-06-27 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Wed, 27 Jun 2007 00:18:24 -0700 (PDT) > From: James Chapman <[EMAIL PROTECTED]> > Date: Sat, 26 May 2007 18:47:24 +0100 > > > Add struct sockaddr_pppol2tp to carry L2TP-specific address > > information for the PPPoX (PPPoL2TP) socket. Unfortunately we

Re: [RFC PATCH 0/2] dmaengine: preparation for raid acceleration

2007-06-27 Thread David Miller
From: Dan Williams <[EMAIL PROTECTED]> Date: Fri, 01 Jun 2007 17:17:49 -0700 > Hello David, > > The following two patches are part of the raid acceleration series I > would like to push for 2.6.23 consideration. I am sending these two > separately for your review for the following reasons: the '

Re: [RFC] IPV6 checksum offloading in network devices

2007-06-27 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 30 May 2007 14:00:34 -0700 > This is better. > There is still a possiblity when a device allows IPV6 and not IPV4 > checksumming, that the checksum will be done in the fixup code in > dev_queue_xmit. > > The existing model for checksum offlo

Re: Linksys Gigabit USB2.0 adapter (asix) regression

2007-06-27 Thread Erik Slagter
David Hollis wrote: > On Mon, 2007-06-25 at 19:05 +0200, Erik Slagter wrote: >> drivers/net/usb/asix.c: PHYID=0x01410cc2 > > Ok, it is using a Marvell PHY so that part should be fine. You > mentioned that it looks like the packets are being transmitted, but are > garbled in some way. The device

Re: [PATCH] netpoll: tx lock deadlock fix

2007-06-27 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 29 May 2007 17:32:21 -0700 > If sky2 device poll routine is called from netpoll_send_skb, it > would deadlock. The netpoll_send_skb held the netif_tx_lock, and the > poll routine could acquire it to clean up skb's. Other drivers > might use sa

[git patches] net driver fixes

2007-06-27 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/au1000_eth.c |2 +- drivers/net/cxgb3/xgmac.c |8 +--- drivers/net/s2io.c| 16 +--- 3 f

Re: resend [PATCH 4/5 2.6.21] L2TP: Add PPPoL2TP maintainer

2007-06-27 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Sat, 26 May 2007 18:47:24 +0100 > Signed-off-by: James Chapman <[EMAIL PROTECTED]> I'll apply this and the following documentation patch once we sort out the UDP decapsulation issues. Thanks. - To unsubscribe from this list: send the line "unsubscrib

Re: resend [PATCH 3/5 2.6.21] L2TP: PPP over L2TP driver core

2007-06-27 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Sat, 26 May 2007 18:47:24 +0100 > This driver handles only L2TP data frames; control frames are handled > by a userspace application. It implements L2TP using the PPPoX socket > family. There is a PPPoX socket for each L2TP session in an L2TP tunnel. >

Re: resend [PATCH 2/5 2.6.21] L2TP: Changes to existing ppp and socket kernel headers for L2TP

2007-06-27 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Sat, 26 May 2007 18:47:24 +0100 > Add struct sockaddr_pppol2tp to carry L2TP-specific address > information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't > use the union inside struct sockaddr_pppox because the L2TP-specific > data is larger

[PATCH] Re: [2.6.21.1] soft lockup when removing netconsole module

2007-06-27 Thread Jarek Poplawski
On Tue, Jun 26, 2007 at 06:00:00PM -0700, Andrew Morton wrote: > On Tue, 26 Jun 2007 17:46:13 -0700 "Wessel, Jason" <[EMAIL PROTECTED]> wrote: ... > > > Everything went quiet? > > > > > > If this patch has been tested and fixes the bug, can you > > > please send a version which is ready for mergi

Re: resend [PATCH 1/5 2.6.21] UDP: Introduce UDP encapsulation type for L2TP

2007-06-27 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Sat, 26 May 2007 18:47:24 +0100 > This patch adds a new UDP_ENCAP_L2TPINUDP encapsulation type for UDP > sockets. When a UDP socket's encap_type is UDP_ENCAP_L2TPINUDP, the > skb is delivered to a function pointed to by udp_encap_l2tp_rcv. If > the skb