From: [EMAIL PROTECTED]
Date: Mon, 02 Jul 2007 01:14:31 +0300
> This patch extracts common code from irttp_open_tsap() and irttp_dup()
> into a new function to 1) avoid code duplication, 2) help avoid forgetting
> object initialization in the tsap duplication path in the future.
>
> Signed-off-
From: [EMAIL PROTECTED]
Date: Mon, 02 Jul 2007 01:14:30 +0300
> Cc: Alex Villacís Lasso <[EMAIL PROTECTED]>
> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo i
From: [EMAIL PROTECTED]
Date: Mon, 02 Jul 2007 01:14:29 +0300
> Through the IrDA netlink set mode command, we switch to IrDA monitor mode,
> where one IrLAP instance receives all the packets on the media, without ever
> responding to them.
>
> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
Appl
From: [EMAIL PROTECTED]
Date: Mon, 02 Jul 2007 01:14:28 +0300
> First IrDA configuration netlink layer implementation.
> Currently, we only support the set/get mode commands.
>
> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
Patch applied, thanks.
-
To unsubscribe from this list: send the line
From: Jeff Dike <[EMAIL PROTECTED]>
Date: Thu, 21 Jun 2007 10:59:11 -0400
> On Mon, Jun 18, 2007 at 10:36:54PM -0700, David Miller wrote:
> > This patch looks fine.
> >
> > I'd like it resubmitted with a proper changelog and signoff, and once
> > I have that I will thus queue it up for the 2.6.23
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Tue, 19 Jun 2007 17:02:23 +0200 (MEST)
> [NET_SCHED]: Remove unnecessary includes
>
> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
There was a minor conflict with the multi-queue patches but it
was line number noise so I took care of it.
App
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Tue, 19 Jun 2007 23:22:06 +0200
> [NET_SCHED]: sch_htb: use generic estimator
>
> Use the generic estimator instead of reimplementing (parts of) it.
> For compatibility always create a default estimator for new classes.
>
> Signed-off-by: Patrick M
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Tue, 19 Jun 2007 17:02:19 +0200 (MEST)
> [NET_SCHED]: Remove CONFIG_NET_ESTIMATOR option
>
> The generic estimator is always built in anways and all the config options
> does is prevent including a minimal amount of code for setting it up.
> Additio
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Tue, 19 Jun 2007 17:02:21 +0200 (MEST)
> [NET_SCHED]: Remove unnecessary stats_lock pointers
>
> Remove stats_lock pointers from qdisc-internal structures, in all cases
> it points to dev->queue_lock. The only case where it is necessary is for
> top
From: jamal <[EMAIL PROTECTED]>
Date: Tue, 12 Jun 2007 19:08:39 -0400
> commit bfd389bba7654aa118f0949ff0de45a3bce9700c
> Author: Jamal Hadi Salim <[EMAIL PROTECTED]>
> Date: Tue Jun 12 18:59:33 2007 -0400
>
> [PKTGEN] IPSEC support
> Added transport mode ESP support for starters.
>
From: jamal <[EMAIL PROTECTED]>
Date: Tue, 12 Jun 2007 19:06:03 -0400
> commit 4fe3190756589ef8155eb97fe725f2564f1fc77d
> Author: Jamal Hadi Salim <[EMAIL PROTECTED]>
> Date: Tue Jun 12 12:35:39 2007 -0400
>
> [XFRM] Introduce standalone SAD lookup
> This allows other in-kernel function
From: jamal <[EMAIL PROTECTED]>
Date: Tue, 12 Jun 2007 08:01:55 -0400
> commit 882c296bb3f153e1ac770a874c75cfb2bab8481b
> Author: Jamal Hadi Salim <[EMAIL PROTECTED]>
> Date: Tue Jun 12 07:24:00 2007 -0400
>
> [PKTGEN] Introduce sequential flows
>
> By default all flows in pktgen a
From: jamal <[EMAIL PROTECTED]>
Date: Tue, 12 Jun 2007 08:00:28 -0400
> commit 38477d7ddfa58f58cce99bc902b4c18883647a71
> Author: Jamal Hadi Salim <[EMAIL PROTECTED]>
> Date: Tue Jun 12 06:43:00 2007 -0400
>
> [PKTGEN] Centralize packet overhead tracking
> Track the extra packet overhea
From: "John W. Linville" <[EMAIL PROTECTED]>
Date: Mon, 11 Jun 2007 21:24:11 -0400
> From: Larry Finger <[EMAIL PROTECTED]>
>
> The initial rate for STA's using rc80211_simple is set to the last
> rate in the rate table. For situations for which the signal is weak,
> the rate may be too high for
From: "John W. Linville" <[EMAIL PROTECTED]>
Date: Mon, 11 Jun 2007 21:23:19 -0400
> From: Larry Finger <[EMAIL PROTECTED]>
>
> At present, transmission rate information for mac80211 is available only
> if verbose debugging is turned on, and then only in the logs. This patch
> implements the SIOC
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Sat, 16 Jun 2007 02:04:25 +0300 (EEST)
> There are still some things I must think carefully in sacktag processing
> since it does not validate start_seq and end_seq at all which can be
> abused currently at least in tcp-2.6. ...I would rather put e
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 14:10:30 +0300
> From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
>
> Previously code had IsReno/IsFack defined as macros that were
> local to tcp_input.c though sack_ok field has users elsewhere
> too for the same purpose
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 14:10:29 +0300
> From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
>
> There is no need for such check in pkts_acked because the
> callback is not invoked unless at least one segment got fully
> ACKed (i.e., the snd_una mov
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 14:10:28 +0300
> From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
>
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
Applied to tcp-2.6
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Fri, 1 Jun 2007 15:17:00 +0300 (EEST)
> On Thu, 31 May 2007, David Miller wrote:
>
> > Is it possible to update fastpath_cnt_hint properly perhaps?
>
> I think that would be valid and even accurate as it can checks skb's
> seq against fastpath_skb_
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Thu, 31 May 2007 19:31:21 +0300 (EEST)
> (i.e, how does it show up in oops if tcp_verify_left_out looks like this):
>
> #define tcp_verify_left_out(tp) BUG_ON(...)
>
> ...does it still point to the tcp.h line then or to the
> tcp_sync_left_out
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Sat, 26 May 2007 11:36:01 +0300
> Previously TCP had a transitional state during which reno
> counted segments that are already below the current window into
> sacked_out, which is now prevented. Re-try now unconditional
> S+L catching (I wonder if w
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Mon, 2 Jul 2007 21:36:36 -0700
> My initial thought is that if there is a legitimate need for this
> new capability then it should be made available to other parts of
> the kernel rather than being private to the AEO driver.
Absolutely.
We even used
On Tue, 26 Jun 2007 14:50:11 -0400 "Ed L. Cashin" <[EMAIL PROTECTED]> wrote:
> Use a dynamic pool of sk_buffs to keep up with fast targets.
That's far too skimpy a description of what this patch is doing, what it is
for, what makes AOE need this functionality, etc.
My initial thought is that if
> -Original Message-
> From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On
> Behalf Of Joakim Tjernlund
> Sent: Tuesday, July 03, 2007 8:52 AM
> To: 'linuxppc-dev Development'; 'Netdev'; Li Yang-r58472
> Subject: [PATCH] ucc_geth.c, make PHY device optional.
>
> > This patch makes the PHY
Jason Lunz wrote:
On Mon, Jul 02, 2007 at 05:10:48PM -0700, Rick Jones wrote:
Rambling a bit, and recognizing that "e1000new" was probably just a
strawman name, but I suspect that a _very_ different name for the new
driver would be a good thing, rather than a varition on the e1000 theme.
I r
On Mon, Jul 02, 2007 at 05:10:48PM -0700, Rick Jones wrote:
> Rambling a bit, and recognizing that "e1000new" was probably just a
> strawman name, but I suspect that a _very_ different name for the new
> driver would be a good thing, rather than a varition on the e1000 theme.
I rather liked the
> This patch makes the PHY optional for ucc_geth.c ethernet driver.
> This is useful to support a direct mii to mii connection to, for example,
> a onboard swicth.
>
> Signed-off-by: Joakim Tjernlund <[EMAIL PROTECTED]>
[SNIP patch sent last Friday]
Since this is my last week before vacation
On Monday 02 July 2007, Kok, Auke wrote:
> Jeff Garzik wrote:
> > Michael Buesch wrote:
> >> On Tuesday 03 July 2007 00:02:57 Kok, Auke wrote:
> >>> well, FWIW when I started looking at adding these flags I looked in
> >>> various
> >>> subsystems in the kernel and picked an implementation that s
There seems to be a lot of concern over obsoleting the e1000 driver
too quickly, and with confusing users (and startup scripts) about which
driver to load.
Yes.
Obviously, we at Intel want to get e1000new into the kernel as quickly
as possible, and to obsolete e1000 also as quickly as possible
Kok, Auke wrote:
but let's stay constructive here:
~/git/linux-2.6 $ grep -r 'unsigned int.*:1;' * | wc -l
748
Is anyone going to fix those? If we don't, someone will certainly again
submit patches to add more of these bitfields, after all, some very
prominent parts of the kernel still use th
On 7/2/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
>
> But that'll require the single receiver queue version I guess. The
> netdevice abuse is the only really major issue I see, although I'd of
> course really like to see the driver getting rid of the bitfield abuse
> aswell.
The submitted
Jeff Garzik wrote:
Michael Buesch wrote:
On Tuesday 03 July 2007 00:02:57 Kok, Auke wrote:
well, FWIW when I started looking at adding these flags I looked in various
subsystems in the kernel and picked an implementation that suited. Guess what
pci.h has? ...:
unsigned int msi_enable
Mark McLoughlin wrote:
>> I disagree, we should not break the current e1000 driver in
>the kernel while
>> there is a new driver coming up that introduces ich9 support
>without breaking
>> (the old e1000) support for all other devices. This is why
>we want to drop a new
>> version of the
On Mon, 2007-07-02 at 14:20 -0700, Matt Carlson wrote:
>
> Also, I think the count, max_per_txd, and nr_frags fields of the
> tg3_tx_cbdata struct are not needed.
The count field is not needed also.
+struct tg3_tx_cbdata {
+ u32 base_flags;
+ int count;
+ unsigned int max_per_
On 7/2/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> > Fake netdevs are needed for doing the multiple Rx queues in NAPI
mode.
> > We are thinking to solve in 2 ways. Having netdev pointer in ring
> > structure or having an array of netdev pointers in ixgbe_adatper
struct
> > which would be vis
> "David" == David Brownell <[EMAIL PROTECTED]> writes:
Hi,
David> I'd rather see the later test updated to match this one.
David> (Good catch!)
David> The return convention is "negative means error". There's
David> code in USB which has multiple nonnegative success codes.
Ok, updated
Michael Buesch wrote:
On Tuesday 03 July 2007 00:02:57 Kok, Auke wrote:
well, FWIW when I started looking at adding these flags I looked in various
subsystems in the kernel and picked an implementation that suited. Guess what
pci.h has? ...:
unsigned int msi_enabled:1;
unsigne
On Tue, 3 Jul 2007 00:13:29 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Mon, Jul 02, 2007 at 10:54:01AM -0400, Jeff Garzik wrote:
> >...
> > maximilian attems (1):
> > starfire list alpha as 64 bit arch
> >...
> > --- a/drivers/net/starfire.c
> > +++ b/drivers/net/starfire.c
> > @@ -15
On Mon, Jul 02, 2007 at 10:54:01AM -0400, Jeff Garzik wrote:
>...
> maximilian attems (1):
> starfire list alpha as 64 bit arch
>...
> --- a/drivers/net/starfire.c
> +++ b/drivers/net/starfire.c
> @@ -152,7 +152,7 @@ static int full_duplex[MAX_UNITS] = {0, };
> * This SUCKS.
> * We need a
On Tuesday 03 July 2007 00:02:57 Kok, Auke wrote:
> well, FWIW when I started looking at adding these flags I looked in various
> subsystems in the kernel and picked an implementation that suited. Guess what
> pci.h has? ...:
>
> unsigned int msi_enabled:1;
> unsigned int msix_enable
Kok, Auke wrote:
I suppose I can fix those, but I really don't understand what all the
fuzz is about here. We're only conserving memory and staying far away
from the real risks of bitmasks, so forgive me if I don't grasp the
problem.
Be it machine ints or bitfields, you're not conserving memo
Christoph Hellwig wrote:
On Mon, Jul 02, 2007 at 02:09:58PM -0700, Stephen Hemminger wrote:
The patch is close to ready for 2.6.24 when this driver will need to show up.
If intel manages to fix up the reamining issues I'd rather see it appear
in 2.6.23..
Since I know Intel will be forced to
Peter Missel <[EMAIL PROTECTED]> :
[...]
> Unfortunately I couldn't get NFS to work with the updated kernel, so I had to
> revert to the original from SuSE 10.2.
No NFS but networking or no networking at all ?
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
Bill Davidsen wrote:
Adrian Bunk wrote:
This patch contains the overdue removal of the eepro100 driver.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
The hardware supported by this driver is still in use, thanks. It's
probably easier to leave the eepro100 driver in than find anyone who
want
On Mon, Jul 02, 2007 at 02:09:58PM -0700, Stephen Hemminger wrote:
> The patch is close to ready for 2.6.24 when this driver will need to show up.
If intel manages to fix up the reamining issues I'd rather see it appear
in 2.6.23..
> Since I know Intel will be forced to backport this to older dis
On Wed, 2007-06-27 at 20:05 -0400, jamal wrote:
> peoplez,
>
> I have added support for tg3 on batching. I see equivalent performance
> improvement for pktgen as i did with e1000 when using gige.
> I have only tested on two machines (one being a laptop which does
> 10/100Mbps). Unfortunately in b
On Mon, 2 Jul 2007 12:00:29 -0700
"Veeraiyan, Ayyappan" <[EMAIL PROTECTED]> wrote:
> On 7/2/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> > Ayyappan Veeraiyan wrote:
> > > +#define IXGBE_TX_FLAGS_VLAN_MASK 0x
> > > +#define IXGBE_TX_FLAGS_VLAN_SHIFT16
> >
> > defining bits using th
On Mon, Jul 02, 2007 at 12:00:29PM -0700, Veeraiyan, Ayyappan wrote:
> Agreed.
> Fake netdevs are needed for doing the multiple Rx queues in NAPI mode.
> We are thinking to solve in 2 ways. Having netdev pointer in ring
> structure or having an array of netdev pointers in ixgbe_adatper struct
> wh
Thanks Francois.
Unfortunately I couldn't get NFS to work with the updated kernel, so I had to
revert to the original from SuSE 10.2.
The other thing that didn't work with 2.6.21.5 was suspend-to-disk (would
suspend, but not resume), so I don't have any useful input for you this time.
I'll be
On Mon, 2 Jul 2007 15:52:01 +0200
maximilian attems <[EMAIL PROTECTED]> wrote:
> nobody objected to adrian's rfc dropping dgrs on netdev back in dec. 2006.
> -> http://marc.info/?l=linux-netdev&m=116507999803538&w=2
> as bonus points this will get rid of a prorpietary licensed firmware.
>
> so no
On 7/2/07, Veeraiyan, Ayyappan <[EMAIL PROTECTED]> wrote:
Thanks for the feedback. I will post another version shortly (except the
feature flags change and the ring struct name members) which fixes my
Just to clarify this, I will wait some more time for feature flags
discussion and the ring st
Nils Rennebarth wrote:
Bjorn Helgaas wrote:
On Thursday 28 June 2007 10:01:08 am Kok, Auke wrote:
I copied Nils Rennebarth, who originally reported the bug:
http://bugzilla.kernel.org/show_bug.cgi?id=5918
in case he can test your patch.
>
Most of the embedded boards we now work with appear to
Adrian Bunk wrote:
This patch contains the overdue removal of the eepro100 driver.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
The hardware supported by this driver is still in use, thanks. It's
probably easier to leave the eepro100 driver in than find anyone who
wants to investigate why t
On 7/2/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Ayyappan Veeraiyan wrote:
> > +#define IXGBE_TX_FLAGS_VLAN_MASK 0x
> > +#define IXGBE_TX_FLAGS_VLAN_SHIFT16
>
> defining bits using the form "(1 << n)" is preferred. Makes it easier
> to read, by eliminating the requirement of th
Ben Dooks wrote:
On Mon, Jul 02, 2007 at 11:08:26AM -0400, Jeff Garzik wrote:
This is what is currently queued for 2.6.23. There are a few patches
in my mbox not yet applied to the git tree, but this is most of them.
I sent driver support for the AX88796 a few weeks ago with no feedback,
shou
Peter Staubach wrote:
[EMAIL PROTECTED] wrote:
To use a NFS-root for UDP jumbo frames the kernel on the client need
to bring
up interface with MTU set to 9000 bytes - otherwise it cannot contact
server
with jumbo frames enabled (nfs server not responding, still trying)
and cannot
boot. Added a
On Mon, Jul 02, 2007 at 11:08:26AM -0400, Jeff Garzik wrote:
>
> This is what is currently queued for 2.6.23. There are a few patches
> in my mbox not yet applied to the git tree, but this is most of them.
I sent driver support for the AX88796 a few weeks ago with no feedback,
should I re-send t
On Mon, 2 Jul 2007 14:37:06 +0100
"Daniel J Blueman" <[EMAIL PROTECTED]> wrote:
> Hi Stephen,
>
> When the sky2 driver initialises, it sets the the ISR timer register
> (STAT_ISR_TIMER_INI) to 125 * 20 = 2500, whereas the vendor sk98lin
> driver sets it to 400, irrespective of the clockspeed of t
On Monday 02 July 2007, Peter Korsgaard wrote:
> usbnet_probe() handles a positive return value from the driver bind()
> function as success, but will later only setup the status handler if the
> return value was zero, leading to confusion. Patch adjusts this to only
> accept 0 as success in both c
Andrew Morton wrote:
On Mon, 02 Jul 2007 11:32:41 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote:
Bitfields are to be avoided for many reasons:
* more difficult, in general, for a compiler to generate optimal code
* in particular, known to generate worse code on various architectures
* often cause
On 02/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
On Mon, 2 Jul 2007 14:37:06 +0100
"Daniel J Blueman" <[EMAIL PROTECTED]> wrote:
> When the sky2 driver initialises, it sets the the ISR timer register
> (STAT_ISR_TIMER_INI) to 125 * 20 = 2500, whereas the vendor sk98lin
> driver sets it t
On Mon, 2 Jul 2007 14:37:06 +0100
"Daniel J Blueman" <[EMAIL PROTECTED]> wrote:
> Hi Stephen,
>
> When the sky2 driver initialises, it sets the the ISR timer register
> (STAT_ISR_TIMER_INI) to 125 * 20 = 2500, whereas the vendor sk98lin
> driver sets it to 400, irrespective of the clockspeed of t
Jeff Garzik wrote:
Kok, Auke wrote:
Maybe this is not most important for ixgbe, where we only have 8 or so
flags, but the new e1000 driver that I posted this weekend currently has
63 (you wanted flags ;)) of them. Do you want me to use 63 integers or
just 2 ?
Don't be silly. We are talking
On Mon, 02 Jul 2007 11:32:41 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Bitfields are to be avoided for many reasons:
> * more difficult, in general, for a compiler to generate optimal code
> * in particular, known to generate worse code on various architectures
> * often causes endian problem
usbnet_probe() handles a positive return value from the driver bind()
function as success, but will later only setup the status handler if the
return value was zero, leading to confusion. Patch adjusts this to only
accept 0 as success in both checks.
Signed-off-by: Peter Korsgaard <[EMAIL PROTECTE
Kok, Auke wrote:
Maybe this is not most important for ixgbe, where we only have 8 or so
flags, but the new e1000 driver that I posted this weekend currently has
63 (you wanted flags ;)) of them. Do you want me to use 63 integers or
just 2 ?
Don't be silly. We are talking about single-bit fe
Jeff Garzik wrote:
Arjan van de Ven wrote:
Jeff Garzik wrote:
always avoid bitfields. They generate horrible code, and endian
problems abound (though no endian problems are apparent here).
they generate no worse code than open coding the checks for these
feature flags...
That would be the log
This is what is currently queued for 2.6.23. There are a few patches
in my mbox not yet applied to the git tree, but this is most of them.
The following is found in the 'upstream' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
Akinobu Mita (1):
softmac: use
On Mon, 2007-07-02 at 16:38 +0200, Patrick McHardy wrote:
> > Do I understand you correctly in that you prefer the way I did it now?
>
>
> Yes.
Alright, then I'll rework the event generation to not include the whole
family info and repost with that tomorrow or so. If I find time I might
actuall
Jeff Garzik wrote:
It's simple logic: using machine integers are the easiest for the
compiler to Do The Right Thing, the easiest way to eliminate endian
problems, the easiest way for programmers to read and understand struct
alignment.
using integers pure is obviously natural..
but using int
Arjan van de Ven wrote:
Jeff Garzik wrote:
always avoid bitfields. They generate horrible code, and endian
problems abound (though no endian problems are apparent here).
they generate no worse code than open coding the checks for these
feature flags...
That would be the logical assumption,
Johannes Berg wrote:
> On Mon, 2007-07-02 at 14:56 +0200, Patrick McHardy wrote:
>
>>The main reason to use nested attributes is when you only have a
>>single attribute to store your data in (for example TCA_OPTIONS
>>for qdiscs). In that case a nested attribute should be used to
>>allow to extend
On Mon, 2007-07-02 at 14:56 +0200, Patrick McHardy wrote:
> For information that belongs together logically a struct is fine.
Ok.
> The main reason to use nested attributes is when you only have a
> single attribute to store your data in (for example TCA_OPTIONS
> for qdiscs). In that case a nes
Jeff Garzik wrote:
I'm not sure whether gcc is confused about ABI alignment or such, on
various platforms, but every time I look at the asm generated it is
/not/ equivalent to open-coded feature flags and bitwise logic. Often
it is demonstrably worse.
(I can imagine this being different if y
Jeff Garzik wrote:
always avoid bitfields. They generate horrible code, and endian
problems abound (though no endian problems are apparent here).
they generate no worse code than open coding the checks for these
feature flags...
That would be the logical assumption, but reality does not bea
Arjan van de Ven wrote:
>> +u32 alloc_rx_buff_failed;
+struct {
+unsigned int rx_csum_enabled:1;
+unsigned int msi_capable:1;
+unsigned int msi_enabled:1;
+unsigned int msix_capable:1;
+unsigned int msix_enabled:1;
+uns
Patrick McHardy wrote:
Russell King wrote:
Having upgraded from 2.6.16 to 2.6.22-rc6, I'm now seeing the following.
Looks like netfilter is calling local_bh_enable() with IRQs disabled,
which would appear to be illegal. Thankfully, this is a warn-once
warning.
WARNING: at /home/rmk/git/linux-
[EMAIL PROTECTED] writes:
> To use a NFS-root for UDP jumbo frames the kernel on the client need to bring
> up interface with MTU set to 9000 bytes - otherwise it cannot contact server
> with jumbo frames enabled (nfs server not responding, still trying) and
> cannot
> boot. Added a kernel paramet
Russell King wrote:
> Having upgraded from 2.6.16 to 2.6.22-rc6, I'm now seeing the following.
>
> Looks like netfilter is calling local_bh_enable() with IRQs disabled,
> which would appear to be illegal. Thankfully, this is a warn-once
> warning.
>
> WARNING: at /home/rmk/git/linux-2.6-rmk/kern
>> +u32 alloc_rx_buff_failed;
+struct {
+unsigned int rx_csum_enabled:1;
+unsigned int msi_capable:1;
+unsigned int msi_enabled:1;
+unsigned int msix_capable:1;
+unsigned int msix_enabled:1;
+unsigned int imir_enabled
(Resending the patch against 2.6.22-rc7)
This patch implements the missing dev->tx_timeout for 8139cp driver
Signed-off-by: Mika Lansirinne <[EMAIL PROTECTED]>
---
diff -uprN linux-2.6.22-rc7/drivers/net/8139cp.c
linux-2.6.22-rc7_8139cp-tx_timeout/drivers/net/8139cp.c
--- linux-2.6.22-rc7/driv
Thomas Bogendoerfer wrote:
On Mon, Jul 02, 2007 at 08:43:04AM -0400, Jeff Garzik wrote:
applied both patches.
Please provide an update that does at Andrew requested -- rather than
#include'ing lib82596.c, you should update the Makefile for relevant
drivers to look like
I got the impression
nobody objected to adrian's rfc dropping dgrs on netdev back in dec. 2006.
-> http://marc.info/?l=linux-netdev&m=116507999803538&w=2
as bonus points this will get rid of a prorpietary licensed firmware.
so now be a bit more serious and remove the Kconfig entries
and see if anyone shouts. if no voi
On Mon, Jul 02, 2007 at 08:43:04AM -0400, Jeff Garzik wrote:
> applied both patches.
>
> Please provide an update that does at Andrew requested -- rather than
> #include'ing lib82596.c, you should update the Makefile for relevant
> drivers to look like
I got the impression that Andrew is fine w
Hi Stephen,
When the sky2 driver initialises, it sets the the ISR timer register
(STAT_ISR_TIMER_INI) to 125 * 20 = 2500, whereas the vendor sk98lin
driver sets it to 400, irrespective of the clockspeed of the NIC
processor.
I guess you found more performance/stability from this value...?
I've
[EMAIL PROTECTED] wrote:
To use a NFS-root for UDP jumbo frames the kernel on the client need to bring
up interface with MTU set to 9000 bytes - otherwise it cannot contact server
with jumbo frames enabled (nfs server not responding, still trying) and cannot
boot. Added a kernel parameter named '
To use a NFS-root for UDP jumbo frames the kernel on the client need to bring
up interface with MTU set to 9000 bytes - otherwise it cannot contact server
with jumbo frames enabled (nfs server not responding, still trying) and cannot
boot. Added a kernel parameter named 'ipmtu' which can be used to
Ayyappan Veeraiyan wrote:
+#define IXGBE_TX_FLAGS_CSUM0x0001
+#define IXGBE_TX_FLAGS_VLAN0x0002
+#define IXGBE_TX_FLAGS_TSO 0x0004
+#define IXGBE_TX_FLAGS_IPV40x0008
+#define IXGBE_TX_FLAGS_VLAN_MASK 0x
+#define IXGBE_T
Johannes Berg wrote:
> On Sat, 2007-06-30 at 11:32 -0400, jamal wrote:
>
>
>>>+NLA_PUT_U32(skb, CTRL_ATTR_MCAST_GRP_ID, grp->id);
>>>+NLA_PUT_STRING(skb, CTRL_ATTR_MCAST_GRP_NAME,
>>>+ grp->name);
>>>+
>>
>>Consider my earl
applied both patches.
Please provide an update that does at Andrew requested -- rather than
#include'ing lib82596.c, you should update the Makefile for relevant
drivers to look like
obj-$(CONFIG_FOO_BAR) += lib82596.o foo_bar_82596.o
and make sure it exports everything to make lib82596 a ful
[EMAIL PROTECTED] wrote:
This patch implements the missing dev->tx_timeout for 8139cp driver
Signed-off-by: Mika Lansirinne <[EMAIL PROTECTED]>
does not seem to apply to current kernel. please resend against
netdev-2.6.git#upstream or 2.6.22-rc7.
-
To unsubscribe from this list: send the
Jan-Bernd Themann wrote:
This patch fixes several whitespace issues.
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/m
Olof Johansson wrote:
It was mistakenly set to interrupt on the second packet instead of first,
causing
some interesting latency behaviour.
Signed-off-by: Olof Johansson <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message
Linas Vepstas wrote:
Replace literal with const; add bit definitions.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
On Wed, Jun 13, 2007 at 04:12:00PM -0400, Jeff Garzik wrote:
A follow-up patch needs to remove the above magic numbers (==numeric
constants), replacing them with named c
Olof Johansson wrote:
Move away from using the pci config access functions for simple register
access. Our device has all of the registers in the config space (hey,
from the hardware point of view it looks reasonable :-), so we need to
somehow get to it. Newer firmwares have it in the device tre
Olof Johansson wrote:
Clean the TX ring in the poll call, to avoid sitting on mapped buffers
for a long time. NFS doesn't seem to like it much, for example.
Signed-off-by: Olof Johansson <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/pasemi_mac.c
Olof Johansson wrote:
Abstract out the PCI config read/write accesses into reg read/write ones, still
calling the pci accessors on the back end.
Signed-off-by: Olof Johansson <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/pasemi_mac.c
MOKUNO Masakazu wrote:
Hi,
This is the second submission of the network driver for PS3.
This version have been updated to address issues raised in the review.
Please apply for 2.6.23.
From: Masakazu Mokuno <[EMAIL PROTECTED]>
Add Gigabit Ethernet support for the PS3 game console. The module
[EMAIL PROTECTED] wrote:
NetXen driver uses PCI function 0 to provide the functionality of MSI.
The patch makes driver check the bus master bit for function 0 and
enable it after the card initialization.
Signed-off-by: Dhananjay Phadke<[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTE
1 - 100 of 125 matches
Mail list logo