Re: 2.6.20-2.6.21 - networking dies after random time

2007-07-30 Thread Marcin Ślusarz
2007/7/26, Ingo Molnar [EMAIL PROTECTED]: (..) yeah - i meant to cover both arches but forgot about x86_64 - updated patch attached below. Ingo - Subject: x86: activate HARDIRQS_SW_RESEND From: Ingo Molnar [EMAIL PROTECTED] activate the software-triggered

Re: [linux-usb-devel] [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

2007-07-30 Thread Petko Manolov
On Sun, 29 Jul 2007, Oliver Neukum wrote: Am Sonntag 29 Juli 2007 schrieb Jesper Juhl: On 29/07/07, Satyam Sharma [EMAIL PROTECTED] wrote: Hi, On 7/29/07, Jesper Juhl [EMAIL PROTECTED] wrote: Hello, This patch makes sure we don't dereference a NULL pointer in

Re: [linux-usb-devel] [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

2007-07-30 Thread Satyam Sharma
On Mon, 30 Jul 2007, Petko Manolov wrote: On Sun, 29 Jul 2007, Oliver Neukum wrote: [...] pegasus == NULL there would be a kernel bug. Silently ignoring it, like the code now wants to do is bad. As the oops has never been reported, I figure turning it into an explicit debugging test

Re: source interface ping bug ?

2007-07-30 Thread nano bug
Can someone have a look a this and tell if it's kernel related or if I posted this in the wrong place ? Thanks. On 7/29/07, nano bug [EMAIL PROTECTED] wrote: Any news about this ? On 7/27/07, nano bug [EMAIL PROTECTED] wrote: Hello there, I'm facing the following issue : when I try to

Re: 2.6.20-2.6.21 - networking dies after random time

2007-07-30 Thread Ingo Molnar
* Alan Cox [EMAIL PROTECTED] wrote: Ok the logic behind the 8390 is very simple: thanks for the explanation Alan! A few comments and a question: Things to know - IRQ delivery is asynchronous to the PCI bus - Blocking the local CPU IRQ via spin locks was too slow - The

Re: 2.6.20-2.6.21 - networking dies after random time

2007-07-30 Thread Ingo Molnar
* Marcin Ślusarz [EMAIL PROTECTED] wrote: Subject: x86: activate HARDIRQS_SW_RESEND From: Ingo Molnar [EMAIL PROTECTED] activate the software-triggered IRQ-resend logic. This patch didn't help (tested on 2.6.22.1) - ne2k_pci timed out. ok. This makes it more likely that the driver

Re: Linksys Gigabit USB2.0 adapter (asix) regression

2007-07-30 Thread Erik Slagter
David Hollis wrote: On Mon, 2007-06-25 at 19:05 +0200, Erik Slagter wrote: drivers/net/usb/asix.c: PHYID=0x01410cc2 Ok, it is using a Marvell PHY so that part should be fine. You mentioned that it looks like the packets are being transmitted, but are garbled in some way. The device does

[PATCH 2.6.23-rc1] PPPOL2TP: Add CONFIG_INET Kconfig dependency

2007-07-30 Thread James Chapman
[PPPOL2TP]: Add CONFIG_INET Kconfig dependency. PPPOL2TP uses UDP so it obviously depends on CONFIG_INET. Signed-off-by: James Chapman [EMAIL PROTECTED] --- Toralf Foerster reported that make rndconfig failed in 2.6.23-rc1 when selecting CONFIG_PPPOL2TP without CONFIG_INET. Index:

Re: [2.6 patch] make nf_ct_ipv6_skip_exthdr() static

2007-07-30 Thread Patrick McHardy
Adrian Bunk wrote: nf_ct_ipv6_skip_exthdr() can now become static. Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] HW VLAN filtering control

2007-07-30 Thread Patrick McHardy
Mitch Williams wrote: This patchset adds the capability to disable hardware VLAN filtering at runtime via the existing vconfig utility. It's useful for debugging purposes. The first patch modifies the VLAN subsystem to define the flag, and to support passing the flag on to the base driver.

[PATCH V3 1/7] IB/ipoib: Bound the net device to the ipoib_neigh structue

2007-07-30 Thread Moni Shoua
IPoIB uses a two layer neighboring scheme, such that for each struct neighbour whose device is an ipoib one, there is a struct ipoib_neigh buddy which is created on demand at the tx flow by an ipoib_neigh_alloc(skb-dst-neighbour) call. When using the bonding driver, neighbours are created by the

[PATCH V3 2/7] IB/ipoib: Verify address handle validity on send

2007-07-30 Thread Moni Shoua
When the bonding device senses a carrier loss of its active slave it replaces that slave with a new one. In between the times when the carrier of an IPoIB device goes down and ipoib_neigh is destroyed, it is possible that the bonding driver will send a packet on a new slave that uses an old

[PATCH V3 3/7] net/bonding: Enable bonding to enslave non ARPHRD_ETHER

2007-07-30 Thread Moni Shoua
This patch changes some of the bond netdevice attributes and functions to be that of the active slave for the case of the enslaved device not being of ARPHRD_ETHER type. Basically it overrides those setting done by ether_setup(), which are netdevice **type** dependent and hence might be not

[PATCH V3 4/7] net/bonding: Enable bonding to enslave netdevices not supporting set_mac_address()

2007-07-30 Thread Moni Shoua
This patch allows for enslaving netdevices which do not support the set_mac_address() function. In that case the bond mac address is the one of the active slave, where remote peers are notified on the mac address (neighbour) change by Gratuitous ARP sent by bonding when fail-over occurs (this is

[PATCH V3 5/7] net/bonding: Enable IP multicast for bonding IPoIB devices

2007-07-30 Thread Moni Shoua
Allow to enslave devices when the bonding device is not up. Over the discussion held at the previous post this seemed to be the most clean way to go, where it is not expected to cause instabilities. Normally, the bonding driver is UP before any enslavement takes place. Once a netdevice is UP,

[PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver

2007-07-30 Thread Moni Shoua
This patch series is the third version (see below link to V2) of the suggested changes to the bonding driver so it would be able to support non ARPHRD_ETHER netdevices for its High-Availability (active-backup) mode. The motivation is to enable the bonding driver on its HA mode to work with

[PATCH V3 6/7] net/bonding: Handlle wrong assumptions that slave is always an Ethernet device

2007-07-30 Thread Moni Shoua
bonding sometimes uses Ethernet constants (such as MTU and address length) which are not good when it enslaves non Ethernet devices (such as InfiniBand). Signed-off-by: Moni Shoua [EMAIL PROTECTED] --- drivers/net/bonding/bond_main.c |2 +- drivers/net/bonding/bond_sysfs.c | 10

[PATCH V3 7/7] net/bonding: Delay sending of gratuitous ARP to avoid failure

2007-07-30 Thread Moni Shoua
Delay sending a gratuitous_arp when LINK_STATE_LINKWATCH_PENDING bit in dev-state field is on. This improves the chances for the arp packet to be transmitted. Signed-off-by: Moni Shoua [EMAIL PROTECTED] --- drivers/net/bonding/bond_main.c | 25 +

Re: 2.6.20-2.6.21 - networking dies after random time

2007-07-30 Thread Alan Cox
So the whole locking is to be able to keep irqs enabled for a long time, without risking entry of the same IRQ handler on this same CPU, correct? As implemented - on any CPU. We also need to know that the IRQ handler is not doing useful work on another processor which is why we take the lock

Re: [PATCH 1/7] Preparatory refactoring part 1.

2007-07-30 Thread Patrick McHardy
Corey Hickey wrote: diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c index 9579573..8ae077f 100644 --- a/net/sched/sch_sfq.c +++ b/net/sched/sch_sfq.c @@ -77,6 +77,9 @@ #define SFQ_DEPTH128 #define SFQ_HASH_DIVISOR 1024 +#define SFQ_HEAD 0 +#define SFQ_TAIL 1 +

Re: [PATCH 2/7] Preparatory refactoring part 2.

2007-07-30 Thread Patrick McHardy
Corey Hickey wrote: diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c index 8ae077f..0c46938 100644 --- a/net/sched/sch_sfq.c +++ b/net/sched/sch_sfq.c @@ -380,71 +380,71 @@ static void sfq_perturbation(unsigned long arg) } } -static int sfq_change(struct Qdisc *sch, struct

Re: [PATCH 6/7] Make qdisc changeable.

2007-07-30 Thread Patrick McHardy
Corey Hickey wrote: Re-implement sfq_change() and enable Qdisc_opts.change so tc qdisc change will work. Signed-off-by: Corey Hickey [EMAIL PROTECTED] --- net/sched/sch_sfq.c | 51 ++- 1 files changed, 50 insertions(+), 1 deletions(-)

Re: [PATCH] NET_DMA: remove unused dma_memcpy_to_kernel_iovec

2007-07-30 Thread pravin
On 7/26/07, David Miller [EMAIL PROTECTED] wrote: From: Shannon Nelson [EMAIL PROTECTED] Date: Tue, 24 Jul 2007 17:36:06 -0700 (repost - original eaten by vger?) Al Viro pointed out that dma_memcpy_to_kernel_iovec() really was unreachable and thus unused. The code originally was there

Re: [PATCH RFC]: napi_struct V4

2007-07-30 Thread Roland Dreier
If you have a means in the device (like tg3, bnx2, e1000, and a score of others do) to force the device to trigger a HW interrupt, that's what you do if you detect that events are pending after re-enabling interrupt in the -poll() handler. It is possible to trigger an interrupt for IPoIB

[PATCH 1/3] ehea: Fix workqueue handling

2007-07-30 Thread Thomas Klein
Fix: Workqueue ehea_driver_wq was not destroyed Signed-off-by: Thomas Klein [EMAIL PROTECTED] --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h index

[PATCH 2/3] ehea: Simplify resource usage check

2007-07-30 Thread Thomas Klein
Use shorter method to determine whether adapter has configured ports Signed-off-by: Thomas Klein [EMAIL PROTECTED] --- drivers/net/ehea/ehea_main.c | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c

[PATCH 3/3] ehea: Eliminated some compiler warnings

2007-07-30 Thread Thomas Klein
Fixed wrongly casted pointers Signed-off-by: Thomas Klein [EMAIL PROTECTED] --- drivers/net/ehea/ehea_main.c | 25 ++--- 1 files changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c index 36ca322..9756211

[PATCH 1/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Jan-Bernd Themann
Generic Large Receive Offload for TCP traffic Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- include/linux/inet_lro.h | 173 ++ net/ipv4/inet_lro.c | 590 ++ 2 files changed, 763 insertions(+), 0 deletions(-) create mode

[PATCH 2/4][RFC] lro: Kconfig and Makefile

2007-07-30 Thread Jan-Bernd Themann
Kconfig and Makefile for LRO Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- net/ipv4/Kconfig |8 net/ipv4/Makefile |1 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig index fb79097..d894f61 100644 ---

[PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Jan-Bernd Themann
Hi, this patch set contains the latest generic LRO code, a Kconfig / Makefile and an eHEA patch demonstrating how the aggregate SKB interface has to to be used. Drew, could you provide a patch for the myri10ge driver to show how the receive in page interface works? Please check the Kconfig /

[PATCH 3/4][RFC] ehea: LRO support

2007-07-30 Thread Jan-Bernd Themann
Added LRO support using the SKB aggregate interface Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- drivers/net/ehea/ehea.h |9 - drivers/net/ehea/ehea_ethtool.c | 15 +++ drivers/net/ehea/ehea_main.c| 82 +++--- 3 files

[PATCH 4/4][RFC] ehea: Kconfig

2007-07-30 Thread Jan-Bernd Themann
Kconfig changes for LRO Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- drivers/net/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index f8a602c..fec4004 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig

Re: source interface ping bug ?

2007-07-30 Thread Ben Greear
nano bug wrote: Can someone have a look a this and tell if it's kernel related or if I posted this in the wrong place ? Thanks. Last I checked, ping did not do an SO_BINDTODEVICE even if you did -i ethX. I think it just looked up the IP for that port and treated it as -i a.b.c.d. That said,

[PATCH] [NET]: fix multicast list when cloning sockets

2007-07-30 Thread Flavio Leitner
The sock_copy() function uses memcpy() to clone the socket including the struct ip_mc_socklist *mc_list pointer. The ip_mc_drop_socket() function is called when socket is closed to free these objects leaving the other sockets cloned from the same master socket with invalid pointers. This patch

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Jeff Garzik
Seems pretty good to me, save for one minor detail: patches #1/#2 should be combined together for greater git-bisect happiness. Ditto for patches #3/#4. Largely harmless in this case, but keeps the git history pollution to a minimum. Caveat reviewer: I'm not an expert of net/ipv4/* code,

Re: source interface ping bug ?

2007-07-30 Thread Patrick McHardy
nano bug wrote: [...] using source interface : [EMAIL PROTECTED]:~/iputils# ./ping -I eth2 87.248.113.14 PING 87.248.113.14 (87.248.113.14) from 86.106.19.75 eth2: 56(84) bytes of data. From 86.106.19.75 icmp_seq=1 Destination Host Unreachable [EMAIL PROTECTED]:~# tcpdump -i eth2 -vvv -n

Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile

2007-07-30 Thread Stephen Hemminger
On Mon, 30 Jul 2007 17:24:45 +0200 Jan-Bernd Themann [EMAIL PROTECTED] wrote: Kconfig and Makefile for LRO Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- net/ipv4/Kconfig |8 net/ipv4/Makefile |1 + 2 files changed, 9 insertions(+), 0 deletions(-) diff

Re: [2/3] 2.6.23-rc1: known regressions v3

2007-07-30 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc1. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk6 Andi Kleen

Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile

2007-07-30 Thread Jeff Garzik
Stephen Hemminger wrote: Why make this a user selectable option at all? Unless you want to deal with out of tree drivers (not my problem), it should be hidden to avoid having to explain an support it. In this case it's an optional library kernel module. That seems to be a common setup for

Re: [PATCH 3/4][RFC] ehea: LRO support

2007-07-30 Thread Kok, Auke
Jan-Bernd Themann wrote: Added LRO support using the SKB aggregate interface Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- drivers/net/ehea/ehea.h |9 - drivers/net/ehea/ehea_ethtool.c | 15 +++ drivers/net/ehea/ehea_main.c| 82

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Linas Vepstas
On Mon, Jul 30, 2007 at 05:24:33PM +0200, Jan-Bernd Themann wrote: Changes to http://www.spinics.net/lists/netdev/msg36912.html 1) A new field called features has been added to the net_lro_mgr struct. It is set by the driver to indicate: - LRO_F_NAPI:Use NAPI / netif_rx

Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile

2007-07-30 Thread Kok, Auke
Jeff Garzik wrote: Stephen Hemminger wrote: Why make this a user selectable option at all? Unless you want to deal with out of tree drivers (not my problem), it should be hidden to avoid having to explain an support it. In this case it's an optional library kernel module. That seems to be a

Re: [RFC] fib_trie: whitespace cleanup

2007-07-30 Thread Paul E. McKenney
On Thu, Jul 26, 2007 at 09:56:30PM -0700, Andrew Morton wrote: On Thu, 26 Jul 2007 08:44:21 -0700 Paul E. McKenney [EMAIL PROTECTED] wrote: On Thu, Jul 26, 2007 at 11:49:42AM +0100, Stephen Hemminger wrote: Whitespace cleanup run code through lindent then cleanup results. Applys after

[PATCH net-2.6 0/2] [TCP]: Fix bidirectional brokeness

2007-07-30 Thread Ilpo Järvinen
Hi Dave, While testing frto with bidirection TCP a while (months) ago, I encountered time-seq graphs which made absolutely no sense as if recoveries only completed after RTO. As a result, I noticed that rate-halving has problem when a flow is bidirection but testing the patch has been on my

[PATCH net-2.6 1/2] [TCP]: Fix ratehalving with bidirectional flows

2007-07-30 Thread Ilpo Järvinen
Actually, the ratehalving seems to work too well, as cwnd is reduced on every second ACK even though the packets in flight remains unchanged. Recoveries in a bidirectional flows suffer quite badly because of this, both NewReno and SACK are affected. After this patch, rate halving is performed

[PATCH net-2.6 2/2] [TCP]: Bidir flow must not disregard SACK blocks for lost marking

2007-07-30 Thread Ilpo Järvinen
It's possible that new SACK blocks that should trigger new LOST markings arrive with new data (which previously made is_dupack false). In addition, I think this fixes a case where we get a cumulative ACK with enough SACK blocks to trigger the fast recovery (is_dupack would be false there too).

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Andrew Gallatin
Here is a quick reply before something more official can be written up: Linas Vepstas wrote: -- what is LRO? Large Receive Offload -- Basic principles of operation? LRO is analogous to a receive side version of TSO. The NIC (or driver) merges several consecutive segments from the same

Re: [PATCH] NET_DMA: remove unused dma_memcpy_to_kernel_iovec

2007-07-30 Thread Christoph Hellwig
On Mon, Jul 30, 2007 at 08:09:53PM +0530, pravin wrote: comments? please avoid using plain sendmsg/recvmsg from kernelspace. Adding these segment checks is more than a bad hack and not something that should clutter up fasthpathes. Add to that problems with kthreads vs blocking recvmsg and you

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2007-07-30 Thread Steve . Glendinning
Hi Peter, What's the problem with Dustin's driver? It seems to work fine here with a lan9117. Why not just add lan921x support to the existing driver? I have heard Dustin's driver works very well on PXA, but on others it doesn't even compile (hence why it depends on ARCH_PXA). Dustin's

Re: Linksys Gigabit USB2.0 adapter (asix) regression

2007-07-30 Thread David Hollis
On Mon, 2007-07-30 at 11:27 +0200, Erik Slagter wrote: They are either garbled are they are not passed on the wire. The transmitted packets are shown by tshark, but a tshark run on the other end of the line does not show them. Platform is indeed x86, to be precise: fedora 7, kernel

[TULIP] Need new maintainer

2007-07-30 Thread Valerie Henson
The Tulip network driver needs a new maintainer! I no longer have time to maintain the Tulip network driver and I'm stepping down. Jeff Garzik would be happy to get volunteers. The only current major outstanding patch I know of is Grant's shutdown race patch, which was incorrectly dropped as

[PATCH] tulip: Remove tulip maintainer

2007-07-30 Thread Valerie Henson
Remove Val Henson as tulip maintainer and let her roam free, FREE! Signed-off-by: Val Henson [EMAIL PROTECTED] --- linux-2.6.orig/MAINTAINERS +++ linux-2.6/MAINTAINERS @@ -3569,11 +3569,9 @@ W: http://www.auk.cx/tms380tr/ S: Maintained TULIP NETWORK DRIVER -P: Valerie Henson

Re: [PATCH] possible deadlock in tulip driver

2007-07-30 Thread Valerie Henson
(No longer maintainer, btw.) What situation have you tested this under? Thanks, -VAL On Tue, Jul 24, 2007 at 11:49:08AM +0400, Denis V. Lunev wrote: Calling flush_scheduled_work() may deadlock if called under rtnl_lock (from dev-stop) as linkwatch_event() may be on the workqueue and it will

Re: [TULIP] Need new maintainer

2007-07-30 Thread Kyle McMartin
On Mon, Jul 30, 2007 at 01:04:13PM -0600, Valerie Henson wrote: The Tulip network driver needs a new maintainer! I no longer have time to maintain the Tulip network driver and I'm stepping down. Jeff Garzik would be happy to get volunteers. Since I already take care of a major consumer of

Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net/usb/pegasus.c

2007-07-30 Thread Jeff Garzik
Micah Gruber wrote: This patch fixes a potential null dereference bug where we dereference pegasus before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber [EMAIL PROTECTED] --- --- a/drivers/net/usb/pegasus.c +++

Re: [PATCH] gfar: Fix modpost warning

2007-07-30 Thread Jeff Garzik
Kumar Gala wrote: Fix the following modpost warning: WARNING: vmlinux.o(.init.text+0x1aa6c): Section mismatch: reference to .exit.text:gfar_mdio_exit (between 'gfar_init' and 'gfar_mdio_init') Signed-off-by: Kumar Gala [EMAIL PROTECTED] --- drivers/net/gianfar_mii.c |2 +-

Re: [PATCH][netdrvr] lib8390: comment on locking by Alan Cox Re: 2.6.20-2.6.21 - networking dies after random time

2007-07-30 Thread Jeff Garzik
Jarek Poplawski wrote: Hi, Very below is my patch proposal with a comment, which in my opinion is precious enough to save it for future help in reading and understanding the code. I hope Alan will not blame me I've not asked for his permission before sending, and he would ack this patch as it

Re: [PATCH] tulip: Remove tulip maintainer

2007-07-30 Thread Jeff Garzik
Valerie Henson wrote: Remove Val Henson as tulip maintainer and let her roam free, FREE! Signed-off-by: Val Henson [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] forcedeth: mac address correct

2007-07-30 Thread Jeff Garzik
Ayaz Abdulla wrote: Resending: In older chipsets, the mac address was stored in reversed order. However, in newer chipsets, the mac address is in correct order. This patch takes those newer chipsets into account and does not rely on a special bit setup by BIOS'. Signed-Off-By: Ayaz Abdulla

Re: [RESEND 1/2] netxen: re-init station address after h/w init

2007-07-30 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: This is a workaround for firmware bug with 2nd port of multiport adapter, where MAC address is reset. Driver just needs to overwrite it with the value read from PROM. Signed-off-by: Dhananjay Phadke [EMAIL PROTECTED] applied 1-2 - To unsubscribe from this list: send

Re: [PATCH] netxen: drop redudant spinlock

2007-07-30 Thread Jeff Garzik
Dhananjay Phadke wrote: Some leftover code that makes use of adapter-lock in tx_timeout function, which resets the interface under this lock. In close() when the workqueue is flushed, prints the warning about sleeping with interrupts disabled (when spinlock debug is enabled). The lock was

Re: [PATCH 2.6.22 1/3]S2io: Mask spurious interrupts

2007-07-30 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Mask single and double bit ETQ ecc errors to inhibit spurious interrupts. (Resending; Removed HTML sections in the patch) Signed-off-by: Santosh Rastapur [EMAIL PROTECTED] applied 1-3 - To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in mace_interrupt() in drivers/net/pcmcia/nmclan_cs.c

2007-07-30 Thread Jeff Garzik
Micah Gruber wrote: This patch fixes a potential null dereference bug where we dereference DEV before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber [EMAIL PROTECTED] applied (git-am worked!) - To unsubscribe from this list: send

Re: [PATCH 2.6.22 1/4]S2IO: Removing 3 buffer mode support from the driver

2007-07-30 Thread Jeff Garzik
Veena Parat wrote: - Removed 3 buffer mode support from driver - unused feature - Incorporated Jeff Garzik's comments on elimination of inline typecasting - Code cleanup : Removed a few extra spaces Signed-off-by: Veena Parat [EMAIL PROTECTED] applied 1-4 - To unsubscribe from this list:

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Stephen Hemminger
Could someone add this to: http://linux-net.osdl.org Wiki? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization

2007-07-30 Thread Jeff Garzik
Denis Cheng wrote: Cc: [EMAIL PROTECTED] Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [NET] IOC3: Switch hw checksumming to ethtool configurable.

2007-07-30 Thread Jeff Garzik
Ralf Baechle wrote: Signed-off-by: Ralf Baechle [EMAIL PROTECTED] applied to #upstream (2.6.24) I've previously sent out this patch a long time ago. At that time I was told NETIF_F_IP_CSUM wouldn't make any sense without NETIF_F_SG. IOC3's S/G abilities are very limited; it can do upto

Re: [PATCH 2.6.23 1/2] Make the iw_cxgb3 module parameters writable.

2007-07-30 Thread Roland Dreier
ugh, missed these before my last merge... anyway: why do we want to parameters writable? a good changelog tells me what, why and how, and this changelog just covered the what. Also, I assume you've checked that it's OK for these variables to change at any time? - To unsubscribe from this list:

Re: [PATCH V3 7/7] net/bonding: Delay sending of gratuitous ARP to avoid failure

2007-07-30 Thread Jay Vosburgh
Moni Shoua [EMAIL PROTECTED] wrote: Delay sending a gratuitous_arp when LINK_STATE_LINKWATCH_PENDING bit in dev-state field is on. This improves the chances for the arp packet to be transmitted. Under what circumstances were you seeing problems that delaying the gratuitous ARP until

Re: Proposed interface for per-packet mesh-ttl

2007-07-30 Thread Javier Cardona
Hi Stephen, On 7/27/07, Stephen Hemminger [EMAIL PROTECTED] wrote: In this case perhaps you can have a table that maps skb-priority to mesh ttl? priorty can already by handled by existing setsockopt calls, and modified by netfilter and QoS managements. Thanks for the feedback. IMHO

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Andrew Gallatin
Jan-Bernd Themann wrote: Hi, this patch set contains the latest generic LRO code, a Kconfig / Makefile and an eHEA patch demonstrating how the aggregate SKB interface has to to be used. Drew, could you provide a patch for the myri10ge driver to show how the receive in page interface works?

RE: [PATCH] NET_DMA: remove unused dma_memcpy_to_kernel_iovec

2007-07-30 Thread Waskiewicz Jr, Peter P
On 7/26/07, David Miller [EMAIL PROTECTED] wrote: From: Shannon Nelson [EMAIL PROTECTED] Date: Tue, 24 Jul 2007 17:36:06 -0700 (repost - original eaten by vger?) Al Viro pointed out that dma_memcpy_to_kernel_iovec() really was unreachable and thus unused. The code originally

Re: Proposed interface for per-packet mesh-ttl

2007-07-30 Thread Stephen Hemminger
On Mon, 30 Jul 2007 13:37:20 -0700 Javier Cardona [EMAIL PROTECTED] wrote: Hi Stephen, On 7/27/07, Stephen Hemminger [EMAIL PROTECTED] wrote: In this case perhaps you can have a table that maps skb-priority to mesh ttl? priorty can already by handled by existing setsockopt calls, and

Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver

2007-07-30 Thread Roland Dreier
1. When bonding enslaves an IPoIB device the bonding neighbor holds a reference to a cleanup function in the IPoIB drives. This makes it unsafe to unload the IPoIB module if there are bonding neighbors in the air. So, to avoid this race one must unload bonding before unloading IPoIB.

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Mon, 30 Jul 2007 12:17:58 -0400 David, thoughts on merging? I'm not We could stick this into your tree or mine. Whether yours or mine, I would like to keep the driver and net-core patches together in the same git tree. No objections and I'll stick

Re: [git patches] net driver fixes

2007-07-30 Thread Satyam Sharma
On Mon, 30 Jul 2007, Jeff Garzik wrote: true, we should just remove the dev==NULL check Patch below: [PATCH] nmclan_cs: Remove bogus (dev==NULL) check in mace_interrupt() The (dev == NULL) check in drivers/net/pcmcia/nmclan_cs.c:mace_interrupt() handler is always false, so let's remove it.

Re: [PATCH RFC]: napi_struct V4

2007-07-30 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 30 Jul 2007 08:04:24 -0700 IPoIB can cope but it really seems like an unfortunate feature of these changes that we can't do something like what we have today, which imposes no overhead unless an event actually lands in the race window. It is

Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-30 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Wed, 18 Jul 2007 16:21:00 -0700 On Wed, 2007-07-18 at 15:49 -0700, David Miller wrote: From: Joe Perches [EMAIL PROTECTED] Date: Wed, 18 Jul 2007 15:14:13 -0700 -#define VERSION pktgen v2.68: Packet Generator for packet performance

Re: [IPVS]: Use skb_forward_csum

2007-07-30 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 26 Jul 2007 16:59:39 +0800 [IPVS]: Use skb_forward_csum As a path that forwards packets, IPVS should be using skb_forward_csum instead of directly setting ip_summed to CHECKSUM_NONE. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Patch applied,

Re: [PATCH 1/6] [NET]: Call uninit if necessary in register_netdevice

2007-07-30 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 26 Jul 2007 17:09:08 +0800 [NET]: Call uninit if necessary in register_netdevice This patch makes register_netdevice call dev-uninit if the regsitration fails after dev-init has completed successfully. Very few drivers use the init/uninit calls

Re: [PATCH 2/6] [NET]: Take dev_base_lock when moving device name hash list entry

2007-07-30 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 26 Jul 2007 17:09:30 +0800 [NET]: Take dev_base_lock when moving device name hash list entry When we added name-based hashing the dev_base_lock was designated as the lock to take when changing the name hash list. Unfortunately, because it was a

Re: [PATCH 3/6] [NET] loopback: Panic if registration fails

2007-07-30 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 26 Jul 2007 17:09:33 +0800 [NET] loopback: Panic if registration fails Because IPv4 and IPv6 both depend on the presence of the loopback device to function, failure in registration the loopback device should be fatal. Signed-off-by: Herbert Xu

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Mon, 30 Jul 2007 12:17:58 -0400 David, thoughts on merging? I'm not We could stick this into your tree or mine. Whether yours or mine, I would like to keep the driver and net-core patches together in the same git tree. No

Re: [PATCH 4/6] [NET]: Allow netdev REGISTER/CHANGENAME events to fail

2007-07-30 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 26 Jul 2007 17:09:36 +0800 [NET]: Allow netdev REGISTER/CHANGENAME events to fail This patch adds code to allow errors to be passed up from event handlers of NETDEV_REGISTER and NETDEV_CHANGENAME. It also adds the

Re: [PATCH 5/6] [IPV4/IPV6]: Fail registration if inet device construction fails

2007-07-30 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 26 Jul 2007 17:09:38 +0800 [IPV4/IPV6]: Fail registration if inet device construction fails Now that netdev notifications can fail, we can use this to signal errors during registration for IPv4/IPv6. In particular, if we fail to allocate memory

Re: [PATCH 6/6] [IPV6]: Remove circular dependency on if_inet6.h

2007-07-30 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 26 Jul 2007 17:09:40 +0800 [IPV6]: Remove circular dependency on if_inet6.h net/if_inet6.h includes linux/ipv6.h which also tries to include net/if_inet6.h. Since the latter only needs it for forward declarations, we can fix this by adding the

Re: [PATCH v3 -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability

2007-07-30 Thread Andrew Morton
On Mon, 30 Jul 2007 08:17:41 +0530 Satyam Sharma [EMAIL PROTECTED] wrote: [0/9] netconsole: Multiple targets and dynamic reconfigurability This is v3 of the patchset That all looks pretty reasonable, thanks. Are we all comfortable with the attributions? As I have it now, everything will go

Re: [PATCH v3 -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-30 Thread Andrew Morton
On Mon, 30 Jul 2007 08:19:10 +0530 Satyam Sharma [EMAIL PROTECTED] wrote: +/* + * Wrapper over simple_strtol (base 10) with sanity and range checking. + * We return (signed) long only because we may want to return errors. + * Do not use this to convert numbers that are allowed to be negative.

Re: [FIX] NET: Fix sch_api and sch_prio to properly set and detect the root qdisc

2007-07-30 Thread David Miller
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Fri, 27 Jul 2007 09:22:11 -0700 Are these queued for 2.6.24, or are they going to make it into 2.6.23? I know you're busy with patches and NAPI, but I was curious. Thanks! I've applied both fixes and will push them into 2.6.23 - To

RE: [FIX] NET: Fix sch_api and sch_prio to properly set and detect the root qdisc

2007-07-30 Thread Waskiewicz Jr, Peter P
-Original Message- From: David Miller [mailto:[EMAIL PROTECTED] Sent: Monday, July 30, 2007 5:14 PM To: Waskiewicz Jr, Peter P Cc: netdev@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [FIX] NET: Fix sch_api and sch_prio to properly set and detect the root qdisc From:

Re: [PATCH] IPv6: ipv6_addr_type() doesn't know about RFC4193 addresses

2007-07-30 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Thu, 26 Jul 2007 13:34:52 -0500 (CDT) In article [EMAIL PROTECTED] (at Wed, 25 Jul 2007 19:49:09 -0400), Dave Johnson [EMAIL PROTECTED] says: ipv6_addr_type() doesn't check for 'Unique Local IPv6 Unicast Addresses' (RFC4193) and

Re: [PATCH v3 -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability

2007-07-30 Thread Satyam Sharma
On Mon, 30 Jul 2007, Andrew Morton wrote: On Mon, 30 Jul 2007 08:17:41 +0530 Satyam Sharma [EMAIL PROTECTED] wrote: [0/9] netconsole: Multiple targets and dynamic reconfigurability This is v3 of the patchset That all looks pretty reasonable, thanks. Are we all comfortable with

Re: [PATCH RFC]: napi_struct V4

2007-07-30 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Thu, 26 Jul 2007 14:38:09 -0700 If the driver wants a simple solution, it can do what you did in the patch: wrap the tx cleanup code with netif_tx_lock() and netif_tx_unlock(). If a NAPI driver wants to be more clever, it can do something such as

Re: [PATCH v3 -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-30 Thread Satyam Sharma
On Mon, 30 Jul 2007, Andrew Morton wrote: On Mon, 30 Jul 2007 08:19:10 +0530 Satyam Sharma [EMAIL PROTECTED] wrote: +/* + * Wrapper over simple_strtol (base 10) with sanity and range checking. + * We return (signed) long only because we may want to return errors. + * Do not use this

Re: [RESEND][PATCH 1/3] PPPoE: improved hashing routine

2007-07-30 Thread David Miller
From: Florian Zumbiehl [EMAIL PROTECTED] Date: Sun, 29 Jul 2007 08:04:23 +0200 Hi, I'm not sure whether this is really worth it, but it looked so extremely inefficient that I couldn't resist - so let's hope providers will keep PPPoE around for a while, at least until terabit dsl ;-) The

Re: [RESEND][PATCH 2/3] PPPoX/E: return ENOTTY on unknown ioctl requests

2007-07-30 Thread David Miller
From: Florian Zumbiehl [EMAIL PROTECTED] Date: Sun, 29 Jul 2007 08:04:36 +0200 here another patch for the PPPoX/E code that makes sure that ENOTTY is returned for unknown ioctl requests rather than 0 (and removes another unneeded initializer which I didn't bother creating a separate patch

Re: [RESEND][PATCH 3/3] PPPoE: move lock_sock() in pppoe_sendmsg() to the right location

2007-07-30 Thread David Miller
From: Florian Zumbiehl [EMAIL PROTECTED] Date: Sun, 29 Jul 2007 08:04:46 +0200 and the last one for now: Acquire the sock lock in pppoe_sendmsg() before accessing the sock - and in particular avoid releasing the lock even though it hasn't been acquired. Signed-off-by: Florian Zumbiehl

RFC: on [ab]use of skb-cb by VLAN code

2007-07-30 Thread jamal
I was going to forget this, but its been playing in the back of my head and wont go away Matt Carlson recently (while fixing the tg3 driver in my batching patches) pointed to me that skb-cb[] was being used to pass around vlan data. This seems like a bad use since there can be a lot of

Re: [2.6 patch] make pktgen.c:get_ipsec_sa() static and non-inline

2007-07-30 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Sun, 29 Jul 2007 16:58:40 +0200 Non-static inline code usually doesn't makes sense. In this case making is static and non-inline is the correct solution. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied, thanks Adrian. - To unsubscribe from

Re: [2.6 patch] make nf_ct_ipv6_skip_exthdr() static

2007-07-30 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Sun, 29 Jul 2007 16:58:46 +0200 nf_ct_ipv6_skip_exthdr() can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

  1   2   >