Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-14 Thread Herbert Xu
Chris Snook <[EMAIL PROTECTED]> wrote: > > Because atomic operations are generally used for synchronization, which > requires > volatile behavior. Most such codepaths currently use an inefficient > barrier(). > Some forget to and we get bugs, because people assume that atomic_read() > actua

Re: Realtek r8168 slow outbound transfer - potential fix/workaround

2007-08-14 Thread Bruce Cole
[EMAIL PROTECTED] wrote: Bruce, I settled on using ndelay(10) rather than udelay(25) in the end.. it's probably a bit safer & less likely to cause problems with higher throughputs. Yes, I saw that you later recommended the change but opted to try it the way you tested first. When I was di

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-08-14 Thread Andy Gospodarek
On 8/14/07, Mike Snitzer <[EMAIL PROTECTED]> wrote: > Andy, > > Is there an updated version of this patch? > > Please advise, thanks. > > Mike, There is a version that Jay and I have been testing and if you would like to help out, we could probably send you some patches. Jay has split the entire

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-08-14 Thread Mike Snitzer
Andy, Is there an updated version of this patch? Please advise, thanks. On 1/10/07, Andy Gospodarek <[EMAIL PROTECTED]> wrote: > On Tue, Jan 09, 2007 at 03:09:35PM -0800, Stephen Hemminger wrote: > > On Tue, 9 Jan 2007 17:59:01 -0500 > > Andy Gospodarek <[EMAIL PROTECTED]> wrote: > > > > > > >

Re: Please pull 'fixes-davem' branch of wireless-2.6

2007-08-14 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Tue, 14 Aug 2007 20:32:34 -0400 > These are a few more items intended for 2.6.23. ... > The following changes since commit 39d3520c92cf7a28c07229ca00cc35a1e8026c77: > Linus Torvalds (1): > Linux 2.6.23-rc3 > > are available in the git

Re: [RFC: -mm patch] improve the SSB dependencies

2007-08-14 Thread John W. Linville
On Mon, Aug 13, 2007 at 12:44:02AM +0200, Adrian Bunk wrote: > On Sun, Aug 12, 2007 at 02:00:26PM +0200, Michael Buesch wrote: > > Ok, I'll give it a try, with small modifications. > > Thanks. > > > On Sunday 12 August 2007, Adrian Bunk wrote: > > > Additional changes in this patch: > > > - small

Please pull 'upstream-davem' branch of wireless-2.6

2007-08-14 Thread John W. Linville
More items intended for 2.6.24, based-off the preceding fixes-davem request. Individual patches available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-davem Thanks! John --- The following changes since commit b9bf1e60a294fc7795d5198f94a917290e528

Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-08-14 Thread John W. Linville
A few items intended for 2.6.24. Individual patches here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-jgarzik/ Thanks! John --- The following changes since commit 39d3520c92cf7a28c07229ca00cc35a1e8026c77: Linus Torvalds (1): Linux 2.6.23-rc3

Please pull 'fixes-davem' branch of wireless-2.6

2007-08-14 Thread John W. Linville
These are a few more items intended for 2.6.23. Individual patches available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-davem Thanks! John --- The following changes since commit 39d3520c92cf7a28c07229ca00cc35a1e8026c77: Linus Torvalds (1):

Re: [2.6 patch] net/8021q/vlanproc.c: fix check-after-use

2007-08-14 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Tue, 14 Aug 2007 23:22:44 +0200 > The Coverity checker spotted that we'd have already oops'ed if "vlandev" > was NULL. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Fair enough, applied, thanks Adrian. - To unsubscribe from this list: send the lin

Re: [2.6 patch] unexport dev_ethtool

2007-08-14 Thread David Miller
From: Matthew Wilcox <[EMAIL PROTECTED]> Date: Tue, 14 Aug 2007 15:23:26 -0600 > On Tue, Aug 14, 2007 at 11:22:03PM +0200, Adrian Bunk wrote: > > This patch removes the no longer used EXPORT_SYMBOL(dev_ethtool). > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > Acked-by: Matthew Wilcox <[E

Re: [PATCH] IOAT: Fix ioatdma descriptor cache miss

2007-08-14 Thread David Miller
From: "Nelson, Shannon" <[EMAIL PROTECTED]> Date: Tue, 14 Aug 2007 14:20:02 -0700 > The layout for struct ioat_desc_sw is non-optimal and causes an extra > cache hit for every descriptor processed. By tightening up the struct > layout and removing one item, we pull in the fields that get used in

Re: [PATCH] ax25: don't free pointers to statically allocated data

2007-08-14 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 14 Aug 2007 23:30:38 +0400 > commit 8d5cf596d10d740b69b5f4bbdb54b85abf75810d started to add statically > allocated ax25_protocol's to list. However kfree() was still in place waiting > for unsuspecting ones on module removal. > > Steps to repro

Re: [PATCH] econet: remove econet_packet_type on unload

2007-08-14 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Wed, 15 Aug 2007 01:25:53 +0400 > Steps to reproduce: > > modprobe econet > rmmod econet > modprobe econet > > Unable to handle kernel paging request at 8870a098 RIP: > [] dev_add_pack+0x48/0x90 ... > Signed-off-by: Ale

Re: [PATCH 9/13] cxgb3 - Update internal memory management

2007-08-14 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: > From: Divy Le Ray <[EMAIL PROTECTED]> > > Set PM1 internal memory to round robin mode > > Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> why? For multiport adapters, it balances access to this internal memory. Divy - To unsubscribe from this list: send

Re: [PATCH 5/13] cxgb3 - Expose HW memory page info

2007-08-14 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Let the RDMA driver get HW page info to work around HW issues. Assign explicit enum values. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> "HW issues" -- you need to go into far more detail, when adding a new interf

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-14 Thread Paul E. McKenney
On Wed, Aug 15, 2007 at 04:38:54AM +0530, Satyam Sharma wrote: > > > On Tue, 14 Aug 2007, Christoph Lameter wrote: > > > On Thu, 9 Aug 2007, Chris Snook wrote: > > > > > This patchset makes the behavior of atomic_read uniform by removing the > > > volatile keyword from all atomic_t and atomic64

Re: [PATCH 4/13] cxgb3 - use immediate data for offload Tx

2007-08-14 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: > From: Divy Le Ray <[EMAIL PROTECTED]> > > Send small TX_DATA work requests as immediate data even when > there are fragments. > > Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> > --- > > drivers/net/cxgb3/sge.c | 17 +++-- > 1 files changed,

Re: [PATCH 2/13] cxgb3 - Update rx coalescing length

2007-08-14 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: > From: Divy Le Ray <[EMAIL PROTECTED]> > > Set max Rx coalescing length to 12288 > > Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> > --- > > drivers/net/cxgb3/common.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-14 Thread Christoph Lameter
On Tue, 14 Aug 2007, Chris Snook wrote: > Because atomic operations are generally used for synchronization, which > requires volatile behavior. Most such codepaths currently use an inefficient > barrier(). Some forget to and we get bugs, because people assume that > atomic_read() actually reads

[PATCH] pcnet32: add suspend and resume capability

2007-08-14 Thread Don Fry
Add suspend and resume capability to the driver. Tested both to ram and to disk on x86_64 platform. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc3/drivers/net/pcnet32.c.orig 2007-08-14 13:52:24.0 -0700 +++ linux-2.6.23-rc3/drivers/net/pcnet32.c 2007-08-14 14:16:

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-14 Thread Chris Snook
Satyam Sharma wrote: On Tue, 14 Aug 2007, Christoph Lameter wrote: On Thu, 9 Aug 2007, Chris Snook wrote: This patchset makes the behavior of atomic_read uniform by removing the volatile keyword from all atomic_t and atomic64_t definitions that currently have it, and instead explicitly casts

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-14 Thread Satyam Sharma
On Tue, 14 Aug 2007, Christoph Lameter wrote: > On Thu, 9 Aug 2007, Chris Snook wrote: > > > This patchset makes the behavior of atomic_read uniform by removing the > > volatile keyword from all atomic_t and atomic64_t definitions that currently > > have it, and instead explicitly casts the var

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-14 Thread Christoph Lameter
On Tue, 14 Aug 2007, Chris Snook wrote: > But barriers force a flush of *everything* in scope, which we generally don't > want. On the other hand, we pretty much always want to flush atomic_* > operations. One way or another, we should be restricting the volatile > behavior to the thing that nee

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-14 Thread Chris Snook
Christoph Lameter wrote: On Thu, 9 Aug 2007, Chris Snook wrote: This patchset makes the behavior of atomic_read uniform by removing the volatile keyword from all atomic_t and atomic64_t definitions that currently have it, and instead explicitly casts the variable as volatile in atomic_read().

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-14 Thread Paul E. McKenney
On Wed, Aug 15, 2007 at 12:01:54AM +0200, Arnd Bergmann wrote: > On Tuesday 14 August 2007, Paul E. McKenney wrote: > > > #define order(x) asm volatile("" : "+m" (x)) > > > > There was something very similar discussed earlier in this thread, > > with quite a bit of debate as to exactly what the "m

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-14 Thread Christoph Lameter
On Thu, 9 Aug 2007, Chris Snook wrote: > This patchset makes the behavior of atomic_read uniform by removing the > volatile keyword from all atomic_t and atomic64_t definitions that currently > have it, and instead explicitly casts the variable as volatile in > atomic_read(). This leaves little r

Re: [2.6 patch] remove Documentation/networking/net-modules.txt

2007-08-14 Thread Adrian Bunk
On Tue, Aug 14, 2007 at 06:04:01PM -0400, Jeff Garzik wrote: > Adrian Bunk wrote: >> According to git, the only one who touched this file during the last >> 5 years was me when removing drivers... >> modinfo offers less ancient information. >> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> >> --- >

Re: [3/4] 2.6.23-rc3: known regressions

2007-08-14 Thread Francois Romieu
Michal Piotrowski <[EMAIL PROTECTED]> : [...] > Networking > > Subject : NETDEV WATCHDOG: eth0: transmit timed out > References : http://lkml.org/lkml/2007/8/13/737 > Last known good : ? > Submitter : Karl Meyer <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By : ?

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-14 Thread Arnd Bergmann
On Tuesday 14 August 2007, Paul E. McKenney wrote: > > #define order(x) asm volatile("" : "+m" (x)) > > There was something very similar discussed earlier in this thread, > with quite a bit of debate as to exactly what the "m" flag should > look like.  I suggested something similar named ACCESS_ON

Re: [2.6 patch] remove Documentation/networking/net-modules.txt

2007-08-14 Thread Jeff Garzik
Adrian Bunk wrote: According to git, the only one who touched this file during the last 5 years was me when removing drivers... modinfo offers less ancient information. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 23 Jul 2007 Documentation/networking/00-

[2.6 patch] remove Documentation/networking/net-modules.txt

2007-08-14 Thread Adrian Bunk
According to git, the only one who touched this file during the last 5 years was me when removing drivers... modinfo offers less ancient information. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 23 Jul 2007 Documentation/networking/00-INDEX|2

[PATCH] econet: remove econet_packet_type on unload

2007-08-14 Thread Alexey Dobriyan
Steps to reproduce: modprobe econet rmmod econet modprobe econet Unable to handle kernel paging request at 8870a098 RIP: [] dev_add_pack+0x48/0x90 PGD 203067 PUD 207063 PMD 7817f067 PTE 0 Oops: 0002 [1] PREEMPT SMP CPU 1 Modules linked in: econet [mny] Pid:

Re: [2.6 patch] unexport dev_ethtool

2007-08-14 Thread Matthew Wilcox
On Tue, Aug 14, 2007 at 11:22:03PM +0200, Adrian Bunk wrote: > This patch removes the no longer used EXPORT_SYMBOL(dev_ethtool). > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Matthew Wilcox <[EMAIL PROTECTED]> -- "Bill, look, we understand that you're interested in selling us this

[2.6 patch] net/8021q/vlanproc.c: fix check-after-use

2007-08-14 Thread Adrian Bunk
The Coverity checker spotted that we'd have already oops'ed if "vlandev" was NULL. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc1-mm2/net/8021q/vlanproc.c.old 2007-08-08 06:22:40.0 +0200 +++ linux-2.6.23-rc1-mm2/net/8021q/vlanproc.c 2007-08-08 06:23:13.00

Re: [PATCH 2/6] e1000e: remove namespace collisions with e1000

2007-08-14 Thread Kok, Auke
Rick Jones wrote: if you grep around this effort was already started using the 'e1e_' prefix. I like the shorter prefix, but your call ultimately. Either way, make sure to make the driver consistent there too. should it then be consistent with the overall driver name too? certainly calling

[2.6 patch] unexport dev_ethtool

2007-08-14 Thread Adrian Bunk
This patch removes the no longer used EXPORT_SYMBOL(dev_ethtool). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 37bcb29c1a1fefe6da0ea9e54a5cde09a82318f0 diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 2ab0a60..c5e0593 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -9

Re: Realtek r8168 slow outbound transfer - potential fix/workaround

2007-08-14 Thread Francois Romieu
Bruce Cole <[EMAIL PROTECTED]> : [...] > What's the status of this fix? It (or something more refined) seems > necessary to correct the current performance problems with this driver. An explanation or something more refined would be welcome. [...] > I can troubleshoot in more detail if that wou

[PATCH] IOAT: Fix ioatdma descriptor cache miss

2007-08-14 Thread Nelson, Shannon
(copying from linux-kernel to net-dev) The layout for struct ioat_desc_sw is non-optimal and causes an extra cache hit for every descriptor processed. By tightening up the struct layout and removing one item, we pull in the fields that get used in the speedpath and get a little better performan

Re: [patch 12/18] e1000: #if 0 two functions

2007-08-14 Thread Kok, Auke
Kok, Auke wrote: Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Adrian Bunk <[EMAIL PROTECTED]> e1000_{read,write}_pci_cfg() are no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: Auke Kok <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/ne

Re: [patch 12/18] e1000: #if 0 two functions

2007-08-14 Thread Kok, Auke
Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Adrian Bunk <[EMAIL PROTECTED]> e1000_{read,write}_pci_cfg() are no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: Auke Kok <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.h

Re: [patch 07/18] PCI-X/PCI-Express read control interfaces: use them in e1000

2007-08-14 Thread Kok, Auke
[EMAIL PROTECTED] wrote: From: "Peter Oruba" <[EMAIL PROTECTED]> These driver changes incorporate the proposed PCI-X / PCI-Express read byte count interface. Reading and setting those valuse doesn't take place "manually", instead wrapping functions are called to allow quirks for some PCI bridge

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-14 Thread Kok, Auke
Rick Jones wrote: David Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Fri, 10 Aug 2007 15:40:02 -0700 For GSO on output, is there a generic fallback for any driver that does not specifically implement GSO? Absolutely, in fact that's mainly what it's there for. I don't think ther

Re: [PATCH] bridge: sysfs locking fix.

2007-08-14 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 14 Aug 2007 14:50:52 +0100 > Forget earlier patch, it is wrong... > > The stp change code generates "sleeping function called from invalid context" > because rtnl_lock() called with BH disabled. This fixes it by not acquiring > then > droppi

Re: [PATCH] [459/2many] MAINTAINERS - SPIDERNET NETWORK DRIVER for CELL

2007-08-14 Thread Linas Vepstas
On Mon, Aug 13, 2007 at 10:07:25AM -0700, Joe Perches wrote: > On Mon, 2007-08-13 at 10:45 -0500, Linas Vepstas wrote: > > Note quite right. spider-pic is not part of spider_net. > > SPIDERNET NETWORK DRIVER for CELL > P:Linas Vepstas > M:[EMAIL PROTECTED] > L:netdev@vger.kernel.org >

[PATCH] ax25: don't free pointers to statically allocated data

2007-08-14 Thread Alexey Dobriyan
commit 8d5cf596d10d740b69b5f4bbdb54b85abf75810d started to add statically allocated ax25_protocol's to list. However kfree() was still in place waiting for unsuspecting ones on module removal. Steps to reproduce: modprobe netrom rmmod netrom P.S.: code would benefit greatly from

Re: [PATCH] [DM9000] Add support for big-endian hosts

2007-08-14 Thread Ben Dooks
On Tue, Aug 14, 2007 at 01:22:32PM +0200, Laurent Pinchart wrote: > This patch splits the receive status in 8bit wide fields and convert the > packet length from little endian to CPU byte order. Which version of the the kernel was this against, it applies with fuzz to 2.6.23-rc3: $ patch -p1 < ~/

Re: [PATCH] [DM9000] External PHY support

2007-08-14 Thread Ben Dooks
On Tue, Aug 14, 2007 at 01:29:35PM +0200, Laurent Pinchart wrote: > This patch adds a flag to the DM9000 platform data which, when set, > configures the device to use an external PHY. This patch applies with fuzz: $ patch -p1 < ~/dm9000-external-phy.patch patching file drivers/net/dm9000.c Hun

[PATCH 2/2] iproute2: sch_rr support in tc

2007-08-14 Thread PJ Waskiewicz
This patch applies on top of Patrick McHardy's RTNETLINK patches to add nested compat attributes. This is needed to maintain ABI for sch_{rr|prio} in the kernel with respect to tc. A new option, namely multiqueue, was added to sch_prio and sch_rr. This will allow a user to turn multiqueue suppor

[PATCH] iproute2: sch_rr support in tc

2007-08-14 Thread PJ Waskiewicz
Stephen, These patches are resubmissions of patches that were approved, but didn't get merged. The first patch is Patrick McHardy's nested compat attribute patch to the netlink libraries. The second patch adds multiqueue and sch_rr functionality to tc. The multiqueue features have been merged t

[PATCH 1/2] IPROUTE2: RTNETLINK nested attributes

2007-08-14 Thread PJ Waskiewicz
From: Patrick McHardy <[EMAIL PROTECTED]> This adds capability for iproute2 to send nested attributes to the kernel, while maintaining backwards compatibility. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- include/libnetlink.h |9 + lib/libnetlink.c | 46 +

Re: [PATCH] xen-netfront: Avoid deref'ing skbafter it is potentially freed.

2007-08-14 Thread Jeremy Fitzhardinge
Jesper Juhl wrote: > This moves the updating of both tx_bytes and tx_packets inside the > spinlock, but as far as I can see we only _really_ need to move the > tx_bytes update. Considering that we generally want to do as little > work as possible while holding a lock, wouldn't the following be

Re: troubles with r8169

2007-08-14 Thread Alistair John Strachan
On Sunday 12 August 2007 21:06:43 Vadim Dyadkin wrote: > Robert Hancock пишет: > > This could well be a problem with the nvidia driver as it shares the > > same IRQ. The first step would be to see if the problem still shows up > > without the nvidia binary module loaded. > > Thank for your answer.

[PATCH] b44-ssb: Powerup the bus before using the device.

2007-08-14 Thread Michael Buesch
We must turn on buspower before poking with the device Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-dev-new/drivers/net/b44.c === --- wireless-dev-new.orig/drivers/net/b44.c 2007-08-11 00:45:55.0 +02

Re: Distributed storage. Mirroring to any number of devices.

2007-08-14 Thread Evgeniy Polyakov
On Tue, Aug 14, 2007 at 07:20:49PM +0200, Jan Engelhardt ([EMAIL PROTECTED]) wrote: > >I'm pleased to announce second release of the distributed storage > >subsystem, which allows to form a storage on top of remote and local > >nodes, which in turn can be exported to another storage as a node to >

Re: [net-2.6.24] forcedeth does not compile without CONFIG_FORCEDETH_NAPI set

2007-08-14 Thread Oliver Hartkopp
Samuel Ortiz wrote: > Hi Oliver, > > On Fri, Aug 10, 2007 at 07:34:03PM +0200, Oliver Hartkopp wrote: > >> Checking some other source with the current net-2.6.24 GIT, i just >> discovered this: >> >> CC drivers/net/mii.o >> CC drivers/net/Space.o >> CC drivers/net/loopback.o

Re: Distributed storage. Mirroring to any number of devices.

2007-08-14 Thread Jan Engelhardt
On Aug 14 2007 20:29, Evgeniy Polyakov wrote: > >I'm pleased to announce second release of the distributed storage >subsystem, which allows to form a storage on top of remote and local >nodes, which in turn can be exported to another storage as a node to >form tree-like storages. I'll be quick: w

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-14 Thread Paul E. McKenney
On Tue, Aug 14, 2007 at 03:34:25PM +1000, Nick Piggin wrote: > Paul E. McKenney wrote: > >On Mon, Aug 13, 2007 at 01:15:52PM +0800, Herbert Xu wrote: > > > >>Paul E. McKenney <[EMAIL PROTECTED]> wrote: > >> > >>>On Sat, Aug 11, 2007 at 08:54:46AM +0800, Herbert Xu wrote: > >>> > Chris Snook <[E

Re: [PATCH 2/6] e1000e: remove namespace collisions with e1000

2007-08-14 Thread Rick Jones
if you grep around this effort was already started using the 'e1e_' prefix. I like the shorter prefix, but your call ultimately. Either way, make sure to make the driver consistent there too. should it then be consistent with the overall driver name too? certainly calling things e1e or e1ke

Re: [PATCH] netfilter : xt_u32 bug correction

2007-08-14 Thread Patrick McHardy
Eric Dumazet wrote: > [PATCH] netfilter : xt_u32 bug correction Applied, thanks Eric. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [396/2many] MAINTAINERS - QLOGIC QLAxxx NETWORK DRIVER

2007-08-14 Thread Ron Mercer
On Sun, Aug 12, 2007 at 11:34:33PM -0700, [EMAIL PROTECTED] wrote: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index 1fa922a..6a99fe5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3790,6 +3790,8 @@ P

Re: possible BUG while using CUPS

2007-08-14 Thread Chuck Ebbert
On 08/13/2007 11:46 AM, Udo van den Heuvel wrote: > Michal Piotrowski wrote: >> On 11/08/07, Udo van den Heuvel <[EMAIL PROTECTED]> wrote: >>> Using Cups 1.2.12 on Linux 2.6.22.1. > (...) >>> I clikc that link and hear the ping-ping of the BUG: >> This is very interesting. Can you reproduce this bu

[PATCH] bridge: sysfs locking fix.

2007-08-14 Thread Stephen Hemminger
Forget earlier patch, it is wrong... The stp change code generates "sleeping function called from invalid context" because rtnl_lock() called with BH disabled. This fixes it by not acquiring then dropping the bridge lock. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/bridge/br_s

Re: BUG: when using 'brctl stp'

2007-08-14 Thread Lennert Buytenhek
On Tue, Aug 14, 2007 at 02:11:05PM +0100, Stephen Hemminger wrote: > Bridge locking for /sys/class/net/br0/bridge/stp_enabled > was wrong. Another bug in bridge utilities makes it such that > this interface, meant it wasn't being used. The locking needs > to be removed from set_stp_state(), the

Re: BUG: when using 'brctl stp'

2007-08-14 Thread Stephen Hemminger
Bridge locking for /sys/class/net/br0/bridge/stp_enabled was wrong. Another bug in bridge utilities makes it such that this interface, meant it wasn't being used. The locking needs to be removed from set_stp_state(), the lock is already acquired down in br_stp_start()/br_stp_stop. Signed-off-by:

Re: Block device throttling [Re: Distributed storage.]

2007-08-14 Thread Daniel Phillips
On Tuesday 14 August 2007 05:46, Evgeniy Polyakov wrote: > > The throttling of the virtual device must begin in > > generic_make_request and last to ->endio. You release the throttle > > of the virtual device at the point you remap the bio to an > > underlying device, which you have convinced your

Re: Block device throttling [Re: Distributed storage.]

2007-08-14 Thread Evgeniy Polyakov
On Tue, Aug 14, 2007 at 05:32:29AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > On Tuesday 14 August 2007 04:50, Evgeniy Polyakov wrote: > > On Tue, Aug 14, 2007 at 04:35:43AM -0700, Daniel Phillips > ([EMAIL PROTECTED]) wrote: > > > On Tuesday 14 August 2007 04:30, Evgeniy Polyakov wrote:

Re: Block device throttling [Re: Distributed storage.]

2007-08-14 Thread Daniel Phillips
On Tuesday 14 August 2007 04:50, Evgeniy Polyakov wrote: > On Tue, Aug 14, 2007 at 04:35:43AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > > On Tuesday 14 August 2007 04:30, Evgeniy Polyakov wrote: > > > > And it will not solve the deadlock problem in general. (Maybe > > > > it works for y

[PATCH] netfilter : xt_u32 bug correction

2007-08-14 Thread Eric Dumazet
Hi all This applies to net-2.6 (so should be forwared to Linus for 2.6.23 inclusion ?) Sorry for the first mail without attachment. Thank you [PATCH] netfilter : xt_u32 bug correction An extraneous ";" makes xt_u32 match useless Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> diff --git a/net

[PATCH] netfilter : xt_u32 bug correction

2007-08-14 Thread Eric Dumazet
Hi all This applies to net-2.6 (so should be forwared to Linus for 2.6.23 inclusion ?) Thank you [PATCH] netfilter : xt_u32 bug correction An extraneous ";" makes xt_u32 match useless Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe ne

[PATCH] [DM9000] Add support for big-endian hosts

2007-08-14 Thread Laurent Pinchart
This patch splits the receive status in 8bit wide fields and convert the packet length from little endian to CPU byte order. Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- drivers/net/dm9000.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/ne

Re: Block device throttling [Re: Distributed storage.]

2007-08-14 Thread Evgeniy Polyakov
On Tue, Aug 14, 2007 at 04:35:43AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > On Tuesday 14 August 2007 04:30, Evgeniy Polyakov wrote: > > > And it will not solve the deadlock problem in general. (Maybe it > > > works for your virtual device, but I wonder...) If the virtual > > > device

Re: Block device throttling [Re: Distributed storage.]

2007-08-14 Thread Daniel Phillips
On Tuesday 14 August 2007 04:30, Evgeniy Polyakov wrote: > > And it will not solve the deadlock problem in general. (Maybe it > > works for your virtual device, but I wonder...) If the virtual > > device allocates memory during generic_make_request then the memory > > needs to be throttled. > > D

Re: Block device throttling [Re: Distributed storage.]

2007-08-14 Thread Evgeniy Polyakov
On Tue, Aug 14, 2007 at 04:13:10AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > On Tuesday 14 August 2007 01:46, Evgeniy Polyakov wrote: > > On Mon, Aug 13, 2007 at 06:04:06AM -0700, Daniel Phillips > ([EMAIL PROTECTED]) wrote: > > > Perhaps you never worried about the resources that the d

[PATCH] [DM9000] External PHY support

2007-08-14 Thread Laurent Pinchart
This patch adds a flag to the DM9000 platform data which, when set, configures the device to use an external PHY. Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- drivers/net/dm9000.c |6 ++ include/linux/dm9000.h |1 + 2 files changed, 7 insertions(+), 0 deletions(-) diff -

Re: Block device throttling [Re: Distributed storage.]

2007-08-14 Thread Daniel Phillips
On Tuesday 14 August 2007 01:46, Evgeniy Polyakov wrote: > On Mon, Aug 13, 2007 at 06:04:06AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > > Perhaps you never worried about the resources that the device > > mapper mapping function allocates to handle each bio and so did not > > consider thi

Re: Davicom Ethernet (onboard) with many Tx timeouts...

2007-08-14 Thread Ben Dooks
On Wed, Jan 03, 2007 at 10:33:08PM -0200, D?niel Fraga wrote: > Linux 2.6.19 (but this problem occurs with previous kernels too) > gcc 4.1.1 > pentium 3 > Module dmfe.ko > > dmfe: Davicom DM9xxx net driver, version 1.36.4 (2002-01-17) hmm, dmfe does not cover the dm9000, a little missleading? --

Re: dm9000: add set_mac_address()

2007-08-14 Thread Ben Dooks
On Sun, Aug 12, 2007 at 07:08:52PM -0400, Jeff Garzik wrote: > set_mac_address should not write to the SROM, as Michael noted. > > The proper operations are: > > probe time: > read MAC address from SROM > > dev open (interface up): > write dev->dev_addr[] to RX filter (or ide

Re: [patch 08/18] 3c59x: check return of pci_enable_device()

2007-08-14 Thread Mark Hindley
On Tue, Aug 14, 2007 at 01:33:26AM -0400, Jeff Garzik wrote: > I would strongly prefer that vortex_up return a value, since all the > important callers of this function can themselves return an error back > to the system. > > we can definitely return a meaningful return value here, if > pci_ena

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-14 Thread Krishna Kumar2
Forgot to mention one thing: > This fix reduced > retransmissions from 180,000 to 55,000 or so. When I changed IPoIB > driver to use iterative sends of each skb instead of creating multiple > Work Request's, that number went down to 15]. This also reduced TCP No Delay performance from huge perce

Re: 2.4.35-pre1: new e1000 driver breaks old hardware

2007-08-14 Thread Wolfgang Nothdurft
Kok, Auke wrote: Wolfgang Nothdurft wrote: Hi, with the new e1000 driver version 7.3.20 the onboard gigabit nic 82547EI (8086:1019) doesn't work correctly. After transferring about 100 megabytes over a gigabit link the transfer stopped and I have to reinit the link either by doing a ifconfig do

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-14 Thread Krishna Kumar2
Hi Dave, David Miller <[EMAIL PROTECTED]> wrote on 08/08/2007 04:19:00 PM: > From: Krishna Kumar <[EMAIL PROTECTED]> > Date: Wed, 08 Aug 2007 15:01:14 +0530 > > > RESULTS: The performance improvement for TCP No Delay is in the range of -8% > >to 320% (with -8% being the sole negative), with m

Re: Block device throttling [Re: Distributed storage.]

2007-08-14 Thread Evgeniy Polyakov
On Mon, Aug 13, 2007 at 06:04:06AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > Perhaps you never worried about the resources that the device mapper > mapping function allocates to handle each bio and so did not consider > this hole significant. These resources can be significant, as is

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-14 Thread Herbert Xu
On Tue, Aug 14, 2007 at 03:34:25PM +1000, Nick Piggin wrote: > > What do you think of this crazy idea? > > /* Enforce a compiler barrier for only operations to location X. > * Call multiple times to provide an ordering between multiple > * memory locations. Other memory operations can be assumed

Re: [patch]support for USB autosuspend in the asix driver

2007-08-14 Thread Oliver Neukum
Am Dienstag 14 August 2007 schrieb David Brownell: > On Monday 13 August 2007, Jeff Garzik wrote: > > Oliver Neukum wrote: > > > Hi, > > > > > > this implements support for USB autosuspend in the asix USB ethernet > > > driver. > > > > > > Regards > > > Oliver > > > Signed-off-by: Oli