[PATCH][IPv6] Export userland ND options through netlink (RDNSS support)

2007-10-04 Thread Pierre Ynard
As discussed before, this patch provides userland with a way to access relevant options in Router Advertisements, after they are processed and validated by the kernel. Extra options are processed in a generic way; this patch only exports RDNSS options described in RFC5006, but support to control wh

[PATCH] Fix typos in comments in netlink.h

2007-10-04 Thread Pierre Ynard
This patch fixes a few typos in comments in include/net/netlink.h Signed-off-by: Pierre Ynard <[EMAIL PROTECTED]> diff --git a/include/net/netlink.h b/include/net/netlink.h index 83113df..1afd3e8 100644 --- a/include/net/netlink.h +++ b/include/net/netlink.h @@ -84,7 +84,7 @@ * nla_next(nla)-

Re: [Bugme-new] [Bug 9124] New: Netconsole race crashed the system

2007-10-04 Thread David Miller
From: Tina Yang <[EMAIL PROTECTED]> Date: Thu, 04 Oct 2007 20:56:50 -0700 > Yes, it's RHEL5 2.6.18-8. Attached is the 2.6.9-42 version that > doesn't have 802.11 and > crashed at the same spot - netdevice.h:888. Also crashed are > 2.6.23-rc2 and rc4. 2.6.9-42 is, again, a vendor modif

Re: [Bugme-new] [Bug 9124] New: Netconsole race crashed the system

2007-10-04 Thread Tina Yang
Stephen Hemminger wrote: On Thu, 04 Oct 2007 18:27:04 -0700 Tina Yang <[EMAIL PROTECTED]> wrote: Andrew Morton wrote: (Please resoind by emailed reply-to-all, not via the bugzilla web interface) On Thu, 4 Oct 2007 16:24:18 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzi

Re: [Bugme-new] [Bug 9124] New: Netconsole race crashed the system

2007-10-04 Thread Stephen Hemminger
On Thu, 04 Oct 2007 18:27:04 -0700 Tina Yang <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > (Please resoind by emailed reply-to-all, not via the bugzilla web interface) > > > > On Thu, 4 Oct 2007 16:24:18 -0700 (PDT) > > [EMAIL PROTECTED] wrote: > > > > > >> http://bugzilla.kernel.org/s

Re: [Bugme-new] [Bug 9124] New: Netconsole race crashed the system

2007-10-04 Thread Stephen Hemminger
On Thu, 04 Oct 2007 18:27:04 -0700 Tina Yang <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > (Please resoind by emailed reply-to-all, not via the bugzilla web interface) > > > > On Thu, 4 Oct 2007 16:24:18 -0700 (PDT) > > [EMAIL PROTECTED] wrote: > > > > > >> http://bugzilla.kernel.org/s

[PATCH net-2.6.24] fix network compile warnings

2007-10-04 Thread Stephen Hemminger
One unused variable warning, and other is failure to check result. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c 2007-10-04 17:40:34.0 -0700 +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c 2007-10-04 17:44:33.0 -0700 @@ -854

Re: Vague maybe ppp-related panic report for 2.6.23-rc9

2007-10-04 Thread Roland Dreier
Just as a quick update -- I seem to only be able to reproduce this crash when my ppp session drops, which seems associated with marginal signal. And unfortunately I have great coverage at home so I haven't been able to reproduce this again today. Maybe on the train tomorrow I can crash my laptop.

Re: [Bugme-new] [Bug 9124] New: Netconsole race crashed the system

2007-10-04 Thread Tina Yang
Andrew Morton wrote: (Please resoind by emailed reply-to-all, not via the bugzilla web interface) On Thu, 4 Oct 2007 16:24:18 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9124 Summary: Netconsole race crashed the system Product: Net

Re: netconsole problems

2007-10-04 Thread Tina Yang
Matt Mackall wrote: On Thu, Oct 04, 2007 at 10:59:38AM -0700, Tina Yang wrote: We recently run into a few problems with netconsole in at least 2.6.9, 2.6.18 and 2.6.23. It either panicked at netdevice.h:890 or hung the system, and sometimes depending on which NIC we are using, the following

Re: [PATCH net-2.6.24] ip_gre: build fix

2007-10-04 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 4 Oct 2007 17:47:38 -0700 > IPGRE only uses header_ops in the case of CONFIG_NET_IPGRE_BROADCAST. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Stephen. - To unsubscribe from this list: send the line "unsubscribe n

Re: Vague maybe ppp-related panic report for 2.6.23-rc9

2007-10-04 Thread Herbert Xu
On Thu, Oct 04, 2007 at 01:51:13PM -0700, David Miller wrote: > > I don't want to jump the gun on the analysis but it just might > be the packet sharing fixes Herbert put in a short time ago. I think the only change of mine that could affect ppp over a serial line is this one. I couldn't see any

[PATCH net-2.6.24] ip_gre: build fix

2007-10-04 Thread Stephen Hemminger
IPGRE only uses header_ops in the case of CONFIG_NET_IPGRE_BROADCAST. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/ip_gre.c 2007-10-04 17:40:34.0 -0700 +++ b/net/ipv4/ip_gre.c 2007-10-04 17:41:20.0 -0700 @@ -1092,6 +1092,10 @@ static int ipgre_header(struct

Re: netconsole problems

2007-10-04 Thread Matt Mackall
On Thu, Oct 04, 2007 at 10:59:38AM -0700, Tina Yang wrote: > We recently run into a few problems with netconsole > in at least 2.6.9, 2.6.18 and 2.6.23. It either panicked > at netdevice.h:890 or hung the system, and sometimes depending > on which NIC we are using, the following console message, >

Re: [PATCH] net: fix kernel_accept() error path

2007-10-04 Thread David Miller
From: Tony Battersby <[EMAIL PROTECTED]> Date: Thu, 04 Oct 2007 18:12:53 -0400 > Here is an example of what I would consider "reasonable code" that would > fail: > > int example() > { > struct socket *conn_socket = NULL; > int err; > > ... > > if ((err = kernel_accept(sock, &con

Re: [Bugme-new] [Bug 9124] New: Netconsole race crashed the system

2007-10-04 Thread Andrew Morton
(Please resoind by emailed reply-to-all, not via the bugzilla web interface) On Thu, 4 Oct 2007 16:24:18 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9124 > >Summary: Netconsole race crashed the system >Product: Networking >

Re: [PATCH] ieee80211_if_set_type: make check for master dev more explicit

2007-10-04 Thread John W. Linville
On Thu, Oct 04, 2007 at 05:26:11PM -0400, Michael Wu wrote: > On Thursday 04 October 2007 14:09, John W. Linville wrote: > > diff --git a/net/mac80211/ieee80211_iface.c > > b/net/mac80211/ieee80211_iface.c index be7e77f..6607b80 100644 > > --- a/net/mac80211/ieee80211_iface.c > > +++ b/net/mac80211

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread John W. Linville
On Thu, Oct 04, 2007 at 02:31:26PM -0700, Roland Dreier wrote: > > Programming with assertions (and BUG_ON is a form of that) is > > generally a good practice. Almost any book or other source on > The problem with BUG_ON is that it kills the whole system. So every > time you add a BUG_ON into

Re: [PATCH] net: fix kernel_accept() error path

2007-10-04 Thread Tony Battersby
James Morris wrote: > On Thu, 4 Oct 2007, Tony Battersby wrote: > > >> If accept() returns an error, kernel_accept() releases the new socket >> but passes a pointer to the released socket back to the caller. Make it >> pass back NULL instead. >> >> Signed-off-by: Tony Battersby <[EMAIL PROTECTE

Re: net-2.6.24 compile breakage: error: 'ipgre_header' undeclared

2007-10-04 Thread David Miller
From: "Kok, Auke" <[EMAIL PROTECTED]> Date: Thu, 04 Oct 2007 14:49:10 -0700 > I'm getting this on net-2.6.24 today: > > CC [M] net/ipv4/ip_gre.o > net/ipv4/ip_gre.c:1135: error: 'ipgre_header' undeclared here (not in a > function) > make[2]: *** [net/ipv4/ip_gre.o] Error 1 > make[1]: *** [net

Re: [PATCH] net: fix kernel_accept() error path

2007-10-04 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Thu, 4 Oct 2007 14:57:33 -0700 (PDT) > On Thu, 4 Oct 2007, Tony Battersby wrote: > > > If accept() returns an error, kernel_accept() releases the new socket > > but passes a pointer to the released socket back to the caller. Make it > > pass back NULL

[PATCH] e1000e: Fix ethtool register test code

2007-10-04 Thread Auke Kok
A merge/cleanup code accidentally dropped 8254x code in and removed 8257x code here. Undo this mistake and use the pci-e relevant register test similar as to what is in e1000. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/ethtool.c | 14 ++ 1 files changed, 10

Re: [PATCH] net: fix kernel_accept() error path

2007-10-04 Thread James Morris
On Thu, 4 Oct 2007, Tony Battersby wrote: > If accept() returns an error, kernel_accept() releases the new socket > but passes a pointer to the released socket back to the caller. Make it > pass back NULL instead. > > Signed-off-by: Tony Battersby <[EMAIL PROTECTED]> > --- > --- linux-2.6.23-rc9

net-2.6.24 compile breakage: error: 'ipgre_header' undeclared

2007-10-04 Thread Kok, Auke
I'm getting this on net-2.6.24 today: CC [M] net/ipv4/ip_gre.o net/ipv4/ip_gre.c:1135: error: 'ipgre_header' undeclared here (not in a function) make[2]: *** [net/ipv4/ip_gre.o] Error 1 make[1]: *** [net/ipv4] Error 2 make[1]: *** Waiting for unfinished jobs the git log says sch touched

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread Roland Dreier
> Programming with assertions (and BUG_ON is a form of that) is > generally a good practice. Almost any book or other source on > good programming practices will agree. Yes, it can be overdone. > But I don't really think that is the case here, since the check is > relatively inexpensive and

Re: [PATCH] ieee80211_if_set_type: make check for master dev more explicit

2007-10-04 Thread Michael Wu
On Thursday 04 October 2007 14:09, John W. Linville wrote: > diff --git a/net/mac80211/ieee80211_iface.c > b/net/mac80211/ieee80211_iface.c index be7e77f..6607b80 100644 > --- a/net/mac80211/ieee80211_iface.c > +++ b/net/mac80211/ieee80211_iface.c > @@ -106,7 +106,7 @@ void ieee80211_if_set_type(st

Re: PROBLEM: system freezes on starting ne2k-pci + bridge

2007-10-04 Thread Stephen Hemminger
On Thu, 4 Oct 2007 20:27:38 +0200 [EMAIL PROTECTED] (Mirko Parthey) wrote: > On Tue, Oct 02, 2007 at 04:12:17PM +0200, I wrote: > > On a machine running Debian testing, I get complete lockups > > (Num lock LED not responding anymore) > > > > Kernel versions tried (all of them show this problem):

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread Michael Wu
On Thursday 04 October 2007 14:15, John W. Linville wrote: > Falling back on bloat as an argument against a BUG_ON in a > configuration path seems a bit weak. :-) > Seems strong to me. Bloat slows me down and distracts me from what code really needs to do. Bloat is an indication that one does not

Skb over panic on TUN device (2.6.18)

2007-10-04 Thread Max Krasnyansky
Folks, I just got this panic report against 2.6.18 kernel and was wondering if some of you have an idea of why this might happen. The panic looks like this: skb_over_panic: text:880463db len:2840 put:1454 head:81005df81000 data:81005df81020 tail:81005df81b38 end:81005df

Re: Vague maybe ppp-related panic report for 2.6.23-rc9

2007-10-04 Thread Roland Dreier
> I don't want to jump the gun on the analysis but it just might > be the packet sharing fixes Herbert put in a short time ago. > > What you could do is go back to say rc2 and see if you still get > the panics, then bisect from there to narrow it down. > > If rc2 still gives the panic, it'

Re: Vague maybe ppp-related panic report for 2.6.23-rc9

2007-10-04 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Thu, 04 Oct 2007 11:12:42 -0700 > Sorry for the lack of detail -- I've just switched to running in the > console so if I can provoke the crash again I'll get a little more > info. I just wanted to mention this in case someone has seen > something simi

[PATCH] net: fix kernel_accept() error path

2007-10-04 Thread Tony Battersby
If accept() returns an error, kernel_accept() releases the new socket but passes a pointer to the released socket back to the caller. Make it pass back NULL instead. Signed-off-by: Tony Battersby <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc9/net/socket.c.bak 2007-10-04 15:21:17.0 -0400 +

[PATCH 2.6.23-rc9] [TCP]: Fix fastpath_cnt_hint when GSO skb is partially ACKed

2007-10-04 Thread Ilpo Järvinen
When only GSO skb was partially ACKed, no hints are reset, therefore fastpath_cnt_hint must be tweaked too or else it can corrupt fackets_out. The corruption to occur, one must have non-trivial ACK/SACK sequence, so this bug is not very often that harmful. There's a fackets_out state reset in TCP

[PATCH net-2.6.24] [TCP]: Fix fastpath_cnt_hint when GSO skb is partially ACKed

2007-10-04 Thread Ilpo Järvinen
On Thu, 4 Oct 2007, Cedric Le Goater wrote: > so here are the results on a net-2.6.24 kernel. > > I've put the patchset here to make sure it's correct: > > http://legoater.free.fr/patches/2.6.23/net-2.6.24.git-tcp_fastretrans/ > > and plenty of logs : > > > http://legoater.free.

Re: [PATCH] ieee80211_if_set_type: make check for master dev more explicit

2007-10-04 Thread John W. Linville
On Thu, Oct 04, 2007 at 08:44:48PM +0200, Johannes Berg wrote: > On Thu, 2007-10-04 at 14:09 -0400, John W. Linville wrote: > > > --- a/net/mac80211/ieee80211_iface.c > > +++ b/net/mac80211/ieee80211_iface.c > > @@ -106,7 +106,7 @@ void ieee80211_if_set_type(struct net_device *dev, int > > type)

wireless-dev dead, long live wireless-2.6

2007-10-04 Thread John W. Linville
Greetings, This message is perhaps a few days late -- better late than never. :-) The big news is that wireless-dev is now dead, defunct, kaput. Please discontinue any use of wireless-dev or any of its clones. If you need access to the contents of that tree for historical purposes, please see the

Re: [PATCH] ieee80211_if_set_type: make check for master dev more explicit

2007-10-04 Thread Johannes Berg
On Thu, 2007-10-04 at 14:09 -0400, John W. Linville wrote: > --- a/net/mac80211/ieee80211_iface.c > +++ b/net/mac80211/ieee80211_iface.c > @@ -106,7 +106,7 @@ void ieee80211_if_set_type(struct net_device *dev, int > type) >* which already has a hard_start_xmit routine assigned >*

[PATCH] e1000e: fix debugging printout code

2007-10-04 Thread Auke Kok
A small bug crawled in the -DDEBUG enabled code. Fix this to properly call the backreference device name. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/hw.h |2 +- drivers/net/e1000e/netdev.c |4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread John W. Linville
On Thu, Oct 04, 2007 at 01:11:33PM -0400, Michael Wu wrote: > On Thursday 04 October 2007 11:19, John W. Linville wrote: > > > The reason why BUG_ON exists is to catch bugs that happen, although > > > they Should Never Happen (tm) ;) > > > > Precisely. > No really, this bug will never happen. This

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread John W. Linville
On Thu, Oct 04, 2007 at 12:33:43PM +0100, Daniel Drake wrote: > Fix this by unsetting the hard_start_xmit handler in ieee80211_if_reinit. It > will then be reinitialised to the default (ieee80211_subif_start_xmit) in > ieee80211_if_set_type. I think I'd rather fix this by making the check in ieee

[PATCH] ieee80211_if_set_type: make check for master dev more explicit

2007-10-04 Thread John W. Linville
Problem description by Daniel Drake <[EMAIL PROTECTED]>: "This sequence of events causes loss of connectivity: ifconfig eth7 down iwconfig eth7 mode monitor ifconfig eth7 up ifconfig eth7 down iwconfig eth7 mode managed At this point you are associated but TX does not work. This is because th

[PATCH] ethtool: Add e1000e reg dump support (using e1000 decode function)

2007-10-04 Thread Auke Kok
The e1000 register dump code can print out e1000e register dump information as well, so enable it for e1000e devices. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ethtool.c b/ethtool.c index 651529e..6c7a2e3 10

Re: PROBLEM: system freezes on starting ne2k-pci + bridge

2007-10-04 Thread Mirko Parthey
On Tue, Oct 02, 2007 at 04:12:17PM +0200, I wrote: > On a machine running Debian testing, I get complete lockups > (Num lock LED not responding anymore) > > Kernel versions tried (all of them show this problem): > - linux-image-2.6.18-5-amd64 (Debian etch) > - linux-image-2.6.22-2-amd64 (Debian te

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread Johannes Berg
On Thu, 2007-10-04 at 10:34 -0400, Michael Wu wrote: > On Thursday 04 October 2007 07:33, Daniel Drake wrote: > > Fix this by unsetting the hard_start_xmit handler in ieee80211_if_reinit. > > It will then be reinitialised to the default (ieee80211_subif_start_xmit) > > in ieee80211_if_set_type. > >

Vague maybe ppp-related panic report for 2.6.23-rc9

2007-10-04 Thread Roland Dreier
I'm running 2.6.23-rc9 on my laptop, and when in a coffee shop I use a Verizon EVDO card to get network access. This is a kyocera device that looks like a serial adapter behind an ohci usb controller, and uses the airprime driver (for usb device 0c88:17da). The actual IP networking is ppp over th

netconsole problems

2007-10-04 Thread Tina Yang
We recently run into a few problems with netconsole in at least 2.6.9, 2.6.18 and 2.6.23. It either panicked at netdevice.h:890 or hung the system, and sometimes depending on which NIC we are using, the following console message, e1000: "e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang

Re: Bugzilla: open bug reports

2007-10-04 Thread Chuck Ebbert
On 10/04/2007 12:44 PM, Stephen Hemminger wrote: > Bugzilla report of open bugs. Yes you could run it yourself but > many of these bugs seem to be old and need some attention or work > to get resolved. > > Would this be useful to regularly run/automate? > What format? Yes, run it. And add links t

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread Michael Wu
On Thursday 04 October 2007 11:19, John W. Linville wrote: > > The reason why BUG_ON exists is to catch bugs that happen, although > > they Should Never Happen (tm) ;) > > Precisely. No really, this bug will never happen. This is function is merely a helper function which is called from interface

Re: [BUGZILLA] network bugs

2007-10-04 Thread Stephen Hemminger
On Thu, 4 Oct 2007 09:55:43 -0700 "Avinash Ramanath" <[EMAIL PROTECTED]> wrote: > Stephen, > > Are there any bugs that I can look into? > I would like to get context of an area for a bug and then fix the issue. > > Thanks, > Avinash. > Go look at the bug report on bugzilla and do what you can.

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread Michael Wu
On Thursday 04 October 2007 11:54, Stephen Hemminger wrote: > Playing with the function pointer is a awkward way to do this. Shouldn't > the state management flags be used instead (dormant, running, stop/wake)... > I am concerned about races and dereferencing the NULL ptr. This is all under RTNL a

Re: [BUGZILLA] network bugs

2007-10-04 Thread Avinash Ramanath
Stephen, Are there any bugs that I can look into? I would like to get context of an area for a bug and then fix the issue. Thanks, Avinash. On 10/4/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > 68 bugs found. > ID AssigneeStatus Resolution Version Summary > 2803

[BUGZILLA] network device bugs

2007-10-04 Thread Stephen Hemminger
94 bugs found. ID AssigneeStatus Resolution Version Summary 2283[EMAIL PROTECTED] ASSI2.6.3 (net forcedeth) NETDEV WATCHDOG: eth1: transmit timed out... 2776[EMAIL PROTECTED] ASSI2.6.5 (net dmfe) Davicom 9102AF o

[BUGZILLA] network bugs

2007-10-04 Thread Stephen Hemminger
68 bugs found. ID AssigneeStatus Resolution Version Summary 2803[EMAIL PROTECTED] ASSI2.6.6 isa modem detected but does not initialize 3258[EMAIL PROTECTED] ASSI2.4.27 or 2.6.8.1 kernel IP autoconfig with PCMCIA 4206

Bugzilla: open bug reports

2007-10-04 Thread Stephen Hemminger
Bugzilla report of open bugs. Yes you could run it yourself but many of these bugs seem to be old and need some attention or work to get resolved. Would this be useful to regularly run/automate? What format? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messa

[BUGZILLA] network wireless bugs

2007-10-04 Thread Stephen Hemminger
13 bugs found. ID AssigneeStatus Resolution Version Summary 4186[EMAIL PROTECTED] ASSI2.6.9 (wireless airo) Aironet 340 PCMCIA does not support WPA 6834[EMAIL PROTECTED] ASSI2.6.17-rc6 wpa_supplicant does not work if wi

Re: Blackfin Ethernet MAC driver compile error

2007-10-04 Thread Bryan Wu
On Thu, 2007-10-04 at 22:26 +0800, Kalle Pokki wrote: > On 10/4/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > Sorry for missing the pinmux patches. > > After Linus's git-pull, it should be fixed in the latest Linus > mainline > > git tree. > > Thanks, it is working now. I was also glad to see the

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread Stephen Hemminger
On Thu, 4 Oct 2007 12:33:43 +0100 (BST) Daniel Drake <[EMAIL PROTECTED]> wrote: > This sequence of events causes loss of connectivity: > > > > ifconfig eth7 down > iwconfig eth7 mode monitor > ifconfig eth7 up > ifconfig eth7 down > iwconfig eth7 mode managed > > > At this point you are asso

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread John W. Linville
On Thu, Oct 04, 2007 at 05:06:05PM +0200, Michael Buesch wrote: > On Thursday 04 October 2007 16:34:43 Michael Wu wrote: > > On Thursday 04 October 2007 07:33, Daniel Drake wrote: > > > Fix this by unsetting the hard_start_xmit handler in ieee80211_if_reinit. > > > It will then be reinitialised to

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread Michael Wu
On Thursday 04 October 2007 11:06, Michael Buesch wrote: > The reason why BUG_ON exists is to catch bugs that happen, although > they Should Never Happen (tm) ;) This is just paranoia. There's plenty of other BUG_ONs which we use to catch bugs caused by drivers doing silly things. We can verify th

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread Michael Buesch
On Thursday 04 October 2007 16:34:43 Michael Wu wrote: > On Thursday 04 October 2007 07:33, Daniel Drake wrote: > > Fix this by unsetting the hard_start_xmit handler in ieee80211_if_reinit. > > It will then be reinitialised to the default (ieee80211_subif_start_xmit) > > in ieee80211_if_set_type. >

Re: [patch 3/3] git-net: sctp build fix (not for applying)

2007-10-04 Thread Vlad Yasevich
David Miller wrote: > From: Vlad Yasevich <[EMAIL PROTECTED]> > Date: Wed, 03 Oct 2007 09:50:55 -0400 > >> [EMAIL PROTECTED] wrote: >>> From: Andrew Morton <[EMAIL PROTECTED]> >>> >>> net/sctp/sm_statetable.c:551: error: 'sctp_sf_tabort_8_4_8' undeclared here >>> (not in a function) >>> >> Andrew

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-04 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Wed, 3 Oct 2007, Cedric Le Goater wrote: > >> Cedric Le Goater wrote: >>> Below are the messages I got on 2) right after running ketchup (which does >>> a wget www.kernel.org) > > Oops, those tcp_fragment WARNINGs in the other mail were due to bug in > the debug patch

[patch 2/2] af_iucv: postpone receival of iucv-packets

2007-10-04 Thread Ursula Braun
From: Ursula Braun <[EMAIL PROTECTED]> AF_IUCV socket programs may waste Linux storage, because af_iucv allocates an skb whenever posted by the receive callback routine and receives the message immediately. Message receival is now postponed if data from previous callbacks has not yet been transf

[patch 0/2] [AF_IUCV] fixes for net-2.6.24

2007-10-04 Thread Ursula Braun
-- Dave, the following 2 patches are intended for 2.6.24 and contain: - removal of static declarations in af_iucv header file - postpone receival of inbound packets in af_iucv - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More ma

[patch 1/2] af_iucv: remove static declarations from header file.

2007-10-04 Thread Ursula Braun
From: Heiko Carstens <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> Signed-off-by: Ursula Braun <[EMAIL PROTECTED]> --- include/net/iucv/af_iucv.h | 21 - net/iucv/af_iucv.c |3 +++ 2 files changed, 3 insertions(+), 21 deletions(-) Index:

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread Michael Wu
On Thursday 04 October 2007 07:33, Daniel Drake wrote: > Fix this by unsetting the hard_start_xmit handler in ieee80211_if_reinit. > It will then be reinitialised to the default (ieee80211_subif_start_xmit) > in ieee80211_if_set_type. > Well.. this kinda sucks, but we can clean up the logic here la

Re: Blackfin Ethernet MAC driver compile error

2007-10-04 Thread Kalle Pokki
On 10/4/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > Sorry for missing the pinmux patches. > After Linus's git-pull, it should be fixed in the latest Linus mainline > git tree. Thanks, it is working now. I was also glad to see the binfmt_flat patch going in. Do you plan to get the PHY abstraction la

Re: [Devel] [PATCH][NETNS] Move some code into __init section when CONFIG_NET_NS=n

2007-10-04 Thread Alexey Dobriyan
On Thu, Oct 04, 2007 at 05:54:11PM +0400, Pavel Emelyanov wrote: > With the net namespaces many code leaved the __init section, > thus making the kernel occupy more memory than it did before. > Since we have a config option that prohibits the namespace > creation, the functions that initialize/fina

[PATCH][NETNS] Move some code into __init section when CONFIG_NET_NS=n

2007-10-04 Thread Pavel Emelyanov
With the net namespaces many code leaved the __init section, thus making the kernel occupy more memory than it did before. Since we have a config option that prohibits the namespace creation, the functions that initialize/finalize some netns stuff are simply not needed and can be freed after the bo

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-10-04 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 04, 2007 at 01:51:47PM +0200, Urs Thuermann escreveu: > Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> writes: > > > > +struct sockaddr_can { > > > + sa_family_t can_family; > > > + int can_ifindex; > > > + union { > > > + struct { canid_t rx_id, tx_id; } tp16; > > > +

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-10-04 Thread Urs Thuermann
Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> writes: > > +#ifdef CONFIG_CAN_DEBUG_DEVICES > > +static int debug; > > +module_param(debug, int, S_IRUGO); > > +#endif > > Can debug be a boolean? Like its counterpart on DCCP: debug used to a bit mask, like it still is in core.h. You can see this i

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-10-04 Thread Urs Thuermann
Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> writes: > > +struct sockaddr_can { > > + sa_family_t can_family; > > + int can_ifindex; > > + union { > > + struct { canid_t rx_id, tx_id; } tp16; > > + struct { canid_t rx_id, tx_id; } tp20; > > + struct { ca

Re: [PATCH 3/7] CAN: Add raw protocol

2007-10-04 Thread Urs Thuermann
Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> writes: > > +static inline struct raw_sock *raw_sk(const struct sock *sk) > > +{ > > + return (struct raw_sock *)sk; > > +} > > > What if I want to do some kernel module that uses INET raw sockets > (include/net/icmp.h) and CAN raw sockets? Namespac

[PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread Daniel Drake
This sequence of events causes loss of connectivity: ifconfig eth7 down iwconfig eth7 mode monitor ifconfig eth7 up ifconfig eth7 down iwconfig eth7 mode managed At this point you are associated but TX does not work. This is because the eth7 hard_start_xmit is still ieee80211_monitor_start_xmi

[RFC][PATCH 2/2] TCP: skip processing cached SACK blocks

2007-10-04 Thread TAKANO Ryousei
This patch allows to process only newly reported SACK blocks at the sender side. An ACK packet contains up to three SACK blocks, and some of them may be already reported and processed blocks. This patch prevents processing of such already processed SACK blocks. Signed-off-by: Ryousei Takano <[EM

[RFC][PATCH 1/2] TCP: fix lost retransmit detection

2007-10-04 Thread TAKANO Ryousei
This patch allows to detect loss of retransmitted packets more accurately by using the highest end sequence number among SACK blocks. Before the retransmission queue is scanned, the highest end sequence number (high_end_seq) is retrieved, and this value is compared with the ack_seq of each packet

[RFC][PATCH 2.6.23-rc9 0/2] detection of loss of retransmitted packets

2007-10-04 Thread TAKANO Ryousei
Hi all, We found a performance problem which occurs in heavy packet loss conditions. It seems there is a problem in detecting loss of retransmitted packets. In the retransmission queue, status of sent packets are registered. When a packet is retransmitted, it is so marked, and snd_nxt (sequence

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-04 Thread Ilpo Järvinen
On Wed, 3 Oct 2007, Cedric Le Goater wrote: > Cedric Le Goater wrote: > > > > Below are the messages I got on 2) right after running ketchup (which does > > a wget www.kernel.org) Oops, those tcp_fragment WARNINGs in the other mail were due to bug in the debug patch as it called verify too ea

Re: Blackfin Ethernet MAC driver compile error

2007-10-04 Thread Bryan Wu
On Tue, 2007-10-02 at 23:36 +0800, Robin Getz wrote: > On Tue 2 Oct 2007 07:30, Kalle Pokki pondered: > > The Blackfin Ethernet MAC driver does not compile. It seems the > driver is > > missing some pinmux defines. > > > > CC drivers/net/bfin_mac.o > > drivers/net/bfin_mac.c: In functio

Re: Blackfin Ethernet MAC driver compile error

2007-10-04 Thread Bryan Wu
On Tue, 2007-10-02 at 19:30 +0800, Kalle Pokki wrote: > The Blackfin Ethernet MAC driver does not compile. It seems the driver > is > missing some pinmux defines. > > CC drivers/net/bfin_mac.o > drivers/net/bfin_mac.c: In function 'setup_pin_mux': > drivers/net/bfin_mac.c:275: error: 'P_