Re: MSI interrupts and disable_irq

2007-10-06 Thread Yinghai Lu
On 10/5/07, Eric W. Biederman [EMAIL PROTECTED] wrote: Stephen Hemminger [EMAIL PROTECTED] writes: On Fri, 28 Sep 2007 22:47:16 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Ayaz Abdulla wrote: I am trying to track down a forcedeth driver issue described by bug 9047 in bugzilla

Re: [PATCH]: Third (final?) release of Sun Neptune driver

2007-10-06 Thread Johannes Berg
On Fri, 2007-10-05 at 17:28 -0700, Stephen Hemminger wrote: Sparse doesn't like dynamically sized arrays, which is what BUILD_BUG_ON() expands into. Not sure why it is hostile to dynamic arrays, probably just a Linus (or Viro) taste thing. sparse from git copes with it. johannes

duplicated u32 filters in tc show output

2007-10-06 Thread Abhijit Menon-Sen
The HTB user guide (http://luxik.cdi.cz/~devik/qos/htb/manual/userg.htm) says the following: Note: The U32 classifier has an undocumented design bug which causes duplicate entries to be listed by tc filter show when you use U32 classifiers with different prio values. What exactly is

[PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-06 Thread Jeff Garzik
The 'fe-lock' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock contains the following changes that I would like to get tested: [netdrvr] forcedeth: make NAPI unconditional [netdrvr] forcedeth: interrupt handling cleanup [netdrvr]

[PATCH 1/5] forcedeth: make NAPI unconditional

2007-10-06 Thread Jeff Garzik
commit 7bfc023b952e8e12c7333efccd2e78023c546a7c Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Oct 5 20:50:24 2007 -0400 [netdrvr] forcedeth: make NAPI unconditional Signed-off-by: Jeff Garzik [EMAIL PROTECTED] drivers/net/Kconfig | 17 - drivers/net/forcedeth.c |

[PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-06 Thread Jeff Garzik
commit a606d2a111cdf948da5d69eb1de5526c5c2dafef Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Oct 5 22:56:05 2007 -0400 [netdrvr] forcedeth: interrupt handling cleanup * nv_nic_irq_optimized() and nv_nic_irq_other() were complete duplicates of nv_nic_irq(), with the

[PATCH 3/5] forcedeth: process TX completions using NAPI

2007-10-06 Thread Jeff Garzik
commit 57cbfacc00d69be2ba02b65d1021442273b76263 Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Oct 5 23:25:56 2007 -0400 [netdrvr] forcedeth: process TX completions using NAPI Signed-off-by: Jeff Garzik [EMAIL PROTECTED] drivers/net/forcedeth.c | 143

[PATCH 4/5] forcedeth: internal simplification and cleanups

2007-10-06 Thread Jeff Garzik
commit 39572457a4dfe9a9dc1efd6641e7a6467e5658a1 Author: Jeff Garzik [EMAIL PROTECTED] Date: Sat Oct 6 01:21:01 2007 -0400 [netdrvr] forcedeth: internal simplification and cleanups * remove changelog from source; its kept in git repository * split guts of RX/TX DMA engine

[PATCH 5/5] forcedeth: timer overhaul

2007-10-06 Thread Jeff Garzik
commit d7c766113ee2ec66ae8975e0acbad086d2c23594 Author: Jeff Garzik [EMAIL PROTECTED] Date: Sat Oct 6 10:57:56 2007 -0400 [netdrvr] forcedeth: timer overhaul * convert stats_poll timer to a delayed-work workqueue stats_task * protect hw stats update with a lock *

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-06 Thread Jeff Garzik
On Sat, Oct 06, 2007 at 11:12:50AM -0400, Jeff Garzik wrote: The 'fe-lock' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock It should also be pointed out that these patches were generated on top of davem's net-2.6.24.git tree. They -probably- apply to

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-06 Thread Jeff Garzik
Jeff Garzik wrote: The goals of these changes are: * move the driver towards a more sane, simple, easy to verify locking setup -- irq handler would often acquire/release the lock twice for each interrupt -- and hopefully s/and hopefully// (it became the next bullet point) - To

Re: MSI interrupts and disable_irq

2007-10-06 Thread Yinghai Lu
On 9/28/07, Jeff Garzik [EMAIL PROTECTED] wrote: Ayaz Abdulla wrote: I am trying to track down a forcedeth driver issue described by bug 9047 in bugzilla (2.6.23-rc7-git1 forcedeth w/ MCP55 oops under heavy load). I added a patch to synchronize the timer handlers so that one handler

[PATCH] net/core: split dev_ifsioc() according to locking

2007-10-06 Thread Jeff Garzik
This always bugged me: dev_ioctl() called dev_ifsioc() either inside read_lock(dev_base_lock) or rtnl_lock(), depending on the ioctl being executed. This change moves the ioctls executed inside dev_base_lock to a new function, dev_ifsioc_locked(). Now the locking context is completely clear to

Re: [PATCH] net/core: split dev_ifsioc() according to locking

2007-10-06 Thread Arnd Bergmann
On Saturday 06 October 2007, Jeff Garzik wrote: This always bugged me:  dev_ioctl() called dev_ifsioc() either inside read_lock(dev_base_lock) or rtnl_lock(), depending on the ioctl being executed. This change moves the ioctls executed inside dev_base_lock to a new function,

Re: [PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-06 Thread Yinghai Lu
On 10/6/07, Jeff Garzik [EMAIL PROTECTED] wrote: commit a606d2a111cdf948da5d69eb1de5526c5c2dafef Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Oct 5 22:56:05 2007 -0400 [netdrvr] forcedeth: interrupt handling cleanup * nv_nic_irq_optimized() and nv_nic_irq_other() were complete