This code is broken from the very beginning.
iris den # cat /proc/sys/net/ipv4/ip_local_port_range
32768 61000
iris den # echo 32768 32 /proc/sys/net/ipv4/ip_local_port_range
iris den # cat /proc/sys/net/ipv4/ip_local_port_range
32768 32
iris den # echo 32768 61000
Hi,
Denis V. Lunev [EMAIL PROTECTED] writes:
This code is broken from the very beginning.
iris den # cat /proc/sys/net/ipv4/ip_local_port_range
32768 61000
iris den # echo 32768 32 /proc/sys/net/ipv4/ip_local_port_range
iris den # cat /proc/sys/net/ipv4/ip_local_port_range
32768 32
Hi Evgeniy,
Thank you for your comment.
Hi.
On Sat, Oct 06, 2007 at 12:01:07AM +0900, Satoshi OSHIMA ([EMAIL PROTECTED])
wrote:
--- 2.6.23-rc3-udp_limit.orig/net/ipv4/udp.c
+++ 2.6.23-rc3-udp_limit/net/ipv4/udp.c
@@ -113,6 +113,10 @@ DEFINE_SNMP_STAT(struct udp_mib, udp_sta
struct
Anton Arapov wrote:
Denis V. Lunev [EMAIL PROTECTED] writes:
Anton Arapov wrote:
Denis V. Lunev [EMAIL PROTECTED] writes:
This code is broken from the very beginning.
iris den # cat /proc/sys/net/ipv4/ip_local_port_range
32768 61000
iris den # echo 32768 32
From: Denis V. Lunev [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 12:38:37 +0400
both versions of settings, your ones and my ones are _useless_ in real
life. So, we do some sanity fixes. Am I right? If so, we must prevent
all versions of OOPS (aka division by zero here).
I'll send my vision in
Anton Arapov wrote:
Hi,
Denis V. Lunev [EMAIL PROTECTED] writes:
This code is broken from the very beginning.
iris den # cat /proc/sys/net/ipv4/ip_local_port_range
32768 61000
iris den # echo 32768 32 /proc/sys/net/ipv4/ip_local_port_range
iris den # cat
This patch fixed a possible division-by-zero in inet_csk_get_port
treating situation low high as if low == high.
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
CC: Antov Arapov [EMAIL PROTECTED]
--- ./net/ipv4/inet_connection_sock.c.getport 2007-10-09 15:16:02.0
+0400
+++
Eric W. Biederman wrote:
Pavel Emelyanov [EMAIL PROTECTED] writes:
Currently indexes for netdevices come sequentially one by
one, and the same stays true even for devices that are
created for namespaces.
Side effects of this are:
* lo device has not 1 index in a namespace. This may
Hello,
I'm studying the implementation of sk_buff and I think there's a
possible race condition in skb_clone (2.6.22.9)
The code is:
struct sk_buff *skb_clone(struct sk_buff *skb, gfp_t gfp_mask)
{
struct sk_buff *n;
n = skb + 1;
if (skb-fclone == SKB_FCLONE_ORIG
n-fclone ==
Ok, I've got it, so we have to do the same with the following:
quote from inet_hashtables.c and inet6_hashtables.c. I'll prepare the
patch.
And just a curious, does the /* Treat low high as high == low */
idea will keep after the sysctl will be patched?
int inet_hash_connect(struct
A 256 entry TX hw queue fills up trivially on 1GB and 10GB, but if you
With TSO really?
increase the size much more performance starts to go down due to L2
cache thrashing.
Another possibility would be to consider using cache avoidance
instructions while updating the TX ring (e.g. write
From: Andi Kleen [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 11:16:44 +0200
A 256 entry TX hw queue fills up trivially on 1GB and 10GB, but if you
With TSO really?
Yes.
increase the size much more performance starts to go down due to L2
cache thrashing.
Another possibility would be to
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 19:52:58 +0400
This function allocates the zeroed chunk of memory and
call seq_open(). The __seq_open_private() helper returns
the allocated memory to make it possible for the caller
to initialize it.
Signed-off-by: Pavel
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 19:55:28 +0400
This concerns the ipv4 and ipv6 code mostly, but also the netlink
and unix sockets.
The netlink code is an example of how to use the __seq_open_private()
call - it saves the net namespace on this private.
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 19:57:29 +0400
Just switch to the consolidated calls.
ipt_recent() has to initialize the private, so use
the __seq_open_private() helper.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Cc: Patrick McHardy [EMAIL PROTECTED]
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 19:59:38 +0400
Just switch to the consolidated code.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Cc: Patrick Caulfield [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 20:01:32 +0400
Just switch to the consolidated code
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Cc: Samuel Ortiz [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a
From: Anton Arapov [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 11:00:17 +0200
Ok, I've got it, so we have to do the same with the following:
quote from inet_hashtables.c and inet6_hashtables.c. I'll prepare the
patch.
And just a curious, does the /* Treat low high as high == low */
idea will
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 15:20:02 +0300
This addition of lost_retrans_low to tcp_sock might be
unnecessary, it's not clear how often lost_retrans worker is
executed when there wasn't work to do.
Cc: TAKANO Ryousei [EMAIL PROTECTED]
Signed-off-by: Ilpo
From: David Miller [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 02:44:03 -0700 (PDT)
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 15:20:02 +0300
This addition of lost_retrans_low to tcp_sock might be
unnecessary, it's not clear how often lost_retrans worker is
executed when
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 15:20:00 +0300
Follows own function for each task principle, this is really
somewhat separate task being done in sacktag. Also reduces
indentation.
In addition, added ack_seq local var to break some long
lines fixed coding style
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 14:50:54 +0400
The unregister_netdevice() and dev_change_net_namespace()
both check for dev-flags to be IFF_UP before calling the
dev_close(), but the dev_close() checks for IFF_UP itself,
so remove those unneeded checks.
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 16:03:29 +0300 (EEST)
On Tue, 9 Oct 2007, Ilpo Järvinen wrote:
Lost_retrans handling of sacktag was found to be flawed, two
problems that were found have an intertwined solution. Fastpath
problem has existed since hints got
From: Eliezer Tamir [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 18:20:01 +0200
Almost all of the zero-filled tables will be removed.
The rest of the registers do need to be initialized.
I agree that the number of registers that needs to be initialized is
huge, but that is caused by the way the
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 20:04:23 +0400
Just switch to the consolidated code.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Cc: Neil Brown [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a
From: Mitsuru Chinen [EMAIL PROTECTED]
Date: Tue, 9 Oct 2007 16:21:58 +0900
To judge the timing for DAD, netif_carrier_ok() is used. However,
there is a possibility that dev-qdisc stays noop_qdisc even if
netif_carrier_ok() returns true. In that case, DAD NS is not sent out.
We need to defer
From: Anton Arapov [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 11:56:23 +0200
Yep, that's exactly I'm talking about. I'm sure that
[...] % (high - low) [...] erroneous from the begining, because
in such places we want to have 1 in denominator, for the cases when we
have only one port.
Unless we have failed to fill the RX ring the timer used by the natsemi
driver is not particularly urgent and can use round_jiffies() to allow
grouping with other timers.
Signed-off-by: Mark Brown [EMAIL PROTECTED]
---
Rediffed against current netdev-2.6.git#upstream
drivers/net/natsemi.c |
On Wed, Oct 10, 2007 at 11:16:44AM +0200, Andi Kleen wrote:
A 256 entry TX hw queue fills up trivially on 1GB and 10GB, but if you
With TSO really?
Hardware queues are generally per-page rather than per-skb so
it'd fill up quicker than a software queue even with TSO.
Cheers,
--
Visit
David Miller [EMAIL PROTECTED] writes:
Ok, I've got it, so we have to do the same with the following:
quote from inet_hashtables.c and inet6_hashtables.c. I'll prepare the
patch.
And just a curious, does the /* Treat low high as high == low */
idea will keep after the sysctl will be
On Wed, Oct 10, 2007 at 02:25:50AM -0700, David Miller wrote:
The chip I was working with at the time (UltraSPARC-IIi) compressed
all the linear stores into 64-byte full cacheline transactions via
the store buffer.
That's a pretty old CPU. Conclusions on more modern ones might be different.
From: Andi Kleen [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 12:23:31 +0200
On Wed, Oct 10, 2007 at 02:25:50AM -0700, David Miller wrote:
The chip I was working with at the time (UltraSPARC-IIi) compressed
all the linear stores into 64-byte full cacheline transactions via
the store buffer.
On Wed, 10 Oct 2007, David Miller wrote:
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Mon, 24 Sep 2007 13:28:42 +0300
After couple of wrong-wayed before/after()s and one infinite
loopy version, here's the current trial version of a sacktag
cache usage recode
Two first patches
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 13:26:05 +0300 (EEST)
Hmm, SACK code is under such flux currently that I'll
have to deal conflicts almost daily due to overlapping ideas...
Welcome to my world, just scale it to 800 patches and entire
networking tree :-
-
To
Denys wrote:
here is try to switch clocksource to acpi_pm
Time: acpi_pm clocksource has been installed.
Clockevents: could not switch to one-shot mode: lapic is not functional.
Could not switch to high resolution mode on CPU 0
What does /proc/net/psched contain?
-
To unsubscribe from this
What does /proc/net/psched contain?
visp-1 ~ # cat /proc/net/psched
03e8 0400 000f4240 3b9aca00
--
Denys Fedoryshchenko
Technical Manager
Virtual ISP S.A.L.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo
Denys wrote:
What does /proc/net/psched contain?
visp-1 ~ # cat /proc/net/psched
03e8 0400 000f4240 3b9aca00
OK, hrtimers are disabled on your system, but we still announce
the usec clock resolution to userspace, which is used by HTB to
calculate the burst rate. But actually that
David Miller [EMAIL PROTECTED] writes:
From: Anton Arapov [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 11:56:23 +0200
Yep, that's exactly I'm talking about. I'm sure that
[...] % (high - low) [...] erroneous from the begining, because
in such places we want to have 1 in denominator, for the
Eric W. Biederman wrote:
Before I can enable rtnetlink to work in all network namespaces
I need to be certain that something won't break. So this
patch deliberately disables all of the rtnletlink methods in everything
except the initial network namespace. After the methods have been
audited
Hi 2 all again
I have shaper, running very simple HTB tree (about 10 classes).
Traffic is coming via eth0, and going over eth0.1000, shaper installed on
eth0.1000 (802.1Q vlan), total rate is 85Mbit/s.
On kernel 2.6.22 with bnx2 eth0 everything was working fine.
I have another server with
P.S.
dmesg
Linux version 2.6.23-insat1 ([EMAIL PROTECTED]) (gcc version 4.1.1 (Gentoo
4.1.1-
r3)) #1 SMP Wed Oct 10 01:41:17 EEST 2007
BIOS-provided physical RAM map:
BIOS-e820: 0100 - 000a (usable)
BIOS-e820: 0010 - 3ffa8000 (usable)
BIOS-e820:
Seems i am lost a bit. Now 2.6.22, i am not sure that working well. Possible
it is related, that i booted kernel over kexec.
I will try to do full power cycle reboot if required, but it will cause for
me serious downtime. Please tell me, which kernel prefferable to boot?
If it is interesting
On Wed, 2007-10-10 at 14:45 +0200, Patrick McHardy wrote:
OK, hrtimers are disabled on your system, but we still announce
the usec clock resolution to userspace, which is used by HTB to
calculate the burst rate. But actually that can't be the reason
since that has already been the case in
Denys wrote:
Seems i am lost a bit. Now 2.6.22, i am not sure that working well. Possible
it is related, that i booted kernel over kexec.
Possibly.
I will try to do full power cycle reboot if required, but it will cause for
me serious downtime. Please tell me, which kernel prefferable to
I did complete reboot(without kexec) to 2.6.23 (same configuration) and seems
it is working better (not stuck as before to 60-70Mbit/s).
On all cases current_clocksources was hpet, just i tried to change it (doesnt
help at all).
visp-1 ~ # cat /sys/devices/system/clocksource/clocksource0/
Patch applied. Rebooted over kexec to 2.6.23 without nmi_watchdog, for now
all seems fine.
visp-1 ~ # cat /proc/net/psched
03e8 0400 000f4240 3b9aca00
82942/82949 KBit/S (53083445/53087945) (106109614/106105114)
82955/82955 KBit/S (53091631/53091631) (159193059/159193059)
82955/82955
Denis V. Lunev wrote:
Eric W. Biederman wrote:
Before I can enable rtnetlink to work in all network namespaces
I need to be certain that something won't break. So this
patch deliberately disables all of the rtnletlink methods in everything
except the initial network namespace. After the
This patch adds check low high for ip_local_port_range.
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index 53ef0f4..686c0a4 100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@ -186,6 +186,61 @@
This patch prevents possibility to give 1-1024 port range for autobinding.
{1, 1} may only takes some sense for deep embedded people.
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
--- ./net/ipv4/sysctl_net_ipv4.c.port2 2007-10-10 17:46:48.0 +0400
+++ ./net/ipv4/sysctl_net_ipv4.c
Fix incorrect HTB burst rate calculation in userspace when
clock and timer resolution differ. I guess this should go
in stable 2.6.22/23 as well.
[NET_SCHED]: Show timer resolution instead of clock resolution in
/proc/net/psched
The fourth parameter of /proc/net/psched is supposed to show the
Pavel Emelyanov wrote:
The list_head *tmp is used to help getting the first entry in
the ip6_frag_lru_list list. There is a simpler way to do it
The exact same code exists in ip_fragment.c and nf_conntrack_reasm.c,
please also change it there.
-
To unsubscribe from this list: send the line
Hi Dave:
Here's a few more clean-up's on the IPsec input/output path.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from
[IPSEC] esp: Remove NAT-T checksum invalidation for BEET
I pointed this out back when this patch was first proposed but it looks like
it got lost along the way.
The checksum only needs to be ignored for NAT-T in transport mode where
we lose the original inner addresses due to NAT. With BEET the
[IPSEC] beet: Fix extension header support on output
The beet output function completely kills any extension headers by replacing
them with the IPv6 header. This is because it essentially ignores the
result of ip6_find_1stfragopt by simply acting as if there aren't any
extension headers.
[IPSEC]: Set skb-data to payload in x-mode-output
This patch changes the calling convention so that on entry from
x-mode-output and before entry into x-type-output skb-data
will point to the payload instead of the IP header.
This is essentially a redistribution of skb_push/skb_pull calls
with
[IPSEC]: Get rid of ipv6_{auth,esp,comp}_hdr
This patch removes the duplicate ipv6_{auth,esp,comp}_hdr structures since
they're identical to the IPv4 versions. Duplicating them would only create
problems for ourselves later when we need to add things like extended
sequence numbers.
I've also
[IPSEC]: Move IP length/checksum setting out of transforms
This patch moves the setting of the IP length and checksum fields out of
the transforms and into the xfrmX_output functions. This would help future
efforts in merging the transforms themselves.
It also adds an optimisation to ipcomp due
[IPSEC]: Move IP protocol setting from transforms into xfrm4_input.c
This patch makes the IPv4 x-type-input functions return the next protocol
instead of setting it directly. This is identical to how we do things in
IPv6 and will help us merge common code on the input path.
Signed-off-by:
[IPSEC]: Use IPv6 calling convention as the convention for x-mode-output
The IPv6 calling convention for x-mode-output is more general and could
help an eventual protocol-generic x-type-output implementation. This
patch adopts it for IPv4 as well and modifies the IPv4 type output functions
Daniel Lezcano wrote:
struct net *net = in?in-nd_net:out-nd_net;
So, we are bound to the following options:
- perform additional non-uniform hacks around to place 'struct net' into
other and other structures like xt_target
- add 7th parameter here and over
- introduce an skb_net field in
Patrick McHardy wrote:
Pavel Emelyanov wrote:
The list_head *tmp is used to help getting the first entry in
the ip6_frag_lru_list list. There is a simpler way to do it
The exact same code exists in ip_fragment.c and nf_conntrack_reasm.c,
please also change it there.
Hm, indeed. But I see
The list_head *tmp is used to help getting the first entry in
the ip6_frag_lru_list list. There is a simpler way to do it.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c
index 31601c9..8fad98b 100644
--- a/net/ipv6/reassembly.c
Anton Arapov wrote:
So, now the way suggested by Denis looks reasonable.
What do you think?
If that's the case then you should fix __udp_lib_get_port() the same way.
Prevent division by zero in __udp_lib_get_port() when only one
unsecured port is available.
-Brian
Signed-off-by:
Hi,
From RFC 3493, Section 5.2:
IPV6_MULTICAST_IF
Set the interface to use for outgoing multicast packets. The
argument is the index of the interface to use. If the
interface index is specified as zero, the system selects the
interface (for example,
Pavel Emelyanov wrote:
Patrick McHardy wrote:
Pavel Emelyanov wrote:
The list_head *tmp is used to help getting the first entry in
the ip6_frag_lru_list list. There is a simpler way to do it
The exact same code exists in ip_fragment.c and nf_conntrack_reasm.c,
please also change it there.
On Wed, 10 Oct 2007 18:34:49 +0400
Denis V. Lunev [EMAIL PROTECTED] wrote:
This patch prevents possibility to give 1-1024 port range for autobinding.
{1, 1} may only takes some sense for deep embedded people.
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
---
We've done similar testing with ixgbe to push maximum descriptor counts,
and we lost performance very quickly in the same range you're quoting on
NIU.
Did you try it with WC writes to the ring or CLFLUSH?
-Andi
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a
On Tue, 09 Oct 2007, David Miller wrote:
From: jamal [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 17:56:46 -0400
if the h/ware queues are full because of link pressure etc, you drop. We
drop today when the s/ware queues are full. The driver txmit lock takes
place of the qdisc queue lock
Jay Vosburgh wrote:
David Miller [EMAIL PROTECTED] wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 20:56:35 -0400
Jeff Garzik wrote:
applied patches 1-9
the only thing that was a hiccup during submission is that your email
subject lines did not contain a notion of
pci_enable_device() is __must_check so do that in natsemi_resume().
Signed-off-by: Mark Brown [EMAIL PROTECTED]
---
drivers/net/natsemi.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index b881786..50e1ec6 100644
-Original Message-
From: Andi Kleen [mailto:[EMAIL PROTECTED]
Sent: Wednesday, October 10, 2007 9:02 AM
To: Waskiewicz Jr, Peter P
Cc: David Miller; [EMAIL PROTECTED]; [EMAIL PROTECTED];
[EMAIL PROTECTED]; [EMAIL PROTECTED];
[EMAIL PROTECTED]; [EMAIL PROTECTED];
[EMAIL
Stephen Hemminger wrote:
On Wed, 10 Oct 2007 18:34:49 +0400
Denis V. Lunev [EMAIL PROTECTED] wrote:
This patch prevents possibility to give 1-1024 port range for autobinding.
{1, 1} may only takes some sense for deep embedded people.
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
---
More complete version of local port range checking.
1. Enforce that low high when setting.
2. Use seqlock to ensure atomic update.
3. Add port randomization to SCTP. This is a new feature but
easier than maintaining old code that was broken if range
changed.
Signed-off-by: Stephen
On Wed, 10 Oct 2007 20:59:13 +0400
Denis V. Lunev [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
On Wed, 10 Oct 2007 18:34:49 +0400
Denis V. Lunev [EMAIL PROTECTED] wrote:
This patch prevents possibility to give 1-1024 port range for autobinding.
{1, 1} may only takes some sense
David Miller wrote:
From: Urs Thuermann [EMAIL PROTECTED]
Date: 09 Oct 2007 23:13:42 +0200
Last week I have sent another version of our patch series for PF_CAN.
The changes after the last review feedback were only cosmetics.
Do you have any plans with that code for this or the next
Stephen Hemminger wrote:
More complete version of local port range checking.
1. Enforce that low high when setting.
2. Use seqlock to ensure atomic update.
3. Add port randomization to SCTP. This is a new feature but
easier than maintaining old code that was broken if range
changed.
Hi Herbert,
CC [M] crypto/authenc.o
crypto/authenc.c: In function ‘crypto_authenc_hash’:
crypto/authenc.c:88: warning: ‘cryptlen’ may be used uninitialized in
this function
crypto/authenc.c:87: warning: ‘dst’ may be used uninitialized in this
function
crypto/authenc.c: In function
Pavel Emelyanov [EMAIL PROTECTED] writes:
I know there are several data structures internal to the kernel that
are indexed by ifindex, and not struct net_device *. There is the
iflink field in struct net_device. We need a way to refer to network
devices in other namespaces in rtnetlink in
I also ran a test for the code in the branch of 2.6.24 and found a problem.
I see that ifconfig down doesn't return (for IPoIB interfaces) and it's
stuck in napi_disable() in the kernel (any idea why?)
For what it's worth, I took the upstream 2.6.23 git tree and merged in
Dave's latest
On Tue, 2007-10-09 at 11:41 -0600, Eric W. Biederman wrote:
So please hold off on this until the kernel has been audited and
we have removed all of the uses of ifindex that assume ifindex is
global, that we can find.
I certainly have this assumption in the wireless code (cfg80211). How
would
Stephen Hemminger wrote:
int inet_csk_bind_conflict(const struct sock *sk,
const struct inet_bind_bucket *tb)
@@ -77,10 +90,11 @@ int inet_csk_get_port(struct inet_hashin
local_bh_disable();
if (!snum) {
- int low =
Denis V. Lunev [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Before I can enable rtnetlink to work in all network namespaces
I need to be certain that something won't break. So this
patch deliberately disables all of the rtnletlink methods in everything
except the initial network
Eliezer Tamir wrote:
The full patch is available at:
[EMAIL PROTECTED]://ftp1.broadcom.com/0001-BNX2X-0.40.10a-net-2.6.24.patch
Just when I thought I have beaten the line beast.
(or maybe it's just too much work and not enough sleep.)
the right links are of course:
ftp://[EMAIL
Johannes Berg [EMAIL PROTECTED] writes:
On Tue, 2007-10-09 at 11:41 -0600, Eric W. Biederman wrote:
So please hold off on this until the kernel has been audited and
we have removed all of the uses of ifindex that assume ifindex is
global, that we can find.
I certainly have this assumption
* Oliver Hartkopp | 2007-10-10 19:53:53 [+0200]:
CC [M] crypto/authenc.o
crypto/authenc.c: In function ?crypto_authenc_hash?:
crypto/authenc.c:88: warning: ?cryptlen? may be used uninitialized in this
function
crypto/authenc.c:87: warning: ?dst? may be used uninitialized in this
function
What about just checking for 0 in the later test?
if (val __dev_get_by_index(val) == NULL) {
...
+-DLS
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
The hack to use a socket and bind it to claim the port was just for
demostrating the idea. The correct solution, IMO, is to enhance the
core low level 4-tuple allocation services to be more generic (eg: not
be tied to a struct sock). Then the host tcp stack and the host rdma
stack can
David Stevens wrote:
What about just checking for 0 in the later test?
if (val __dev_get_by_index(val) == NULL) {
We could fail the next check right before that though:
if (sk-sk_bound_dev_if sk-sk_bound_dev_if != val)
goto e_inval;
I just mimicked what
Brian Haley [EMAIL PROTECTED] wrote on 10/10/2007 02:20:45 PM:
David Stevens wrote:
What about just checking for 0 in the later test?
if (val __dev_get_by_index(val) == NULL) {
We could fail the next check right before that though:
Right, the semantics there would be
This patch set adds a new property to make specifying QE clock sources
easier, adds a function to help parse the property, updates some other
functions to use an enum instead of an integer, and updates the ucc_geth
driver to take advantage of all this.
-
To unsubscribe from this list: send the
Add function qe_clock_source() which takes a string containing the name of a
QE clock source (as is typically found in device trees) and returns the
matching enum qe_clock value.
Update booting-without-of.txt to indicate that the UCC properties rx-clock
and tx-clock are deprecated and replaced
This patch updates the ucc_geth device driver to check the new rx-clock-name
and tx-clock-name properties first. If present, it uses the new function
qe_clock_source() to obtain the clock source. Otherwise, it checks the
deprecated rx-clock and tx-clock properties.
The device trees for 832x,
Sorry, please ignore this set. Something got screwed up with the patches.
I'm going to resend.
Timur Tabi wrote:
This patch set adds a new property to make specifying QE clock sources
easier, adds a function to help parse the property, updates some other
functions to use an enum instead of an
From: jamal [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 09:08:48 -0400
On Wed, 2007-10-10 at 03:44 -0700, David Miller wrote:
I've always gotten very poor results when increasing the TX queue a
lot, for example with NIU the point of diminishing returns seems to
be in the range of 256-512 TX
(Replaces all previous versions of this patch)
This patch set adds a new property to make specifying QE clock sources
easier, adds a function to help parse the property, updates some other
functions to use an enum instead of an integer, and updates the ucc_geth
driver to take advantage of all
Add function qe_clock_source() which takes a string containing the name of a
QE clock source (as is typically found in device trees) and returns the
matching enum qe_clock value.
Update booting-without-of.txt to indicate that the UCC properties rx-clock
and tx-clock are deprecated and replaced
This patch updates the ucc_geth device driver to check the new rx-clock-name
and tx-clock-name properties first. If present, it uses the new function
qe_clock_source() to obtain the clock source. Otherwise, it checks the
deprecated rx-clock and tx-clock properties.
The device trees for 832x,
From: Herbert Xu [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 22:40:10 +0800
[IPSEC] esp: Remove NAT-T checksum invalidation for BEET
I pointed this out back when this patch was first proposed but it looks like
it got lost along the way.
The checksum only needs to be ignored for NAT-T in
From: Herbert Xu [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 22:40:11 +0800
[IPSEC] beet: Fix extension header support on output
The beet output function completely kills any extension headers by replacing
them with the IPv6 header. This is because it essentially ignores the
result of
From: Herbert Xu [EMAIL PROTECTED]
Date: Wed, 10 Oct 2007 22:40:12 +0800
[IPSEC]: Set skb-data to payload in x-mode-output
This patch changes the calling convention so that on entry from
x-mode-output and before entry into x-type-output skb-data
will point to the payload instead of the IP
1 - 100 of 161 matches
Mail list logo
