Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread David Miller
From: Jens Axboe <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 08:46:21 +0100 > On Tue, Oct 30 2007, David Miller wrote: > > @@ -293,7 +293,7 @@ decryptor(struct scatterlist *sg, void *data) > > if (thislen == 0) > > return 0; > > > > - sg_mark_end(desc->frags, desc->fragno); > >

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread Jens Axboe
On Wed, Oct 31 2007, David Miller wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 08:32:07 +0100 > > > [SG] Remove __sg_mark_end() > > > > Make sg_mark_end() NOT overwrite the page link. Then it can be used > > after filling the sg table, which is what users want. That mean

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread Jens Axboe
On Tue, Oct 30 2007, David Miller wrote: > diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c > b/net/sunrpc/auth_gss/gss_krb5_crypto.c > index 91cd8f0..4a8aa94 100644 > --- a/net/sunrpc/auth_gss/gss_krb5_crypto.c > +++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c > @@ -211,8 +211,8 @@ encryptor(struct

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread David Miller
From: Jens Axboe <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 08:32:07 +0100 > [SG] Remove __sg_mark_end() > > Make sg_mark_end() NOT overwrite the page link. Then it can be used > after filling the sg table, which is what users want. That means that > __sg_mark_end() is no longer useful, so kill i

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread Jens Axboe
On Tue, Oct 30 2007, David Miller wrote: > > I just checked the following bug fix into net-2.6 > > Rusty, have a quick look at virtio_net wrt. the changes I > made to skb_to_sgvec()'s behavior. I think I might have > even fixed something :-) > > Jens, please review my commentary wrt. sg_mark_en

Re: [PATCH v2] using mii-bitbang on different processor ports

2007-10-30 Thread Sergej Stepanov
Am Dienstag, den 30.10.2007, 13:23 -0500 schrieb Scott Wood: > Sergej Stepanov wrote: > > + if( !of_address_to_resource(np, 1, &res[1])) { > > The spacing is still wrong. > > > - iounmap(bitbang->dir); > > + if ( bitbang->mdio.dir != bitbang->mdc.dir) > > + iounmap(bitbang->mdio.d

Re: [PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread David Miller
From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 16:24:52 +1100 > On PowerPC allmodconfig build we get this: > > net/key/af_key.c:400: warning: comparison is always false due to limited > range of data type > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> Applied, thank

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 17:06:32 +1100 > On Wednesday 31 October 2007 14:40:02 David Miller wrote: > > I just checked the following bug fix into net-2.6 > > > > Rusty, have a quick look at virtio_net wrt. the changes I > > made to skb_to_sgvec()'s behavior.

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread Rusty Russell
On Wednesday 31 October 2007 14:40:02 David Miller wrote: > I just checked the following bug fix into net-2.6 > > Rusty, have a quick look at virtio_net wrt. the changes I > made to skb_to_sgvec()'s behavior. I think I might have > even fixed something :-) Grr, the scatterlist changes are really

[PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread Stephen Rothwell
On PowerPC allmodconfig build we get this: net/key/af_key.c:400: warning: comparison is always false due to limited range of data type Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- net/key/af_key.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) This version gets rid of

Re: [PATCH 1/14 v2] nes: module and device initialization

2007-10-30 Thread Roland Dreier
> Thanks Roland. Let me know when you have your branch ready. OK, I pushed out a "neteffect" branch at git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git This has the driver from your git tree plus some compile fixes and cleanups (added as separate commits, so you can see

Re: [PATCH 00/33] Swap over NFS -v14

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 15:37, David Miller wrote: > From: Nick Piggin <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 14:26:32 +1100 > > > Is it really worth all the added complexity of making swap > > over NFS files work, given that you could use a network block > > device instead? > > Don't be

Re: [possibly OT] for_each_netdev() in 2.6.23-gitX / 2.6.24-rc1-gitY breaks Cisco VPN client

2007-10-30 Thread Stephen Hemminger
On Wed, 31 Oct 2007 01:35:47 +0100 "Alessandro Suardi" <[EMAIL PROTECTED]> wrote: > It's been a while I noticed, but I thought someone would as usual > cook up some fix, while I don't even see the issue been reported... > if this isn't a Linux kernel/net issue just drop my email, thanks. > > Er

Re: [PATCH 09/33] mm: system wide ALLOC_NO_WATERMARK

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Change ALLOC_NO_WATERMARK page allocation such that the reserves are system > wide - which they are per setup_per_zone_pages_min(), when we scrape the > barrel, do it properly. > IIRC it's actually not too uncommon to have allocations com

Re: [PATCH 06/33] mm: allow PF_MEMALLOC from softirq context

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Allow PF_MEMALLOC to be set in softirq context. When running softirqs from > a borrowed context save current->flags, ksoftirqd will have its own > task_struct. What's this for? Why would ksoftirqd pick up PF_MEMALLOC? (I guess that some

Re: [PATCH 04/33] mm: allow mempool to fall back to memalloc reserves

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Allow the mempool to use the memalloc reserves when all else fails and > the allocation context would otherwise allow it. I don't see what this is for. The whole point of when I fixed this to *not* use the memalloc reserves is because pro

Re: [patch 1/1][CORE] resend - fix free_netdev on register_netdev failure

2007-10-30 Thread Stephen Hemminger
On Tue, 30 Oct 2007 15:38:30 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Daniel Lezcano <[EMAIL PROTECTED]> > Date: Tue, 30 Oct 2007 17:19:26 +0100 > > > Point 1: > > The unregistering of a network device schedule a netdev_run_todo. > > This function calls dev->destructor when it

Re: [PATCH 05/33] mm: kmem_estimate_pages()

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Provide a method to get the upper bound on the pages needed to allocate > a given number of objects from a given kmem_cache. > Fair enough, but just to make it a bit easier, can you provide a little reason of why in this patch (or referen

Re: [PATCH 03/33] mm: slub: add knowledge of reserve pages

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Restrict objects from reserve slabs (ALLOC_NO_WATERMARKS) to allocation > contexts that are entitled to it. > > Care is taken to only touch the SLUB slow path. > > This is done to ensure reserve pages don't leak out and get consumed. I th

Re: [PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread David Miller
From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 15:34:22 +1100 > On Tue, 30 Oct 2007 21:08:46 -0700 (PDT) David Miller <[EMAIL PROTECTED]> > wrote: > > I think we should retain the check, but modify it so that GCC knows we > > understand that it's OK if it is always false. Perh

Re: [PATCH 00/33] Swap over NFS -v14

2007-10-30 Thread David Miller
From: Nick Piggin <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 14:26:32 +1100 > Is it really worth all the added complexity of making swap > over NFS files work, given that you could use a network block > device instead? Don't be misled. Swapping over NFS is just a scarecrow for the seemingly real

Re: [PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread Stephen Rothwell
On Tue, 30 Oct 2007 21:08:46 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > > I'm not so sure ifdef'ing things up all over the place is the way to > solve this. It makes the code ultra ugly. I agree. > I think we should retain the check, but modify it so that GCC knows we > understand tha

Re: [PATCH 00/33] Swap over NFS -v14

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Hi, > > Another posting of the full swap over NFS series. Hi, Is it really worth all the added complexity of making swap over NFS files work, given that you could use a network block device instead? Also, have you ensured that page_file

Re: [PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread David Miller
From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 14:59:54 +1100 > On PowerPC allmodconfig build we get this: > > net/key/af_key.c:400: warning: comparison is always false due to limited > range of data type > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> ... > > +

[PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread Stephen Rothwell
On PowerPC allmodconfig build we get this: net/key/af_key.c:400: warning: comparison is always false due to limited range of data type Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- net/key/af_key.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) -- Cheers, Stephen Rothw

[PATCH]: Fix IP1000 config dependencies.

2007-10-30 Thread David Miller
Noticed during some randconfig runs. [NET]: IP1000 driver needs MII. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- drivers/net/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 86b8641..895936a 100644 --- a/

Re: dev_ifname32() fails on 32->64bit calls in copy_in_user().

2007-10-30 Thread David Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 13:35:24 +1100 > [PATCH] Fix new dev_ifname32 returning -EFAULT > > A stray semicolon slipped in the patch that updated dev_ifname32 to > not be inline, causing it to always return -EFAULT. This fixes it. > > Signed-off-by:

[PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread David Miller
I just checked the following bug fix into net-2.6 Rusty, have a quick look at virtio_net wrt. the changes I made to skb_to_sgvec()'s behavior. I think I might have even fixed something :-) Jens, please review my commentary wrt. sg_mark_end() and it's nonintuitive behavior which led to these bug

Re: dev_ifname32() fails on 32->64bit calls in copy_in_user().

2007-10-30 Thread Benjamin Herrenschmidt
Bug is in the new dev_ifname32: uifr = compat_alloc_user_space(sizeof(struct ifreq)); if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32))); return -EFAULT; There's a stray ";" after the if statement, that was obviously not tested :-) This fixes it here

[PATCH 1/7] o80211s: Export dev_seq_{start,stop,next} symbols.

2007-10-30 Thread Luis Carlos Cobo
This is the first patch of a series starting mesh wireless support (802.11s) for wireless network cards with drivers using the mac80211 stack. It is still in an early stage of development but some functionality (static forwarding) is quite solid and we would like the code to be integrated in the k

Re: [PATCH] remove claim balance_rr won't reorder on many to one

2007-10-30 Thread Rick Jones
2- next worst is "balance-rr many slow" to "single fast", with the reordering rate generally being substantially lower than case #1 (it looked like your test showed about a 1% reordering rate, if I'm reading your data correctly). The percentage of reordering for TCP is likely capped by i

Re: [PATCH] remove claim balance_rr won't reorder on many to one

2007-10-30 Thread Rick Jones
Jay Vosburgh wrote: Rick Jones <[EMAIL PROTECTED]> wrote: I have to wonder if the full description of the different versions of being a little bit pregnant is worth it. Just saying that using balance-rr will result in reordering seems much more simple to comprehend. True, but the d

[possibly OT] for_each_netdev() in 2.6.23-gitX / 2.6.24-rc1-gitY breaks Cisco VPN client

2007-10-30 Thread Alessandro Suardi
It's been a while I noticed, but I thought someone would as usual cook up some fix, while I don't even see the issue been reported... if this isn't a Linux kernel/net issue just drop my email, thanks. Error message during cisco_vpn.ko build: /download/linux/net/vpnclient/interceptor.c:345:23: e

Re: [PATCH] remove claim balance_rr won't reorder on many to one

2007-10-30 Thread Jay Vosburgh
Rick Jones <[EMAIL PROTECTED]> wrote: >I have to wonder if the full description of the different versions of >being a little bit pregnant is worth it. Just saying that using >balance-rr will result in reordering seems much more simple to comprehend. True, but the different configuration

Re: [RFC 2/2] [IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.

2007-10-30 Thread Paul E. McKenney
On Tue, Oct 30, 2007 at 02:52:54PM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: Looks good from an RCU perspective. A couple questions below about hlist_for_each_entry_safe(). Thanx, Paul > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> >

Re: recent sysfs changes cause lots of network device errors

2007-10-30 Thread Rick Jones
Well, this was a bug that no one caught in -mm as we all seem to be running with CONFIG_SYSFS_DEPRECATED disabled. There was a long discussion on lkml last week, and here's the patch that should fix it that is going to Linus in a day or so (it's in my tree, but I'm supposed to be on vacation righ

Re: [PATCH] ehea: add kexec support

2007-10-30 Thread Michael Ellerman
On Tue, 2007-10-30 at 09:39 +0100, Christoph Raisch wrote: > > Michael Ellerman <[EMAIL PROTECTED]> wrote on 28.10.2007 23:32:17: > > > > > > How do you plan to support kdump? > > > > When kexec is fully supported kdump should work out of the box > as for any other ethernet card (if you load the

Re: recent sysfs changes cause lots of network device errors

2007-10-30 Thread Greg KH
On Tue, Oct 30, 2007 at 03:00:10PM -0700, Stephen Hemminger wrote: > It seems that the network device rename done by distro's > interacts badly with the code in device_rename() in 2.6.24 > (post -rc1). Network devices create sysfs entries where the sd->s_name is > just a pointer over to the actua

Re: [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface

2007-10-30 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 16:11:47 +0300 > One proc_net_create() user less. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Please make the corrections suggested in the feedback for this patch and resubmit. Thanks! - To unsubscribe from this list: s

Re: [patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove

2007-10-30 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 17:23:45 +0100 > The file /proc/net/if_inet6 is removed twice. > First time in: > inet6_exit > ->addrconf_cleanup > And followed a few lines after by: > inet6_exit > -> if6_proc_exit > > Sign

Re: [PATCH 2/2] Remove /proc/net/ip_vs_lblcr

2007-10-30 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 16:12:57 +0300 > It's under CONFIG_IP_VS_LBLCR_DEBUG option which never existed. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: [patch 1/1][NETNS] resend: fix net released by rcu callback

2007-10-30 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 17:21:40 +0100 > When a network namespace reference is held by a network subsystem, > and when this reference is decremented in a rcu update callback, we > must ensure that there is no more outstanding rcu update before > trying to f

Re: [patch 1/1][CORE] resend - fix free_netdev on register_netdev failure

2007-10-30 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 17:19:26 +0100 > Point 1: > The unregistering of a network device schedule a netdev_run_todo. > This function calls dev->destructor when it is set and the > destructor calls free_netdev. > > Point 2: > In the case of an initializatio

Re: [patch 1/1][NETNS] resend: fix net released by rcu callback

2007-10-30 Thread Eric W. Biederman
Daniel Lezcano <[EMAIL PROTECTED]> writes: > Yes, I had this problem when doing ipv6 isolation for netns49. The ipv6 > subsystem creation failed and the different subsystem where rollbacked in the > setup_net function. > When the network namespace was about to be freed in free_net function, I had

Re: [PATCH] remove claim balance_rr won't reorder on many to one

2007-10-30 Thread Rick Jones
Jay Vosburgh wrote: Rick Jones <[EMAIL PROTECTED]> wrote: [...] - Note that this out of order delivery occurs when both the - sending and receiving systems are utilizing a multiple - interface bond. Consider a configuration in which a - balance-rr bond feeds into a sing

recent sysfs changes cause lots of network device errors

2007-10-30 Thread Stephen Hemminger
It seems that the network device rename done by distro's interacts badly with the code in device_rename() in 2.6.24 (post -rc1). Network devices create sysfs entries where the sd->s_name is just a pointer over to the actual buffer in the netdevice. Prior to calling device_rename, the code in de

Re: Bonding in active-backup mode with arp monitoring on Xen

2007-10-30 Thread Jay Vosburgh
Tsutomu Fujii <[EMAIL PROTECTED]> wrote: [...] >The network structure is the following. > >+---+ >|virtual I/F(eth0) | <- have IP address. >+---+ >| virtual bridge(xenbr0) | >+---+ >| bon

Re: [PATCH] net: Saner thash_entries default with much memory

2007-10-30 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 21:42:05 +0100 > I still have my doubts it makes sense to have an own lock for each bucket. It > would be probably better to just divide the hash value through a factor > again and then use that to index a smaller lock only table. Yes,

Re: [patch 1/1][NETNS] resend: fix net released by rcu callback

2007-10-30 Thread Daniel Lezcano
Eric W. Biederman wrote: Daniel Lezcano <[EMAIL PROTECTED]> writes: When a network namespace reference is held by a network subsystem, and when this reference is decremented in a rcu update callback, we must ensure that there is no more outstanding rcu update before trying to free the network

Re: [PATCH 23/33] netvm: skb processing

2007-10-30 Thread Peter Zijlstra
On Tue, 2007-10-30 at 14:26 -0700, Stephen Hemminger wrote: > On Tue, 30 Oct 2007 17:04:24 +0100 > Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > In order to make sure emergency packets receive all memory needed to proceed > > ensure processing of emergency SKBs happens under PF_MEMALLOC. > > >

Re: [PATCH 23/33] netvm: skb processing

2007-10-30 Thread Stephen Hemminger
On Tue, 30 Oct 2007 17:04:24 +0100 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > In order to make sure emergency packets receive all memory needed to proceed > ensure processing of emergency SKBs happens under PF_MEMALLOC. > > Use the (new) sk_backlog_rcv() wrapper to ensure this for backlog proces

Re: [PATCH] net: Saner thash_entries default with much memory

2007-10-30 Thread David Miller
From: Jean Delvare <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 14:18:27 +0100 > OK, let's go with (512 * 1024) then. Want me to send an updated patch? Why submit a patch that's already in Linus's tree :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [PATCH] remove claim balance_rr won't reorder on many to one

2007-10-30 Thread Jay Vosburgh
Rick Jones <[EMAIL PROTECTED]> wrote: [...] >- Note that this out of order delivery occurs when both the >- sending and receiving systems are utilizing a multiple >- interface bond. Consider a configuration in which a >- balance-rr bond feeds into a single higher capacity netwo

Re: [patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove

2007-10-30 Thread Eric W. Biederman
Daniel Lezcano <[EMAIL PROTECTED]> writes: > The file /proc/net/if_inet6 is removed twice. > First time in: > inet6_exit > ->addrconf_cleanup > And followed a few lines after by: > inet6_exit > -> if6_proc_exit > > Signed-off-by: Daniel Lezcano <[EMAIL PRO

Re: [patch 1/1][NETNS] resend: fix net released by rcu callback

2007-10-30 Thread Eric W. Biederman
Daniel Lezcano <[EMAIL PROTECTED]> writes: > When a network namespace reference is held by a network subsystem, > and when this reference is decremented in a rcu update callback, we > must ensure that there is no more outstanding rcu update before > trying to free the network namespace. > > In th

Re: [2.6 patch] fix drivers/net/wan/lmc/ compilation

2007-10-30 Thread Roel Kluin
Adrian Bunk wrote: > Documentation/SubmitChecklist, point 1: > > <-- snip --> > > ... > CC drivers/net/wan/lmc/lmc_main.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In > function ‘lmc_ioctl’: > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wa

Re: [PATCH] net: Saner thash_entries default with much memory

2007-10-30 Thread Andi Kleen
> Next, machines that service that many sockets typically have them > mostly with full transmit queues talking to a very slow receiver at > the other end. Not sure -- there are likely use cases with lots of idle but connected sockets. Also the constraint here is not really how many sockets are

[2.6 patch] fix drivers/net/wan/lmc/ compilation

2007-10-30 Thread Adrian Bunk
Documentation/SubmitChecklist, point 1: <-- snip --> ... CC drivers/net/wan/lmc/lmc_main.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In function ‘lmc_ioctl’: /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c:239: error: expected ex

[PATCH] remove claim balance_rr won't reorder on many to one

2007-10-30 Thread Rick Jones
Remove the text which suggests that many balance_rr links feeding into a single uplink will not experience packet reordering. More up-to-date tests, with 1G links feeding into a switch with a 10G uplink, using a 2.6.23-rc8 kernel on the system on which the 1G links were bonded with balance_rr (mod

Re: [PATCH] ixgb: fix TX hangs under heavy load

2007-10-30 Thread Andy Gospodarek
On Tue, Oct 30, 2007 at 11:21:50AM -0700, Auke Kok wrote: > A merge error occurred where we merged the wrong block here > in version 1.0.120. The right condition for frags is slightly > different then for the skb, so account for the difference properly > and trim the TSO based size right. > > Orig

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

2007-10-30 Thread Brian Haley
Aurélien Charbon wrote: Here is a second missing part of the IPv6 support in NFS server code concerning knfd syscall interface. It updates write_getfd and write_getfd to accept IPv6 addresses. Applies on a kernel including ip_map cache modifications Both patches still have bugs, I think the p

Re: [PATCH 1/2] NFS: change the ip_map cache code to handle IPv6 addresses

2007-10-30 Thread J. Bruce Fields
Thanks for working on this. Could you run linux/scripts/checkpatch.pl on your patch and fix the problems it complains about? On Tue, Oct 30, 2007 at 06:05:42PM +0100, Aurélien Charbon wrote: > static void update(struct cache_head *cnew, struct cache_head *citem) > { > @@ -149,22 +157,24 @@ static

[git patches] net driver fixes

2007-10-30 Thread Jeff Garzik
Fixes, and a new DM9601 USB NIC id. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/bfin_mac.c|2 - drivers/net/e1000/e1000.h |8 +++ dri

[PATCH v2] using mii-bitbang on different processor ports

2007-10-30 Thread Sergej Stepanov
The patch makes possible to have mdio and mdc pins on different physical ports also for CONFIG_PPC_CPM_NEW_BINDING. To setup it in the device tree: reg = <10d40 14 10d60 14>; // mdc: 0x10d40, mdio: 0x10d60 or reg = <10d40 14>; // mdc and mdio have the same offset 10d40 The approach was taken from o

netdev@vger.kernel.org

2007-10-30 Thread Jeff Garzik
Auke Kok wrote: From: Roel Kluin <[EMAIL PROTECTED]> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/82571.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000

Re: [PATCH] ixgb: fix TX hangs under heavy load

2007-10-30 Thread Jeff Garzik
Auke Kok wrote: A merge error occurred where we merged the wrong block here in version 1.0.120. The right condition for frags is slightly different then for the skb, so account for the difference properly and trim the TSO based size right. Originally part of a fix reported by IBM to fix TSO hang

Re: [PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines

2007-10-30 Thread Jeff Garzik
Dale Farnsworth wrote: On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote: This commit made an incorrect assumption: -- Author: Lennert Buytenhek <[EMAIL PROTECTED]> Date: Fri Oct 19 04:10:10 2007 +0200 mv643xx_eth: Move ethernet register definitions into private header

Re: [PATCH 4/4] ixgbe: minor sparse fixes

2007-10-30 Thread Jeff Garzik
Auke Kok wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Make strings const if possible, and fix includes so forward definitions are seen. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgbe/ixgbe.h |2 +- drivers

Re: [PATCH 1/1] Blackfin EMAC driver: Fix Ethernet communication bug (dupliated and lost packets)

2007-10-30 Thread Jeff Garzik
Bryan Wu wrote: From: Michael Hennerich <[EMAIL PROTECTED]> Fix Ethernet communication bug(dupliated and lost packets) in RMII PHY mode- dont call mac_disable and mac_enable during 10/100 REFCLK changes - mac_enable screws up the DMA descriptor chain Signed-off-by: Michael Hennerich <[EMAIL PRO

Re: [PATCH] DM9601: Support for ADMtek ADM8515 NIC

2007-10-30 Thread Jeff Garzik
Peter Korsgaard wrote: Add device ID for the ADMtek ADM8515 USB NIC to the DM9601 driver. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:

Re: [PATCH v2] using mii-bitbang on different processor ports

2007-10-30 Thread Scott Wood
Sergej Stepanov wrote: + if( !of_address_to_resource(np, 1, &res[1])) { The spacing is still wrong. - iounmap(bitbang->dir); + if ( bitbang->mdio.dir != bitbang->mdc.dir) + iounmap(bitbang->mdio.dir); + iounmap(bitbang->mdc.dir); And here. -Scott - To

[PATCH] ixgb: fix TX hangs under heavy load

2007-10-30 Thread Auke Kok
A merge error occurred where we merged the wrong block here in version 1.0.120. The right condition for frags is slightly different then for the skb, so account for the difference properly and trim the TSO based size right. Originally part of a fix reported by IBM to fix TSO hangs on pSeries hardw

[PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

2007-10-30 Thread Aurélien Charbon
Here is a second missing part of the IPv6 support in NFS server code concerning knfd syscall interface. It updates write_getfd and write_getfd to accept IPv6 addresses. Applies on a kernel including ip_map cache modifications Tests: tested with only IPv4 network and basic nfs ops (mount, file

[PATCH 1/2] NFS: change the ip_map cache code to handle IPv6 addresses

2007-10-30 Thread Aurélien Charbon
Hi, Here is the IPv6 support patch for the ip_map caching code part in nfs server. I have ported it on 2.6.24-rc1 (in which Brian Haley's ipv6_addr_v4mapped function is included) In case of bad formatting due to my mailer, you can also find the patch in attachment. Tests: tested with onl

[patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove

2007-10-30 Thread Daniel Lezcano
The file /proc/net/if_inet6 is removed twice. First time in: inet6_exit ->addrconf_cleanup And followed a few lines after by: inet6_exit -> if6_proc_exit Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/ipv6/addrconf.c |4 1 file changed

[patch 1/1][NETNS] resend: fix net released by rcu callback

2007-10-30 Thread Daniel Lezcano
When a network namespace reference is held by a network subsystem, and when this reference is decremented in a rcu update callback, we must ensure that there is no more outstanding rcu update before trying to free the network namespace. In the normal case, the rcu_barrier is called when the netwo

[patch 1/1][CORE] resend - fix free_netdev on register_netdev failure

2007-10-30 Thread Daniel Lezcano
Point 1: The unregistering of a network device schedule a netdev_run_todo. This function calls dev->destructor when it is set and the destructor calls free_netdev. Point 2: In the case of an initialization of a network device the usual code is: * alloc_netdev * register_netdev -> if this one

Re: [PATCH 2.6.24] ixgb: TX hangs under heavy load

2007-10-30 Thread Kok, Auke
Andy Gospodarek wrote: > Auke, > > It has become clear that this patch resolves some tx-lockups on the ixgb > driver. IBM did some checking and realized this hunk is in your > sourceforge driver, but not anywhere else. Mind if we add it? I'll quickly double check where this came from in the fi

[PATCH 09/33] mm: system wide ALLOC_NO_WATERMARK

2007-10-30 Thread Peter Zijlstra
Change ALLOC_NO_WATERMARK page allocation such that the reserves are system wide - which they are per setup_per_zone_pages_min(), when we scrape the barrel, do it properly. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- mm/page_alloc.c |6 ++ 1 file changed, 6 insertions(+) Index:

[PATCH 04/33] mm: allow mempool to fall back to memalloc reserves

2007-10-30 Thread Peter Zijlstra
Allow the mempool to use the memalloc reserves when all else fails and the allocation context would otherwise allow it. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- mm/mempool.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) Index: linux-2.6/mm/mempool.c ==

[PATCH 06/33] mm: allow PF_MEMALLOC from softirq context

2007-10-30 Thread Peter Zijlstra
Allow PF_MEMALLOC to be set in softirq context. When running softirqs from a borrowed context save current->flags, ksoftirqd will have its own task_struct. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/linux/sched.h |4 kernel/softirq.c |3 +++ mm/page_alloc.c

[PATCH 12/33] selinux: tag avc cache alloc as non-critical

2007-10-30 Thread Peter Zijlstra
Failing to allocate a cache entry will only harm performance not correctness. Do not consume valuable reserve pages for something like that. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> --- security/selinux/avc.c |2 +- 1 file changed, 1 inserti

[PATCH 31/33] nfs: enable swap on NFS

2007-10-30 Thread Peter Zijlstra
Provide an a_ops->swapfile() implementation for NFS. This will set the NFS socket to SOCK_MEMALLOC and run socket reconnect under PF_MEMALLOC as well as reset SOCK_MEMALLOC before engaging the protocol ->connect() method. PF_MEMALLOC should allow the allocation of struct socket and related objects

[PATCH 33/33] nfs: do not warn on radix tree node allocation failures

2007-10-30 Thread Peter Zijlstra
GFP_ATOMIC failures are rather common, no not warn about them. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- fs/nfs/inode.c |2 +- fs/nfs/write.c | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) Index: linux-2.6/fs/nfs/inode.c ==

[PATCH 27/33] nfs: remove mempools

2007-10-30 Thread Peter Zijlstra
With the introduction of the shared dirty page accounting in .19, NFS should not be able to surpise the VM with all dirty pages. Thus it should always be able to free some memory. Hence no more need for mempools. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- fs/nfs/read.c | 15 +++-

[PATCH 29/33] nfs: disable data cache revalidation for swapfiles

2007-10-30 Thread Peter Zijlstra
Do as Trond suggested: http://lkml.org/lkml/2006/8/25/348 Disable NFS data cache revalidation on swap files since it doesn't really make sense to have other clients change the file while you are using it. Thereby we can stop setting PG_private on swap pages, since there ought to be no further

[PATCH 00/33] Swap over NFS -v14

2007-10-30 Thread Peter Zijlstra
Hi, Another posting of the full swap over NFS series. [ I tried just posting the first part last time around, but that just gets more confusion by lack of a general picture ] [ patches against 2.6.23-mm1, also to be found online at: http://programming.kicks-ass.net/kernel-patches/vm_deadlo

[PATCH 14/33] net: packet split receive api

2007-10-30 Thread Peter Zijlstra
Add some packet-split receive hooks. For one this allows to do NUMA node affine page allocs. Later on these hooks will be extended to do emergency reserve allocations for fragments. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |8 ++-- drivers/net/

[PATCH 11/33] mm: memory reserve management

2007-10-30 Thread Peter Zijlstra
Generic reserve management code. It provides methods to reserve and charge. Upon this, generic alloc/free style reserve pools could be build, which could fully replace mempool_t functionality. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/linux/reserve.h | 54 + mm/Makefil

[PATCH 21/33] netvm: prevent a TCP specific deadlock

2007-10-30 Thread Peter Zijlstra
It could happen that all !SOCK_MEMALLOC sockets have buffered so much data that we're over the global rmem limit. This will prevent SOCK_MEMALLOC buffers from receiving data, which will prevent userspace from running, which is needed to reduce the buffered data. Fix this by exempting the SOCK_MEMA

[PATCH 07/33] mm: serialize access to min_free_kbytes

2007-10-30 Thread Peter Zijlstra
There is a small race between the procfs caller and the memory hotplug caller of setup_per_zone_pages_min(). Not a big deal, but the next patch will add yet another caller. Time to close the gap. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- mm/page_alloc.c | 16 +--- 1 file

[PATCH 18/33] netvm: INET reserves.

2007-10-30 Thread Peter Zijlstra
Add reserves for INET. The two big users seem to be the route cache and ip-fragment cache. Reserve the route cache under generic RX reserve, its usage is bounded by the high reclaim watermark, and thus does not need further accounting. Reserve the ip-fragement caches under SKB data reserve, thes

[PATCH 03/33] mm: slub: add knowledge of reserve pages

2007-10-30 Thread Peter Zijlstra
Restrict objects from reserve slabs (ALLOC_NO_WATERMARKS) to allocation contexts that are entitled to it. Care is taken to only touch the SLUB slow path. This is done to ensure reserve pages don't leak out and get consumed. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/linux/slu

[PATCH 15/33] net: sk_allocation() - concentrate socket related allocations

2007-10-30 Thread Peter Zijlstra
Introduce sk_allocation(), this function allows to inject sock specific flags to each sock related allocation. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/net/sock.h|7 ++- net/ipv4/tcp_output.c | 11 ++- net/ipv6/tcp_ipv6.c | 14 +- 3 files

[PATCH 23/33] netvm: skb processing

2007-10-30 Thread Peter Zijlstra
In order to make sure emergency packets receive all memory needed to proceed ensure processing of emergency SKBs happens under PF_MEMALLOC. Use the (new) sk_backlog_rcv() wrapper to ensure this for backlog processing. Skip taps, since those are user-space again. Signed-off-by: Peter Zijlstra <[E

[PATCH 25/33] mm: add support for non block device backed swap files

2007-10-30 Thread Peter Zijlstra
A new addres_space_operations method is added: int swapfile(struct address_space *, int) When during sys_swapon() this method is found and returns no error the swapper_space.a_ops will proxy to sis->swap_file->f_mapping->a_ops. The swapfile method will be used to communicate to the address_spa

[PATCH 01/33] mm: gfp_to_alloc_flags()

2007-10-30 Thread Peter Zijlstra
Factor out the gfp to alloc_flags mapping so it can be used in other places. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- mm/internal.h | 11 ++ mm/page_alloc.c | 98 2 files changed, 67 insertions(+), 42 deletions(-) In

[PATCH 20/33] netvm: filter emergency skbs.

2007-10-30 Thread Peter Zijlstra
Toss all emergency packets not for a SOCK_MEMALLOC socket. This ensures our precious memory reserve doesn't get stuck waiting for user-space. The correctness of this approach relies on the fact that networks must be assumed lossy. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/net

[PATCH 10/33] mm: __GFP_MEMALLOC

2007-10-30 Thread Peter Zijlstra
__GFP_MEMALLOC will allow the allocation to disregard the watermarks, much like PF_MEMALLOC. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/linux/gfp.h |3 ++- mm/page_alloc.c |4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) Index: linux-2.6/include/linux/gfp

[PATCH 19/33] netvm: hook skb allocation to reserves

2007-10-30 Thread Peter Zijlstra
Change the skb allocation api to indicate RX usage and use this to fall back to the reserve when needed. SKBs allocated from the reserve are tagged in skb->emergency. Teach all other skb ops about emergency skbs and the reserve accounting. Use the (new) packet split API to allocate and track frag

  1   2   >