Re: [PATCH] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 04:09:43PM +0300, Pavel Emelyanov wrote: > The following race is possible when one cpu unregisters the handler > while other one is trying to receive a message and call this one: Good catch! But I think we need a bit more to close this fully. Dumps can resume asynchronousl

Re: [PATCH][UNIX] EOF on non-blocking SOCK_SEQPACKET

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 09:33:23AM +, Florian Zumbiehl wrote: > > I am not absolutely sure whether this actually is a bug (as in: I've got > no clue what the standards say or what other implementations do), but at > least I was pretty surprised when I noticed that a recv() on a > non-blocking

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 10:56:48AM +, Gerrit Renker wrote: > > | - InDatagrams: Total number of received datagrams. > | + InDatagrams: The total number of UDP datagrams delivered to UDP > users. > You are in the UDP-Lite documentation -- it should read "UDP-Lite", not UDP. We coul

Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 04:02:19PM +0900, Joonwoo Park wrote: > > [NET]: Fix TX bug VLAN in VLAN > Fix misbehavior of vlan_dev_hard_start_xmit() for recursive encapsulations. > > Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> Applied to net-2.6. Thanks! -- Visit Openswan at http://www.openswa

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.5)

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 07:54:59PM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > > I've fixed up those errors. OK, patch applied to net-2.6.25. Thanks everyone! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbe

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Gerrit Renker
Thank you for doing this work, there is a small comment below. | --- linux-2.6.24.rc3.org/Documentation/networking/udplite.txt 2007-11-19 12:37:40.0 +0800 | +++ linux-2.6.24.rc3/Documentation/networking/udplite.txt 2007-11-28 18:35:29.0 +0800 | @@ -236,7 +236,7 @@ | |Th

Re: [PATCH] sungem: fix napi regression with reset work

2007-11-29 Thread Herbert Xu
On Mon, Nov 26, 2007 at 09:02:08PM +0100, Johannes Berg wrote: > sungem's gem_reset_task() will unconditionally try to disable NAPI even > when it's called while the interface is not operating and hence the NAPI > struct isn't enabled. Make napi_disable() depend on gp->running. > > Also removes a

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.5)

2007-11-29 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 29 Nov 2007 21:29:40 +1100), Herbert Xu <[EMAIL PROTECTED]> says: > On Mon, Nov 26, 2007 at 05:16:16PM +, Templin, Fred L wrote: > > From: Fred L. Templin <[EMAIL PROTECTED]> > > > > This patch includes support for the Intra-Site Automatic Tunnel > > A

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 06:33:01PM +0800, Wang Chen wrote: > > I cooked the patch based on Andi's and left the new counter. > Frankly, I don't like the EarlyDatagrams too. > So, I will remove it and resubmit. Sounds good. Thanks for all your efforts on this problem! -- Visit Openswan at http://w

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Wang Chen
Herbert Xu said the following on 2007-11-29 18:21: > On Thu, Nov 29, 2007 at 06:08:30PM +0800, Wang Chen wrote: >> Add a new UdpInEarlyDatagrams counter to count datagrams received early, >> but which might be dropped later. > > Could you please split this into two patches? Have one do the > UdpIn

Re: [PATCH] XFRM: SPD auditing fix to include the netmask/prefix-length

2007-11-29 Thread Herbert Xu
On Mon, Nov 26, 2007 at 07:55:12PM +, Paul Moore wrote: > Currently the netmask/prefix-length of an IPsec SPD entry is not included in > any of the SPD related audit messages. This can cause a problem when the > audit log is examined as the netmask/prefix-length is vital in determining > what

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.5)

2007-11-29 Thread Herbert Xu
On Mon, Nov 26, 2007 at 05:16:16PM +, Templin, Fred L wrote: > From: Fred L. Templin <[EMAIL PROTECTED]> > > This patch includes support for the Intra-Site Automatic Tunnel > Addressing Protocol (ISATAP) per RFC4214. It uses the SIT > module, and is configured using extensions to the "iproute2

Re: [PATCH 2/2] Eliminate unused argument from sk_stream_alloc_pskb

2007-11-29 Thread Herbert Xu
On Mon, Nov 26, 2007 at 08:17:27PM +0300, Pavel Emelyanov wrote: > The 3rd argument is always zero (according to grep :) Eliminate > it and merge the function with sk_stream_alloc_skb. > > This saves 44 more bytes, and together with the previous patch > we have: > > add/remove: 1/0 grow/shrink: 0

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-29 Thread Arnd Bergmann
On Thursday 29 November 2007, Andi Kleen wrote: > > I think it would be good if you could specify a default namespace > > per module, that could reduce the amount of necessary changes significantly. > > But also give less documentation. It's also not that difficult to mark > the exports once. I've

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 06:08:30PM +0800, Wang Chen wrote: > > Add a new UdpInEarlyDatagrams counter to count datagrams received early, > but which might be dropped later. Could you please split this into two patches? Have one do the UdpInDatagrams change and the other to introduce the EarlyDatag

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Wang Chen
Herbert Xu said the following on 2007-11-29 17:21: > On Thu, Nov 29, 2007 at 03:55:38PM +0800, Wang Chen wrote: > > Excellent. They now do a recvmsg first with no buffer to get > meta-information, which just happens to increment the counters. > > Could you please resubmit the patch then? > [SN

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-29 Thread Andi Kleen
> I think it would be good if you could specify a default namespace > per module, that could reduce the amount of necessary changes significantly. But also give less documentation. It's also not that difficult to mark the exports once. I've forward ported such patches over a few kernels and didn'

[NET 01/02]: Move netfilter checksum helpers to net/core/utils.c

2007-11-29 Thread Patrick McHardy
[NET]: Move netfilter checksum helpers to net/core/utils.c This allows to get rid of the CONFIG_NETFILTER dependency of NET_ACT_NAT. This patch redefines the old names to keep the noise low, the next patch converts all users. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 01879e49

[NETFILTER 02/02]: Convert old checksum helper names

2007-11-29 Thread Patrick McHardy
[NETFILTER]: Convert old checksum helper names Kill the defines again, convert to the new checksum helper names and remove the dependency of NET_ACT_NAT on NETFILTER. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit da8ffc485b6e8e429c51f7f1c03a0ae824eca848 tree 2198c531b224c82e74b66

[NET 00/02]: Remove NET_ACT_NAT dependency on NETFILTER

2007-11-29 Thread Patrick McHardy
These patches remove the dependency of NET_ACT_NAT on NETFILTER by moving the netfilter checksum helpers to include/net/checksum and net/core/utils.c. I didn't find more appropriate locations, but I'd happily change it if someone suggests something better. include/linux/netfilter.h

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-29 Thread Arnd Bergmann
On Thursday 22 November 2007, Andi Kleen wrote: >  #define EXPORT_SYMBOL(sym) \ > -   __EXPORT_SYMBOL(sym, "") > +   __EXPORT_SYMBOL(sym, "",,, NULL) >   >  #define EXPORT_SYMBOL_GPL(sym) \ > -   __EXPORT_SYMBOL(sym, "_

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 03:55:38PM +0800, Wang Chen wrote: > > I tested nfsv3 & nfsv4. It seems that nfs calls recvmsg() like > following:nfsd()->svc_recv()->svc_udp_recvfrom()->udp_recvmsg(). > So, I think putting the udpInDatagrams increment in udp_recvmsg() > is enough. > > FYI: > http://www.m

<    1   2