[IPV4] Thresholds in fib_trie.c are used as consts, so make them const.
There are several thresholds for trie fib hash management. They are used
in the code as a constants. Make them constants from the compiler point of
view.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
diff --git a/net/
Hi,
I generated this patch for linux 2.6.24-rc5 and test it on AT91SAM9263
with iperf.
From: Gregory CLEMENT <[EMAIL PROTECTED]>
Date: Wed, 12 Dec 2007 18:10:14 +0100
Subject: [PATCH] MACB: clear transmit buffers properly on TX Underrun
Initially transmit buffer pointers were only reset. But b
Christian Borntraeger wrote:
Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor:
> Christian Borntraeger wrote:
> >
> > Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor:
> > > --- a/drivers/net/virtio_net.c
> > > +++ b/drivers/net/virtio_net.c
> > > @@ -406,10 +405,10 @@ again:
> >
> > Hmm, while I
Hi Francois,
Francois Romieu a écrit :
> Thanks, I have split it in parts. The serie should be available shortly at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git r6040
You are welcome, thank you for taking care of this driver !
>
> Please note that:
> 1. TIMER_WUT ha
WARNING: vmlinux.o(.init.text+0x1cfc4): Section mismatch: reference to
.exit.text:tcpv6_exit (between 'inet6_init' and 'ac6_proc_init')
WARNING: vmlinux.o(.init.text+0x1cfc9): Section mismatch: reference to
.exit.text:udplitev6_exit (between 'inet6_init' and 'ac6_proc_init')
WARNING: vmlinux.o(.i
2007/12/12, Joonwoo Park <[EMAIL PROTECTED]>:
> [NETDEV]: e1000 Fix possible causing oops of net_rx_action
> returning work_done == weight as true after calling netif_rx_complete will
> cause oops in net_rx_action.
>
I tried two types of patches for oops and ifconfig down hang for e1000 first.
J
Andrew Morton wrote:
WARNING: vmlinux.o(.init.text+0x1cfc4): Section mismatch: reference to
.exit.text:tcpv6_exit (between 'inet6_init' and 'ac6_proc_init')
WARNING: vmlinux.o(.init.text+0x1cfc9): Section mismatch: reference to
.exit.text:udplitev6_exit (between 'inet6_init' and 'ac6_proc_init'
Subject: fix section mismatch warnings
From: Daniel Lezcano <[EMAIL PROTECTED]>
Removed useless and buggy __exit section in the different
ipv6 subsystems. Otherwise they will be called inside an
init section during rollbacking in case of an error in the
protocol initialization.
Signed-off-by:
The _find calls calculate the hash value using the
xfrm_state_hmask, without the xfrm_state_lock. But the
value of this mask can change in the _resize call under
the state_lock, so we risk to fail in finding the desired
entry in hash.
I think, that the hash value is better to calculate
under th
On 13-12-2007 03:49, Herbert Xu wrote:
> On Thu, Dec 13, 2007 at 09:58:56AM +0800, Herbert Xu wrote:
>> [IPSEC]: Fix reversed ICMP6 policy check
>
> While that won't crash anymore, it's still logically wrong.
>
> Here's a more complete fix.
...even more than this!
Since more than a year each ti
* Joerg Pommnitz <[EMAIL PROTECTED]> 2007-12-11 06:52
> I think the leak comes from addr_msg_parser. The newly created address object
> gets added to the cache with nl_cache_add wich takes a reference, so the
> reference in addr_msg_parser should be dropped, e.g. the following patch
> might be c
On Thu, 13 Dec 2007 08:51:57 +0100
Gregory CLEMENT <[EMAIL PROTECTED]> wrote:
> Hi,
> I generated this patch for linux 2.6.24-rc5 and test it on AT91SAM9263
> with iperf.
>
> From: Gregory CLEMENT <[EMAIL PROTECTED]>
> Date: Wed, 12 Dec 2007 18:10:14 +0100
> Subject: [PATCH] MACB: clear transmit
Do you think we can improve upon our own LTP-KDUMP test cases housed
here:
http://ltp.cvs.sourceforge.net/ltp/ltp/testcases/kdump/,
because of your changes below:
--Subrata
On Wed, 2007-12-12 at 17:53 +0100, Thomas Klein wrote:
> This patch adds kdump support using the new PPC crash shutdown hoo
> > This cleans up the frame receive handling. After this patch
> > * EAPOL frames addressed to us or the EAPOL group address are
> >always accepted regardless of whether they are encrypted or not
>
> why? userspace (wap_supplicant) tryes to control this depending on the
> network settings.
Hi,
Here is a set of updates for PS3 gelic network driver.
This patch set requires other patches which were already submitted by
Geert (http://marc.info/?l=linux-kernel&m=119626095605487).
[1] PS3: gelic: Fix the wrong dev_id passed
[2] PS3: gelic: Add endianness macros
PS3: gelic: Fix the wrong dev_id passed
The device id for lv1_net_set_interrupt_status_indicator() would be wrong.
This path would be invoked only in the case of the initialization failure.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c |2 +-
1 file chang
PS3: gelic: remove duplicated ethtool handers
Remove some ethtool handers, which the common ethtool handlers already has
in functionality
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c | 43 +++
1 file changed, 3 inser
PS3: gelic: add support for port link status
Add support for interrupt driven port link status detection.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c | 77
drivers/net/ps3_gelic_net.h |2 +
2 files changed,
PS3: gelic: Add support for dual network interface
Add support for dual network (net_device) interface so that ethernet
and wireless can own separate ethX interface.
- Export functions which are convenience for both interfaces
- Move irq allocation/release code to driver probe/remove handlers
PS3: gelic: code cleanup
Code cleanup:
- Use appropriate prefixes of names instead of fixed 'gelic_net'
so that objects of the functions, variables and constants can be esitimate.
- Remove definitions for IPSec offload of the gelic hardware. This
functionality is never supported in PS3.
PS3: gelic: Add endianness macros
Mark the members of the structure for DMA descriptor proper endian
and use appropriate accessor macros.
As gelic driver works only on PS3, all these macros will be
expanded null.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 13:25:16 +0800
> [DECNET]: Fix inverted wait flag in xfrm_lookup call
>
> My previous patch made the wait flag take the opposite value to what it
> should be. This patch fixes that.
>
> Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Ap
Christian Borntraeger wrote:
Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor:
I think the change below handles the race. Otherwise please detail the
use case.
[...]
@@ -292,6 +292,9 @@ static int virtnet_open(struct net_devic
return -ENOMEM;
napi_enable(&vi-
From: Daniel Lezcano <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 11:39:26 +0100
> Removed useless and buggy __exit section in the different
> ipv6 subsystems. Otherwise they will be called inside an
> init section during rollbacking in case of an error in the
> protocol initialization.
>
> Signed
These two patches allow rebinding of GRE and SIT tunnels to interfaces using
ip tun change dev
A similar change was already done for IPIP tunnels.
Michal
--
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
This is similar to the change already done for IPIP tunnels.
Once created, a GRE tunnel can't be bound to another device.
To reproduce:
# create a tunnel:
ip tunnel add tunneltest0 mode gre remote 10.0.0.1 dev eth0
# try to change the bounding device from eth0 to eth1:
ip tunnel change tunneltest
This is similar to the change already done for IPIP tunnels.
Once created, a SIT tunnel can't be bound to another device.
To reproduce:
# create a tunnel:
ip tunnel add tunneltest0 mode sit remote 10.0.0.1 dev eth0
# try to change the bounding device from eth0 to eth1:
ip tunnel change tunneltest
From: Jarek Poplawski <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 14:49:53 +0100
> As a matter of fact, since it's "unlikely()" in net_rx_action() anyway,
> I wonder what is the main reason or gain of leaving such a tricky
> exception, instead of letting drivers to always decide which is the
> best
[IPV6] Always pass a valid nl_info to inet6_rt_notify.
This makes the code in the inet6_rt_notify more straightforward and provides
groud for namespace passing.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/ipv6/ip6_fib.c |3 ++-
net/ipv6/route.c | 27 +---
From: "Joonwoo Park" <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 19:18:56 +0900
> Just blowing netif_running up is not best solution I think, it makes
> ifconfig down hang at least for e1000.
It hangs because the packet receive rate is so high that NAPI
poll never exits.
I think we need a cheap s
On 12-12-2007 19:41, Kok, Auke wrote:
> David Miller wrote:
>> From: Andrew Gallatin <[EMAIL PROTECTED]>
>> Date: Wed, 12 Dec 2007 12:29:23 -0500
>>
>>> Is the netif_running() check even required?
>> No, it is not.
>>
>> When a device is brought down, one of the first things
>> that happens is that
Hi,
My config does not link any more:
...
CHK include/linux/compile.h
UPD include/linux/compile.h
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
net/built-in.o: In function `xs_udp_data_ready':
/home/peifferp/containers/kernel/linux-2.6.24-rc5-mm1/n
From: Andrew Gallatin <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 09:13:54 -0500
> If the netif_running() check is indeed required to make a device break
> out of napi polling and respond to an ifconfig down, then I think the
> netif_running() check should be moved up into net_rx_action() to avoid
Joonwoo Park wrote:
> 2007/12/13, Kok, Auke <[EMAIL PROTECTED]>:
>> David Miller wrote:
>>> From: Andrew Gallatin <[EMAIL PROTECTED]>
>>> Date: Wed, 12 Dec 2007 12:29:23 -0500
>>>
Is the netif_running() check even required?
>>> No, it is not.
>>>
>>> When a device is brought down, one of the
There are to many spaces between type and function name in the declaration
of fib rules manipulation routines. Eat them and save a couple of lines.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
include/net/fib_rules.h | 16 +++-
1 files changed, 7 insertions(+), 9 deletions(
On Thu, Dec 13, 2007 at 05:50:13AM -0800, David Miller wrote:
> From: Jarek Poplawski <[EMAIL PROTECTED]>
> Date: Thu, 13 Dec 2007 14:49:53 +0100
>
> > As a matter of fact, since it's "unlikely()" in net_rx_action() anyway,
> > I wonder what is the main reason or gain of leaving such a tricky
> >
I've been working on making DCCP Ack Vectors more robust, dealing more
gracefully
with buffer overflow, and fixing two cases which will lead to corrupted buffer
state.
The encountered problems and implementation strategy are documented on
http://www.erg.abdn.ac.uk/users/gerrit/dccp/notes
David Miller wrote:
> From: "Denis V. Lunev" <[EMAIL PROTECTED]>
> Date: Thu, 13 Dec 2007 17:18:42 +0300
>
>> There are to many spaces between type and function name in the declaration
>> of fib rules manipulation routines. Eat them and save a couple of lines.
>>
>> Signed-off-by: Denis V. Lunev <
From: "Denis V. Lunev" <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 18:01:32 +0300
> Could you still apply it, or I will need to send fully functional set to
> you including this?
Please combine the changes so that when you change the args
you fixup the whitespace as well.
--
To unsubscribe from th
From: "Denis V. Lunev" <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 17:18:42 +0300
> There are to many spaces between type and function name in the declaration
> of fib rules manipulation routines. Eat them and save a couple of lines.
>
> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
This is j
From: Alexey Dobriyan <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 17:47:07 +0300
> On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote:
> > There are to many spaces between type and function name in the declaration
> > of fib rules manipulation routines. Eat them and save a couple of lin
The problem comes from the new macro UDPX_INC_STATS_BH introduced
by Herbert, which was a nice addition to increment the correct
UDP MIB depending on the socket family, but unfortunately
the use of this macro from kernel code (I mean code not compiled
as module) requires that IPv6 is also compil
From: Gerrit Renker <[EMAIL PROTECTED]>
When performing active close, RFC 4340, 8.3. requires to retransmit the
Close/CloseReq with a backoff-retransmit timer starting at intially 2 RTTs.
This patch shifts the existing code for active-close retransmit timer
into output.c, so that the retransmit t
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Best Regards,
- Arnaldo
Documentation/networking/dccp.txt |6 +
include/linux/dccp.h | 24 ++-
net/dccp/dccp.h | 10 ++-
net/dccp/feat.c
From: Gerrit Renker <[EMAIL PROTECTED]>
The option parsing code currently only parses on full sk's. This causes a
problem for
options sent during the initial handshake (in particular timestamps and
feature-negotiation
options). Therefore, this patch extends the option parsing code with an
addit
From: Gerrit Renker <[EMAIL PROTECTED]>
This provides a separate routine to insert options during the initial handshake.
The main purpose is to conduct feature negotiation, for the moment the only user
is the timestamp echo needed for the (CCID3) handshake RTT sample.
Padding of options has been
On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote:
> There are to many spaces between type and function name in the declaration
> of fib rules manipulation routines. Eat them and save a couple of lines.
If this patch is going in, it would be nice to get rid of "extern" as
well.
From: Gerrit Renker <[EMAIL PROTECTED]>
This removes two inlines which were both called in a single function only:
1) dccp_feat_change() is always called with either DCCPO_CHANGE_L or
DCCPO_CHANGE_R as argument
* from dccp_set_socktopt_change() via do_dccp_setsockopt() with
DCCP_SOCKOPT_CH
From: Gerrit Renker <[EMAIL PROTECTED]>
This implements [RFC 4340, p. 32]: "any feature negotiation options received
on DCCP-Data packets MUST be ignored".
Also added a FIXME for further processing, since the code currently (wrongly)
classifies empty Confirm options as invalid - this needs to be
From: Gerrit Renker <[EMAIL PROTECTED]>
In DCCP, timestamps can occur on packets anytime, CCID3 uses a timestamp(/echo)
on the Request/Response
exchange. This patch addresses the following situation:
* timestamps are recorded on the listening socket;
* Responses are sent from dccp
From: Gerrit Renker <[EMAIL PROTECTED]>
This adds option-parsing code to processing of Acks in the listening state
on request_socks on the server, serving two purposes
(i) resolves a FIXME (removed);
(ii) paves the way for feature-negotiation during connection-setup.
There is an intended subtl
From: Gerrit Renker <[EMAIL PROTECTED]>
This replaces 4 individual assignments for `len' with a single
one, placed where the control flow of those 4 leads to.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <
From: Gerrit Renker <[EMAIL PROTECTED]>
This adds a socket option and signalling support for the case where the server
holds timewait state on closing the connection, as described in RFC 4340, 8.3.
Since holding timewait state at the server is the non-usual case, it is enabled
via a socket option
From: Gerrit Renker <[EMAIL PROTECTED]>
This patch performs two changes:
1) Close the write-end in addition to the read-end when a fin-like segment
(Close or CloseReq) is received by DCCP. This accounts for the fact that DCCP,
in contrast to TCP, does not have a half-close. RFC 4340 says in t
From: Gerrit Renker <[EMAIL PROTECTED]>
This removes another Fixme, using the TCP maximum RTO rather than the value
specified by the DCCP specification. Across the sections in RFC 4340, 64
seconds is consistently suggested as maximum RTO backoff value; and this is
the value which is now used.
I h
From: Gerrit Renker <[EMAIL PROTECTED]>
This removes several `XXX' references which indicate a missing support
for non-1-byte feature values: this is unnecessary, as all currently known
(standardised) SP feature values are 1-byte quantities.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed
On Thu, Dec 13, 2007 at 04:01:34PM +0100, Benjamin Thery wrote:
> The problem comes from the new macro UDPX_INC_STATS_BH introduced
> by Herbert, which was a nice addition to increment the correct
> UDP MIB depending on the socket family, but unfortunately
> the use of this macro from kernel code
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Fri, 14 Dec 2007 00:44:48 +0800
> [IPSEC]: Fix zero return value in xfrm_lookup on error
>
> Further testing shows that my ICMP relookup patch can cause xfrm_lookup
> to return zero on error which isn't very nice since it leads to the caller
> dying on n
Hello Ilpo,
it happened again with your patch applied:
WARNING: at net/ipv4/tcp_input.c:1018 tcp_sacktag_write_queue()
Call Trace:
[] tcp_sacktag_write_queue+0x7d0/0xa60
[] add_partial+0x19/0x60
[] tcp_ack+0x5a4/0x1d70
[] tcp_rcv_established+0x485/0x7b0
[] tcp_v4_do_rcv+0xed/0x3e0
[] tcp_v4_rc
David Miller wrote:
> From: Andrew Gallatin <[EMAIL PROTECTED]>
> Date: Thu, 13 Dec 2007 09:13:54 -0500
>
>> If the netif_running() check is indeed required to make a device break
>> out of napi polling and respond to an ifconfig down, then I think the
>> netif_running() check should be moved up i
Hi Dave:
Found another silly bug in my ICMP relookup patch.
[IPSEC]: Fix zero return value in xfrm_lookup on error
Further testing shows that my ICMP relookup patch can cause xfrm_lookup
to return zero on error which isn't very nice since it leads to the caller
dying on null pointer dereference.
On Thu, Dec 13, 2007 at 05:07:44PM +0100, Borislav Petkov wrote:
> On Thu, Dec 13, 2007 at 04:01:34PM +0100, Benjamin Thery wrote:
> > The problem comes from the new macro UDPX_INC_STATS_BH introduced
> > by Herbert, which was a nice addition to increment the correct
> > UDP MIB depending on the s
From: "Denis V. Lunev" <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 11:06:18 +0300
> [IPV4] Thresholds in fib_trie.c are used as consts, so make them const.
>
> There are several thresholds for trie fib hash management. They are used
> in the code as a constants. Make them constants from the compil
From: [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 14:37:49 +0100
> This is similar to the change already done for IPIP tunnels.
>
> Once created, a GRE tunnel can't be bound to another device.
> To reproduce:
>
> # create a tunnel:
> ip tunnel add tunneltest0 mode gre remote 10.0.0.1 dev eth0
> # t
From: "Denis V. Lunev" <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 16:58:54 +0300
> [IPV6] Always pass a valid nl_info to inet6_rt_notify.
>
> This makes the code in the inet6_rt_notify more straightforward and provides
> groud for namespace passing.
>
> Signed-off-by: Denis V. Lunev <[EMAIL PROT
Cedric Le Goater wrote:
> Ilpo Järvinen wrote:
>> On Wed, 5 Dec 2007, Andrew Morton wrote:
>>
>>> On Thu, 06 Dec 2007 17:59:37 +1100 Reuben Farrelly <[EMAIL PROTECTED]>
>>> wrote:
>>>
This non fatal oops which I have just noticed may be related to this
change then
- certainly look
This should fix the kernel warn/oops reported while routing.
The tulip driver has a fencepost bug with new NAPI in 2.6.24
It has an off by one bug if a full quantum is reached.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/drivers/net/tulip/interrupt.c 2007-12-13 09:20:27.0
The hardware mitigation in tulip can be simpified.
1. The budget with new NAPI will always be less than RX_RING_SIZE
because RX_RING_SIZE is 128 and weight is 16.
2. The received counter is redundunt, just use the work_done value.
3. Only one value is used from the mit_table[]
Signed-off-by: St
From: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---
drivers/net/e1000/e1000_hw.h |2 --
drivers/net/e1000/e1000_main.c | 16
2 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/d
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 13:05:53 -0200
> Please consider pulling from:
>
> master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Looks good, pulled and pushed back out to net-2.6.25
Thanks!
--
To unsubscribe from this list: send the
Andrew Morton wrote:
> Temporarily at
>
> http://userweb.kernel.org/~akpm/2.6.24-rc4-mm1/
>
> Will appear later at
>
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/
I got this one while compiling on NFS.
C.
kernel BUG at /home/legoater/linux/2
From: Benjamin Thery <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 16:01:34 +0100
> The problem comes from the new macro UDPX_INC_STATS_BH introduced
> by Herbert, which was a nice addition to increment the correct
> UDP MIB depending on the socket family, but unfortunately
> the use of this macro
From: [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 14:37:50 +0100
> This is similar to the change already done for IPIP tunnels.
>
> Once created, a SIT tunnel can't be bound to another device.
> To reproduce:
>
> # create a tunnel:
> ip tunnel add tunneltest0 mode sit remote 10.0.0.1 dev eth0
> # t
On Thu, 13 Dec 2007 06:19:38 -0800 (PST)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Andrew Gallatin <[EMAIL PROTECTED]>
> Date: Thu, 13 Dec 2007 09:13:54 -0500
>
> > If the netif_running() check is indeed required to make a device break
> > out of napi polling and respond to an ifconfig down
Am Donnerstag, 13. Dezember 2007 schrieb Dor Laor:
> You're right I got confused somehow.
> So in that case setting the driver status field on open in addition to
> your enable will do the trick.
> On DRIVER_OPEN the host will trigger an interrupt if the queue is not
> empty..
> Thanks,
> Dor
Af
From: Gavin McCullagh <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 18:56:26 +
> I'm trying to hack together something which will run through the
> retransmit queue looking at the tcp headers.
The packets in the retransmit queue are headerless, the
header only gets added to clones of the retrans
Hi,
thanks for the swift reply.
On Thu, 13 Dec 2007, David Miller wrote:
> > I'm trying to hack together something which will run through the
> > retransmit queue looking at the tcp headers.
>
> The packets in the retransmit queue are headerless, the
> header only gets added to clones of the re
From: Andrew Gallatin <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 14:02:25 -0500
> Or perhaps we should just leave things as is.
We should probably add a "disabling" state bit to the
napi struct flags, this will be set by napi_disable()
before it loops trying to set the sched bit.
net_rx_action()
Stephen Hemminger wrote:
On Thu, 13 Dec 2007 06:19:38 -0800 (PST)
David Miller <[EMAIL PROTECTED]> wrote:
From: Andrew Gallatin <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 09:13:54 -0500
If the netif_running() check is indeed required to make a device break
out of napi polling and respond to a
From: Gavin McCullagh <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 19:08:59 +
> Thought that might be it. I presume there isn't any other residue of the
> tcp options elsewhere, that one could look at when the packet gets
> acknowledged? I'm particularly interested in the timestamp.
Every time
This is a resubmission of a new driver for Solarflare network controllers.
The driver supports many types of PHY (10Gbase-T, XFP, CX4) on five
different 10G reference designs and one 1G NIC ref design.
The previous thread was:
"[PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller"
David Miller wrote:
From: Andrew Gallatin <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 14:02:25 -0500
Or perhaps we should just leave things as is.
We should probably add a "disabling" state bit to the
napi struct flags, this will be set by napi_disable()
before it loops trying to set t
On Thu, 13 Dec 2007 20:26:21 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote:
> Hi Andrew,
Hi. Please do try to cc netdev@vger.kernel.org on net-related problems.
Doing so will often save multiple hours latency and will optimise away one
entire email (ie: this one).
> Following call trace is
David Miller wrote, On 12/13/2007 02:50 PM:
> From: Jarek Poplawski <[EMAIL PROTECTED]>
> Date: Thu, 13 Dec 2007 14:49:53 +0100
>
>> As a matter of fact, since it's "unlikely()" in net_rx_action() anyway,
>> I wonder what is the main reason or gain of leaving such a tricky
>> exception, instead o
From: Jarek Poplawski <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 21:16:12 +0100
> I see in a nearby thread you would prefer to save some work to drivers
> (like this netif_running() check), but I think this all is at the cost
> of flexibility, and there will probably appear new problems, when a
>
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 11:35:07 -0800
> How about allowing a return value of -1 from napi_poll and letting
> device check itself.
It doesn't avoid the code duplication in the ->poll() fast paths.
I don't care, on the other hand, if crap accumulates in
David Miller wrote:
From: Jarek Poplawski <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 21:16:12 +0100
I see in a nearby thread you would prefer to save some work to drivers
(like this netif_running() check), but I think this all is at the cost
of flexibility, and there will probably appear new
On 14:47 Mon 10 Dec , Evgeniy Polyakov wrote:
>
> Network state machine.
>
> Includes network async processing state machine and related tasks.
Hi, I've tried to play a little bit with DST and discover huge memory
leak. Every read request from remote node result in bio + bio's pages leak.
Da
In SMP kernels 2.6.21 and prior you could use a SOCK's sendmsg() call via the
PROTO structure directly. e.g., sock->sk_prot->sendmsg().
Now in 2.6.22 and later kernels you must use the higher level SOCKET to make a
call to PROTO_OPS then to sendmsg(). e.g., socket->ops->sendmsg().
Would someone
From: "Kevin Wilson" <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 14:54:31 -0600
> The 2nd method fixes the kernel oops I reported. Thanks to all those
> that assisted me (0) with my first post to this list (see below)
> ... uh, oh yeah, did I mention that number would tally up to ZERO
> people. ;-}
On Wed, Dec 12, 2007 at 07:24:04PM +0100, Johannes Berg wrote:
> @@ -1014,6 +992,24 @@ ieee80211_drop_unencrypted(struct ieee80
> return 0;
> }
>
> +static bool ieee80211_frame_allowed(struct ieee80211_txrx_data *rx)
> +{
> + static const u8 pae_group_addr[ETH_ALEN]
> + =
Stephen Hemminger wrote, On 12/13/2007 09:41 PM:
> David Miller wrote:
>> From: Jarek Poplawski <[EMAIL PROTECTED]>
>> Date: Thu, 13 Dec 2007 21:16:12 +0100
>>
>>
>>> I see in a nearby thread you would prefer to save some work to drivers
>>> (like this netif_running() check), but I think this a
I see your point but it just so happens it is a GPL'd driver, as is all of our
Linux code we produce for our hardware. Granted it is out of tree, and after
you saw it you would want it to stay that way. However, I would have sent you
the whole thing if that is a pre-req to cordial exchanges on t
David Miller wrote, On 12/13/2007 09:37 PM:
...
> For example, if we export the list handling widget into the ->poll()
> routines, god help the person who wants to change how the poll list is
> managed in net_rx_action() :-/
...I'm afraid I can't understand: I mean doing the same but without
pass
From: Jarek Poplawski <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 23:28:41 +0100
> ...I'm afraid I can't understand: I mean doing the same but without
> passing this info with 'work == weight': if driver sends this info,
> why it can't instead call something like napi_continue() with
> this list_mo
David Miller wrote, On 12/13/2007 11:34 PM:
> From: Jarek Poplawski <[EMAIL PROTECTED]>
> Date: Thu, 13 Dec 2007 23:28:41 +0100
>
>> ...I'm afraid I can't understand: I mean doing the same but without
>> passing this info with 'work == weight': if driver sends this info,
>> why it can't instead c
On Thu, 13 Dec 2007, Cedric Le Goater wrote:
> I got this one while compiling on NFS.
>
> C.
>
> kernel BUG at /home/legoater/linux/2.6.24-rc4-mm1/include/net/tcp.h:1480!
I'm not exactly sure what patches you have applied and which patches are
not, with rc4-mm1 there are two patches (first one
Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
---
drivers/infiniband/core/addr.c |4 ++--
drivers/infiniband/core/cma.c |5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index 5381c80..0802b79 100644
Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
---
net/ipv4/arp.c |2 +-
net/ipv4/datagram.c |2 +-
net/ipv4/devinet.c |4 +-
net/ipv4/fib_frontend.c |6 ++--
net/ipv4/igmp.c | 12 +-
net/ipv4/ip_gre.c | 23 +++-
net/ipv4
Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
---
include/net/sctp/constants.h | 36 ++--
net/sctp/protocol.c | 12 +++-
2 files changed, 13 insertions(+), 35 deletions(-)
diff --git a/include/net/sctp/constants.h b/include/net/sctp/constants
1 - 100 of 145 matches
Mail list logo