[patch] skbuff: spelling and formatting fixes

2007-12-24 Thread Matti Linnanvuori
--- a/include/linux/skbuff.h2007-12-25 08:24:51.032348500 +0200 +++ b/include/linux/skbuff.h2007-12-25 08:38:31.067753500 +0200 @@ -127,7 +127,7 @@ struct sk_buff_head { struct sk_buff; /* To allow 64K frame to be packed as single skb without frag_list */ -#define MAX_SKB_FRAGS (65536/P

Re: Please pull 'fixes-davem' branch of wireless-2.6

2007-12-24 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 10:52:27 -0500 > A few more stragglers for 2.6.24...let me know if there are any > problems! ... > The following changes since commit 82d29bf6dc7317aeb0a3a13c2348ca8591965875: > Linus Torvalds (1): > Linux 2.6.24-rc5 >

Re: [PATCH] net: santize headers for iproute2

2007-12-24 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 09:43:36 -0800 > iproute2 source uses headers that result from "make headers_install". > The header files net/tcp_states.h and net/veth.h are both being used > but are not processed. > > Signed-off-by: Stephen Hemminger <[EMAIL P

Re: [PATCH] [TCP]: Remove seq_rtt ptr from clean_rtx_queue args

2007-12-24 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 16:19:19 +0200 (EET) > While checking Gavin's patch I noticed that the returned seq_rtt > is not used by the caller. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Good catch, applied to net-2.6.25 The history of this is tha

Re: [PATCH] [TCP]: Force TSO splits to MSS boundaries

2007-12-24 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 20:55:28 +0200 (EET) > [PATCH] [TCP]: Force TSO splits to MSS boundaries > > If snd_wnd - snd_nxt wasn't multiple of MSS, skb was split on > odd boundary by the callers of tcp_window_allows. > > We try really hard to avoid unnecess

Re: [PATCH] TUNTAP: Fix wrong debug message

2007-12-24 Thread David Miller
From: Toyo Abe <[EMAIL PROTECTED]> Date: Tue, 25 Dec 2007 12:27:56 +0900 (JST) > --- Original Messsage --- > From: Joe Perches <[EMAIL PROTECTED]> > Subject: Re: [PATCH] TUNTAP: Fix wrong debug message > Date: Mon, 24 Dec 2007 18:48:48 -0800 > Message-ID: <[EMAIL PROTECTED]> > > > More readable t

Re: [ETH]: Combine format_addr() with print_mac().

2007-12-24 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Sun, 23 Dec 2007 16:20:35 -0800 > Here's the revised patch: > > [ETH]: Combine format_addr() with print_mac(). > > print_mac() used many most net drivers and format_addr() used by > net-sysfs.c are very similar and they can be intergrated. > > form

Re: [WEXT 3/12]: Extract standard call iw_point handling into seperate function.

2007-12-24 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 23:22:52 -0800 > On Fri, 2007-12-21 at 20:54 -0800, David Miller wrote: > > [WEXT]: Extract standard call iw_point handling into seperate function. > > This potentially does copy_from_user twice, > first to the stack, second to a kmallo

Re: [SOCK] Avoid divides in sk_stream_pages() and __sk_stream_mem_reclaim()

2007-12-24 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 15:45:08 +0100 > [SOCK] Avoid divides in sk_stream_pages() and __sk_stream_mem_reclaim() > > sk_forward_alloc being signed, we should take care of divides by > SK_STREAM_MEM_QUANTUM we do in sk_stream_pages() and > __sk_stream_mem_rec

Re: (2nd attempt) Please pull 'upstream-davem' branch of wireless-2.6

2007-12-24 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 09:05:27 -0500 > These are destined for 2.6.25. The patches fall mostly into two > categories: a new rate control algorithm for mac80211, and some > cfg80211 enhancements (including mac80211 patches to use them). > > Also there

Re: [PATCH] TUNTAP: Fix wrong debug message

2007-12-24 Thread Toyo Abe
--- Original Messsage --- From: Joe Perches <[EMAIL PROTECTED]> Subject: Re: [PATCH] TUNTAP: Fix wrong debug message Date: Mon, 24 Dec 2007 18:48:48 -0800 Message-ID: <[EMAIL PROTECTED]> > More readable to reverse the strings > > tun->dev->name, arg ? "enabled" : "disabled"); >

[PATCH] TUNTAP: Fix wrong debug message

2007-12-24 Thread Toyo Abe
This is a trivial fix of debug message. When a persist flag is set, the message should say "enabled". Signed-off-by: Toyo Abe <[EMAIL PROTECTED]> --- drivers/net/tun.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 1f76446..e5

Re: [patch 3/6] netxen: improve MSI interrupt handling

2007-12-24 Thread Dhananjay Phadke
Supposedly I had 2.6.24-rc2 as base for the patchset, but looks like it had some stale code. I'll regenrate series on a fresh checkout. -Dhananjay On Sat, 22 Dec 2007, Jeff Garzik wrote: > Patch does not apply to 2.6.24-rc. > > Was this "bug fix" series meant for 2.6.25? > > Jeff > >

Re: "ip neigh show" not showing arp cache entries?

2007-12-24 Thread Herbert Xu
On Wed, Dec 19, 2007 at 08:28:49AM -0600, Chris Friesen wrote: > > I've included the traces below, they're pretty long. I don't know > enough about the netlink format to trace the responses, but I did notice > one interesting thing. > > In the "ip neigh show" case the "bond2" entry isn't print

Re: [RFC] potential bugs in nexten

2007-12-24 Thread Dhananjay Phadke
Probably I need to clean up much more junk like that from days before I took over. I recently cleaned up a bit of rx and tx code, which is more frequently executed. The last one (byte swapping) is serious and I am gonna take care of that in next patch. Thanks, -Dhananjay On Sun, 23 Dec 2007,

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-24 Thread Herbert Xu
On Mon, Dec 24, 2007 at 09:50:59AM -0500, jamal wrote: > > Herbert, i agree with you that userspace is the best spot for this[1]; > we unfortunately have precedence already on the kernel sending arps with > bonding when link status changes (that was added recently). > So it sounds reasonable to hav

[RFC] old stuff - Kernel Bug Tracker Bug 7398

2007-12-24 Thread Andreas Henriksson
Hello! While looking over the old remaining bugs reported against iproute in Debian I came across http://bugs.debian.org/394780 which has also been reported as http://bugzilla.kernel.org/show_bug.cgi?id=7398 (please see the old comments here). As there seems to be a question remaining which still

Re: [XFRM]: Fix outbound statistics.

2007-12-24 Thread David Miller
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 23:25:00 +0900 > Hello David, > > I'm sorry, the previous mail contains wrong code: ... > Please apply the below patch instead of the previous. > > Signed-off-by: Masahide NAKAMURA <[EMAIL PROTECTED]> Applied, thanks. -- To uns

Re: [patch net-2.6.25 2/2][NETNS] net: Add a helper function neigh_param_default_alloc

2007-12-24 Thread David Miller
From: Eric.W.Biederman" <[EMAIL PROTECTED]>"@fr.ibm.com Date: Fri, 21 Dec 2007 14:02:25 +0100 > In the presence of multiple network namespaces the logic needed > to allocate the a default parameter table is just barely non-trivial. > So add a function to automate it to make everyone's life easier.

Re: [patch net-2.6.25 1/2][NETNS] net: Modify the neighbour table code so it handles multiple network namespaces

2007-12-24 Thread David Miller
From: Eric.W.Biederman" <[EMAIL PROTECTED]>"@fr.ibm.com Date: Fri, 21 Dec 2007 14:02:24 +0100 > I'm actually surprised at how much was involved. At first glance it appears > that the neighbour table data structures are already split by network device > so all that should be needed is to modify th

Re: Strange Panic (Deadlock)

2007-12-24 Thread Jarek Poplawski
[EMAIL PROTECTED] wrote, On 12/24/2007 07:18 PM: > Hello again. > Its bug depend to > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4aae07025265151e3f7041dfbf0f529e122de1d8 > ? Hello Vyacheslav! I wonder why do you think there is such a dependency, and why do you r

Re: [RFC] skge csum problems

2007-12-24 Thread Stephen Hemminger
On Mon, 24 Dec 2007 18:39:50 + Al Viro <[EMAIL PROTECTED]> wrote: > On Mon, Dec 24, 2007 at 02:15:40PM +0100, Andi Kleen wrote: > > Al Viro <[EMAIL PROTECTED]> writes: > > > > > > Checksum is fixed-endian and we want it that way; IOW, what we end up > > > storing in skb->csum should be fixed-e

Re: [RFC] skge csum problems

2007-12-24 Thread Al Viro
On Mon, Dec 24, 2007 at 11:36:38AM -0800, Stephen Hemminger wrote: > > you will get the same behaviour on big- and little-endian boxen, even though > > the intermediate integer values will be of course different. > > > > skb->csum *must* be stored in the same order on l-e and b-e boxen; that > > w

Re: [RFC] skge csum problems

2007-12-24 Thread Al Viro
On Mon, Dec 24, 2007 at 02:15:40PM +0100, Andi Kleen wrote: > Al Viro <[EMAIL PROTECTED]> writes: > > > > Checksum is fixed-endian and we want it that way; IOW, what we end up > > storing in skb->csum should be fixed-endian as well. > > AFAIK skb->csum is always native endian because it normally >

Re: Strange Panic (Deadlock)

2007-12-24 Thread slavon
Hello again. Its bug depend to http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4aae07025265151e3f7041dfbf0f529e122de1d8 ? Its very critical bug to us. This PC must be HA. Server place so far for me to go and reboot server. I go to it 1-3 times in week =( Please help

Re: [PATCH] [IPROUTE2] IPT action compatibility with iptables 1.4.0

2007-12-24 Thread jamal
On Mon, 2007-24-12 at 09:48 -0800, Stephen Hemminger wrote: > On Mon, 24 Dec 2007 11:55:05 -0500 > Is this backwards compatible with older kernels? Yes. Denys change adds forward compat (although iptables in 1.4 is not fully backward compatible). cheers, jamal -- To unsubscribe from this list:

Re: [PATCH] [IPROUTE2] IPT action compatibility with iptables 1.4.0

2007-12-24 Thread Stephen Hemminger
On Mon, 24 Dec 2007 11:55:05 -0500 jamal <[EMAIL PROTECTED]> wrote: > > Stephen, > > Please apply this patch from Denys Fedoryshchenko to make the ipt action > work with latest iptables. > > cheers, > jamal > Is this backwards compatible with older kernels? -- Stephen Hemminger <[EMAIL PROT

Re: [PATCH] [IPROUTE2] Compatibility with iptables 1.4.0

2007-12-24 Thread jamal
I just submitted a tested, slightly reduced patch (example we dont need to register matches) and it works as expected now. Thanks for the excellent work Denys. Pablo, below looks an oversight. I think there are some libraries like the mark target need also to be backward compatible. cheers, jama

[PATCH] [IPROUTE2] IPT action compatibility with iptables 1.4.0

2007-12-24 Thread jamal
Stephen, Please apply this patch from Denys Fedoryshchenko to make the ipt action work with latest iptables. cheers, jamal New iptables 1.4.0 has some library names changed from libipt to libxt. It is prefferable also to open libxt_ first, as newer "style". Signed-off-by: Denys Fedoryshchenko

Re: [PATCH] [IPROUTE2] Compatibility with iptables 1.4.0

2007-12-24 Thread jamal
On Mon, 2007-24-12 at 18:07 +0200, Denys Fedoryshchenko wrote: > Hi, probably like this will be better? > Previous patch was not backward compatible. > > Btw i checked twice, name is changed from libipt_MARK to libxt_MARK. So > probably when you have tested this, your iproute2 was looking to old >

[PATCH] [IPROUTE2] Compatibility with iptables 1.4.0

2007-12-24 Thread Denys Fedoryshchenko
Hi, probably like this will be better? Previous patch was not backward compatible. Btw i checked twice, name is changed from libipt_MARK to libxt_MARK. So probably when you have tested this, your iproute2 was looking to old libipt_MARK (iptables is not deleting old libraries on make install). ---

Re: iproute2 action ipt + iptables 1.4.0

2007-12-24 Thread jamal
Denys, Looks reasonable to check for libxt as well. Please add a signed-off and append mine as well then send to Stephen. BTW, I just finished compiling iptables 1.4.0 and _it is_ backward compatible - you just have to point to the correct environment variable IPTABLES_LIB_DIR; it seems to work

iproute2 action ipt + iptables 1.4.0

2007-12-24 Thread Denys Fedoryshchenko
Hi again :-) Happy holidays :-) It seems there is serious break in compatibility, but can be fixed by ugly way. Maybe just to add patch below, and to search libipt AND libxt (for my case i just edit and change libipt to libxt, but it can be handled in more smart way. After i apply all this - it s

Strange Panic (Deadlock)

2007-12-24 Thread Badalian Vyacheslav
Hello all. Some time machine freeze. No information on monitor. No rebooting on sysctl "kernel.panic". Any idea? Catched by netconsole: [91922.085864] [ cut here ] [91922.085975] kernel BUG at kernel/timer.c:606! [91922.086058] invalid opcode: [#1] [91922.086127] SMP [

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-24 Thread jamal
On Mon, 2007-24-12 at 15:38 +0200, David Shwatrz wrote: > Hello, > > First, it indeed can be handled by user space. (even though it should > be done twice, once for ifconig of net-tools and once for ip of > iproute2) it needs to be done once only: reacting to netlink events when MAC address cha

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-24 Thread jamal
On Sun, 2007-23-12 at 08:17 -0500, jamal wrote: > On Sun, 2007-23-12 at 22:04 +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > > > If the secondary MACs are used with ARP/NDP, we should take care of > > that, but I think we use the primary MAC for ARP/NDP, no? > > (In other words, we always use primary MA

Re: iproute2 action ipt + iptables 1.4.0

2007-12-24 Thread jamal
On Mon, 2007-24-12 at 11:31 +0200, Denys Fedoryshchenko wrote: > Seems latest iproute2(even from GIT) searching for libipt_MARK (for example), > while it is libxt_MARK. It seems that iptables broke backward compatibility. > Even if i correct names it will be still not functional > "undefined symb

Re: ipv4_devconf.arp_accept mystery

2007-12-24 Thread Ian Brown
Hello, >As the name suggests you should use > /proc/sys/net/ipv4/conf/all/arp_accept Thanks. This is indeed true. I first tried with ipv4_devconf.arp_accept, where the name probably does **not** suggest it; I agree that for PV4_DEVCONF_ALL() the name indeed suggests it . It just skipped my e

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-24 Thread David Shwatrz
Hello, First, it indeed can be handled by user space. (even though it should be done twice, once for ifconig of net-tools and once for ip of iproute2) / However, we have already methods which deal with bringing down an interface - neigh_ifdown(), and changing MAC address of an interface (neigh_ch

Re: [RFC] skge csum problems

2007-12-24 Thread Andi Kleen
Al Viro <[EMAIL PROTECTED]> writes: > > Checksum is fixed-endian and we want it that way; IOW, what we end up > storing in skb->csum should be fixed-endian as well. AFAIK skb->csum is always native endian because it normally needs to be manipulated further even for RX. -Andi -- To unsubscribe fro

Re: ipv4_devconf.arp_accept mystery

2007-12-24 Thread Herbert Xu
Ian Brown <[EMAIL PROTECTED]> wrote: > > BTW, in newer kernel version we have IPV4_DEVCONF_ALL(ARP_ACCEPT) > instead. So if anybody knows how to set this macro (instead)to be 1, it will > be > also fine. As the name suggests you should use /proc/sys/net/ipv4/conf/all/arp_accept Cheers,

Simple question about network stack

2007-12-24 Thread Badalian Vyacheslav
Hi all. Sorry for offtopic. Have problems with balance CPU load in networking. Have 2 Ethernet adapters e1000. Have 8 CPU (4 real). Computer work as Shaper. Use only TC rules to shape and IPTABLES to drop. rx on eth0 go to CPU0. traffic above 400mbs do 90% SI. rx on eth1 go to CPU1. traffic above

[RFC] skge csum problems

2007-12-24 Thread Al Viro
Both variants of skge (drivers/net and drivers/net/sk98lin/ resp.) have the same problem with rx checksums. They pick checksum from rx descriptor and use it as-is. Normally that would be the right thing to do. However, skge is told to byteswap descriptors on big-endian boxen. Checksum i

iproute2 action ipt + iptables 1.4.0

2007-12-24 Thread Denys Fedoryshchenko
Seems latest iproute2(even from GIT) searching for libipt_MARK (for example), while it is libxt_MARK. Even if i correct names it will be still not functional "undefined symbol: xtables_register_target" Probably some other issues actual with new version of iptables libraries? -- Denys Fedoryshc