Re: Assertions in latest kernels

2008-01-23 Thread Krishna Kumar2
David Miller <[EMAIL PROTECTED]> wrote on 01/23/2008 01:27:23 PM: > > iperf with multiple threads almost always gets these 4, *especially* when I > > do some batching :). > > > > static void tcp_fastretrans_alert(struct sock *sk, int pkts_acked, int flag) > > { > > ... > > if (WARN_ON(

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-23 Thread Ilpo Järvinen
On Wed, 23 Jan 2008, Dave Young wrote: > On Jan 23, 2008 3:41 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > > > On Tue, 22 Jan 2008, David Miller wrote: > > > > > From: "Dave Young" <[EMAIL PROTECTED]> > > > Date: Wed, 23 Jan 2008 09:44:30 +0800 > > > > > > > On Jan 22, 2008 6:47 PM, Ilpo Järvi

Re: Assertions in latest kernels

2008-01-23 Thread Ilpo Järvinen
On Wed, 23 Jan 2008, Krishna Kumar2 wrote: > David Miller <[EMAIL PROTECTED]> wrote on 01/23/2008 01:27:23 PM: > > > > iperf with multiple threads almost always gets these 4, *especially* > when I > > > do some batching :). > > > > > > static void tcp_fastretrans_alert(struct sock *sk, int pkts_a

Re: [PATCH 12/12 net-2.6.25] [NETNS]: Add namespace for ICMP replying code.

2008-01-23 Thread Mathieu Lacage
hi, On Tue, 2008-01-22 at 23:51 -0800, David Miller wrote: > From: "Denis V. Lunev" <[EMAIL PROTECTED]> > Date: Wed, 23 Jan 2008 10:46:27 +0300 > > > All needed API is done, the namespace is available when required from the > > device on the DST entry from the incoming packet. So, just replace in

Re: [PATCH 12/12 net-2.6.25] [NETNS]: Add namespace for ICMP replying code.

2008-01-23 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 23 Jan 2008 10:16:29 +0100), Mathieu Lacage <[EMAIL PROTECTED]> says: > I have been following the netns patches on this ML for a while but I > still have not figured out in which tree the patches fed to David Miller > are applied. I have attempted to grep t

2.6.24-rc8 ppp regression

2008-01-23 Thread maximilian attems
when killing a wvdial usb modem session: Jan 22 23:23:03 dual pppd[7941]: Terminating on signal 15 Jan 22 23:23:03 dual pppd[7941]: Connect time 92.2 minutes. Jan 22 23:23:03 dual pppd[7941]: Sent 1322316 bytes, received 8587156 bytes. Jan 22 23:23:03 dual pppd[7941]: Connection terminated. Jan 2

Re: Assertions in latest kernels

2008-01-23 Thread Ilpo Järvinen
On Wed, 23 Jan 2008, Krishna Kumar2 wrote: > Hi Ilpo, > > > It's almost impossible to know which of these is the main cause and the > > first occuring due to reasons I'll not copy here. What a strange thing > > that it has been super quiet on this front until now everybody is seeing > > it, could

Re: [PATCH] pci-skeleton: Misc fixes to build neatly

2008-01-23 Thread Jeff Garzik
Jike Song wrote: Hello Jeff, The pci-skeleton.c has several problems with compilation, such as missing args when calling synchronize_irq(). Fix it. Signed-off-by: Jike Song <[EMAIL PROTECTED]> --- drivers/net/pci-skeleton.c | 49 ++- 1 files changed, 2

[git patches] net driver fixes

2008-01-23 Thread Jeff Garzik
Francois noted that these warranted promotion from net-2.6.25.git to current 2.6.24-rc. NOTE: These changesets were cherry-picked from net-2.6.25, without any modifications. Any future rebase or merge should hopefully notice this automatically. Please pull from 'upstream-davem' branch of mas

Re: [PATCH] pci-skeleton: Misc fixes to build neatly

2008-01-23 Thread Jike Song
On 1/23/08, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > ACK but git-am (everybody's patch import tool) says the patch is corrupted > Hi Jeff, Thank you very much for your acknowledgement! This is my first patch for Linux kernel, sorry for the corruption. I'll resend it ASAP. Regards, Jike -- To

Re: Assertions in latest kernels

2008-01-23 Thread Krishna Kumar2
[EMAIL PROTECTED] wrote on 01/23/2008 03:23:24 PM: > > There were couple of patch apply failures in .c files which I fixed by > > hand. > > But when compiling, I got these errors (I am using DM's 2.6.24-rc7 kernel, > > net-2.6.25.git): > > Well, that's annoying, you didn't mention net-2.6.25 back

Re: 2.6.24-rc8 ppp regression

2008-01-23 Thread Ben Hutchings
maximilian attems wrote: > > when killing a wvdial usb modem session: > > Jan 22 23:23:03 dual pppd[7941]: Terminating on signal 15 > Jan 22 23:23:03 dual pppd[7941]: Connect time 92.2 minutes. > Jan 22 23:23:03 dual pppd[7941]: Sent 1322316 bytes, received 8587156 bytes. > Jan 22 23:23:03 dual p

Re: Assertions in latest kernels

2008-01-23 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 11:17:05 +0200 (EET) > What a strange thing that it has been super quiet on this front > until now everybody is seeing it, could there be something unrelated > to TCP which has broken it all recently? I think it is simply "capture e

Re: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

2008-01-23 Thread Andi Kleen
Sreenivasa Honnur <[EMAIL PROTECTED]> writes: > Multiqueue netwrok device support implementation. > - Added a loadable parameter "multiq" to enable/disable multiqueue support, > by default it is disabled. > - skb->queue_mapping is not used for queue/fifo selection. FIFO iselection is > based o

Re: 2.6.24-rc8 ppp regression

2008-01-23 Thread David Miller
From: maximilian attems <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 10:35:09 +0100 > Jan 22 23:23:54 dual kernel: unregister_netdevice: waiting for ppp0 to become > free. Usage count = 1 Already fixed by: [NEIGH]: Revert 'Fix race between neigh_parms_release and neightbl_fill_parms' Commit 9cd4

Re: [git patches] net driver fixes

2008-01-23 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 05:05:18 -0500 > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git > upstream-davem Pulled into net-2.6, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EM

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-23 Thread Ilpo Järvinen
On Wed, 23 Jan 2008, Ilpo Järvinen wrote: > On Wed, 23 Jan 2008, Dave Young wrote: > > > On Jan 23, 2008 3:41 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > > > > > On Tue, 22 Jan 2008, David Miller wrote: > > > > > > > From: "Dave Young" <[EMAIL PROTECTED]> > > > > Date: Wed, 23 Jan 2008 09:44

Re: 2.6.24-rc8 ppp regression

2008-01-23 Thread maximilian attems
On Wed, Jan 23, 2008 at 02:58:54AM -0800, David Miller wrote: > From: maximilian attems <[EMAIL PROTECTED]> > Date: Wed, 23 Jan 2008 10:35:09 +0100 > > > Jan 22 23:23:54 dual kernel: unregister_netdevice: waiting for ppp0 to > > become free. Usage count = 1 > > Already fixed by: > thanks. --

Re: Assertions in latest kernels

2008-01-23 Thread Ilpo Järvinen
On Wed, 23 Jan 2008, Ilpo Järvinen wrote: > On Wed, 23 Jan 2008, Krishna Kumar2 wrote: > > > Hi Ilpo, > > > > > It's almost impossible to know which of these is the main cause and the > > > first occuring due to reasons I'll not copy here. What a strange thing > > > that it has been super quiet

Re: pull request: wireless-2.6 'upstream' 2008-01-22

2008-01-23 Thread Stefano Brivio
On Tue, 22 Jan 2008 20:45:21 -0500 "John W. Linville" <[EMAIL PROTECTED]> wrote: > b43legacy: Remove the PHY spinlock I hope you tested this. I still haven't been able to (I received the needed hardware yesterday), and Michael said that the patch has been compile-tested only. -- Ciao Ste

Re: pull request: wireless-2.6 'upstream' 2008-01-22

2008-01-23 Thread Michael Buesch
On Wednesday 23 January 2008 12:15:51 Stefano Brivio wrote: > On Tue, 22 Jan 2008 20:45:21 -0500 > "John W. Linville" <[EMAIL PROTECTED]> wrote: > > > b43legacy: Remove the PHY spinlock > > I hope you tested this. I still haven't been able to (I received the > needed hardware yesterday), an

Re: Assertions in latest kernels

2008-01-23 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 12:49:31 +0200 (EET) > On Wed, 23 Jan 2008, Ilpo Järvinen wrote: > > Hmm, perhaps it could be something related to this (and some untested > path somewhere which is now exposed): > > commit 4a55b553f691abadaa63570dfc714e20913561c1

Re: 2.6.24-rc8 ppp regression

2008-01-23 Thread Evgeniy Polyakov
On Wed, Jan 23, 2008 at 10:35:09AM +0100, maximilian attems ([EMAIL PROTECTED]) wrote: > Jan 22 23:23:13 dual kernel: unregister_netdevice: waiting for ppp0 to become > free. Usage count = 1 > Jan 22 23:23:44 dual last message repeated 3 times > Jan 22 23:23:54 dual kernel: unregister_netdevice:

Re: Assertions in latest kernels

2008-01-23 Thread Ilpo Järvinen
On Wed, 23 Jan 2008, Krishna Kumar2 wrote: > While running with this patch, I got these errors (pasted at the end > of this mail). I don't have a clue why it didn't go to the checking func (or it didn't print anything) but just had those WARN_ONs... Hopefully this is giving somewhat better inpu

[PATCH] Introducing socket mark socket option

2008-01-23 Thread Laszlo Attila Toth
A userspace program may wish to set the mark for each packets its send without using the netfilter MARK target. Changing the mark can be used mark based routing without netfilter or for packet filtering. It requires CAP_NET_ADMIN capability. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> -

Re: pull request: wireless-2.6 'upstream' 2008-01-22

2008-01-23 Thread John W. Linville
On Wed, Jan 23, 2008 at 12:15:51PM +0100, Stefano Brivio wrote: > On Tue, 22 Jan 2008 20:45:21 -0500 > "John W. Linville" <[EMAIL PROTECTED]> wrote: > > > b43legacy: Remove the PHY spinlock > > I hope you tested this. I still haven't been able to (I received the > needed hardware yesterday)

Re: pull request: wireless-2.6 'upstream' 2008-01-22

2008-01-23 Thread John W. Linville
On Wed, Jan 23, 2008 at 12:30:07PM +0100, Michael Buesch wrote: > On Wednesday 23 January 2008 12:15:51 Stefano Brivio wrote: > > On Tue, 22 Jan 2008 20:45:21 -0500 > > "John W. Linville" <[EMAIL PROTECTED]> wrote: > > > > > b43legacy: Remove the PHY spinlock > > > > I hope you tested this.

Re: [PATCH 2.6.23+] ingress classify to [nf]mark

2008-01-23 Thread Dzianis Kahanovich
Too many pixels to smoke. Sorry. May be so? ;)) (if undefined classid not overwrited by random value tc_classify) Even "tc" say to classid=0 - "" --- 1/net/sched/sch_ingress.c 2008-01-12 17:27:05.0 +0200 +++ 2/net/sched/sch_ingress.c 2008-01-22 22:09:32.0 +0200 @@ -136,6

Re: [Cbe-oss-dev] [PATCH 1/5] spidernet: add missing initialization

2008-01-23 Thread Jens Osterkamp
On Friday 11 January 2008, Ishizaki Kou wrote: > This patch fixes initialization of "aneg_count" and "medium" fields in > spider_net_card to make spidernet driver correctly sets "link status". > > Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Acked-by: Jens Osterkamp <[EMAIL PROTECTED]> > ---

Re: [Cbe-oss-dev] [PATCH 2/5] spidernet: increase auto-negotiation timeout to 5 seconds

2008-01-23 Thread Jens Osterkamp
On Friday 11 January 2008, Ishizaki Kou wrote: > This patch extends the timeout for spidernet auto-negotiation. > Auto-negotiation often fails to finish in 2 seconds. > > Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Acked-by: Jens Osterkamp <[EMAIL PROTECTED]> > --- > > Index: linux-powerpc-

Re: [Cbe-oss-dev] [PATCH 3/5] spidernet: change interrupt masks

2008-01-23 Thread Jens Osterkamp
On Friday 11 January 2008, Ishizaki Kou wrote: > This patch changes spidernet interrupt masks. > > - unmask GDAINVAINT. There is an operation to do by spidernet >interrupt handler. > - mask some interrupts. There are no operations in the interrupt handler. > > Signed-off-by: Kou Ishizaki <[

Re: [Cbe-oss-dev] [PATCH 4/5] spidernet: fix error interrupt handling

2008-01-23 Thread Jens Osterkamp
On Friday 11 January 2008, Ishizaki Kou wrote: > In addition to the value of GHIINT0STS, spidernet interrupt handler > should check the values of GHIINT1STS/GHIINT2STS registers at the > beginning of spider_net_interrupt() so as not to drop error > interrupts. > > GHIINT1STS/GHIINT2STS registers i

Re: [Cbe-oss-dev] [PATCH 5/5] spidernet: revise link status logging

2008-01-23 Thread Jens Osterkamp
On Friday 11 January 2008, Ishizaki Kou wrote: > This patch revises the logging for link informations of spidernet. > > - The link down message is too verbose because auto-negotiation timeout > occurs periodically while an ethernet cable is not connected. > - We want to see the link resul

[IPV4 0/9] TRIE performance patches

2008-01-23 Thread Robert Olsson
Stephen Hemminger writes: > Time to handle a full BGP load (163K of routes). > > Before: LoadDumpFlush > > kmem_cache 3.8 13.07.2 > iter 3.9 12.36.9 > unordered3.1 11.9

Re: [PATCH] Introducing socket mark socket option

2008-01-23 Thread Patrick McHardy
Laszlo Attila Toth wrote: A userspace program may wish to set the mark for each packets its send without using the netfilter MARK target. Changing the mark can be used mark based routing without netfilter or for packet filtering. It requires CAP_NET_ADMIN capability. @@ -403,6 +403,7 @@ stat

[PATCH 1/3] Cleanup and simplify virtnet header

2008-01-23 Thread Rusty Russell
1) Turn GSO on virtio net into an all-or-nothing (keep checksumming separate). Having multiple bits is a pain: if you can't support something you should handle it in software, which is still a performance win. 2) Make VIRTIO_NET_HDR_GSO_ECN a flag in the header, so it can apply to IPv6 o

[PATCH 2/3] partial checksum and GSO support for tun/tap.

2008-01-23 Thread Rusty Russell
(Changes since last time: we how have explicit IFF_RECV_CSUM and IFF_RECV_GSO bits, and some renaming of virtio_net hdr) We use the virtio_net_hdr: it is an ABI already and designed to encapsulate such metadata as GSO and partial checksums. IFF_VIRTIO_HDR means you will write and read a 'struct

[PATCH 3/3] Interface to query tun/tap features.

2008-01-23 Thread Rusty Russell
(No real change, just updated with new bits) The problem with introducing IFF_RECV_CSUM and IFF_RECV_GSO is that they need to set dev->features to enable GSO and/or checksumming, which is supposed to be done before register_netdevice(), ie. as part of TUNSETIFF. Unfortunately, TUNSETIFF has alway

[PATCH net-2.6.25] [PKTGEN] Remove an unused definition in pktgen.c.

2008-01-23 Thread Rami Rosen
Hi, - Remove an unused definition (LAT_BUCKETS_MAX) in net/core/pktgen.c. - Remove the corresponding comment. - The LAT_BUCKETS_MAX seems to have to do with a patch from a long time ago which was not applied (Ben Greear), which dealt with latency counters. See, for example : http://oss.sgi.com/arc

My 802.3ad is my bond

2008-01-23 Thread Steven Whitehouse
Hi, This commit: ece95f7fefe3afae19e641e1b3f5e64b00d5b948 seems to have caused a problem with parsing bond arguments as now only the numeric arguments seem to work (in modprobe.conf) and specifying 802.3ad fails. When I revert that patch in my local tree all seems ok. Also I notice that one of my

Re: [IPV4 0/9] TRIE performance patches

2008-01-23 Thread Stephen Hemminger
Robert Olsson wrote: Stephen Hemminger writes: > Time to handle a full BGP load (163K of routes). > > Before: Load Dump Flush > > kmem_cache3.8 13.07.2 > iter 3.9 12.36.9 > unordered 3.1 11.9

[NET_SCHED 00/15]: Make use of new netlink API features

2008-01-23 Thread Patrick McHardy
Hi Dave, these patches change the packet schedulers/classifers/actions to make use of the features of the new netlink API, like typeful attribute dumping and parsing, automatic basic attribute validation etc. The also fix a bug and a warning introduced by my last set of patches. Please apply, tha

[NET_SCHED 01/15]: sch_atm: fix format string warning

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: sch_atm: fix format string warning Fix format string warning introduces by the netlink API conversion: net/sched/sch_atm.c:250: warning: format '%lu' expects type 'long unsigned int', but argument 3 has type 'int'. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 3bab

[NET_SCHED 02/15]: sch_netem: use nla_parse_nested_compat

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: sch_netem: use nla_parse_nested_compat Replace open coded equivalent of nla_parse_nested_compat(). Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 1af28b79f4f0a67db344938ef6739ad2af1a72a7 tree 52294414fad2e6cd11aa719113f160a47bbe5bd5 parent 3bab4166cf0350552419d7871b4d

[NET_SCHED 03/15]: act_api: fix netlink API conversion bug

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: act_api: fix netlink API conversion bug Fix two invalid attribute accesses, indices start at 1 with the new netlink API. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 512b2ab20730e1d24e36fb94eab4a2731e90e315 tree e3583125570ee0c7a57feac7aa6fcabe2541112a parent 1af28b

[NET_SCHED 04/15]: act_api: use nlmsg_parse

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: act_api: use nlmsg_parse Convert open-coded nlmsg_parse to use the real function. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit f9f9cbaccb1a58ea02318250192effe1e2e1e715 tree 7ea770493ca465a7aac1a7779b2aa4c593de3a97 parent 512b2ab20730e1d24e36fb94eab4a2731e90e315 auth

[NET_SCHED 05/15]: act_api: use PTR_ERR in tcf_action_init/tcf_action_get

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: act_api: use PTR_ERR in tcf_action_init/tcf_action_get Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 0919ac24aa4bd6978806f35f8daefe32aa997823 tree 95e2c04521d6a09c080eac8735ab0598c3b3ff5b parent f9f9cbaccb1a58ea02318250192effe1e2e1e715 author Patrick McHardy <[EMAIL P

[NET_SCHED 06/15]: Propagate nla_parse return value

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: Propagate nla_parse return value nla_parse() returns more detailed errno codes, propagate them back on error. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit f9b5ab497909e836983bc31e5e7ad5065ccba6bc tree 3b2ca0f7dcf925d113fce3e376cf7f2e995f0b7a parent 0919ac24aa4bd6978

[NET_SCHED 07/15]: Use nla_nest_start/nla_nest_end

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: Use nla_nest_start/nla_nest_end Use nla_nest_start/nla_nest_end for dumping nested attributes. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit bdd38a3b14cfa340da580f6e825d7f1142925926 tree 36dc82b63837c96b0f5e1b5c508f789abe7414e8 parent f9b5ab497909e836983bc31e5e7ad506

[NET_SCHED 08/15]: Use NLA_PUT_STRING for string dumping

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: Use NLA_PUT_STRING for string dumping Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit ad688fbdf7dd0ebeb1b2fba0d7d2105bdf3c6de9 tree 68bb3e1dc3484d6ca0e7ddc55ad4e25864aaac84 parent bdd38a3b14cfa340da580f6e825d7f1142925926 author Patrick McHardy <[EMAIL PROTECTED]> Wed, 2

[NET_SCHED 10/15]: Use typeful attribute parsing helpers

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: Use typeful attribute parsing helpers Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 3e73383f7c353af51e8cc475f1c217a6b81fcecf tree 53d369ca2ffca26cf46c57d2a9043d53da7474f8 parent 04d3c2781cba0b4ab75005de0defdb2a58178f21 author Patrick McHardy <[EMAIL PROTECTED]> Wed, 2

[NET_SCHED 09/15]: Use typeful attribute construction helpers

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: Use typeful attribute construction helpers Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 04d3c2781cba0b4ab75005de0defdb2a58178f21 tree a1b904b7f29ad1ff7cff310128b3fd67e2543278 parent ad688fbdf7dd0ebeb1b2fba0d7d2105bdf3c6de9 author Patrick McHardy <[EMAIL PROTECTED]> W

[NET_SCHED 11/15]: sch_api: introduce constant for rate table size

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: sch_api: introduce constant for rate table size Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit b21f31e516f993016f8a1ade331bcaf71576b4e2 tree e59049e1fb3f2711d83c196d2f54b5021dc68330 parent 3e73383f7c353af51e8cc475f1c217a6b81fcecf author Patrick McHardy <[EMAIL PROTECTE

[NET_SCHED 12/15]: Use nla_policy for attribute validation in packet schedulers

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: Use nla_policy for attribute validation in packet schedulers Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 76c3c24283fa9f78d8dc30c8eb73e0f11934bf69 tree bcc9baf4eae9086d377efff17fbd37a360ac64b7 parent b21f31e516f993016f8a1ade331bcaf71576b4e2 author Patrick McHardy <[E

[NET_SCHED 13/15]: Use nla_policy for attribute validation in classifiers

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: Use nla_policy for attribute validation in classifiers Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit d177578bdf08849a388f1bc42a1d0566c6a3aded tree 2eda0cf1e0479dab464acda9def525df27bd4307 parent 76c3c24283fa9f78d8dc30c8eb73e0f11934bf69 author Patrick McHardy <[EMAIL P

[NET_SCHED 15/15]: Use nla_policy for attribute validation in ematches

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: Use nla_policy for attribute validation in ematches Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 9420f06512465a8a90f3ff0df8b943989bc7e2e7 tree 7556b31b93647c9d2c30eb567b50671d368f8ced parent 99302e1c1ed003305e9a0102aa772e2f2d61114c author Patrick McHardy <[EMAIL PROT

[NET_SCHED 14/15]: Use nla_policy for attribute validation in actions

2008-01-23 Thread Patrick McHardy
[NET_SCHED]: Use nla_policy for attribute validation in actions Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 99302e1c1ed003305e9a0102aa772e2f2d61114c tree 05286e8f9d74ad273d6a6e12d7bc794a19c4ea4c parent d177578bdf08849a388f1bc42a1d0566c6a3aded author Patrick McHardy <[EMAIL PROTE

Re: My 802.3ad is my bond

2008-01-23 Thread Jay Vosburgh
Steven Whitehouse <[EMAIL PROTECTED]> wrote: [...] >This commit: ece95f7fefe3afae19e641e1b3f5e64b00d5b948 seems to have >caused a problem with parsing bond arguments as now only the numeric >arguments seem to work (in modprobe.conf) and specifying 802.3ad fails. >When I revert that patch in my loca

Re: My 802.3ad is my bond

2008-01-23 Thread Steven Whitehouse
Hi, On Wed, 2008-01-23 at 09:13 -0800, Jay Vosburgh wrote: > Steven Whitehouse <[EMAIL PROTECTED]> wrote: > [...] > >This commit: ece95f7fefe3afae19e641e1b3f5e64b00d5b948 seems to have > >caused a problem with parsing bond arguments as now only the numeric > >arguments seem to work (in modprobe.co

SCTP NAT module for netfilter

2008-01-23 Thread Sohan Shetty
Is  anyone aware if there an  NAT module for netfilter being developed for SCTP protocol ? I have searched the netfilter development tree source code and also mailing list and so far I have not found the NAT module for SCTP . There is SCTP conntrack module and packet match module. If anyone

RE: [ipw3945-devel] [PATCH 1/5] iwlwifi: iwl3945 flush interrupt mask

2008-01-23 Thread Chatre, Reinette
Joonwoo Park <[EMAIL PROTECTED]> wrote: > interrupt mask > > After enabling/disabling interrupts flushing is required > I have been looking at this patch and I would like to get some more feedback from the experts in the group. First off, the register used for the read in order to flush has to

[PATCH 0/3] A few more pasemi_mac patches for 2.6.25

2008-01-23 Thread Olof Johansson
Hi, This should be the last of my updates for 2.6.25: 1/3: pasemi_mac: Add support for changing mac address 2/3: pasemi_mac: add support for setting MTU 3/3: pasemi_mac: Disable interface on close Thanks, Olof -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

[PATCH 3/3] pasemi_mac: Disable interface on close

2008-01-23 Thread Olof Johansson
Turns out we never disable the interface. It doesn't really cause any problems since the channel is off, but it's still better to do it this way. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c index 059c6b0..2e39e02 100644 --

[PATCH 1/3] pasemi_mac: Add support for changing mac address

2008-01-23 Thread Olof Johansson
Straightforward. It used to be hardcoded and impossible to override with ifconfig. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c index bb88a41..59dea3f 100644 --- a/drivers/net/pasemi_mac.c +++ b/drivers/net/pasemi_mac.c @@ -221

[PATCH 2/3] pasemi_mac: add support for setting MTU

2008-01-23 Thread Olof Johansson
Currently keeping it at 1500 bytes or below since jumbo frames need special checksum offload on TX. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c index 59dea3f..059c6b0 100644 --- a/drivers/net/pasemi_mac.c +++ b/drivers/net/pas

arp queries and ipsec policy

2008-01-23 Thread Marco Berizzi
Hello everybody. I'm using openswan 2.4.x to drive the linux 2.4.23.14 ipsec native stack (netkey). Openswan by default insert a static route when an ipsec SA is established: this is needed by the klips stack as it is routing based. For example when a roadwarrior establish an ipsec SA with the linu

Re: [PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-23 Thread Eric Dumazet
[EMAIL PROTECTED] a écrit : On Mon, Jan 21, 2008 at 02:40:43AM -0800, David Miller wrote: From: Joonwoo Park <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 00:08:57 +0900 The rt_run_flush() can be stucked if it was called while netdev is on the high load. It's possible when pushing rtable to rt_h

RE: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

2008-01-23 Thread Ramkrishna Vepa
> Sreenivasa Honnur <[EMAIL PROTECTED]> writes: > > > Multiqueue netwrok device support implementation. > > - Added a loadable parameter "multiq" to enable/disable multiqueue > support, > > by default it is disabled. > > - skb->queue_mapping is not used for queue/fifo selection. FIFO > iselectio

arping

2008-01-23 Thread Michaelian Ennis
Someone filed a bug at bugs.gentoo.org reflecting a possible enhancement to arping. In short the patches author felt that select should be used instead of signals to avoid missing a timeout. The bug is located at: http://bugs.gentoo.org/show_bug.cgi?id=144526 The diff follows: --- arping.c2

Re: [PATCH] BUG_ON() bad input to request_irq

2008-01-23 Thread Andrew Morton
> On Thu, 17 Jan 2008 17:59:58 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote: > Is there any reason why these bugs should be treated gently? The > caller might not want to check NR_IRQS and IRQ_NOREQUEST cases, but > a NULL handler or NULL dev_id w/ shared are coding bugs. > > Signed-off-by: Rust

Re: [PATCH] bluetooth : move children of connection device to NULL before connection down

2008-01-23 Thread Andrew Morton
> On Tue, 22 Jan 2008 07:18:16 +0100 Marcel Holtmann <[EMAIL PROTECTED]> wrote: > Hi Dave, > > > > Add people missed in cc-list. > > > > Thanks Dave for your continued efforts on Bluetooth bugs like this. > > > > Marcel, are you going to review/ACK/integrate/push-upstream/whatever > > any of the

Re: [PATCH] BUG_ON() bad input to request_irq

2008-01-23 Thread Rusty Russell
On Thursday 24 January 2008 09:04:14 Andrew Morton wrote: > > On Thu, 17 Jan 2008 17:59:58 +1100 Rusty Russell <[EMAIL PROTECTED]> > If no driver is passing in args which will trigger this BUG, we presumably > don't need the patch. You're only thinking of current code. The BUG catches future chan

[IPV4 1/5] fib_trie: more whitespace cleanup

2008-01-23 Thread Stephen Hemminger
Remove extra blank lines. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-22 17:46:28.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-22 17:50:44.0 -0800 @@ -447,7 +447,6 @@ static void tnode_put_child_reorg(struct BUG_ON(i >

[IPV4 2/5] fib_trie: remove unneeded NULL check

2008-01-23 Thread Stephen Hemminger
Since fib_route_seq_show now uses hlist_for_each_entry(), the leaf info can not be NULL. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-22 17:50:44.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-22 17:50:58.0 -0800 @@ -2474,9 +2474,6

[IPV4 4/5] fib_trie: version 0.410

2008-01-23 Thread Stephen Hemminger
Increase version to reflect recent changes. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-22 17:50:58.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-22 17:51:02.0 -0800 @@ -50,7 +50,7 @@ * Patrick McHardy <[EMAIL PROTE

[IPV4 3/5] fib_trie: dump doesnt use RCU

2008-01-23 Thread Stephen Hemminger
Since fib dump (via netlink) holds the RTNL mutex, it is unnecessary to use RCU, and it is impossible to get truncated (-EBUSY) result. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-23 13:55:12.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01

[IPV4 5/5] fib_semantics: sparse warnings

2008-01-23 Thread Stephen Hemminger
The magic macro change_nexthops introduces a variable nh which overlaps previous declaration of nh. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_semantics.c 2008-01-23 11:03:55.0 -0800 +++ b/net/ipv4/fib_semantics.c 2008-01-23 11:05:12.0 -0800 @@ -105

[PATCH] ppp: sparse warning fixes

2008-01-23 Thread Stephen Hemminger
Fix a bunch of warnings in PPP and related drivers. Mostly because sparse doesn't like it when the the function is only marked private in the forward declaration. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/ppp_deflate.c |4 ++-- drivers/net/ppp_generic.c |2 +-

Re: [IPV4 0/9] TRIE performance patches

2008-01-23 Thread Stephen Hemminger
On Wed, 23 Jan 2008 15:06:47 +0100 Robert Olsson <[EMAIL PROTECTED]> wrote: > > Stephen Hemminger writes: > > > Time to handle a full BGP load (163K of routes). > > > > Before:LoadDumpFlush > > > > kmem_cache 3.8 13.07.2 > > iter

Re: [PATCH] bluetooth : move children of connection device to NULL before connection down

2008-01-23 Thread Dave Young
On Wed, Jan 23, 2008 at 02:06:29PM -0800, Andrew Morton wrote: > > On Tue, 22 Jan 2008 07:18:16 +0100 Marcel Holtmann <[EMAIL PROTECTED]> > > wrote: > > Hi Dave, > > > > > > Add people missed in cc-list. > > > > > > Thanks Dave for your continued efforts on Bluetooth bugs like this. > > > > > >

Re: [PATCH] bluetooth : move children of connection device to NULL before connection down

2008-01-23 Thread Dave Young
On Thu, Jan 24, 2008 at 09:19:26AM +0800, Dave Young wrote: > On Wed, Jan 23, 2008 at 02:06:29PM -0800, Andrew Morton wrote: > > > On Tue, 22 Jan 2008 07:18:16 +0100 Marcel Holtmann <[EMAIL PROTECTED]> > > > wrote: > > > Hi Dave, > > > > > > > > Add people missed in cc-list. > > > > > > > > Than

Re: [PATCH] [POWERPC] Add fixed-phy support for fs_enet

2008-01-23 Thread Kumar Gala
On Tue, 18 Dec 2007, Jochen Friedrich wrote: > This patch adds support to use the fixed-link property > of an ethernet node to fs_enet for the > CONFIG_PPC_CPM_NEW_BINDING case. > > Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> > Acked-by: Jeff Garzik <[EMAIL PROTECTED]> > Acked-by: Vitali B

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-23 Thread Dave Young
On Jan 23, 2008 7:01 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > On Wed, 23 Jan 2008, Ilpo Järvinen wrote: > > > On Wed, 23 Jan 2008, Dave Young wrote: > > > > > On Jan 23, 2008 3:41 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > > > > > > > On Tue, 22 Jan 2008, David Miller wrote: > > > > > >

bluetooth : lockdep warning on rfcomm

2008-01-23 Thread Dave Young
= [ INFO: possible recursive locking detected ] 2.6.24-rc8-mm1 #8 - bluepush/3213 is trying to acquire lock: (sk_lock-AF_BLUETOOTH){--..}, at: [] l2cap_sock_bind+0x40/0x100 [l2cap] but task is already holding

Re: [PATCH 0/6] PS3: gelic: gelic updates for 2.6.25

2008-01-23 Thread John W. Linville
On Tue, Jan 22, 2008 at 07:12:44PM -0800, Geoff Levand wrote: > On 01/22/2008 04:58 PM, John W. Linville wrote: > > I thought Geert's had been applied, but I guess I was looking at > > it wrong. Is there a powerpc tree that has them? > > Not yet, they are now only in ps3-linux.git. I sent them

[PATCH 2/2] sky2: fix Wake On Lan interaction with BIOS

2008-01-23 Thread Stephen Hemminger
This patch disables config mode access after clearing PCI settings. Some BIOS's seem to not do WOL if config bit still set. Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=9721 Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- Please get this into 2.6.24. --- a/drivers/net/sky2.c

[PATCH 1/2] sky2: restore multicast addresses after recovery

2008-01-23 Thread Stephen Hemminger
If the sky2 deadman timer forces a recovery, the multicast hash list is lost. Move the call to sky2_set_multicast to the end of sky2_up() so all paths that bring device up will restore multicast. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- Please apply for 2.6.24 --- a/drivers/net/s

[PATCH UCC TDM 0/3] UCC based TDM driver for QE based MPC83xx platforms

2008-01-23 Thread Aggrwal Poonam
Reworked patches after incorporating comments of Andrew, Stephen and Tabi and Kumar. Kumar could you please consider them for linux-2.6.25. There are three patches [PATCH 1/3] drivers/misc : UCC TDM driver for mpc83xx platforms. This driver is usable in VoIP iind of applications to interface wit

Re: [NET_SCHED 00/15]: Make use of new netlink API features

2008-01-23 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 17:36:35 +0100 (MET) > these patches change the packet schedulers/classifers/actions to make use > of the features of the new netlink API, like typeful attribute dumping and > parsing, automatic basic attribute validation etc. The al

Re: [IPV4 1/5] fib_trie: more whitespace cleanup

2008-01-23 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 14:48:45 -0800 > Remove extra blank lines. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

Re: [IPV4 2/5] fib_trie: remove unneeded NULL check

2008-01-23 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 14:48:46 -0800 > Since fib_route_seq_show now uses hlist_for_each_entry(), the > leaf info can not be NULL. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubs

[PATCH] UCC TDM driver for QE based MPC83xx platforms.

2008-01-23 Thread Poonam_Aggrwal-b10812
From: Poonam Agarwal-b10812 <[EMAIL PROTECTED]> The UCC TDM driver basically multiplexes and demultiplexes data from different channels. It can interface with for example SLIC kind of devices to receive TDM data demultiplex it and send to upper modules. At the transmit end it receives data for d

Re: [IPV4 3/5] fib_trie: dump doesnt use RCU

2008-01-23 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 14:48:47 -0800 > Since fib dump (via netlink) holds the RTNL mutex, it is unnecessary > to use RCU, and it is impossible to get truncated (-EBUSY) result. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> You tested this p

[PATCH 2/3] Platform changes for UCC TDM driver for MPC8323ERDB.Also includes related QE changes and dts entries.

2008-01-23 Thread Poonam_Aggrwal-b10812
From: Poonam Aggrwal <[EMAIL PROTECTED]> This patch makes necessary changes in the QE and UCC framework to support TDM. It also adds support to configure the BRG properly through device tree entries. Includes the device tree changes for UCC TDM driver as well. It also includes device tree entrie

Re: [IPV4 4/5] fib_trie: version 0.410

2008-01-23 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 14:48:48 -0800 > Increase version to reflect recent changes. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> I'm dropping this and patch 5 for now. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] ppp: sparse warning fixes

2008-01-23 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 15:40:19 -0800 > Fix a bunch of warnings in PPP and related drivers. Mostly because > sparse doesn't like it when the the function is only marked private > in the forward declaration. > > Signed-off-by: Stephen Hemminger <[EMAIL P

rebasing net-2.6.25...

2008-01-23 Thread David Miller
I am going to work throughout the evening to rebase the net-2.6.25 GIT tree. I'm heading off to LCA08 tomorrow afternoon so I wanted to get this out of the way before leaving. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More m

[PATCH UCC TDM 3/3 ] Modified Documentation to explain dts entries for TDM driver

2008-01-23 Thread Poonam_Aggrwal-b10812
From: Poonam Aggrwal <[EMAIL PROTECTED]> Modified Documentation to explain new properties introduced for UCC TDM driver. Also two new nodes have been added "brg" and "clocks" to configure a BRG from device tree. Signed-off-by: Poonam Aggrwal <[EMAIL PROTECTED]> Signed-off-by: Ashish Kalra <[EM

Re: [PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-23 Thread Joonwoo Park
2008/1/24, Eric Dumazet <[EMAIL PROTECTED]>: > > Unfortunatly, your patch doesnt work on CONFIG_SMP=n (softirq will be disabled > for the whole scan of table) > > Also, some machines around there have 2^22 slots in hash table, and NR_CPUS=4, > so softirqs will be disabled for a too long time. > > P

[PATCH 6/6 v2] PS3: gelic: Add support for dual network interface

2008-01-23 Thread Masakazu Mokuno
Add support for dual network (net_device) interface so that ethernet and wireless can own separate ethX interfaces. V2 - Fix the bug that bringing down and up the interface keeps rx disabled. - Make 'gelic_net_poll_controller()' extern , as David Woodhouse pointed out at the previous

  1   2   >