Re: [PATCH v3 net-next 2/2] rocker: mark parameters and local variables as const

2015-05-25 Thread Jiri Pirko
Mon, May 25, 2015 at 07:28:36AM CEST, simon.hor...@netronome.com wrote: >Mark parameters and local variables as const where possible. > >Signed-off-by: Simon Horman >Acked-by: Scott Feldman Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-25 Thread Nicolas Dichtel
Le 22/05/2015 22:50, Alexander Holler a écrit : Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: So I am dense. I have read through the patches and I don't see where you tag packets from other network namespaces with a network namespace id. Me too, I've recently written a little tool calle

[PATCH net-next 2/4] net: cpsw: remove two unused global functions

2015-05-25 Thread Richard Cochran
The funtions, cpsw_ale_flush and cpsw_ale_set_ageout, have never been used since they were first introduced. This patch removes the dead code. Signed-off-by: Richard Cochran --- drivers/net/ethernet/ti/cpsw_ale.c | 45 -- drivers/net/ethernet/ti/cpsw_ale.h |

[PATCH net-next 0/4] cpsw cleanups

2015-05-25 Thread Richard Cochran
While working on an out-of-tree customization, I noticed a few minor problems in the cpsw code. This series cleans up the issues I found. Thanks, Richard Richard Cochran (4): net: cpsw: fix misplaced break statements. net: cpsw: remove two unused global functions net: cpsw: remove redunda

[PATCH net-next 4/4] net: cpsw: remove redundant calls disabling dma interrupts.

2015-05-25 Thread Richard Cochran
The function, cpsw_intr_disable, already calls cpdma_ctlr_int_ctrl. There is no need to disable the dma interrupts twice. This patch removes the extra calls. Signed-off-by: Richard Cochran --- drivers/net/ethernet/ti/cpsw.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethe

[PATCH net-next 3/4] net: cpsw: remove redundant calls enabling dma interrupts.

2015-05-25 Thread Richard Cochran
The function, cpsw_intr_enable, already calls cpdma_ctlr_int_ctrl. There is no need to enable the dma interrupts twice. This patch removes the extra call. Signed-off-by: Richard Cochran --- drivers/net/ethernet/ti/cpsw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next 1/4] net: cpsw: fix misplaced break statements.

2015-05-25 Thread Richard Cochran
Having the breaks too far to the left makes parsing the dense switch/case block unnecessarily harder. Signed-off-by: Richard Cochran --- drivers/net/ethernet/ti/cpsw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Dan Carpenter
On Sun, May 24, 2015 at 07:11:40PM -0500, Larry Finger wrote: > On 05/24/2015 02:03 PM, Haggai Eran wrote: > >On 24 May 2015 at 00:16, Larry Finger wrote: > >>The driver is reporting a warning at kernel/time/timer.c:1096 due to calling > >>del_timer_sync() while in interrupt mode. Such warnings ar

[PATCH net 0/3] phyter bug fixes

2015-05-25 Thread Richard Cochran
While working on a project using the phyter, I noticed some bugs that have crept in over time. This series fixes those bugs. These patches are also meant for stable. Thanks, Richard Richard Cochran (3): net: dp83640: fix broken calibration routine. net: dp83640: reinforce locking rules.

[PATCH net 1/3] net: dp83640: fix broken calibration routine.

2015-05-25 Thread Richard Cochran
Currently, the calibration function that corrects the initial offsets among multiple devices only works the first time. If the function is called more than once, the calibration fails and bogus offsets will be programmed into the devices. In a well hidden spot, the device documentation tells that

[PATCH net 3/3] net: dp83640: fix improper double spin locking.

2015-05-25 Thread Richard Cochran
A pair of nested spin locks was introduced in commit 63502b8d0 "dp83640: Fix receive timestamp race condition". Unfortunately the 'flags' parameter was reused for the inner lock, clobbering the originally saved IRQ state. This patch fixes the issue by changing the inner lock to plain spin_lock wi

[PATCH net 2/3] net: dp83640: reinforce locking rules.

2015-05-25 Thread Richard Cochran
Callers of the ext_write function are supposed to hold a mutex that protects the state of the dialed page, but one caller was missing the lock from the very start, and over time the code has been changed without following the rule. This patch cleans up the call sites in violation of the rule. Sig

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Dan Carpenter
On Mon, May 25, 2015 at 03:07:08PM +0530, Vaishali Thakkar wrote: > I am sorry for those patches. It was me who introduced those bugs. Yes, it > was sent during Outreachy process. But it was my mistake as a newbie. May > be I should have taken care of interrupt mode thing. > > I would like to fix

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-25 Thread Herbert Xu
On Sun, May 24, 2015 at 12:52:02PM +0200, Stephan Mueller wrote: > > [ 29.653113] BUG: unable to handle kernel NULL pointer dereference at > 000c Weird. I tried running your test but it appears to pass. The only failures were the nonsense strings and everything else says pased.

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-25 Thread Alexander Holler
Am 25.05.2015 um 09:45 schrieb Nicolas Dichtel: Le 22/05/2015 22:50, Alexander Holler a écrit : First I think if NETLINK_LISTEN_ALL_NSID is enabled, a dump of the interfaces through RTM_GETLINK together with NLM_F_DUMP and NLM_F_REQUEST should return all interfaces of all reachable namespaces.

Re: pull-request: wireless-drivers-next 2015-05-21

2015-05-25 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Thu, 21 May 2015 16:39:04 +0300 > >> here's a wireless-drivers pull request for 4.2. This time please pay >> extra attention to this pull as there are two problems: >> >> First of all as you can see the diffstat from git-pull-request in the >> end

Re: [PATCH net-next] bridge: skip fdb add if the port shouldn't learn

2015-05-25 Thread Nikolay Aleksandrov
On Mon, May 25, 2015 at 4:59 AM, David Miller wrote: > From: Nikolay Aleksandrov > Date: Thu, 21 May 2015 03:42:57 -0700 > >> From: Wilson Kok >> >> Check in fdb_add_entry() if the source port should learn, similar >> check is used in br_fdb_update. >> Note that new fdb entries which are added m

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-25 Thread Stephan Mueller
Am Montag, 25. Mai 2015, 18:20:21 schrieb Herbert Xu: Hi Herbert, > On Sun, May 24, 2015 at 12:52:02PM +0200, Stephan Mueller wrote: > > [ 29.653113] BUG: unable to handle kernel NULL pointer dereference at > > 000c > > Weird. I tried running your test but it appears to pass. The

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-25 Thread Herbert Xu
On Mon, May 25, 2015 at 01:50:55PM +0200, Stephan Mueller wrote: > > When you have my code local, simply execute libkcapi/test/kcapi -y twice or > three times. That triggered the crash. Aha that's what I was missing. I'll look into the crash. Thanks, -- Email: Herbert Xu Home Page: http://gon

pull-request: wireless-drivers 2015-05-25

2015-05-25 Thread Kalle Valo
Hi Dave, here's hopefully the last wireless-drivers pull request for 4.1. Mostly iwlwifi fixes this time. Please let me know if there are any problems. Kalle The following changes since commit f673821864899153142365aca888435815ac93f0: ath9k: fix per-packet tx power configuration (2015-05-03 2

[PATCH net] tools: bpf_jit_disasm: fix segfault on disabled debugging log output

2015-05-25 Thread Daniel Borkmann
With recent debugging, I noticed that bpf_jit_disasm segfaults when there's no debugging output from the JIT compiler to the kernel log. Reason is that when regexec(3) doesn't match on anything, start/end offsets are not being filled out and contain some uninitialized garbage from stack. Thus, we

[PATCH 1/3 nf-next] netfilter: default CONFIG_NETFILTER_INGRESS to y

2015-05-25 Thread Pablo Neira Ayuso
Useful to compile-test all options. Suggested-by: by Alexei Stavoroitov Signed-off-by: Pablo Neira Ayuso --- net/netfilter/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index db1c674..9a89e7c 100644 --- a/net/netfilter/Kconfig +++ b

[PATCH libnftnl] table: add netdev family support

2015-05-25 Thread Pablo Neira Ayuso
This adds support for the new 'netdev' family tables. Signed-off-by: Pablo Neira Ayuso --- include/buffer.h|1 + include/libnftnl/table.h|1 + include/linux/netfilter.h |8 include/linux/netfilter/nf_tables.h |2 ++ src/chain.c

[PATCH 0/3 nf-next] nf_tables support at ingress

2015-05-25 Thread Pablo Neira Ayuso
Hi, This is the follow-up patchset to add nf_tables on top of the Netfilter ingress hook [1] now available in the net-next tree: 1) default CONFIG_NETFILTER_INGRESS to y for easier compile-testing of all options. 2) Allow to bind a table to net_device. This introduces the internal NFT_AF_N

[PATCH 3/3 nf-next] netfilter: nf_tables: add netdev table to filter from ingress

2015-05-25 Thread Pablo Neira Ayuso
This allows us to create netdev tables that contain ingress chains. Use skb_header_pointer() as we may see shared sk_buffs at this stage. This change provides access to the existing nf_tables features from the ingress hook. Signed-off-by: Pablo Neira Ayuso --- include/net/netns/nftables.h |

[PATCH nft] src: add netdev family support

2015-05-25 Thread Pablo Neira Ayuso
This patch adds support for the new 'netdev' table. So far, this table allows you to create filter chains from ingress. The following example shows a very simple base configuration with one table that is bound to device 'eth0' with a single ingress chain: # nft list table netdev eth0 table netd

[PATCH 2/3 nf-next] netfilter: nf_tables: allow to bind table to net_device

2015-05-25 Thread Pablo Neira Ayuso
This patch adds the internal NFT_AF_NEEDS_DEV flag to indicate that you must attach this table to a net_device. This change is required by the follow up patch that introduces the new netdev table. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h|8 ++ inclu

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-25 Thread Nicolas Dichtel
Le 25/05/2015 12:55, Alexander Holler a écrit : Am 25.05.2015 um 09:45 schrieb Nicolas Dichtel: Le 22/05/2015 22:50, Alexander Holler a écrit : First I think if NETLINK_LISTEN_ALL_NSID is enabled, a dump of the interfaces through RTM_GETLINK together with NLM_F_DUMP and NLM_F_REQUEST should r

[PATCH net-next v2] bridge: skip fdb add if the port shouldn't learn

2015-05-25 Thread Nikolay Aleksandrov
From: Wilson Kok Check in fdb_add_entry() if the source port should learn, similar check is used in br_fdb_update. Note that new fdb entries which are added manually or as local ones are still permitted. This patch has been tested by running traffic via a bridge port and switching the port's stat

TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread John A. Sullivan III
Hello, all. I hope this is the correct list for this question. We are having serious problems on high BDP networks using GRE tunnels. Our traces show it to be a TCP Window problem. When we test without GRE, throughput is wire speed and traces show the window size to be 16MB which is what we con

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Larry Finger
On 05/25/2015 04:37 AM, Vaishali Thakkar wrote: On 25 May 2015 14:49, "Dan Carpenter" mailto:dan.carpen...@oracle.com>> wrote: > > On Sun, May 24, 2015 at 07:11:40PM -0500, Larry Finger wrote: > > On 05/24/2015 02:03 PM, Haggai Eran wrote: > > >On 24 May 2015 at 00:16, Larry Finger mailto:la

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Larry Finger
On 05/24/2015 11:42 PM, Sudip Mukherjee wrote: I haven't been using kernel v4.1 so I haven't seen this warning, but looking at the code it seems to originate from the two recent patches to remove _cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml [1] that changes del_tim

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Larry Finger
On 05/23/2015 04:16 PM, Larry Finger wrote: The driver is reporting a warning at kernel/time/timer.c:1096 due to calling del_timer_sync() while in interrupt mode. Such warnings are fixed by calling del_timer() instead. Signed-off-by: Larry Finger Cc: Stable Cc: Haggi Eran --- Greg, Please

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread Eric Dumazet
On Mon, 2015-05-25 at 11:42 -0400, John A. Sullivan III wrote: > Hello, all. I hope this is the correct list for this question. We are > having serious problems on high BDP networks using GRE tunnels. Our > traces show it to be a TCP Window problem. When we test without GRE, > throughput is wir

Re: pull-request: wireless-drivers 2015-05-25

2015-05-25 Thread David Miller
From: Kalle Valo Date: Mon, 25 May 2015 15:01:19 +0300 > here's hopefully the last wireless-drivers pull request for 4.1. Mostly > iwlwifi fixes this time. Please let me know if there are any problems. Pulled into 'net', thanks Kalle. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH net-next v5 00/11] ipv6: Only create RTF_CACHE route after encountering pmtu exception

2015-05-25 Thread David Miller
From: Martin KaFai Lau Date: Fri, 22 May 2015 20:55:55 -0700 > This series is to avoid creating a RTF_CACHE route whenever we are consulting > the fib6 tree with a new destination. Instead, only create RTF_CACHE route > when we see a pmtu exception. Looks great, nice work. Series applied to ne

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Joe Perches
On Mon, 2015-05-25 at 12:17 +0300, Dan Carpenter wrote: > These are special intern patches that > dont' go through the normal review process. The intern process is over > this year. The lack of normal review introduced a number of bugs this > year. I always complain to Greg about it and he says

[PATCH] net:xen-netback - Change 1 to true for bool type variable.

2015-05-25 Thread Shailendra Verma
The variable separate_tx_rx_irq is bool type so assigning true instead of 1. Signed-off-by: Shailendra Verma --- drivers/net/xen-netback/netback.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 4

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread Eric Dumazet
On Mon, 2015-05-25 at 09:58 -0700, Eric Dumazet wrote: > 1) Non GRE session > > lpaa23:~# DUMP_TCP_INFO=1 ./netperf -H lpaa24 -Cc -t OMNI > OMNI Send TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to > lpaa24.prod.google.com () port 0 AF_INET > tcpi_rto 201000 tcpi_ato 0 tcpi_pmtu 1500 tcpi_rcv_ssth

[PATCH] net:wireless - Change 1 to true for bool type variable.

2015-05-25 Thread Shailendra Verma
The variable translate is bool type.So assigning true instead of 1. Signed-off-by: Shailendra Verma --- drivers/net/wireless/ray_cs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c index 477f863..0881ba8 100644

Re: [PATCH] net:wireless - Change 1 to true for bool type variable.

2015-05-25 Thread Larry Finger
On 05/25/2015 12:55 PM, Shailendra Verma wrote: The variable translate is bool type.So assigning true instead of 1. Signed-off-by: Shailendra Verma When you submit a patch for a particular driver in the drivers/net/wireless/ tree, it is preferred that the subject start with the driver name,

[PATCH] net:wireless:rndis_wlan - Use bool function return value

2015-05-25 Thread Shailendra Verma
The function rndis_bss_info_update() has bool return type. So use bool value flase instead of NULL to return. Signed-off-by: Shailendra Verma --- drivers/net/wireless/rndis_wlan.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/rndis_wlan.c b/dr

Re: [PATCH] net:wireless - Change 1 to true for bool type variable.

2015-05-25 Thread Joe Perches
On Mon, 2015-05-25 at 23:25 +0530, Shailendra Verma wrote: > The variable translate is bool type.So assigning true instead of 1. There are a lot these in the kernel. $ git grep -P "^[ \t]*(?:static[ \t]+)?(?:const\s+)?bool\s+\w+\s*=\s*[01]\s*;" * | wc -l 161 Are you going to submit patches for

TX abort errors on GRE tunnels

2015-05-25 Thread John A. Sullivan III
Hello, all. We are seeing TX abort errors on all of our GRE tunnels. What would cause such a thing? We suspected it might be MTU because these are encapsulated in IPSec transport and the MTU on the GRE tunnel is still 1476 so we reduced the MTU but that did not eliminate the problem. By the way,

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread John A. Sullivan III
On Mon, 2015-05-25 at 09:58 -0700, Eric Dumazet wrote: > On Mon, 2015-05-25 at 11:42 -0400, John A. Sullivan III wrote: > > Hello, all. I hope this is the correct list for this question. We are > > having serious problems on high BDP networks using GRE tunnels. Our > > traces show it to be a TCP

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread Eric Dumazet
On Mon, 2015-05-25 at 14:49 -0400, John A. Sullivan III wrote: > On Mon, 2015-05-25 at 09:58 -0700, Eric Dumazet wrote: > > On Mon, 2015-05-25 at 11:42 -0400, John A. Sullivan III wrote: > > > Hello, all. I hope this is the correct list for this question. We are > > > having serious problems on h

Re: [PATCH net-next V4 00/12] net/mlx5: ConnectX-4 100G Ethernet driver

2015-05-25 Thread Or Gerlitz
On Wed, May 20, 2015 at 5:17 PM, Amir Vadai wrote: > On Tue, May 19, 2015 at 7:41 PM, David Miller wrote: >> From: Amir Vadai >> Date: Tue, 19 May 2015 12:25:12 +0300 >> >>> On Sun, May 17, 2015 at 8:05 PM, David Miller wrote: From: Amir Vadai Date: Sun, 17 May 2015 16:02:11 +0300 >>

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread John A. Sullivan III
On Mon, 2015-05-25 at 12:05 -0700, Eric Dumazet wrote: > On Mon, 2015-05-25 at 14:49 -0400, John A. Sullivan III wrote: > > On Mon, 2015-05-25 at 09:58 -0700, Eric Dumazet wrote: > > > On Mon, 2015-05-25 at 11:42 -0400, John A. Sullivan III wrote: > > > > Hello, all. I hope this is the correct lis

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread John A. Sullivan III
On Mon, 2015-05-25 at 15:21 -0400, John A. Sullivan III wrote: > On Mon, 2015-05-25 at 12:05 -0700, Eric Dumazet wrote: > > On Mon, 2015-05-25 at 14:49 -0400, John A. Sullivan III wrote: > > > On Mon, 2015-05-25 at 09:58 -0700, Eric Dumazet wrote: > > > > On Mon, 2015-05-25 at 11:42 -0400, John A.

Re: [PATCH v2 3/3] ARM: zynq: DT: Use the zynq binding with macb

2015-05-25 Thread Sören Brinkmann
On Fri, 2015-05-22 at 09:22AM -0500, Nathan Sullivan wrote: > Use the new zynq binding for macb ethernet, since it will disable half > duplex gigabit like the Zynq TRM says to do. > > Signed-off-by: Nathan Sullivan > --- > arch/arm/boot/dts/zynq-7000.dtsi |4 ++-- > 1 file changed, 2 inserti

[PATCH] atm:he - Change 1 to true for bool type variable.

2015-05-25 Thread Shailendra Verma
The variable irq_coalesce is bool type. So assign the value true instead of 1. Signed-off-by: Shailendra Verma --- drivers/atm/he.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 93dca2e..0237271 100644 --- a/drivers/atm/he.c +++

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread John A. Sullivan III
On Mon, 2015-05-25 at 15:29 -0400, John A. Sullivan III wrote: > On Mon, 2015-05-25 at 15:21 -0400, John A. Sullivan III wrote: > > On Mon, 2015-05-25 at 12:05 -0700, Eric Dumazet wrote: > > > On Mon, 2015-05-25 at 14:49 -0400, John A. Sullivan III wrote: > > > > On Mon, 2015-05-25 at 09:58 -0700,

[PATCH] atm:he - Do not initialise statics to 0.

2015-05-25 Thread Shailendra Verma
Static variables are initialised to 0 by GCC. Fixes the following checkpatch error: ERROR: do not initialise statics to 0 or NULL FILE: drivers/atm/he.c:120: static bool sdh = 0; Signed-off-by: Shailendra Verma --- drivers/atm/he.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Drops in qdisc on ifb interface

2015-05-25 Thread John A. Sullivan III
Hello, all. One one of our connections we are doing intensive traffic shaping with tc. We are using ifb interfaces for shaping ingress traffic and we also use ifb interfaces for egress so that we can apply the same set of rules to multiple interfaces (e.g., tun and eth interfaces operating on the

Re: [PATCH] net:xen-netback - Change 1 to true for bool type variable.

2015-05-25 Thread David Miller
From: Shailendra Verma Date: Mon, 25 May 2015 23:19:31 +0530 > The variable separate_tx_rx_irq is bool type so assigning true > instead of 1. > > Signed-off-by: Shailendra Verma Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@

Re: [PATCH] atm:he - Change 1 to true for bool type variable.

2015-05-25 Thread David Miller
From: Shailendra Verma Date: Tue, 26 May 2015 01:17:23 +0530 > The variable irq_coalesce is bool type. > So assign the value true instead of 1. > > Signed-off-by: Shailendra Verma Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord..

Re: [PATCH] atm:he - Do not initialise statics to 0.

2015-05-25 Thread David Miller
From: Shailendra Verma Date: Tue, 26 May 2015 01:23:53 +0530 > Static variables are initialised to 0 by GCC. > Fixes the following checkpatch error: > ERROR: do not initialise statics to 0 or NULL > FILE: drivers/atm/he.c:120: > static bool sdh = 0; > > Signed-off-by: Shailendra Verma true is

Re: [PATCH] net/ibm/emac: fix size of emac dump memory areas

2015-05-25 Thread David Miller
From: Ivan Mikhaylov Date: Thu, 21 May 2015 19:11:02 +0400 > Fix in send of emac regs dump to ethtool which > causing in wrong data interpretation on ethtool > layer for MII and EMAC. > > Signed-off-by: Ivan Mikhaylov Applied, thanks. -- To unsubscribe from this list: send the line "unsubscrib

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread Eric Dumazet
On Mon, 2015-05-25 at 15:21 -0400, John A. Sullivan III wrote: > > Thanks, Eric. I really appreciate the help. This is a problem holding up > a very high profile, major project and, for the life of me, I can't > figure out why my TCP window size is reduced inside the GRE tunnel. > > Here is the

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread Eric Dumazet
On Mon, 2015-05-25 at 13:41 -0700, Eric Dumazet wrote: > lpaa23:~# DUMP_TCP_INFO=1 ./netperf -H 10.7.8.152 -Cc -t OMNI -l 20 > OMNI Send TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to 10.7.8.152 () port 0 > AF_INET > tcpi_rto 281000 tcpi_ato 0 tcpi_pmtu 1476 tcpi_rcv_ssthresh 28720 > tcpi_rtt 8043

RE: [E1000-devel] [stable] e1000e fixes

2015-05-25 Thread Lubetkin, YanirX
Thanks, I will look into it shortly. I'm in the process of bringing the upstream driver up to date. > -Original Message- > From: Ben Hutchings [mailto:b...@decadent.org.uk] > Sent: Saturday, May 23, 2015 20:09 > To: e1000-de...@lists.sourceforge.net > Cc: netdev; stable > Subject: [E1000-

Re: [PATCH v3 -next] ipv6: don't increase size when refragmenting forwarded ipv6 skbs

2015-05-25 Thread David Miller
From: Florian Westphal Date: Fri, 22 May 2015 00:44:16 +0200 > since commit 6aafeef03b9d ("netfilter: push reasm skb through instead of > original frag skbs") we will end up sometimes re-fragmenting skbs > that we've reassembled. > > ipv6 defrag preserves the original skbs using the skb frag lis

Re: [PATCHv3 net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-25 Thread David Miller
From: Linus Lüssing Date: Sat, 23 May 2015 03:12:34 +0200 > Network managers like netifd (used in OpenWRT for instance) try to > configure interface options after creation but before setting the > interface up. > > Unfortunately the sysfs / bridge currently only allows to configure the > hash_ma

Re: [PATCH net-next v5 2/2] net: Adding support for Cavium ThunderX network controller

2015-05-25 Thread David Miller
From: Aleksey Makarov Date: Fri, 22 May 2015 18:28:16 -0700 > +#ifdef NOT_SUPPORTED_FOR_NOW > +static int nicvf_set_coalesce(struct net_device *netdev, > + struct ethtool_coalesce *cmd) > +{ ... > +#ifdef NOT_SUPPORTED_FOR_NOW > + .set_coalesce = nicvf_set

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread John A. Sullivan III
On Mon, 2015-05-25 at 13:41 -0700, Eric Dumazet wrote: > On Mon, 2015-05-25 at 15:21 -0400, John A. Sullivan III wrote: > > > > > Thanks, Eric. I really appreciate the help. This is a problem holding up > > a very high profile, major project and, for the life of me, I can't > > figure out why my

[net-next:master 741/754] net/ipv6/ip6_output.c:587:17: sparse: incorrect type in assignment (different base types)

2015-05-25 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 376cd36dc7b68ec7f7de1428fa055ce706a33bbf commit: 286c2349f6665c3e67f464a5faa14a0e28be4842 [741/754] ipv6: Clean up ipv6_select_ident() and ip6_fragment() reproduce: # apt-get install sparse git checkout 286

Re: [PATCH] net: stmmac: create one debugfs dir per net-device

2015-05-25 Thread David Miller
From: Mathieu Olivari Date: Fri, 22 May 2015 19:03:29 -0700 > stmmac DebugFS entries are currently global to the driver. As a result, > having more than one stmmac device in the system creates the following > error: > * ERROR stmmaceth, debugfs create directory failed > * stmmac_hw_setup: failed

Re: [PATCH] irda: irda-usb: use msecs_to_jiffies for conversions

2015-05-25 Thread David Miller
From: Nicholas Mc Guire Date: Sat, 23 May 2015 14:46:30 +0200 > API compliance scanning with coccinelle flagged: > > Converting milliseconds to jiffies by "val * HZ / 1000" is technically > is not a clean solution as it does not handle all corner cases correctly. > By changing the conversion to

Re: [trivial PATCH] neterion: s2io: Fix kernel doc formatting

2015-05-25 Thread David Miller
From: Joe Perches Date: Sat, 23 May 2015 10:32:55 -0700 > These two uses seem to have had carriage returns removed. > Make these entries like all the others in this file. > > Signed-off-by: Joe Perches Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH V2] irda: use msecs_to_jiffies for conversion to jiffies

2015-05-25 Thread David Miller
From: Nicholas Mc Guire Date: Mon, 25 May 2015 08:16:50 +0200 > API compliance scanning with coccinelle flagged: > ./net/irda/timer.c:63:35-37: use of msecs_to_jiffies probably perferable > > Converting milliseconds to jiffies by "val * HZ / 1000" technically > is not a clean solution as it does

Re: [PATCH v3 net-next 0/2] rocker: unused parameter and const cleanups

2015-05-25 Thread David Miller
From: Simon Horman Date: Mon, 25 May 2015 14:28:34 +0900 > This series provides some minor though verbose cleanup of rocker. > > The second patch depends on the first though it could be rebased. > > I had previously asked for v2 to be put on hold while some bugs I had found > in the rocker driv

Re: [PATCH net-next 0/4] cpsw cleanups

2015-05-25 Thread David Miller
From: Richard Cochran Date: Mon, 25 May 2015 11:02:12 +0200 > While working on an out-of-tree customization, I noticed a few minor > problems in the cpsw code. This series cleans up the issues I found. Series applied, thanks Richard. -- To unsubscribe from this list: send the line "unsubscribe

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread John A. Sullivan III
On Mon, 2015-05-25 at 17:34 -0400, John A. Sullivan III wrote: > On Mon, 2015-05-25 at 13:41 -0700, Eric Dumazet wrote: > > On Mon, 2015-05-25 at 15:21 -0400, John A. Sullivan III wrote: > > > > > > > > Thanks, Eric. I really appreciate the help. This is a problem holding up > > > a very high pro

Re: [PATCH net 0/3] phyter bug fixes

2015-05-25 Thread David Miller
From: Richard Cochran Date: Mon, 25 May 2015 11:55:42 +0200 > While working on a project using the phyter, I noticed some bugs that > have crept in over time. This series fixes those bugs. These patches > are also meant for stable. Series applied and queued up for -stable as well, thanks. -- T

Re: Drops in qdisc on ifb interface

2015-05-25 Thread Eric Dumazet
On Mon, 2015-05-25 at 16:05 -0400, John A. Sullivan III wrote: > Hello, all. One one of our connections we are doing intensive traffic > shaping with tc. We are using ifb interfaces for shaping ingress > traffic and we also use ifb interfaces for egress so that we can apply > the same set of rule

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread Eric Dumazet
On Mon, 2015-05-25 at 18:22 -0400, John A. Sullivan III wrote: > 2) Why do we still not negotiate the 16MB buffer that we get when we are > not using GRE? What exact NIC handles receive side ? If drivers allocate a full 4KB page to hold each frame, plus sk_buff overhead, then 32MB of kernel memo

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread John A. Sullivan III
On Mon, 2015-05-25 at 15:38 -0700, Eric Dumazet wrote: > On Mon, 2015-05-25 at 18:22 -0400, John A. Sullivan III wrote: > > > 2) Why do we still not negotiate the 16MB buffer that we get when we are > > not using GRE? > > What exact NIC handles receive side ? > > If drivers allocate a full 4KB p

[PATCH net-next] ipv6: ipv6_select_ident() returns a __be32

2015-05-25 Thread Eric Dumazet
From: Eric Dumazet ipv6_select_ident() returns a 32bit value in network order. Fixes: 286c2349f666 ("ipv6: Clean up ipv6_select_ident() and ip6_fragment()") Signed-off-by: Eric Dumazet Reported-by: kbuild test robot --- include/net/ipv6.h |6 +++--- net/ipv6/output_core.c |6 +++--

[PATCH net-next] pktgen: remove one sparse error

2015-05-25 Thread Eric Dumazet
From: Eric Dumazet net/core/pktgen.c:2672:43: warning: incorrect type in assignment (different base types) net/core/pktgen.c:2672:43:expected unsigned short [unsigned] [short] [usertype] net/core/pktgen.c:2672:43:got restricted __be16 [usertype] protocol Let's use proper struct ethhdr

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread Eric Dumazet
On Mon, 2015-05-25 at 18:44 -0400, John A. Sullivan III wrote: > On Mon, 2015-05-25 at 15:38 -0700, Eric Dumazet wrote: > > On Mon, 2015-05-25 at 18:22 -0400, John A. Sullivan III wrote: > > > > > 2) Why do we still not negotiate the 16MB buffer that we get when we are > > > not using GRE? > > >

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread John A. Sullivan III
On Mon, 2015-05-25 at 16:19 -0700, Eric Dumazet wrote: > On Mon, 2015-05-25 at 18:44 -0400, John A. Sullivan III wrote: > > On Mon, 2015-05-25 at 15:38 -0700, Eric Dumazet wrote: > > > On Mon, 2015-05-25 at 18:22 -0400, John A. Sullivan III wrote: > > > > > > > 2) Why do we still not negotiate the

Re: TCP window auto-tuning sub-optimal in GRE tunnel

2015-05-25 Thread Eric Dumazet
On Mon, 2015-05-25 at 19:35 -0400, John A. Sullivan III wrote: > On Mon, 2015-05-25 at 16:19 -0700, Eric Dumazet wrote: > > On Mon, 2015-05-25 at 18:44 -0400, John A. Sullivan III wrote: > > > On Mon, 2015-05-25 at 15:38 -0700, Eric Dumazet wrote: > > > > On Mon, 2015-05-25 at 18:22 -0400, John A.

Re: [PATCH net-next] ipv6: ipv6_select_ident() returns a __be32

2015-05-25 Thread Martin KaFai Lau
On Mon, May 25, 2015 at 04:02:21PM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > ipv6_select_ident() returns a 32bit value in network order. > > Fixes: 286c2349f666 ("ipv6: Clean up ipv6_select_ident() and ip6_fragment()") > Signed-off-by: Eric Dumazet > Reported-by: kbuild test robot Th

Re: [PATCH net-next] ipv6: ipv6_select_ident() returns a __be32

2015-05-25 Thread David Miller
From: Eric Dumazet Date: Mon, 25 May 2015 16:02:21 -0700 > From: Eric Dumazet > > ipv6_select_ident() returns a 32bit value in network order. > > Fixes: 286c2349f666 ("ipv6: Clean up ipv6_select_ident() and ip6_fragment()") > Signed-off-by: Eric Dumazet > Reported-by: kbuild test robot Appl

Re: [PATCH net-next] pktgen: remove one sparse error

2015-05-25 Thread David Miller
From: Eric Dumazet Date: Mon, 25 May 2015 16:06:37 -0700 > From: Eric Dumazet > > net/core/pktgen.c:2672:43: warning: incorrect type in assignment (different > base types) > net/core/pktgen.c:2672:43:expected unsigned short [unsigned] [short] > [usertype] > net/core/pktgen.c:2672:43:

Re: [PATCH 1/3 nf-next] netfilter: default CONFIG_NETFILTER_INGRESS to y

2015-05-25 Thread Simon Horman
Hi Pablo, On Mon, May 25, 2015 at 02:46:40PM +0200, Pablo Neira Ayuso wrote: > Useful to compile-test all options. > > Suggested-by: by Alexei Stavoroitov > Signed-off-by: Pablo Neira Ayuso There seems to be a stray "by" between ':' and Alexi's name. > --- > net/netfilter/Kconfig |1 + >

Re: [PATCH 2/3 nf-next] netfilter: nf_tables: allow to bind table to net_device

2015-05-25 Thread Simon Horman
Hi Pablo, On Mon, May 25, 2015 at 02:46:41PM +0200, Pablo Neira Ayuso wrote: > This patch adds the internal NFT_AF_NEEDS_DEV flag to indicate that you must > attach this table to a net_device. > > This change is required by the follow up patch that introduces the new netdev > table. > > Signed-o

[PATCH/RFC net-next] rocker: by default accept untagged packets

2015-05-25 Thread Simon Horman
This will occur anyway if the 8021q module is loaded as it will call rocker_port_vlan_rx_add_vid for vlan 0. This code is here to handle the case where the 8021q module is not loaded. This patch also handles the case where the 8021q is unloaded removing all VLANs from all ports. This change shoul

[PATCH] net: netxen: correct sysfs bin attribute return code

2015-05-25 Thread Vladimir Zapolskiy
If read() syscall requests unexpected number of bytes from "dimm" binary attribute file, return EINVAL instead of EPERM. At the same time pin down sysfs file size to the fixed sizeof(struct netxen_dimm_cfg), which allows to exploit some missing sanity checks from kernfs (file boundary checks vs of

[PATCH] net: qlcnic: clean up sysfs error codes

2015-05-25 Thread Vladimir Zapolskiy
Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the latter error code is arguable, but it is already used in the driver, so let it be here as well. Also remove always false (!buf) check on read(), the driver s

RE: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-25 Thread Hiroshi Shimamoto
> > -Original Message- > > From: Rose, Gregory V > > Sent: Friday, May 22, 2015 8:08 AM > > To: Hiroshi Shimamoto; Skidmore, Donald C; Kirsher, Jeffrey T; intel-wired- > > l...@lists.osuosl.org > > Cc: nhor...@redhat.com; jogre...@redhat.com; Linux Netdev List; Choi, > > Sy Jong; Rony Efrai

[PATCH net-next] net: fix inet_proto_csum_replace4() sparse errors

2015-05-25 Thread Eric Dumazet
From: Eric Dumazet make C=2 CF=-D__CHECK_ENDIAN__ net/core/utils.o ... net/core/utils.c:307:72: warning: incorrect type in argument 2 (different base types) net/core/utils.c:307:72:expected restricted __wsum [usertype] addend net/core/utils.c:307:72:got restricted __be32 [usertype] from

[PATCH net-next] net: remove a sparse error in secure_dccpv6_sequence_number()

2015-05-25 Thread Eric Dumazet
From: Eric Dumazet make C=2 CF=-D__CHECK_ENDIAN__ net/core/secure_seq.o net/core/secure_seq.c:157:50: warning: restricted __be32 degrades to integer Signed-off-by: Eric Dumazet --- net/core/secure_seq.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/secure_seq.c

Re: Drops in qdisc on ifb interface

2015-05-25 Thread John A. Sullivan III
On Mon, 2015-05-25 at 15:31 -0700, Eric Dumazet wrote: > On Mon, 2015-05-25 at 16:05 -0400, John A. Sullivan III wrote: > > Hello, all. One one of our connections we are doing intensive traffic > > shaping with tc. We are using ifb interfaces for shaping ingress > > traffic and we also use ifb in

Re: [PATCH net-next] net: remove a sparse error in secure_dccpv6_sequence_number()

2015-05-25 Thread David Miller
From: Eric Dumazet Date: Mon, 25 May 2015 18:55:48 -0700 > From: Eric Dumazet > > make C=2 CF=-D__CHECK_ENDIAN__ net/core/secure_seq.o > net/core/secure_seq.c:157:50: warning: restricted __be32 degrades to > integer > > Signed-off-by: Eric Dumazet Applied. -- To unsubscribe from this list: s

Re: [PATCH net-next] net: fix inet_proto_csum_replace4() sparse errors

2015-05-25 Thread David Miller
From: Eric Dumazet Date: Mon, 25 May 2015 18:50:01 -0700 > From: Eric Dumazet > > make C=2 CF=-D__CHECK_ENDIAN__ net/core/utils.o ... > Note we can use csum_replace4() helper > > Fixes: 58e3cac5613aa ("net: optimise inet_proto_csum_replace4()") > Signed-off-by: Eric Dumazet Also applied, th

Re: Drops in qdisc on ifb interface

2015-05-25 Thread Eric Dumazet
On Mon, 2015-05-25 at 22:52 -0400, John A. Sullivan III wrote: > Hmm . . . I've been thinking about that SFQ leaf qdisc. I see that > newer kernels allow a much higher "limit" than 127 but it still seems > that the queue depth limit for any one flow is still 127. When we do > something like GRE/

Re: [PATCH v3] brcmfmac: prohibit ACPI power management for brcmfmac driver

2015-05-25 Thread Fu, Zhonghui
On 2015/5/20 17:02, Arend van Spriel wrote: > On 05/18/15 08:26, Fu, Zhonghui wrote: >> >> Hi guys, >> >> Any comments about this patch? > > My acked is already there. I have not been able to test it, but I assume you > did. Yes, I have verified this patch on ASUS T100TA. Thanks, Zhonghui > >

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Sudip Mukherjee
On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote: > It'd be better if the approved patches from the intern list > (no idea what that is) were sent to lkml/devel@driverdev lists > for review before actually being applied. Its the outreachy program. And http://kernelnewbies.org/OutreachyAp

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Joe Perches
On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote: > On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote: > > It'd be better if the approved patches from the intern list > > (no idea what that is) were sent to lkml/devel@driverdev lists > > for review before actually being applied. >

  1   2   >