IPv6: finding a match in find_rr_leaf that cause a NULL pointer dereference

2015-05-26 Thread Jeremy
Hi all, My kernel is 3.10.20 and I encountered this NULL pointer dereference. According to my log, I found that dev is NULL in the beginning of for loop. it is the dev of rr_head that has been set to NULL. That might be possible that dev being NULL but I don't see any case to avoid such case i

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-26 Thread Eric Dumazet
On Tue, 2015-05-26 at 23:12 -0700, Eric Dumazet wrote: > On Tue, 2015-05-26 at 22:47 -0700, Gopakumar Choorakkot Edakkunni wrote: > > All, > > > > The original query I had posted is here : > > http://stackoverflow.com/questions/30414350/tcp-syn-ack-tsecr-not-matching-tsval-in-syn > > .. The summar

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-26 Thread Eric Dumazet
On Tue, 2015-05-26 at 22:47 -0700, Gopakumar Choorakkot Edakkunni wrote: > All, > > The original query I had posted is here : > http://stackoverflow.com/questions/30414350/tcp-syn-ack-tsecr-not-matching-tsval-in-syn > .. The summary is that once in a while, the TSval in SYN is not what > is gettin

Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-26 Thread Gopakumar Choorakkot Edakkunni
All, The original query I had posted is here : http://stackoverflow.com/questions/30414350/tcp-syn-ack-tsecr-not-matching-tsval-in-syn .. The summary is that once in a while, the TSval in SYN is not what is getting echoed in TSecr, and looks like something on amazon aws side is very strict about t

Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-26 Thread Gopakumar Choorakkot Edakkunni
All, The original query I had posted is here : http://stackoverflow.com/questions/30414350/tcp-syn-ack-tsecr-not-matching-tsval-in-syn .. The summary is that once in a while, the TSval in SYN is not what is getting echoed in TSecr, and looks like something on amazon aws side is very strict about t

Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-26 Thread Gopakumar Choorakkot Edakkunni
All, The original query I had posted is here : http://stackoverflow.com/questions/30414350/tcp-syn-ack-tsecr-not-matching-tsval-in-syn .. The summary is that once in a while, the TSval in SYN is not what is getting echoed in TSecr, and looks like something on amazon aws side is very strict about t

Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-26 Thread Gopakumar Choorakkot Edakkunni
All, The original query I had posted is here : http://stackoverflow.com/questions/30414350/tcp-syn-ack-tsecr-not-matching-tsval-in-syn .. The summary is that once in a while, the TSval in SYN is not what is getting echoed in TSecr, and looks like something on amazon aws side is very strict about t

[PATCH net-next] qla4xxx: add a missing include

2015-05-26 Thread Eric Dumazet
From: Eric Dumazet vmalloc.h used to be included from include/net/inet_hashtables.h but it is no longer the case. Fixes: 095dc8e0c368 ("tcp: fix/cleanup inet_ehash_locks_alloc()") Reported-by: kbuild test robot Signed-off-by: Eric Dumazet --- Given its broken in David net-next tree, its probab

Re: [PATCH net-next 0/2] net: phy: phy_interface_is_rgmii helper

2015-05-26 Thread David Miller
From: Florian Fainelli Date: Tue, 26 May 2015 12:19:57 -0700 > As you suggested, here is the helper function to avoid missing some RGMII > interface checks. Had to wait for net to be merged in net-next to avoid > submitting the same patch/commit. > > Dan, you might want to rebase your dp83867 su

Re: [PATCH net] tools: bpf_jit_disasm: fix segfault on disabled debugging log output

2015-05-26 Thread David Miller
From: Daniel Borkmann Date: Mon, 25 May 2015 14:08:03 +0200 > With recent debugging, I noticed that bpf_jit_disasm segfaults when > there's no debugging output from the JIT compiler to the kernel log. > > Reason is that when regexec(3) doesn't match on anything, start/end > offsets are not being

Re: [net-next:master 200/201] net/ipv4/fib_trie.c:293:3: error: implicit declaration of function 'vfree'

2015-05-26 Thread Eric Dumazet
Few vmalloc() users forgot to include , which used to be included from include/net/inet_hashtables.h Thanks for the report, I'll send fixes. On Tue, May 26, 2015 at 9:12 PM, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > master > head: d6

Re: [net-next:master 200/201] net/ipv4/fib_trie.c:293:3: error: implicit declaration of function 'vfree'

2015-05-26 Thread David Miller
From: kbuild test robot Date: Wed, 27 May 2015 12:12:08 +0800 > All error/warnings: > >net/ipv4/fib_trie.c: In function '__node_free_rcu': >>> net/ipv4/fib_trie.c:293:3: error: implicit declaration of function 'vfree' >>> [-Werror=implicit-function-declaration] > vfree(n); > ^ >

Re: [net-next:master 200/201] net/ipv4/inet_hashtables.c:620:13: warning: division by zero

2015-05-26 Thread Eric Dumazet
This report seems bogus ? The divide is guarded by if (sizeof(spinlock_t) != 0) { } On Tue, May 26, 2015 at 9:09 PM, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > master > head: d6a4e26afb80c049e7f94e1b7b506dcda61eee88 > comm

[net-next:master 200/201] net/ipv4/fib_trie.c:293:3: error: implicit declaration of function 'vfree'

2015-05-26 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: d6a4e26afb80c049e7f94e1b7b506dcda61eee88 commit: 095dc8e0c3686d586a01a50abc3e1bb9ac633054 [200/201] tcp: fix/cleanup inet_ehash_locks_alloc() config: powerpc-defconfig (attached as .config) reproduce: wget h

[net-next:master 200/201] net/ipv4/inet_hashtables.c:620:13: warning: division by zero

2015-05-26 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: d6a4e26afb80c049e7f94e1b7b506dcda61eee88 commit: 095dc8e0c3686d586a01a50abc3e1bb9ac633054 [200/201] tcp: fix/cleanup inet_ehash_locks_alloc() config: cris-etrax-100lx_v2_defconfig (attached as .config) reproduc

Re: [PATCH net-next] tcp: tcp_tso_autosize() minimum is one packet

2015-05-26 Thread Eric Dumazet
On Tue, 2015-05-26 at 23:52 -0400, David Miller wrote: > From: Eric Dumazet > Date: Tue, 26 May 2015 08:55:28 -0700 > > > From: Eric Dumazet > > > > By making sure sk->sk_gso_max_segs minimal value is one, > > and sysctl_tcp_min_tso_segs minimal value is one as well, > > tcp_tso_autosize() will

[PATCH v3 net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-26 Thread Neil McKee
If new optional attribute OVS_USERSPACE_ATTR_ACTIONS is added to an OVS_ACTION_ATTR_USERSPACE action, then include the datapath actions in the upcall. This Directly associates the sampled packet with the path it takes through the virtual switch. Path information currently includes mangling, encaps

[PATCH net-next v6 1/2] pci: Add Cavium PCI vendor id

2015-05-26 Thread Aleksey Makarov
From: Sunil Goutham This vendor id will be used by network (vNIC), USB (xHCI), SATA (AHCI), GPIO, I2C, MMC and maybe other drivers for ThunderX SoC. Acked-by: Bjorn Helgaas Signed-off-by: Sunil Goutham Signed-off-by: Aleksey Makarov --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 inser

Re: [PATCH net-next] tcp: tcp_tso_autosize() minimum is one packet

2015-05-26 Thread David Miller
From: Eric Dumazet Date: Tue, 26 May 2015 08:55:28 -0700 > From: Eric Dumazet > > By making sure sk->sk_gso_max_segs minimal value is one, > and sysctl_tcp_min_tso_segs minimal value is one as well, > tcp_tso_autosize() will return a non zero value. > > We can then revert 843925f33fcc293d80acf

Re: [PATCH v3] net/unix: sk_socket can disappear when state is unlocked

2015-05-26 Thread David Miller
From: Hannes Frederic Sowa Date: Tue, 26 May 2015 23:24:59 +0200 > On Tue, May 26, 2015, at 17:22, Mark Salyzyn wrote: >> got a rare NULL pointer dereference in clear_bit >> >> Signed-off-by: Mark Salyzyn > > IMHO, this is the right approach, I didn't came up with something > easier, thanks! >

Re: [PATCH net-next v6 0/2] Adding support for Cavium ThunderX network controller

2015-05-26 Thread David Miller
From: Aleksey Makarov Date: Tue, 26 May 2015 19:20:13 -0700 > This patchset adds support for the Cavium ThunderX network controller. I don't see patch #1 (yet). -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH] atm:he - Change 0 to false for bool type variable initialization.

2015-05-26 Thread David Miller
From: Shailendra Verma Date: Wed, 27 May 2015 06:50:18 +0530 > The variable sdh is bool type so initializing it with false value > instead of 0. > > Signed-off-by: Shailendra Verma > --- > drivers/atm/he.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers

[PATCH net-next v6 0/2] Adding support for Cavium ThunderX network controller

2015-05-26 Thread Aleksey Makarov
This patchset adds support for the Cavium ThunderX network controller. changes in v6: * unused preprocessor symbols were removed * reduce no of atomic operations in SQ maintenance * support for TCP segmentation at driver level * reset RBDR if fifo state is FAIL * fixed an issue with link stat

Re: [PATCH net-next] tcp: tcp_tso_autosize() minimum is one packet

2015-05-26 Thread Herbert Xu
On Tue, May 26, 2015 at 07:14:41PM -0700, Eric Dumazet wrote: > > Fact that Nagle or tso should defer applies in this corner case is not > very important here, unless you have a specific case in mind ? > Anyway I double checked and I believes it is fine. Yes it does appear to be fine on a second l

Re: [PATCH net-next] tcp: tcp_tso_autosize() minimum is one packet

2015-05-26 Thread Eric Dumazet
On Wed, 2015-05-27 at 10:01 +0800, Herbert Xu wrote: > On Wed, May 27, 2015 at 09:38:40AM +0800, Herbert Xu wrote: > > > > Not really. They're not identical. For example, before your > > patch a packet greater than MSS with TSO disabled would call > > tcp_nagle_test, with your patch it will call

Re: [PATCH net-next] tcp: tcp_tso_autosize() minimum is one packet

2015-05-26 Thread Eric Dumazet
On Wed, 2015-05-27 at 09:38 +0800, Herbert Xu wrote: > On Tue, May 26, 2015 at 05:36:34PM -0700, Eric Dumazet wrote: > > > > tldr: "TSO with max_segs==1" "no TSO/GSO" > > Not really. They're not identical. For example, before your > patch a packet greater than MSS with TSO disabled would cal

Re: [PATCH net-next] tcp: tcp_tso_autosize() minimum is one packet

2015-05-26 Thread Herbert Xu
On Wed, May 27, 2015 at 09:38:40AM +0800, Herbert Xu wrote: > > Not really. They're not identical. For example, before your > patch a packet greater than MSS with TSO disabled would call > tcp_nagle_test, with your patch it will call tcp_tso_should_defer > instead. > > Maybe this is OK but it i

RE: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-26 Thread Rose, Gregory V
> -Original Message- > From: Hiroshi Shimamoto [mailto:h-shimam...@ct.jp.nec.com] > Sent: Tuesday, May 26, 2015 5:28 PM > To: Rose, Gregory V; Skidmore, Donald C; Kirsher, Jeffrey T; intel-wired- > l...@lists.osuosl.org > Cc: nhor...@redhat.com; jogre...@redhat.com; Linux Netdev List; Choi

Re: [Patch net] net_sched: invoke ->attach() after setting dev->qdisc

2015-05-26 Thread Eric Dumazet
On Tue, 2015-05-26 at 16:08 -0700, Cong Wang wrote: > For mq qdisc, we add per tx queue qdisc to root qdisc > for display purpose, however, that happens too early, > before the new dev->qdisc is finally set, this causes > q->list points to an old root qdisc which is going to be > freed right before

Re: [Intel-wired-lan] [PATCH v5] ixgbe: Add module parameter to disable VLAN filter

2015-05-26 Thread Alexander Duyck
On 05/26/2015 06:11 PM, Hiroshi Shimamoto wrote: On 05/21/2015 06:10 AM, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto Introduce module parameter "disable_hw_vlan_filter" to disable HW VLAN filter on ixgbe module load. From the hardware limitation, there are only 64 VLAN entries for HW V

Re: [PATCH net-next] tcp: tcp_tso_autosize() minimum is one packet

2015-05-26 Thread Herbert Xu
On Tue, May 26, 2015 at 05:36:34PM -0700, Eric Dumazet wrote: > > tldr: "TSO with max_segs==1" "no TSO/GSO" Not really. They're not identical. For example, before your patch a packet greater than MSS with TSO disabled would call tcp_nagle_test, with your patch it will call tcp_tso_should_def

[PATCH v3] isdn: Use ktime_t instead of 'struct timeval'

2015-05-26 Thread Tina Ruchandani
'struct timeval' uses 32-bit representation for seconds which will overflow in year 2038 and beyond. mISDN/clock.c needs to compute and store elapsed time in intervals of 125 microseconds. This patch replaces the usage of 'struct timeval' with 64-bit ktime_t which is y2038 safe. The patch also repl

[PATCH] atm:he - Change 0 to false for bool type variable initialization.

2015-05-26 Thread Shailendra Verma
The variable sdh is bool type so initializing it with false value instead of 0. Signed-off-by: Shailendra Verma --- drivers/atm/he.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 93dca2e..eb5bebc 100644 --- a/drivers/atm/he.c

RE: [Intel-wired-lan] [PATCH v5] ixgbe: Add module parameter to disable VLAN filter

2015-05-26 Thread Hiroshi Shimamoto
> On 05/21/2015 06:10 AM, Hiroshi Shimamoto wrote: > > From: Hiroshi Shimamoto > > > > Introduce module parameter "disable_hw_vlan_filter" to disable HW VLAN > > filter on ixgbe module load. > > > > From the hardware limitation, there are only 64 VLAN entries for HW VLAN > > filter, and it leads

Re: [PATCH 2/3 nf-next] netfilter: nf_tables: allow to bind table to net_device

2015-05-26 Thread Simon Horman
On Tue, May 26, 2015 at 11:58:24AM +0200, Pablo Neira Ayuso wrote: > On Tue, May 26, 2015 at 09:48:41AM +0900, Simon Horman wrote: > > Hi Pablo, > > > > On Mon, May 25, 2015 at 02:46:41PM +0200, Pablo Neira Ayuso wrote: > > > This patch adds the internal NFT_AF_NEEDS_DEV flag to indicate that you

Re: [PATCH/RFC net-next] rocker: by default accept untagged packets

2015-05-26 Thread Simon Horman
Hi Scott, On Tue, May 26, 2015 at 02:04:00AM -0700, Scott Feldman wrote: > On Tue, May 26, 2015 at 12:28 AM, Scott Feldman wrote: > > On Mon, May 25, 2015 at 5:55 PM, Simon Horman > > wrote: > >> This will occur anyway if the 8021q module is loaded as it will > >> call rocker_port_vlan_rx_add_vi

[PATCH] ray_cs: Change 1 to true for bool type variable.

2015-05-26 Thread Shailendra Verma
The variable translate is bool type.So assigning true instead of 1. Signed-off-by: Shailendra Verma --- drivers/net/wireless/ray_cs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c index 477f863..0881ba8 100644

Re: [PATCH net-next] tcp: tcp_tso_autosize() minimum is one packet

2015-05-26 Thread Eric Dumazet
On Wed, 2015-05-27 at 08:03 +0800, Herbert Xu wrote: > Eric Dumazet wrote: > > > > - if (tso_segs == 1 || !max_segs) { > > + if (tso_segs == 1) { > > What we're testing for here with max_segs is actually the question > "is TSO enabled". So with your patch we will be t

RE: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-26 Thread Hiroshi Shimamoto
> > -Original Message- > > From: Skidmore, Donald C > > Sent: Tuesday, May 26, 2015 10:46 AM > > To: Hiroshi Shimamoto; Rose, Gregory V; Kirsher, Jeffrey T; intel-wired- > > l...@lists.osuosl.org > > Cc: nhor...@redhat.com; jogre...@redhat.com; Linux Netdev List; Choi, Sy > > Jong; Rony Efr

Re: [PATCH net-next] tcp: tcp_tso_autosize() minimum is one packet

2015-05-26 Thread Herbert Xu
Eric Dumazet wrote: > > - if (tso_segs == 1 || !max_segs) { > + if (tso_segs == 1) { What we're testing for here with max_segs is actually the question "is TSO enabled". So with your patch we will be taking the TSO code path even when TSO is disabled. Now this may or

Re: [PATCH net-next] tcp: fix/cleanup inet_ehash_locks_alloc()

2015-05-26 Thread David Miller
From: Eric Dumazet Date: Tue, 26 May 2015 07:55:34 -0700 > From: Eric Dumazet > > If tcp ehash table is constrained to a very small number of buckets > (eg boot parameter thash_entries=128), then we can crash if spinlock > array has more entries. > > While we are at it, un-inline inet_ehash_lo

Re: [PATCH net] amd-xgbe-phy: Fix initial mode when autoneg is disabled

2015-05-26 Thread David Miller
From: Tom Lendacky Date: Tue, 26 May 2015 09:57:33 -0500 > On 05/26/2015 09:51 AM, Tom Lendacky wrote: >> When the ethtool command is used to set the speed of the device while >> the device is down, the check to set the initial mode may fail when >> the device is brought up, causing failure to br

Re: [PATCH net-next 1/1] tipc: fix bug in link protocol message create function

2015-05-26 Thread David Miller
From: Jon Maloy Date: Tue, 26 May 2015 05:40:19 -0400 > In commit dd3f9e70f59f43a5712eba9cf3ee4f1e6999540c > ("tipc: add packet sequence number at instant of transmission") we > made a change with the consequence that packets in the link backlog > queue don't contain valid sequence numbers. > >

Re: pull-request: mac80211 2015-05-26

2015-05-26 Thread David Miller
From: Johannes Berg Date: Tue, 26 May 2015 09:25:03 +0200 > Unfortunately I neglected to send this to you last week before our long > weekend. > > These changes look fairly big, but they're fairly contained to the > remain-on- channel and AP_VLAN key handling code. > > However, if you think you

[PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket

2015-05-26 Thread Jason Gunthorpe
sctp_v4_map_v6 was subtly writing and reading from members of a union in a way the clobbered data it needed to read before it read it. Zeroing the v6 flowinfo overwrites the v4 sin_addr with 0, meaning that every place that calls sctp_v4_map_v6 gets :::0.0.0.0 as the result. Reorder things to

[Patch net] net_sched: invoke ->attach() after setting dev->qdisc

2015-05-26 Thread Cong Wang
For mq qdisc, we add per tx queue qdisc to root qdisc for display purpose, however, that happens too early, before the new dev->qdisc is finally set, this causes q->list points to an old root qdisc which is going to be freed right before assigning with a new one. Fix this by moving ->attach() afte

Re: DSA and underlying 802.1Q encapsulation

2015-05-26 Thread Guenter Roeck
On Tue, May 26, 2015 at 06:29:57PM -0400, Vivien Didelot wrote: > Hi, > > I'm doing tests with VLAN support in DSA and I noticed that the EDSA > frame is prepended with a 802.1q header once queued to the underlying > network device, in net/dsa/tag_edsa.c: > > skb->dev = p->parent->dst->mast

Re: [PATCH v2 net-next 0/3] net: Add incoming CPU mask to sockets

2015-05-26 Thread Eric Dumazet
On Tue, 2015-05-26 at 13:01 -0700, Tom Herbert wrote: > In that case there's no guarantee that any two packets in a flow will > hit the same CPU so there's no way to establish affinity to the > interrupt anyway. RFS would work okay to get affinity of the soft > processing, but there would be no po

[net-next PATCH RFC 2/3] xfrm: Override skb->mark with tunnel->parm.i_key in xfrm_input

2015-05-26 Thread Alexander Duyck
This change makes it so that if a tunnel is defined we just use the mark from the tunnel instead of the mark from the skb header. By doing this we can avoid the need to set skb->mark inside of the tunnel receive functions. Signed-off-by: Alexander Duyck --- net/xfrm/xfrm_input.c | 17

[net-next PATCH RFC 0/3] Preserve skb->mark through VTI tunnels

2015-05-26 Thread Alexander Duyck
These patches are meant to try and address the fact the VTI tunnels are currently overwriting the skb->mark value. I am generally happy with the first two patches, however the third patch still modifies the skb->mark, though it undoes after the fact. The main problem I am trying to address is the

[net-next PATCH RFC 1/3] ip_vti/ip6_vti: Do not touch skb->mark on xmit

2015-05-26 Thread Alexander Duyck
Instead of modifying skb->mark we can simply modify the flowi_mark that is generated as a result of the xfrm_decode_session. By doing this we don't need to actually touch the skb->mark and it can be preserved as it passes out through the tunnel. Signed-off-by: Alexander Duyck --- net/ipv4/ip_vt

[net-next PATCH RFC 3/3] ip_vti/ip6_vti: Preserve skb->mark after rcv_cb call

2015-05-26 Thread Alexander Duyck
The vti6_rcv_cb and vti_rcv_cb calls were leaving the skb->mark modified after completing the function. This resulted in the original skb->mark value being lost. Since we only need skb->mark to be set for xfrm_policy_check we can pull the assignment into the rcv_cb calls and then just restore the

DSA and underlying 802.1Q encapsulation

2015-05-26 Thread Vivien Didelot
Hi, I'm doing tests with VLAN support in DSA and I noticed that the EDSA frame is prepended with a 802.1q header once queued to the underlying network device, in net/dsa/tag_edsa.c: skb->dev = p->parent->dst->master_netdev; dev_queue_xmit(skb); This issue can be observed with the follo

[PATCH 2/2] cgroup: report cgroup release event to proc connector

2015-05-26 Thread Dimitri John Ledkov
This adds a call to proc_cgrelease_connector at check_for_release time. It is done when cgroup becomes dead, regardless of the notify_on_release status. This is thus compatible with both current & unified cgroups hierarchy, and the decision which cgroups to emit events for is offloaded to the proc

[PATCH 1/2] connector: add cgroup release event report to proc connector

2015-05-26 Thread Dimitri John Ledkov
Add a kernel API to send a proc connector notification that a cgroup has become empty. A userspace daemon can then act upon such information, and usually clean-up and remove such a group as it's no longer needed. Currently there are two other ways (one for current & one for unified cgroups) to rec

Re: [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-26 Thread Pravin Shelar
On Tue, May 26, 2015 at 10:38 AM, Jiri Benc wrote: > Currently, openvswitch tries to disable LRO from the user space. This does > not work correctly when the device added is a vlan interface, though. > Instead of dealing with possibly complex stacked cross name space relations > in the user space,

Re: xen-netfront crash when detaching network while some network activity

2015-05-26 Thread Marek Marczykowski-Górecki
On Tue, May 26, 2015 at 11:56:00AM +0100, David Vrabel wrote: > On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: > > Hi all, > > > > I'm experiencing xen-netfront crash when doing xl network-detach while > > some network activity is going on at the same time. It happens only when > > domU has

Re: [PATCH net] mpls: fix mpls route deletes to not check for route scope and type

2015-05-26 Thread roopa
On 5/26/15, 2:48 PM, Eric W. Biederman wrote: Roopa Prabhu writes: From: Roopa Prabhu This patch fixes incorrect -EINVAL error due to invalid scope and type for mpls route deletes. Well this is embarrassing apparently I did not exercise this code path in iproute. Looking through my tests t

[PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-26 Thread K. Y. Srinivasan
The current algorithm for deciding on the number of VRSS channels is not optimal since we open up the min of number of CPUs online and the number of VRSS channels the host is offering. So on a 32 VCPU guest we could potentially open 32 VRSS subchannels. Experimentation has shown that it is best to

Re: [PATCH net] mpls: fix mpls route deletes to not check for route scope and type

2015-05-26 Thread Eric W. Biederman
Roopa Prabhu writes: > From: Roopa Prabhu > > This patch fixes incorrect -EINVAL error due to invalid > scope and type for mpls route deletes. Well this is embarrassing apparently I did not exercise this code path in iproute. Looking through my tests the closest I came was: ip -M route flush t

Re: [PATCH net-next v5 00/11] ipv6: Only create RTF_CACHE route after encountering pmtu exception

2015-05-26 Thread Martin KaFai Lau
On Tue, May 26, 2015 at 11:20:53PM +0200, Hannes Frederic Sowa wrote: > I also went over the changes to the last version and such, albeit a bit > late: > Reviewed-by: Hannes Frederic Sowa Thanks for your help and review, Hannes! --Martin -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH v2 net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-26 Thread Pravin Shelar
On Fri, May 22, 2015 at 4:21 PM, Neil McKee wrote: > If new optional attribute OVS_USERSPACE_ATTR_ACTIONS is added to an > OVS_ACTION_ATTR_USERSPACE action, then include the datapath actions > in the upcall. > > This Directly associates the sampled packet with the path it takes > through the virtu

Re: [PATCH v3] net/unix: sk_socket can disappear when state is unlocked

2015-05-26 Thread Hannes Frederic Sowa
Hi, On Tue, May 26, 2015, at 17:22, Mark Salyzyn wrote: > got a rare NULL pointer dereference in clear_bit > > Signed-off-by: Mark Salyzyn IMHO, this is the right approach, I didn't came up with something easier, thanks! Acked-by: Hannes Frederic Sowa -- To unsubscribe from this list: send th

Re: [PATCH] Remove unused functions from the driver file, bcmgenet.c

2015-05-26 Thread Florian Fainelli
+Petri, On 26/05/15 09:28, Nicholas Krause wrote: > This removes the unused function, bcmgenet_hfb_add_filter and > the filter functions used within it due to either having no > callers or their only caller now removed from the file, > bcmgent.c with the removal of the function, bgmgenet_add_fil

Re: [PATCH net-next v5 00/11] ipv6: Only create RTF_CACHE route after encountering pmtu exception

2015-05-26 Thread Hannes Frederic Sowa
On Mon, May 25, 2015, at 19:34, David Miller wrote: > From: Martin KaFai Lau > Date: Fri, 22 May 2015 20:55:55 -0700 > > > This series is to avoid creating a RTF_CACHE route whenever we are > > consulting > > the fib6 tree with a new destination. Instead, only create RTF_CACHE route > > when we

[PATCH net] mpls: fix mpls route deletes to not check for route scope and type

2015-05-26 Thread Roopa Prabhu
From: Roopa Prabhu This patch fixes incorrect -EINVAL error due to invalid scope and type for mpls route deletes. iproute2 route modify code does not set protocol/scope/type for RTM_DELROUTE msgs. mpls code can skip checking for these too. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev

Re: [PATCH net-next v2] test_bpf: add similarly conflicting jump test case only for classic

2015-05-26 Thread Alexei Starovoitov
On 5/26/15 1:35 PM, Daniel Borkmann wrote: While 3b52960266a3 ("test_bpf: add more eBPF jump torture cases") added the int3 bug test case only for eBPF, which needs exactly 11 passes to converge, here's a version for classic BPF with 11 passes, and one that would need 70 passes on x86_64 to actua

[PATCH net-next v2] test_bpf: add similarly conflicting jump test case only for classic

2015-05-26 Thread Daniel Borkmann
While 3b52960266a3 ("test_bpf: add more eBPF jump torture cases") added the int3 bug test case only for eBPF, which needs exactly 11 passes to converge, here's a version for classic BPF with 11 passes, and one that would need 70 passes on x86_64 to actually converge for being successfully JITed. Ef

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Greg KH
On Tue, May 26, 2015 at 10:06:17AM -0700, Joe Perches wrote: > On Tue, 2015-05-26 at 09:35 -0700, Greg KH wrote: > > On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote: > > > > > The main point is that patches shouldn't be applied without > > > > > being submitted to a more widely read lis

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Dan Carpenter
On Tue, May 26, 2015 at 10:06:17AM -0700, Joe Perches wrote: > If you're collecting them, I suggest you stick them in > a separate branch, post them to your driverdev list and > cc the appropriate maintainers, wait a week, then apply > them to your main branch. That would work. A massive thread i

[PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-26 Thread Ido Yariv
The Tail Loss Probe RFC specifies that the PTO value should be set to max(2 * SRTT, 10ms), where SRTT is the smoothed round-trip time. The PTO value is converted to jiffies, so the timer may expire prematurely. This is especially problematic on systems in which HZ <= 100, so work around this by s

[PATCH] i40e: remove unneeded tests

2015-05-26 Thread Laurent Navet
The same code is executed regardless ret_code value, so these tests can be removed. Fix Coverity CID 1268789 and 1268791 Signed-off-by: Laurent Navet --- drivers/net/ethernet/intel/i40e/i40e_hmc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.c

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Dan Carpenter
On Tue, May 26, 2015 at 09:35:55AM -0700, Greg KH wrote: > Also, the outreachy patch process would overwhelm everyone else on the > list, it's really high volume during the application phase, I'd prefer > it to stick with the mentors that wish to help out with the process. If > you and/or Dan, or

Re: [PATCH v2 net-next 0/3] net: Add incoming CPU mask to sockets

2015-05-26 Thread Tom Herbert
On Tue, May 26, 2015 at 11:19 AM, Eric Dumazet wrote: > On Tue, 2015-05-26 at 11:00 -0700, Tom Herbert wrote: >> On Tue, May 26, 2015 at 10:18 AM, Eric Dumazet >> wrote: >> > On Tue, 2015-05-26 at 09:34 -0700, Tom Herbert wrote: >> >> Added matching of CPU to a socket CPU mask. This is useful fo

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-26 Thread Ido Yariv
Hi Eric, On Tue, May 26, 2015 at 11:25:21AM -0700, Eric Dumazet wrote: > On Tue, 2015-05-26 at 13:55 -0400, Ido Yariv wrote: > > > > > The platform this was tested on was an embedded platform with a wifi > > module (11n, 20MHZ). The other end was a computer running Windows, and > > the benchmark

[PATCH 0/5] Add support for QCA IPQ806x Ethernet GMAC controller

2015-05-26 Thread Mathieu Olivari
This patch set adds support for the integrated Ethernet GMAC controller on QCA IPQ806x SoC. This controller is based on a Gigabit Synopsys DesignWare IP, already supported in the stmmac driver located in drivers/net/ethernet/stmicro/stmmac. This change is done as a follow-up to the following threa

[PATCH 3/5] stmmac: add fixed-link device-tree support

2015-05-26 Thread Mathieu Olivari
In case DT is used, this change adds the ability to the stmmac driver to detect a fixed-link PHY, instanciate it, and use it during phy_connect(). Fixed link PHYs DT usage is described in: Documentation/devicetree/bindings/net/fixed-link.txt Signed-off-by: Mathieu Olivari --- drivers/net/ethern

[PATCH 5/5] net: stmmac: ipq806x: document device tree bindings

2015-05-26 Thread Mathieu Olivari
Add the device tree bindings documentation for the QCA IPQ806x variant of the Synopsys DesignWare MAC. Signed-off-by: Mathieu Olivari --- .../devicetree/bindings/net/ipq806x-dwmac.txt | 35 ++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/

[PATCH 1/5] clk: qcom: Add support for NSS/GMAC clocks and resets

2015-05-26 Thread Mathieu Olivari
From: Stephen Boyd Add the NSS/GMAC clocks and the TCM clock and NSS resets. Signed-off-by: Stephen Boyd Signed-off-by: Mathieu Olivari --- drivers/clk/qcom/gcc-ipq806x.c | 594 ++- include/dt-bindings/clock/qcom,gcc-ipq806x.h | 2 + include/dt-bindings

[PATCH 4/5] stmmac: add ipq806x glue layer

2015-05-26 Thread Mathieu Olivari
The ethernet controller available in IPQ806x is a Synopsys DesignWare Gigabit MAC IP core, already supported by the stmmac driver. This glue layer implements some platform specific settings required to get the controller working on an IPQ806x based platform. Signed-off-by: Mathieu Olivari --- d

[PATCH 2/5] stmmac: add phy-handle support to the platform layer

2015-05-26 Thread Mathieu Olivari
On stmmac driver, PHY specification in device-tree was done using the non-standard property "snps,phy-addr". Specifying a PHY on a different MDIO bus that the one within the stmmac controller doesn't seem to be possible when device-tree is used. This change adds support for the phy-handle property

[PATCH net-next 2/2] net: phy: Utilize phy_interface_is_rgmii

2015-05-26 Thread Florian Fainelli
Update all open-coded tests for all 4 PHY_INTERFACE_MODE_RGMII* values to use the newly introduced helper: phy_interface_is_rgmii. Signed-off-by: Florian Fainelli --- drivers/net/phy/icplus.c | 5 + drivers/net/phy/marvell.c | 10 ++ drivers/net/phy/phy.c | 3 +-- 3 files chan

[PATCH net-next 1/2] net: phy: Add phy_interface_is_rgmii helper

2015-05-26 Thread Florian Fainelli
RGMII interfaces come in 4 different flavors that the PHY library needs to care about: regular RGMII (no delays), RGMII with either RX or TX delay, and both. In order to avoid errors of checking only for one type of RGMII interface and miss the 3 others, introduce a convenience function which tests

[PATCH net-next 0/2] net: phy: phy_interface_is_rgmii helper

2015-05-26 Thread Florian Fainelli
Hi David, As you suggested, here is the helper function to avoid missing some RGMII interface checks. Had to wait for net to be merged in net-next to avoid submitting the same patch/commit. Dan, you might want to rebase your dp83867 submission to use that helper when you this patchset gets merged

Re: [PATCH iproute2] ss: add support for segs_in and segs_out

2015-05-26 Thread Marcelo Ricardo Leitner
On Tue, May 26, 2015 at 02:54:41PM -0400, Craig Gallek wrote: > Two new tcp_info fields: tcpi_segs_in and tcpi_segs_out. > (2efd055c53c06b7e89c167c98069bab9afce7e59) > > ~: ss -ti src :22 >cubic wscale:7,6 rto:201 rtt:0.244/0.012 ato:40 mss:1418 cwnd:21 > bytes_acked:80605 bytes_received:

Re: "ip netns create" hangs forever, spamming console with "unregister_netdevice: waiting for lo to become free"

2015-05-26 Thread Zack Weinberg
On Tue, May 26, 2015 at 12:21 PM, Zack Weinberg wrote: > I have an application that makes heavy use of network namespaces, > creating and destroying them on the fly during operation. With 100% > reproducibility, the first invocation of "ip netns create" after any > "ip netns del" hangs forever in

[PATCH iproute2] ss: add support for segs_in and segs_out

2015-05-26 Thread Craig Gallek
Two new tcp_info fields: tcpi_segs_in and tcpi_segs_out. (2efd055c53c06b7e89c167c98069bab9afce7e59) ~: ss -ti src :22 cubic wscale:7,6 rto:201 rtt:0.244/0.012 ato:40 mss:1418 cwnd:21 bytes_acked:80605 bytes_received:20491 segs_out:414 segs_in:600 send 976.3Mbps lastsnd:23 lastrcv:23 las

Re: [PATCH] net: phy: dp83867: Add TI dp83867 phy

2015-05-26 Thread Dan Murphy
Florian Thanks for the review! On 05/26/2015 01:04 PM, Florian Fainelli wrote: > On 26/05/15 06:07, Dan Murphy wrote: >> Add support for the TI dp83867 Gigabit ethernet phy >> device. >> >> The DP83867 is a robust, low power, fully featured >> Physical Layer transceiver with integrated PMD >> sub

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-26 Thread Jason Gunthorpe
On Tue, May 26, 2015 at 01:46:36PM -0400, Doug Ledford wrote: > > Remember, this isn't RDMA namespaces, this is netdev namespace support > > for RDMA-CM -> very different things. > > That was the point of my email. This is a very myopic view of the > feature. It *should* at least have an idea o

Re: [PATCH net-next] test_bpf: add similarly conflicting jump test case only for classic

2015-05-26 Thread Daniel Borkmann
On 05/26/2015 07:45 PM, Daniel Borkmann wrote: While 3b52960266a3 ("test_bpf: add more eBPF jump torture cases") added the int3 bug test case only for eBPF, which needs exactly 11 passes to converge, here's a version for classic BPF that would ... Noticed a newline accidentally slipped in, plea

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-26 Thread Eric Dumazet
On Tue, 2015-05-26 at 13:55 -0400, Ido Yariv wrote: > > The platform this was tested on was an embedded platform with a wifi > module (11n, 20MHZ). The other end was a computer running Windows, and > the benchmarking software was IxChariot. > The whole setup was running in a shielded box with min

Re: [PATCH v2 net-next 0/3] net: Add incoming CPU mask to sockets

2015-05-26 Thread Eric Dumazet
On Tue, 2015-05-26 at 11:00 -0700, Tom Herbert wrote: > On Tue, May 26, 2015 at 10:18 AM, Eric Dumazet wrote: > > On Tue, 2015-05-26 at 09:34 -0700, Tom Herbert wrote: > >> Added matching of CPU to a socket CPU mask. This is useful for TCP > >> listeners and unconnected UDP. This works with SO_REU

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-26 Thread Eric Dumazet
On Tue, 2015-05-26 at 13:55 -0400, Ido Yariv wrote: > Hi Eric, > > > I understand, and I also suspect that having it expire after 9ms will > have very little impact, if at all. > > Since it mainly affects HZ=100 systems, we can simply go with having at > least 2 jiffies on these systems, and le

Re: [PATCH] net: phy: dp83867: Add TI dp83867 phy

2015-05-26 Thread Florian Fainelli
On 26/05/15 06:07, Dan Murphy wrote: > Add support for the TI dp83867 Gigabit ethernet phy > device. > > The DP83867 is a robust, low power, fully featured > Physical Layer transceiver with integrated PMD > sublayers to support 10BASE-T, 100BASE-TX and > 1000BASE-T Ethernet protocols. > > Signed-

RE: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-26 Thread Christian Benvenuti (benve)
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Doug Ledford > Sent: Tuesday, May 26, 2015 6:35 AM > To: Haggai Eran > Cc: linux-r...@vger.kernel.org; netdev@vger.kernel.org; Liran Liss; Guy > Shapiro; Shachar Raindel; Yotam Ken

RE: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-26 Thread Rose, Gregory V
> -Original Message- > From: Skidmore, Donald C > Sent: Tuesday, May 26, 2015 10:46 AM > To: Hiroshi Shimamoto; Rose, Gregory V; Kirsher, Jeffrey T; intel-wired- > l...@lists.osuosl.org > Cc: nhor...@redhat.com; jogre...@redhat.com; Linux Netdev List; Choi, Sy > Jong; Rony Efraim; David M

Re: [RFC V7 PATCH 7/7] vhost_net: add interrupt coalescing support

2015-05-26 Thread Stephen Hemminger
On Mon, 25 May 2015 01:24:04 -0400 Jason Wang wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index 7d137a4..5ee28b7 100644 > --- a/drivers/vhost/net.c > +++ b/drivers/vh

Re: [PATCH v2 net-next 1/3] net: Add cache alignment in sock_common for socket lookup fields

2015-05-26 Thread Tom Herbert
On Tue, May 26, 2015 at 10:54 AM, Eric Dumazet wrote: > On Tue, 2015-05-26 at 10:19 -0700, Eric Dumazet wrote: > >> No, we do not want to increase the size of sock_common with such a >> hammer. > > Current sizeof(struct sock_common) is 0x78 bytes. > > So moving 2 read_mostly pointers into this str

Re: [PATCH v2 net-next 0/3] net: Add incoming CPU mask to sockets

2015-05-26 Thread Tom Herbert
On Tue, May 26, 2015 at 10:18 AM, Eric Dumazet wrote: > On Tue, 2015-05-26 at 09:34 -0700, Tom Herbert wrote: >> Added matching of CPU to a socket CPU mask. This is useful for TCP >> listeners and unconnected UDP. This works with SO_REUSPORT to steer >> packets to listener sockets based on CPU aff

Re: Socket receives packet to multicast group to which it was not joined since kernel 3.13.10-1

2015-05-26 Thread Eric Dumazet
On Tue, 2015-05-26 at 12:41 -0500, Shawn Bohrer wrote: > On Sun, May 24, 2015 at 04:55:40AM +, Oliver Graff wrote: > > Shawn Bohrer gmail.com> writes: > > > > > > > > On Tue, May 13, 2014 at 04:36:41PM -0500, Shawn Bohrer wrote: > > > > > > If I did "break" something here it appears to be b

  1   2   >