Re: [PATCH net-next] tcp: tcp_v6_connect() cleanup

2015-06-12 Thread David Miller
From: Eric Dumazet Date: Fri, 12 Jun 2015 19:34:03 -0700 > From: Eric Dumazet > > Remove dead code from tcp_v6_connect() > > Signed-off-by: Eric Dumazet Also applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kerne

Re: [PATCH net-next] flow_dissector: fix ipv6 dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread David Miller
From: Eric Dumazet Date: Fri, 12 Jun 2015 19:31:32 -0700 > From: Eric Dumazet > > __skb_header_pointer() returns a pointer that must be checked. > > Fixes infinite loop reported by Alexei, and add __must_check to > catch these errors earlier. > > Fixes: 6a74fcf426f5 ("flow_dissector: add supp

[PATCH net-next 3/5] rocker: mark STP update as 'no wait' processing

2015-06-12 Thread sfeldma
From: Scott Feldman We can get STP updates from the bridge driver in atomic and non-atomic contexts. Since we can't test what context we're getting called in, do the STP processing as 'no wait', which will cover all cases. Signed-off-by: Scott Feldman --- drivers/net/ethernet/rocker/rocker.c

[PATCH net-next 1/5] rocker: revert back to support for nowait processes

2015-06-12 Thread sfeldma
From: Scott Feldman One of the items removed from the rocker driver in the Spring Cleanup patch series was the ability to mark processing in the driver as "no wait" for those contexts where we cannot sleep. Turns out, we have "no wait" contexts where we want to program the device. So re-add the

[PATCH net-next 4/5] rocker: move MAC learn event back to 'no wait' processing

2015-06-12 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman --- drivers/net/ethernet/rocker/rocker.c | 40 +++--- 1 file changed, 3 insertions(+), 37 deletions(-) diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c index 6c15c2e..8430cb3

[PATCH net-next 5/5] rocker: move port stop to 'no wait' processing

2015-06-12 Thread sfeldma
From: Scott Feldman rocker_port_stop can be called from atomic and non-atomic contexts. Since we can't test what context we're getting called in, do the processing as 'no wait', which will cover all cases. Signed-off-by: Scott Feldman --- drivers/net/ethernet/rocker/rocker.c |3 ++- 1 fil

[PATCH net-next 2/5] rocker: mark neigh update event processing as 'no wait'

2015-06-12 Thread sfeldma
From: Scott Feldman Neigh update event handler runs in a context where we can't sleep, so mark processing in driver with ROCKER_OP_FLAG_NOWAIT. NOWAIT will use GFP_ATOMIC for allocations and will queue cmds to the device's cmd ring but will not wait (sleep) for cmd response back from device. Si

[PATCH net-next 0/5] rocker: revert back to support for nowait processes

2015-06-12 Thread sfeldma
From: Scott Feldman One of the items removed from the rocker driver in the Spring Cleanup patch series was the ability to mark processing in the driver as "no wait" for those contexts where we cannot sleep. Turns out, we have "no wait" contexts where we want to program the device and we don't wa

[PATCH net-next] rocker: fix neigh tbl index increment race

2015-06-12 Thread sfeldma
From: Scott Feldman rocker->neigh_tbl_next_index is used to generate unique indices for neigh entries programmed into the device. The way new indices were generated was racy with the new prepare-commit transaction model. A simple fix here removes the race. The race was with two processes getti

[PATCH net-next] rocker: gaurd against NULL rocker_port when removing ports

2015-06-12 Thread sfeldma
From: Scott Feldman The ports array is filled in as ports are probed, but if probing doesn't finish, we need to stop only those ports that where probed successfully. Check the ports array for NULL to skip un-probed ports when stopping. Signed-off-by: Scott Feldman --- drivers/net/ethernet/rock

[PATCH net-next] net: make u64_stats_init() a function

2015-06-12 Thread Eric Dumazet
From: Eric Dumazet Using a function instead of a macro is cleaner and remove following W=1 warnings (extract) In file included from net/ipv6/ip6_vti.c:29:0: net/ipv6/ip6_vti.c: In function ‘vti6_dev_init_gen’: include/linux/netdevice.h:2029:18: warning: variable ‘stat’ set but not used [-Wunused

Re: [PATCH net-next] flow_dissector: fix ipv6 dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Tom Herbert
On Fri, Jun 12, 2015 at 7:31 PM, Eric Dumazet wrote: > From: Eric Dumazet > > __skb_header_pointer() returns a pointer that must be checked. > > Fixes infinite loop reported by Alexei, and add __must_check to > catch these errors earlier. > > Fixes: 6a74fcf426f5 ("flow_dissector: add support for

[PATCH v2 net-next 0/3] bpf: share helpers between tracing and networking

2015-06-12 Thread Alexei Starovoitov
v1->v2: switched to init_user_ns from current_user_ns as suggested by Andy Introduce new helpers to access 'struct task_struct'->pid, tgid, uid, gid, comm fields in tracing and networking. Share bpf_trace_printk() and bpf_get_smp_processor_id() helpers between tracing and networking. Alexei Star

[PATCH v2 net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Alexei Starovoitov
eBPF programs attached to kprobes need to filter based on current->pid, uid and other fields, so introduce helper functions: u64 bpf_get_current_pid_tgid(void) Return: current->tgid << 32 | current->pid u64 bpf_get_current_uid_gid(void) Return: current_gid << 32 | current_uid bpf_get_current_com

[PATCH v2 net-next 2/3] bpf: allow networking programs to use bpf_trace_printk() for debugging

2015-06-12 Thread Alexei Starovoitov
bpf_trace_printk() is a helper function used to debug eBPF programs. Let socket and TC programs use it as well. Note, it's DEBUG ONLY helper. If it's used in the program, the kernel will print warning banner to make sure users don't use it in production. Signed-off-by: Alexei Starovoitov --- v1->

[PATCH v2 net-next 3/3] bpf: let kprobe programs use bpf_get_smp_processor_id() helper

2015-06-12 Thread Alexei Starovoitov
It's useful to do per-cpu histograms. Suggested-by: Daniel Wagner Signed-off-by: Alexei Starovoitov --- v1->v2: no changes kernel/trace/bpf_trace.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 4f9b5d41869b..88a041adee90 1006

[PATCH net-next] tcp: tcp_v6_connect() cleanup

2015-06-12 Thread Eric Dumazet
From: Eric Dumazet Remove dead code from tcp_v6_connect() Signed-off-by: Eric Dumazet --- net/ipv6/tcp_ipv6.c |2 -- 1 file changed, 2 deletions(-) diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 45a7176ed460681558808439f20e1622423f4c32..6748c4277affad71cd721e3a985af10c31c04

[PATCH net-next] flow_dissector: fix ipv6 dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Eric Dumazet
From: Eric Dumazet __skb_header_pointer() returns a pointer that must be checked. Fixes infinite loop reported by Alexei, and add __must_check to catch these errors earlier. Fixes: 6a74fcf426f5 ("flow_dissector: add support for dst, hop-by-hop and routing ext hdrs") Reported-by: Alexei Starovo

Re: [PATCH net-next] Fix Cavium Liquidio build related errors and warnings

2015-06-12 Thread David Miller
From: Raghu Vatsavayi Date: Fri, 12 Jun 2015 18:11:50 -0700 > 1) Fixed following sparse warnings: ... > 2) Fix build errors corresponding to vmalloc on linux-next 4.1. > 3) Liquidio now supports 64 bit only, modified Kconfig accordingly. > 4) Fix some code alignment issues based on kernel build

Re: [PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Alexei Starovoitov
On Fri, Jun 12, 2015 at 07:11:16PM -0700, Eric Dumazet wrote: > On Fri, 2015-06-12 at 18:50 -0700, Alexei Starovoitov wrote: > > > > > sure, that's better. > > If you're going to submit it officialy, please add my Tested-by. > > My server is happy now :) > > Sure , will do. > > I tried adding _

Re: [PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Eric Dumazet
On Fri, 2015-06-12 at 18:50 -0700, Alexei Starovoitov wrote: > > sure, that's better. > If you're going to submit it officialy, please add my Tested-by. > My server is happy now :) Sure , will do. I tried adding __must_check to __skb_header_pointer() but apparently had to use W=1 to get a warni

[no subject]

2015-06-12 Thread Estonia organization
Good day, We are Christian organization, we give out loan to those who are interested in getting a financial help, contact us through our email, at estonia_organizat...@yahoo.cl -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger

Re: [PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Alexei Starovoitov
On Fri, Jun 12, 2015 at 06:37:34PM -0700, Eric Dumazet wrote: > On Fri, 2015-06-12 at 18:27 -0700, Alexei Starovoitov wrote: > > On Fri, Jun 12, 2015 at 09:01:06AM -0700, Tom Herbert wrote: > > > If dst, hop-by-hop or routing extension headers are present determine > > > length of the options and s

Re: [PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Eric Dumazet
On Fri, 2015-06-12 at 18:27 -0700, Alexei Starovoitov wrote: > On Fri, Jun 12, 2015 at 09:01:06AM -0700, Tom Herbert wrote: > > If dst, hop-by-hop or routing extension headers are present determine > > length of the options and skip over them in flow dissection. > > > > Signed-off-by: Tom Herbert

Re: [PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Alexei Starovoitov
On Fri, Jun 12, 2015 at 09:01:06AM -0700, Tom Herbert wrote: > If dst, hop-by-hop or routing extension headers are present determine > length of the options and skip over them in flow dissection. > > Signed-off-by: Tom Herbert > --- > net/core/flow_dissector.c | 17 + > 1 file ch

[PATCH net-next] Fix Cavium Liquidio build related errors and warnings

2015-06-12 Thread Raghu Vatsavayi
1) Fixed following sparse warnings: lio_main.c:213:6: warning: symbol 'octeon_droq_bh' was not declared. Should it be static? lio_main.c:233:5: warning: symbol 'lio_wait_for_oq_pkts' was not declared. Should it be static? lio_main.c:3083:5: warning: symbol 'lio_nic_info' was not

Re: Fw: [Bug 98781] New: WWAN: TX bytes counter shows very huge impossible value

2015-06-12 Thread Kevin
Stephen Hemminger networkplumber.org> writes: > > > Begin forwarded message: > > Date: Sat, 23 May 2015 16:54:50 + > From: "bugzilla-daemon bugzilla.kernel.org" bugzilla.kernel.org> > To: "shemminger linux-foundation.org" linux-foundation.org> > Subject: [Bug 98781] New: WWAN: TX bytes

[PATCH net-next v2] bridge: use either ndo VLAN ops or switchdev VLAN ops to install MASTER vlans

2015-06-12 Thread sfeldma
From: Scott Feldman v2: Move struct switchdev_obj automatics to inner scope where there used. v1: To maintain backward compatibility with the existing iproute2 "bridge vlan" command, let bridge's setlink/dellink handler call into either the port driver's 8021q ndo ops or the port driver's brid

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Alexei Starovoitov
On 6/12/15 5:24 PM, Andy Lutomirski wrote: >so what specifically you proposing? >Use from_kuid(&init_user_ns,...) instead? That seems reasonable to me. After all, you can't install one of these probes from a non-init userns. ok. will respin with that change. -- To unsubscribe from this list:

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Andy Lutomirski
On Fri, Jun 12, 2015 at 5:15 PM, Alexei Starovoitov wrote: > On 6/12/15 5:03 PM, Andy Lutomirski wrote: >> >> On Fri, Jun 12, 2015 at 4:55 PM, Alexei Starovoitov >> wrote: >>> >>> On 6/12/15 4:47 PM, Andy Lutomirski wrote: On Fri, Jun 12, 2015 at 4:38 PM, Alexei Starovoitov w

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Alexei Starovoitov
On 6/12/15 5:03 PM, Andy Lutomirski wrote: On Fri, Jun 12, 2015 at 4:55 PM, Alexei Starovoitov wrote: On 6/12/15 4:47 PM, Andy Lutomirski wrote: On Fri, Jun 12, 2015 at 4:38 PM, Alexei Starovoitov wrote: On 6/12/15 4:25 PM, Andy Lutomirski wrote: It's a dangerous tool. Also, shouldn't

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Andy Lutomirski
On Fri, Jun 12, 2015 at 4:55 PM, Alexei Starovoitov wrote: > On 6/12/15 4:47 PM, Andy Lutomirski wrote: >> >> On Fri, Jun 12, 2015 at 4:38 PM, Alexei Starovoitov >> wrote: >>> >>> On 6/12/15 4:25 PM, Andy Lutomirski wrote: It's a dangerous tool. Also, shouldn't the returned uid ma

[GIT] Networking

2015-06-12 Thread David Miller
1) Fix uninitialized struct station_info in cfg80211_wireless_stats(), from Johannes Berg. 2) Revert commit attempt to fix ipv6 protocol resubmission, it adds regressions. 3) Endless loops can be created in bridge port lists, fix from Nikolay Aleksandrov. 4) Don't WARN_ON() if sk->sk_f

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Alexei Starovoitov
On 6/12/15 4:47 PM, Andy Lutomirski wrote: On Fri, Jun 12, 2015 at 4:38 PM, Alexei Starovoitov wrote: On 6/12/15 4:25 PM, Andy Lutomirski wrote: It's a dangerous tool. Also, shouldn't the returned uid match the namespace of the task that installed the probe, not the task that's being probed?

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Andy Lutomirski
On Fri, Jun 12, 2015 at 4:38 PM, Alexei Starovoitov wrote: > On 6/12/15 4:25 PM, Andy Lutomirski wrote: >> >> It's a dangerous tool. Also, shouldn't the returned uid match the >> namespace of the task that installed the probe, not the task that's >> being probed? > > > so leaking info to unprivil

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Alexei Starovoitov
On 6/12/15 4:25 PM, Andy Lutomirski wrote: It's a dangerous tool. Also, shouldn't the returned uid match the namespace of the task that installed the probe, not the task that's being probed? so leaking info to unprivileged apps is the concern? The whole thing is for root only as you know. The

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Andy Lutomirski
On Fri, Jun 12, 2015 at 4:23 PM, Alexei Starovoitov wrote: > On 6/12/15 3:54 PM, Andy Lutomirski wrote: >> >> On Fri, Jun 12, 2015 at 3:44 PM, Alexei Starovoitov >> wrote: >>> >>> On 6/12/15 3:08 PM, Andy Lutomirski wrote: On Fri, Jun 12, 2015 at 2:40 PM, Alexei Starovoitov w

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Alexei Starovoitov
On 6/12/15 3:54 PM, Andy Lutomirski wrote: On Fri, Jun 12, 2015 at 3:44 PM, Alexei Starovoitov wrote: On 6/12/15 3:08 PM, Andy Lutomirski wrote: On Fri, Jun 12, 2015 at 2:40 PM, Alexei Starovoitov wrote: eBPF programs attached to kprobes need to filter based on current->pid, uid and other

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Andy Lutomirski
On Fri, Jun 12, 2015 at 3:44 PM, Alexei Starovoitov wrote: > On 6/12/15 3:08 PM, Andy Lutomirski wrote: >> >> On Fri, Jun 12, 2015 at 2:40 PM, Alexei Starovoitov >> wrote: >>> >>> eBPF programs attached to kprobes need to filter based on >>> current->pid, uid and other fields, so introduce helper

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Alexei Starovoitov
On 6/12/15 3:08 PM, Andy Lutomirski wrote: On Fri, Jun 12, 2015 at 2:40 PM, Alexei Starovoitov wrote: eBPF programs attached to kprobes need to filter based on current->pid, uid and other fields, so introduce helper functions: u64 bpf_get_current_pid_tgid(void) Return: current->tgid << 32 | cu

Re: [PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Andy Lutomirski
On Fri, Jun 12, 2015 at 2:40 PM, Alexei Starovoitov wrote: > eBPF programs attached to kprobes need to filter based on > current->pid, uid and other fields, so introduce helper functions: > > u64 bpf_get_current_pid_tgid(void) > Return: current->tgid << 32 | current->pid > > u64 bpf_get_current_ui

[PATCH net-next 2/3] bpf: allow networking programs to use bpf_trace_printk() for debugging

2015-06-12 Thread Alexei Starovoitov
bpf_trace_printk() is a helper function used to debug eBPF programs. Let socket and TC programs use it as well. Note, it's DEBUG ONLY helper. If it's used in the program, the kernel will print warning banner to make sure users don't use it in production. Signed-off-by: Alexei Starovoitov --- inc

[PATCH net-next 0/3] bpf: share helpers between tracing and networking

2015-06-12 Thread Alexei Starovoitov
Introduce new helpers to access 'struct task_struct'->pid, tgid, uid, gid, comm fields in tracing and networking. Share bpf_trace_printk() and bpf_get_smp_processor_id() helpers between tracing and networking. Alexei Starovoitov (3): bpf: introduce current->pid, tgid, uid, gid, comm accessors

[PATCH net-next 1/3] bpf: introduce current->pid, tgid, uid, gid, comm accessors

2015-06-12 Thread Alexei Starovoitov
eBPF programs attached to kprobes need to filter based on current->pid, uid and other fields, so introduce helper functions: u64 bpf_get_current_pid_tgid(void) Return: current->tgid << 32 | current->pid u64 bpf_get_current_uid_gid(void) Return: current_gid << 32 | current_uid bpf_get_current_com

[PATCH net-next 3/3] bpf: let kprobe programs use bpf_get_smp_processor_id() helper

2015-06-12 Thread Alexei Starovoitov
It's useful to do per-cpu histograms. Suggested-by: Daniel Wagner Signed-off-by: Alexei Starovoitov --- kernel/trace/bpf_trace.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 4f9b5d41869b..88a041adee90 100644 --- a/kernel/trac

Re: next-20150610 - repeated hangs at e1000e_phc_gettime+0x2e/0x60

2015-06-12 Thread Valdis . Kletnieks
On Thu, 11 Jun 2015 22:57:48 -0400, Valdis Kletnieks said: > 0) next-20150603 works, so the problem landed in linux-next in the last week. > > 1) All 3 times happened while I was at home, using wireless, so > the interface didn't have link and was ifconfig'ed down. All 3 crashes happened at almos

Re: [PATCH net-next 0/2] flow_dissector: Fix MPLS parsing and add ext hdr support

2015-06-12 Thread David Miller
From: Tom Herbert Date: Fri, 12 Jun 2015 09:01:04 -0700 > Need to shift label. Added parsing of dst, hop-by-hop, and routing > extension headers. Series applied, thanks Tom. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] Doc: networking: Fix URL for wiki.wireshark.org in udplite.txt

2015-06-12 Thread David Miller
From: Masanari Iida Date: Sat, 13 Jun 2015 00:23:21 +0900 > This patch fix URL (http to https) for wiki.wireshark.org. > > Signed-off-by: Masanari Iida Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] netdevice: add netdev_pub helper function

2015-06-12 Thread David Miller
From: "Jason A. Donenfeld" Date: Fri, 12 Jun 2015 15:30:29 +0200 > Being able to utilize this makes much code a lot simpler and cleaner. > It's a nice convenience function. > > Signed-off-by: Jason A. Donenfeld Please do not ever submit patches adding new interfaces without also submitting cha

Re: [PATCH -next] net: ipv4: un-inline ip_finish_output2

2015-06-12 Thread David Miller
From: Florian Westphal Date: Fri, 12 Jun 2015 12:12:22 +0200 > textdata bss dec hex filename > old: 16527 44 0 1657140bb net/ipv4/ip_output.o > new: 14935 44 0 149793a83 net/ipv4/ip_output.o > > Suggested-by: Eric Dumazet > Signed-off-by: F

Re: [PATCH] sctp: allow authenticating DATA chunks that are bundled with COOKIE_ECHO

2015-06-12 Thread David Miller
From: mleit...@redhat.com Date: Thu, 11 Jun 2015 14:49:46 -0300 > From: Marcelo Ricardo Leitner > > Currently, we can ask to authenticate DATA chunks and we can send DATA > chunks on the same packet as COOKIE_ECHO, but if you try to combine > both, the DATA chunk will be sent unauthenticated and

Re: iproute2: missing patches in branch net-next

2015-06-12 Thread Daniel Borkmann
On 05/29/2015 01:15 AM, Daniel Borkmann wrote: On 05/29/2015 01:12 AM, Stephen Hemminger wrote: ... I will go back and recreate what is missing. Sorry for the confusion. Great thanks, no problem. Hmm, two weeks have passed. :/ Is there any progress so far? -- To unsubscribe from this list: s

[PATCH next v1] bonding: Display LACP info only to CAP_NET_ADMIN capable user

2015-06-12 Thread Mahesh Bandewar
Actor and Partner details can be accessed via proc-fs and sys-fs entries. These interfaces are world readable at this moment. The earlier patch-series made the LACP communication secure to avoid nuisance attack from within the same L2 domain but it did not prevent "someone unprivileged" looking at

[PATCH] ethernet/sfc: mark state UNINIT after unregister

2015-06-12 Thread Jarod Wilson
Without this change, modprobe -r sfc hits the BUG_ON() in efx_pci_remove_main(). Best as I can tell, this was just an oversight, efx->state gets set to STATE_UNINIT in the error path of efx_register_netdev() just after unregister_netdevice(), and the same should happen in efx_unregister_netdev() af

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-12 Thread Andrew Lunn
On Fri, Jun 12, 2015 at 11:14:25AM -0700, Florian Fainelli wrote: > On 12/06/15 10:18, Andrew Lunn wrote: > > By default, DSA and CPU ports are configured to the maximum speed the > > switch supports. However there can be use cases where the peer device > > port is slower. Allow a fixed-link proper

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-12 Thread Guenter Roeck
On 06/12/2015 11:14 AM, Florian Fainelli wrote: On 12/06/15 10:18, Andrew Lunn wrote: By default, DSA and CPU ports are configured to the maximum speed the switch supports. However there can be use cases where the peer device port is slower. Allow a fixed-link property to be used with the DSA an

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-12 Thread Florian Fainelli
On 12/06/15 10:18, Andrew Lunn wrote: > By default, DSA and CPU ports are configured to the maximum speed the > switch supports. However there can be use cases where the peer device > port is slower. Allow a fixed-link property to be used with the DSA > and CPU port in the device tree, and use this

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-12 Thread Guenter Roeck
Hi Florian, On 06/12/2015 10:18 AM, Andrew Lunn wrote: By default, DSA and CPU ports are configured to the maximum speed the switch supports. However there can be use cases where the peer device port is slower. Allow a fixed-link property to be used with the DSA and CPU port in the device tree,

Re: [PATCH next v0] bonding: Display LACP info only to CAP_SYS_ADMIN capable user

2015-06-12 Thread Mahesh Bandewar
On Thu, Jun 11, 2015 at 3:22 PM, David Miller wrote: > > From: Mahesh Bandewar > Date: Wed, 10 Jun 2015 17:19:56 -0700 > > > Actor and Partner details can be accessed via proc-fs and sys-fs > > entries. These interfaces are world readable at this moment. The > > earlier patch-series made the LACP

[PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-12 Thread Andrew Lunn
By default, DSA and CPU ports are configured to the maximum speed the switch supports. However there can be use cases where the peer device port is slower. Allow a fixed-link property to be used with the DSA and CPU port in the device tree, and use this information to configure the port. Signed-of

[PATCH 2/3] dsa: mv88e6xxx: Allow speed/duplex of port to be configured

2015-06-12 Thread Andrew Lunn
The current code sets user ports to perform auto negotiation using the phy. CPU and DSA ports are configured to full duplex and maximum speed the switch supports. There are however use cases where the CPU has a slower port, and when user ports have SFP modules with fixed speed. In these cases, all

[PATCH 1/3] net: phy: Allow PHY devices to identify themselves as Ethernet switches, etc.

2015-06-12 Thread Andrew Lunn
From: Florian Fainelli Some Ethernet MAC drivers using the PHY library require the hardcoding of link parameters when interfaced to a switch device, SFP module, switch to switch port, etc. This has typically lead to various ad-hoc implementations looking like this: - using a "fixed PHY" emulated

Re: [PATCH] sctp: allow authenticating DATA chunks that are bundled with COOKIE_ECHO

2015-06-12 Thread Vlad Yasevich
On 06/12/2015 07:26 AM, Neil Horman wrote: > On Thu, Jun 11, 2015 at 05:27:45PM -0700, David Miller wrote: >> From: mleit...@redhat.com >> Date: Thu, 11 Jun 2015 14:49:46 -0300 >> >>> From: Marcelo Ricardo Leitner >>> >>> Currently, we can ask to authenticate DATA chunks and we can send DATA >>> c

Re: [PATCH net-next v2] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-12 Thread Andy Gospodarek
On Thu, Jun 11, 2015 at 08:19:01AM -0700, sfel...@gmail.com wrote: > From: Scott Feldman > > Fix a BUG_ON() where CONFIG_NET_SWITCHDEV is set but the driver for a > bridged port does not support switchdev_port_attr_set op. Don't BUG_ON() > if -EOPNOTSUPP is returned. > > Also change BUG_ON() to

Re: [PATCH] mlx4_en: don't wait for high order page allocation

2015-06-12 Thread Shaohua Li
On Fri, Jun 12, 2015 at 10:05:42AM -0700, Alexander Duyck wrote: > On 06/12/2015 09:50 AM, Shaohua Li wrote: > >High order page allocation can cause direct memory compaction and harm > >performance. The patch makes the high order page allocation don't wait, > >so not trigger direct memory compactio

Re: [PATCH] mlx4_en: don't wait for high order page allocation

2015-06-12 Thread Alexander Duyck
On 06/12/2015 09:50 AM, Shaohua Li wrote: High order page allocation can cause direct memory compaction and harm performance. The patch makes the high order page allocation don't wait, so not trigger direct memory compaction with memory pressure. More details can be found in a similar patch for n

[BUG ?] delay always evaluates to 0

2015-06-12 Thread Nicholas Mc Guire
Hi ! commit 2c86c275015c ("Add ipw2100 wireless driver.") introduced drivers/net/wireless/ipw2100.c - line-numbers are from next-20150511 1410 static int ipw2100_hw_phy_off(struct ipw2100_priv *priv) 1411 { 1412 1413 #define HW_PHY_OFF_LOOP_DELAY (HZ / 5000) 141

[PATCH] mlx4_en: don't wait for high order page allocation

2015-06-12 Thread Shaohua Li
High order page allocation can cause direct memory compaction and harm performance. The patch makes the high order page allocation don't wait, so not trigger direct memory compaction with memory pressure. More details can be found in a similar patch for net core: http://marc.info/?l=linux-mm&m=1434

[PATCH] netlink: add API to retrieve all group memberships

2015-06-12 Thread David Herrmann
This patch adds getsockopt(SOL_NETLINK, NETLINK_LIST_MEMBERSHIPS) to retrieve all groups a socket is a member of. Currently, we have to use getsockname() and look at the nl.nl_groups bitmask. However, this mask is limited to 32 groups. Hence, similar to NETLINK_ADD_MEMBERSHIP and NETLINK_DROP_MEMBE

Re: [PATCH WIP RFC 0/3] mpls: support for ler

2015-06-12 Thread roopa
On 6/10/15, 12:13 AM, roopa wrote: Robert/Thomas, All my changes are in the below repo under the 'mpls' branch. https://github.com/CumulusNetworks/net-next https://github.com/CumulusNetworks/iproute2 The last iproute2 commit has a sample usage. The commits pushed to this tree do not contain su

[PATCH net-next 1/2] flow_dissector: Fix MPLS entropy label handling in flow dissector

2015-06-12 Thread Tom Herbert
Need to shift after masking to get label value for comparison. Fixes: b3baa0fbd02a1a9d493d8 ("mpls: Add MPLS entropy label in flow_keys") Reported-by: Dan Carpenter Signed-off-by: Tom Herbert --- net/core/flow_dissector.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/n

[PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Tom Herbert
If dst, hop-by-hop or routing extension headers are present determine length of the options and skip over them in flow dissection. Signed-off-by: Tom Herbert --- net/core/flow_dissector.c | 17 + 1 file changed, 17 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/

[PATCH net-next 0/2] flow_dissector: Fix MPLS parsing and add ext hdr support

2015-06-12 Thread Tom Herbert
Need to shift label. Added parsing of dst, hop-by-hop, and routing extension headers. Tom Herbert (2): flow_dissector: Fix MPLS entropy label handling in flow dissector flow_dissector: add support for dst, hop-by-hop and routing ext hdrs net/core/flow_dissector.c | 21 +++--

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-12 Thread Steven Rostedt
On Fri, 12 Jun 2015 11:50:38 -0400 Steven Rostedt wrote: > On Fri, 12 Jun 2015 11:34:20 -0400 > Steven Rostedt wrote: > > > And the issue goes away. That is, I watched the port go from > ESTABLISHED to TIME_WAIT, and then gone, and theirs no hidden port. > s/theirs/there's/ Time to go back

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-12 Thread Steven Rostedt
On Fri, 12 Jun 2015 11:34:20 -0400 Steven Rostedt wrote: > On Fri, 12 Jun 2015 07:40:35 -0700 > Eric Dumazet wrote: > > > Strange, because the usual way to not have time-wait is to use SO_LINGER > > with linger=0 > > > > And apparently xs_tcp_finish_connecting() has this : > > > >

[PATCH] net: fec: Ensure clocks are enabled while using mdio bus

2015-06-12 Thread Andrew Lunn
When a switch is attached to the mdio bus, the mdio bus can be used while the interface is not open. If the clocks are not enabled, MDIO reads/writes will simply time out. So enable the clocks before starting a transaction, and disable them afterwards. The CCF performs reference counting so the clo

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-12 Thread Eric Dumazet
On Fri, 2015-06-12 at 10:57 -0400, Trond Myklebust wrote: > On Fri, Jun 12, 2015 at 10:40 AM, Eric Dumazet wrote: > > Strange, because the usual way to not have time-wait is to use SO_LINGER > > with linger=0 > > > > And apparently xs_tcp_finish_connecting() has this : > > > > soc

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-12 Thread Steven Rostedt
On Fri, 12 Jun 2015 07:40:35 -0700 Eric Dumazet wrote: > Strange, because the usual way to not have time-wait is to use SO_LINGER > with linger=0 > > And apparently xs_tcp_finish_connecting() has this : > > sock_reset_flag(sk, SOCK_LINGER); > tcp_sk(sk)->linger2

[PATCH net-next] tcp: cdg: use div_u64()

2015-06-12 Thread Kenneth Klette Jonassen
Fixes cross-compile to mips. Signed-off-by: Kenneth Klette Jonassen --- Fixes build error for mips-allyesconfig: net/built-in.o: In function `tcp_cdg_cong_avoid': >> tcp_cdg.c:(.text+0x217774): undefined reference to `__udivdi3' https://lists.01.org/pipermail/kbuild-all/2015-June/010142.html

[PATCH] Doc: networking: Fix URL for wiki.wireshark.org in udplite.txt

2015-06-12 Thread Masanari Iida
This patch fix URL (http to https) for wiki.wireshark.org. Signed-off-by: Masanari Iida --- Documentation/networking/udplite.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/udplite.txt b/Documentation/networking/udplite.txt index d727a38..53a7268

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-12 Thread Trond Myklebust
On Fri, Jun 12, 2015 at 10:40 AM, Eric Dumazet wrote: > On Fri, 2015-06-12 at 10:10 -0400, Trond Myklebust wrote: >> On Thu, Jun 11, 2015 at 11:49 PM, Steven Rostedt wrote: >> > >> > I recently upgraded my main server to 4.0.4 from 3.19.5 and rkhunter >> > started reporting a hidden port on my bo

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-12 Thread Eric Dumazet
On Fri, 2015-06-12 at 10:10 -0400, Trond Myklebust wrote: > On Thu, Jun 11, 2015 at 11:49 PM, Steven Rostedt wrote: > > > > I recently upgraded my main server to 4.0.4 from 3.19.5 and rkhunter > > started reporting a hidden port on my box. > > > > Running unhide-tcp I see this: > > > > # unhide-tc

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-12 Thread Trond Myklebust
On Thu, Jun 11, 2015 at 11:49 PM, Steven Rostedt wrote: > > I recently upgraded my main server to 4.0.4 from 3.19.5 and rkhunter > started reporting a hidden port on my box. > > Running unhide-tcp I see this: > > # unhide-tcp > Unhide-tcp 20121229 > Copyright © 2012 Yago Jesus & Patrick Gouin > Li

RE: [PATCH net-next v2 05/19] bna: use BIT(x) instead of (1 << x)

2015-06-12 Thread David Laight
From: Ivan Vecera ... > diff --git a/drivers/net/ethernet/brocade/bna/bfa_defs_mfg_comm.h > b/drivers/net/ethernet/brocade/bna/bfa_defs_mfg_comm.h > index 679a503..16090fd 100644 > --- a/drivers/net/ethernet/brocade/bna/bfa_defs_mfg_comm.h > +++ b/drivers/net/ethernet/brocade/bna/bfa_defs_mfg_comm.

[PATCH] netdevice: add netdev_pub helper function

2015-06-12 Thread Jason A. Donenfeld
Being able to utilize this makes much code a lot simpler and cleaner. It's a nice convenience function. Signed-off-by: Jason A. Donenfeld --- include/linux/netdevice.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 05b

[PATCH net-next] Increase limit of macvtap queues

2015-06-12 Thread Pankaj Gupta
Macvtap should be compatible with tuntap for maximum number of queues. '1059590254fa9dce9cafc4f07d1103dbec415e76' removes the limitation and increases number of queues in tuntap. Now, Its safe to increase number of queues in Macvtap as well. Signed-off-by: Pankaj Gupta --- include/linux/if_macvl

Re: [PATCH v5 00/24] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-12 Thread Thomas Gleixner
On Fri, 12 Jun 2015, Baolin Wang wrote: Sigh. Again threading of the series failed. Some patches are, the whole series is not. Can you please get your tools straight? You neither managed to cc me on the security patch. > - Modify the subject line and the changelog: > timekeeping: Change the i

Re: [PATCH nf-next] net: ip_fragment: remove BRIDGE_NETFILTER mtu special handling

2015-06-12 Thread Pablo Neira Ayuso
On Fri, Jun 05, 2015 at 01:28:38PM +0200, Florian Westphal wrote: > since commit d6b915e29f4adea9 > ("ip_fragment: don't forward defragmented DF packet") the largest > fragment size is available in the IPCB. > > Therefore we no longer need to care about 'encapsulation' > overhead of stripped PPPOE

Cavium Liquidio: select on undefined option LIBCRC32

2015-06-12 Thread Valentin Rothberg
Hi Raghu, your commit f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters") is in today's linux-next tree (i.e., next-20150612) adding the following lines of code: +config LIQUIDIO [...] + select LIBCRC32 The select turns out to be a NOOP since there is no opt

Re: [PATCH] sctp: allow authenticating DATA chunks that are bundled with COOKIE_ECHO

2015-06-12 Thread Neil Horman
On Thu, Jun 11, 2015 at 05:27:45PM -0700, David Miller wrote: > From: mleit...@redhat.com > Date: Thu, 11 Jun 2015 14:49:46 -0300 > > > From: Marcelo Ricardo Leitner > > > > Currently, we can ask to authenticate DATA chunks and we can send DATA > > chunks on the same packet as COOKIE_ECHO, but i

[PATCH -next] net: ipv4: un-inline ip_finish_output2

2015-06-12 Thread Florian Westphal
textdata bss dec hex filename old: 16527 44 0 1657140bb net/ipv4/ip_output.o new: 14935 44 0 149793a83 net/ipv4/ip_output.o Suggested-by: Eric Dumazet Signed-off-by: Florian Westphal --- diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output

Re: [RFC net-next 0/3] Proposal for VRF-lite

2015-06-12 Thread Thomas Graf
On 06/10/15 at 01:43pm, Shrijeet Mukherjee wrote: > On Tue, Jun 9, 2015 at 3:15 AM, Thomas Graf wrote: > > Do I understand this correctly that swp* represent veth pairs? > > Why do you have distinct addresses on each peer of the pair? > > Are the addresses in N2 and N3 considered private and NATed

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-12 Thread Vlastimil Babka
On 06/12/2015 01:50 AM, Shaohua Li wrote: We saw excessive direct memory compaction triggered by skb_page_frag_refill. This causes performance issues and add latency. Commit 5640f7685831e0 introduces the order-3 allocation. According to the changelog, the order-3 allocation isn't a must-have but

Re: [RFC] net: use atomic allocation for order-3 page allocation

2015-06-12 Thread Vlastimil Babka
On 06/11/2015 11:28 PM, Debabrata Banerjee wrote: Resend in plaintext, thanks gmail: It's somewhat an intractable problem to know if compaction will succeed without trying it, There are heuristics, but those cannot be perfect by definition. I think the worse problem here is the extra latency,

Re: [RFC] net: use atomic allocation for order-3 page allocation

2015-06-12 Thread Vlastimil Babka
On 06/11/2015 11:35 PM, Debabrata Banerjee wrote: There is no "background" it doesn't matter if this activity happens synchronously or asynchronously, unless you're sensitive to the latency on that single operation. If you're driving all your cpu's and memory hard then this is work that still tak

RE: [V6 PATCH 6/7] megaraid_sas: fix TRUE and FALSE re-define build error

2015-06-12 Thread Sumit Saxena
>-Original Message- >From: Suravee Suthikulpanit [mailto:suravee.suthikulpa...@amd.com] >Sent: Wednesday, June 10, 2015 9:39 PM >To: r...@rjwysocki.net; l...@kernel.org; catalin.mari...@arm.com; >will.dea...@arm.com; thomas.lenda...@amd.com; >herb...@gondor.apana.org.au; da...@davemloft.net

[PATCH v5 20/24] posix-clock: Convert to y2038 safe callbacks

2015-06-12 Thread Baolin Wang
The clock_getres()/clock_get()/clock_set()/timer_set()/timer_get() callbacks in struct k_clock are not year 2038 safe on 32bit systems, and it need convert to safe callbacks which use struct timespec64 or struct itimerspec64. The clock_gettime()/clock_settime()/clock_getres()/timer_gettime()/ time

RENDSZERGAZDA

2015-06-12 Thread br1788
Ez az üzenet a rendszergazda üzenetközpont valamennyi tulajdonosa webmail számlák. Jelenleg korszerűsítése a adatbázis-központ és figyelembe email. Töröljük email segítségével webes e-mail fiókot, hogy nagyobb teret az új számlákat. Ha még nem frissítette előtt ez az utolsó alkalom, hogy csinálni.

[PATCH v5 00/24] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-12 Thread Baolin Wang
This patch series changes the 32-bit time types (timespec/itimerspec) to the 64-bit types (timespec64/itimerspec64), since 32-bit time types will break in the year 2038 on 32bit systems. This patch series introduces new methods with timespec64/itimerspec64 type, and removes the old ones with times