[PATCH] net/phy: Add Vitesse 8641 phy ID

2015-06-25 Thread shh.xie
From: Shaohui Xie Vitesse VSC8641 is compatible with Vitesse 82xx Signed-off-by: Shaohui Xie --- drivers/net/phy/vitesse.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c index 76cad71..17cad18 100644 --- a/drivers/net/p

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-06-25 Thread Daniel Borkmann
On 06/25/2015 05:31 AM, Stephen Hemminger wrote: On Fri, 29 May 2015 18:48:42 +0200 Daniel Borkmann wrote: On 05/29/2015 06:17 PM, Guzman Mosqueda, Jose R wrote: Hi Daniel and Vadim Thanks for your prompt response and for the patch. Also, what about the other one? Do you think it is an issu

Re: [PATCH v2 0/4] net: dsa: mv88e6352: add support for VLAN Table Unit

2015-06-25 Thread David Miller
From: Vivien Didelot Date: Wed, 24 Jun 2015 14:50:55 -0400 > This patchset brings full support for hardware VLANs in DSA, and the Marvell > 88E6352 and compatible switch chips. As I clearly announced on net-next yesterday, the net-next tree is now closed. Please resubmit this series when the ne

[PATCH net V1 2/4] net/mlx4_en: Wake TX queues only when there's enough room

2015-06-25 Thread Or Gerlitz
From: Ido Shamay Indication of a single completed packet, marked by txbbs_skipped being bigger then zero, in not enough in order to wake up a stopped TX queue. The completed packet may contain a single TXBB, while next packet to be sent (after the wake up) may have multiple TXBBs (LSO/TSO packets

[PATCH net V1 0/4] mlx4 driver fixes, June 24, 2015

2015-06-25 Thread Or Gerlitz
Hi Dave, Some fixes that we made recently, all need to go into stable. patch #1 "net/mlx4_en: Release TX QP when destroying TX ring" and patch #3 "Fix wrong csum complete report when rxvlan offload is disabled" to >= 3.19 patch #2 "Wake TX queues only when there's enough room" addressing a bug

[PATCH net V1 4/4] mlx4: Disable HA for SRIOV PF RoCE devices

2015-06-25 Thread Or Gerlitz
When in HA mode, the driver exposes an IB (RoCE) device instance with only one port. Under SRIOV, the existing implementation doesn't go well with the PF RoCE driver's role of Special QPs Para-Virtualization, etc. As such, disable HA for the mlx4 PF RoCE device in SRIOV mode. Fixes: a57500903093

[PATCH net V1 3/4] net/mlx4_en: Fix wrong csum complete report when rxvlan offload is disabled

2015-06-25 Thread Or Gerlitz
From: Ido Shamay The check_csum() function relied on hwtstamp_rx_filter to know if rxvlan offload is disabled. This is wrong since rxvlan offload can be switched on/off regardless of hwtstamp_rx_filter. Also moved check_csum to query CQE information to identify VLAN packets and removed the check

[PATCH net V1 1/4] net/mlx4_en: Release TX QP when destroying TX ring

2015-06-25 Thread Or Gerlitz
From: Eran Ben Elisha TX ring QP wasn't released at mlx4_en_destroy_tx_ring. Instead, the code used the deprecated base_tx_qpn field. Move TX QP release to mlx4_en_destroy_tx_ring and remove the base_tx_qpn field. Fixes: ddae0349fdb7 ('net/mlx4: Change QP allocation scheme') Signed-off-by: Eran

Re: [PATCH net V1 0/4] mlx4 driver fixes, June 24, 2015

2015-06-25 Thread David Miller
From: Or Gerlitz Date: Thu, 25 Jun 2015 11:29:40 +0300 > Some fixes that we made recently, all need to go into stable. > > patch #1 "net/mlx4_en: Release TX QP when destroying TX ring" and patch #3 > "Fix wrong csum complete report when rxvlan offload is disabled" to >= 3.19 > > patch #2 "Wake

Re: [patch -next] renesas: missing unlock on error path

2015-06-25 Thread David Miller
From: Dan Carpenter Date: Wed, 24 Jun 2015 17:32:54 +0300 > We need to unlock before returning here. > > Fixes: a0d2f20650e8 ('Renesas Ethernet AVB PTP clock driver') > Signed-off-by: Dan Carpenter Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: [patch -next] cavium/liquidio: fix some error handling in lio_set_phys_id()

2015-06-25 Thread David Miller
From: Dan Carpenter Date: Wed, 24 Jun 2015 17:47:02 +0300 > There was a missing assignment so the "if (ret)" on the next line is > never true. > > Fixes: f21fb3ed364b ('Add support of Cavium Liquidio ethernet adapters') > Signed-off-by: Dan Carpenter Applied. -- To unsubscribe from this list:

Re: [PATCH] net/phy: Add Vitesse 8641 phy ID

2015-06-25 Thread David Miller
From: Date: Thu, 25 Jun 2015 13:34:27 +0800 > From: Shaohui Xie > > Vitesse VSC8641 is compatible with Vitesse 82xx > > Signed-off-by: Shaohui Xie Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH] net/fsl: remove dependency FSL_SOC for Gianfar

2015-06-25 Thread David Miller
From: Alison Wang Date: Thu, 25 Jun 2015 11:34:38 +0800 > CONFIG_GIANFAR is not depended on FSL_SOC, it > can be built on non-PPC platforms. > > Signed-off-by: Alison Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.k

[PATCH 2/2] iproute2: misc/ss.c - fix run_ssfilter af_packet when protocol == 0

2015-06-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski s->local.data is a pointer to a field of a non-NULL struct, and hence cannot be NULL, thus comparing it to 0 is always false, and thus the return is always false. Presumably this was meant to be a check whether s->local.data[0] (which I believe stores af_packet protocol

[PATCH 1/2] iproute2: tc/m_pedit.c - remove dead code

2015-06-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski The initializers are simply not needed. These if-blocks are outright dead code, because '0 > unsigned' is always false, so only else clause triggers and regardless of which clause triggers it only updates 'ind' which is later unconditionally written to before being used

Re: [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell, armada-xp-neta"

2015-06-25 Thread Simon Guinot
On Fri, Jun 19, 2015 at 02:32:53PM +0200, Simon Guinot wrote: > On Wed, Jun 17, 2015 at 05:01:12PM +, Jason Cooper wrote: > > Hi Gregory, > > > > On Wed, Jun 17, 2015 at 05:15:28PM +0200, Gregory CLEMENT wrote: > > > On 17/06/2015 17:12, Gregory CLEMENT wrote: > > > > On 17/06/2015 15:19, Simo

Re: [RFC] virtio_net: Adding tx_timeout function.

2015-06-25 Thread Jason Wang
On 06/25/2015 09:31 AM, Julio Faracco wrote: > 2015-06-24 3:10 GMT-03:00 Michael S. Tsirkin : >> On Tue, Jun 23, 2015 at 10:44:29PM -0300, Julio Faracco wrote: >>> virtio_net paravirtualized driver does not have a tx_timeout() function to >>> guarantee that the driver will recover properly after

Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

2015-06-25 Thread Oliver Neukum
On Tue, 2015-06-23 at 00:32 +0200, Enrico Mioso wrote: > This patch introduces a new NCM tx engine, able to operate in standard- > and huawei-style mode. > In the first case, the NDP is disposed after the initial headers and > before any datagram. > > What works: > - is able to communicate with co

Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

2015-06-25 Thread Oliver Neukum
On Tue, 2015-06-23 at 00:32 +0200, Enrico Mioso wrote: > +/* XXX rewrite, not multipacket */ Can you explain what you want to do here? > +struct sk_buff * > +huawei_ncm_tx_fixup(struct usbnet *dev, struct sk_buff *skb_in, gfp_t flags) > { > + struct huawei_cdc_ncm_state *drvstate = (void *)&

[PATCH net-next v2] enic: use atomic_t instead of spin_lock in busy poll

2015-06-25 Thread Govindarajulu Varadarajan
We use spinlock to access a single flag. We can avoid spin_locks by using atomic variable and atomic_cmpxchg(). Use atomic_cmpxchg to set the flag for idle to poll. And a simple atomic_set to unlock (set idle from poll). In napi poll, if gro is enabled, we call napi_gro_receive() to deliver the pa

[net-next PATCH 1/1] net: sched: flower fix typo

2015-06-25 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Fix typo in the validation rules for flower's attributes Signed-off-by: Jamal Hadi Salim --- net/sched/cls_flower.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index b92d3f4..9d37ccd 100644 --

netdev broken?

2015-06-25 Thread Jamal Hadi Salim
Trying to catchup with email and i am noticing my last received email was on the 21st. Anyone else having problems (feel like i am asking the question "if you cant hear me please raise your hand" ;->). cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: netdev broken?

2015-06-25 Thread Phil Sutter
On Thu, Jun 25, 2015 at 07:12:07AM -0400, Jamal Hadi Salim wrote: > Trying to catchup with email and i am noticing my last > received email was on the 21st. Anyone else having problems > (feel like i am asking the question "if you cant hear me > please raise your hand" ;->). I received your mail.

[EDT] [PATCH] ax88179_178a: add reset function in reset_resume

2015-06-25 Thread Vivek Kumar Bhagat
EP-EC562D6B53594479BCA6FC73F17DEE54 Hello David, without reset functionality in reset_resume, iperf connection does not establish after suspend/resume however ping works at the same time. reset function inside reset_resume solves above bug. We have verified it on ASIX based ST Lab, Cadyce dongle

Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

2015-06-25 Thread Enrico Mioso
Hi Oliver. Thank you for your patience, and review. I apreciated it very much. On Thu, 25 Jun 2015, Oliver Neukum wrote: Date: Thu, 25 Jun 2015 11:49:29 From: Oliver Neukum To: Enrico Mioso Cc: linux-...@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH RFC] 2/2 huawei_cdc_ncm: intr

Re: netdev broken?

2015-06-25 Thread David Miller
From: Jamal Hadi Salim Date: Thu, 25 Jun 2015 07:12:07 -0400 > Trying to catchup with email and i am noticing my last > received email was on the 21st. Anyone else having problems > (feel like i am asking the question "if you cant hear me > please raise your hand" ;->). I'm pretty sure you're ju

Re: [EDT] [PATCH] ax88179_178a: add reset function in reset_resume

2015-06-25 Thread David Miller
From: Vivek Kumar Bhagat Date: Thu, 25 Jun 2015 11:23:10 + (GMT) > As my email client is giving problem of converting tabs into spaces, > Please find patch attached herewith. Sorry, this is not acceptable. Please read Documentation/email-clients.txt for how to properly setup your email clie

Re: [PATCH net-next v2] enic: use atomic_t instead of spin_lock in busy poll

2015-06-25 Thread David Miller
From: Govindarajulu Varadarajan <_gov...@gmx.com> Date: Thu, 25 Jun 2015 16:02:04 +0530 > We use spinlock to access a single flag. We can avoid spin_locks by using > atomic variable and atomic_cmpxchg(). Use atomic_cmpxchg to set the flag > for idle to poll. And a simple atomic_set to unlock (set

Re: [net-next PATCH 1/1] net: sched: flower fix typo

2015-06-25 Thread David Miller
From: Jamal Hadi Salim Date: Thu, 25 Jun 2015 06:55:27 -0400 > From: Jamal Hadi Salim > > Fix typo in the validation rules for flower's attributes > > Signed-off-by: Jamal Hadi Salim Oops, good catch, applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

[PATCH net 4/9] bnx2x: Don't notify about scratchpad parities

2015-06-25 Thread Yuval Mintz
From: Manish Chopra The scratchpad is a shared block between all functions of a given device. Due to HW limitations, we can't properly close its parity notifications to all functions on legal flows. E.g., it's possible that while taking a register dump from one function a parity error would be tr

[PATCH net 2/9] bnx2x: Correct speed from baseT into KR.

2015-06-25 Thread Yuval Mintz
ethtool shows KR supported/advertised speeds incorrectly as baseT in cases the board is in fact KR-base. Signed-off-by: Yaniv Rosner Signed-off-by: Yuval Mintz --- .../net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c| 55 -- drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c

[PATCH net 1/9] bnx2x: Correct asymmetric flow-control

2015-06-25 Thread Yuval Mintz
This fixes several issues relating to asymmetric configuration: 1. When user requests to disable TX, the local-device needs to advertise both PAUSE and ASM_DIR, but to avoid transmitting pause frames. In the 578xx, it would ignore the TX disable. 2. When user advertises RX-only, ASM_DIR

[PATCH net 0/9] bnx2x: various fixes

2015-06-25 Thread Yuval Mintz
This patch series contains several small fixes [with the possible exception of the first 2 link fixes] for various driver flows. Dave, Sorry for the backlog - looks like at least some of these could have been sent some time ago on shorter series. Please consider applying this series to `net'. Th

[PATCH net 3/9] bnx2x: Prevent false warning when accessing MACs

2015-06-25 Thread Yuval Mintz
Each time a flow finishes reads from the classification shadow configuration in the driver, that flow would check for pending commands and pass them to FW if possible. In case there's already a completion pending command, I.e., a ramrod that has been sent to the FW and is yet to be completed while

[PATCH net 9/9] bnx2x: Fix linearization for encapsulated packets

2015-06-25 Thread Yuval Mintz
Due to FW constraints, driver must make sure that transmitted SKBs will not be too fragmented, or in the case that they are - that each 'window' of fragments passed to the FW would contain at least an mss worth of data. For encapsultaed packets the calculation is wrong, since it ignores the inner

[PATCH net 5/9] bnx2x: Fix VF MAC removal

2015-06-25 Thread Yuval Mintz
From: Shahed Shaikh There's a bug in today's driver where VF requests to add/remove MAC filters always reach the Hypervisor as add requests. This prevents the VF from changing its MAC address, as it cannot remove the previously configured MAC and runs out of MAC credits. Signed-off-by: Shahed Sh

[PATCH net 6/9] bnx2x: Fix self-test for 20g devices

2015-06-25 Thread Yuval Mintz
20g-capable devices are not configured properly for self-test, using 10g as their speed which cause the link indication to remain down and fail the internal loopback test. Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 12 ---

[PATCH net 8/9] bnx2x: Release nvram lock on error flow

2015-06-25 Thread Yuval Mintz
During an error flow when trying to access the nvram the driver doesn't release the hw lock it acquired. Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadco

[PATCH net 7/9] bnx2x: Fix statistics gathering on link change

2015-06-25 Thread Yuval Mintz
From: Ariel Elior Since driver statistics flow access MACs and those might reset during link re-configurations, when we're about to change link properties we have to make sure that statistics are not operational. Statisics would be re-enabled [i.e., gathering of statistics would re-commence] once

[EDT][PATCH] ax88179_178a: add reset function in reset_resume

2015-06-25 Thread Vivek Kumar Bhagat
EP-EC562D6B53594479BCA6FC73F17DEE54 Without reset functionality in reset_resume, iperf connection does not establish after suspend/resume however ping works at the same time. reset function inside reset_resume solves above bug. We have verified it on ASIX based ST Lab, Cadyce dongle. Signed-off-b

Re: [PATCH iproute2 resend] Fix changing tunnel remote and local address to any

2015-06-25 Thread Stephen Hemminger
On Mon, 08 Jun 2015 10:51:51 +0200 Nicolas Dichtel wrote: > Le 04/06/2015 14:01, Thadeu Lima de Souza Cascardo a écrit : > > If a tunnel is created with a local address, you can't change it to any. > > > > # ip tunnel add tunl1 mode ipip remote 10.16.42.37 local 10.16.42.214 ttl > > 64 > > #

Re: [PATCH iproute2] mroute: "ip mroute show" not working when "to" and/or "from" is given

2015-06-25 Thread Stephen Hemminger
On Thu, 11 Jun 2015 21:37:36 +0530 Mazhar Rana wrote: > The command "ip mroute show" is not showing routes when "to" and/or "from" > filter is applied. > > root@mazhar:~# ip mroute show > (10.202.30.101, 235.1.2.3) Iif: eth0 Oifs: eth1 > > But When I applied filter, it does not show

Re: [PATCH 1/2] iproute2: tc/m_pedit.c - remove dead code

2015-06-25 Thread Stephen Hemminger
On Thu, 25 Jun 2015 02:03:02 -0700 Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > The initializers are simply not needed. > > These if-blocks are outright dead code, because '0 > unsigned' is always > false, so only else clause triggers and regardless of which clause triggers > it

Re: [Q] sk->sk_protinfo leftovers

2015-06-25 Thread David Miller
From: Denis Kirjanov Date: Wed, 17 Jun 2015 14:58:15 +0300 > I've found the old thread about removing sk_protinfo member [0]. Back > in 2005 Ralf mentioned that the ax25 case is more complicated. Have > the things changed in the ax25 code since that time? It's trivial 15 minute hack to remove,

[PATCH 0/2] Get rid of sock->sk_protinfo.

2015-06-25 Thread David Miller
These two patches get rid of the last remaining user of sk_protinfo (ax25) and then really gets rid of the struct member. Signed-off-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH 1/2] ax25: Stop using sock->sk_protinfo.

2015-06-25 Thread David Miller
Just make a ax25_sock structure that provides the ax25_cb pointer. Signed-off-by: David S. Miller --- include/net/ax25.h | 16 +++- net/ax25/af_ax25.c | 30 +++--- net/ax25/ax25_in.c |2 +- 3 files changed, 31 insertions(+), 17 deletions(-) diff --gi

[PATCH 2/2] net: Kill sock->sk_protinfo

2015-06-25 Thread David Miller
No more users, so it can now be removed. Signed-off-by: David S. Miller --- include/net/sock.h |2 -- net/core/sock.c|1 - net/sctp/socket.c |6 -- 3 files changed, 9 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index 14d539c..05a8c1a 100644 --- a/incl

[PATCH] flow_dissector: Pre-initialize ip_proto in __skb_flow_dissect()

2015-06-25 Thread Geert Uytterhoeven
net/core/flow_dissector.c: In function ‘__skb_flow_dissect’: net/core/flow_dissector.c:132: warning: ‘ip_proto’ may be used uninitialized in this function Signed-off-by: Geert Uytterhoeven --- This may be a false positive, but the state machine in __skb_flow_dissect() is a bit hard to follow. As

[PATCH] drivers: net: xgene: Pre-initialize ret in xgene_enet_get_resources()

2015-06-25 Thread Geert Uytterhoeven
If CONFIG_ACPI=n: drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function ‘xgene_enet_get_resources’: drivers/net/ethernet/apm/xgene/xgene_enet_main.c:951: warning: ‘ret’ may be used uninitialized in this function If the driver is bound to a legacy platform device, ret will contai

Re: [PATCH net 0/9] bnx2x: various fixes

2015-06-25 Thread David Miller
From: Yuval Mintz Date: Thu, 25 Jun 2015 15:19:20 +0300 > This patch series contains several small fixes [with the possible > exception of the first 2 link fixes] for various driver flows. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell, armada-xp-neta"

2015-06-25 Thread Jason Cooper
On Thu, Jun 25, 2015 at 11:13:23AM +0200, Simon Guinot wrote: > On Fri, Jun 19, 2015 at 02:32:53PM +0200, Simon Guinot wrote: > > On Wed, Jun 17, 2015 at 05:01:12PM +, Jason Cooper wrote: > > > On Wed, Jun 17, 2015 at 05:15:28PM +0200, Gregory CLEMENT wrote: > > > > On 17/06/2015 17:12, Gregory

Re: netdev broken?

2015-06-25 Thread Jamal Hadi Salim
On 06/25/15 08:03, David Miller wrote: I'm pretty sure you're just not subscribed to the list. I never unsubscribed. Ive resubscribed. cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] flow_dissector: Pre-initialize ip_proto in __skb_flow_dissect()

2015-06-25 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 25 Jun 2015 15:10:32 +0200 > net/core/flow_dissector.c: In function ‘__skb_flow_dissect’: > net/core/flow_dissector.c:132: warning: ‘ip_proto’ may be used uninitialized > in this function > > Signed-off-by: Geert Uytterhoeven > --- > This may be a false posi

Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

2015-06-25 Thread Oliver Neukum
On Thu, 2015-06-25 at 13:44 +0200, Enrico Mioso wrote: > On Thu, 25 Jun 2015, Oliver Neukum wrote: > > Is there any advantage in keeping this in a single function? > > > I did this choice in the light of the fact I think the tx_fixup function will > become more complex than it is now, when aggre

Re: [PATCH net 6/9] bnx2x: Fix self-test for 20g devices

2015-06-25 Thread Sergei Shtylyov
Hello. On 06/25/2015 03:19 PM, Yuval Mintz wrote: 20g-capable devices are not configured properly for self-test, using 10g as their speed which cause the link indication to remain down and fail the internal loopback test. Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior --- drivers/

Re: [PATCH] flow_dissector: Pre-initialize ip_proto in __skb_flow_dissect()

2015-06-25 Thread Jiri Pirko
Thu, Jun 25, 2015 at 03:33:31PM CEST, da...@davemloft.net wrote: >From: Geert Uytterhoeven >Date: Thu, 25 Jun 2015 15:10:32 +0200 > >> net/core/flow_dissector.c: In function ‘__skb_flow_dissect’: >> net/core/flow_dissector.c:132: warning: ‘ip_proto’ may be used uninitialized >> in this function >

[PATCH net] dsa: fix promiscuity leak on slave dev open error

2015-06-25 Thread Gilad Ben-Yossef
DSA master netdev promiscuity counter was not being properly decremented on slave device open error path. Signed-off-by: Gilad Ben-Yossef CC: Gilad Ben-Yossef CC: David S. Miller CC: Florian Fainelli CC: Guenter Roeck CC: Andrew Lunn CC: Scott Feldman --- net/dsa/slave.c |2 +- 1 files

[PATCH net] dsa: fix promiscuity leak on slave dev open error

2015-06-25 Thread giladb
From: Gilad Ben-Yossef DSA master netdev promiscuity counter was not being properly decremented on slave device open error path. Signed-off-by: Gilad Ben-Yossef CC: Gilad Ben-Yossef CC: David S. Miller CC: Florian Fainelli CC: Guenter Roeck CC: Andrew Lunn CC: Scott Feldman --- net/dsa/s

Re: Performance loss due to commit 37c3185 ([NET]: Added GSO toggle)

2015-06-25 Thread Herbert Xu
On Sat, Jun 20, 2015 at 11:55:03AM +0200, christophe leroy wrote: > Hello Herbert, > > In commit "[NET]: Added GSO toggle" > 37c3185a02d4b85fbe134bf5204535405dd2c957, > you force NETIF_F_HW_CSUM if GSO feature is selected. > By default, SW GSO is active as soon as a network board has NETIF_F_SG >

RESEND: Performance loss due to commit 37c3185 ([NET]: Added GSO toggle)

2015-06-25 Thread leroy christophe
Hello Herbert, In commit "[NET]: Added GSO toggle" 37c3185a02d4b85fbe134bf5204535405dd2c957, you force NETIF_F_HW_CSUM if GSO feature is selected. By default, SW GSO is active as soon as a network board has NETIF_F_SG feature. This means that function sk_setup_caps() forces NETIF_F_HW_CSUM for

Re: [GIT] Networking

2015-06-25 Thread Or Gerlitz
On Thu, Jun 25, 2015 at 2:38 AM, Linus Torvalds wrote: > > On Wed, Jun 24, 2015 at 6:39 AM, David Miller wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master > > Just going through the conflicts, I see commit 7193a141eb74 ("IB/mlx4: > Set VF to read from QP cou

Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

2015-06-25 Thread Enrico Mioso
Hi Oliver! And thank you again. I like / recommend the usage of open messaging standards: my preferred XMPP ID (JID) is: mrk...@jit.si. On Thu, 25 Jun 2015, Oliver Neukum wrote: Date: Thu, 25 Jun 2015 15:38:46 From: Oliver Neukum To: Enrico Mioso Cc: linux-...@vger.kernel.org, netdev@vger.ke

Re: [PATCH] flow_dissector: Pre-initialize ip_proto in __skb_flow_dissect()

2015-06-25 Thread Tom Herbert
On Thu, Jun 25, 2015 at 6:10 AM, Geert Uytterhoeven wrote: > net/core/flow_dissector.c: In function ‘__skb_flow_dissect’: > net/core/flow_dissector.c:132: warning: ‘ip_proto’ may be used uninitialized > in this function > > Signed-off-by: Geert Uytterhoeven > --- > This may be a false positive,

Re: [GIT] Networking

2015-06-25 Thread Paul Gortmaker
On Wed, Jun 24, 2015 at 7:38 PM, Linus Torvalds wrote: [...] > > I'm getting *real* tired of that BUG_ON() shit. I realize that > infiniband is a niche market, and those "commercial grade" niche > markets are more-than-used-to crap code and horrible hacks, but this > is still the kernel. We don'

[net PATCH 1/1] net: phy: fix phy link up when limiting speed via device tree

2015-06-25 Thread Mugunthan V N
When limiting phy link speed using "max-speed" to 100mbps or less on a giga bit phy, phy never completes auto negotiation and phy state machine is held in PHY_AN. Fixing this issue by comparing the giga bit advertise though phydev->supported doesn't have it but phy has BMSR_ESTATEN set. So that aut

Re: [GIT] Networking

2015-06-25 Thread Joe Perches
On Thu, 2015-06-25 at 12:24 -0400, Paul Gortmaker wrote: > On Wed, Jun 24, 2015 at 7:38 PM, Linus Torvalds > wrote: > > I'm getting *real* tired of that BUG_ON() shit. [] > > Killing the machine for idiotic things like that is truly offensive, > > and truly horrible horrible code. Why do I keep o

Re: [PATCH RFC] vhost: add ioctl to query nregions upper limit

2015-06-25 Thread Igor Mammedov
On Wed, 24 Jun 2015 17:08:56 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jun 24, 2015 at 04:52:29PM +0200, Igor Mammedov wrote: > > On Wed, 24 Jun 2015 16:17:46 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jun 24, 2015 at 04:07:27PM +0200, Igor Mammedov wrote: > > > > On Wed, 24 Jun

Re: [net PATCH 1/1] net: phy: fix phy link up when limiting speed via device tree

2015-06-25 Thread Florian Fainelli
2015-06-25 9:51 GMT-07:00 Mugunthan V N : > When limiting phy link speed using "max-speed" to 100mbps or less on a > giga bit phy, phy never completes auto negotiation and phy state > machine is held in PHY_AN. Fixing this issue by comparing the giga > bit advertise though phydev->supported doesn't

Re: [net PATCH 1/1] net: phy: fix phy link up when limiting speed via device tree

2015-06-25 Thread Mugunthan V N
On Thursday 25 June 2015 11:01 PM, Florian Fainelli wrote: > 2015-06-25 9:51 GMT-07:00 Mugunthan V N : >> > When limiting phy link speed using "max-speed" to 100mbps or less on a >> > giga bit phy, phy never completes auto negotiation and phy state >> > machine is held in PHY_AN. Fixing this issue

net-next headers break user source compatiablity

2015-06-25 Thread Stephen Hemminger
Current net-next headers break build of iproute2. Looks like in.h needs the same libc-compat.h dance as was done in in6.h $ gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wformat=2 -O2 -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -D

RE: netdev broken?

2015-06-25 Thread Lukas Tribus
> On 06/25/15 08:03, David Miller wrote: > >> >> I'm pretty sure you're just not subscribed to the list. >> > > I never unsubscribed. Ive resubscribed. Same thing happened to me at least 3 times in the last 4 - 5 years. Suddenly it appears I'm unsubscribed. I have no idea how that happens or why.

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-25 Thread Paul Bolle
(Evolution 3.16 is basically unbearable for replying to patches. Anyone else running into this?) On Wed, 2015-06-24 at 22:37 +0300, igal.liber...@freescale.com wrote: > > --- /dev/null > +++ b/drivers/net/ethernet/freescale/fman/mac/mac-api.c > +int set_mac_active_pause(struct mac_device *mac_de

Re: [v2,8/9] fsl/fman: Add FMan Port Support

2015-06-25 Thread Paul Bolle
On Wed, 2015-06-24 at 22:37 +0300, igal.liber...@freescale.com wrote: > --- a/drivers/net/ethernet/freescale/fman/fm_drv.c > +++ b/drivers/net/ethernet/freescale/fman/fm_drv.c > +struct fm_port_t *fm_port_drv_handle(const struct fm_port_drv_t *port) > +{ > + return port->fm_port; > +} > +EXPOR

[PATCH] Added additional callback to ptp_clock_info:

2015-06-25 Thread Christopher Hall
* getsynctime64() This takes 2 arguments referring to system and device time With this callback drivers may provide both system time and device time to ensure precise correlation Modified PTP_SYS_OFFSET ioctl in PTP clock driver to use the above callback if it's available Signed-off-by: Christo

[PATCH] Add PTP cross-timestamp to the PTP driver interface

2015-06-25 Thread Christopher Hall
This patch allows system and device time ("cross-timestamp") to be performed by the driver. Currently, the timestamping is performed in the PTP_SYS_OFFSET ioctl. It reads gettimeofday() and the gettime64() callback provided by the driver. The cross-timestamp is best effort ignoring the latency

Re: [v2,5/9] fsl/fman: Add Frame Manager support

2015-06-25 Thread Paul Bolle
On Wed, 2015-06-24 at 22:35 +0300, igal.liber...@freescale.com wrote: > --- /dev/null > +++ b/drivers/net/ethernet/freescale/fman/fm_drv.c > +u16 fm_get_max_frm(void) > +{ > + return fsl_fm_max_frm; > +} > +EXPORT_SYMBOL(fm_get_max_frm); Which module is using this export? (And what does this

[PATCH] - vxlan: gro not effective for intel 82599

2015-06-25 Thread Ramu Ramamurthy
Problem: --- GRO is enabled on the interfaces in the following test, but GRO does not take effect for vxlan-encapsulated tcp streams. The root cause of why GRO does not take effect is described below. VM nic (mtu 1450)---bridge---vxlan10Gb nic (intel 82599ES)-| VM nic (mtu 1450)---

Re: [v2,5/9] fsl/fman: Add Frame Manager support

2015-06-25 Thread Paul Bolle
On Fri, 2015-06-26 at 01:53 +0200, Paul Bolle wrote: > So I decided to pick one subject: exports. I think I had something to > comment on all eight of them. s/eight/twelve/ Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.

Re: [PATCH] - vxlan: gro not effective for intel 82599

2015-06-25 Thread Tom Herbert
On Thu, Jun 25, 2015 at 5:03 PM, Ramu Ramamurthy wrote: > Problem: > --- > > GRO is enabled on the interfaces in the following test, > but GRO does not take effect for vxlan-encapsulated tcp streams. The root > cause of why GRO does not take effect is described below. > > VM nic (mtu 1450)---b

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-25 Thread Scott Wood
On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: > (Evolution 3.16 is basically unbearable for replying to patches. > Anyone > else running into this?) If you mean the crazy lag when selecting moderate-to-large amounts of text (for snipping), yes. -Scott -- To unsubscribe from this list:

Re: [PATCH] - vxlan: gro not effective for intel 82599

2015-06-25 Thread Ramu Ramamurthy
On 2015-06-25 17:20, Tom Herbert wrote: On Thu, Jun 25, 2015 at 5:03 PM, Ramu Ramamurthy wrote: Problem: --- GRO is enabled on the interfaces in the following test, but GRO does not take effect for vxlan-encapsulated tcp streams. The root cause of why GRO does not take effect is describe

Re: Issue with LACP mode support in Linux bonding driver

2015-06-25 Thread Ajith Adapa
Hi, How can I know the current maintainer for Linux Bonding Driver ? Regards, Ajith Regards, Ajith codingfreak.blogspot.com On 24 June 2015 at 15:25, Ajith Adapa wrote: > Hi, > > I am using Centos7 with v3.10 kernel. > > My issue is related to mult

Re: [v2,1/9] fsl/fman: Add the FMan FLIB

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:33 +0300, igal.liber...@freescale.com wrote: > From: Igal Liberman > > The FMan FLib provides the basic API used by the FMan drivers to > > configure and control the FMan hardware. > > Signed-off-by: Igal Liberman Again, what is an FLib? What determines whether conten

Re: [v2,3/9] fsl/fman: Add the FMan MAC FLIB

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:34 +0300, igal.liber...@freescale.com wrote: > From: Igal Liberman > > The FMan MAC FLib provides basic API used by the drivers to > configure and control the FMan MAC hardware. > > Signed-off-by: Igal Liberman ... > > +int fman_dtsec_mii_write_reg(struct dtsec_mii_reg

Re: [v2,4/9] fsl/fman: Add FMan MURAM support

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:34 +0300, igal.liber...@freescale.com wrote: > + struct muram_info *p_muram; No Hungarian notation. > +void fm_muram_free(struct muram_info *p_muram) > +{ > + /* Destroy pool */ > + gen_pool_destroy(p_muram->pool); > + /* Unmap memory */ > + iounmap(p_

Re: Issue with LACP mode in linux bonding driver

2015-06-25 Thread Jay Vosburgh
Ajith Adapa wrote: >Hi, > >Sorry for direct mail. Since the question is more specific about >supporting LACP standard I decided to communicate directly with the >MAINTAINERS. My issue is related to multiaggregation support in LACP. I saw your message this morning, but didn't have an oppo

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-25 Thread Michael Ellerman
On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: > On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: > > (Evolution 3.16 is basically unbearable for replying to patches. > > Anyone > > else running into this?) > > If you mean the crazy lag when selecting moderate-to-large amounts of > te

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-25 Thread Scott Wood
On Fri, 2015-06-26 at 12:21 +1000, Michael Ellerman wrote: > On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: > > On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: > > > (Evolution 3.16 is basically unbearable for replying to patches. > > > Anyone > > > else running into this?) > > > > If

Re: [PATCH] - vxlan: gro not effective for intel 82599

2015-06-25 Thread Tom Herbert
On Thu, Jun 25, 2015 at 6:06 PM, Ramu Ramamurthy wrote: > On 2015-06-25 17:20, Tom Herbert wrote: >> >> On Thu, Jun 25, 2015 at 5:03 PM, Ramu Ramamurthy >> wrote: >>> >>> Problem: >>> --- >>> >>> GRO is enabled on the interfaces in the following test, >>> but GRO does not take effect for vxla

Re: [net PATCH 1/1] net: phy: fix phy link up when limiting speed via device tree

2015-06-25 Thread Florian Fainelli
Le 06/25/15 09:51, Mugunthan V N a écrit : > When limiting phy link speed using "max-speed" to 100mbps or less on a > giga bit phy, phy never completes auto negotiation and phy state > machine is held in PHY_AN. Fixing this issue by comparing the giga > bit advertise though phydev->supported doesn'

Re: Issue with LACP mode support in Linux bonding driver

2015-06-25 Thread Mahesh Bandewar
On Wed, Jun 24, 2015 at 2:55 AM, Ajith Adapa wrote: > Hi, > > I am using Centos7 with v3.10 kernel. > You are using a very old kernel. Have you tried it with the latest kernel? > My issue is related to multiaggregation in LACP. > > In my setup topology I connected linux server and a L2 switch bac

[PATCH net] uapi: fix compatability of linux/in.h with netinet/in.h

2015-06-25 Thread Stephen Hemminger
This fixes breakage to iproute2 build with recent kernel headers caused by: commit a263653ed798216c0069922d7b5237ca49436007 Author: Pablo Neira Ayuso Date: Wed Jun 17 10:28:27 2015 -0500 netfilter: don't pull include/linux/netfilter.h from netns headers The issue is that definition

Re: [PATCH iproute2] ss: add support for segs_in and segs_out

2015-06-25 Thread Stephen Hemminger
On Tue, 26 May 2015 14:54:41 -0400 Craig Gallek wrote: > Two new tcp_info fields: tcpi_segs_in and tcpi_segs_out. > (2efd055c53c06b7e89c167c98069bab9afce7e59) > > ~: ss -ti src :22 >cubic wscale:7,6 rto:201 rtt:0.244/0.012 ato:40 mss:1418 cwnd:21 > bytes_acked:80605 bytes_received:20491

Re: [v2,5/9] fsl/fman: Add Frame Manager support

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:35 +0300, igal.liber...@freescale.com wrote: > From: Igal Liberman > > Add Frame Manger Driver support. > This patch adds The FMan configuration, initialization and > runtime control routines. > > Signed-off-by: Igal Liberman > --- > drivers/net/ethernet/freescale/fman

Re: [PATCH iproute2] Add displaying VF traffic statistics

2015-06-25 Thread Stephen Hemminger
On Tue, 16 Jun 2015 12:13:16 +0300 Or Gerlitz wrote: > From: Eran Ben Elisha > > Enable reading and displaying SRIOV VFs traffic statistics through > the host PF netdevice using the nested IFLA_VF_STATS attribute. > > Signed-off-by: Eran Ben Elisha > Signed-off-by: Hadar Hen Zion > Signed-o

Re: [PATCH iproute2 net-next 0/3] iplink_bridge: add support for ageing_time, priority and stp_state

2015-06-25 Thread Stephen Hemminger
On Tue, 16 Jun 2015 13:38:46 +0300 Nikolay Aleksandrov wrote: > Hi, > Three months ago support was added to be able to set ageing_time, > priority and stp_state via netlink by commit: > af615762e972 ("bridge: add ageing_time, stp_state, priority over netlink") > This patch-set adds support for ip

Re: [PATCH iproute2] ss: print value of IPV6_V6ONLY socket option if set

2015-06-25 Thread Stephen Hemminger
On Wed, 24 Jun 2015 11:07:20 + Phil Sutter wrote: > If available and set, print 'v6only:1' for AF_INET6 sockets upon request > of extended information. For IPv6 sockets bound to in6addr_any, this is > the only way to determine if they will also accept IPv4 requests or not. > > Signed-off-by:

Re: [PATCH net-next 3/3 v7] iproute2: add support to print 'linkdown' nexthop flag

2015-06-25 Thread Stephen Hemminger
On Tue, 23 Jun 2015 13:45:38 -0400 Andy Gospodarek wrote: > Signed-off-by: Andy Gospodaerk > Signed-off-by: Dinesh Dutt > Acked-by: Scott Feldman Applied, currently sitting on local net-next branch until after merge. } -- To unsubscribe from this list: send the line "unsubscribe ne

Re: [PATCH iproute2 v2] ss: Include -E option for socket destroy events

2015-06-25 Thread Stephen Hemminger
On Wed, 17 Jun 2015 11:14:48 -0400 Craig Gallek wrote: > Use the IPv4/IPv6/TCP/UDP multicast groups of NETLINK_SOCK_DIAG > to filter and display socket statistics as they are destroyed. > > Kernel support patch series: 24029a3603cfa633e8bc2b3fb3e48e76c497831d > > Signed-off-by: Craig Gallek A

4.1+ use after free in netlink_broadcast_filtered

2015-06-25 Thread Dave Jones
I taught Trinity about NETLINK_LISTEN_ALL_NSID and NETLINK_LIST_MEMBERSHIPS yesterday, and this evening, this fell out.. general protection fault: [#1] PREEMPT SMP DEBUG_PAGEALLOC CPU: 1 PID: 9130 Comm: kworker/1:1 Not tainted 4.1.0-gelk-debug+ #1 Workqueue: sock_diag_events sock_diag_broadc

  1   2   >