Re: [PATCH] net: macb: Add SG support for Zynq SOC family

2015-07-06 Thread Nicolas Ferre
Le 06/07/2015 06:32, Punnaiah Choudary Kalluri a écrit : Enable SG support for Zynq SOC family devices. Signed-off-by: Punnaiah Choudary Kalluri punn...@xilinx.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/net/ethernet/cadence/macb.c |6 ++ 1 files changed, 2

BUG: unable to handle kernel NULL pointer in __netdev_pick_tx()

2015-07-06 Thread Bob Liu
Hi, I tried to run the latest kernel v4.2-rc1, but often got below panic during system boot. [ 42.118983] BUG: unable to handle kernel paging request at 003f [ 42.119008] IP: [8161cfd0] __netdev_pick_tx+0x70/0x120 [ 42.119023] PGD 0 [ 42.119026] Oops: [#1]

Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Bob Liu
On 07/04/2015 02:01 AM, Julien Grall wrote: The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd netfilter: bridge: forward IPv6 fragmented packets introduced a new function br_validate_ipv6 which take a reference on the inet6 device. Although, the reference is not released at the end. This

Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Eric Dumazet
On Mon, 2015-07-06 at 11:35 +0100, Julien Grall wrote: __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on this code is very limited. Are we sure that one this lock is hold? At first glance, I wasn't able to find one. You could play it safe ;) diff --git

Re: BUG: unable to handle kernel NULL pointer in __netdev_pick_tx()

2015-07-06 Thread Bob Liu
On 07/06/2015 06:41 PM, Eric Dumazet wrote: On Mon, 2015-07-06 at 16:26 +0800, Bob Liu wrote: Hi, I tried to run the latest kernel v4.2-rc1, but often got below panic during system boot. [ 42.118983] BUG: unable to handle kernel paging request at 003f [ 42.119008] IP:

Re: [PATCH V2] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-06 Thread Oliver Neukum
On Sun, 2015-07-05 at 12:21 +0200, Enrico Mioso wrote: When sending lots of small packets, this patch will generate an Unable to handle kernel paging request in the memset call: ndp16 = memset(ctx-delayed_ndp16, 0, ctx-max_ndp_size); And I don't know why. Any comment or suggestion would be

Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Julien Grall
Hi, On 03/07/15 21:42, Florian Westphal wrote: Julien Grall julien.gr...@citrix.com wrote: The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd netfilter: bridge: forward IPv6 fragmented packets introduced a new function br_validate_ipv6 which take a reference on the inet6 device. Although,

Re: BUG: unable to handle kernel NULL pointer in __netdev_pick_tx()

2015-07-06 Thread Eric Dumazet
On Mon, 2015-07-06 at 16:26 +0800, Bob Liu wrote: Hi, I tried to run the latest kernel v4.2-rc1, but often got below panic during system boot. [ 42.118983] BUG: unable to handle kernel paging request at 003f [ 42.119008] IP: [8161cfd0] __netdev_pick_tx+0x70/0x120

Re: [PATCH v2] add stealth mode

2015-07-06 Thread Valdis . Kletnieks
On Thu, 02 Jul 2015 10:56:01 +0200, Matteo Croce said: Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Port-Unreachable for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single

[PATCH net-next] drivers: net: xgene: Fix the compilation error error: implicit declaration of function 'acpi_evaluate_integer' for CONFIG_ACPI=n.

2015-07-06 Thread Suman Tripathi
This patch guards the acpi_evaluate_interger function as it fails the build for CONFIG_ACPI=n. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com Reported-by: kbuild test robot fengguang...@intel.com ---

[PATCH] ip_tunnel: fix ipv4 pmtu check to honor inner ip header df

2015-07-06 Thread Timo Teräs
Frag needed should be sent only if the inner header asked to not fragment. Currently fragmentation is broken if the tunnel has df set. The tunnel's df needs to be still checked to update internally the pmtu cache. This got broken in commit 23a3647bc4f93bac and this fixes the pmtu check back to

RE: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-06 Thread David Laight
From: Eric Dumazet [mailto:eric.duma...@gmail.com] Sent: 03 July 2015 17:39 On Fri, 2015-07-03 at 16:18 +, David Laight wrote: Even on x86 aligning the ethernet receive data on a 4n+2 boundary is likely to give marginally better performance than aligning on a 4n boundary. You are

Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Florian Westphal
Julien Grall julien.gr...@citrix.com wrote: On 03/07/15 21:42, Florian Westphal wrote: I think it makes more sense to use __in6_dev_get() instead which doesn't take a reference. __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on this code is very limited. Are we sure

Re: [PATCH V2] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-06 Thread Enrico Mioso
Just to be clear - this happens on the real machine as well, but here the trace is difficult to extract, because even with the help of someone seeing the screen, I noticed the screen doesn't get updated. I am using vesa right now. -- To unsubscribe from this list: send the line unsubscribe

[PATCH] rhashtable: fix for resize events during table walk

2015-07-06 Thread Phil Sutter
If rhashtable_walk_next detects a resize operation in progress, it jumps to the new table and continues walking that one. But it misses to drop the reference to it's current item, leading it to continue traversing the new table's bucket in which the current item is sorted into, and after reaching

[PATCH net-next] cxgb4: Add PCI device ids for few more T5 and T6 adapters

2015-07-06 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h index

Re: [PATCH v2] bonding: primary_reselect with failure is not working properly

2015-07-06 Thread GMAIL
On Friday 03 July 2015 11:46 PM, Jay Vosburgh wrote: GMAIL ranamazh...@gmail.com wrote: Hi Jay, On Friday 03 July 2015 02:12 AM, Jay Vosburgh wrote: [ added netdev to cc ] Mazhar Rana ranamazh...@gmail.com wrote: When primary_reselect is set to failure, primary interface should

Re: [PATCH v2 net-next 0/7] net_sched: act: lockless operation

2015-07-06 Thread Jamal Hadi Salim
On 07/06/15 02:41, Eric Dumazet wrote: As mentioned by Alexei last week in Budapest, it is a bit weird to take a spinlock in order to drop a packet in a tc filter... Lets add percpu infra for tc actions and use it for gact mirred. Before changes, my host with 8 RX queues was handling 5 Mpps

Re: [PATCH v2 net-next 0/7] net_sched: act: lockless operation

2015-07-06 Thread Eric Dumazet
On Mon, Jul 6, 2015 at 2:12 PM, Jamal Hadi Salim j...@mojatatu.com wrote: on mirred: The main thing that is read-write is the stats. lastuse timestamp as well, but that one doesnt have to be accurate (used mainly to help decide when to flush out policies). so the lock around all that code is

Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Julien Grall
On 06/07/15 12:19, Florian Westphal wrote: Julien Grall julien.gr...@citrix.com wrote: On 03/07/15 21:42, Florian Westphal wrote: I think it makes more sense to use __in6_dev_get() instead which doesn't take a reference. __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on

Disable executions commands outside net_device_ops structure

2015-07-06 Thread Marian Corcodel
we keep commands only on net_device_ops structure - struct net_device_ops. From 0749e12c21b564d62c89ec35c5fc8f4289a7e4d9 Mon Sep 17 00:00:00 2001 From: Corcodel Marian a...@192-168-0-3.rdsnet.ro Date: Mon, 6 Jul 2015 13:24:59 +0300 Subject: [PATCH] Committer: Corcodel Marian

Re: [PATCH V2] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-06 Thread Enrico Mioso
Sure Oliver! Here it is. And - I tried with various approach. I tired also kzallocating the needed memory inside the tx_fixup function using the GFP_ATOMIC flag due to the fact I am in an interrupt handler. At some point, the problem started manifesting in a memset call that whasn't in my

[PATCH v3 net-next 0/7] net_sched: act: lockless operation

2015-07-06 Thread Eric Dumazet
As mentioned by Alexei last week in Budapest, it is a bit weird to take a spinlock in order to drop a packet in a tc filter... Lets add percpu infra for tc actions and use it for gact mirred. Before changes, my host with 8 RX queues was handling 5 Mpps with gact, and more than 11 Mpps after.

[PATCH v3 net-next 6/7] net_sched: act_gact: remove spinlock in fast path

2015-07-06 Thread Eric Dumazet
Final step for gact RCU operation : 1) Use percpu stats 2) update lastuse only every clock tick to avoid false sharing 3) Remove spinlock acquisition, as it is no longer needed. Since this is the last contended lock in packet RX when tc gact is used, this gives impressive gain. My host with 8

[PATCH v3 net-next 2/7] net: sched: add percpu stats to actions

2015-07-06 Thread Eric Dumazet
Reuse existing percpu infrastructure John Fastabend added for qdisc. This patch adds a new cpustats parameter to tcf_hash_create() and all actions pass false, meaning this patch should have no effect yet. Signed-off-by: Eric Dumazet eduma...@google.com Cc: Alexei Starovoitov a...@plumgrid.com

[PATCH v3 net-next 3/7] net_sched: act_gact: make tcfg_pval non zero

2015-07-06 Thread Eric Dumazet
First step for gact RCU operation : Instead of testing if tcfg_pval is zero or not, just make it 1. No change in behavior, but slightly faster code. The smp_rmb()/smp_wmb() barriers, while not strictly needed at this stage are added for upcoming spinlock removal. Signed-off-by: Eric Dumazet

[PATCH v3 net-next 4/7] net_sched: act_gact: use a separate packet counters for gact_determ()

2015-07-06 Thread Eric Dumazet
Second step for gact RCU operation : We want to get rid of the spinlock protecting gact operations. Stats (packets/bytes) will soon be per cpu. gact_determ() would not work without a central packet counter, so lets add it for this mode. Signed-off-by: Eric Dumazet eduma...@google.com Cc: Alexei

[PATCH v3 net-next 5/7] net_sched: act_gact: read tcfg_ptype once

2015-07-06 Thread Eric Dumazet
Third step for gact RCU operation : Following patch will get rid of spinlock protection, so we need to read tcfg_ptype once. Signed-off-by: Eric Dumazet eduma...@google.com Cc: Alexei Starovoitov a...@plumgrid.com Acked-by: Jamal Hadi Salim j...@mojatatu.com Acked-by: John Fastabend

[PATCH v3 net-next 1/7] net: sched: extend percpu stats helpers

2015-07-06 Thread Eric Dumazet
qdisc_bstats_update_cpu() and other helpers were added to support percpu stats for qdisc. We want to add percpu stats for tc action, so this patch add common helpers. qdisc_bstats_update_cpu() is renamed to qdisc_bstats_cpu_update() qdisc_qstats_drop_cpu() is renamed to qdisc_qstats_cpu_drop()

Re: [PATCH v3 net-next 7/7] net_sched: act_mirred: remove spinlock in fast path

2015-07-06 Thread Jamal Hadi Salim
On 07/06/15 08:18, Eric Dumazet wrote: Like act_gact, act_mirred can be lockless in packet processing 1) Use percpu stats 2) update lastuse only every clock tick to avoid false sharing 3) use rcu to protect tcfm_dev 4) Remove spinlock usage, as it is no longer needed. Next step : add multi

Re: Summary lightweight tunnel discussion at NFWS

2015-07-06 Thread Thomas Graf
On 07/04/15 at 11:21pm, roopa wrote: Thx. I have fixed this since,...did not realize it came in as part of this RFC series. Other than that I managed to rebase my changes onto yours and it looks clean. Glad to know!. thanks Thomas. I had a few more changes (mostly cleanup/bug fixes, ipv6

Re: [PATCH 6/6] net: mvneta: Statically assign queues to CPUs

2015-07-06 Thread Maxime Ripard
On Sun, Jul 05, 2015 at 03:00:11PM +0200, Willy Tarreau wrote: Hi Thomas, On Fri, Jul 03, 2015 at 04:46:24PM +0200, Thomas Petazzoni wrote: Maxime, On Fri, 3 Jul 2015 16:25:51 +0200, Maxime Ripard wrote: +static void mvneta_percpu_enable(void *arg) +{ + struct mvneta_port

[PATCH 2/7] Drivers: hv: vmbus: define a new VMBus message type for hvsock

2015-07-06 Thread Dexuan Cui
A function to send the type of message is also added. The coming net/hvsock driver will use this function to proactively request the host to offer a VMBus channel for a new hvsock connection. Signed-off-by: Dexuan Cui de...@microsoft.com --- drivers/hv/channel.c | 15 +++

[PATCH 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability

2015-07-06 Thread Dexuan Cui
This will be used by the coming net/hvsock driver. Signed-off-by: Dexuan Cui de...@microsoft.com --- drivers/hv/channel.c | 131 ++ drivers/hv/hyperv_vmbus.h | 4 ++ drivers/hv/ring_buffer.c | 14 + include/linux/hyperv.h| 33

[PATCH 4/7] Drivers: hv: vmbus: add APIs to register callbacks to process hvsock connection

2015-07-06 Thread Dexuan Cui
With the 2 APIs supplied by the VMBus driver, the coming net/hvsock driver can register 2 callbacks and can know when a new hvsock connection is offered by the host, and when a hvsock connection is being closed by the host. Signed-off-by: Dexuan Cui de...@microsoft.com --- drivers/hv/Makefile

[PATCH 7/7] Drivers: hv: vmbus: disable local interrupt when hvsock's callback is running

2015-07-06 Thread Dexuan Cui
In the SMP guest case, when the per-channel callback hvsock_events() is running on virtual CPU A, if the guest tries to close the connection on virtual CPU B: we invoke vmbus_close() - vmbus_close_internal(), then we can have trouble: on B, vmbus_close_internal() will send IPI reset_channel_cb()

[PATCH 5/7] Drivers: hv: vmbus: add a helper function to set a channel's pending send size

2015-07-06 Thread Dexuan Cui
This will be used by the coming net/hvsock driver. Signed-off-by: Dexuan Cui de...@microsoft.com --- include/linux/hyperv.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 307910b3..c52f4cb 100644 --- a/include/linux/hyperv.h +++

[PATCH 0/7] introduce Hyper-V VM Sockets(hvsock)

2015-07-06 Thread Dexuan Cui
Hyper-V VM Sockets (hvsock) is a byte-stream based communication mechanism between Windowsd 10 (or later) host and a guest. It's kind of TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V VM Sockets, applications between the host and a guest can talk with

[PATCH 1/7] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock)

2015-07-06 Thread Dexuan Cui
A helper function is also added. Signed-off-by: Dexuan Cui de...@microsoft.com --- include/linux/hyperv.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 30d3a1f..aa21814 100644 --- a/include/linux/hyperv.h +++

[PATCH net] bridge: mdb: start delete timer for temp static entries

2015-07-06 Thread Nikolay Aleksandrov
From: Satish Ashok sas...@cumulusnetworks.com Start the delete timer when adding temp static entries so they can expire. Signed-off-by: Satish Ashok sas...@cumulusnetworks.com Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com Fixes: ccb1c31a7a87 (bridge: add flags to distinguish

Re: [PATCH 4/6] net: mvneta: Handle per-cpu interrupts

2015-07-06 Thread Maxime Ripard
Hi Willy, On Sun, Jul 05, 2015 at 02:37:08PM +0200, Willy Tarreau wrote: Hi Maxime, On Fri, Jul 03, 2015 at 04:25:49PM +0200, Maxime Ripard wrote: Now that our interrupt controller is allowing us to use per-CPU interrupts, actually use it in the mvneta driver. This involves obviously

[PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature

2015-07-06 Thread Dexuan Cui
Hyper-V VM sockets (hvsock) supplies a byte-stream based communication mechanism between the host and a guest. It's kind of TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V VM Sockets, applications between the host and a guest can talk with each other

Re: [PATCH] rhashtable: fix for resize events during table walk

2015-07-06 Thread Herbert Xu
On Mon, Jul 06, 2015 at 02:01:42PM +0200, Phil Sutter wrote: If rhashtable_walk_next detects a resize operation in progress, it jumps to the new table and continues walking that one. But it misses to drop the reference to it's current item, leading it to continue traversing the new table's

[PATCH 0/7] introduce Hyper-V VM Sockets(hvsock)

2015-07-06 Thread Dexuan Cui
Hyper-V VM Sockets (hvsock) is a byte-stream based communication mechanism between Windowsd 10 (or later) host and a guest. It's kind of TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V VM Sockets, applications between the host and a guest can talk with

Re: [RFC patch] sctp: sctp_generate_fwdtsn: Initialize sctp_fwdtsn_skip array, neatening

2015-07-06 Thread Neil Horman
On Fri, Jul 03, 2015 at 09:41:41AM -0700, Joe Perches wrote: On Fri, 2015-07-03 at 07:51 -0400, Neil Horman wrote: On Thu, Jul 02, 2015 at 02:54:56PM -0700, Joe Perches wrote: It's not clear to me that the sctp_fwdtsn_skip array is always initialized when used. It is appropriate to

[PATCH v2] rhashtable: fix for resize events during table walk

2015-07-06 Thread Phil Sutter
If rhashtable_walk_next detects a resize operation in progress, it jumps to the new table and continues walking that one. But it misses to drop the reference to it's current item, leading it to continue traversing the new table's bucket in which the current item is sorted into, and after reaching

Re: [PATCH v2] rhashtable: fix for resize events during table walk

2015-07-06 Thread Herbert Xu
On Mon, Jul 06, 2015 at 03:51:20PM +0200, Phil Sutter wrote: If rhashtable_walk_next detects a resize operation in progress, it jumps to the new table and continues walking that one. But it misses to drop the reference to it's current item, leading it to continue traversing the new table's

Re: [PATCH] rhashtable: fix for resize events during table walk

2015-07-06 Thread Phil Sutter
On Mon, Jul 06, 2015 at 09:30:40PM +0800, Herbert Xu wrote: On Mon, Jul 06, 2015 at 02:01:42PM +0200, Phil Sutter wrote: diff --git a/lib/rhashtable.c b/lib/rhashtable.c index a60a6d3..e36b94b 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c @@ -585,6 +585,7 @@ void

Re: [PATCH] ip_tunnel: fix ipv4 pmtu check to honor inner ip header df

2015-07-06 Thread Pravin Shelar
On Mon, Jul 6, 2015 at 1:35 AM, Timo Teräs timo.te...@iki.fi wrote: Frag needed should be sent only if the inner header asked to not fragment. Currently fragmentation is broken if the tunnel has df set. The tunnel's df needs to be still checked to update internally the pmtu cache. This got

Re: [PATCH v2 1/1] Added additional callback to ptp_clock_info:

2015-07-06 Thread Josh Cartwright
On Thu, Jul 02, 2015 at 06:14:48PM -0700, Christopher Hall wrote: * getsynctime64() Hello Christopher- A couple comments below. This takes 2 arguments referring to system and device time With this callback drivers may provide both system time and device time to ensure precise

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-06 Thread Nicolas Dichtel
Le 06/07/2015 17:03, David Ahern a écrit : This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all local routes pointing to

[PATCH] sctp: Add counters for out data chunk discards

2015-07-06 Thread Vitaly Andrianov
This commit adds a MIB entry for out data chunk discards. Number of outgoing SCTP DATA chunks for a SCTP association for which no problems were encountered to prevent their transmission but were discarded. Data chunks are discarded due to ungraceful closing of the SCTP association. Signed-off-by:

[PATCH net-next] ifb: add multiqueue operation

2015-07-06 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com Add multiqueue capabilities to ifb netdevice. This removes last bottleneck for ingress when mq qdisc can be used to shard load from multiple RX queues on physical device. Tested: # netem based setup, installed at receiver side ETH=eth0 IFB=ifb10 EST=est

[PATCH net] amd-xgbe: Fix DMA API debug warning

2015-07-06 Thread Tom Lendacky
When running a kernel configured with CONFIG_DMA_API_DEBUG=y a warning is issued: DMA-API: device driver tries to sync DMA memory it has not allocated This warning is the result of mapping the full range of the Rx buffer pages allocated and then performing a dma_sync_single_for_cpu against a

Re: BUG: unable to handle kernel NULL pointer in __netdev_pick_tx()

2015-07-06 Thread Eric Dumazet
On Mon, 2015-07-06 at 19:13 +0800, Bob Liu wrote: Thank you for the quick fix! Tested by rebooting several times and didn't hit this panic any more. Thanks Bob, I will submit an official patch then ;) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [RFC net-next 0/6] Proposal for VRF-lite - v2

2015-07-06 Thread Shrijeet Mukherjee
No no problem, Just trying to get the functional aspects worked out. the global search replace will be easy. Was hoping to see some more responses on the naming suggestions here from the community. If there is not disagreement we can spin patches with MRF as the name. On Mon, Jul 6, 2015 at

Re: [PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG

2015-07-06 Thread Florian Fainelli
2015-07-05 10:16 GMT-07:00 Rob Herring r...@kernel.org: On UML builds, mdio-mux-mmioreg.c fails to compile: drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] drivers/net/phy/mdio-mux-mmioreg.c:63:3: error:

Re: [Intel-wired-lan] [PATCH V3 0/2] pci: Provide a flag to access VPD through function 0

2015-07-06 Thread Rustad, Mark D
On Jun 26, 2015, at 11:04 AM, Rustad, Mark D mark.d.rus...@intel.com wrote: Sorry, Mark, I've just been busy with other issues and haven't had a chance to look at this yet. Is there any chance of this getting into this merge window? Well, it has missed the merge window, but this really is

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-06 Thread David Ahern
On 7/6/15 10:37 AM, Nikolay Aleksandrov wrote: +static int vrf_add_slave(struct net_device *dev, +struct net_device *port_dev) +{ + if (!dev || !port_dev || dev_net(dev) != dev_net(port_dev)) + return -ENODEV; + + if (!vrf_is_master(port_dev)

Re: tc ingress filters not applied

2015-07-06 Thread Daniel Borkmann
On 07/06/2015 07:24 PM, Huan Le wrote: Erik Hugne erik.hugne at ericsson.com writes: I'm having troubles with TC policing, the ingress filters does not seem to be applied. Kernel: net-next/latest iproute2: shemminger/master //E I observed similar behavior when configuring a filter on

Re: tc ingress filters not applied

2015-07-06 Thread Huan Le
Erik Hugne erik.hugne at ericsson.com writes: I'm having troubles with TC policing, the ingress filters does not seem to be applied. Kernel: net-next/latest iproute2: shemminger/master //E I observed similar behavior when configuring a filter on ingress qdisc. Test shows that

Re: problems with L2TP

2015-07-06 Thread Sam Protsenko
Thanks for your reply, Tom! How is the tunnel/session being created on the server side? My server is xl2tpd. If I understand correctly, session and tunnel are being created in start_pppd() function, see [1]. Judging from xl2tpd logs (see [2]), start_pppd() function is executed, in turn, from

Disable setting speed outside the ethtool

2015-07-06 Thread Marian Corcodel
Set speed only on ethtool..Driver is r8169 . From 84ea65a6d1c2bc9bc28e8f54df5766395ea9ce05 Mon Sep 17 00:00:00 2001 From: Corcodel Marian a...@192-168-0-3.rdsnet.ro Date: Mon, 6 Jul 2015 16:33:18 +0300 Subject: [net-next Disable setting speed outside the ethtool] Committer: Corcodel Marian

Re: [PATCH net] Revert dev: set iflink to 0 for virtual interfaces

2015-07-06 Thread Oliver Hartkopp
On 06.07.2015 17:25, Nicolas Dichtel wrote: This reverts commit e1622baf54df8cc958bf29d71de5ad545ea7d93c. The side effect of this commit is to add a '@NONE' after each virtual interface name with a 'ip link'. It may break existing scripts. Reported-by: Olivier Hartkopp socket...@hartkopp.net

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-06 Thread Nikolay Aleksandrov
On 07/06/2015 05:03 PM, David Ahern wrote: This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all local routes pointing

Re: [PATCH v3 net-next 7/7] net_sched: act_mirred: remove spinlock in fast path

2015-07-06 Thread Alexei Starovoitov
On 7/6/15 5:18 AM, Eric Dumazet wrote: Like act_gact, act_mirred can be lockless in packet processing 1) Use percpu stats 2) update lastuse only every clock tick to avoid false sharing 3) use rcu to protect tcfm_dev 4) Remove spinlock usage, as it is no longer needed. Next step : add multi

[PATCH v5] net: fec: Ensure clocks are enabled while using mdio bus

2015-07-06 Thread Andrew Lunn
When a switch is attached to the mdio bus, the mdio bus can be used while the interface is not open. If the IPG clock is not enabled, MDIO reads/writes will simply time out. Add support for runtime PM to control this clock. Enable/disable this clock using runtime PM, with open()/close() and mdio

RE: [PATCH net-next] hv_netvsc: Add support to set MTU reservation from guest side

2015-07-06 Thread Haiyang Zhang
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Friday, July 3, 2015 12:17 PM To: dan.carpen...@oracle.com Cc: Haiyang Zhang; netdev@vger.kernel.org; o...@aepfle.de; jasow...@redhat.com; driverdev-de...@linuxdriverproject.org; linux- ker...@vger.kernel.org

[PATCH net-next,v2] hv_netvsc: Add support to set MTU reservation from guest side

2015-07-06 Thread Haiyang Zhang
When packet encapsulation is in use, the MTU needs to be reduced for headroom reservation. The existing code takes the updated MTU value only from the host side. But vSwitch extensions, such as Open vSwitch, require the flexibility to change the MTU to different values from within a guest during

Re: [PATCH] samples: bpf: enable trace samples for s390x

2015-07-06 Thread Alexei Starovoitov
On 7/6/15 7:20 AM, Michael Holzheu wrote: The trace bpf samples do not compile on s390x because they use x86 specific fields from the pt_regs structure. Fix this and access the fields via new PT_REGS macros. Signed-off-by: Michael Holzheuholz...@linux.vnet.ibm.com ---

Re: [PATCH v3 net-next 7/7] net_sched: act_mirred: remove spinlock in fast path

2015-07-06 Thread Eric Dumazet
ifb patch seems to work very well ;) # tc -s -d qd sh dev ifb10 qdisc mq 1: root Sent 190952 bytes 31798616 pkt (dropped 0, overlimits 0 requeues 0) backlog 29460b 491p requeues 0 qdisc netem 8002: parent 1:1 limit 10 delay 3.0ms Sent 238320936 bytes 3971225 pkt (dropped 0, overlimits

Re: [PATCH v3 net-next 1/7] net: sched: extend percpu stats helpers

2015-07-06 Thread Alexei Starovoitov
On 7/6/15 5:18 AM, Eric Dumazet wrote: qdisc_bstats_update_cpu() and other helpers were added to support percpu stats for qdisc. We want to add percpu stats for tc action, so this patch add common helpers. qdisc_bstats_update_cpu() is renamed to qdisc_bstats_cpu_update()

Re: [PATCH v2] add stealth mode

2015-07-06 Thread Matteo Croce
2015-07-06 12:49 GMT+02:00 valdis.kletni...@vt.edu: On Thu, 02 Jul 2015 10:56:01 +0200, Matteo Croce said: Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Port-Unreachable for UDP. Also disables ICMP replies to echo request and timestamp. The

[PATCH net-next] net: add support for linkdown sysctl to netconf

2015-07-06 Thread Andy Gospodarek
This kernel patch exports the value of the new ignore_routes_with_linkdown via netconf. Signed-off-by: Andy Gospodarek go...@cumulusnetworks.com Suggested-by: Nicolas Dichtel nicolas.dich...@6wind.com --- include/uapi/linux/netconf.h | 1 + net/ipv4/devinet.c | 7 +++ 2 files

Re: [PATCH] sctp: Add counters for out data chunk discards

2015-07-06 Thread Vlad Yasevich
On 07/06/2015 01:37 PM, Vitaly Andrianov wrote: This commit adds a MIB entry for out data chunk discards. Number of outgoing SCTP DATA chunks for a SCTP association for which no problems were encountered to prevent their transmission but were discarded. Data chunks are discarded due to

Re: [PATCH v2 06/22] fjes: buffer address regist/unregistration routine

2015-07-06 Thread Yasuaki Ishimatsu
On Wed, 24 Jun 2015 11:55:38 +0900 Taku Izumi izumi.t...@jp.fujitsu.com wrote: This patch adds buffer address regist/unregistration routine. This function is mainly invoked when network device's activation (open) and deactivation (close) in order to retist/unregist shared buffer address.

Re: [PATCH net-next] ifb: add multiqueue operation

2015-07-06 Thread Alexei Starovoitov
On 7/6/15 1:05 PM, Eric Dumazet wrote: Add multiqueue capabilities to ifb netdevice. This removes last bottleneck for ingress when mq qdisc can be used to shard load from multiple RX queues on physical device. ... Signed-off-by: Eric Dumazeteduma...@google.com Cc: Alexei

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-06 Thread Lawrence Brakmo
On 7/3/15, 9:47 AM, David Miller da...@davemloft.net wrote: From: Lawrence Brakmo bra...@fb.com Date: Thu, 2 Jul 2015 18:21:24 -0700 This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-06 Thread Lawrence Brakmo
On 7/3/15, 1:30 PM, Neal Cardwell ncardw...@google.com wrote: diff --git a/include/linux/tcp.h b/include/linux/tcp.h index 48c3696..05e0da5 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -254,6 +254,10 @@ struct tcp_sock { u32 lost_out; /* Lost packets

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-06 Thread Lawrence Brakmo
On 7/3/15, 10:10 AM, Tom Herbert t...@herbertland.com wrote: On Thu, Jul 2, 2015 at 6:21 PM, Lawrence Brakmo bra...@fb.com wrote: This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed

Re: [PATCH net] amd-xgbe: Fix DMA API debug warning

2015-07-06 Thread Kim Phillips
On Mon, 6 Jul 2015 09:57:37 -0700 Tom Lendacky thomas.lenda...@amd.com wrote: When running a kernel configured with CONFIG_DMA_API_DEBUG=y a warning is issued: DMA-API: device driver tries to sync DMA memory it has not allocated This warning is the result of mapping the full range of the

Re: [PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-06 Thread Andrew Lunn
On Sun, Jul 05, 2015 at 10:14:50PM -0400, Vivien Didelot wrote: Hi all, This patchset brings full support for hardware VLANs in DSA, and the Marvell 88E6xxx compatible switch chips. Hi Vivien I just booted these patches on my board, and i'm getting WARNINGS: [ 61.111302] WARNING: CPU: 0

Re: [PATCH iproute2] include: add copy of tipc.h

2015-07-06 Thread Stephen Hemminger
On Mon, 29 Jun 2015 10:53:15 +0200 (CEST) Michal Kubecek mkube...@suse.cz wrote: Copy of kernel include/uapi/linux/tipc.h is needed to build on systems with pre-3.16 kernel headers. Signed-off-by: Michal Kubecek mkube...@suse.cz Ok, I applied (and fixed) this. The headers you want are not

[PATCH net] rtnetlink: verify IFLA_VF_INFO attributes before passing them to driver

2015-07-06 Thread Daniel Borkmann
Jason Gunthorpe reported that since commit c02db8c6290b (rtnetlink: make SR-IOV VF interface symmetric), we don't verify IFLA_VF_INFO attributes anymore with respect to their policy, that is, ifla_vfinfo_policy[]. Before, they were part of ifla_policy[], but they have been nested since placed

Re: [PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-06 Thread Andrew Lunn
On Tue, Jul 07, 2015 at 01:38:04AM +0200, Andrew Lunn wrote: On Sun, Jul 05, 2015 at 10:14:50PM -0400, Vivien Didelot wrote: Hi all, This patchset brings full support for hardware VLANs in DSA, and the Marvell 88E6xxx compatible switch chips. Hi Vivien I just booted these patches

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU

2015-07-06 Thread Andrew Lunn
+static int _mv88e6xxx_vtu_getnext(struct dsa_switch *ds, u16 vid, + struct mv88e6xxx_vtu_entry *entry) +{ + int ret, i; + + ret = _mv88e6xxx_vtu_wait(ds); + if (ret 0) + return ret; + + ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL,

Re: [PATCH v2] add stealth mode

2015-07-06 Thread David Miller
From: Matteo Croce mat...@openwrt.org Date: Mon, 6 Jul 2015 21:44:06 +0200 2015-07-06 12:49 GMT+02:00 valdis.kletni...@vt.edu: On Thu, 02 Jul 2015 10:56:01 +0200, Matteo Croce said: Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP

Re: [PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-06 Thread Scott Feldman
On Mon, Jul 6, 2015 at 7:00 PM, Andrew Lunn and...@lunn.ch wrote: On Tue, Jul 07, 2015 at 01:38:04AM +0200, Andrew Lunn wrote: On Sun, Jul 05, 2015 at 10:14:50PM -0400, Vivien Didelot wrote: Hi all, This patchset brings full support for hardware VLANs in DSA, and the Marvell 88E6xxx

[PATCH net-next] tcp: always send a quick ack when quickacks are enabled

2015-07-06 Thread Jon Maxwell
I ran some tests and after setting the ip route change quickack 1 knob there were still many delayed ACKs sent. This occured because when icsk_ack.quick=0 the !icsk_ack.pingpong value is subsequently ignored as tcp_in_quickack_mode() checks both these values. The condition for a quick ack to

[PATCH net,v2] ip_tunnel: fix ipv4 pmtu check to honor inner ip header df

2015-07-06 Thread Timo Teräs
Frag needed should be sent only if the inner header asked to not fragment. Currently fragmentation is broken if the tunnel has df set, but df was not asked in the original packet. The tunnel's df needs to be still checked to update internally the pmtu cache. Commit 23a3647bc4f93bac broke it, and

[PATCH v2 net-next 0/7] net_sched: act: lockless operation

2015-07-06 Thread Eric Dumazet
As mentioned by Alexei last week in Budapest, it is a bit weird to take a spinlock in order to drop a packet in a tc filter... Lets add percpu infra for tc actions and use it for gact mirred. Before changes, my host with 8 RX queues was handling 5 Mpps with gact, and more than 11 Mpps after.

[PATCH v2 net-next 1/7] net: sched: extend percpu stats helpers

2015-07-06 Thread Eric Dumazet
qdisc_bstats_update_cpu() and other helpers were added to support percpu stats for qdisc. We want to add percpu stats for tc action, so this patch add common helpers. qdisc_bstats_update_cpu() is renamed to qdisc_bstats_cpu_update() qdisc_qstats_drop_cpu() is renamed to qdisc_qstats_cpu_drop()

[PATCH v2 net-next 2/7] net: sched: add percpu stats to actions

2015-07-06 Thread Eric Dumazet
Reuse existing percpu infrastructure John Fastabend added for qdisc. This patch adds a new cpustats parameter to tcf_hash_create() and all actions pass false, meaning this patch should have no effect yet. Signed-off-by: Eric Dumazet eduma...@google.com Cc: Alexei Starovoitov a...@plumgrid.com

[PATCH v2 net-next 3/7] net_sched: act_gact: make tcfg_pval non zero

2015-07-06 Thread Eric Dumazet
First step for gact RCU operation : Instead of testing if tcfg_pval is zero or not, just make it 1. No change in behavior, but slightly faster code. The smp_rmb()/smp_wmb() barriers, while not strictly needed at this stage are added for upcoming spinlock removal. Signed-off-by: Eric Dumazet

[PATCH v2 net-next 4/7] net_sched: act_gact: use a separate packet counters for gact_determ()

2015-07-06 Thread Eric Dumazet
Second step for gact RCU operation : We want to get rid of the spinlock protecting gact operations. Stats (packets/bytes) will soon be per cpu. gact_determ() would not work without a central packet counter, so lets add it for this mode. Signed-off-by: Eric Dumazet eduma...@google.com Cc: Alexei

[PATCH v2 net-next 3/7] net_sched: act: make tcfg_pval non zero

2015-07-06 Thread Eric Dumazet
First step for gact RCU operation : Instead of testing if tcfg_pval is zero or not, just make it 1. No change in behavior, but slightly faster code. The smp_rmb()/smp_wmb() barriers, while not strictly needed at this stage are added for upcoming spinlock removal. Signed-off-by: Eric Dumazet

Re: [PATCH v2 net-next 0/7] net_sched: act: lockless operation

2015-07-06 Thread Eric Dumazet
On Mon, Jul 6, 2015 at 8:41 AM, Eric Dumazet eduma...@google.com wrote: As mentioned by Alexei last week in Budapest, it is a bit weird to take a spinlock in order to drop a packet in a tc filter... Arg, please ignore v2, I messed my git send-email command -- To unsubscribe from this list:

[RFC net-next 5/6] net: Add sk_bind_dev_if to task_struct

2015-07-06 Thread David Ahern
Allow tasks to have a default device index for binding sockets. If set the value is passed to all AF_INET/AF_INET6 sockets when they are created. The task setting is passed parent to child on fork, but can be set or changed after task creation using prctl (if task has CAP_NET_ADMIN permissions).

[RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-06 Thread David Ahern
This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all local routes pointing to enslaved devices are re-pointed to the vrf

[RFC net-next 4/6] net: Modifications to ipv4 stack for VRF devices

2015-07-06 Thread David Ahern
With the following tweaks to the IPv4 stack: - enslaving devices to a VRF device automatically moves routes to the VRF table; removing the VRF master moves routes back to the main table - the following use cases work for both Rx and Tx: + ICMP (ping -I vrf-device ip) + TCP server and client

  1   2   >