Re: [PATCH net-next 1/2] tcp: don't extend RTO on failed loss probe attempts

2015-07-17 Thread Eric Dumazet
On Fri, 2015-07-17 at 14:22 -0700, Yuchung Cheng wrote: > If TLP was unable to send a probe, it extended the RTO to > now + icsk_rto. But extending the RTO makes little sense > if no TLP probe went out. With this commit, instead of > extending the RTO we re-arm it relative to the transmit time > of

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-17 Thread Sowmini Varadhan
On (07/17/15 16:07), Joe Perches wrote: > On Fri, 2015-07-17 at 22:00 +0200, Sowmini Varadhan wrote: > > __vxlan_find_mac invokes ether_addr_equal on the eth_addr field, > > which triggers unaligned access messages, so rearrange vxlan_fdb > > to avoid this in the most non-intrusive way. > > What a

Re: [PATCH 1/3] fixed_phy: handle link-down case

2015-07-17 Thread Florian Fainelli
Le 07/17/15 16:53, Stas Sergeev a écrit : > 18.07.2015 02:35, Florian Fainelli пишет: >> On 17/07/15 16:24, Stas Sergeev wrote: >>> 18.07.2015 01:01, Florian Fainelli пишет: On 17/07/15 13:03, Stas Sergeev wrote: > 17.07.2015 21:50, Florian Fainelli пишет: >> On 17/07/15 04:26, Stas Se

good afternoon

2015-07-17 Thread wvzjtmqx
Hi samsung s6,280euro, imac,nikon,samsung products site: isgayre. com

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-17 Thread David Miller
From: Joe Perches Date: Fri, 17 Jul 2015 16:07:02 -0700 > On Fri, 2015-07-17 at 22:00 +0200, Sowmini Varadhan wrote: >> __vxlan_find_mac invokes ether_addr_equal on the eth_addr field, >> which triggers unaligned access messages, so rearrange vxlan_fdb >> to avoid this in the most non-intrusive w

Re: [RGC PATCH v3.10] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-17 Thread Alex Gartrell
On Fri, Jul 17, 2015 at 5:10 PM, Cong Wang wrote: > Hmm, but in htb_delete() we do reset the leaf qdisc before removing the > class from ha > > if (!cl->level) { > qlen = cl->un.leaf.q->q.qlen; > qdisc_reset(cl->un.leaf.q); > qdisc_tree_decre

Re: [RGC PATCH v3.10] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-17 Thread Cong Wang
On Fri, Jul 17, 2015 at 4:27 PM, Alex Gartrell wrote: > To my understanding, the following situation is taking place. > > tc_ctl_tclass >-> htb_delete > -> class is deleted from clhash >-> htb_put > -> qdisc_destroy >-> fq_codel_reset > -> fq_codel_dequeue >

Re: [PATCH 1/3] fixed_phy: handle link-down case

2015-07-17 Thread Stas Sergeev
18.07.2015 02:35, Florian Fainelli пишет: On 17/07/15 16:24, Stas Sergeev wrote: 18.07.2015 01:01, Florian Fainelli пишет: On 17/07/15 13:03, Stas Sergeev wrote: 17.07.2015 21:50, Florian Fainelli пишет: On 17/07/15 04:26, Stas Sergeev wrote: 17.07.2015 02:25, Florian Fainelli пишет: On 16/

Re: [PATCH 1/3] fixed_phy: handle link-down case

2015-07-17 Thread Florian Fainelli
On 17/07/15 16:24, Stas Sergeev wrote: > 18.07.2015 01:01, Florian Fainelli пишет: >> On 17/07/15 13:03, Stas Sergeev wrote: >>> 17.07.2015 21:50, Florian Fainelli пишет: On 17/07/15 04:26, Stas Sergeev wrote: > 17.07.2015 02:25, Florian Fainelli пишет: >> On 16/07/15 07:50, Stas Serge

Re: [PATCH net-next] rocker: forward packets to CPU when port is joined to openvswitch

2015-07-17 Thread Jesse Gross
On Thu, Jul 16, 2015 at 7:41 AM, John Fastabend wrote: > On 15-07-16 01:14 AM, Jiri Pirko wrote: >> Thu, Jul 16, 2015 at 09:09:39AM CEST, sfel...@gmail.com wrote: >>> On Wed, Jul 15, 2015 at 11:58 PM, Jiri Pirko wrote: Thu, Jul 16, 2015 at 08:40:31AM CEST, sfel...@gmail.com wrote: > On W

[RGC PATCH v3.10] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-17 Thread Alex Gartrell
First, vehement apologies for sending an RFC patch against such an old kernel. This is (potentially) a bug fix for a crash that we've been seeing in 3.2 and 3.10, and, AFAICT, the underlying issue has not been addressed. We have an application that invokes tc to delete the root every time the con

Re: [PATCH 1/3] fixed_phy: handle link-down case

2015-07-17 Thread Stas Sergeev
18.07.2015 01:01, Florian Fainelli пишет: On 17/07/15 13:03, Stas Sergeev wrote: 17.07.2015 21:50, Florian Fainelli пишет: On 17/07/15 04:26, Stas Sergeev wrote: 17.07.2015 02:25, Florian Fainelli пишет: On 16/07/15 07:50, Stas Sergeev wrote: Currently fixed_phy driver recognizes only the li

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-17 Thread Joe Perches
On Fri, 2015-07-17 at 22:00 +0200, Sowmini Varadhan wrote: > __vxlan_find_mac invokes ether_addr_equal on the eth_addr field, > which triggers unaligned access messages, so rearrange vxlan_fdb > to avoid this in the most non-intrusive way. What arch does this? -- To unsubscribe from this list: s

Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-17 Thread Joe Perches
On Fri, 2015-07-17 at 15:44 +0200, Hagen Paul Pfeifer wrote: > > On July 16, 2015 at 9:23 PM Joe Perches wrote: > > > > It might be useful to have these performance impacting > > changes guarded by something like CONFIG_CC_OPTIMIZE_FOR_SIZE > > with another static __always_inline __ and a functio

Re: [PATCH v2 -next] net: fib: use fib result when zero-length prefix aliases exist

2015-07-17 Thread Julian Anastasov
Hello, On Fri, 17 Jul 2015, Florian Westphal wrote: > default route selection is not deterministic when TOS keys are used: In fact, TOS should be matched just like in fib_table_lookup but it is not. > This changes fib_select_default to not change the FIB chosen result EXCEPT >

Re: [PATCH 1/3] fixed_phy: handle link-down case

2015-07-17 Thread Florian Fainelli
On 17/07/15 13:03, Stas Sergeev wrote: > 17.07.2015 21:50, Florian Fainelli пишет: >> On 17/07/15 04:26, Stas Sergeev wrote: >>> 17.07.2015 02:25, Florian Fainelli пишет: On 16/07/15 07:50, Stas Sergeev wrote: > Currently fixed_phy driver recognizes only the link-up state. > This simpl

[PATCH net] stmmac: fix setting of driver data in stmmac_dvr_probe

2015-07-17 Thread Joachim Eastwood
Commit 803f8fc46274b ("stmmac: move driver data setting into stmmac_dvr_probe") mistakenly set priv and not priv->dev as driver data. This meant that the remove, resume and suspend callbacks that fetched and tried to use this data would most likely explode. Fix the issue by using the correct variab

Re: [PATCH net 1/3] sched: cls_bpf: fix panic on filter replace

2015-07-17 Thread Alexei Starovoitov
On 7/17/15 2:05 PM, John Fastabend wrote: On 15-07-17 01:38 PM, Daniel Borkmann wrote: >The following test case causes a NULL pointer dereference in cls_bpf: > > FOO="1,6 0 0 4294967295," > tc filter add dev foo parent 1: bpf bytecode "$FOO" flowid 1:1 action ok > tc filter replace dev foo

Cannot connect to netlink socket??

2015-07-17 Thread Ben Greear
Any idea what can cause this? The system was working fine earlier, so it is compiled with netlink support, etc. Last thing someone did was to add 258 mac-vlans on top of an ethernet port. Removing macvlan module did not improve things. 'ifconfig -a' works fine. This is on a 4.0.4 (+ local hack

[PATCH net-next 1/2] tcp: don't extend RTO on failed loss probe attempts

2015-07-17 Thread Yuchung Cheng
If TLP was unable to send a probe, it extended the RTO to now + icsk_rto. But extending the RTO makes little sense if no TLP probe went out. With this commit, instead of extending the RTO we re-arm it relative to the transmit time of the write queue head. Signed-off-by: Yuchung Cheng Signed-off-b

[PATCH net-next 2/2] tcp: TLP retransmits last if failed to send new packet

2015-07-17 Thread Yuchung Cheng
When TLP fails to send new packet because of receive window limit or other reasons, it should fall back to retransmit the last packet, instead of resorting to RTO. Signed-off-by: Yuchung Cheng Signed-off-by: Neal Cardwell Signed-off-by: Nanditad Dukkipati --- net/ipv4/tcp_output.c | 14 +++

[PATCH net-next 0/2] tcp: minor tail loss probe improvements

2015-07-17 Thread Yuchung Cheng
This patch series enhance the tail loss probe (TLP) to timeout quicker if it fails to send a probe, and tries harder to send a probe. Yuchung Cheng (2): tcp: don't extend RTO on failed loss probe attempts tcp: TLP retransmits last if failed to send new packet net/ipv4/tcp_output.c | 27 +

Re: [PATCH net 1/3] sched: cls_bpf: fix panic on filter replace

2015-07-17 Thread Daniel Borkmann
On 07/17/2015 11:05 PM, John Fastabend wrote: ... Thanks Daniel. Apparently I got this right in cls_basic but botched it here and in cls_flow. Yep, it's correct there. :) Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@v

Re: [PATCH net 3/3] sched: cls_flow: fix panic on filter replace

2015-07-17 Thread John Fastabend
On 15-07-17 01:38 PM, Daniel Borkmann wrote: > The following test case causes a NULL pointer dereference in cls_flow: > > tc filter add dev foo parent 1: handle 0x1 flow hash keys dst action ok > tc filter replace dev foo parent 1: pref 49152 handle 0x1 \ > flow hash keys mark acti

Re: [PATCH net 1/3] sched: cls_bpf: fix panic on filter replace

2015-07-17 Thread John Fastabend
On 15-07-17 01:38 PM, Daniel Borkmann wrote: > The following test case causes a NULL pointer dereference in cls_bpf: > > FOO="1,6 0 0 4294967295," > tc filter add dev foo parent 1: bpf bytecode "$FOO" flowid 1:1 action ok > tc filter replace dev foo parent 1: pref 49152 handle 0x1 \ >

Re: [PATCH net 0/3] Couple of classifier fixes

2015-07-17 Thread John Fastabend
On 15-07-17 01:41 PM, Daniel Borkmann wrote: > On 07/17/2015 10:38 PM, Daniel Borkmann wrote: >> This fixes a couple of panics in the form of (analogous for >> cls_flow{,er}): > > [ Also putting John into Cc for these fixes as it has to do with all > the RCU conversion, sorry just realized that

Re: [PATCH net 0/3] Couple of classifier fixes

2015-07-17 Thread Daniel Borkmann
On 07/17/2015 10:38 PM, Daniel Borkmann wrote: This fixes a couple of panics in the form of (analogous for cls_flow{,er}): [ Also putting John into Cc for these fixes as it has to do with all the RCU conversion, sorry just realized that after git send-email. ] [ 912.759276] BUG: unable to

[PATCH net 1/3] sched: cls_bpf: fix panic on filter replace

2015-07-17 Thread Daniel Borkmann
The following test case causes a NULL pointer dereference in cls_bpf: FOO="1,6 0 0 4294967295," tc filter add dev foo parent 1: bpf bytecode "$FOO" flowid 1:1 action ok tc filter replace dev foo parent 1: pref 49152 handle 0x1 \ bpf bytecode "$FOO" flowid 1:1 action drop The pro

[PATCH net 3/3] sched: cls_flow: fix panic on filter replace

2015-07-17 Thread Daniel Borkmann
The following test case causes a NULL pointer dereference in cls_flow: tc filter add dev foo parent 1: handle 0x1 flow hash keys dst action ok tc filter replace dev foo parent 1: pref 49152 handle 0x1 \ flow hash keys mark action drop To be more precise, actually two different pan

[PATCH net 2/3] sched: cls_flower: fix panic on filter replace

2015-07-17 Thread Daniel Borkmann
The following test case causes a NULL pointer dereference in cls_flower: tc filter add dev foo parent 1: flower eth_type ipv4 action ok flowid 1:1 tc filter replace dev foo parent 1: pref 49152 handle 0x1 \ flower eth_type ipv6 action ok flowid 1:1 The problem is that commit 77b99

[PATCH net 0/3] Couple of classifier fixes

2015-07-17 Thread Daniel Borkmann
This fixes a couple of panics in the form of (analogous for cls_flow{,er}): [ 912.759276] BUG: unable to handle kernel NULL pointer dereference at (null) [ 912.759373] IP: [] cls_bpf_change+0x23d/0x268 [cls_bpf] [ 912.759441] PGD 8783c067 PUD 5f684067 PMD 0 [ 912.759491] Oops: 0002 [#1] SMP D

Re: [PATCH net-next 15/22] route: Extend flow representation with tunnel key

2015-07-17 Thread Julian Anastasov
Hello, On Fri, 17 Jul 2015, Thomas Graf wrote: > Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to > allow routes to match on tunnel metadata. For now, the tunnel id is > added to flowi_tunnel which allows for routes to be bound to specific > virtual tunnels. > > Si

[PATCH net-next 4/4] cxgb4 : Fill DCB priority in vlan control headers

2015-07-17 Thread Anish Bhatt
Signed-off-by: Anish Bhatt --- drivers/net/ethernet/chelsio/cxgb4/sge.c| 14 ++ drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 3 +++ 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.

[PATCH net-next 1/4] cxgb4 : Only pass app selector of 0 or 3 to firmware

2015-07-17 Thread Anish Bhatt
This keeps app format passed to firmware the same irrespective of DCBx version in use. Signed-off-by: Anish Bhatt --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c b/drivers

[PATCH net-next 0/4] cxgb4 DCB updates

2015-07-17 Thread Anish Bhatt
The following patchset covers changes to work better with the userspace tools cgdcbxd and cgrulesengd and improves firmware support for host-managed mode. Also exports traffic class information that was previously not being exported via dcbnl_ops and unfifies how app selector information is passe

[PATCH net-next 2/4] cxgb4 : Allow firmware DCB info to be queried in host state

2015-07-17 Thread Anish Bhatt
Since finally DCB traffic management is still handled by firmware, allow firmware to be fully programmed and queried even in host managed state for the cases where this was previously rejected. Signed-off-by: Anish Bhatt --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 32 +--

[PATCH net-next 3/4] cxgb4 : Fill in number of DCB traffic classes supported

2015-07-17 Thread Anish Bhatt
Signed-off-by: Anish Bhatt --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c index 56a81b8f7c54..052c660aca80 100644 --- a/drivers/net/ethernet

Re: [PATCH 1/3] fixed_phy: handle link-down case

2015-07-17 Thread Stas Sergeev
17.07.2015 21:50, Florian Fainelli пишет: On 17/07/15 04:26, Stas Sergeev wrote: 17.07.2015 02:25, Florian Fainelli пишет: On 16/07/15 07:50, Stas Sergeev wrote: Currently fixed_phy driver recognizes only the link-up state. This simple patch adds an implementation of link-down state. It fixes

[PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-17 Thread Sowmini Varadhan
__vxlan_find_mac invokes ether_addr_equal on the eth_addr field, which triggers unaligned access messages, so rearrange vxlan_fdb to avoid this in the most non-intrusive way. Signed-off-by: Sowmini Varadhan --- v2: Alexander Duyck comments: make eth_addr[] 64b aligned. drivers/net/vxlan.c |

Re: [PATCH net-next v2 1/5] net: don't reforward packets already forwarded by offload device

2015-07-17 Thread Scott Feldman
On Fri, Jul 17, 2015 at 7:37 AM, Nicolas Dichtel wrote: > Le 16/07/2015 10:04, sfel...@gmail.com a écrit : >> >> From: Scott Feldman >> >> Just before queuing skb for xmit on port, check if skb has been marked by >> switchdev port driver as already fordwarded by device. If so, drop skb. >> A >>

Re: [PATCH net-next v2] rhashtable: Allow other tasks to be scheduled in large lookup loops

2015-07-17 Thread Eric Dumazet
On Fri, 2015-07-17 at 22:07 +0300, mr...@linux.ee wrote: > > Depending on system speed, the large lookup/insert/delete loops of the > > testsuite can > > take a considerable amount of time to complete causing watchdog warnings to > > appear. > > Allow other tasks to be scheduled throughout the lo

Re: [net-next 01/14] clarify implementation of ethtool's get_ts_info op

2015-07-17 Thread Richard Cochran
On Fri, Jul 17, 2015 at 07:25:10AM -0700, Jeff Kirsher wrote: > From: Jacob Keller > > This patch adds some clarification about the intended way to implement > both SIOCSHWTSTAMP and ethtool's get_ts_info. The HWTSTAMP API has > several Rx filters which are very specific, as well as more general

Re: [PATCH net-next v2] rhashtable: Allow other tasks to be scheduled in large lookup loops

2015-07-17 Thread mroos
> Depending on system speed, the large lookup/insert/delete loops of the > testsuite can > take a considerable amount of time to complete causing watchdog warnings to > appear. > Allow other tasks to be scheduled throughout the loops. > > Reported-by: Meelis Roos > Signed-off-by: Thomas Graf >

Re: [PATCH 1/3] fixed_phy: handle link-down case

2015-07-17 Thread Florian Fainelli
On 17/07/15 04:26, Stas Sergeev wrote: > 17.07.2015 02:25, Florian Fainelli пишет: >> On 16/07/15 07:50, Stas Sergeev wrote: >>> >>> Currently fixed_phy driver recognizes only the link-up state. >>> This simple patch adds an implementation of link-down state. >>> It fixes the status registers when

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-17 Thread Alexei Starovoitov
On 7/17/15 5:55 AM, Thomas Graf wrote: @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) netif_keep_dst(dev); dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; + /* If in flow based mode, keep the dst including encapsulation +* instructions for vxlan_xmi

Re: [PATCH net-next 1/2] bpf: introduce bpf_skb_vlan_push/pop() helpers

2015-07-17 Thread Alexei Starovoitov
On 7/17/15 1:12 AM, Eric Dumazet wrote: On Thu, 2015-07-16 at 19:58 -0700, Alexei Starovoitov wrote: In order to let eBPF programs call skb_vlan_push/pop via helper functions Why should eBPF program do such thing ? Are BPF users in the kernel expecting skb being changed, and are we sure they

Re: 4.1.0, kernel panic, pppoe_release

2015-07-17 Thread Denys Fedoryshchenko
Probably my knowledge of kernel is not sufficient, but i will try few approaches. One of them to add to pppoe_unbind_sock_work: pppox_unbind_sock(sk); +/* Signal the death of the socket. */ +sk->sk_state = PPPOX_DEAD; I will wait first, to make sure this patch was causin

Re: [PATCH] net: bcmgenet: Return the variable ret rather then zero for the function bcmgenet_power_down

2015-07-17 Thread Florian Fainelli
On 16/07/15 12:38, Nicholas Krause wrote: > This makes the function bcmgenet_power_down return the variable ret > rather then zero in order to make this function be able to signal its > caller with a error code when a failure occurs internally rather then > always appearing to run successfully to i

[PATCH v2 -next] net: fib: use fib result when zero-length prefix aliases exist

2015-07-17 Thread Florian Westphal
default route selection is not deterministic when TOS keys are used: ip route del default ip route add tos 0x00 via 10.2.100.100 ip route add tos 0x04 via 10.2.100.101 ip route add tos 0x08 via 10.2.100.102 ip route add tos 0x0C via 10.2.100.103 ip route add tos 0x10 via 10.2.100.104 [ i.e. 5 ro

Re: [PATCH] bcmsysport:Fix error handling in the function bcm_sysport_init_rx_ring

2015-07-17 Thread Florian Fainelli
On 17/07/15 05:13, Nicholas Krause wrote: > This fixes the error handling in the function bcm_sysport_init_rx_ringi > after calling the function rdma_enable_set to make sure the return value > is equal to zero and if not print on the console failed to enable RDMA > for the device and return the fa

Re: [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-17 Thread Pravin Shelar
On Fri, Jul 17, 2015 at 3:58 AM, Thomas Graf wrote: > On 07/16/15 at 02:36pm, Pravin Shelar wrote: >> On Thu, Jul 16, 2015 at 7:52 AM, Thomas Graf wrote: >> > I'm inclined to change this and use an in-kernel API as well to >> > create the net_device just like VXLAN does in patch 21. >> > >> > Pra

[PATCH] sctp: fix cut and paste issue in comment

2015-07-17 Thread Marcelo Ricardo Leitner
Cookie ACK is always received by the association initiator, so fix the comment to avoid confusion. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/sm_statefuns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index 3ee27

Re: [PATCH -next] net: fib: use fib result when zero-length prefix aliases exist

2015-07-17 Thread Alexander Duyck
On 07/17/2015 08:17 AM, Florian Westphal wrote: default route selection is not deterministic when TOS keys are used: ip route del default ip route add tos 0x00 via 10.2.100.100 ip route add tos 0x04 via 10.2.100.101 ip route add tos 0x08 via 10.2.100.102 ip route add tos 0x0C via 10.2.100.103 i

RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, July 17, 2015 9:10 AM > To: KY Srinivasan > Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jaso

Re: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread Vitaly Kuznetsov
KY Srinivasan writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Friday, July 17, 2015 7:13 AM >> To: KY Srinivasan >> Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- >> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de

RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, July 17, 2015 7:13 AM > To: KY Srinivasan > Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jaso

RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Friday, July 17, 2015 3:07 AM > To: KY Srinivasan; da...@davemloft.net; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com; vkuzn...@redhat.com > C

RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Friday, July 17, 2015 3:01 AM > To: KY Srinivasan; da...@davemloft.net; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com; vkuzn...@redhat.com > C

Re: sit: Set SKB_GSO_SIT bit when performing GRO

2015-07-17 Thread Wolfgang Walter
Am Freitag, 17. Juli 2015, 09:56:51 schrieb Herbert Xu: > On Thu, Jul 16, 2015 at 12:58:45PM +0200, Wolfgang Walter wrote: > > Am Donnerstag, 16. Juli 2015, 08:23:50 schrieb Herbert Xu: > > > On Wed, Jul 15, 2015 at 02:25:59PM +0200, Wolfgang Walter wrote: > > > > Yes. Switching TSO off and leaving

Re: 4.1.0, kernel panic, pppoe_release

2015-07-17 Thread Dan Williams
On Fri, 2015-07-17 at 12:24 +0300, Denys Fedoryshchenko wrote: > As i suspect, this kernel panic caused by recent changes to pppoe. > This problem appearing in accel-pppd (server), on loaded servers (2k > users and more). > Most probably related to changed "pppoe: Use workqueue to die properly >

[PATCH v2 1/2] sctp: reduce indent level on sctp_v4_get_dst

2015-07-17 Thread Marcelo Ricardo Leitner
Paves the day for the next patch. Functionality stays untouched. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/protocol.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index 59e80356672bdf89

[PATCH v2 2/2] sctp: fix src address selection if using secondary addresses

2015-07-17 Thread Marcelo Ricardo Leitner
In short, sctp is likely to incorrectly choose src address if socket is bound to secondary addresses. This patch fixes it by adding a new check that checks if such src address belongs to the interface that routing identified as output. This is enough to avoid rp_filter drops on remote peer. Detai

[PATCH v2 0/2] sctp: fix src address selection if using secondary address

2015-07-17 Thread Marcelo Ricardo Leitner
This series improves the way SCTP chooses its src address so that the choosen one will always belong to the interface being used for output. v1->v2: - split out the refactoring from the fix itself - Doing a full reverse routing as in v1 is not necessary. Only looking for the interface that ha

[PATCH -next] net: fib: use fib result when zero-length prefix aliases exist

2015-07-17 Thread Florian Westphal
default route selection is not deterministic when TOS keys are used: ip route del default ip route add tos 0x00 via 10.2.100.100 ip route add tos 0x04 via 10.2.100.101 ip route add tos 0x08 via 10.2.100.102 ip route add tos 0x0C via 10.2.100.103 ip route add tos 0x10 via 10.2.100.104 [ i.e. 5 ro

Re: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature

2015-07-17 Thread Vitaly Kuznetsov
Dexuan Cui writes: >> From: David Miller >> Sent: Thursday, July 16, 2015 12:19 >> >> From: Dexuan Cui >> Date: Tue, 14 Jul 2015 03:00:48 -0700 >> >> > + pr_debug("hvsock_sk_destruct: called\n"); >> >> Debug logging just to state that a function is called is not appropriate, >> we have very s

RE: [PATCH v7 3/3] ixgbe, ixgbevf: Add new mbox API xcast mode

2015-07-17 Thread Skidmore, Donald C
> -Original Message- > From: Hiroshi Shimamoto [mailto:h-shimam...@ct.jp.nec.com] > Sent: Thursday, July 16, 2015 3:36 AM > To: Alexander Duyck; Skidmore, Donald C; Rose, Gregory V; Kirsher, Jeffrey > T; intel-wired-...@lists.osuosl.org > Cc: nhor...@redhat.com; jogre...@redhat.com; Linux

Re: [PATCH net-next v2 1/5] net: don't reforward packets already forwarded by offload device

2015-07-17 Thread Nicolas Dichtel
Le 16/07/2015 10:04, sfel...@gmail.com a écrit : From: Scott Feldman Just before queuing skb for xmit on port, check if skb has been marked by switchdev port driver as already fordwarded by device. If so, drop skb. A non-zero skb->offload_fwd_mark field is set by the switchdev port driver/dev

[net-next 11/14] ixgbe: Specify Rx hash type WRT Rx desc RSS type

2015-07-17 Thread Jeff Kirsher
From: Fan Du RSS could be leveraged by taking account L4 src/dst ports as ingredients, thus ingress skb Rx hash type should honor such the real configuration. Signed-off-by: Fan Du Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 25

[net-next 01/14] clarify implementation of ethtool's get_ts_info op

2015-07-17 Thread Jeff Kirsher
From: Jacob Keller This patch adds some clarification about the intended way to implement both SIOCSHWTSTAMP and ethtool's get_ts_info. The HWTSTAMP API has several Rx filters which are very specific, as well as more general filters. The specific filters really only exist to support some broken h

[net-next 00/14][pull request] Intel Wired LAN Driver Updates 2015-07-17

2015-07-17 Thread Jeff Kirsher
This series contains updates to igb, ixgbe, ixgbevf, i40e, bnx2x, freescale, siena and dp83640. Jacob provides several patches to clarify the intended way to implement both SIOCSHWTSTAMP and ethtool's get_ts_info(). It is okay to support the specific filters in SIOCSHWTSTAMP by upscaling them to

[net-next 12/14] ixgbevf: Set Rx hash type for ingress packets

2015-07-17 Thread Jeff Kirsher
From: Fan Du Set hash type for ingress packets according to NIC advanced receive descriptors RSS type part. Signed-off-by: Fan Du Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbevf/defines.h | 12 ++ drivers/net/ethernet/intel/ixgbevf/ixgb

[net-next 09/14] igb: Pull timestamp from fragment before adding it to skb

2015-07-17 Thread Jeff Kirsher
From: Alexander Duyck This change makes it so that we pull the timestamp from the fragment before we add it to the skb. By doing this we can avoid a possible issue in which the fragment can possibly be less than IGB_RX_HDR_LEN due to the timestamp being pulled after the copybreak check. While m

[net-next 14/14] igb: Fix i354 88E1112 PHY on RCC boards using AutoMediaDetect

2015-07-17 Thread Jeff Kirsher
From: Todd Fujinaka e1000_check_for_link_media_swap() checks PHY page 0 for copper and PHY page 1 for "other" (fiber) link. The switch back from page 1 to page 0 happened too soon, before e1000_check_for_link_82575() is executed, and link on fiber (other) was never detected. Check for link while

[net-next 08/14] dp83640: only report generic filters in ts_info

2015-07-17 Thread Jeff Kirsher
From: Jacob Keller CC: Richard Cochran Signed-off-by: Jacob Keller Signed-off-by: Jeff Kirsher --- drivers/net/phy/dp83640.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c index 00cb41e..185b03c 100644 --- a/

[net-next 04/14] i40e: only report generic filters in get_ts_info

2015-07-17 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/e

[net-next 13/14] ixgbe: Don't report flow director filter's status

2015-07-17 Thread Jeff Kirsher
From: Fan Du For two reasons I want to disable this: 1. Not any part actually check the report status(Alexander Duyck) 2. To report hash value of a packet to stack, RSS -> 32bits hash value Perfect match fdir filter -> 13bits hash value Hashed-based fdir filter -> 31bits hash value f

[net-next 03/14] bnx2x: only report most generic filters in get_ts_info

2015-07-17 Thread Jeff Kirsher
From: Jacob Keller CC: Ariel Elior Signed-off-by: Jacob Keller Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net

[net-next 02/14] freescale: remove incorrect copied comment

2015-07-17 Thread Jeff Kirsher
From: Jacob Keller The comment in question is word-for-word copied from ixgbe, and clearly has no meaning in freescale's driver. (it even says 'return an error' when the code clearly does not). Remove the comment as it is obviously incorrect and not applicable to the code as it is today. CC: Pan

[net-next 10/14] ixgbevf: fold ixgbevf_pull_tail into ixgbevf_add_rx_frag

2015-07-17 Thread Jeff Kirsher
From: Alexander Duyck This change folds the ixgbevf_pull_tail call into ixgbevf_add_rx_frag. The advantage to doing this is that the fragment doesn't have to be modified after it is added to the skb. Signed-off-by: Alexander Duyck Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- driv

[net-next 07/14] siena: only report generic filters in get_ts_info

2015-07-17 Thread Jeff Kirsher
From: Jacob Keller CC: Solarflare linux maintainers CC: Shradha Shah Signed-off-by: Jacob Keller Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/sfc/siena.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/sfc/siena.c b/drivers/net/ethernet/s

[net-next 06/14] ixgbe: only report generic filters in get_ts_info

2015-07-17 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixg

[net-next 05/14] igb: only report generic filters in get_ts_info

2015-07-17 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.

[PATCH nf-next v2] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-17 Thread Michal Kubecek
Currently nf_conntrack_proto_sctp module handles only packets between primary addresses used to establish the connection. Any packets between secondary addresses are classified as invalid so that usual firewall configurations drop them. Allowing HEARTBEAT and HEARTBEAT-ACK chunks to establish a new

Re: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread Vitaly Kuznetsov
"K. Y. Srinivasan" writes: > The current code returns from probe without waiting for the proper handling > of subchannels that may be requested. If the netvsc driver were to be rapidly > loaded/unloaded, we can trigger a panic as the unload will be tearing > down state that may not have been ful

Re: [PATCH net-next 0/6] net: bcmgenet: PHY initialization rework

2015-07-17 Thread Jaedon Shin
> On Jul 17, 2015, at 7:51 AM, Florian Fainelli wrote: > > Hi David, Petri, Jaedon, > > This patch series reworks how we perform PHY initialization and resets in the > GENET driver. Although this contains mostly fixes, some of the changes are a > bit too intrusive to be backported to 'net' at th

Re: [PATCH] mac80211: Deinline rate_control_rate_init, rate_control_rate_update

2015-07-17 Thread Johannes Berg
On Wed, 2015-07-15 at 14:56 +0200, Denys Vlasenko wrote: > With this .config: http://busybox.net/~vda/kernel_config, > after deinlining these functions have sizes and callsite counts > as follows: > > rate_control_rate_init: 554 bytes, 8 calls > rate_control_rate_update: 1596 bytes, 5 calls > > T

Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-17 Thread Hagen Paul Pfeifer
> On July 16, 2015 at 9:23 PM Joe Perches wrote: > > It might be useful to have these performance impacting > changes guarded by something like CONFIG_CC_OPTIMIZE_FOR_SIZE > with another static __always_inline __ and a function & > EXPORT_SYMBOL or just a static inline so that where code size > i

Re: pull-request: mac80211 2015-07-17

2015-07-17 Thread Johannes Berg
On Fri, 2015-07-17 at 15:31 +0200, Johannes Berg wrote: > Hi Dave, > > We've accumulated some wireless fixes, please pull. Arik's fix is a > bit > bigger than I might like, but it fixes a real locking issue and we > didn't really see a good way to make a smaller version. > > Let me know if there

pull-request: mac80211 2015-07-17

2015-07-17 Thread Johannes Berg
Hi Dave, We've accumulated some wireless fixes, please pull. Arik's fix is a bit bigger than I might like, but it fixes a real locking issue and we didn't really see a good way to make a smaller version. Let me know if there's any problem. johannes The following changes since commit f760b87f8f

[PATCH net-next 11/22] icmp: Don't leak original dst into ip_route_input()

2015-07-17 Thread Thomas Graf
ip_route_input() unconditionally overwrites the dst. Hide the original dst attached to the skb by calling skb_dst_set(skb, NULL) prior to ip_route_input(). Reported-by: Julian Anastasov Signed-off-by: Thomas Graf --- net/ipv4/icmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/i

[PATCH net-next 00/22] Lightweight & flow based encapsulation

2015-07-17 Thread Thomas Graf
This series combines the work previously posted by Roopa, Robert and myself. It's according to what we discussed at NFWS. The motivation of this series is to: * Consolidate code between OVS and the rest of the kernel and get rid of OVS vports and instead represent them as pure net_devices. *

[PATCH net-next 06/22] ipv4: redirect dst output to lwtunnel output

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu For input routes with tunnel encap state this patch redirects dst output functions to lwtunnel_output which later resolves to the corresponding lwtunnel output function. This has been tested to work with mpls ip tunnels. Open items: Support for tunnel mtu, pmtu, fragmentation

[PATCH net-next 10/22] ip_tunnel: Make ovs_tunnel_info and ovs_key_ipv4_tunnel generic

2015-07-17 Thread Thomas Graf
Rename the tunnel metadata data structures currently internal to OVS and make them generic for use by all IP tunnels. Both structures are kernel internal and will stay that way. Their members are exposed to user space through individual Netlink attributes by OVS. It will therefore be possible to e

[PATCH net-next 02/22] lwtunnel: infrastructure for handling light weight tunnels like mpls

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu Provides infrastructure to parse/dump/store encap information for light weight tunnels like mpls. Encap information for such tunnels is associated with fib routes. This infrastructure is based on previous suggestions from Eric Biederman to follow the xfrm infrastructure. Sign

[PATCH net-next 07/22] ipv6: rt6_info output redirect to tunnel output

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu This is similar to ipv4 redirect of dst output to lwtunnel output function for encapsulation and xmit. Signed-off-by: Roopa Prabhu --- net/ipv6/route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index b3431b7..7f2214f 100644 --- a

[PATCH net-next 15/22] route: Extend flow representation with tunnel key

2015-07-17 Thread Thomas Graf
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to allow routes to match on tunnel metadata. For now, the tunnel id is added to flowi_tunnel which allows for routes to be bound to specific virtual tunnels. Signed-off-by: Thomas Graf --- include/net/flow.h | 7 +++ net/ipv

[PATCH net-next 12/22] dst: Metadata destinations

2015-07-17 Thread Thomas Graf
Introduces a new dst_metadata which enables to carry per packet metadata between forwarding and processing elements via the skb->dst pointer. The structure is set up to be a union. Thus, each separate type of metadata requires its own dst instance. If demand arises to carry multiple types of metad

[PATCH net-next 04/22] ipv6: support for fib route lwtunnel encap attributes

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu This patch adds support in ipv6 fib functions to parse Netlink RTA encap attributes and attach encap state data to rt6_info. Signed-off-by: Roopa Prabhu --- include/net/ip6_fib.h | 3 +++ net/ipv6/ip6_fib.c| 2 ++ net/ipv6/route.c | 33

[PATCH net-next 03/22] ipv4: support for fib route lwtunnel encap attributes

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu This patch adds support in ipv4 fib functions to parse user provided encap attributes and attach encap state data to fib_nh and rtable. Signed-off-by: Roopa Prabhu --- include/net/ip_fib.h | 5 ++- include/net/route.h | 1 + net/ipv4/fib_frontend.c | 8 net

[PATCH net-next 18/22] vxlan: Factor out device configuration

2015-07-17 Thread Thomas Graf
This factors out the device configuration out of the RTNL newlink API which allows for in-kernel creation of VXLAN net_devices. Signed-off-by: Thomas Graf --- drivers/net/vxlan.c | 332 include/net/vxlan.h | 59 ++ 2 files changed, 23

  1   2   >