drivers/net/phy/dp83867.c:126:1-4: WARNING: end returns can be simpified
drivers/net/phy/dp83867.c:74:5-8: WARNING: end returns can be simpified if
tested value is negative or 0
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by:
RFC 5061:
This is an opaque integer assigned by the sender to identify each
request parameter. The receiver of the ASCONF Chunk will copy this
32-bit value into the ASCONF Response Correlation ID field of the
ASCONF-ACK response parameter. The sender of the ASCONF can use this
Sent from my iPhone
On Jul 24, 2015, at 08:14, Scott Feldman sfel...@gmail.com wrote:
On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko j...@resnulli.us wrote:
From: Ido Schimmel ido...@mellanox.com
Add the ability to construct mailbox-style register access messages
called EMADs with
On Thu, Jul 23, 2015 at 01:24:50PM +0300, Dan Carpenter wrote:
On Thu, Jul 23, 2015 at 01:10:57PM +0300, Dan Carpenter wrote:
In this specific case, writing it as if (ret != 0) caused the bug. If
we had written it as if (ret) return ret; then there are no zeroes so
wouldn't have been any
On Fri, Jul 24, 2015 at 10:18 AM, Jinpu Wang
jinpu.w...@profitbricks.com wrote:
Hi all,
I hit bug in OFED, I report to link below:
http://marc.info/?l=linux-rdmam=143634872328553w=2
I checked latest mainline Linux 4.2-rc3, it has similar bug.
Here is the patch against Linux 4.2-rc3, compile
This function make sense only when LWTUNNEL_STATE_OUTPUT_REDIRECT is set.
The check is already done in IPv4.
CC: Thomas Graf tg...@suug.ch
CC: Roopa Prabhu ro...@cumulusnetworks.com
Fixes: 74a0f2fe8ed5 (ipv6: rt6_info output redirect to tunnel output)
Signed-off-by: Nicolas Dichtel
Maninder Singh maninder...@samsung.com writes:
chandef is initialized with NULL and on the very next line,
we are using it to get channel, which is not correct.
channel should be initialized after obtaining chandef.
Signed-off-by: Maninder Singh maninder...@samsung.com
Thanks, applied.
--
On Fri, Jul 24, 2015 at 11:57:01AM +0530, Sudip Mukherjee wrote:
This is also ok, the function is supposed to return ret or-ed with the
relevant flags based on the scan position. It is considered error if 0
is returned (without any flag).
Yeah. You're right. I looked through my list again
We need to copy this field (ip6_rt_cache_alloc() and ip6_rt_pcpu_alloc()
use ip6_rt_copy_init() to build a dst).
CC: Thomas Graf tg...@suug.ch
CC: Roopa Prabhu ro...@cumulusnetworks.com
Fixes: 19e42e451506 (ipv6: support for fib route lwtunnel encap attributes)
Signed-off-by: Nicolas Dichtel
On 07/24/15 at 10:59am, Nicolas Dichtel wrote:
This function make sense only when LWTUNNEL_STATE_OUTPUT_REDIRECT is set.
The check is already done in IPv4.
CC: Thomas Graf tg...@suug.ch
CC: Roopa Prabhu ro...@cumulusnetworks.com
Fixes: 74a0f2fe8ed5 (ipv6: rt6_info output redirect to tunnel
It saves some lines and simplify a bit the code when the state is returning
by this function. It's also useful to handle a NULL entry.
To avoid too long lines, I've also renamed lwtunnel_state_get() and
lwtunnel_state_put() to lwtstate_get() and lwtstate_put().
CC: Thomas Graf tg...@suug.ch
CC:
2015-07-24 12:48 GMT+08:00 YOSHIFUJI Hideaki
hideaki.yoshif...@miraclelinux.com:
Hi,
Hangbin Liu wrote:
Commit 6fd99094de2b (ipv6: Don't reduce hop limit for an interface)
disabled accept hop limit from RA if it is higher than the current hop
limit for security stuff. But this behavior kind
On 07/24/15 at 12:28pm, Nicolas Dichtel wrote:
We need to copy this field (ip6_rt_cache_alloc() and ip6_rt_pcpu_alloc()
use ip6_rt_copy_init() to build a dst).
CC: Thomas Graf tg...@suug.ch
CC: Roopa Prabhu ro...@cumulusnetworks.com
Fixes: 19e42e451506 (ipv6: support for fib route lwtunnel
On 07/24/15 at 12:28pm, Nicolas Dichtel wrote:
It saves some lines and simplify a bit the code when the state is returning
by this function. It's also useful to handle a NULL entry.
To avoid too long lines, I've also renamed lwtunnel_state_get() and
lwtunnel_state_put() to lwtstate_get() and
From: Shaohui Xie shaohui@freescale.com
When using fiber port, the phy cannot report it's auto negotiation state,
driver should always report auto negotiation is done when using fiber port.
Signed-off-by: Shaohui Xie shaohui@freescale.com
---
drivers/net/phy/teranetics.c | 11
On Fri, 2015-07-24 at 16:16 +0200, Nicolas Dichtel wrote:
This patch takes advantage of the newly added lwtunnel framework to
allow the user to set routes that point to a peer netns.
Packets are injected to the peer netns via the loopback device. It works
only when the output device is
Begin forwarded message:
Date: Fri, 24 Jul 2015 11:22:17 +
From: bugzilla-dae...@bugzilla.kernel.org
bugzilla-dae...@bugzilla.kernel.org
To: shemmin...@linux-foundation.org shemmin...@linux-foundation.org
Subject: [Bug 99461] recvfrom SYSCALL infinite loop/deadlock chewing 100% CPU
[was
Make sure that return value of each socket() call is properly checked
and do not continue processing if the call failed.
Signed-off-by: Zhang Shengju zhangshen...@cmss.chinamobile.com
---
ip/tunnel.c | 24
1 file changed, 24 insertions(+)
diff --git a/ip/tunnel.c
23.07.2015 12:15, Oliver Neukum пишет:
On Wed, 2015-07-22 at 21:33 +0300, Eugene Shatokhin wrote:
The following part is not necessary, I think. usbnet_bh() does not
touch
EVENT_NO_RUNTIME_PM bit explicitly and these bit operations are
atomic
w.r.t. each other.
+ mpn |=
On Fri, Jul 24, 2015 at 05:39:57PM +0200, Eric Dumazet wrote:
On Fri, 2015-07-24 at 16:16 +0200, Nicolas Dichtel wrote:
This patch takes advantage of the newly added lwtunnel framework to
allow the user to set routes that point to a peer netns.
Packets are injected to the peer netns
This patch adds data structures and handlers for messages related
to SRIOV Virtual Function.
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Reviewed-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/net/hyperv/hyperv_net.h | 29 ++
drivers/net/hyperv/netvsc.c
Currently, tcp_recvmsg enters a busy loop in sk_wait_data if called
with flags = MSG_WAITALL | MSG_PEEK.
sk_wait_data waits for sk_receive_queue not empty, but in this case,
the receive queue is not empty, but does not contain any skb that we
can use.
Add a last skb seen on receive queue
On 7/23/15 8:22 AM, Nicolas Dichtel wrote:
static netdev_tx_t loopback_xmit(struct sk_buff *skb,
struct net_device *dev)
{
+ int nsid = skb_lwt_netns_info(skb);
struct pcpu_lstats *lb_stats;
int len;
+ if (nsid = 0) {
+
On 7/24/15 8:32 AM, Nicolas Dichtel wrote:
Le 24/07/2015 16:28, David Ahern a écrit :
On 7/23/15 8:22 AM, Nicolas Dichtel wrote:
static netdev_tx_t loopback_xmit(struct sk_buff *skb,
struct net_device *dev)
{
+int nsid = skb_lwt_netns_info(skb);
struct
-Original Message-
From: Joe Perches [mailto:j...@perches.com]
On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote:
Allow the user to tweak the refill threshold and the total number
of buffers in the buffer pool. The provided values are for one CPU.
Any value in making these
This patch takes advantage of the newly added lwtunnel framework to
allow the user to set routes that point to a peer netns.
Packets are injected to the peer netns via the loopback device. It works
only when the output device is 'lo'.
Example:
ip route add 40.1.1.1/32 encap netns nsid 5 via dev
Le 24/07/2015 16:28, David Ahern a écrit :
On 7/23/15 8:22 AM, Nicolas Dichtel wrote:
static netdev_tx_t loopback_xmit(struct sk_buff *skb,
struct net_device *dev)
{
+int nsid = skb_lwt_netns_info(skb);
struct pcpu_lstats *lb_stats;
int len;
+if (nsid
On Wed, Jul 22, 2015 at 10:39 PM, Stephen Hemminger
step...@networkplumber.org wrote:
On Wed, 22 Jul 2015 17:07:37 -0700
Cong Wang xiyou.wangc...@gmail.com wrote:
For a real example, named randomly selects some port to bind() for
security concern. (It doesn't use bind(0) to let kernel to
The device probe method e1000_probe calls e1000_init_eeprom_params
itself so there's no reason to call it again from e1000_do_write_eeprom
or e1000_do_read_eeprom.
The sentence above assumes that e1000_init_eeprom_params is effective
but it's mostly dependant on hw-mac_type: safe as e1000_probe
On Friday 24 July 2015 08:02 PM, Kalle Valo wrote:
Vineet Gupta vineet.gup...@synopsys.com writes:
There's already a generic implementation so use that instead.
---
I'm not sure if the driver usage of atomic_or?() is correct in terms of
storage size of @val for 64 bit arches.
On Fri, 2015-07-24 at 18:19 +0200, Sabrina Dubroca wrote:
Currently, tcp_recvmsg enters a busy loop in sk_wait_data if called
with flags = MSG_WAITALL | MSG_PEEK.
sk_wait_data waits for sk_receive_queue not empty, but in this case,
the receive queue is not empty, but does not contain any skb
21.07.2015 15:04, Oliver Neukum пишет:
On Mon, 2015-07-20 at 21:13 +0300, Eugene Shatokhin wrote:
Hi,
I have recently found several data races in usbnet module, checked on
vanilla kernel 4.1.0 on x86_64. The races do actually happen, I have
confirmed it by adding delays and using hardware
The commit a50dad355a53 (net: macb: Add big endian CPU support) converted I/O
accessors to readl_relaxed() and writel_relaxed() and consequentially broke
MACB driver on AVR32 platforms such as ATNGW100.
This patch improves I/O access by checking endiannes first and use the
corresponding methods.
This patch coverts struct description to the kernel doc format. There is no
functional change.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
include/linux/platform_data/macb.h | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git
This patch fixes the following warnings:
drivers/net/ethernet/cadence/macb.c: In function ‘macb_handle_link_change’:
drivers/net/ethernet/cadence/macb.c:266: warning: comparison between signed and
unsigned
drivers/net/ethernet/cadence/macb.c:267: warning: comparison between signed and
unsigned
It seems no one had tested recently the driver on AVR32 platforms such as
ATNGW100. This series bring it back to work.
Andy Shevchenko (6):
net/macb: improve big endian CPU support
net/macb: check if macb_config present
net/macb: use dev_*() when netdev is not yet registered
net/macb:
macb_count_tx_descriptors() repeats the generic macro DIV_ROUND_UP(). The patch
does a replacement.
There is no functional change.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/net/ethernet/cadence/macb.c | 10 ++
1 file changed, 2 insertions(+), 8
The commit 98b5a0f4a228 introduces jumbo frame support, but also it assumes
that macb_config present which is not always true.
The configuration without macb_config fails to boot.
Unable to handle kernel NULL pointer dereference at virtual address 0010
ptbr = 9035 pgd =
Oops:
To avoid messages like
macb macb.0 (unnamed net_device) (uninitialized): Cadence caps 0x
macb macb.0 (unnamed net_device) (uninitialized): invalid hw address, using
random
let's use dev_*() macros.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
-Original Message-
From: Joe Perches [mailto:j...@perches.com]
On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote:
This introduces the Freescale Data Path Acceleration Architecture
(DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan,
BMan, PAMU and FMan drivers to
On 7/24/15, 3:28 AM, Nicolas Dichtel wrote:
It saves some lines and simplify a bit the code when the state is returning
by this function. It's also useful to handle a NULL entry.
To avoid too long lines, I've also renamed lwtunnel_state_get() and
lwtunnel_state_put() to lwtstate_get() and
Le 24/07/2015 15:50, roopa a écrit :
On 7/24/15, 5:24 AM, Nicolas Dichtel wrote:
Sure, but my goal was to not create a new .h file just for these two helpers.
It's related to lwtunnel, thus I was thinking they can go here.
ok..., since your lwt namespace functions went into net_namespace.c, I
This patch asserts SGMII RTRESET, i.e. resetting the SGMII Tx/Rx
logic, during network interface shutdown to avoid having the
hardware wedge when shutting down with high incoming traffic rates.
This is cleared (brought out of RTRESET) when the interface is
brought back up.
Signed-off-by:
On Fri, Jul 24, 2015 at 02:56:29PM +0800, Xin Long wrote:
RFC 5061:
This is an opaque integer assigned by the sender to identify each
request parameter. The receiver of the ASCONF Chunk will copy this
32-bit value into the ASCONF Response Correlation ID field of the
On Fri, Jul 24, 2015 at 11:18 AM, Jinpu Wang
jinpu.w...@profitbricks.com wrote:
I hit bug in OFED, I report to link below:
http://marc.info/?l=linux-rdmam=143634872328553w=2
I checked latest mainline Linux 4.2-rc3, it has similar bug.
Here is the patch against Linux 4.2-rc3, compile test only.
It is a prep work for the next patch to remove write_lock
from rt6_probe().
1. Reduce the number of if(neigh) check. From 4 to 1.
2. Bring the write_(un)lock() closer to the operations that the
lock is protecting.
Hopefully, the above make rt6_probe() more readable.
Signed-off-by: Martin
The patch checks neigh-nud_state before acquiring the writer lock.
Note that rt6_probe() is only used in CONFIG_IPV6_ROUTER_PREF.
40 udpflood processes and a /64 gateway route are used.
The gateway has NUD_PERMANENT. Each of them is run for 30s.
At the end, the total number of finished sendto():
v1 - v2:
1. Separate the code re-arrangement into another patch
2. Fix style
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Vineet Gupta vineet.gup...@synopsys.com writes:
There's already a generic implementation so use that instead.
---
I'm not sure if the driver usage of atomic_or?() is correct in terms of
storage size of @val for 64 bit arches.
Assuming LP64 programming model for linux on say x86_64:
On Sat, Jul 25, 2015 at 3:11 AM, Marcelo Ricardo Leitner
mleit...@redhat.com wrote:
On Fri, Jul 24, 2015 at 02:56:29PM +0800, Xin Long wrote:
RFC 5061:
This is an opaque integer assigned by the sender to identify each
request parameter. The receiver of the ASCONF Chunk will copy this
RFC 5061:
This is an opaque integer assigned by the sender to identify each
request parameter. The receiver of the ASCONF Chunk will copy this
32-bit value into the ASCONF Response Correlation ID field of the
ASCONF-ACK response parameter. The sender of the ASCONF can use this
From: Nicolas Schichan nschic...@freebox.fr
Date: Tue, 21 Jul 2015 14:16:37 +0200
This serie adds support for more instructions to the ARM BPF JIT
series
namely skb netdevice type retrieval, skb payload offset retrieval, and
skb packet type retrieval.
This allows 35 tests to use the JIT
From: Julian Anastasov j...@ssi.bg
Date: Wed, 22 Jul 2015 10:43:21 +0300
This patchset contains 2 changes for the alternative routes,
one to add tb_id/fa_slen check needed after the recent
fib_trie optimizations for fib aliases and the second
change attempts to support alternative routes with
From: Cong Wang xiyou.wangc...@gmail.com
Date: Tue, 21 Jul 2015 16:31:53 -0700
Otherwise the skbuff related structures are not correctly
refcount'ed.
Cc: Jamal Hadi Salim j...@mojatatu.com
Signed-off-by: Cong Wang xiyou.wangc...@gmail.com
Applied.
--
To unsubscribe from this list: send the
From: Rami Rosen rami.ro...@intel.com
Date: Wed, 22 Jul 2015 07:57:02 +0300
This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range()
method. The
assignment of vinfo.flags = ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and
is
unneeded, as vinfo.flags value is overriden by
From: Cong Wang xiyou.wangc...@gmail.com
Date: Tue, 21 Jul 2015 16:52:43 -0700
Signed-off-by: Cong Wang xiyou.wangc...@gmail.com
Applied.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On 7/24/15, 1:59 AM, Nicolas Dichtel wrote:
This function make sense only when LWTUNNEL_STATE_OUTPUT_REDIRECT is set.
The check is already done in IPv4.
CC: Thomas Graf tg...@suug.ch
CC: Roopa Prabhu ro...@cumulusnetworks.com
Fixes: 74a0f2fe8ed5 (ipv6: rt6_info output redirect to tunnel output)
On 7/24/15, 3:28 AM, Nicolas Dichtel wrote:
We need to copy this field (ip6_rt_cache_alloc() and ip6_rt_pcpu_alloc()
use ip6_rt_copy_init() to build a dst).
CC: Thomas Graf tg...@suug.ch
CC: Roopa Prabhu ro...@cumulusnetworks.com
Fixes: 19e42e451506 (ipv6: support for fib route lwtunnel encap
From: Nikolay Aleksandrov niko...@cumulusnetworks.com
num_grat_arp wasn't converted to the new bonding option API, so do this
now and remove the specific sysfs store option in order to use the
standard one. num_grat_arp is the same as num_unsol_na so add it as an
alias with the same option
On 7/24/15, 5:24 AM, Nicolas Dichtel wrote:
Sure, but my goal was to not create a new .h file just for these two
helpers.
It's related to lwtunnel, thus I was thinking they can go here.
ok..., since your lwt namespace functions went into net_namespace.c, I
was thinking
these should really go
Replace 2 arguments (cnt and rtt) in the congestion control modules'
pkts_acked() function with a struct. This will allow adding more
information without having to modify existing congestion control
modules (tcp_nv in particular needs bytes in flight when packet
was sent).
As proposed by Neal
This patchset adds support for NV congestion control.
The first patch replaces two arguments with a struct in pkts_acked()
The second patch is a refactor of tcp_skb_cb
The third patch adds in_flight to tcp_skb_cb's tx section
The fourth patch adds NV congestion control support.
[RFC PATCH v4
This is a request for comments.
TCP-NV (New Vegas) is a major update to TCP-Vegas.
An earlier version of NV was presented at 2010's LPC.
It is a delayed based congestion avoidance for the
data center. This version has been tested within a
10G rack where the HW RTTs are 20-50us.
A description of
Refactor tcp_skb_cb to create two overlaping areas to store
state for incoming or outgoing skbs based on comments by
Neal Cardwell to tcp_nv patch:
AFAICT this patch would not require an increase in the size of
sk_buff cb[] if it were to take advantage of the fact that the
tcp_skb_cb
Add in_flight (bytes in flight when packet was sent) field
to tx component of tcp_skb_cb and make it available to
congestion modules' pkts_acked() function through the
ack_sample function argument.
Signed-off-by: Lawrence Brakmo bra...@fb.com
---
include/net/tcp.h | 2 ++
On Fri, Jul 24, 2015 at 07:24:53AM +0200, Jiri Pirko wrote:
Thu, Jul 23, 2015 at 11:12:20PM CEST, go...@cumulusnetworks.com wrote:
On Thu, Jul 23, 2015 at 05:43:35PM +0200, Jiri Pirko wrote:
From: Ido Schimmel ido...@mellanox.com
Add the ability to construct mailbox-style register access
Le 23/07/2015 17:50, roopa a écrit :
On 7/23/15, 8:25 AM, Nicolas Dichtel wrote:
Le 23/07/2015 17:01, roopa a écrit :
On 7/23/15, 7:22 AM, Nicolas Dichtel wrote:
[snip]
+static inline u32 *lwt_netns_info(struct lwtunnel_state *lwtstate)
+{
+return (u32 *)lwtstate-data;
+}
+
+static
67 matches
Mail list logo
