[PATCH v2 net-next 4/4] bnx2fc: Read npiv table from nvram and create vports.

2015-08-03 Thread Yuval Mintz
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Chad Dupuis Signed-off-by: Yuval Mintz --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bn

[PATCH v2 net-next 2/4] cnic: Add the interfaces to get FC-NPIV table.

2015-08-03 Thread Yuval Mintz
From: Adheer Chandravanshi Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis Signed-off-by: Yuval Mintz --- drivers/net/ethernet/broadcom/cnic.c| 18 ++ drivers/net/ethernet/broadcom/cnic_if.h | 16 ++-- 2 files changed, 32 insertions(+), 2 deletio

[PATCH v2 net-next 3/4] bnx2x: Add BD support for storage

2015-08-03 Thread Yuval Mintz
Commit 230d00eb4bfe ("bnx2x: new Multi-function mode - BD") adds support for the new mode in bnx2x. This expands this support by implementing APIs required by our storage drivers to support that mode. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h| 12 +++ ...

[PATCH v2 net-next 0/4] bnx2x, cnic, bnx2fc: add support for BD

2015-08-03 Thread Yuval Mintz
Commit 230d00eb4bfe ("bnx2x: new Multi-function mode - BD") added support for a new multi-function mode, but it added only the support required by bnx2x for L2 interfaces. This adds the required changes to support the new multi-function mode in the offloaded storage protocols. Dave, Please consi

[PATCH v2 net-next 1/4] cnic: Populate upper layer driver state in MFW

2015-08-03 Thread Yuval Mintz
From: Tej Parkash Signed-off-by: Tej Parkash Signed-off-by: Yuval Mintz --- drivers/net/ethernet/broadcom/cnic.c| 18 +++--- drivers/net/ethernet/broadcom/cnic_if.h | 5 + 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/cnic.c

[PATCH net] net: dsa: fix EDSA frame from hwaccel frame

2015-08-03 Thread Vivien Didelot
If the underlying network device features NETIF_F_HW_VLAN_CTAG_TX, an EDSA frame is prepended with a 802.1q header once queued. To fix this, push the VLAN tag to the payload if present, before checking the frame protocol. [note: we may prefer to access directly VLAN TCI from hwaccel frames, but t

[PATCH net-next 4/4] net: dsa: mv88e6xxx: refactor FDB routines

2015-08-03 Thread Vivien Didelot
Refactor mv88e6xxx_port_fdb_{add,del,getnext} to respect the new DSA switch driver FDB access routines. The Marvell 88E6xxx switches support up to 4094 FIDs (from 1 to 0xfff; FID 0 means that multiple address databases are not being used). So change the fid_mask for a fid_bitmap of 4096 bits. FID

[PATCH net-next 0/4] net: dsa: support switchdev FDB objects

2015-08-03 Thread Vivien Didelot
This patchset refactors the DSA and mv88e6xxx code to use the switchdev FDB objects. The first two patches add minor but necessary changes to switchdev, the third one implements the switchdev glue in DSA for FDB routines, and the forth one refactors the FDB access functions in the mv88e6xxx code.

[PATCH net-next 2/4] net: switchdev: support static FDB addresses

2015-08-03 Thread Vivien Didelot
This patch adds a is_static boolean to the switchdev_obj_fdb structure, in order to set the ndm_state to either NUD_NOARP or NUD_REACHABLE. Signed-off-by: Vivien Didelot --- include/net/switchdev.h | 1 + net/switchdev/switchdev.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff -

[PATCH net-next 3/4] net: dsa: add support for switchdev FDB objects

2015-08-03 Thread Vivien Didelot
Remove the fdb_{add,del,getnext} function pointer in favor of new port_fdb_{add,del,getnext}. Implement the switchdev_port_obj_{add,del,dump} functions in DSA to support the SWITCHDEV_OBJ_PORT_FDB objects. These functions are called from switchdev_port_bridge_{get,set,del}link. Signed-off-by: Vi

[PATCH net-next 1/4] net: switchdev: change fdb addr for a byte array

2015-08-03 Thread Vivien Didelot
The address in the switchdev_obj_fdb structure is currently represented as a pointer. Replacing it for a 6-byte array allows switchdev to carry addresses directly read from hardware registers, not stored by the switch chip driver (as in Rocker). Signed-off-by: Vivien Didelot --- drivers/net/ethe

Re: [PATCH] net: dsa: fix EDSA frame from hwaccel frame

2015-08-03 Thread David Miller
From: Vivien Didelot Date: Tue, 4 Aug 2015 02:01:18 -0400 (EDT) > Dully noted. Should I resend it? Yes, please. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: net: dsa: support switchdev FDB objects

2015-08-03 Thread Vivien Didelot
Hi, On Aug 4, 2015, at 1:54 AM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: > This patchset refactors the DSA and mv88e6xxx code to use the switchdev FDB > objects. > > The first two patches add minor but necessary changes to switchdev, the third > one implements the switchdev glu

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Alexei Starovoitov
On Mon, Aug 03, 2015 at 10:58:02PM -0700, Pravin Shelar wrote: > >> > feature detection based on netdev name? > >> > meaning that there will be only one such device for the whole > >> > host? and namespaces cannot have their own gre tunnels? > >> > (since host 'gretap0' cannot be seen in netns) > >

Re: [PATCH] net: dsa: fix EDSA frame from hwaccel frame

2015-08-03 Thread Vivien Didelot
Hi David, On Aug 4, 2015, at 1:21 AM, David da...@davemloft.net wrote: > From: Vivien Didelot > Date: Sun, 2 Aug 2015 21:46:02 -0400 > >> If the underlying network device features NETIF_F_HW_VLAN_CTAG_TX, >> an EDSA frame is prepended with a 802.1q header once queued. >> >> To fix this, push

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Pravin Shelar
On Mon, Aug 3, 2015 at 10:54 PM, Alexei Starovoitov wrote: > On Mon, Aug 03, 2015 at 10:51:02PM -0700, Pravin Shelar wrote: >> On Mon, Aug 3, 2015 at 9:23 PM, Alexei Starovoitov >> wrote: >> > On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote: >> >> With addition of flow based tunne

[PATCH 1/4] net: switchdev: change fdb addr for a byte array

2015-08-03 Thread Vivien Didelot
The address in the switchdev_obj_fdb structure is currently represented as a pointer. Replacing it for a 6-byte array allows switchdev to carry addresses directly read from hardware registers, not stored by the switch chip driver (as in Rocker). Signed-off-by: Vivien Didelot --- drivers/net/ethe

[PATCH 3/4] net: dsa: add support for switchdev FDB objects

2015-08-03 Thread Vivien Didelot
Remove the fdb_{add,del,getnext} function pointer in favor of new port_fdb_{add,del,getnext}. Implement the switchdev_port_obj_{add,del,dump} functions in DSA to support the SWITCHDEV_OBJ_PORT_FDB objects. These functions are called from switchdev_port_bridge_{get,set,del}link. Signed-off-by: Vi

[PATCH 2/4] net: switchdev: support static FDB addresses

2015-08-03 Thread Vivien Didelot
This patch adds a is_static boolean to the switchdev_obj_fdb structure, in order to set the ndm_state to either NUD_NOARP or NUD_REACHABLE. Signed-off-by: Vivien Didelot --- include/net/switchdev.h | 1 + net/switchdev/switchdev.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff -

net: dsa: support switchdev FDB objects

2015-08-03 Thread Vivien Didelot
This patchset refactors the DSA and mv88e6xxx code to use the switchdev FDB objects. The first two patches add minor but necessary changes to switchdev, the third one implements the switchdev glue in DSA for FDB routines, and the forth one refactors the FDB access functions in the mv88e6xxx code.

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Pravin Shelar
On Mon, Aug 3, 2015 at 9:59 PM, David Miller wrote: > From: Alexei Starovoitov > Date: Mon, 3 Aug 2015 21:23:40 -0700 > >> On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote: >>> With addition of flow based tunneling, there is no need to >>> have special GRE vport. Removes all of the

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Alexei Starovoitov
On Mon, Aug 03, 2015 at 10:51:02PM -0700, Pravin Shelar wrote: > On Mon, Aug 3, 2015 at 9:23 PM, Alexei Starovoitov > wrote: > > On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote: > >> With addition of flow based tunneling, there is no need to > >> have special GRE vport. Removes all

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Pravin Shelar
On Mon, Aug 3, 2015 at 9:23 PM, Alexei Starovoitov wrote: > On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote: >> With addition of flow based tunneling, there is no need to >> have special GRE vport. Removes all of the OVS specific >> GRE code and make OVS use a ip_gre net_device. >>

Re: [PATCH net-next] mpls: Use definition for reserved label checks

2015-08-03 Thread David Miller
From: Robert Shearman Date: Mon, 3 Aug 2015 17:50:04 +0100 > In multiple locations there are checks for whether the label in hand > is a reserved label or not using the arbritray value of 16. Factor > this out into a #define for better maintainability and for > documentation. > > Signed-off-by:

Re: BUG: null dereference in __skb_recv_datagram

2015-08-03 Thread Brenden Blanco
> [ 318.244596] BUG: unable to handle kernel NULL pointer dereference > at 008e > [ 318.245182] IP: [] __skb_recv_datagram+0xbc/0x5a0 Replying to myself, and adding commit interested parties... I went through the git log for the function in question, and positively identified that t

Re: [PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-08-03 Thread Stephen Hemminger
On Tue, 4 Aug 2015 13:28:47 +1200 Richard Laing wrote: > diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h > index 5fa643b..7db9f72 100644 > --- a/include/net/ip_fib.h > +++ b/include/net/ip_fib.h > @@ -117,6 +117,8 @@ struct fib_info { > #ifdef CONFIG_IP_ROUTE_MULTIPATH > int

[PATCH v2 net-next 1/2] RDS-TCP: Make RDS-TCP work correctly when it is set up in a netns other than init_net

2015-08-03 Thread Sowmini Varadhan
Open the sockets calling sock_create_kern() with the correct struct net pointer, and use that struct net pointer when verifying the address passed to rds_bind(). Signed-off-by: Sowmini Varadhan --- v2: David Ahern comments. net/rds/bind.c|3 ++- net/rds/connection.c | 16

[PATCH v2 net-next 0/2] RDS-TCP: Network namespace support

2015-08-03 Thread Sowmini Varadhan
This patch series contains the set of changes to correctly set up the infra for PF_RDS sockets that use TCP as the transport in multiple network namespaces. Patch 1 in the series is the minimal set of changes to allow a single instance of RDS-TCP to run in any (i.e init_net or other) net namespac

[PATCH v2 net-next 2/2] RDS-TCP: Support multiple RDS-TCP listen endpoints, one per netns.

2015-08-03 Thread Sowmini Varadhan
Register pernet subsys init/stop functions that will set up and tear down per-net RDS-TCP listen endpoints. Unregister pernet subusys functions on 'modprobe -r' to clean up these end points. Enable keepalive on both accept and connect socket endpoints. The keepalive timer expiration will ensure th

[PATCH net-next 2/2] rocker: use netdev_err after register_netdev

2015-08-03 Thread sfeldma
From: Scott Feldman After successful register_netdev, we can use netdev_err rather the more generic dev_err. Signed-off-by: Scott Feldman --- drivers/net/ethernet/rocker/rocker.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/rocker/rocker.c b/driv

[PATCH net-next 1/2] rocker: NULL port if port probe fails

2015-08-03 Thread sfeldma
From: Scott Feldman Set port to NULL if port probe fails so we don't try to remove partially initialized port on port probe err cleanup path. Signed-off-by: Scott Feldman --- drivers/net/ethernet/rocker/rocker.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/rocker

Re: [PATCH net-next 0/2] lwtunnel: encap locally-generated ipv4 packets

2015-08-03 Thread David Miller
From: Robert Shearman Date: Mon, 3 Aug 2015 17:39:19 +0100 > Locally-generated IPv4 packets, such as from applications running on > the host or traceroute/ping currently don't have lwtunnel output > redirected encap applied. However, they should do in the same way as > for forwarded packets and t

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread David Miller
From: Lucas Stach Date: Mon, 3 Aug 2015 17:50:11 +0200 > The clocks are initially active and thus the device is marked active. > This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() > call at the end of probe then leaves us with an invalid refcount of -1, > which in turn leads

Re: [PATCH] net: dsa: fix EDSA frame from hwaccel frame

2015-08-03 Thread David Miller
From: Vivien Didelot Date: Sun, 2 Aug 2015 21:46:02 -0400 > If the underlying network device features NETIF_F_HW_VLAN_CTAG_TX, > an EDSA frame is prepended with a 802.1q header once queued. > > To fix this, push the VLAN tag to the payload if present, before > checking the frame protocol. > >

Re: [PATCH] xen-netback: Allocate fraglist early to avoid complex rollback

2015-08-03 Thread David Miller
From: Ross Lagerwall Date: Mon, 3 Aug 2015 15:38:03 +0100 > Determine if a fraglist is needed in the tx path, and allocate it if > necessary before setting up the copy and map operations. > Otherwise, undoing the copy and map operations is tricky. > > This fixes a use-after-free: if allocating t

Re: [PATCH net] udp: fix dst races with multicast early demux

2015-08-03 Thread David Miller
From: Eric Dumazet Date: Sat, 01 Aug 2015 12:14:33 +0200 > From: Eric Dumazet > > Multicast dst are not cached. They carry DST_NOCACHE. > > As mentioned in commit f8864972126899 ("ipv4: fix dst race in > sk_dst_get()"), these dst need special care before caching them > into a socket. > > Cach

[PATCH net-next] net_sched: act_bpf: remove spinlock in fast path

2015-08-03 Thread Alexei Starovoitov
Similar to act_gact/act_mirred, act_bpf can be lockless in packet processing. Also similar to gact/mirred there is a race between prog->filter and prog->tcf_action. Meaning that the program being replaced may use previous default action if it happened to return TC_ACT_UNSPEC. act_mirred race betwe

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread David Miller
From: Alexei Starovoitov Date: Mon, 3 Aug 2015 21:23:40 -0700 > On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote: >> With addition of flow based tunneling, there is no need to >> have special GRE vport. Removes all of the OVS specific >> GRE code and make OVS use a ip_gre net_devic

Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-03 Thread David Miller
From: Joe Perches Date: Mon, 03 Aug 2015 21:02:21 -0700 > On Mon, 2015-08-03 at 20:57 -0700, Joe Perches wrote: >> On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote: >> > This patch replaces calls to net_dbg_ratelimited when !DEBUG with >> > no_printk, keeping with the idiom of all the

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Alexei Starovoitov
On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote: > With addition of flow based tunneling, there is no need to > have special GRE vport. Removes all of the OVS specific > GRE code and make OVS use a ip_gre net_device. > Minimal GRE vport is kept to handle compatibility with > current

[PATCH net-next v2] openvswitch: Make 100 percents packets sampled when sampling rate is 1.

2015-08-03 Thread Wenyu Zhang
When sampling rate is 1, the sampling probability is UINT32_MAX. The packet should be sampled even the prandom_u32() generate the number of UINT32_MAX. And none packet need be sampled when the probability is 0. Signed-off-by: Wenyu Zhang --- net/openvswitch/actions.c |4 +++- 1 file changed,

Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-03 Thread Joe Perches
On Mon, 2015-08-03 at 20:57 -0700, Joe Perches wrote: > On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote: > > This patch replaces calls to net_dbg_ratelimited when !DEBUG with > > no_printk, keeping with the idiom of all the other debug print helpers. > > Makes sense, thanks Jason. Per

Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-03 Thread Joe Perches
On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote: > The pr_debug family of functions turns into a no-op when -DDEBUG is not > specified, opting instead to call "no_printk", which gets compiled to a > no-op (but retains gcc's nice warnings about printf-style arguments). > > The problem w

[PATCHv2 net-next 0/4] add meminfo, bist status and misc. fixes

2015-08-03 Thread Hariprasad Shenai
Hi, This patch series adds the following. Add support to dump memory address range of various hw modules Add support to dump edc bist status during ecc error Read correct bits of who am i register for T6 adapter and update T6 register range This patch series has been created against net-next tree

[PATCHv2 net-next 4/4] cxgb4: Update T6 register ranges

2015-08-03 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index 5c63ceb..91750ad 100644 -

[PATCHv2 net-next 2/4] cxgb4: Add support to dump edc bist status

2015-08-03 Thread Hariprasad Shenai
Add support to dump edc bist status for ECC data errors Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 39 drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 5 ++-- 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/dri

[PATCHv2 net-next 1/4] cxgb4: Add debugfs support to dump meminfo

2015-08-03 Thread Hariprasad Shenai
Add debug support to dump memory address ranges of various hardware modules of the adapter. Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 285 + drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 122 + 2 files changed, 40

[PATCHv2 net-next 3/4] cxgb4/cxgb4vf: read the correct bits of PL Who Am I register

2015-08-03 Thread Hariprasad Shenai
Read the correct bits of PL Who Am I for the Source PF field which has changed in T6 Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 34 - drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 8 -- drivers/net/ethernet/chelsio/cxgb

[PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-03 Thread Jason A. Donenfeld
The pr_debug family of functions turns into a no-op when -DDEBUG is not specified, opting instead to call "no_printk", which gets compiled to a no-op (but retains gcc's nice warnings about printf-style arguments). The problem with net_dbg_ratelimited is that it is defined to be a variant of net_ra

BUG: null dereference in __skb_recv_datagram

2015-08-03 Thread Brenden Blanco
Hi Folks, I just hit this one off of latest net-next tree, git hash 58da018053531b9cb91423a64f2a762ef0fe7456 I was running a set of tests from pyroute2 project: https://github.com/svinota/pyroute2 A simple `sudo make test skip_tests=test_stress` in there hits the issue every time. [ 318.244596

[PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-08-03 Thread Richard Laing
Enable flow-based ECMP. Currently if equal-cost multipath is enabled the kernel chooses between equal cost paths for each matching packet, essentially packets are round-robined between the routes. This means that packets from a single flow can traverse different routes. If one of the routes experi

[PATCH net-next v2 2/2] gre: Remove support for sharing GRE protocol hook.

2015-08-03 Thread Pravin B Shelar
Support for sharing GREPROTO_CISCO port was added so that OVS gre port and kernel GRE devices can co-exist. After flow-based tunneling patches OVS GRE protocol processing is completely moved to ip_gre module. so there is no need for GRE protocol hook. Following patch consolidates GRE protocol relat

[PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Pravin B Shelar
With addition of flow based tunneling, there is no need to have special GRE vport. Removes all of the OVS specific GRE code and make OVS use a ip_gre net_device. Minimal GRE vport is kept to handle compatibility with current userspace application. Signed-off-by: Pravin B Shelar --- include/net/g

[PATCH net-next v2 0/2] GRE: Use flow based tunneling for OVS GRE vport.

2015-08-03 Thread Pravin B Shelar
Following patches make use of new flow based tunneling API from kernel. This allows us to directly use netdev based GRE tunnel implementation. While doing so I have removed GRE demux API which were targeted for OVS. Most of GRE protocol code is now consolidated in ip_gre module. Pravin B Shelar (2

Re:

2015-08-03 Thread Pravin Shelar
Somehow subject line got dropped, I am resending these patches. On Mon, Aug 3, 2015 at 3:58 PM, Pravin B Shelar wrote: > Following patches make use of new flow based tunneling > API from kernel. This allows us to directly use netdev > based GRE tunnel implementation. While doing so I have > remov

Re: [PATCH] fddi: Use a more more typical logging style

2015-08-03 Thread Joe Perches
On Mon, 2015-08-03 at 16:05 -0700, David Miller wrote: > From: Joe Perches > Date: Sun, 02 Aug 2015 21:27:45 -0700 > > > Use macros that don't require fixed argument counts so > > format and arguments can be verified by the compiler. > > > > Miscellanea: > > > > o Remove a few #if uses to allow

Re: [PATCH net-next] bridge: mdb: fix vlan_enabled access when vlans are not configured

2015-08-03 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 4 Aug 2015 01:19:58 +0200 > From: Nikolay Aleksandrov > > Instead of trying to access br->vlan_enabled directly use the provided > helper br_vlan_enabled(). > > Signed-off-by: Nikolay Aleksandrov Applied. -- To unsubscribe from this list: send the line "

[PATCH net-next] bridge: mdb: fix vlan_enabled access when vlans are not configured

2015-08-03 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Instead of trying to access br->vlan_enabled directly use the provided helper br_vlan_enabled(). Signed-off-by: Nikolay Aleksandrov --- Sorry, forgot to change this before sending the patch. net/bridge/br_mdb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

Re: [PATCH net-next 1/1] e1000: remove dead e1000_init_eeprom_params calls.

2015-08-03 Thread Jeff Kirsher
On Fri, Jul 24, 2015 at 2:40 PM, Francois Romieu wrote: > The device probe method e1000_probe calls e1000_init_eeprom_params > itself so there's no reason to call it again from e1000_do_write_eeprom > or e1000_do_read_eeprom. > > The sentence above assumes that e1000_init_eeprom_params is effectiv

Re: [PATCH net-next] act_bpf: properly support late binding of bpf action to a classifier

2015-08-03 Thread David Miller
From: Daniel Borkmann Date: Mon, 3 Aug 2015 16:21:57 +0200 > Since the introduction of the BPF action in d23b8ad8ab23 ("tc: add BPF > based action"), late binding was not working as expected. I.e. setting > the action part for a classifier only via 'bpf index ', where > is the index of an exist

Re: [PATCH] fddi: Use a more more typical logging style

2015-08-03 Thread David Miller
From: Joe Perches Date: Sun, 02 Aug 2015 21:27:45 -0700 > Use macros that don't require fixed argument counts so > format and arguments can be verified by the compiler. > > Miscellanea: > > o Remove a few #if uses to allow dynamic debug to always work > o whitespace neatening > > Signed-off-by

[PATCH 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Pravin B Shelar
With addition of flow based tunneling, there is no need to have special GRE vport. Removes all of the OVS specific GRE code and make OVS use a ip_gre net_device. Minimal GRE vport is kept to handle compatibility with current userspace application. Signed-off-by: Pravin B Shelar --- include/net/g

[net-next:master 173/173] net/bridge/br_mdb.c:493:8: error: 'struct net_bridge' has no member named 'vlan_enabled'

2015-08-03 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: e44deb2f0cce9183ca94d14effd4170a35eec31d commit: e44deb2f0cce9183ca94d14effd4170a35eec31d [173/173] bridge: mdb: add/del entry on all vlans if vlan_filter is enabled and vid is 0 config: sh-titan_defconfig (att

[PATCH 2/2] gre: Remove support for sharing GRE protocol hook.

2015-08-03 Thread Pravin B Shelar
Support for sharing GREPROTO_CISCO port was added so that OVS gre port and kernel GRE devices can co-exist. After flow-based tunneling patches OVS GRE protocol processing is completely moved to ip_gre module. so there is no need for GRE protocol hook. Following patch consolidates GRE protocol relat

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-08-03 Thread Joe Stringer
On 31 July 2015 at 19:08, Pravin Shelar wrote: > On Thu, Jul 30, 2015 at 11:12 AM, Joe Stringer wrote: >> +static void prepare_frag(struct vport *vport, struct sw_flow_key *key, >> +struct sk_buff *skb) >> +{ >> + unsigned int hlen = ETH_HLEN; >> + struct ovs_f

[no subject]

2015-08-03 Thread Pravin B Shelar
Following patches make use of new flow based tunneling API from kernel. This allows us to directly use netdev based GRE tunnel implementation. While doing so I have removed GRE demux API which were targeted for OVS. Most of GRE protocol code is now consolidated in ip_gre module. Pravin B Shelar (2

Re: [PATCH 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-08-03 Thread Jeff Kirsher
On Wed, 2015-07-29 at 14:31 -0700, David Miller wrote: > From: Alex Williamson > Date: Wed, 29 Jul 2015 13:33:07 -0600 > > > I expect that's because of this patch that's in Jeff's dev-queue branch: > > > > http://git.kernel.org/cgit/linux/kernel/git/jkirsher/next-queue.git/commit/?h=dev-queue&id

Re: [PATCH] net: dsa: mv88e6xxx: call _mv88e6xxx_stats_wait with SMI lock held

2015-08-03 Thread David Miller
From: Vivien Didelot Date: Mon, 3 Aug 2015 09:17:44 -0400 > At switch setup, _mv88e6xxx_stats_wait was called without holding the > SMI mutex. Fix this by requesting the lock for this call. > > Also, return the _mv88e6xxx_stats_wait code, since it may fail. > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next] bridge: mdb: add/del entry on all vlans if vlan_filter is enabled and vid is 0

2015-08-03 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 3 Aug 2015 13:29:16 +0200 > From: Satish Ashok > > Before this patch when a vid was not specified, the entry was added with > vid 0 which is useless when vlan_filtering is enabled. This patch makes > the entry to be added on all configured vlans when vlan f

RE: [PATCH net] udp: fix dst races with multicast early demux

2015-08-03 Thread Gregory Hoggarth
Hi, I have included this patch into my code and re-run our tests overnight, out of 644 iterations we did not see the kernel crash. Previous reproduction rate we would have expected 4-6 crashes in this time. So I think this fixes the issue we are seeing. Thanks, Greg __

RX overrun errors building on several of our hosts

2015-08-03 Thread Dan Finn
After implementing a new monitoring tool I've noticed that several of our physical servers have increasing RX errors, all seem to be classified as overruns. The interfaces are Broadcom Corporation BCM57840 NetXtreme II 10 Gigabit Ethernet (rev 11) and we are using the bnx2x driver.  The are co

Re: [PATCH] 3c59x: Fix resource leaks in vortex_open

2015-08-03 Thread David Miller
From: Jia-Ju Bai Date: Mon, 3 Aug 2015 11:18:12 +0800 > When vortex_up is failed, the skb buffers allocated by __netdev_alloc_skb > in vortex_open are not released, which may cause resource leaks. > This bug has been submitted before. > This patch modifies the error handling code to fix it. > >

Re: [patch] rds: fix an integer overflow test in rds_info_getsockopt()

2015-08-03 Thread David Miller
From: Dan Carpenter Date: Sat, 1 Aug 2015 15:33:26 +0300 > "len" is a signed integer. We check that len is not negative, so it > goes from zero to INT_MAX. PAGE_SIZE is unsigned long so the comparison > is type promoted to unsigned long. ULONG_MAX - 4095 is a higher than > INT_MAX so the condi

Re: [PATCH] Add BQL support for 3c59x, based on patch from Tino Reichardt.

2015-08-03 Thread David Miller
From: Loganaden Velvindron Date: Fri, 31 Jul 2015 23:13:13 -0700 > Tested on 3Com PCI 3c905C Tornardo by running Flent multiple times. > > Signed-off-by: Loganaden Velvindron Please format your Subject line correctly, it should be of the form: [PATCH $TREE] $SUBSYSTEM: $DESCRIPTION.

Re: [PATCH] r8169: Permit users to change transmit and receive max pachet size

2015-08-03 Thread David Miller
From: "Corcodel.marian" Date: Tue, 04 Aug 2015 00:41:50 +0300 > A this moment these param is only for test and not for large utilization. Then you can patch your local driver for "testing". You change doesn't belong upstream. We're not going to litter drivers with debugging hack options. -- To

Re: [PATCH net-next] mpls: Use definition for reserved label checks

2015-08-03 Thread roopa
On 8/3/15, 9:50 AM, Robert Shearman wrote: In multiple locations there are checks for whether the label in hand is a reserved label or not using the arbritray value of 16. Factor this out into a #define for better maintainability and for documentation. Signed-off-by: Robert Shearman --- Acked

Re: [PATCH net-next 0/2] lwtunnel: encap locally-generated ipv4 packets

2015-08-03 Thread roopa
On 8/3/15, 9:39 AM, Robert Shearman wrote: Locally-generated IPv4 packets, such as from applications running on the host or traceroute/ping currently don't have lwtunnel output redirected encap applied. However, they should do in the same way as for forwarded packets and this patch series address

Re: [PATCH net-next 0/4] Stacked vlan TSO for virtual devices

2015-08-03 Thread David Miller
From: Toshiaki Makita Date: Fri, 31 Jul 2015 15:03:23 +0900 > Basically virtual devices do not need to segment double tagged packets. > This patch set adds TSO feature for double tagged packets to several > virtual devices, which can be realized by simply setting > .ndo_features_check to passthru

Re: [PATCH net-next] virtio_net: add gro capability

2015-08-03 Thread David Miller
From: Eric Dumazet Date: Fri, 31 Jul 2015 18:25:17 +0200 > From: Eric Dumazet > > Straightforward patch to add GRO processing to virtio_net. > > napi_complete_done() usage allows more aggressive aggregation, > opted-in by setting /sys/class/net/xxx/gro_flush_timeout > > Tested: > > Setting /

Re: [patch net-next 1/2] rocker: enable support for scattered packets

2015-08-03 Thread David Miller
From: Jiri Pirko Date: Sun, 2 Aug 2015 20:56:37 +0200 > From: Ido Schimmel > > rocker supports the transmission of scattered packets, so let the kernel > know about it by setting the NETIF_F_SG bit in the device's features. > > Signed-off-by: Ido Schimmel > Signed-off-by: Jiri Pirko Applie

Re: [patch net-next 2/2] rocker: linearize skb in case frags would not fit into tx descriptor

2015-08-03 Thread David Miller
From: Jiri Pirko Date: Sun, 2 Aug 2015 20:56:38 +0200 > Suggested-by: Scott Feldman > Signed-off-by: Jiri Pirko Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/ma

Re: [PATCH net-next] vxlan: expose COLLECT_METADATA flag to user space

2015-08-03 Thread Jesse Gross
On Fri, Jul 31, 2015 at 8:41 AM, Alexei Starovoitov wrote: > thanks. I think exposing collect_metadata for vxlan and in the future > for other tunnel types is the clean enough way, though the other > alternative would be to get rid of collect_metadata flag > from the kernel and do it when flowmode

Re: [Patch net] act_mirred: avoid calling tcf_hash_release() when binding

2015-08-03 Thread David Miller
From: Cong Wang Date: Thu, 30 Jul 2015 17:12:20 -0700 > When we share an action within a filter, the bind refcnt > should increase, therefore we should not call tcf_hash_release(). > > Cc: Jamal Hadi Salim > Cc: Daniel Borkmann > Signed-off-by: Cong Wang > Signed-off-by: Cong Wang Applied,

Re: [PATCH] r8169: Permit users to change transmit and receive max pachet size

2015-08-03 Thread David Miller
From: "Corcodel.marian" Date: Tue, 04 Aug 2015 00:06:28 +0300 > Sorry bu these parameters is not covered by ethtool. Then simply add such a generic facility, so other drivers can benefit from it as well. I'll be completely honest, and say that I don't anticipate that you will implement the etht

Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments

2015-08-03 Thread David Miller
From: Glenn Griffin Date: Mon, 3 Aug 2015 09:56:54 -0700 > openvswitch modifies the L4 checksum of a packet when modifying > the ip address. When an IP packet is fragmented only the first > fragment contains an L4 header and checksum. Prior to this change > openvswitch would modify all fragments,

Re: [PATCH v2 net-next 1/6] net: fix sk_mem_reclaim_partial()

2015-08-03 Thread Jason Baron
On 05/15/2015 03:39 PM, Eric Dumazet wrote: > sk_mem_reclaim_partial() goal is to ensure each socket has > one SK_MEM_QUANTUM forward allocation. This is needed both for > performance and better handling of memory pressure situations in > follow up patches. > > SK_MEM_QUANTUM is currently a page

Re: [patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

2015-08-03 Thread Joe Stringer
On 3 August 2015 at 13:24, Pablo Neira Ayuso wrote: > On Mon, Aug 03, 2015 at 11:30:16AM -0700, Joe Stringer wrote: >> On 3 August 2015 at 11:29, Joe Stringer wrote: >> > On 30 July 2015 at 04:57, Pablo Neira Ayuso wrote: >> >> On Tue, Jul 28, 2015 at 01:42:28AM +0300, Dan Carpenter wrote: >> >>

Re: [patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

2015-08-03 Thread Pablo Neira Ayuso
On Mon, Aug 03, 2015 at 11:30:16AM -0700, Joe Stringer wrote: > On 3 August 2015 at 11:29, Joe Stringer wrote: > > On 30 July 2015 at 04:57, Pablo Neira Ayuso wrote: > >> On Tue, Jul 28, 2015 at 01:42:28AM +0300, Dan Carpenter wrote: > >>> We recently changed this from nf_conntrack_alloc() to nf_

Re: [patch net-next 2/2] rocker: linearize skb in case frags would not fit into tx descriptor

2015-08-03 Thread Scott Feldman
On Sun, Aug 2, 2015 at 11:56 AM, Jiri Pirko wrote: > Suggested-by: Scott Feldman > Signed-off-by: Jiri Pirko Acked-by: Scott Feldman -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: [patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

2015-08-03 Thread Joe Stringer
On 3 August 2015 at 11:29, Joe Stringer wrote: > On 30 July 2015 at 04:57, Pablo Neira Ayuso wrote: >> On Tue, Jul 28, 2015 at 01:42:28AM +0300, Dan Carpenter wrote: >>> We recently changed this from nf_conntrack_alloc() to nf_ct_tmpl_alloc() >>> so the error handling needs to changed to check fo

Re: [patch net-next 1/2] rocker: enable support for scattered packets

2015-08-03 Thread Scott Feldman
On Sun, Aug 2, 2015 at 11:56 AM, Jiri Pirko wrote: > From: Ido Schimmel > > rocker supports the transmission of scattered packets, so let the kernel > know about it by setting the NETIF_F_SG bit in the device's features. > > Signed-off-by: Ido Schimmel > Signed-off-by: Jiri Pirko Acked-by: Sco

Re: [ovs-dev] [PATCH v1] netdev: Make 100 percents packets sampled when sampling rate is 1.

2015-08-03 Thread Jesse Gross
On Mon, Aug 3, 2015 at 11:18 AM, Pravin Shelar wrote: > On Mon, Aug 3, 2015 at 12:11 AM, Wenyu Zhang wrote: >> When sampling rate is 1, the sampling probability is UINT32_MAX. The packet >> should be sampled even the prandom32() generate the number of UINT32_MAX. >> And none packet need be sample

Re: [patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

2015-08-03 Thread Joe Stringer
On 30 July 2015 at 04:57, Pablo Neira Ayuso wrote: > On Tue, Jul 28, 2015 at 01:42:28AM +0300, Dan Carpenter wrote: >> We recently changed this from nf_conntrack_alloc() to nf_ct_tmpl_alloc() >> so the error handling needs to changed to check for NULL instead of >> IS_ERR(). >> >> Fixes: 0838aa7fc

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread Alan Stern
On Mon, 3 Aug 2015, Uwe [iso-8859-1] Kleine-K�nig wrote: > Hello, > > I have no clue about runtime-pm, but I added a few people to Cc: who > should know better ... > > Best regards > Uwe > > On Mon, Aug 03, 2015 at 06:15:54PM +0200, Andrew Lunn wrote: > > On Mon, Aug 03, 2015 at 05:50:11PM +020

Re: [ovs-dev] [PATCH v1] netdev: Make 100 percents packets sampled when sampling rate is 1.

2015-08-03 Thread Pravin Shelar
On Mon, Aug 3, 2015 at 12:11 AM, Wenyu Zhang wrote: > When sampling rate is 1, the sampling probability is UINT32_MAX. The packet > should be sampled even the prandom32() generate the number of UINT32_MAX. > And none packet need be sampled when the probability is 0. > > Signed-off-by: Wenyu Zhang

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread Uwe Kleine-König
Hello, I have no clue about runtime-pm, but I added a few people to Cc: who should know better ... Best regards Uwe On Mon, Aug 03, 2015 at 06:15:54PM +0200, Andrew Lunn wrote: > On Mon, Aug 03, 2015 at 05:50:11PM +0200, Lucas Stach wrote: > > The clocks are initially active and thus the device

Re: [PATCH net-next 0/4] bnx2x, cnic, bnx2fc: add support for BD

2015-08-03 Thread David Miller
From: Yuval Mintz Date: Mon, 3 Aug 2015 13:09:31 + > Apparently I've made a typo in netdev's E-mail address. > Dave - do you want me to re-send the entire series? Yes. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org M

Re: [PATCH 2/6] test_bpf: allow tests to specify an skb fragment.

2015-08-03 Thread Daniel Borkmann
On 08/03/2015 06:38 PM, Nicolas Schichan wrote: On 08/03/2015 05:29 PM, Daniel Borkmann wrote: On 08/03/2015 04:02 PM, Nicolas Schichan wrote: We now have 286 tests, which is awesome! Perhaps, we need to start thinking of a better test description method soonish as the test_bpf.ko module grew t

[PATCH v2 net-next 0/4] gro: Fixes for tunnels and GRO

2015-08-03 Thread Tom Herbert
This patch set addresses some issue related to tunneling and GRO: - Ensure headers are pull into skb->head when putting 1st packet onto GRO list - Fix remote checksum offload to properly deal with frag0 in GRO. - Add support for GRO at VXLAN tunnel (call gro_cells) Testing: Ran one netperf TCP_

[PATCH v2 net-next 1/4] gro: Fix remcsum offload to deal with frags in GRO

2015-08-03 Thread Tom Herbert
The remote checksum offload GRO did not consider the case that frag0 might be in use. This patch fixes that by accessing headers using the skb_gro functions and not saving offsets relative to skb->head. Signed-off-by: Tom Herbert --- drivers/net/vxlan.c | 23 +-- includ

  1   2   >