Re: [PATCH RFC V2 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once

2015-08-27 Thread Raghavendra K T
On 08/28/2015 12:08 AM, David Miller wrote: From: Raghavendra K T Date: Wed, 26 Aug 2015 23:07:33 +0530 @@ -4641,10 +4647,12 @@ static inline void __snmp6_fill_stats64(u64 *stats, void __percpu *mib, static void snmp6_fill_stats(u64 *stats, struct inet6_dev *idev, int attrtype,

Re: linux-next: manual merge of the rdma tree with the net-next tree

2015-08-27 Thread Jiri Pirko
Fri, Aug 28, 2015 at 03:26:50AM CEST, s...@canb.auug.org.au wrote: >Hi Doug, > >Today's linux-next merge of the rdma tree got a conflict in: > > net/core/dev.c > >between commit: > > 0e4ead9d7b36 ("net: introduce change upper device notifier change info") > >from the net-next tree and commit: > >

Re: [PATCH net-next] net: FIB tracepoints

2015-08-27 Thread David Miller
From: David Ahern Date: Thu, 27 Aug 2015 22:32:59 -0700 > TP_printk is not printk. See my other response. Then I consider TP_printk to be broken. Forcing you to memcpy() ipv4 addresses in the "fast assign" of a trace point is completely stupid. -- To unsubscribe from this list: send the line "u

[PATCH net-next] cxgb4: Force uninitialized state if FW in adapter is unsupported

2015-08-27 Thread Hariprasad Shenai
Forcing uninitialized state allows us to upgrade and reinitialize the adapter. FW_VERSION_T4 = 1.4.0.0 FW_VERSION_T5 = 0.0.0.0 FW_VERSION_T6 = 0.0.0.0 At this point driver supports above and greater than above version. If FW in adapter < min FW_VERSION driver supports tries to upgrade

Re: [PATCH net-next] cxgb4: continue in debug mode, if probe fails

2015-08-27 Thread Hariprasad S
On Thu, Aug 27, 2015 at 16:14:34 -0300, Thadeu Lima de Souza Cascardo wrote: > On Wed, Aug 26, 2015 at 10:30:35PM +0530, Hariprasad Shenai wrote: > > If adapter is flashed with incorrect firmware, probe can fail. > > If probe fails, continue in debug mode, so one can also use the debug > > interfac

Re: [PATCH net-next] net: FIB tracepoints

2015-08-27 Thread David Miller
From: David Ahern Date: Thu, 27 Aug 2015 22:27:38 -0700 > ie., it does matter. src was declared a u32 and trying to pass &src to > the printk fails. Been down this road a lot. It's not printk that's failing, it's the tracing library in userspace that's being stupid about this. That's where the

Re: [PATCH net-next] net: Check frag_lists first to prevent data out of order

2015-08-27 Thread Weilong Chen
From: Weilong Chen Date: Fri, 28 Aug 2015 11:35:40 +0800 In my test, @to has a fraglist, but skb_tailroom(to) is not 0! The test is about tipc, the function tipc_buf_append will merge 3 skbs to one: packet 1: len = 1420 skb_tailroom = 190 packet 2: len = 1420 packet 2 will be add to 1'

Re: [PATCH net-next] net: Check frag_lists first to prevent data out of order

2015-08-27 Thread Weilong Chen
在 2015/8/28 12:37, Eric Dumazet 写道: On Fri, 2015-08-28 at 11:35 +0800, Weilong Chen wrote: Thanks for reply. On Wed, 2015-08-26 at 19:12 -0700, Eric Dumazet wrote: On Thu, 2015-08-27 at 08:56 +0800, chenweil...@huawei.com wrote: From: Weilong Chen When try to merge several skbs to prior

Re: [PATCH net-next] net: FIB tracepoints

2015-08-27 Thread David Ahern
On 8/27/15 10:17 PM, David Miller wrote: From: David Ahern Date: Thu, 27 Aug 2015 22:12:01 -0700 perhaps an example helps: swapper 0 [000] 406.447548: fib:fib_table_lookup: table 255 oif 0 iif 0 src 0.0.0.0 dst 2.1.1.2 tos 0 scope 0 flags 0 If src and dst are u32's then they print as either

Re: [PATCH net-next] net: FIB tracepoints

2015-08-27 Thread David Ahern
On 8/27/15 10:16 PM, David Miller wrote: From: David Ahern Date: Thu, 27 Aug 2015 22:07:30 -0700 On 8/27/15 10:05 PM, David Miller wrote: From: David Ahern Date: Thu, 27 Aug 2015 21:59:32 -0700 + __array(__u8, src,4 ) + __array(__u8,

Re: [PATCH net-next] net: FIB tracepoints

2015-08-27 Thread David Miller
From: David Ahern Date: Thu, 27 Aug 2015 22:12:01 -0700 > perhaps an example helps: > > swapper 0 [000] 406.447548: fib:fib_table_lookup: table 255 oif 0 iif > 0 src 0.0.0.0 dst 2.1.1.2 tos 0 scope 0 flags 0 > > If src and dst are u32's then they print as either 0x%x or %d which is > not intuit

Re: [PATCH net-next] net: FIB tracepoints

2015-08-27 Thread David Miller
From: David Ahern Date: Thu, 27 Aug 2015 22:07:30 -0700 > On 8/27/15 10:05 PM, David Miller wrote: >> From: David Ahern >> Date: Thu, 27 Aug 2015 21:59:32 -0700 >> >>> + __array(__u8, src,4 ) >>> + __array(__u8, dst,4 ) >> ... >>> +

Re: [PATCH net-next] net: FIB tracepoints

2015-08-27 Thread David Ahern
On 8/27/15 10:07 PM, David Ahern wrote: On 8/27/15 10:05 PM, David Miller wrote: From: David Ahern Date: Thu, 27 Aug 2015 21:59:32 -0700 +__array(__u8,src,4) +__array(__u8,dst,4) ... +__array(__u8,src,4) Maybe there

[PATCH v4] netlink: add NETLINK_CAP_ACK socket option

2015-08-27 Thread Christophe Ricard
Since commit c05cdb1b864f ("netlink: allow large data transfers from user-space"), the kernel may fail to allocate the necessary room for the acknowledgment message back to userspace. This patch introduces a new socket option that trims off the payload of the original netlink message. The netlink

[PATCH v4] netlink_ack: send a capped message in case of error

2015-08-27 Thread Christophe Ricard
Hi, After Jiri Benc feedback on my seconds proposal, please find a reworked patch still based on Pablo Neira Ayuso proposal. Compared to v3 i have removed Cc: sta...@vger.kernel.org. Could you queue it up for -stable ? On this patch, I found the sender's socket was saved in netlink_unicast_ker

Re: [PATCH net-next] net: FIB tracepoints

2015-08-27 Thread David Ahern
On 8/27/15 10:05 PM, David Miller wrote: From: David Ahern Date: Thu, 27 Aug 2015 21:59:32 -0700 + __array(__u8, src,4 ) + __array(__u8, dst,4 ) ... + __array(__u8, src,4 ) Maybe there i

Re: [PATCH net-next] net: FIB tracepoints

2015-08-27 Thread David Miller
From: David Ahern Date: Thu, 27 Aug 2015 21:59:32 -0700 > + __array(__u8, src,4 ) > + __array(__u8, dst,4 ) ... > + __array(__u8, src,4 ) Maybe there is something I don't understand about tracing, bu

[PATCH net-next] net: FIB tracepoints

2015-08-27 Thread David Ahern
A few useful tracepoints developing VRF driver. Signed-off-by: David Ahern --- I realize the sensitivity around adding tracepoints, but these have been invaluable developing the VRF device driver along with a return probe: perf probe -a 'fib_table_lookup_ret=fib_table_lookup%return ret=%ax' i

Re: [PATCH net-next] net: Check frag_lists first to prevent data out of order

2015-08-27 Thread Eric Dumazet
On Fri, 2015-08-28 at 11:35 +0800, Weilong Chen wrote: > Thanks for reply. > > > On Wed, 2015-08-26 at 19:12 -0700, Eric Dumazet wrote: > >> On Thu, 2015-08-27 at 08:56 +0800, chenweil...@huawei.com wrote: > >>> From: Weilong Chen > >>> > >>> When try to merge several skbs to prior one, if the fr

Re: [PATCH net-next] net: Check frag_lists first to prevent data out of order

2015-08-27 Thread David Miller
From: Weilong Chen Date: Fri, 28 Aug 2015 11:35:40 +0800 > In my test, @to has a fraglist, but skb_tailroom(to) is not 0! > The test is about tipc, the function tipc_buf_append will merge 3 skbs > to one: > packet 1: len = 1420 skb_tailroom = 190 > packet 2: len = 1420 > packet 2 will be ad

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

2015-08-27 Thread David Miller
From: Cong Wang Date: Thu, 27 Aug 2015 18:49:09 -0700 > On Thu, Aug 27, 2015 at 4:18 PM, David Miller wrote: >> From: Cong Wang >> Date: Thu, 27 Aug 2015 15:47:55 -0700 >> >>> On Thu, Aug 27, 2015 at 3:42 PM, David Miller wrote: If you fix it properly, by making every qdisc capable of bei

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-08-27 Thread Jay Vosburgh
Nikolay Aleksandrov wrote: [...] >Restarting this thread because there’s actually a bug here, what you described >with >the bonding destruction is true when the slaves are all destroyed but it isn’t >true if they’re >just released, if you take a look at bond_slave_netdev_event() the bond >destr

Re: [PATCH net-next] net: Check frag_lists first to prevent data out of order

2015-08-27 Thread Weilong Chen
Thanks for reply. On Wed, 2015-08-26 at 19:12 -0700, Eric Dumazet wrote: On Thu, 2015-08-27 at 08:56 +0800, chenweil...@huawei.com wrote: From: Weilong Chen When try to merge several skbs to prior one, if the frag_list is used and the the last one is a small packet, once the condition "len <

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-27 Thread Jason Wang
On 08/27/2015 06:43 PM, Michael S. Tsirkin wrote: > On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote: >> >> On 08/26/2015 12:32 AM, Vlad Yasevich wrote: >>> On 08/25/2015 07:30 AM, Jason Wang wrote: On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: > On Mon, Aug 24, 2015 at 04:

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-27 Thread Nikolay Aleksandrov
> On Aug 27, 2015, at 4:47 PM, Vlad Yasevich wrote: > > On 08/27/2015 05:02 PM, Nikolay Aleksandrov wrote: >> >>> On Aug 26, 2015, at 9:57 PM, roopa wrote: >>> >>> On 8/26/15, 4:33 AM, Nikolay Aleksandrov wrote: > On Aug 25, 2015, at 11:06 PM, David Miller wrote: > > From: Nikol

RE: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Arad, Ronen
>-Original Message- >From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On >Behalf Of sfel...@gmail.com >Sent: Thursday, August 27, 2015 12:17 AM >To: netdev@vger.kernel.org >Cc: j...@resnulli.us; da...@davemloft.net; f.faine...@gmail.com; >ro...@cumulusnetworks.com

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-08-27 Thread Nikolay Aleksandrov
> On Jul 15, 2015, at 1:32 PM, Jay Vosburgh wrote: > > Nikolay Aleksandrov wrote: > >> From: Nikolay Aleksandrov >> >> If a bonding device enslaves devices != arphrd_ether it'll change types >> and if later these devices are released, it can enslave an arphrd_ether >> device and switch back

Re: [PATCH net-next] bpf: add support for %s specifier to bpf_trace_printk()

2015-08-27 Thread Alexei Starovoitov
On 8/27/15 4:43 PM, Steven Rostedt wrote: On Thu, 27 Aug 2015 16:20:39 -0700 (PDT) David Miller wrote: From: Alexei Starovoitov Date: Thu, 27 Aug 2015 16:06:14 -0700 Fair or you still think it should be per byte copy? I'm terribly surprised we don't have an equivalent of strncpy() for uns

[PATCH net] bonding: fix bond_poll_controller bh_enable warning

2015-08-27 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov The problem is rcu_read_unlock_bh() which triggers a warning. ndo_poll_controller is supposed to be running with either irqs disabled or bh disabled already, so we don't need to take rcu_read_lock_bh. Use the standard rcu_read_lock/unlock to make the non-bh rcu_dereferen

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

2015-08-27 Thread Cong Wang
On Thu, Aug 27, 2015 at 4:18 PM, David Miller wrote: > From: Cong Wang > Date: Thu, 27 Aug 2015 15:47:55 -0700 > >> On Thu, Aug 27, 2015 at 3:42 PM, David Miller wrote: >>> If you fix it properly, by making every qdisc capable of being ->init()'d >>> without explicit parameters, it will be the b

linux-next: manual merge of the rdma tree with the net-next tree

2015-08-27 Thread Stephen Rothwell
Hi Doug, Today's linux-next merge of the rdma tree got a conflict in: net/core/dev.c between commit: 0e4ead9d7b36 ("net: introduce change upper device notifier change info") from the net-next tree and commit: 133b5b93c734 ("net: Add info for NETDEV_CHANGEUPPER event") from the rdma tre

RE: [PATCH net-next 1/1] lan78xx: Change default internal PHY ID to 1

2015-08-27 Thread Woojung.Huh
Sorry for lack of details. Default PHY ID is changed to 1 for final silicon. This is an coding error to be included. From: David Miller [da...@davemloft.net] Sent: Thursday, August 27, 2015 7:17 PM To: Woojung Huh - C21699 Cc: netdev@vger.kernel.org Subjec

[GIT] Networking

2015-08-27 Thread David Miller
Some straggler bug fixes here: 1) Netlink_sendmsg() doesn't check iterator type properly in mmap case, from Ken-ichirou MATSUZAWA. 2) Don't sleep in atomic context in bcmgenet driver, from Florian Fainelli. 3) The pfkey_broadcast() code patch can't actually ever use anything other than

Re: [net-next PATCH 0/4] fixup IFF_NO_QUEUE conversion

2015-08-27 Thread David Miller
From: Phil Sutter Date: Thu, 27 Aug 2015 21:21:35 +0200 > This series serves two purposes: > > On one hand it fixes a quite embarrassing bug around the warning I added for > drivers still setting tx_queue_len = 0 to achieve noqueue operation. It turned > out to be quite useless as due to using a

Re: [PATCH net-next] sock: fix kernel doc error

2015-08-27 Thread David Miller
From: Jεan Sacren Date: Thu, 27 Aug 2015 18:05:49 -0600 > From: Jean Sacren > > The symbol '__sk_reclaim' is not present in the current tree. Apparently > '__sk_reclaim' was meant to be '__sk_mem_reclaim', so fix it with the > right symbol name for the kernel doc. > > Signed-off-by: Jean Sacre

Re: [PATCH net v3] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

2015-08-27 Thread David Miller
From: Xin Long Date: Thu, 27 Aug 2015 04:52:20 +0800 > Commit f8d960524328 ("sctp: Enforce retransmission limit during shutdown") > fixed a problem with excessive retransmissions in the SHUTDOWN_PENDING by not > resetting the association overall_error_count. This allowed the association > to bet

[PATCH net-next] sock: fix kernel doc error

2015-08-27 Thread Jεan Sacren
From: Jean Sacren The symbol '__sk_reclaim' is not present in the current tree. Apparently '__sk_reclaim' was meant to be '__sk_mem_reclaim', so fix it with the right symbol name for the kernel doc. Signed-off-by: Jean Sacren Cc: Hideo Aoki --- net/core/sock.c | 2 +- 1 file changed, 1 insert

Re: [PATCH net-next] bpf: add support for %s specifier to bpf_trace_printk()

2015-08-27 Thread Steven Rostedt
On Thu, 27 Aug 2015 16:20:39 -0700 (PDT) David Miller wrote: > From: Alexei Starovoitov > Date: Thu, 27 Aug 2015 16:06:14 -0700 > > > Fair or you still think it should be per byte copy? > > I'm terribly surprised we don't have an equivalent of strncpy() > for unsafe kernel pointers. > > You p

Re: [PATCH net v3] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

2015-08-27 Thread Vlad Yasevich
On 08/26/2015 04:52 PM, Xin Long wrote: > Commit f8d960524328 ("sctp: Enforce retransmission limit during shutdown") > fixed a problem with excessive retransmissions in the SHUTDOWN_PENDING by not > resetting the association overall_error_count. This allowed the association > to better enforce ass

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-27 Thread Vlad Yasevich
On 08/27/2015 05:02 PM, Nikolay Aleksandrov wrote: > >> On Aug 26, 2015, at 9:57 PM, roopa wrote: >> >> On 8/26/15, 4:33 AM, Nikolay Aleksandrov wrote: On Aug 25, 2015, at 11:06 PM, David Miller wrote: From: Nikolay Aleksandrov Date: Tue, 25 Aug 2015 22:28:16 -0700

Re: [PATCH net-next 2/2] net/mlx4_core: Fix unintialized variable used in error path

2015-08-27 Thread David Miller
From: cls...@linux.vnet.ibm.com Date: Thu, 27 Aug 2015 14:43:26 -0500 > From: Carol L Soto > > The uninitialized value name in mlx4_en_activate_cq was used in order > to print an error message. Fixing it by replacing it with cq->vector. > > Signed-off-by: Matan Barak > Signed-off-by: Carol L S

Re: [PATCH net-next 1/2] net/mlx4_core: Capping number of requested MSIXs to MAX_MSIX

2015-08-27 Thread David Miller
From: cls...@linux.vnet.ibm.com Date: Thu, 27 Aug 2015 14:43:25 -0500 > From: Carol L Soto > > We currently manage IRQs in pool_bm which is a bit field > of MAX_MSIX bits. Thus, allocating more than MAX_MSIX > interrupts can't be managed in pool_bm. > Fixing this by capping number of requested M

Re: [PATCH net-next] bridge: fdb: rearrange net_bridge_fdb_entry

2015-08-27 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 27 Aug 2015 14:19:20 -0700 > From: Nikolay Aleksandrov > > While looking into fixing the local entries scalability issue I noticed > that the structure is badly arranged because vlan_id would fall in a > second cache line while keeping rcu which is used only

Re: [PATCH net-next 0/2] OPENVSWITCH && !NETFILTER build fix.

2015-08-27 Thread David Miller
From: Joe Stringer Date: Thu, 27 Aug 2015 15:25:44 -0700 > Fix issues reported by kbuild test robot: > > All error/warnings (new ones prefixed by >>): Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.o

Re: [RFC v3] netlink: add NETLINK_CAP_ACK socket option

2015-08-27 Thread David Miller
From: Christophe Ricard Date: Thu, 27 Aug 2015 21:31:31 +0200 > Since commit c05cdb1b864f ("netlink: allow large data transfers from > user-space"), the kernel may fail to allocate the necessary room for the > acknowledgment message back to userspace. This patch introduces a new > socket option t

Re: [patch net-next v2 0/3] mlxsw: small driver update

2015-08-27 Thread David Miller
From: Jiri Pirko Date: Thu, 27 Aug 2015 17:59:54 +0200 > Ido Schimmel (2): > mlxsw: Remove duplicate included header > mlxsw: Make mailboxes 4KB aligned > > Jiri Pirko (1): > mlxsw: adjust transmit fail log message level in __mlxsw_emad_transmit Series applied, thanks Jiri. -- To unsubscr

Re: [patch net-next v2 0/6] rocker: make master change handling nicer

2015-08-27 Thread David Miller
From: Jiri Pirko Date: Thu, 27 Aug 2015 09:31:17 +0200 > From: Jiri Pirko > > Jiri Pirko (6): > net: introduce change upper device notifier change info > net: add netif_is_bridge_master helper > net: add netif_is_ovs_master helper with IFF_OPENVSWITCH private flag > net: kill long time

Re: [RFC PATCH v6 net-next 3/4] tcp: add in_flight to tcp_skb_cb

2015-08-27 Thread Lawrence Brakmo
On 8/27/15, 3:57 PM, "Yuchung Cheng" wrote: >On Thu, Aug 27, 2015 at 3:54 PM, Yuchung Cheng wrote: >> On Thu, Aug 27, 2015 at 3:44 PM, Lawrence Brakmo wrote: >>> Yuchung, thank you for reviewing these patches. Response inline below. >>> >>> On 8/27/15, 3:00 PM, "Yuchung Cheng" wrote: >>> >>>

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread David Miller
From: sfel...@gmail.com Date: Thu, 27 Aug 2015 00:16:44 -0700 > Comments? No fundamental objections from me. I just want to reiterate one thing I think Jiri said. There are other kinds of devices which make up this kind of hierarchy. I can think of two examples involving bonafide ethernet ports

Re: [PATCH net-next] bpf: add support for %s specifier to bpf_trace_printk()

2015-08-27 Thread David Miller
From: Alexei Starovoitov Date: Thu, 27 Aug 2015 16:06:14 -0700 > Fair or you still think it should be per byte copy? I'm terribly surprised we don't have an equivalent of strncpy() for unsafe kernel pointers. You probably won't be the last person to want this, and it's silly to optimize it in o

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

2015-08-27 Thread David Miller
From: Cong Wang Date: Thu, 27 Aug 2015 15:47:55 -0700 > On Thu, Aug 27, 2015 at 3:42 PM, David Miller wrote: >> If you fix it properly, by making every qdisc capable of being ->init()'d >> without explicit parameters, it will be the best behavior overall. > > The problem is ->init() is not even

Re: [PATCH net-next 1/1] lan78xx: Change default internal PHY ID to 1

2015-08-27 Thread David Miller
From: Date: Thu, 27 Aug 2015 18:01:17 + > Change default internal PHY ID to 1. > > Signed-off-by: Woojung Huh This doesn't describe in enough details, this change. Why is this being changed now? How did the driver work properly with the previous value? If it worked previously, what nega

Re: [PATCH net-next] udp_offload: Allow device GRO without checksum-complete

2015-08-27 Thread Ramu Ramamurthy
On 2015-08-24 12:34, Tom Herbert wrote: This patch adds a sysctl which allows GRO for a UDP offload protocol to be performed in the device NAPI. This potentially is a performance improvement if the savings of doing GRO in device NAPI outweighs the cost of performing the checksum. Note that the pe

Re: [PATCH net-next v2] net: sched: consolidate tc_classify{,_compat}

2015-08-27 Thread David Miller
From: Daniel Borkmann Date: Thu, 27 Aug 2015 10:11:37 +0200 > For classifiers getting invoked via tc_classify(), we always need an > extra function call into tc_classify_compat(), as both are being > exported as symbols and tc_classify() itself doesn't do much except > handling of reclassificatio

[PATCH net-next 3/5] net: Add helper function to compare inetpeer addresses

2015-08-27 Thread David Ahern
tcp_metrics and inetpeer both have functions to compare inetpeer addresses. Consolidate into 1 version. Signed-off-by: David Ahern --- include/net/inetpeer.h | 16 net/ipv4/inetpeer.c| 20 ++-- net/ipv4/tcp_metrics.c | 6 +- 3 files changed, 19 insertion

[PATCH net-next 1/5] net: Introduce ipv4_addr_hash and use it for tcp metrics

2015-08-27 Thread David Ahern
Refactors a common line into helper function. Signed-off-by: David Ahern --- include/net/ip.h | 5 + net/ipv4/tcp_metrics.c | 12 ++-- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/include/net/ip.h b/include/net/ip.h index bee5f3582e38..7b9e1c782aa3 100644 --

[PATCH net-next 4/5 v2] net: Refactor inetpeer address struct

2015-08-27 Thread David Ahern
Move the inetpeer_addr_base union to inetpeer_addr and drop inetpeer_addr_base. Both the a6 and in6_addr overlays are not needed; drop the __be32 version and rename in6 to a6 for consistency with ipv4. Add a new u32 array to the union which removes the need for the typecast in the compare function

[PATCH net-next 5/5] net: Add support for VRFs to inetpeer cache

2015-08-27 Thread David Ahern
inetpeer caches based on address only, so duplicate IP addresses within a namespace return the same cached entry. Enhance the ipv4 address key to contain both the IPv4 address and VRF device index. Signed-off-by: David Ahern --- include/net/inetpeer.h | 17 - net/ipv4/icmp.c

[PATCH net-next 2/5] net: Add set,get helpers for inetpeer addresses

2015-08-27 Thread David Ahern
Use inetpeer set,get helpers in tcp_metrics rather than peeking into the inetpeer_addr struct. Signed-off-by: David Ahern --- include/net/inetpeer.h | 23 ++ net/ipv4/tcp_metrics.c | 65 +- 2 files changed, 50 insertions(+), 38 dele

Re: [PATCH net-next] bpf: add support for %s specifier to bpf_trace_printk()

2015-08-27 Thread Alexei Starovoitov
On 8/27/15 3:34 PM, David Miller wrote: From: Alexei Starovoitov Date: Wed, 26 Aug 2015 23:26:59 -0700 +/* similar to strncpy_from_user() but with extra checks */ +static void probe_read_string(char *buf, int size, long unsafe_ptr) +{ + char dst[4]; + int i = 0; + + size--; +

[PATCH net-next 0/5 v2] net: Refactor inetpeer cache and add support for VRFs

2015-08-27 Thread David Ahern
Per Dave's comment on the version 1 patch adding VRF support to inetpeer cache by explicitly making the address + index a key. Refactored the inetpeer code in the process; mostly impacts the use by tcp_metrics. David Ahern (5): net: Introduce ipv4_addr_hash and use it for tcp metrics net: Add

Re: [RFC PATCH v6 net-next 3/4] tcp: add in_flight to tcp_skb_cb

2015-08-27 Thread Yuchung Cheng
On Thu, Aug 27, 2015 at 3:54 PM, Yuchung Cheng wrote: > On Thu, Aug 27, 2015 at 3:44 PM, Lawrence Brakmo wrote: >> Yuchung, thank you for reviewing these patches. Response inline below. >> >> On 8/27/15, 3:00 PM, "Yuchung Cheng" wrote: >> >>>On Tue, Aug 25, 2015 at 4:33 PM, Lawrence Brakmo wrot

Re: [RFC PATCH v6 net-next 3/4] tcp: add in_flight to tcp_skb_cb

2015-08-27 Thread Yuchung Cheng
On Thu, Aug 27, 2015 at 3:44 PM, Lawrence Brakmo wrote: > Yuchung, thank you for reviewing these patches. Response inline below. > > On 8/27/15, 3:00 PM, "Yuchung Cheng" wrote: > >>On Tue, Aug 25, 2015 at 4:33 PM, Lawrence Brakmo wrote: >>> Add in_flight (bytes in flight when packet was sent) fi

Re: [PATCH net-next 4/5] net: Refactor inetpeer address struct

2015-08-27 Thread David Ahern
On 8/27/15 2:16 PM, David Ahern wrote: @@ -124,12 +122,12 @@ static inline struct inet_peer *inet_getpeer_v6(struct inet_peer_base *base, static inline int inetpeer_addr_cmp(const struct inetpeer_addr *a, const struct inetpeer_addr *b) { - int i, n =

Re: [PATCH net-next] virtio-net: avoid unnecessary sg initialzation

2015-08-27 Thread David Miller
From: Jason Wang Date: Thu, 27 Aug 2015 14:53:06 +0800 > Usually an skb does not have up to MAX_SKB_FRAGS frags. So no need to > initialize the unuse part of sg. This patch initialize the sg based on > the real number it will used: > > - during xmit, it could be inferred from nr_frags and can_pu

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

2015-08-27 Thread Cong Wang
On Thu, Aug 27, 2015 at 3:42 PM, David Miller wrote: > > Long term it's the wrong fix, trust me. So we have plan to convert some non-defaultable qdisc to defaultable? I don't see a reason here. > > If you fix it properly, by making every qdisc capable of being ->init()'d > without explicit param

Re: [RFC PATCH v6 net-next 3/4] tcp: add in_flight to tcp_skb_cb

2015-08-27 Thread Lawrence Brakmo
Yuchung, thank you for reviewing these patches. Response inline below. On 8/27/15, 3:00 PM, "Yuchung Cheng" wrote: >On Tue, Aug 25, 2015 at 4:33 PM, Lawrence Brakmo wrote: >> Add in_flight (bytes in flight when packet was sent) field >> to tx component of tcp_skb_cb and make it available to >>

Re: [PATCH v4 net-next 0/8] Geneve: Add support for tunnel metadata mode

2015-08-27 Thread David Miller
From: Pravin B Shelar Date: Wed, 26 Aug 2015 14:54:31 -0700 > Following patches adds support for Geneve tunnel metadata > mode. OVS can make use of Geneve net-device with tunnel > metadata API from kernel. > > This also allows us to consolidate Geneve implementation > from two kernel modules gen

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

2015-08-27 Thread David Miller
From: Cong Wang Date: Thu, 27 Aug 2015 15:39:12 -0700 > On Thu, Aug 27, 2015 at 3:30 PM, David Miller wrote: >> I don't like this. >> >> The situation is that some sophisticated qdiscs can function without >> explicit parameters, some cannot. > > This is exactly what this patch tries to solve..

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

2015-08-27 Thread Cong Wang
On Thu, Aug 27, 2015 at 3:30 PM, David Miller wrote: > I don't like this. > > The situation is that some sophisticated qdiscs can function without > explicit parameters, some cannot. This is exactly what this patch tries to solve... I already mark those with a DEFAULTABLE flag. > > That is the p

Re: [PATCH v2 net-next] bridge: Add netlink support for vlan_protocol attribute

2015-08-27 Thread David Miller
From: Toshiaki Makita Date: Thu, 27 Aug 2015 15:32:26 +0900 > This enables bridge vlan_protocol to be configured through netlink. > > When CONFIG_BRIDGE_VLAN_FILTERING is disabled, kernel behaves the > same way as this feature is not implemented. > > Signed-off-by: Toshiaki Makita > --- > v2:

Re: [PATCH net-next] bpf: add support for %s specifier to bpf_trace_printk()

2015-08-27 Thread David Miller
From: Alexei Starovoitov Date: Wed, 26 Aug 2015 23:26:59 -0700 > +/* similar to strncpy_from_user() but with extra checks */ > +static void probe_read_string(char *buf, int size, long unsafe_ptr) > +{ > + char dst[4]; > + int i = 0; > + > + size--; > + for (;;) { > + i

Re: [PATCH net-next] bnx2x: Add new device ids under the Qlogic vendor

2015-08-27 Thread David Miller
From: Yuval Mintz Date: Thu, 27 Aug 2015 08:03:08 +0300 > This adds support for 3 new PCI device combinations - > 1077:16a1, 1077:16a4 and 1077:16ad. > > Signed-off-by: Yuval Mintz Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

[PATCH net-next 0/2] OPENVSWITCH && !NETFILTER build fix.

2015-08-27 Thread Joe Stringer
Fix issues reported by kbuild test robot: All error/warnings (new ones prefixed by >>): net/openvswitch/actions.c: In function 'ovs_fragment': >> net/openvswitch/actions.c:705:16: error: implicit declaration of function 'nf_get_ipv6_ops' [-Werror=implicit-function-declaration] const stru

[PATCH net-next 1/2] netfilter: Define v6ops in !CONFIG_NETFILTER case.

2015-08-27 Thread Joe Stringer
When CONFIG_OPENVSWITCH is set, and CONFIG_NETFILTER is not set, the openvswitch IPv6 fragmentation handling cannot refer to ipv6_ops because it isn't defined. Add a dummy version to avoid #ifdefs in source files. Fixes: 7f8a436 "openvswitch: Add conntrack action" Signed-off-by: Joe Stringer ---

[PATCH net-next 2/2] openvswitch: Include ip6_fib.h.

2015-08-27 Thread Joe Stringer
kbuild test robot reports that certain configurations will not automatically pick up on the "struct rt6_info" definition, so explicitly include the header for this structure. Fixes: 7f8a436 "openvswitch: Add conntrack action" Signed-off-by: Joe Stringer --- net/openvswitch/actions.c | 1 + 1 fil

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

2015-08-27 Thread David Miller
From: Cong Wang Date: Wed, 26 Aug 2015 15:41:26 -0700 > Currently there is no check for if a qdisc is appropriate > to be used as the default qdisc. This causes we get no > error even we set the default qdisc to an inappropriate one > but an error will be shown up later. This is not good. > > Al

Re: [RFC PATCH v6 net-next 3/4] tcp: add in_flight to tcp_skb_cb

2015-08-27 Thread Yuchung Cheng
On Tue, Aug 25, 2015 at 4:33 PM, Lawrence Brakmo wrote: > Add in_flight (bytes in flight when packet was sent) field > to tx component of tcp_skb_cb and make it available to > congestion modules' pkts_acked() function through the > ack_sample function argument. > > Signed-off-by: Lawrence Brakmo

Re: [RFC PATCH v6 net-next 2/4] tcp: refactor struct tcp_skb_cb

2015-08-27 Thread Yuchung Cheng
On Tue, Aug 25, 2015 at 4:33 PM, Lawrence Brakmo wrote: > > Refactor tcp_skb_cb to create two overlaping areas to store > state for incoming or outgoing skbs based on comments by > Neal Cardwell to tcp_nv patch: > >AFAICT this patch would not require an increase in the size of >sk_buff cb[

Re: [RFC PATCH v6 net-next 1/4] tcp: replace cnt & rtt with struct in pkts_acked()

2015-08-27 Thread Yuchung Cheng
On Tue, Aug 25, 2015 at 4:33 PM, Lawrence Brakmo wrote: > Replace 2 arguments (cnt and rtt) in the congestion control modules' > pkts_acked() function with a struct. This will allow adding more > information without having to modify existing congestion control > modules (tcp_nv in particular needs

Re: [PATCH v5 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-27 Thread Pravin Shelar
On Thu, Aug 27, 2015 at 2:18 AM, Thomas Graf wrote: > On 08/26/15 at 11:46pm, Pravin B Shelar wrote: >> + if (ip_tunnel_collect_metadata() || geneve->collect_md) { >> + __be16 flags; >> + void *opts; >> + >> + flags = TUNNEL_KEY | TUNNEL_GENEVE_OPT | >> +

Re: [PATCH -next v3 1/2] device property: Return -ENXIO if there is no suitable FW interface

2015-08-27 Thread David Miller
From: Guenter Roeck Date: Wed, 26 Aug 2015 20:27:04 -0700 > Return -ENXIO if device property array access functions don't find > a suitable firmware interface. > > This lets drivers decide if they should use available platform data > instead. > > Cc: Rafael J. Wysocki > Signed-off-by: Guenter

Re: [PATCH -next v3 2/2] smsc911x: Ignore error return from device_get_phy_mode()

2015-08-27 Thread David Miller
From: Guenter Roeck Date: Wed, 26 Aug 2015 20:27:05 -0700 > Commit 62ee783bf1f8 ("smsc911x: Fix crash seen if neither ACPI nor OF is > configured or used") introduces an error check for the return value from > device_get_phy_mode() and bails out if there is an error. Unfortunately, > there are co

[PATCH net-next] bridge: fdb: rearrange net_bridge_fdb_entry

2015-08-27 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov While looking into fixing the local entries scalability issue I noticed that the structure is badly arranged because vlan_id would fall in a second cache line while keeping rcu which is used only when deleting in the first, so re-arrange the structure and push rcu to the

Re: [PATCH net-next] route: fix breakage after moving lwtunnel state

2015-08-27 Thread Tom Herbert
On Thu, Aug 27, 2015 at 2:00 PM, Thomas Graf wrote: > On 08/27/15 at 12:47pm, Tom Herbert wrote: >> On Wed, Aug 26, 2015 at 3:13 PM, Thomas Graf wrote: >> > On 08/26/15 at 06:19pm, Jiri Benc wrote: >> >> might be a noise. However, there's definitely room for performance >> >> improvement here, th

Re: [PATCH net-next] net: sched: consolidate tc_classify{,_compat}

2015-08-27 Thread David Miller
From: Daniel Borkmann Date: Wed, 26 Aug 2015 23:00:06 +0200 > For classifiers getting invoked via tc_classify(), we always need an > extra function call into tc_classify_compat(), as both are being > exported as symbols and tc_classify() itself doesn't do much except > handling of reclassificatio

[PATCH net-next 2/5] net: Add set,get helpers for inetpeer addresses

2015-08-27 Thread David Ahern
Use inetpeer set,get helpers in tcp_metrics rather than peeking into the inetpeer_addr struct. Signed-off-by: David Ahern --- include/net/inetpeer.h | 23 ++ net/ipv4/tcp_metrics.c | 65 +- 2 files changed, 50 insertions(+), 38 dele

[PATCH net-next 5/5] net: Add support for VRFs to inetpeer cache

2015-08-27 Thread David Ahern
inetpeer caches based on address only, so duplicate IP addresses within a namespace return the same cached entry. Enhance the ipv4 address key to contain both the IPv4 address and VRF device index. Signed-off-by: David Ahern --- include/net/inetpeer.h | 17 - net/ipv4/icmp.c

[PATCH net-next 1/5] net: Introduce ipv4_addr_hash and use it for tcp metrics

2015-08-27 Thread David Ahern
Refactors a common line into helper function. Signed-off-by: David Ahern --- include/net/ip.h | 5 + net/ipv4/tcp_metrics.c | 12 ++-- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/include/net/ip.h b/include/net/ip.h index bee5f3582e38..7b9e1c782aa3 100644 --

[PATCH net-next 4/5] net: Refactor inetpeer address struct

2015-08-27 Thread David Ahern
Move the inetpeer_addr_base union to inetpeer_addr and drop inetpeer_addr_base. Both the a6 and in6_addr overlays are not needed; drop the __be32 version and rename in6 to a6 for consistency with ipv4. Add a new u32 array to the union which removes the need for the typecast in the compare function

[PATCH net-next 3/5] net: Add helper function to compare inetpeer addresses

2015-08-27 Thread David Ahern
tcp_metrics and inetpeer both have functions to compare inetpeer addresses. Consolidate into 1 version. Signed-off-by: David Ahern --- include/net/inetpeer.h | 16 net/ipv4/inetpeer.c| 20 ++-- net/ipv4/tcp_metrics.c | 6 +- 3 files changed, 19 insertion

Re: [PATCH net v3] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

2015-08-27 Thread Marcelo Ricardo Leitner
On Thu, Aug 27, 2015 at 04:52:20AM +0800, Xin Long wrote: > Commit f8d960524328 ("sctp: Enforce retransmission limit during shutdown") > fixed a problem with excessive retransmissions in the SHUTDOWN_PENDING by not > resetting the association overall_error_count. This allowed the association > to

[PATCH net-next 0/5] net: Refactor inetpeer cache and add support for VRFs

2015-08-27 Thread David Ahern
Per Dave's comment on the version 1 patch adding VRF support to inetpeer cache by explicitly making the address + index a key. Refactored the inetpeer code in the process. David Ahern (5): net: Introduce ipv4_addr_hash and use it for tcp metrics net: Add set,get helpers for inetpeer addresses

Re: [net-next v2 00/14][pull request] Intel Wired LAN Driver Updates 2015-08-26

2015-08-27 Thread David Miller
From: Jeff Kirsher Date: Wed, 26 Aug 2015 15:49:19 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ker

Re: [PATCH net v3] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

2015-08-27 Thread lucien xin
hi, Vlad, plz help to ACK this one -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-27 Thread Nikolay Aleksandrov
> On Aug 26, 2015, at 9:57 PM, roopa wrote: > > On 8/26/15, 4:33 AM, Nikolay Aleksandrov wrote: >>> On Aug 25, 2015, at 11:06 PM, David Miller wrote: >>> >>> From: Nikolay Aleksandrov >>> Date: Tue, 25 Aug 2015 22:28:16 -0700 >>> Certainly, that should be done and I will look into it, b

Re: [PATCH net-next] route: fix breakage after moving lwtunnel state

2015-08-27 Thread Thomas Graf
On 08/27/15 at 12:47pm, Tom Herbert wrote: > On Wed, Aug 26, 2015 at 3:13 PM, Thomas Graf wrote: > > On 08/26/15 at 06:19pm, Jiri Benc wrote: > >> might be a noise. However, there's definitely room for performance > >> improvement here, the lwtunnel vxlan throughput is at about ~40% of the > >> no

Re: [PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning

2015-08-27 Thread David Miller
From: Xin Long Date: Thu, 27 Aug 2015 16:26:34 +0800 > in sctp_process_asconf(), we get address parameter from the beginning of > the addip params. but we never check if it's really there. if the addr > param is not there, it still can pass sctp_verify_asconf(), then to be > handled by sctp_proce

Re: [TRIVIAL PATCH V2] smsc9194: Remove uncompilable #if 0'd use of pr_dbg

2015-08-27 Thread David Miller
From: Joe Perches Date: Wed, 26 Aug 2015 11:49:35 -0700 > No pr_dbg method exists. > > While this code is #if 0'd, it'd be nicer to > use the generic hex_dump, so use it instead. > > Signed-off-by: Joe Perches Applied to net-next, thanks Joe. I don't know what to do with "really old" drivers

Re: [PATCH v2 0/2] drivers: net: xgene: Add TSO support

2015-08-27 Thread David Miller
From: Iyappan Subramanian Date: Wed, 26 Aug 2015 11:48:04 -0700 > Adding TSO support for 10GbE > > iperf Tx data rate without TSO: 3.42 Gbps > with TSO: 9.41 Gbps > > v2: Address review comments from v1 > - skb_linearize() if headers doesn't fit in 3 hardware buffers >

  1   2   >