Re: [PATCH net v2] rtnetlink: catch -EOPNOTSUPP errors from ndo_bridge_getlink

2015-09-15 Thread David Miller
From: Roopa Prabhu Date: Tue, 15 Sep 2015 14:44:29 -0700 > From: Roopa Prabhu ... > ndo_bridge_getlink can return -EOPNOTSUPP when an interfaces > ndo_bridge_getlink op is set to switchdev_port_bridge_getlink > and CONFIG_SWITCHDEV is not defined. This today can happen to > bond, rocker and tea

Re: [PATCH v4 net 0/5] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-15 Thread David Miller
From: Martin KaFai Lau Date: Tue, 15 Sep 2015 14:30:04 -0700 > v4: > - Fix a compilation error in patch 5 when CONFIG_LOCKDEP is turned on and > re-test it > > v3: > - Merge a 'if else if' test in patch 4 > - Use rcu_dereference_protected in patch 5 to fix a sparse check when > CONFIG_SPARSE

Re: [PATCH] net: mvneta: fix DMA buffer unmapping in mvneta_rx()

2015-09-15 Thread David Miller
From: Simon Guinot Date: Tue, 15 Sep 2015 22:41:21 +0200 > This patch fixes a regression introduced by the commit a84e32894191 > ("net: mvneta: fix refilling for Rx DMA buffers"). Due to this commit > the newly allocated Rx buffers are DMA-unmapped in place of those passed > to the networking sta

Re: [PATCH V4 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-09-15 Thread Rustad, Mark D
> On Sep 15, 2015, at 2:17 PM, Alex Williamson > wrote: > > Also, rather than clearing the flag, can we move the tests done by > pci_vpd_f0_dev_check() into the > quirk setup function? It seems like function 0 should be sufficiently > configured by the time we're probing non-zero functions that

Re: [PATCH 3/5] lan78xx: update to use phylib

2015-09-15 Thread David Miller
From: Date: Thu, 10 Sep 2015 22:16:11 + > @@ -1287,42 +1074,30 @@ static int lan78xx_set_wol(struct net_device *netdev, > static int lan78xx_get_eee(struct net_device *net, struct ethtool_eee *edata) > { > struct lan78xx_net *dev = netdev_priv(net); > + struct phy_device *phydev =

[PATCH net v2] rtnetlink: catch -EOPNOTSUPP errors from ndo_bridge_getlink

2015-09-15 Thread Roopa Prabhu
From: Roopa Prabhu problem reported: kernel 4.1.3 # bridge vlan portvlan ids eth0 1 PVID Egress Untagged 90 91 92 93 94 95 9

Re: [PATCH v3 net-next 1/2] ipv4: L3 hash-based multipath

2015-09-15 Thread Alexander Duyck
On 09/15/2015 01:29 PM, Peter Nørlund wrote: Replaces the per-packet multipath with a hash-based multipath using source and destination address. Signed-off-by: Peter Nørlund --- include/net/ip_fib.h | 11 ++-- net/ipv4/fib_semantics.c | 137 +-

Re: v2 of seccomp filter c/r patches

2015-09-15 Thread Tycho Andersen
Hi Andy, On Tue, Sep 15, 2015 at 01:01:23PM -0700, Andy Lutomirski wrote: > On Tue, Sep 15, 2015 at 11:26 AM, Tycho Andersen > wrote: > > Hi Andy, > > > > On Tue, Sep 15, 2015 at 11:13:51AM -0700, Andy Lutomirski wrote: > >> On Tue, Sep 15, 2015 at 9:07 AM, Tycho Andersen > >> wrote: > >> > Hi A

[PATCH v4 net 3/5] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-15 Thread Martin KaFai Lau
Problems in the current dst_entry cache in the ip6_tunnel: 1. ip6_tnl_dst_set is racy. There is no lock to protect it: - One major problem is that the dst refcnt gets messed up. F.e. the same dst_cache can be released multiple times and then triggering the infamous dst refcnt < 0 war

[PATCH v4 net 0/5] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-15 Thread Martin KaFai Lau
v4: - Fix a compilation error in patch 5 when CONFIG_LOCKDEP is turned on and re-test it v3: - Merge a 'if else if' test in patch 4 - Use rcu_dereference_protected in patch 5 to fix a sparse check when CONFIG_SPARSE_RCU_POINTER is enabled v2: - Add patch 4 and 5 to remove the spinlock v1: Th

[PATCH v4 net 4/5] ipv6: Avoid double dst_free

2015-09-15 Thread Martin KaFai Lau
It is a prep work to get dst freeing from fib tree undergo a rcu grace period. The following is a common paradigm: if (ip6_del_rt(rt)) dst_free(rt) which means, if rt cannot be deleted from the fib tree, dst_free(rt) now. 1. We don't know the ip6_del_rt(rt) failure is because it was no

[PATCH v4 net 5/5] ipv6: Replace spinlock with seqlock and rcu in ip6_tunnel

2015-09-15 Thread Martin KaFai Lau
This patch uses a seqlock to ensure consistency between idst->dst and idst->cookie. It also makes dst freeing from fib tree to undergo a rcu grace period. Signed-off-by: Martin KaFai Lau --- include/net/ip6_tunnel.h | 4 ++-- net/ipv6/ip6_fib.c | 9 +++-- net/ipv6/ip6_tunnel.c|

[PATCH v4 net 1/5] ipv6: Refactor common ip6gre_tunnel_init codes

2015-09-15 Thread Martin KaFai Lau
It is a prep work to fix the dst_entry refcnt bugs in ip6_tunnel. This patch refactors some common init codes used by both ip6gre_tunnel_init and ip6gre_tap_init. Signed-off-by: Martin KaFai Lau --- net/ipv6/ip6_gre.c | 37 - 1 file changed, 24 insertions(+),

[PATCH v4 net 2/5] ipv6: Rename the dst_cache helper functions in ip6_tunnel

2015-09-15 Thread Martin KaFai Lau
It is a prep work to fix the dst_entry refcnt bugs in ip6_tunnel. This patch rename: 1. ip6_tnl_dst_check() to ip6_tnl_dst_get() to better reflect that it will take a dst refcnt in the next patch. 2. ip6_tnl_dst_store() to ip6_tnl_dst_set() to have a more conventional name matching with ip6_

[PATCH v2] net-sysfs: get_netdev_queue_index() cleanup

2015-09-15 Thread Thadeu Lima de Souza Cascardo
Redo commit ed1acc8cd8c22efa919da8d300bab646e01c2dce. Commit 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 ("net: Add max rate tx queue attribute") moved get_netdev_queue_index around, but kept the old version. Probably because of a reuse of the original patch from before Eric's change to that function

Re: [PATCH] net: mvneta: fix DMA buffer unmapping in mvneta_rx()

2015-09-15 Thread Oren Laskin
This fixes the regression we saw. Tested-by: Oren Laskin On Tue, Sep 15, 2015 at 1:41 PM, Simon Guinot wrote: > This patch fixes a regression introduced by the commit a84e32894191 > ("net: mvneta: fix refilling for Rx DMA buffers"). Due to this commit > the newly allocated Rx buffers are DMA-un

Re: [PATCH V4 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-09-15 Thread Alex Williamson
On Tue, 2015-09-15 at 20:47 +, Rustad, Mark D wrote: > > On Sep 15, 2015, at 12:04 PM, Alex Williamson > > wrote: > > > > > > FRU-type information is only one of the use cases of VPD, the spec also > > defines (PCI rev 3.0, 6.4): > > > >... a mechanism for storing information such

Re: [PATCH] x86: Wire up 32-bit direct socket calls

2015-09-15 Thread H. Peter Anvin
On 09/14/2015 06:35 AM, Ingo Molnar wrote: >> >> I missed sys_ipc entirely. >> >> Ingo, Thomas, want to just wire those up, too? I can send a patch >> next week, but it'll be as trivial as the socket one. > > Yeah, sure - split out system calls are so much better (and slightly faster) > than >

Re: [PATCH V4 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-09-15 Thread Rustad, Mark D
> On Sep 15, 2015, at 12:04 PM, Alex Williamson > wrote: > > > FRU-type information is only one of the use cases of VPD, the spec also > defines (PCI rev 3.0, 6.4): > >... a mechanism for storing information such as performance and >failure data on the device being monitored. >

[PATCH] net: mvneta: fix DMA buffer unmapping in mvneta_rx()

2015-09-15 Thread Simon Guinot
This patch fixes a regression introduced by the commit a84e32894191 ("net: mvneta: fix refilling for Rx DMA buffers"). Due to this commit the newly allocated Rx buffers are DMA-unmapped in place of those passed to the networking stack. Obviously, this causes data corruptions. This patch fixes the

Re: stmmac: improve logging

2015-09-15 Thread David Miller
From: LABBE Corentin Date: Thu, 10 Sep 2015 14:37:28 +0200 > This patch series try to improve logging of the stmmac driver. > > Changes since v1 > - Use netdev_xxx instead of dev_xxx > - Use netif_xxx instead of "if (netif_msg_type) dev_xxx" This series does not apply cleanly to the current tre

[PATCH v3 net-next 2/2] ipv4: ICMP packet inspection for multipath

2015-09-15 Thread Peter Nørlund
ICMP packets are inspected to let them route together with the flow they belong to, minimizing the chance that a problematic path will affect flows on other paths, and so that anycast environments can work with ECMP. Signed-off-by: Peter Nørlund --- include/net/route.h | 12 +++- net/ipv

[PATCH v3 net-next 1/2] ipv4: L3 hash-based multipath

2015-09-15 Thread Peter Nørlund
Replaces the per-packet multipath with a hash-based multipath using source and destination address. Signed-off-by: Peter Nørlund --- include/net/ip_fib.h | 11 ++-- net/ipv4/fib_semantics.c | 137 +-- net/ipv4/route.c | 23 +++- 3 fil

[PATCH v3 net-next 0/2] ipv4: Hash-based multipath routing

2015-09-15 Thread Peter Nørlund
When the routing cache was removed in 3.6, the IPv4 multipath algorithm changed from more or less being destination-based into being quasi-random per-packet scheduling. This increases the risk of out-of-order packets and makes it impossible to use multipath together with anycast services. This pat

Re: [PATCH v2] net: mvneta: fix refilling for Rx DMA buffers

2015-09-15 Thread Simon Guinot
On Mon, Sep 14, 2015 at 01:22:12PM -0700, Oren Laskin wrote: > I had to undo this change on my Amada 370 based board. It was causing > corrupt data to make it through on large downloads. I'm using wget to get > the same 30MB file many times and the SHA would occasionally be different. > I tracked

Re: [net-next:master 6/12] include/linux/usb/cdc.h:23: error: redefinition of 'struct usb_cdc_parsed_header'

2015-09-15 Thread David Miller
From: kbuild test robot Date: Wed, 16 Sep 2015 03:57:11 +0800 > All error/warnings (new ones prefixed by >>): > >In file included from drivers/usb/gadget/function/u_ether.h:20, > from drivers/usb/gadget/legacy/cdc2.c:16: >include/linux/usb/cdc.h:47: warning: 'struct u

Re: [net-next:master 6/10] include/linux/usb/cdc.h:47:5: warning: 'struct usb_interface' declared inside parameter list

2015-09-15 Thread David Miller
From: kbuild test robot Date: Wed, 16 Sep 2015 03:56:14 +0800 > All warnings (new ones prefixed by >>): > >In file included from drivers/usb/gadget/function/u_serial.h:16:0, > from drivers/usb/gadget/function/f_acm.c:23: >>> include/linux/usb/cdc.h:47:5: warning: 'struct

Re: v2 of seccomp filter c/r patches

2015-09-15 Thread Andy Lutomirski
On Tue, Sep 15, 2015 at 11:26 AM, Tycho Andersen wrote: > Hi Andy, > > On Tue, Sep 15, 2015 at 11:13:51AM -0700, Andy Lutomirski wrote: >> On Tue, Sep 15, 2015 at 9:07 AM, Tycho Andersen >> wrote: >> > Hi Andy, >> > >> > On Mon, Sep 14, 2015 at 10:52:46AM -0700, Andy Lutomirski wrote: >> >> >> >>

[net-next:master 6/12] include/linux/usb/cdc.h:23: error: redefinition of 'struct usb_cdc_parsed_header'

2015-09-15 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 8b711d6db5c78a6d1969fb0fccb93daa7df53762 commit: c40a2c8817e42273a4627c48c884b805475a733f [6/12] CDC: common parser for extra headers config: avr32-atngw100_defconfig (attached as .config) reproduce: wget

[net-next:master 6/10] include/linux/usb/cdc.h:47:5: warning: 'struct usb_interface' declared inside parameter list

2015-09-15 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 7b6ee48d3f4d432bfa6c9c9662fbdbd97681240e commit: c40a2c8817e42273a4627c48c884b805475a733f [6/10] CDC: common parser for extra headers config: x86_64-acpi-redef (attached as .config) reproduce: git checkout

Re: [PATCH] mv643xx_eth: Neaten mv643xx_eth_program_multicast_filter

2015-09-15 Thread David Miller
From: Joe Perches Date: Wed, 09 Sep 2015 17:40:56 -0700 > The code around the allocation and loops are a bit obfuscated. > > Neaten it by using: > > o kcalloc with decimal count and sizeof(u32) > o Decimal loop indexing and i++ not i += 4 > o A promiscuous block using a similar style > to the

[PATCH net] rtnetlink: catch -EOPNOTSUPP errors from ndo_bridge_getlink

2015-09-15 Thread Roopa Prabhu
From: Roopa Prabhu problem reported: kernel 4.1.3 # bridge vlan portvlan ids eth0 1 PVID Egress Untagged 90 91 92 93 94 95 9

Re: [PATCH net-next 0/2] driver: net: xgene: Enable 2nd 10GbE port on APM X-Gene SoC

2015-09-15 Thread David Miller
From: Iyappan Subramanian Date: Tue, 8 Sep 2015 15:50:25 -0700 > This patch adds support for 2nd 10GbE on APM X-Gene SoC Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: [PATCH 3/5] cdc-ether: switch to common CDC parser

2015-09-15 Thread David Miller
From: Oliver Neukum Date: Mon, 7 Sep 2015 16:05:40 +0200 > This patch uses the common parser to parse extra CDC > headers in order to reduce code duplication. > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messag

Re: [PATCH 2/5] cdc-ncm: use common parser

2015-09-15 Thread David Miller
From: Oliver Neukum Date: Mon, 7 Sep 2015 16:05:39 +0200 > This moves cdc-ncm to the common parser for CDC user > to reduce code duplication. > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vg

Re: [PATCH 4/5] qmi-wwan: use common parser

2015-09-15 Thread David Miller
From: Oliver Neukum Date: Mon, 7 Sep 2015 16:05:41 +0200 > This moves qmi-wwan to the common parser for CDC user > to reduce code duplication. > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@v

Re: [PATCH 5/5] cdc-phonet: use common parser

2015-09-15 Thread David Miller
From: Oliver Neukum Date: Mon, 7 Sep 2015 16:05:42 +0200 > This moves cdc-phonet to the common parser for CDC users > to reduce code duplication. > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord..

Re: [PATCH 1/5] CDC: common parser for extra headers

2015-09-15 Thread David Miller
From: Oliver Neukum Date: Mon, 7 Sep 2015 16:05:38 +0200 > CDC drivers all implement their own parser for the extra headers. > This patch fixes the code duplication introducing a single common > parser in usbnet. > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send

Re: [net-next PATCH v3] drivers: net: cpsw: Add support to drive gpios for ethernet to be functional

2015-09-15 Thread David Miller
From: Mugunthan V N Date: Mon, 7 Sep 2015 15:16:44 +0530 > In DRA72x EVM, by default slave 1 is connected to the onboard > phy, but slave 2 pins are also muxed with video input module > which is controlled by pcf857x gpio and currently to select slave > 0 to connect to phy gpio hogging is used, b

Re: [PATCH] Net: core: sock.c coding style fixes

2015-09-15 Thread Krzysztof Majzerowicz-Jaszcz
> 200 checkpatch changes in one commit? > > imo it makes sense to fix coding style only if nearby lines are > affected by meaningful changes. > Just blank rewrites like these are more harmful than useful. > They distort git blame, make backporting harder, etc. I'll keep that in mind, thank you.

Re: [PATCH RFC] solos-pci: Fix BUG() with shared skb

2015-09-15 Thread David Woodhouse
On Wed, 2013-09-04 at 21:41 +0100, David Woodhouse wrote: > On Wed, 2013-09-04 at 14:30 -0400, David Miller wrote: > > skb_realloc_headroom() should do everything you need. > > Great, thanks! Something like this then... ? > > diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c > index

Re: [PATCH V4 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-09-15 Thread Alex Williamson
On Tue, 2015-09-15 at 18:39 +, Rustad, Mark D wrote: > > On Sep 15, 2015, at 11:19 AM, Alex Williamson > > wrote: > > > > In addition to the (PCI_SLOT() != devfn) issue, I'm concerned about > > topologies like we see on Skylake. IIRC, the integrated NIC appears at > > something like 00:1f.6

Re: [PATCH] Net: core: sock.c coding style fixes

2015-09-15 Thread Krzysztof Majzerowicz-Jaszcz
> From: Krzysztof Majzerowicz-Jaszcz > Date: Tue, 15 Sep 2015 20:36:29 +0200 > >> OK, sorry. I'll undo the comments then. Do you have any other >> suggestions? > > I think even the non-comment changes make the code look less nice. > > Why don't you just pass on these cleanups for now? Thanks.

Re: [PATCH net-next 0/7] net: dsa: mv88e6xxx: improve ATU move operations

2015-09-15 Thread David Miller
From: Vivien Didelot Date: Fri, 4 Sep 2015 14:34:09 -0400 > This patchset completes the set of available Address Translation Unit > operations. > > These Marvell switches have 4 operations to flush or (re)move, all or > only non-static MAC addresses, from the entire set of databases or from > j

Re: [PATCH net-next 3/3 v2] net: Allow user to get table id from route lookup

2015-09-15 Thread David Miller
From: David Ahern Date: Wed, 2 Sep 2015 13:58:36 -0700 > rt_fill_info which is called for 'route get' requests hardcodes the > table id as RT_TABLE_MAIN which is not correct when multiple tables > are used. Use the newly added table id in the rtable to send back > the correct table similar to wh

Re: kernel 4.2 : "bridge vlan" command return empty result (works with kernel 4.1.3)

2015-09-15 Thread roopa
On 9/15/15, 10:39 AM, Alexandre DERUMIER wrote: Hi, since kernel 4.2, "bridge vlan" command return empty result. kernel 4.1.3 # bridge vlan portvlan ids eth0 1 PVID Egress Untagged 90 91 92 93 94 95 96

Re: [PATCH net-next 2/3] net: Add FIB table id to rtable

2015-09-15 Thread David Miller
From: David Ahern Date: Wed, 2 Sep 2015 13:58:35 -0700 > Add the FIB table id to rtable to make the information available for > IPv4 as it is for IPv6. > > Signed-off-by: David Ahern Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majo

Re: [PATCH net-next 1/3] net: Refactor rtable initialization

2015-09-15 Thread David Miller
From: David Ahern Date: Wed, 2 Sep 2015 13:58:34 -0700 > All callers to rt_dst_alloc have nearly the same initialization following > a successful allocation. Consolidate it into rt_dst_alloc. > > Signed-off-by: David Ahern Applied. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] [PATCH v3] add stealth mode

2015-09-15 Thread David Miller
From: Matteo Croce Date: Wed, 2 Sep 2015 10:47:35 +0200 > Add option to disable any reply not related to a listening socket, > like RST/ACK for TCP and ICMP Port-Unreachable for UDP. > Also disables ICMP replies to echo request and timestamp. > The stealth mode can be enabled selectively for a s

Re: [PATCH for-next] cxgb4: add device ID for few T5 adapters

2015-09-15 Thread David Miller
From: Hariprasad Shenai Date: Tue, 15 Sep 2015 17:20:09 +0530 > Signed-off-by: Hariprasad Shenai Adding just some new device IDs is definitely 'net' material, mind if I apply it there instead? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to major

Re: [PATCH] Net: core: sock.c coding style fixes

2015-09-15 Thread David Miller
From: Alexei Starovoitov Date: Tue, 15 Sep 2015 11:43:49 -0700 > imo it makes sense to fix coding style only if nearby lines are > affected by meaningful changes. > Just blank rewrites like these are more harmful than useful. > They distort git blame, make backporting harder, etc. +1 -- To unsub

Re: [PATCH] Net: core: sock.c coding style fixes

2015-09-15 Thread David Miller
From: Krzysztof Majzerowicz-Jaszcz Date: Tue, 15 Sep 2015 20:36:29 +0200 > OK, sorry. I'll undo the comments then. Do you have any other > suggestions? I think even the non-comment changes make the code look less nice. Why don't you just pass on these cleanups for now? Thanks. -- To unsubscrib

Re: kernel panic in pppoe_release

2015-09-15 Thread Guillaume Nault
On Thu, Sep 03, 2015 at 12:14:32PM -0700, Murat Sezgin wrote: > I just wonder , if the > proposed patch by Denys Fedoryshchenko, which is below, fixes this issue > completely. > >     pppox_unbind_sock(sk); >     +/* Signal the death of the socket. */ >     +sk->sk_state = PPPOX_DEAD;

Re: [PATCH] Net: core: sock.c coding style fixes

2015-09-15 Thread Alexei Starovoitov
On Tue, Sep 15, 2015 at 08:36:29PM +0200, Krzysztof Majzerowicz-Jaszcz wrote: > OK, sorry. I'll undo the comments then. Do you have any other suggestions? > > KMJ > > On 15/09/15 20:22, Eric W. Biederman wrote: > > Krzysztof Majzerowicz-Jaszcz writes: > > > >> Fixed most coding style issues rep

Re: [PATCH V4 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-09-15 Thread Rustad, Mark D
> On Sep 15, 2015, at 11:19 AM, Alex Williamson > wrote: > > In addition to the (PCI_SLOT() != devfn) issue, I'm concerned about > topologies like we see on Skylake. IIRC, the integrated NIC appears at > something like 00:1f.6. I don't know if that specific NIC has VPD, nor > am I sure it real

Re: [PATCH] Net: core: sock.c coding style fixes

2015-09-15 Thread Krzysztof Majzerowicz-Jaszcz
OK, sorry. I'll undo the comments then. Do you have any other suggestions? KMJ On 15/09/15 20:22, Eric W. Biederman wrote: > Krzysztof Majzerowicz-Jaszcz writes: > >> Fixed most coding style issues reported by checkpatch.pl > > Ugh. At least in the matter of comments I find this patch makes >

Re: [PATCH] Net: core: sock.c coding style fixes

2015-09-15 Thread Eric W. Biederman
Krzysztof Majzerowicz-Jaszcz writes: > Fixed most coding style issues reported by checkpatch.pl Ugh. At least in the matter of comments I find this patch makes the code uglier. Replacing: /* * Important banner about the code */ with /* Important banner about the code */ Does n

Re: v2 of seccomp filter c/r patches

2015-09-15 Thread Tycho Andersen
Hi Andy, On Tue, Sep 15, 2015 at 11:13:51AM -0700, Andy Lutomirski wrote: > On Tue, Sep 15, 2015 at 9:07 AM, Tycho Andersen > wrote: > > Hi Andy, > > > > On Mon, Sep 14, 2015 at 10:52:46AM -0700, Andy Lutomirski wrote: > >> > >> I'm not sure I entirely like this solution... > > > > Ok. Since we a

Re: [PATCH V4 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-09-15 Thread Alex Williamson
On Mon, 2015-07-13 at 11:40 -0700, Mark D Rustad wrote: > From: Mark Rustad > > Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through > function 0 to provide VPD access on other functions. This is for > hardware devices that provide copies of the same VPD capability > registers in

Re: [net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR

2015-09-15 Thread Phil Sutter
On Tue, Sep 15, 2015 at 11:11:53AM -0400, Vlad Yasevich wrote: > On 09/14/2015 04:06 PM, Phil Sutter wrote: > > On Mon, Sep 14, 2015 at 02:21:10PM -0400, Vlad Yasevich wrote: > >> On 09/11/2015 04:20 PM, Phil Sutter wrote: > >>> On Fri, Sep 11, 2015 at 12:24:45PM -0700, Stephen Hemminger wrote: > >

Re: [PATCH v3 net 0/5] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-15 Thread Martin KaFai Lau
On Mon, Sep 14, 2015 at 07:56:37PM -0700, David Miller wrote: > From: David Miller > Date: Mon, 14 Sep 2015 19:49:25 -0700 (PDT) > > > Series applied, thanks Martin. > > Actually, reverted, this doesn't even compile :-/ > > In file included from include/linux/srcu.h:33:0, > from i

Re: List corruption on epoll_ctl(EPOLL_CTL_DEL) an AF_UNIX socket

2015-09-15 Thread Mathias Krause
On Tue, Sep 15, 2015 at 06:07:05PM +0100, Rainer Weikusat wrote: > --- a/net/unix/af_unix.c > +++ b/net/unix/af_unix.c > -2233,10 +2233,14 static unsigned int > unix_dgram_poll(struct file *file, struct socket *sock, > writable = unix_writable(sk); > other = unix_peer_get(sk)

Re: v2 of seccomp filter c/r patches

2015-09-15 Thread Andy Lutomirski
On Tue, Sep 15, 2015 at 9:07 AM, Tycho Andersen wrote: > Hi Andy, > > On Mon, Sep 14, 2015 at 10:52:46AM -0700, Andy Lutomirski wrote: >> >> I'm not sure I entirely like this solution... > > Ok. Since we also aren't going to do all the eBPF stuff now, how about > something that looks like this: >

[PATCH] Net: core: sock.c coding style fixes

2015-09-15 Thread Krzysztof Majzerowicz-Jaszcz
Fixed most coding style issues reported by checkpatch.pl Signed-off-by: Krzysztof Majzerowicz-Jaszcz --- net/core/sock.c | 442 +--- 1 file changed, 200 insertions(+), 242 deletions(-) diff --git a/net/core/sock.c b/net/core/sock.c index ca298

Re: [PATCH] pptp: avoid releasing the sock too early

2015-09-15 Thread Sasha Levin
On 09/14/2015 12:43 PM, Eric Dumazet wrote: > Hmm, is the synchronize_rcu() in del_chan() still needed, and why it was > not enough ? > > I believe your patch might reduce the race window, but it is not clear > it is the right fix. You're right, I've missed the synchronize_rcu() originally. At th

kernel 4.2 : "bridge vlan" command return empty result (works with kernel 4.1.3)

2015-09-15 Thread Alexandre DERUMIER
Hi, since kernel 4.2, "bridge vlan" command return empty result. kernel 4.1.3 # bridge vlan portvlan ids eth0 1 PVID Egress Untagged 90 91 92 93 94 95 96 97 98 99 100 vmbr0

Re: [Xen-devel] [PATCHv1 net] xen-netback: require fewer guest Rx slots when not using GSO

2015-09-15 Thread David Miller
From: David Vrabel Date: Tue, 15 Sep 2015 11:30:17 +0100 > This is causing regressions with certain frontend drivers. Can you > drop it, please? All patches applied to my tree are part of the permanent record, and this one even made it's way to Linus already I think. So what you need to do is

Re: List corruption on epoll_ctl(EPOLL_CTL_DEL) an AF_UNIX socket

2015-09-15 Thread Rainer Weikusat
Mathias Krause writes: > this is an attempt to resurrect the thread initially started here: > > http://thread.gmane.org/gmane.linux.network/353003 > > As that patch fixed the issue for the mentioned reproducer, it did not > fix the bug for the production code Olivier is using. :( > > Changing th

[PATCH] net: Add documentation for VRF device

2015-09-15 Thread David Ahern
Signed-off-by: David Ahern --- Documentation/networking/vrf.txt | 96 MAINTAINERS | 1 + 2 files changed, 97 insertions(+) create mode 100644 Documentation/networking/vrf.txt diff --git a/Documentation/networking/vrf.txt b/Documenta

Re: IPv6 routing/fragmentation panic

2015-09-15 Thread Michal Kubecek
On Tue, Sep 15, 2015 at 04:53:20PM +0100, David Woodhouse wrote: > I'm not entirely sure how to interpret the above stack trace. Is the > incoming IPv6 packet being reassembled for netfilter's benefit, then re > -fragmented for transmission? Not refragmented. Both the reassembled packet and the or

Re: v2 of seccomp filter c/r patches

2015-09-15 Thread Tycho Andersen
Hi Andy, On Mon, Sep 14, 2015 at 10:52:46AM -0700, Andy Lutomirski wrote: > > I'm not sure I entirely like this solution... Ok. Since we also aren't going to do all the eBPF stuff now, how about something that looks like this: struct seccomp_layer { unsigned int size; unsigned int type; /* S

IPv6 routing/fragmentation panic

2015-09-15 Thread David Woodhouse
I can repeatably crash my router with 'ping6 -s 2000' to an external machine: [ 61.741618] skbuff: skb_under_panic: text:c1277f1e len:1294 put:14 head:dec98000 data:dec97ffc tail:0xdec9850a end:0xdec98f40 dev:br-lan [ 61.754128] [ cut here ] [ 61.758754] Kernel BUG a

RE: [v2 04/11] soc/fsl: Introduce drivers for the DPAA QMan

2015-09-15 Thread Roy Pledge
> -Original Message- > From: Wood Scott-B07421 > Sent: Friday, September 11, 2015 9:10 PM > To: Pledge Roy-R01356 > Cc: linuxppc-...@lists.ozlabs.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [v2 04/11] soc/fsl: Introduce drivers for the DPAA QMan > > On We

[PATCH 1/2 v2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM

2015-09-15 Thread Ondrej Zary
IW_AUTH_ALG_OPEN_SYSTEM is ambiguous in set_auth for WEP as wpa_supplicant uses it for both no encryption and WEP open system. Cache the last mode set (only of these two) and use it here. This allows wpa_supplicant to work with unencrypted APs. Signed-off-by: Ondrej Zary --- drivers/net/wireles

[PATCH 2/2] airo: Implement netif_carrier_on/off

2015-09-15 Thread Ondrej Zary
Add calls to netif_carrier_on and netif_carrier_off Signed-off-by: Ondrej Zary --- drivers/net/wireless/airo.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c index a8f2767..629245c 100644 --- a/drivers/net/wir

Re: [net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR

2015-09-15 Thread Vlad Yasevich
On 09/14/2015 04:06 PM, Phil Sutter wrote: > On Mon, Sep 14, 2015 at 02:21:10PM -0400, Vlad Yasevich wrote: >> On 09/11/2015 04:20 PM, Phil Sutter wrote: >>> On Fri, Sep 11, 2015 at 12:24:45PM -0700, Stephen Hemminger wrote: On Fri, 11 Sep 2015 21:22:03 +0200 Phil Sutter wrote:

[PATCH net-next] xen-netfront: always set num queues if possible

2015-09-15 Thread Charles (Chas) Williams
If netfront connects with two (or more) queues and then reconnects with only one queue it fails to delete or rewrite the multi-queue-num-queues key and netback will try to use the wrong number of queues. Always write the num-queues field if the backend has multi-queue support. Signed-off-by: Chas

Re: [PATCH v7 3/3] can: Allwinner A10/A20 CAN Controller support - Kernel module

2015-09-15 Thread Marc Kleine-Budde
On 09/15/2015 04:28 PM, Maxime Ripard wrote: >> +static int sunxican_get_berr_counter(const struct net_device *dev, >> + struct can_berr_counter *bec) >> +{ >> +struct sunxican_priv *priv = netdev_priv(dev); >> +u32 errors; >> +int err; >> + >> +err =

Re: [Xen-devel] [PATCH net-next] xen-netfront: always set num queues if possible

2015-09-15 Thread Charles (Chas) Williams
On Tue, 2015-09-15 at 11:59 +0100, David Vrabel wrote: > On 14/09/15 22:28, Charles (Chas) Williams wrote: > > The xen store preserves this information across module invocations. > > If you insmod netfront with two queues and later insmod again with one > > queue, the backend will still believe you

Re: [PATCH v7 3/3] can: Allwinner A10/A20 CAN Controller support - Kernel module

2015-09-15 Thread Maxime Ripard
On Tue, Sep 15, 2015 at 01:17:12AM +0200, Gerhard Bertelsmann wrote: > Kernel module for Allwinner A10/A20 CAN > > Signed-off-by: Gerhard Bertelsmann > --- > > drivers/net/can/Kconfig| 10 + > drivers/net/can/Makefile | 1 + > drivers/net

Re: [PATCH] xfrm: Add oif to dst lookups

2015-09-15 Thread David Ahern
Hi Steffen: On 9/15/15 3:28 AM, Steffen Klassert wrote: On Mon, Aug 10, 2015 at 04:58:11PM -0600, David Ahern wrote: Rules can be installed that direct route lookups to specific tables based on oif. Plumb the oif through the xfrm lookups so it gets set in the flow struct and passed to the resol

[PATCH for-next] cxgb4: add device ID for few T5 adapters

2015-09-15 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h index 8353a6c..03ed00c 100644 --- a/drivers/net

Re: [Xen-devel] [PATCH net-next] xen-netfront: always set num queues if possible

2015-09-15 Thread David Vrabel
On 14/09/15 22:28, Charles (Chas) Williams wrote: > The xen store preserves this information across module invocations. > If you insmod netfront with two queues and later insmod again with one > queue, the backend will still believe you asked for two queues. Can you rewrite the commit message to b

[PATCH net-next 3/5] qeth: move OSA portname into deprecated status

2015-09-15 Thread Ursula Braun
From: Ursula Braun An OSA-Express port name was required to identify a shared OSA port. All operating system instances that shared the port had to use the same port name. This requirement no longer applies. Signed-off-by: Ursula Braun --- drivers/s390/net/qeth_core.h | 2 -- drivers/s390

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Add port attribute when tracking counters"

2015-09-15 Thread Alexey Kardashevskiy
Any luck with that? On 09/04/2015 01:36 PM, Alexey Kardashevskiy wrote: On 09/03/2015 10:09 PM, eran ben elisha wrote: On Mon, Aug 31, 2015 at 5:39 AM, Alexey Kardashevskiy wrote: On 08/30/2015 04:28 PM, Or Gerlitz wrote: On Fri, Aug 28, 2015 at 7:06 AM, Alexey Kardashevskiy wrote: 6823

[PATCH net-next 4/5] qeth: add layer 2 RX/TX checksum offloading

2015-09-15 Thread Ursula Braun
From: Thomas Richter Checksum offloading for send and receive is already supported for layer 3 (IP layer). This patch adds support for RX and TX hardware checksum offloading for layer 2 (MAC layer). The hardware calculates the checksum for IP UDP and TCP packets. This patch moves the hardware ch

[PATCH net-next 0/5] s390: qeth and iucv patches

2015-09-15 Thread Ursula Braun
From: Ursula Braun Hi Dave, here are some s390 related qeth patches for net-next. The patch by Thomas Richter adds a new feature to the qeth layer2 code; the remaining patches are minor improvements. shortlog: Eugene Crosser (1): qeth: remove extraneous length from %pM format Lakhvich Dmitr

[PATCH net-next 5/5] s390/iucv: do not use arrays as argument

2015-09-15 Thread Ursula Braun
From: Ursula Braun The iucv code uses arrays as arguments. Even though this does not really cause a problem, it could be misleading, since the compiler turns array arguments into just a pointer argument. To be more precise this patch changes the array arguments into pointers. Signed-off-by: Ursu

[PATCH net-next 2/5] qeth: no write permission for readonly sysattr

2015-09-15 Thread Ursula Braun
From: Lakhvich Dmitriy User is not allowed to write into bridge_state sysfs file. Fixed attribute not mislead the user Signed-off-by: Lakhvich Dmitriy Signed-off-by: Ursula Braun Reported-by: Peter Oberparleiter Reviewed-by: Eugene Crosser Reviewed-by: Thomas Richter --- drivers/s390/net/q

[PATCH net-next 1/5] qeth: remove extraneous length from %pM format

2015-09-15 Thread Ursula Braun
From: Eugene Crosser Length specifier in the %pM format is not supported (at least, not documented). Remove it, and also an extraneous '&' for the array. Signed-off-by: Eugene Crosser Signed-off-by: Ursula Braun Suggested-by: Joe Perches --- drivers/s390/net/qeth_l2_main.c | 4 ++-- 1 file c

Re: [Xen-devel] [PATCHv1 net] xen-netback: require fewer guest Rx slots when not using GSO

2015-09-15 Thread David Vrabel
On 09/09/15 20:34, David Miller wrote: > From: David Vrabel > Date: Tue, 8 Sep 2015 14:25:14 +0100 > >> Commit f48da8b14d04ca87ffcffe68829afd45f926ec6a (xen-netback: fix >> unlimited guest Rx internal queue and carrier flapping) introduced a >> regression. >> >> The PV frontend in IPXE only place

Re: [PATCH v2] net: mvneta: fix refilling for Rx DMA buffers

2015-09-15 Thread Vincent Donnefort
Hi Oren, On Mon, Sep 14, 2015 at 03:16:50PM -0700, Oren Laskin wrote: > I would hit this error on my Armada 370 board about 20% of the time > after downloading a 30MB file to /tmp. We're running a 1 Gb SGMII > link. I would hit this in less than a minute before removing this > commit from my tre

Re: [PATCH] xfrm: Add oif to dst lookups

2015-09-15 Thread Steffen Klassert
On Mon, Aug 10, 2015 at 04:58:11PM -0600, David Ahern wrote: > Rules can be installed that direct route lookups to specific tables based > on oif. Plumb the oif through the xfrm lookups so it gets set in the flow > struct and passed to the resolver routines. > > Signed-off-by: David Ahern David,

Attached Letter is For Your Payment

2015-09-15 Thread Mrs.Ann Wallace.
LETTER OF PAYMENT (1).pdf Description: Adobe PDF document

[PATCH] net: qdisc: enhance default_qdisc documentation

2015-09-15 Thread Phil Sutter
Aside from some lingual cleanup, point out which interfaces are not or partly covered by this setting. Signed-off-by: Phil Sutter --- Documentation/sysctl/net.txt | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/Documentation/sysctl/net.txt b/Documentation/sys

Re: [PATCH] at86rf230: fix build warning

2015-09-15 Thread Sudip Mukherjee
On Fri, Sep 11, 2015 at 03:16:04PM +0530, Sudip Mukherjee wrote: > e616a00ce786 ("drivers/net/ieee802154/at86rf230.c: seq_printf() now returns > NULL") > has removed the usage of the integer "ret" but missed removing the > variable. And we were getting a build warning about "unused variable". > >

Re: [PATCH v7 2/3] can: Allwinner A10/A20 CAN Controller support - Defconfigs

2015-09-15 Thread Maxime Ripard
Hi, On Tue, Sep 15, 2015 at 01:17:11AM +0200, Gerhard Bertelsmann wrote: > Defconfigs for Allwinner A10/A20 CAN driver > > Signed-off-by: Gerhard Bertelsmann > --- > > arch/arm/configs/multi_v7_defconfig| 1 + > arch/arm/configs/sunxi_defconfig | 2 + > 2

Re: [PATCH v7 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings

2015-09-15 Thread Maxime Ripard
Hi, On Tue, Sep 15, 2015 at 01:17:10AM +0200, Gerhard Bertelsmann wrote: > Devicetree bindings for Allwinner A10/A20 CAN > > Signed-off-by: Gerhard Bertelsmann > --- > > .../devicetree/bindings/net/can/sun4i_can.txt | 38 + > 1 file changed, 38 insertions(+) > > diff --git a/Documentati

<    1   2