Re: [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time

2015-09-18 Thread Jiri Pirko
Fri, Sep 18, 2015 at 09:55:51PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Signed-off-by: Scott Feldman Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [PATCH net-next 5/7] rocker: add FDB cleanup timer

2015-09-18 Thread Jiri Pirko
Fri, Sep 18, 2015 at 09:55:49PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Add a timer to each rocker switch to do FDB entry cleanup by ageing out >expired entries. The timer scheduling algo is copied from the bridge >driver, for the most part, to keep the firing of the timer to a min

Re: [PATCH net-next 6/7] bridge: don't age externally added FDB entries

2015-09-18 Thread Jiri Pirko
Fri, Sep 18, 2015 at 09:55:50PM CEST, sfel...@gmail.com wrote: >From: Siva Mannem > >Signed-off-by: Siva Mannem >Signed-off-by: Scott Feldman Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More maj

Re: [PATCH net-next 4/7] bridge: define some min/max ageing time constants we'll use next

2015-09-18 Thread Jiri Pirko
Fri, Sep 18, 2015 at 09:55:48PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Signed-off-by: Scott Feldman >--- > include/linux/if_bridge.h |4 > 1 file changed, 4 insertions(+) > >diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h >index dad8b00..6cc6dbc 100644 >

Re: [PATCH net-next 1/7] rocker: track when FDB entry is touched.

2015-09-18 Thread Jiri Pirko
Fri, Sep 18, 2015 at 09:55:45PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >The entry is touched once when created, and touched again for each update. >The touched time is used to calculate FDB entry age. > >Signed-off-by: Scott Feldman Acked-by: Jiri Pirko -- To unsubscribe from thi

Re: [PATCH net-next 2/7] rocker: store rocker_port in fdb key rather than pport

2015-09-18 Thread Jiri Pirko
Fri, Sep 18, 2015 at 09:55:46PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >We'll need more info from rocker_port than just pport when we age out fdb >entries, so store rocker_port rather than pport in each fdb entry. > >Signed-off-by: Scott Feldman Acked-by: Jiri Pirko -- To unsubsc

Re: [PATCH net-next 3/7] rocker: adding port ageing_time for ageing out FDB entries

2015-09-18 Thread Jiri Pirko
Fri, Sep 18, 2015 at 09:55:47PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Follow-up patcheset will allow user to change ageing_time, but for now >just hard-code it to a fixed value (the same value used as the default >for the bridge driver). > >Signed-off-by: Scott Feldman >--- > dri

Re: [PATCH] Revert "net/phy: Add Vitesse 8641 phy ID"

2015-09-18 Thread Kevin Hao
On Fri, Sep 18, 2015 at 09:36:42AM +, Shaohui Xie wrote: > > -Original Message- > > From: Kevin Hao [mailto:haoke...@gmail.com] > > Sent: Friday, September 18, 2015 3:43 PM > > To: netdev@vger.kernel.org > > Cc: Florian Fainelli; Xie Shaohui-B21989 > > Subject: [PATCH] Revert "net/phy:

epoll, missed opportunity?

2015-09-18 Thread Jonathan Marler
I'm curious why there wasn't another field added to the epoll_event struct for the application to store the descriptor's context. Any useful multi-plexing application will have a context that will need to be retrieved every time a descriptor needs to be serviced. Since the epoll api has no way of s

Re: [PATCH net] openvswitch: Zero flows on allocation.

2015-09-18 Thread Pravin Shelar
On Fri, Sep 18, 2015 at 7:06 PM, Jesse Gross wrote: > OVS tries to be clever about not touching the parts of a flow that > aren't used. This can include leaving pieces of memory uninitialized > if the mask is zero and therefore the value would be ignored anyways. > > While this works fine for the

Re: [PATCH] net/wireless: enable wiphy device to suspend/resume asynchronously

2015-09-18 Thread Fu, Zhonghui
On 2015/8/24 15:38, Johannes Berg wrote: > On Mon, 2015-08-24 at 11:45 +0800, Fu, Zhonghui wrote: >> On 2015/8/17 16:46, Arend van Spriel wrote: >>> + Rafael >>> >>> On 08/17/2015 09:29 AM, Johannes Berg wrote: On Mon, 2015-08-17 at 09:48 +0800, Fu, Zhonghui wrote: > The suspend/resume t

[PATCH v2] net/wireless: enable wiphy device to suspend/resume asynchronously

2015-09-18 Thread Fu, Zhonghui
Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables wiphy device to

Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-18 Thread Jesse Gross
On Fri, Sep 18, 2015 at 6:36 PM, John W. Linville wrote: > On Fri, Sep 18, 2015 at 02:49:30PM -0700, Jesse Gross wrote: >> On Fri, Sep 18, 2015 at 1:40 PM, John W. Linville >> wrote: >> > On Fri, Sep 18, 2015 at 01:30:36PM -0700, Jesse Gross wrote: >> >> On Thu, Sep 17, 2015 at 1:34 PM, John W. L

[PATCH net] openvswitch: Zero flows on allocation.

2015-09-18 Thread Jesse Gross
OVS tries to be clever about not touching the parts of a flow that aren't used. This can include leaving pieces of memory uninitialized if the mask is zero and therefore the value would be ignored anyways. While this works fine for the purposes of matching (which must always look at the mask), ser

Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-18 Thread John W. Linville
On Fri, Sep 18, 2015 at 02:49:30PM -0700, Jesse Gross wrote: > On Fri, Sep 18, 2015 at 1:40 PM, John W. Linville > wrote: > > On Fri, Sep 18, 2015 at 01:30:36PM -0700, Jesse Gross wrote: > >> On Thu, Sep 17, 2015 at 1:34 PM, John W. Linville > >> wrote: > >> > This seems to have been a "thinko".

RE: [PATCH net] bna: check for dma mapping errors

2015-09-18 Thread Rasesh Mody
> From: Ivan Vecera [mailto:ivec...@redhat.com] > Sent: Wednesday, September 16, 2015 6:28 AM > > Check for DMA mapping errors, recover from them and register them in > ethtool stats like other errors. Acked-by: Rasesh Mody Thanks! Rasesh > Cc: Rasesh Mody > Signed-off-by: Ivan Vecera > ---

[PATCH net-next] tcp: Fix CWV being too strict on thin streams

2015-09-18 Thread Bendik Rønning Opstad
Application limited streams such as thin streams, that transmit small amounts of payload in relatively few packets per RTT, are prevented from growing the CWND after experiencing loss. This leads to increased sojourn times for data segments in streams that often transmit time-dependent data. After

Re: [linux-next] oops in ip_route_input_noref

2015-09-18 Thread Andrew Morton
On Thu, 17 Sep 2015 10:58:52 +0200 Thierry Reding wrote: > On Wed, Sep 16, 2015 at 09:04:15AM -0600, David Ahern wrote: > > On 9/16/15 9:00 AM, Fabio Estevam wrote: > > >On Wed, Sep 16, 2015 at 6:24 AM, Sergey Senozhatsky > > > wrote: > > > > > >>added by b7503e0cdb5dbec5d201aa69dc14679b5ae8

Re: [PATCH net 2/2] 8139cp: reset BQL when ring tx ring cleared

2015-09-18 Thread David Woodhouse
On Fri, 2015-09-18 at 01:44 +0200, Francois Romieu wrote: > The TxDmaOkLowDesc register may tell if the Tx dma part is still > making any progress. I have added a TxPoll request. See below. It isn't making any progress. And TxPoll doesn't help. The only thing I've found that restarts it is to cle

[PATCH net-next] bnx2x: add ethtool support to read and change RSS key

2015-09-18 Thread Eric Dumazet
From: Eric Dumazet While trying to understand why bnx2x RSS hash was not matching Toeplitz specifications, I implemented driver code to support ethtool -x|-X to try various RSS key combinations easily. Then, after some debugging, I understood bnx2x was reading the rss_key in reverse order. If w

Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-18 Thread Jesse Gross
On Fri, Sep 18, 2015 at 1:40 PM, John W. Linville wrote: > On Fri, Sep 18, 2015 at 01:30:36PM -0700, Jesse Gross wrote: >> On Thu, Sep 17, 2015 at 1:34 PM, John W. Linville >> wrote: >> > This seems to have been a "thinko". IP_ECN_decapsulate needs info >> > from both internal and external heade

[PATCH net-next] sunvnet:Invoke SET_NETDEV_DEV() to set up the vdev in vnet_new()

2015-09-18 Thread Sowmini Varadhan
`ls /sys/devices/channel-devices/vnet-port-0-0/net' is missing without this change, and applications like NetworkManager are looking in sysfs for the information. Signed-off-by: Sowmini Varadhan --- drivers/net/ethernet/sun/sunvnet.c | 17 +++-- 1 files changed, 11 insertions(+), 6

Re: [PATCH 1/2 v2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM

2015-09-18 Thread Dan Williams
On Fri, 2015-09-18 at 22:06 +0200, Ondrej Zary wrote: > On Friday 18 September 2015 18:54:35 Dan Williams wrote: > > On Tue, 2015-09-15 at 17:18 +0200, Ondrej Zary wrote: > > > IW_AUTH_ALG_OPEN_SYSTEM is ambiguous in set_auth for WEP as > > > wpa_supplicant uses it for both no encryption and WEP op

Re: [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time

2015-09-18 Thread Vivien Didelot
On Sep. Friday 18 (38) 12:55 PM, sfel...@gmail.com wrote: > From: Scott Feldman > > Signed-off-by: Scott Feldman Reviewed-by: Vivien Didelot -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http:/

Re: [PATCH net-next 6/7] bridge: don't age externally added FDB entries

2015-09-18 Thread Vivien Didelot
On Sep. Friday 18 (38) 12:55 PM, sfel...@gmail.com wrote: > From: Siva Mannem > > Signed-off-by: Siva Mannem > Signed-off-by: Scott Feldman Acked-by: Vivien Didelot -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

[PATCH net-next] net: bcmgenet: Remove duplicate test for tx_coalesce_usecs_high

2015-09-18 Thread Florian Fainelli
We were checking twice for ec->tx_coalesce_usecs_high, remove the duplicate test. Reported-by: Julia Lawall Reported-by: kbuild-...@01.org Fixes: 2f9130709d2c19 ("net: bcmgenet: Implement TX coalescing control knobs") Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/genet/bcmge

Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-18 Thread John W. Linville
On Fri, Sep 18, 2015 at 01:30:36PM -0700, Jesse Gross wrote: > On Thu, Sep 17, 2015 at 1:34 PM, John W. Linville > wrote: > > This seems to have been a "thinko". IP_ECN_decapsulate needs info > > from both internal and external headers. > > > > Signed-off-by: John W. Linville > > This looks goo

Re: [PATCH v2] geneve: remove vlan-related feature assignment

2015-09-18 Thread Jesse Gross
On Fri, Sep 18, 2015 at 1:20 PM, John W. Linville wrote: > The code handling vlan tag insertion was dropped in commit 371bd1061d29 > ("geneve: Consolidate Geneve functionality in single module."). Now we > need to drop the related vlan feature bits in the netdev structure. > > Signed-off-by: John

Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-18 Thread Jesse Gross
On Thu, Sep 17, 2015 at 1:34 PM, John W. Linville wrote: > This seems to have been a "thinko". IP_ECN_decapsulate needs info > from both internal and external headers. > > Signed-off-by: John W. Linville This looks good to me although I realized that the transmit path is also conditional based

[PATCH v2] geneve: remove vlan-related feature assignment

2015-09-18 Thread John W. Linville
The code handling vlan tag insertion was dropped in commit 371bd1061d29 ("geneve: Consolidate Geneve functionality in single module."). Now we need to drop the related vlan feature bits in the netdev structure. Signed-off-by: John W. Linville --- v2 -- replace earlier patch "geneve: restore vlan

Re: [PATCH next 0/15] netfilter: Stop guessing net (take 2)

2015-09-18 Thread Pablo Neira Ayuso
On Fri, Sep 18, 2015 at 02:28:40PM -0500, Eric W. Biederman wrote: > > This is the next installment of my work to pass struct net through the > output path so the code does not need to guess how to figure out which > network namespace it is in, and ultimately routes can have output > devices in an

Re: [PATCH] geneve: use network byte order for destination port config parameter

2015-09-18 Thread Jesse Gross
On Fri, Sep 18, 2015 at 12:59 PM, John W. Linville wrote: > This is primarily for consistancy with vxlan and other tunnels which > use network byte order for similar parameters. > > Signed-off-by: John W. Linville > --- > It is OK to change this, since this parameter was introduced to > net-next

Re: [GIT-PULL nf-next 00/15] IPVS Updates for v4.4

2015-09-18 Thread Pablo Neira Ayuso
On Thu, Sep 17, 2015 at 02:40:36PM +0900, Simon Horman wrote: > Hi Pablo, > > please consider these IPVS Updates for v4.4. > > The updates include the following from Alex Gartrell: > * Scheduling of ICMP > * Sysctl to ignore tunneled packets; and hence some packet-looping scenarios > > The follo

Re: [PATCH 1/2 v2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM

2015-09-18 Thread Ondrej Zary
On Friday 18 September 2015 18:54:35 Dan Williams wrote: > On Tue, 2015-09-15 at 17:18 +0200, Ondrej Zary wrote: > > IW_AUTH_ALG_OPEN_SYSTEM is ambiguous in set_auth for WEP as > > wpa_supplicant uses it for both no encryption and WEP open system. > > Cache the last mode set (only of these two) and

[PATCH] geneve: use network byte order for destination port config parameter

2015-09-18 Thread John W. Linville
This is primarily for consistancy with vxlan and other tunnels which use network byte order for similar parameters. Signed-off-by: John W. Linville --- It is OK to change this, since this parameter was introduced to net-next in the pre-4.3 cycle. Using network byte order for this parameter is co

Re: [PATCH] net: gianfar_ptp: Fix module autoload for OF platform driver

2015-09-18 Thread Luis de Bethencourt
Please ignore this. It has the wrong [PATCH] tag. Apologies, Luis On Fri, Sep 18, 2015 at 09:52:44PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de

[PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time

2015-09-18 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman --- Documentation/networking/switchdev.txt | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt index 476df04..67e43ee 10

[PATCH net-next 3/7] rocker: adding port ageing_time for ageing out FDB entries

2015-09-18 Thread sfeldma
From: Scott Feldman Follow-up patcheset will allow user to change ageing_time, but for now just hard-code it to a fixed value (the same value used as the default for the bridge driver). Signed-off-by: Scott Feldman --- drivers/net/ethernet/rocker/rocker.c |2 ++ 1 file changed, 2 insertion

[PATCH net-next 5/7] rocker: add FDB cleanup timer

2015-09-18 Thread sfeldma
From: Scott Feldman Add a timer to each rocker switch to do FDB entry cleanup by ageing out expired entries. The timer scheduling algo is copied from the bridge driver, for the most part, to keep the firing of the timer to a minimum. Signed-off-by: Scott Feldman --- drivers/net/ethernet/rocke

[PATCH net-next 0/7] bridge: don't age out externally added FDB entries

2015-09-18 Thread sfeldma
From: Scott Feldman Siva originally proposed skipping externally added FDB entries in the bridge's FDB garbage collection func, and moving the ageing of externally added entries to the port driver/device. This broke rocker, since rocker didn't have a hardware (or software) mechanism for ageing o

[PATCH net-next 6/7] bridge: don't age externally added FDB entries

2015-09-18 Thread sfeldma
From: Siva Mannem Signed-off-by: Siva Mannem Signed-off-by: Scott Feldman --- net/bridge/br_fdb.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index 9e9875d..6663cc0 100644 --- a/net/bridge/br_fdb.c +++ b/net/bridge/br_fdb.c @@ -299,6 +299,

[PATCH net-next 1/7] rocker: track when FDB entry is touched.

2015-09-18 Thread sfeldma
From: Scott Feldman The entry is touched once when created, and touched again for each update. The touched time is used to calculate FDB entry age. Signed-off-by: Scott Feldman --- drivers/net/ethernet/rocker/rocker.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-)

[PATCH net-next 2/7] rocker: store rocker_port in fdb key rather than pport

2015-09-18 Thread sfeldma
From: Scott Feldman We'll need more info from rocker_port than just pport when we age out fdb entries, so store rocker_port rather than pport in each fdb entry. Signed-off-by: Scott Feldman --- drivers/net/ethernet/rocker/rocker.c |8 1 file changed, 4 insertions(+), 4 deletions(-

[PATCH net-next 4/7] bridge: define some min/max ageing time constants we'll use next

2015-09-18 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman --- include/linux/if_bridge.h |4 1 file changed, 4 insertions(+) diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h index dad8b00..6cc6dbc 100644 --- a/include/linux/if_bridge.h +++ b/include/linux/if_bridge.h @@ -46,6

[PATCH] net: gianfar_ptp: Fix module autoload for OF platform driver

2015-09-18 Thread Luis de Bethencourt
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- Corrected the subject line as requested by Richard. https://lkml.org/lkml/2015/9/18/717 Thanks for the review, Luis drivers

[PATCH next 13/15] netfilter: Pass priv instead of nf_hook_ops to netfilter hooks

2015-09-18 Thread Eric W. Biederman
Only pass the void *priv parameter out of the nf_hook_ops. That is all any of the functions are interested now, and by limiting what is passed it becomes simpler to change implementation details. Signed-off-by: "Eric W. Biederman" --- include/linux/netfilter.h | 2 +- incl

[PATCH next 12/15] ipvs: Read hooknum from state rather than ops->hooknum

2015-09-18 Thread Eric W. Biederman
This should be more cache efficient as state is more likely to be in core, and the netfilter core will stop passing in ops soon. Signed-off-by: "Eric W. Biederman" --- net/netfilter/ipvs/ip_vs_core.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/net/netfilt

[PATCH next 15/15] netfilter: Use nf_ct_net instead of dev_net(out) in nf_nat_masquerade_ipv6

2015-09-18 Thread Eric W. Biederman
Use nf_ct_net(ct) instead of guessing that the netdevice out can reliably report the network namespace the conntrack operation is happening in. Signed-off-by: "Eric W. Biederman" --- net/ipv6/netfilter/nf_nat_masquerade_ipv6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/n

[PATCH next 11/15] nf_conntrack: Add a struct net parameter to l4_pkt_to_tuple

2015-09-18 Thread Eric W. Biederman
As gre does not have the srckey in the packet gre_pkt_to_tuple needs to perform a lookup in it's per network namespace tables. Pass in the proper network namespace to all pkt_to_tuple implementations to ensure gre (and any similar protocols) can get this right. Signed-off-by: "Eric W. Biederman"

[PATCH next 14/15] netfilter: Pass net into nf_xfrm_me_harder

2015-09-18 Thread Eric W. Biederman
Instead of calling dev_net on a likley looking network device pass state->net into nf_xfrm_me_harder. Signed-off-by: "Eric W. Biederman" --- include/net/netfilter/nf_nat_core.h | 2 +- net/ipv4/netfilter/nf_nat_l3proto_ipv4.c | 4 ++-- net/ipv6/netfilter/nf_nat_l3proto_ipv6.c | 4 ++-- net/

[PATCH next 08/15] nftables: Use pkt->net instead of computing net from the passed net_devices

2015-09-18 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- net/bridge/netfilter/nft_reject_bridge.c | 13 ++--- net/ipv6/netfilter/nft_reject_ipv6.c | 6 +++--- net/netfilter/nf_tables_core.c | 6 ++ net/netfilter/nft_log.c | 3 +-- net/netfilter/nft_reject_inet.c

[PATCH next 02/15] inet netfilter: Remove hook from ip6t_do_table, arp_do_table, ipt_do_table

2015-09-18 Thread Eric W. Biederman
The values of ops->hooknum and state->hook are guaraneted to be equal making the hook argument to ip6t_do_table, arp_do_table, and ipt_do_table is unnecessary. Remove the unnecessary hook argument. In the callers use state->hook instead of ops->hooknum for clarity and to reduce the number of cache

[PATCH next 10/15] act_connmark: Remember the struct net instead of guessing it.

2015-09-18 Thread Eric W. Biederman
Stop guessing the struct net instead of remember it. Guessing is just silly and will be problematic in the future when I implement routes between network namespaces. Signed-off-by: "Eric W. Biederman" --- include/net/tc_act/tc_connmark.h | 1 + net/sched/act_connmark.c | 3 ++- 2 files

[PATCH next 09/15] net: Pass net to nf_dup_ipv4 and nf_dup_ipv6

2015-09-18 Thread Eric W. Biederman
This allows them to stop guessing the network namespace with pick_net. Signed-off-by: "Eric W. Biederman" --- include/net/netfilter/ipv4/nf_dup_ipv4.h | 2 +- include/net/netfilter/ipv6/nf_dup_ipv6.h | 2 +- net/ipv4/netfilter/nf_dup_ipv4.c | 23 --- net/ipv4/netfil

[PATCH next 07/15] nftables: Pass struct net in nft_pktinfo

2015-09-18 Thread Eric W. Biederman
nft_pktinfo is passed on the stack so this does not bloat any in core data structures. By centrally computing this information this makes maintence of the code simpler, and understading of the code easier. Signed-off-by: "Eric W. Biederman" --- include/net/netfilter/nf_tables.h | 3 ++- 1 file

[PATCH next 01/15] ebtables: Simplify the arguments to ebt_do_table

2015-09-18 Thread Eric W. Biederman
Nearly everything thing of interest to ebt_do_table is already present in nf_hook_state. Simplify ebt_do_table by just passing in the skb, nf_hook_state, and the table. This make the code easier to read and maintenance easier. To support this create an nf_hook_state on the stack in ebt_broute (t

[PATCH next 04/15] nftables: kill nft_pktinfo.ops

2015-09-18 Thread Eric W. Biederman
- Add nft_pktinfo.pf to replace ops->pf - Add nft_pktinfo.hook to replace ops->hooknum This simplifies the code, makes it more readable, and likely reduces cache line misses. Maintainability is enhanced as the details of nft_hook_ops are of no concern to the recpients of nft_pktinfo. Signed-off-

[PATCH next 03/15] inet netfilter: Prefer state->hook to ops->hooknum

2015-09-18 Thread Eric W. Biederman
The values of nf_hook_state.hook and nf_hook_ops.hooknum must be the same by definition. We are more likely to access the fields in nf_hook_state over the fields in nf_hook_ops so with a little luck this results in fewer cache line misses, and slightly more consistent code. Signed-off-by: "Eric W

[PATCH next 05/15] x_tables: Pass struct net in xt_action_param

2015-09-18 Thread Eric W. Biederman
As xt_action_param lives on the stack this does not bloat any persistent data structures. This is a first step in making netfilter code that needs to know which network namespace it is executing in simpler. Signed-off-by: "Eric W. Biederman" --- include/linux/netfilter/x_tables.h | 3 ++- inclu

[PATCH next 06/15] x_tables: Use par->net instead of computing from the passed net devices

2015-09-18 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- net/bridge/netfilter/ebt_log.c | 2 +- net/bridge/netfilter/ebt_nflog.c | 2 +- net/ipv4/netfilter/ipt_SYNPROXY.c | 2 +- net/ipv4/netfilter/ipt_rpfilter.c | 5 ++--- net/ipv6/netfilter/ip6t_REJECT.c | 2 +- net/ipv6/netfilter/ip6t_SYNPROXY.c

Re: mvneta: SGMII fixed-link not so fixed

2015-09-18 Thread Stas Sergeev
18.09.2015 20:30, Florian Fainelli пишет: On 18/09/15 10:22, Russell King - ARM Linux wrote: On Fri, Sep 18, 2015 at 07:04:09PM +0300, Stas Sergeev wrote: 18.09.2015 18:43, Russell King - ARM Linux пишет: On Fri, Sep 18, 2015 at 05:45:27PM +0300, Stas Sergeev wrote: AFAICS if it has use_inban

[PATCH next 0/15] netfilter: Stop guessing net (take 2)

2015-09-18 Thread Eric W. Biederman
This is the next installment of my work to pass struct net through the output path so the code does not need to guess how to figure out which network namespace it is in, and ultimately routes can have output devices in another network namespace. This round the changes focus on using nf_hook_state

Re: [PATCH 4/6] net: freescale: Fix module autoload for OF platform driver

2015-09-18 Thread Richard Cochran
On Fri, Sep 18, 2015 at 05:55:27PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt Nit: The subject line should have been: net:

Re: [PATCH] iplink_geneve: add UDP destination port configuration at link creation

2015-09-18 Thread John W. Linville
On Fri, Sep 18, 2015 at 09:15:56AM -0700, Jesse Gross wrote: > On Fri, Sep 18, 2015 at 7:45 AM, Eric Dumazet wrote: > > On Fri, 2015-09-18 at 10:26 -0400, John W. Linville wrote: > >> On Thu, Sep 17, 2015 at 01:49:49PM -0700, Eric Dumazet wrote: > >> > On Thu, 2015-09-17 at 15:27 -0400, John W. Li

[PATCH net-next] tcp: send loss probe after 1s if no RTT available

2015-09-18 Thread Yuchung Cheng
This patch makes TLP to use 1 sec timer by default when RTT is not available due to SYN/ACK retransmission or SYN cookies. Prior to this change, the lack of RTT prevents TLP so the first data packets sent can only be recovered by fast recovery or RTO. If the fast recovery fails to trigger the RTO

[PATCH net-next] tcp: usec resolution SYN/ACK RTT

2015-09-18 Thread Yuchung Cheng
Currently SYN/ACK RTT is measured in jiffies. For LAN the SYN/ACK RTT is often measured as 0ms or sometimes 1ms, which would affect RTT estimation and min RTT samping used by some congestion control. This patch improves SYN/ACK RTT to be usec resolution if platform supports it. While the timestamp

Re: [PATCH next 0/14] netfilter: Stop guessing net

2015-09-18 Thread Eric W. Biederman
Nicolas Dichtel writes: > Le 18/09/2015 17:06, Eric W. Biederman a écrit : >> >> This is the next installment of my work to pass struct net through the >> output path so the code does not need to guess how to figure out which >> network namespace it is in, and ultimately routes can have output >>

[iproute PATCH 0/6] documentation enhancements

2015-09-18 Thread Phil Sutter
This series extends manpages of ip-address and ip by a few smaller things, practically rewrites lnstat manpage to cover in detail what it is used for and what the meanings of the available statistics are, adds a minimal manpage for the rtpr script and last but not least fixes two remaining file hea

[iproute PATCH 4/6] man: ip-address: document mngtmpaddr and noprefixroute flags

2015-09-18 Thread Phil Sutter
Signed-off-by: Phil Sutter --- man/man8/ip-address.8.in | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-address.8.in b/man/man8/ip-address.8.in index 43611b9..159d906 100644 --- a/man/man8/ip-address.8.in +++ b/man/man8/ip-address.8.in @@ -67,7 +

[iproute PATCH 6/6] man: rtpr: add minimal manpage

2015-09-18 Thread Phil Sutter
While there is not much to explain about this rather trivial shell script, having a manpage for it serves as good point of reference for users wondering what it might be for. Signed-off-by: Phil Sutter --- man/man8/Makefile | 2 +- man/man8/rtpr.8 | 25 + 2 files chang

[iproute PATCH 2/6] man: ip: add -h[uman-readable] option

2015-09-18 Thread Phil Sutter
Since 'ip help' lists it, it should be described in ip.8 as well. Signed-off-by: Phil Sutter --- man/man8/ip.8 | 5 + 1 file changed, 5 insertions(+) diff --git a/man/man8/ip.8 b/man/man8/ip.8 index 9da086d..e6c2b32 100644 --- a/man/man8/ip.8 +++ b/man/man8/ip.8 @@ -27,6 +27,7 @@ ip \- show

[iproute PATCH 3/6] comment: Fix remaining listings of wrong FSF address

2015-09-18 Thread Phil Sutter
This patch follows the changes of commit 4d98ab0 ("Fix FSF address in file headers"), fixing file headers added after it. Signed-off-by: Phil Sutter --- include/linux/tc_act/tc_skbedit.h | 3 +-- tc/m_connmark.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --

[iproute PATCH 1/6] man: ip-address: align synopsis with help output

2015-09-18 Thread Phil Sutter
When fixing the BNF syntax error, I overlooked that 'ip address help' prints a more correct synopsis. This patch aligns them. Fixes: 715296b ("ip-address.8.in: fix BNF syntax error") Signed-off-by: Phil Sutter --- man/man8/ip-address.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[iproute PATCH 5/6] man: lnstat: rewrite manpage

2015-09-18 Thread Phil Sutter
Signed-off-by: Phil Sutter --- man/man8/lnstat.8 | 197 -- 1 file changed, 192 insertions(+), 5 deletions(-) diff --git a/man/man8/lnstat.8 b/man/man8/lnstat.8 index 699ddf4..69fe876 100644 --- a/man/man8/lnstat.8 +++ b/man/man8/lnstat.8 @@ -9,

Re: [PATCH 3/6] net: bcmgenet: Fix module autoload for OF platform driver

2015-09-18 Thread Florian Fainelli
On 18/09/15 08:55, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt Acked-by: Florian Fainelli > --- > drivers/net/ethernet/broadcom/genet/bc

Re: [PATCH 1/2] net: phy: mdio-bcm-unimac: Fix module autoload for OF platform driver

2015-09-18 Thread Florian Fainelli
On 18/09/15 09:16, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt Acked-by: Florian Fainelli > --- > drivers/net/phy/mdio-bcm-unimac.c | 1

Re: [PATCH 2/6] net: systemport: Fix module autoload for OF platform driver

2015-09-18 Thread Florian Fainelli
On 18/09/15 08:54, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt Acked-by: Florian Fainelli > --- > drivers/net/ethernet/broadcom/bcmsyspo

Re: mvneta: SGMII fixed-link not so fixed

2015-09-18 Thread Florian Fainelli
On 18/09/15 10:22, Russell King - ARM Linux wrote: > On Fri, Sep 18, 2015 at 07:04:09PM +0300, Stas Sergeev wrote: >> 18.09.2015 18:43, Russell King - ARM Linux пишет: >>> On Fri, Sep 18, 2015 at 05:45:27PM +0300, Stas Sergeev wrote: AFAICS if it has use_inband_status==true, then it went

Re: mvneta: SGMII fixed-link not so fixed

2015-09-18 Thread Russell King - ARM Linux
On Fri, Sep 18, 2015 at 07:04:09PM +0300, Stas Sergeev wrote: > 18.09.2015 18:43, Russell King - ARM Linux пишет: > > On Fri, Sep 18, 2015 at 05:45:27PM +0300, Stas Sergeev wrote: > >> AFAICS if it has use_inband_status==true, > >> then it went through of_phy_register_fixed_link(dn), > > > > That'

netdev: question on ndo_set_rx_mode() API

2015-09-18 Thread Murali Karicheri
Hello Netdev experts, I am seeing an issue with netcp driver that has a mutex lock/unlock() call. When kernel hack debug options are enabled, I see a warning that this function is taking a mutex that can sleep and is not allowed. I am working to fix this. Looking at other drivers, I see many d

[RFC net-next 09/11] net: Move netif_index_is_l3_master to l3mdev.h

2015-09-18 Thread David Ahern
Change CONFIG dependency to CONFIG_NET_L3_MASTER_DEV as well. Signed-off-by: David Ahern --- include/linux/netdevice.h | 21 - include/net/l3mdev.h | 24 include/net/route.h | 1 + 3 files changed, 25 insertions(+), 21 deletions(-) diff -

[RFC net-next 11/11] net: Add netif_is_l3_slave

2015-09-18 Thread David Ahern
Simplifies ops checking. An L3 master is expected to define l3mdev_ops at a minimum. Signed-off-by: David Ahern --- drivers/net/vrf.c | 6 +++--- include/linux/netdevice.h | 5 + net/l3mdev/l3mdev.c | 13 - 3 files changed, 12 insertions(+), 12 deletions(-) diff

[RFC net-next 07/11] net: Remove the now unused vrf_ptr

2015-09-18 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/vrf.c | 32 ++-- include/linux/netdevice.h | 2 -- include/net/vrf.h | 6 -- 3 files changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 75d34a9b525a..c4f03

[RFC net-next 04/11] net: Replace vrf_master_ifindex{,_rcu} with l3mdev equivalents

2015-09-18 Thread David Ahern
Replace calls to vrf_master_ifindex_rcu and vrf_master_ifindex with either l3mdev_master_ifindex_rcu or l3mdev_master_ifindex. The pattern: oif = vrf_master_ifindex(dev) ? : dev->ifindex; is replaced with oif = l3mdev_fib_oif(dev); And remove the now unused vrf macros. Signed-off-by: Dav

[RFC net-next 10/11] net: Rename FLOWI_FLAG_VRFSRC to FLOWI_FLAG_L3MDEV_SRC

2015-09-18 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/vrf.c | 4 ++-- include/net/flow.h | 2 +- include/net/route.h | 2 +- net/ipv4/fib_trie.c | 2 +- net/ipv4/udp.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index a3d5bcabbc48..8fe

[RFC net-next 06/11] net: Replace calls to vrf_dev_get_rth

2015-09-18 Thread David Ahern
Replace calls to vrf_dev_get_rth with l3mdev_get_rtable. The check on the flow flags is handled in the l3mdev operation. Signed-off-by: David Ahern --- include/net/vrf.h | 22 -- net/ipv4/route.c | 9 - 2 files changed, 4 insertions(+), 27 deletions(-) diff --git a

[RFC net-next 08/11] net: Remove vrf header file

2015-09-18 Thread David Ahern
Move remaining structs to VRF driver and delete the vrf header file. Signed-off-by: David Ahern --- MAINTAINERS | 1 - drivers/net/vrf.c | 16 +++- include/net/vrf.h | 29 - 3 files changed, 15 insertions(+), 31 deletions(-) delete mode 100644 incl

[RFC net-next 03/11] net: Add support for l3mdev ops to VRF driver

2015-09-18 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/Kconfig | 1 + drivers/net/vrf.c | 29 + 2 files changed, 30 insertions(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index d18eb607bee6..b9ebd0d18a52 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig

[RFC net-next 05/11] net: Replace vrf_dev_table and friends

2015-09-18 Thread David Ahern
Replace calls to vrf_dev_table and friends with l3mdev_fib_table and kin. Signed-off-by: David Ahern --- include/net/vrf.h | 80 - net/ipv4/af_inet.c | 4 +-- net/ipv4/fib_frontend.c | 7 ++--- 3 files changed, 5 insertions(+), 86 dele

[RFC net-next 00/11] net: L3 master device

2015-09-18 Thread David Ahern
The VRF device is essentially a Layer 3 master device used to associate netdevices with a specific routing table and to influence FIB lookups via 'ip rules' and controlling the oif/iif used for the lookup. This series generalizes the VRF into L3 master device, l3mdev. Similar to switchdev it has a

[RFC net-next 01/11] net: Introduce L3 Master device abstraction

2015-09-18 Thread David Ahern
L3 master devices allow users of the abstraction to influence FIB lookups for enslaved devices. Current API provides a means for the master device to return a specific FIB table for an enslaved device, to return an rtable/custom dst and influence the OIF used for fib lookups. Signed-off-by: David

[RFC net-next 02/11] net: Rename IFF_VRF_MASTER to IFF_L3MDEV

2015-09-18 Thread David Ahern
Rename IFF_VRF_MASTER to IFF_L3MDEV and update the name of the netif_is_vrf and netif_index_is_vrf macros. Signed-off-by: David Ahern --- drivers/net/vrf.c | 6 +++--- include/linux/netdevice.h | 14 +++--- include/net/route.h | 2 +- include/net/vrf.h | 4 ++--

Re: [net-next 0/8][pull request] Intel Wired LAN Driver Updates 2015-09-17

2015-09-18 Thread Jeff Kirsher
On Thu, 2015-09-17 at 17:17 -0700, Jeff Kirsher wrote: > This series contains updates to i40e and i40evf. > > Shannon provides updates to i40e and i40evf to resolve an issue with > the > nvmupdate utility. First renames a variable name to reduce confusion > and > to differentiate it from the actu

Re: ATL1E 0000:02:00.0: swiotlb buffer is full (sz: 529461 bytes)

2015-09-18 Thread Markus Trippelsdorf
On 2015.09.18 at 16:42 +, Chris Snook wrote: > I think atl1e is the victim here, not the cause. It's probably the last > device being brought up that wants to use the swiotlb, so you haven't seen > other devices failing for the same reason. Can you post your dmesg or boot > log from both a boot

Re: [PATCH 1/2 v2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM

2015-09-18 Thread Dan Williams
On Tue, 2015-09-15 at 17:18 +0200, Ondrej Zary wrote: > IW_AUTH_ALG_OPEN_SYSTEM is ambiguous in set_auth for WEP as > wpa_supplicant uses it for both no encryption and WEP open system. > Cache the last mode set (only of these two) and use it here. > > This allows wpa_supplicant to work with unencr

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-18 Thread Robert Jarzmik
David Miller writes: >> My understanding is that the flow will be : >> sched_clock() >>rd->read_sched_clock() (cyc_to_ns() transformed for return) >> pxa_read_sched_clock() >>readl_relaxed(OSCR) >> >> I didn't see any timings issue, as the flow looks equivalent to the >> readl

Re: [PATCH next 0/14] netfilter: Stop guessing net

2015-09-18 Thread Nicolas Dichtel
Le 18/09/2015 17:06, Eric W. Biederman a écrit : This is the next installment of my work to pass struct net through the output path so the code does not need to guess how to figure out which network namespace it is in, and ultimately routes can have output devices in another network namespace.

Re: [PATCH next 0/14] netfilter: Stop guessing net

2015-09-18 Thread Nicolas Dichtel
Le 18/09/2015 18:13, Eric W. Biederman a écrit : [snip] It appears I forgot to hit send. The patches should show up any time now. Yes, thank you. Nicolas -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH next 0/14] netfilter: Stop guessing net

2015-09-18 Thread Eric W. Biederman
Nicolas Dichtel writes: > Le 18/09/2015 17:06, Eric W. Biederman a écrit : >> >> This is the next installment of my work to pass struct net through the >> output path so the code does not need to guess how to figure out which >> network namespace it is in, and ultimately routes can have output >>

[PATCH iproute2] configure: Check for Berkeley DB for arpd compilation

2015-09-18 Thread Vadim Kochan
From: Vadim Kochan Add check for Berkeley DB header & lib before compile arpd util. Signed-off-by: Vadim Kochan --- configure | 29 +++-- misc/Makefile | 6 +- 2 files changed, 32 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 3ae4c95..

  1   2   3   >