Re: [PATCH v4] netlink: Fix autobind race condition that leads to zero port ID

2015-09-21 Thread David Miller
From: Herbert Xu Date: Mon, 21 Sep 2015 14:06:36 +0800 > On Sun, Sep 20, 2015 at 10:55:21PM -0700, David Miller wrote: >> From: Herbert Xu >> Date: Fri, 18 Sep 2015 19:16:50 +0800 >> >> > The commit

Re: [PATCH v4] netlink: Fix autobind race condition that leads to zero port ID

2015-09-21 Thread Herbert Xu
On Sun, Sep 20, 2015 at 10:55:21PM -0700, David Miller wrote: > From: Herbert Xu > Date: Fri, 18 Sep 2015 19:16:50 +0800 > > > The commit c0bb07df7d981e4091432754e30c9c720e2c0c78 ("netlink: > > Reset portid after netlink_insert failure") introduced a race > >

[PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Pravin B Shelar
VXLAN device can receive skb with checksum partial. But the checksum offset could be in outer header which is pulled on receive. This results in negative checksum offset for the skb. Such skb can cause the assert failure in skb_checksum_help(). The patch fixes the bug by checking for negative

Re: [PATCH net] openvswitch: Zero flows on allocation.

2015-09-21 Thread David Miller
From: Jesse Gross Date: Fri, 18 Sep 2015 19:06:14 -0700 > @@ -80,7 +80,7 @@ struct sw_flow *ovs_flow_alloc(void) > struct flow_stats *stats; > int node; > > - flow = kmem_cache_alloc(flow_cache, GFP_KERNEL); > + flow = kmem_cache_alloc(flow_cache,

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

2015-09-21 Thread Scott Feldman
On Sat, Sep 19, 2015 at 5:29 AM, Jiri Pirko wrote: > Jiri Pirko (6): > switchdev: rename "trans" to "trans_ph". > switchdev: introduce transaction infrastructure for attr_set and > obj_add > rocker: switch to local transaction phase enum > switchdev: move transaction

Re: [PATCH net 1/2] iptunnel: make rx/tx bytes counters consistent

2015-09-21 Thread Nicolas Dichtel
Le 21/09/2015 07:37, David Miller a écrit : From: David Miller Date: Sun, 20 Sep 2015 22:35:13 -0700 (PDT) After the patch: $ ping -c1 192.168.0.121 ; ip -s l ls dev gre1 PING 192.168.0.121 (192.168.0.121) 56(84) bytes of data. 64 bytes from 192.168.0.121: icmp_req=1

Re: [PATCH net-next v2 3/7] bridge: define some min/max/default ageing time constants

2015-09-21 Thread Jiri Pirko
Sun, Sep 20, 2015 at 05:48:25PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Signed-off-by: Scott Feldman Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net-next v2 4/7] rocker: adding port ageing_time for ageing out FDB entries

2015-09-21 Thread Jiri Pirko
Sun, Sep 20, 2015 at 05:48:26PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Follow-up patcheset will allow user to change ageing_time, but for now >just hard-code it to a fixed value (the same value used as the default >for the bridge driver). > >Signed-off-by: Scott

[PATCH] ip: find correct route for socket which is not bound (v2)

2015-09-21 Thread Wengang Wang
This is the v2, comparing the v1, the changes is: * for loopback outbound device, it continue skipping cached route; for others, it goes through the cached route. For multi-cast, we should find valid route(thus get the meaniful pmtu) for the package on the socket which is not bound to a

pull-request: can-next 2015-09-17

2015-09-21 Thread Marc Kleine-Budde
/jkirsher/next-queue (2015-09-20 22:26:58 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-4.4-20150921 for you to fetch changes up to 6fa7da249269a6146ce456c43098901c81c8afdf: can: flexcan: enable

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

2015-09-21 Thread Jiri Pirko
Mon, Sep 21, 2015 at 09:23:24AM CEST, sfel...@gmail.com wrote: >On Sat, Sep 19, 2015 at 5:29 AM, Jiri Pirko wrote: >> Jiri Pirko (6): >> switchdev: rename "trans" to "trans_ph". >> switchdev: introduce transaction infrastructure for attr_set and >> obj_add >> rocker:

[PATCH] lib: fix data race in rhashtable_rehash_one

2015-09-21 Thread Dmitry Vyukov
rhashtable_rehash_one() uses plain writes to update entry->next, while it is being concurrently accessed by readers. Unfortunately, the compiler is within its rights to (for example) use byte-at-a-time writes to update the pointer, which would fatally confuse concurrent readers. Use WRITE_ONCE to

Re: [PATCH 0/6] net: Fix module autoload for OF platform drivers

2015-09-21 Thread David Miller
From: Luis de Bethencourt Date: Fri, 18 Sep 2015 17:53:32 +0200 > Hi, > > These patches add the missing MODULE_DEVICE_TABLE() for OF to export > the information so modules have the correct aliases built-in and > autoloading works correctly. > > A longer explanation by

Re: [PATCH net-next] tcp: send loss probe after 1s if no RTT available

2015-09-21 Thread David Miller
From: Yuchung Cheng Date: Fri, 18 Sep 2015 11:40:33 -0700 > This patch makes TLP to use 1 sec timer by default when RTT is > not available due to SYN/ACK retransmission or SYN cookies. > > Prior to this change, the lack of RTT prevents TLP so the first > data packets sent can

Re: [PATCH net-next] tcp: usec resolution SYN/ACK RTT

2015-09-21 Thread David Miller
From: Yuchung Cheng Date: Fri, 18 Sep 2015 11:36:14 -0700 > Currently SYN/ACK RTT is measured in jiffies. For LAN the SYN/ACK > RTT is often measured as 0ms or sometimes 1ms, which would affect > RTT estimation and min RTT samping used by some congestion control. > > This

[RFC net-next 3/4] net: VRF device: Initial IPv6 support

2015-09-21 Thread David Ahern
Start point for IPv6 support by the VRF device. Signed-off-by: David Ahern --- drivers/net/vrf.c | 226 +- 1 file changed, 225 insertions(+), 1 deletion(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index

[RFC net-next 2/4] net: Remove use of IFF_SLAVE with L3 devices

2015-09-21 Thread David Ahern
Use of IFF_SLAVE flag causes problems with IPv6. addrconf_notify does not respond to netdev events for devices with IFF_SLAVE set. This breaks DAD, neighbor discovery and spirals to non-working death for IPv6. L3 master devices will have IFF_MASTER and IFF_L3MDEV set. L3 slave devices will only

[RFC net-next 0/4] net: VRF support in IPv6 stack

2015-09-21 Thread David Ahern
Initial support for VRFs in IPv6 stack. Patches apply on top of the L3 Master Device patches sent on Friday: http://www.spinics.net/lists/netdev/msg343533.html All patches can be found here github.com/dsahern/linux.git vrf/ipv6-l3mdev-rfc1 David Ahern (4): l3mdev: ipv6 support net:

[RFC net-next 4/4] net: ipv6: Initial support for VRFs

2015-09-21 Thread David Ahern
Add basic support for VRFs to IPv6 stack. This is a good start point. ping to and from a VRF works. Basic tcp and udp clients and server all work fine with VRFs. Signed-off-by: David Ahern --- net/ipv6/addrconf.c | 4 +++- net/ipv6/datagram.c | 4

[RFC net-next 1/4] l3mdev: ipv6 support

2015-09-21 Thread David Ahern
Add lookup of cached IPv6 route to l3mdev operations. Signed-off-by: David Ahern --- include/net/l3mdev.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/include/net/l3mdev.h b/include/net/l3mdev.h index

Re: [PATCH net] tcp/dccp: fix timewait races in timer handling

2015-09-21 Thread David Miller
From: Eric Dumazet Date: Sat, 19 Sep 2015 09:08:34 -0700 > From: Eric Dumazet > > When creating a timewait socket, we need to arm the timer before > allowing other cpus to find it. The signal allowing cpus to find > the socket is setting tw_refcnt

Re: [PATCH net] inet: fix races in reqsk_queue_hash_req()

2015-09-21 Thread David Miller
From: Eric Dumazet Date: Sat, 19 Sep 2015 09:48:04 -0700 > From: Eric Dumazet > > Before allowing lockless LISTEN processing, we need to make > sure to arm the SYN_RECV timer before the req socket is visible > in hash tables. > > Also,

Re: [PATCH net-next v2 5/7] rocker: add FDB cleanup timer

2015-09-21 Thread David Miller
From: sfel...@gmail.com Date: Sun, 20 Sep 2015 08:48:27 -0700 > From: Scott Feldman > > Add a timer to each rocker switch to do FDB entry cleanup by ageing out > expired entries. The timer scheduling algo is copied from the bridge > driver, for the most part, to keep the

Re: linux-next: build failure after merge of the bluetooth tree

2015-09-21 Thread Stephen Rothwell
Hi Gustavo, On Mon, 14 Sep 2015 10:22:34 +1000 Stephen Rothwell wrote: > > On Mon, 14 Sep 2015 10:14:28 +1000 Stephen Rothwell > wrote: > > > > I applied the patches that Andrew has had in his post merge series > > (but I think you were sent a

Re: 4.1.0, kernel panic, pppoe_release

2015-09-21 Thread Denys Fedoryshchenko
Hi, Sorry for late reply, was not able to push new kernel on pppoes without permissions (it's production servers), just got OK. I am testing patch on another pppoe server with 9k users, for ~3 days, seems fine. I will test today also on server that was experiencing crashes within 1 day. On

Re: linux-next: build failure after merge of the bluetooth tree

2015-09-21 Thread David Miller
From: Stephen Rothwell Date: Tue, 22 Sep 2015 11:20:15 +1000 > From: Stephen Rothwell > Subject: drivers/net/ieee802154/at86rf230.c: seq_printf() now returns NULL > > Signed-off-by: Stephen Rothwell > Cc: Alexander Aring

Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter

2015-09-21 Thread Mark Rustad
On 9/21/15 9:14 PM, Jarod Wilson wrote: > Just switching to adapter->io_addr everywhere seems to not work as > noted above. :\ Note that I'm also chasing this from the other end > with the author of the pci patches that seem to have triggered this, > so the real bug might be over in pci-land,

Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter

2015-09-21 Thread Jarod Wilson
Alexander Duyck wrote: On 09/21/2015 10:11 AM, Jarod Wilson wrote: Some pci changes upcoming in 4.3 seem to cause additional disconnects, which can happen at unfortuitous times for igb, leading to issues such as this, where the disconnect happened just before igb_configure_tx_ring(): [

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Pravin Shelar
On Mon, Sep 21, 2015 at 8:21 PM, Eric Dumazet wrote: > On Mon, 2015-09-21 at 19:49 -0700, Pravin Shelar wrote: >> On Mon, Sep 21, 2015 at 7:14 PM, Eric Dumazet wrote: >> > On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: >> >> On Mon, Sep

Re: pull request: bluetooth-next 2015-09-18

2015-09-21 Thread David Miller
From: Johan Hedberg Date: Fri, 18 Sep 2015 13:54:55 +0300 > Here's the first bluetooth-next pull request for the 4.4 kernel: > > - ieee802154 cleanups & fixes > - debugfs support for the at86rf230 driver > - Support for quirky (seemingly counterfeit) CSR Bluetooth

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-21 Thread David Miller
From: Robert Jarzmik Date: Fri, 18 Sep 2015 18:36:56 +0200 > Which brings me to wonder which is the more correct : > (a) replace to reproduce the same calculation > Previously mtt was compared to a difference of 76ns steps (as 307ns / 4 = > 76ns): > while

[PATCH v3 2/2] [net] af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag

2015-09-21 Thread Aaron Conole
AF_UNIX sockets now return multiple skbs from recv() when MSG_PEEK flag is set. This is referenced in kernel bugzilla #12323 @ https://bugzilla.kernel.org/show_bug.cgi?id=12323 As described both in the BZ and lkml thread @ http://lkml.org/lkml/2008/1/8/444 calling recv() with MSG_PEEK on an

[PATCH v3 0/2] [net] af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag

2015-09-21 Thread Aaron Conole
This patch set implements a bugfix for kernel.org bugzilla #12323, allowing MSG_PEEK to return all queued data on the unix domain socket, not just the data contained in a single SKB. This is the v3 version of this patch, which includes a suggested modification by Eric Dumazet to convert the

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

2015-09-21 Thread Vivien Didelot
Hi Jiri, On Sep. Monday 21 (39) 08:25 PM, Jiri Pirko wrote: > Mon, Sep 21, 2015 at 07:13:58PM CEST, vivien.dide...@savoirfairelinux.com > wrote: > >Hi Jiri, Scott, > > > >On Sep. Monday 21 (39) 10:09 AM, Jiri Pirko wrote: > >> Mon, Sep 21, 2015 at 09:23:24AM CEST, sfel...@gmail.com wrote: > >>

[PATCH net-next] Driver: Vmxnet3: Extend register dump support

2015-09-21 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare Signed-off-by: Bhavesh Davda Acked-by: Srividya Murali --- drivers/net/vmxnet3/vmxnet3_ethtool.c | 118 ++ drivers/net/vmxnet3/vmxnet3_int.h | 4 +- 2 files

[net-next PATCH 1/4] drivers: net: cpsw: davinci_emac: move reading mac id to common file

2015-09-21 Thread Mugunthan V N
Moving mac address reading from ethernet driver to common file for better maintenance and for code reusable. Signed-off-by: Mugunthan V N --- drivers/net/ethernet/ti/cpsw-common.c | 58 -- drivers/net/ethernet/ti/cpsw.c | 11 +++

[net-next PATCH 2/4] drivers: net: cpsw-common: add support for reading mac address for dra7 and am437x platforms

2015-09-21 Thread Mugunthan V N
Adding support for reading mac address using syscon driver for dra7 and am437x platforms Signed-off-by: Mugunthan V N --- drivers/net/ethernet/ti/cpsw-common.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/ti/cpsw-common.c

Re: [PATCH] lib: fix data race in rhashtable_rehash_one

2015-09-21 Thread Eric Dumazet
On Mon, 2015-09-21 at 10:08 +0200, Dmitry Vyukov wrote: > rhashtable_rehash_one() uses plain writes to update entry->next, > while it is being concurrently accessed by readers. > Unfortunately, the compiler is within its rights to (for example) use > byte-at-a-time writes to update the pointer,

[PATCH 22/38] orinoco: fix checking for default value

2015-09-21 Thread Andrzej Hajda
Thresholds uses -1 to indicate that default value should be used. Since thresholds are unsigned sign checking makes no sense. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]:

[PATCH v3 1/2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM

2015-09-21 Thread Ondrej Zary
IW_AUTH_ALG_OPEN_SYSTEM is ambiguous in set_auth for WEP as wpa_supplicant uses it for both no encryption and WEP open system. Cache the last mode set (only of these two) and use it here. This allows wpa_supplicant to work with unencrypted APs. Signed-off-by: Ondrej Zary

[PATCH 27/38] usbnet: remove invalid check

2015-09-21 Thread Andrzej Hajda
skb->len is always non-negative. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/net/usb/lan78xx.c

[PATCH 18/38] net/ibm/emac: fix type of phy_mode

2015-09-21 Thread Andrzej Hajda
phy_mode can be negative. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda ---

[PATCH v3 2/2] airo: Implement netif_carrier_on/off

2015-09-21 Thread Ondrej Zary
Add calls to netif_carrier_on and netif_carrier_off Signed-off-by: Ondrej Zary --- drivers/net/wireless/airo.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c index 67001a8..8ae838d 100644 ---

[net-next PATCH 3/4] arm: dts: dra7: add syscon phandle to cpsw node

2015-09-21 Thread Mugunthan V N
There are 2 MACIDs stored in the control module of the dra7. These are read by the cpsw driver if no valid MACID was found in the devicetree. Signed-off-by: Mugunthan V N --- arch/arm/boot/dts/dra7.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git

[net-next PATCH 4/4] arm: dts: am4372: add syscon phandle to cpsw node

2015-09-21 Thread Mugunthan V N
There are 2 MACIDs stored in the control module of the am4372. These are read by the cpsw driver if no valid MACID was found in the devicetree. Signed-off-by: Mugunthan V N --- arch/arm/boot/dts/am4372.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git

[net-next PATCH 0/4] Add support for reading macid when DT macid not found

2015-09-21 Thread Mugunthan V N
Did a boot test on dra7-evm [1] and am437x-gp-evm [2]. Pushed a branch [3] for others to test the patch. [1]: http://pastebin.ubuntu.com/12513420/ [2]: http://pastebin.ubuntu.com/12513428/ [3]: git://git.ti.com/~mugunthanvnm/ti-linux-kernel/linux.git cpsw-macid-read-support Mugunthan V N (4):

RE: bnx2x - occasional high packet loss (on LAN)

2015-09-21 Thread Ariel Elior
> -Original Message- > From: Nikola Ciprich [mailto:nikola.cipr...@linuxbox.cz] > Sent: Monday, September 21, 2015 1:32 PM > To: Ariel Elior > Cc: netdev ; n...@linuxbox.cz > Subject: Re: bnx2x - occasional high packet loss (on LAN) > >

netlink: Replace rhash_portid with bound

2015-09-21 Thread Herbert Xu
On Sun, Sep 20, 2015 at 11:11:04PM -0700, David Miller wrote: > > Yeah at this point incremental patches work the best. OK here is the patch: ---8<--- The commit 1f770c0a09da855a2b51af6d19de97fb955eca85 ("netlink: Fix autobind race condition that leads to zero port ID") created some new races

[PATCH 08/38] openvswitch: fix handling result of ipv6_skip_exthdr

2015-09-21 Thread Andrzej Hajda
The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda ---

Re: bnx2x - occasional high packet loss (on LAN)

2015-09-21 Thread Nikola Ciprich
Hello Ariel, after few days of torturing NICs with flood pings, card seems to have given up with lots of errors.. I've uploaded new kernel log here: http://nik.lbox.cz/download/dmesg.txt Will this help? I still have it in this hung state now, in case I could provide more info for

Re: bnx2x - occasional high packet loss (on LAN)

2015-09-21 Thread Nikola Ciprich
> Hi Nikola, > Seems like the link below is the same file you shared before - I don't see > any errors there. ouch, the file was correct, but the permissions were wrong.. so maybe you were getting older file from some proxy? anyways, I've copied file so you can get it from new location:

Re: [PATCH 1/2 v2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM

2015-09-21 Thread Kalle Valo
Ondrej Zary writes: > IW_AUTH_ALG_OPEN_SYSTEM is ambiguous in set_auth for WEP as > wpa_supplicant uses it for both no encryption and WEP open system. > Cache the last mode set (only of these two) and use it here. > > This allows wpa_supplicant to work with

[PATCH 21/38] mwifiex: fix comparison expression

2015-09-21 Thread Andrzej Hajda
To avoid underflows signed variables should be used in expression. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda

[PATCH 23/38] rndis_wlan: fix checking for default value

2015-09-21 Thread Andrzej Hajda
Thresholds uses -1 to indicate that default value should be used. Since thresholds are unsigned sign checking makes no sense. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]:

Re: [PATCH RFC 0/3] kcm: Kernel Connection Multiplexor (KCM)

2015-09-21 Thread Tom Herbert
On Mon, Sep 21, 2015 at 2:26 PM, Sowmini Varadhan wrote: > On (09/21/15 10:33), Tom Herbert wrote: >> > >> > Some things that were not clear to me from the patch-set: >> > >> > The doc statses that we re-assemble packets the "stated length" - >> > but how will the

Re: [PATCH net-next V2 0/5] s390: qeth and iucv patches

2015-09-21 Thread David Miller
From: Ursula Braun Date: Fri, 18 Sep 2015 16:06:47 +0200 > here is version 2 of some s390 related qeth patches for net-next. The patch by > Thomas Richter adds a new feature to the qeth layer2 code; the remaining > patches are minor improvements. > Version 2 of patch 4

Re: [PATCH net-next] sunvnet:Invoke SET_NETDEV_DEV() to set up the vdev in vnet_new()

2015-09-21 Thread David Miller
From: Sowmini Varadhan Date: Fri, 18 Sep 2015 17:47:55 -0400 > `ls /sys/devices/channel-devices/vnet-port-0-0/net' is missing without > this change, and applications like NetworkManager are looking in > sysfs for the information. > > Signed-off-by: Sowmini Varadhan

Re: [PATCH 0/2] net: phy: Fix module autoload for OF platform drivers

2015-09-21 Thread David Miller
From: Luis de Bethencourt Date: Fri, 18 Sep 2015 18:15:53 +0200 > These patches add the missing MODULE_DEVICE_TABLE() for OF to export > the information so modules have the correct aliases built-in and > autoloading works correctly. > > A longer explanation by Javier

Re: [RFC net-next 4/4] net: ipv6: Initial support for VRFs

2015-09-21 Thread David Ahern
On 9/21/15 6:08 PM, Tom Herbert wrote: diff --git a/net/ipv6/datagram.c b/net/ipv6/datagram.c index 9aadd57808a5..11980ee57507 100644 --- a/net/ipv6/datagram.c +++ b/net/ipv6/datagram.c @@ -142,6 +142,10 @@ static int __ip6_datagram_connect(struct sock *sk, struct sockaddr *uaddr, int a

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Pravin Shelar
On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: > From: Pravin B Shelar > Date: Sun, 20 Sep 2015 23:53:17 -0700 > >> VXLAN device can receive skb with checksum partial. But the checksum >> offset could be in outer header which is pulled on receive. >

Re: [PATCH net] openvswitch: Zero flows on allocation.

2015-09-21 Thread Jesse Gross
On Sun, Sep 20, 2015 at 11:24 PM, David Miller wrote: > From: Jesse Gross > Date: Fri, 18 Sep 2015 19:06:14 -0700 > >> @@ -80,7 +80,7 @@ struct sw_flow *ovs_flow_alloc(void) >> struct flow_stats *stats; >> int node; >> >> - flow =

Re: [PATCH v3] geneve: ensure ECN info is handled properly in all tx/rx paths

2015-09-21 Thread Jesse Gross
On Mon, Sep 21, 2015 at 7:29 AM, John W. Linville wrote: > Partially due to a pre-exising "thinko", the new metadata-based tx/rx > paths were handling ECN propagation differently than the traditional > tx/rx paths. This patch removes the "thinko" (involving multiple >

Re: DSA: phy polling

2015-09-21 Thread Andrew Lunn
On Mon, Sep 14, 2015 at 11:42:54AM +0100, Russell King - ARM Linux wrote: > Andrew, > > I think you're the current maintainer of the Marvell DSA code, as being > the most recent author of changes to it. :) Hi Russell Sorry for the slow reply, i've been on vacation. Humm, i suppose i might be

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread David Miller
From: David Ahern Date: Mon, 21 Sep 2015 16:23:13 -0600 > With the new flag a AND kernel that supports it ip will only show the > table id IF it is not main: > > root@vm-wheezy2:~# ./ip route get 10.0.0.20 > 10.0.0.20 dev eth0 src 10.0.0.2 > cache > >

Re: [PATCH] usbnet: New driver for QinHeng CH9200 devices

2015-09-21 Thread David Miller
From: Matthew Garrett Date: Sun, 20 Sep 2015 02:25:38 -0700 > From: Matthew Garrett > > There's a bunch of cheap USB 10/100 devices based on QinHeng chipsets. The > vendor driver supports the CH9100 and CH9200 devices, but the majority of > the code is of

Re: [PATCH 05/15] RDS: increase size of hash-table to 8K

2015-09-21 Thread David Miller
From: Santosh Shilimkar Date: Sat, 19 Sep 2015 19:04:42 -0400 > Even with per bucket locking scheme, in a massive parallel > system with active rds sockets which could be in excess of multiple > of 10K, rds_bin_lookup() workload is siginificant because of smaller >

[PATCH net-next] tcp: factorize sk_txhash init

2015-09-21 Thread Eric Dumazet
From: Eric Dumazet Neal suggested to move sk_txhash init into tcp_create_openreq_child(), called both from IPv4 and IPv6. This opportunity was missed in commit 58d607d3e52f ("tcp: provide skb->hash to synack packets") Signed-off-by: Eric Dumazet

Re: [PATCH 05/15] RDS: increase size of hash-table to 8K

2015-09-21 Thread santosh shilimkar
On 9/21/2015 4:05 PM, David Miller wrote: From: Santosh Shilimkar Date: Sat, 19 Sep 2015 19:04:42 -0400 Even with per bucket locking scheme, in a massive parallel system with active rds sockets which could be in excess of multiple of 10K, rds_bin_lookup()

Re: pull-request: can-next 2015-09-17

2015-09-21 Thread David Miller
From: Marc Kleine-Budde Date: Mon, 21 Sep 2015 09:20:21 +0200 > this is a pull request of 8 patches for net-next/master. > > All 8 patches are by me and cleanup the flexcan driver. Pulled, thanks Marc. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net-next] net: bcmgenet: Remove duplicate test for tx_coalesce_usecs_high

2015-09-21 Thread David Miller
From: Florian Fainelli Date: Fri, 18 Sep 2015 14:16:53 -0700 > We were checking twice for ec->tx_coalesce_usecs_high, remove the > duplicate test. > > Reported-by: Julia Lawall > Reported-by: kbuild-...@01.org > Fixes: 2f9130709d2c19 ("net: bcmgenet:

Re: [PATCH v2] geneve: remove vlan-related feature assignment

2015-09-21 Thread David Miller
From: "John W. Linville" Date: Fri, 18 Sep 2015 16:20:32 -0400 > The code handling vlan tag insertion was dropped in commit 371bd1061d29 > ("geneve: Consolidate Geneve functionality in single module."). Now we > need to drop the related vlan feature bits in the netdev

Re: [PATCH] geneve: use network byte order for destination port config parameter

2015-09-21 Thread David Miller
From: "John W. Linville" Date: Fri, 18 Sep 2015 15:59:10 -0400 > This is primarily for consistancy with vxlan and other tunnels which > use network byte order for similar parameters. > > Signed-off-by: John W. Linville This doesn't apply to any

Re: [RFC net-next 4/4] net: ipv6: Initial support for VRFs

2015-09-21 Thread Tom Herbert
On Mon, Sep 21, 2015 at 4:32 PM, David Ahern wrote: > Add basic support for VRFs to IPv6 stack. This is a good start point. > ping to and from a VRF works. Basic tcp and udp clients and server all > work fine with VRFs. > > Signed-off-by: David Ahern

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Eric Dumazet
On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: > On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: > > From: Pravin B Shelar > > Date: Sun, 20 Sep 2015 23:53:17 -0700 > > > >> VXLAN device can receive skb with checksum partial. But the

Re: [PATCH RFC 0/3] kcm: Kernel Connection Multiplexor (KCM)

2015-09-21 Thread Sowmini Varadhan
On (09/21/15 15:36), Tom Herbert wrote: > segments. What we need to do, which you're probably doing for RDS, is > do message delineation on the stream as a sequence of: > > 1) Read protocol header to determine message length (BPF used here) right, that's what rds does- first reads the

Re: 197b:0250 JMicron JMC250 Gigabit ethernet doesn't work

2015-09-21 Thread Guo-Fu Tseng
Dear druchaty: Woule it get link if you set set the speed to 100M? If it is, then it is a HW-PHY bug, nothing we can do in driver except set the speed to 100M. On Sat, 19 Sep 2015 21:01:28 +0300, wrote > [1.] One line summary of the problem: 197b:0250 JMicron JMC250

Re: [PATCH] lib: fix data race in rhashtable_rehash_one

2015-09-21 Thread Eric Dumazet
On Tue, 2015-09-22 at 00:25 +0200, Thomas Graf wrote: > On 09/21/15 at 07:51am, Eric Dumazet wrote: > > The important part here is that we rehash an item, so we need to make > > sure to maintain consistent ->next field, and need to prevent compiler > > from using ->next as a temporary variable. >

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread David Miller
From: Pravin B Shelar Date: Sun, 20 Sep 2015 23:53:17 -0700 > VXLAN device can receive skb with checksum partial. But the checksum > offset could be in outer header which is pulled on receive. Such a scenerio is a bug. Anything that pulls off a header should use a utility

Re: [net-next PATCH 0/4] Add support for reading macid when DT macid not found

2015-09-21 Thread David Miller
From: Mugunthan V N Date: Mon, 21 Sep 2015 15:56:49 +0530 > Did a boot test on dra7-evm [1] and am437x-gp-evm [2]. > Pushed a branch [3] for others to test the patch. > > [1]: http://pastebin.ubuntu.com/12513420/ > [2]: http://pastebin.ubuntu.com/12513428/ > [3]:

Re: [PATCH] net: dsa: actually force the speed on the CPU port

2015-09-21 Thread Andrew Lunn
On Mon, Sep 21, 2015 at 09:42:59PM +0100, Russell King wrote: > Commit 54d792f257c6 ("net: dsa: Centralise global and port setup > code into mv88e6xxx.") merged in the 4.2 merge window broke the link > speed forcing for the CPU port of Marvell DSA switches. The original > code was: > >

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Pravin Shelar
On Mon, Sep 21, 2015 at 7:14 PM, Eric Dumazet wrote: > On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: >> On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: >> > From: Pravin B Shelar >> > Date: Sun, 20 Sep 2015 23:53:17

Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter

2015-09-21 Thread Alexander Duyck
On 09/21/2015 10:11 AM, Jarod Wilson wrote: Some pci changes upcoming in 4.3 seem to cause additional disconnects, which can happen at unfortuitous times for igb, leading to issues such as this, where the disconnect happened just before igb_configure_tx_ring(): [ 414.440115] igb :15:00.0:

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread David Miller
From: David Ahern Date: Mon, 21 Sep 2015 15:28:53 -0600 > On 9/21/15 3:19 PM, Stephen Hemminger wrote: >>> @@ -1638,6 +1638,8 @@ static int iproute_get(int argc, char **argv) >>> if (req.r.rtm_family == AF_UNSPEC) >>> req.r.rtm_family = AF_INET; >>> >>>

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread David Miller
From: David Ahern Date: Mon, 21 Sep 2015 16:03:00 -0600 > On 9/21/15 3:58 PM, David Miller wrote: >> I think if it always gave MAIN in older kernels, iproute should >> continue >> to do so. >> >> You can't just remove the table ID output just because you disagree >>

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread David Ahern
On 9/21/15 3:58 PM, David Miller wrote: I think if it always gave MAIN in older kernels, iproute should continue to do so. You can't just remove the table ID output just because you disagree with the semantics given by old kernels. Current semantics are maintained. Kernel was hardcoded to

Re: [PATCH 1/7] phy: fix of_mdio_find_bus() device refcount leak

2015-09-21 Thread David Miller
From: Russell King - ARM Linux Date: Mon, 21 Sep 2015 20:32:07 +0100 > In the case of the mdio mux code, I'm dropping the reference when > either (a) we've encountered an error during initialisation and > we're cleaning up, or (b) when the mdio mux code is being torn down

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread David Ahern
On 9/21/15 4:03 PM, David Miller wrote: From: David Ahern Date: Mon, 21 Sep 2015 16:03:00 -0600 On 9/21/15 3:58 PM, David Miller wrote: I think if it always gave MAIN in older kernels, iproute should continue to do so. You can't just remove the table ID output just

Re: [PATCH] lib: fix data race in rhashtable_rehash_one

2015-09-21 Thread Thomas Graf
On 09/21/15 at 07:51am, Eric Dumazet wrote: > The important part here is that we rehash an item, so we need to make > sure to maintain consistent ->next field, and need to prevent compiler > from using ->next as a temporary variable. > > ptr->next = 1UL | ((base + offset) << 1); > > Is dangerous

[PATCH net v2] openvswitch: Zero flows on allocation.

2015-09-21 Thread Jesse Gross
When support for megaflows was introduced, OVS needed to start installing flows with a mask applied to them. Since masking is an expensive operation, OVS also had an optimization that would only take the parts of the flow keys that were covered by a non-zero mask. The values stored in the

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Eric Dumazet
On Mon, 2015-09-21 at 19:49 -0700, Pravin Shelar wrote: > On Mon, Sep 21, 2015 at 7:14 PM, Eric Dumazet wrote: > > On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: > >> On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: > >> > From: Pravin B

[PATCH v2] netlink: Replace rhash_portid with bound

2015-09-21 Thread Herbert Xu
On Mon, Sep 21, 2015 at 02:20:22PM -0400, Tejun Heo wrote: > > store_release and load_acquire are different from the usual memory > barriers and can't be paired this way. You have to pair store_release > and load_acquire. Besides, it isn't a particularly good idea to OK I've decided to drop the

Re: [RFC PATCH 2/3] net: macb: Add support for 1588 for Zynq Ultrascale+ MPSoC

2015-09-21 Thread Harini Katakam
Hi Richard, On Tue, Sep 22, 2015 at 12:09 AM, Richard Cochran wrote: > On Mon, Sep 21, 2015 at 11:19:32PM +0530, Harini Katakam wrote: >> Ping > > 1) trim your replies > > 2) put the PTP maintainer on PTP patches for review > I'm sorry I missed that. Will do so in the

Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter

2015-09-21 Thread Alexander Duyck
On 09/21/2015 09:14 PM, Jarod Wilson wrote: Alexander Duyck wrote: On 09/21/2015 10:11 AM, Jarod Wilson wrote: Some pci changes upcoming in 4.3 seem to cause additional disconnects, which can happen at unfortuitous times for igb, leading to issues such as this, where the disconnect happened

[PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Sudeep Holla
The device is set as wakeup capable using proper wakeup API but the driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source which is incorrect. This patch removes the use of IRQF_NO_SUSPEND flags replacing it with enable_irq_wake instead. Cc: "David S. Miller"

Re: LOAN!

2015-09-21 Thread JM Financial
Welcome to JM Financial. We give out loans of all kinds. If you are in need of urgent loan kindly contact us now for instant approval for just 2% interest rate. APPLICATION FORM NAME... COUNTRY AMOUNT PHONE NUMBER. ADDRESS DURATION... PURPOSE

Re: [PATCH 00/15] RDS: connection scalability and performance improvements

2015-09-21 Thread santosh shilimkar
On 9/20/2015 1:37 AM, Sagi Grimberg wrote: On 9/20/2015 2:04 AM, Santosh Shilimkar wrote: This series addresses RDS connection bottlenecks on massive workloads and improve the RDMA performance almost by 3X. RDS TCP also gets a small gain of about 12%. RDS is being used in massive systems with

[PATCH 2/7] 8139cp: Do not re-enable RX interrupts in cp_tx_timeout()

2015-09-21 Thread David Woodhouse
From: David Woodhouse If an RX interrupt was already received but NAPI has not yet run when the RX timeout happens, we end up in cp_tx_timeout() with RX interrupts already disabled. Blindly re-enabling them will cause an IRQ storm. This is somewhat less painful than

[PATCH 1/7] 8139cp: Improve accuracy of cp_interrupt() return, to survive IRQ storms

2015-09-21 Thread David Woodhouse
From: David Woodhouse The TX timeout handling has been observed to trigger RX IRQ storms. And since cp_interrupt() just keeps saying that it handled the interrupt, the machine then dies. Fix the return value from cp_interrupt(), and the offending IRQ gets disabled and

Re: [PATCH 2/2] 8139cp: Call __cp_set_rx_mode() from cp_tx_timeout()

2015-09-21 Thread David Woodhouse
On Sun, 2015-09-20 at 22:24 -0700, David Miller wrote: > From: David Woodhouse > Date: Fri, 18 Sep 2015 00:21:54 +0100 > > > Unless we reset the RX config, on real hardware I don't seem to > receive > > any packets after a TX timeout. > > > > Signed-off-by: David Woodhouse

Re: [PATCH] lib: fix data race in rhashtable_rehash_one

2015-09-21 Thread Dmitry Vyukov
On Mon, Sep 21, 2015 at 4:51 PM, Eric Dumazet wrote: > On Mon, 2015-09-21 at 06:31 -0700, Eric Dumazet wrote: >> On Mon, 2015-09-21 at 10:08 +0200, Dmitry Vyukov wrote: >> > rhashtable_rehash_one() uses plain writes to update entry->next, >> > while it is being

  1   2   3   >