Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

2015-10-13 Thread Wangnan (F)
On 2015/10/13 13:15, Alexei Starovoitov wrote: On 10/12/15 9:34 PM, Wangnan (F) wrote: On 2015/10/13 12:16, Alexei Starovoitov wrote: On 10/12/15 8:51 PM, Wangnan (F) wrote: why 'set disable' is needed ? the example given in cover letter shows the use case where you want to receive samples

ICMPv6 too big Packet will makes the network unreachable

2015-10-13 Thread Li RongQing
1. Machine with 2001:1b70:82a8:18:650:65:0:2 address, and receive wrong icmp packets root@du1:~# ifconfig eth10.650 Link encap:Ethernet HWaddr 74:c9:9a:a7:e5:88 inet6 addr: fe80::76c9:9aff:fea7:e588/64 Scope:Link inet6 addr: 2001:1b70:82a8:18:650:65:0:2/80 Scope

Re: [PATCH net-next v2 1/4] bridge: vlan: use proper rcu for the vlgrp member

2015-10-13 Thread Ido Schimmel
Mon, Oct 12, 2015 at 10:47:02PM IDT, ra...@blackwall.org wrote: >From: Nikolay Aleksandrov > >The bridge and port's vlgrp member is already used in RCU way, currently >we rely on the fact that it cannot disappear while the port exists but >that is error-prone and we might miss places with improper

Re: [PATCH net-next v2 2/4] bridge: vlan: use rcu for vlan_list traversal in br_fill_ifinfo

2015-10-13 Thread Ido Schimmel
Mon, Oct 12, 2015 at 10:47:03PM IDT, ra...@blackwall.org wrote: >From: Nikolay Aleksandrov > >br_fill_ifinfo is called by br_ifinfo_notify which can be called from >many contexts with different locks held, sometimes it relies upon >bridge's spinlock only which is a problem for the vlan code, so us

Re: [PATCH net-next v2 3/4] bridge: vlan: drop unnecessary flush code

2015-10-13 Thread Ido Schimmel
Mon, Oct 12, 2015 at 10:47:04PM IDT, ra...@blackwall.org wrote: >From: Nikolay Aleksandrov > >As Ido Schimmel pointed out the vlan_vid_del() code in nbp_vlan_flush is >unnecessary (and is actually a remnant of the old vlan code) so we can >remove it. > >Signed-off-by: Nikolay Aleksandrov Reviewed

Re: [PATCH net-next v2 4/4] bridge: vlan: move back vlan_flush

2015-10-13 Thread Ido Schimmel
Mon, Oct 12, 2015 at 10:47:05PM IDT, ra...@blackwall.org wrote: >From: Nikolay Aleksandrov > >Ido Schimmel reported a problem with switchdev devices because of the >order change of del_nbp operations, more specifically the move of >nbp_vlan_flush() which deletes all vlans and frees vlgrp after the

Re: [PATCH net] ppp: don't override sk->sk_state in pppoe_flush_dev()

2015-10-13 Thread Guillaume Nault
On Tue, Oct 13, 2015 at 05:13:54AM +0300, Denys Fedoryshchenko wrote: > On 2015-10-07 15:12, Guillaume Nault wrote: > >On Mon, Oct 05, 2015 at 02:08:44PM +0200, Guillaume Nault wrote: > >>if (po) { > >>struct sock *sk = sk_pppox(po); > >> > >>- bh_lock_sock(sk); > >>- > >>

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-13 Thread Jiri Pirko
Tue, Oct 13, 2015 at 08:53:45AM CEST, sfel...@gmail.com wrote: >On Mon, Oct 12, 2015 at 11:21 PM, Jiri Pirko wrote: >> Tue, Oct 13, 2015 at 08:03:46AM CEST, john.fastab...@gmail.com wrote: >>>On 15-10-12 10:44 PM, Jiri Pirko wrote: Tue, Oct 13, 2015 at 04:52:42AM CEST, sfel...@gmail.com wrote

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-13 Thread Thomas Gleixner
On Tue, 13 Oct 2015, Richard Cochran wrote: > On Mon, Oct 12, 2015 at 11:45:19AM -0700, Christopher S. Hall wrote: > > The transforms such an application would > > perform are: > > > > System Clock <-> Audio clock > > System Clock <-> Network Device Clock [<-> PTP Master Clock] > > This is extra

Re: [PATCH] pcnet32: fix a logic error with pci_set_dma_mask

2015-10-13 Thread Geliang Tang
On Mon, Oct 12, 2015 at 05:38:14AM -0700, David Miller wrote: > From: Geliang Tang > Date: Fri, 9 Oct 2015 03:45:39 -0700 > > > pcnet32 can't work on my machine recently. It says "architecture > > does not support 32bit PCI busmaster DMA". There is a logic error > > in it: pci_set_dma_mask() ret

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-13 Thread Richard Cochran
On Tue, Oct 13, 2015 at 09:51:02AM +0200, Thomas Gleixner wrote: > > You are restricting the problem space to this particular use > case. There are other use cases where PTP is not available or not the > relevant reference, but you still want to correlate time domains to > ART. They may well be o

Re: [PATCH net-next] switchdev: enforce no pvid flag in vlan ranges

2015-10-13 Thread Ido Schimmel
Mon, Oct 12, 2015 at 08:36:25PM IDT, vivien.dide...@savoirfairelinux.com wrote: >Hi guys, > >On Oct. Monday 12 (42) 02:01 PM, Nikolay Aleksandrov wrote: >> From: Nikolay Aleksandrov >> >> We shouldn't allow BRIDGE_VLAN_INFO_PVID flag in VLAN ranges. >> >> Signed-off-by: Nikolay Aleksandrov >> -

Re: [PATCH net-next V15 0/3] openvswitch: Add support for 802.1ad

2015-10-13 Thread Thomas F Herbert
On 10/13/15 3:58 AM, David Miller wrote: From: Thomas F Herbert Date: Sat, 10 Oct 2015 19:40:30 -0400 Thomas F Herbert (3): openvswitch: 802.1ad uapi changes. Check for vlan ethernet types for 8021.q or 802.1ad 802.1AD: Flow handling, actions, vlan parsing and netlink attributes I th

Re: [PATCH] netlink: trim skb to exact size to avoid MSG_TRUNC

2015-10-13 Thread Thomas Graf
On 10/12/15 at 06:15pm, Ronen Arad wrote: > The available room in the skb allocated in netlink_dump for iproute2 > show requests (e.g. "ip link [show]", "bridge [-c] vlan show") should > be trimmed to the exact size requested in order to avoid MSG_TRUNC flag > set in netlink_recvmg. > This was hand

pull-request: mac80211 2015-10-13

2015-10-13 Thread Johannes Berg
Hi, There are just two small fixes, but I didn't really want to wait since I have nothing else pending. Let me know if there's any problem. johannes The following changes since commit babc305e21ea3811d98b67437299360904ac1b6a: mac80211: reset CQM history upon reconfiguration (2015-09-22 15:22

Re: [PATCH net-next 0/4] tcp: better smp listener behavior

2015-10-13 Thread Daniel Borkmann
On 10/13/2015 11:22 AM, Tobias Klauser wrote: On 2015-10-09 at 20:02:47 +0200, Daniel Borkmann wrote: On 10/09/2015 12:50 PM, Eric Dumazet wrote: On Thu, 2015-10-08 at 20:42 -0700, Tom Herbert wrote: On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet wrote: As promised in last patch series, we im

Re: [PATCH net-next 0/4] tcp: better smp listener behavior

2015-10-13 Thread Tobias Klauser
On 2015-10-09 at 20:02:47 +0200, Daniel Borkmann wrote: > On 10/09/2015 12:50 PM, Eric Dumazet wrote: > >On Thu, 2015-10-08 at 20:42 -0700, Tom Herbert wrote: > >>On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet wrote: > >>>As promised in last patch series, we implement a better SO_REUSEPORT > >>>str

[PATCH] e1000e: fix division by zero on jumbo MTUs

2015-10-13 Thread Leonid Bloch
From: Dmitry Fleytman This patch fixes possible division by zero in receive interrupt handler when working without adaptive interrupt moderation. The adaptive interrupt moderation mechanism is typically disabled on jumbo MTUs. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- dr

Re: [PATCH net-next 0/4] tcp: better smp listener behavior

2015-10-13 Thread Tobias Klauser
On 2015-10-13 at 11:28:13 +0200, Daniel Borkmann wrote: > On 10/13/2015 11:22 AM, Tobias Klauser wrote: > >On 2015-10-09 at 20:02:47 +0200, Daniel Borkmann > >wrote: > >>On 10/09/2015 12:50 PM, Eric Dumazet wrote: > >>>On Thu, 2015-10-08 at 20:42 -0700, Tom Herbert wrote: > On Thu, Oct 8, 20

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

2015-10-13 Thread He Kuang
hi, Alexei What about using similar implementation like PERF_EVENT_IOC_SET_OUTPUT, creating a new ioctl like PERF_EVENT_IOC_SET_ENABLER, then let perf to select an event as 'enabler', then BPF can still control one atomic variable to enable/disable a set of events. you lost me on that last sen

Re: [net-next 11/17] i40e: Add promiscuous on VLAN support

2015-10-13 Thread David Miller
From: Jeff Kirsher Date: Mon, 12 Oct 2015 22:53:12 -0700 > From: Greg Rose > > NFV use cases require the ability to steer packets to VSIs by VLAN tag > alone while being in promiscuous mode for multicast and unicast MAC > addresses. These two new functions support that ability. > > Change-ID:

Re: [PATCH] qlcnic: constify qlcnic_mbx_ops structure

2015-10-13 Thread David Miller
From: Julia Lawall Date: Sun, 11 Oct 2015 13:48:05 +0200 > The only instance of a qlcnic_mbx_ops structure is never modified. Thus > the declaration of the structure and all references to the structure type > can be made const. > > In the definition of the qlcnic_mailbox structure, the ops fiel

Re: [PATCH net-next] RDS: Invoke ->laddr_check() in rds_bind() for explicitly bound transports.

2015-10-13 Thread David Miller
From: Sowmini Varadhan Date: Sun, 11 Oct 2015 16:46:03 -0400 > The IP address passed to rds_bind() should be vetted by the > transport's ->laddr_check() for a previously bound transport. > This needs to be done to avoid cases where, for example, > the application has asked for an IB transport, >

Re: [PATCH net-next] RDS-TCP: Reset tcp callbacks if re-using an outgoing socket in rds_tcp_accept_one()

2015-10-13 Thread David Miller
From: Sowmini Varadhan Date: Sun, 11 Oct 2015 16:49:44 -0400 > > Consider the following "duelling syn" sequence between two peers A and B: > A B > SYN1 --> > <-- SYN2 > SYN2ACK --> > > Note that the SYN/ACK h

Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging

2015-10-13 Thread David Miller
From: Vivien Didelot Date: Sun, 11 Oct 2015 18:08:34 -0400 > DSA and its drivers currently hook the NETDEV_CHANGEUPPER net_device event in > order to configure the VLAN map of every port. > > This VLAN map is a feature of these switch chips to hardcode and restrict > which > output ports a give

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

2015-10-13 Thread Wangnan (F)
On 2015/10/13 18:54, He Kuang wrote: hi, Alexei What about using similar implementation like PERF_EVENT_IOC_SET_OUTPUT, creating a new ioctl like PERF_EVENT_IOC_SET_ENABLER, then let perf to select an event as 'enabler', then BPF can still control one atomic variable to enable/disable a set o

Re: [PATCH v2 2/2] net/fsl_pq_mdio: fix computed address for the TBI register

2015-10-13 Thread David Miller
From: Gerlando Falauto Date: Mon, 12 Oct 2015 09:18:41 +0200 > commit afae5ad78b342f401c28b0bb1adb3cd494cb125a > "net/fsl_pq_mdio: streamline probing of MDIO nodes" > > added support for different types of MDIO devices: > 1) Gianfar MDIO nodes that only map the MII registers > 2) Gianfar MDIO

Re: [PATCH v2 1/2] net/fsl_pq_mdio: check TBI address for consistency with mapped range

2015-10-13 Thread David Miller
From: Gerlando Falauto Date: Mon, 12 Oct 2015 09:18:40 +0200 > When configuring the MDIO subsystem it is also necessary to configure > the TBI register. Make sure the TBI is contained within the mapped > register range in order to: > a) make sure the address is computed correctly > b) make users

Re: [PATCH 0/5] be2net: patch set

2015-10-13 Thread David Miller
From: Sathya Perla Date: Mon, 12 Oct 2015 03:47:16 -0400 > Patch 1 fixes a FW image compatibility check in the driver that > prevents certain FW images from being flashed on BE3 (not BE3-R) > adapters. > > Patch 2 fixes a spin_lock not being released in a failure case in > be_cmd_notify_wait().

Re: [PATCH net-next] switchdev: enforce no pvid flag in vlan ranges

2015-10-13 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 12 Oct 2015 14:01:39 +0200 > From: Nikolay Aleksandrov > > We shouldn't allow BRIDGE_VLAN_INFO_PVID flag in VLAN ranges. > > Signed-off-by: Nikolay Aleksandrov Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [PATCH net] switchdev: check if the vlan id is in the proper vlan range

2015-10-13 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 12 Oct 2015 14:31:01 +0200 > From: Nikolay Aleksandrov > > VLANs 0 and 4095 are reserved and shouldn't be used, add checks to > switchdev similar to the bridge. Also make sure ids above 4095 cannot > be passed either. > > Fixes: 47f8328bb1a4 ("switchdev: ad

Re: [PATCH net-next] bridge: fix gc_timer mod/del race condition

2015-10-13 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 12 Oct 2015 17:55:55 +0200 > From: Nikolay Aleksandrov > > commit c62987bbd8a1 ("bridge: push bridge setting ageing_time down to > switchdev") introduced a timer race condition because the gc_timer can > get rearmed after it's supposedly stopped and flushed

Re: [PATCH] i40evf: fix 32 bit build warnings

2015-10-13 Thread Arnd Bergmann
On Monday 12 October 2015 23:18:21 you wrote: > On Wed, 2015-10-07 at 22:13 +0200, Arnd Bergmann wrote: > > Jesse Brandeburg fixed a bug for 32-bit systems in the i40e driver > > in commit 9c70d7cebfec5 ("i40e: fix 32 bit build warnings"), but the > > same code still exists in the i40evf driver and

Re: [PATCH net] ipv6: Don't call with rt6_uncached_list_flush_dev

2015-10-13 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Mon, 12 Oct 2015 11:02:08 -0500 > > As originally written rt6_uncached_list_flush_dev makes no sense when > called with dev == NULL as it attempts to flush all uncached routes > regardless of network namespace when dev == NULL. Which is simpl

Re: [PATCH net-next 0/4 v3] net: VRF support in IPv6 stack

2015-10-13 Thread David Miller
From: David Ahern Date: Mon, 12 Oct 2015 11:47:06 -0700 > Initial support for VRF in IPv6 stack. Makes IPv6 functionality on par > with IPv4 -- ping, tcp client/server and udp client/server all work fine. > tcpdump on vrf device and external tap (e.g., host side tap device) shows > all packets wi

Re: [PATCH net-next v2 0/4] bridge: vlan: cleanups & fixes (part 3)

2015-10-13 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 12 Oct 2015 21:47:01 +0200 > Patch 01 converts the vlgrp member to use rcu as it was already used in a > similar way so better to make it official and use all the available RCU > instrumentation. Patch 02 fixes a bug where the vlan_list can be traversed > with

Re: [PATCH v4 1/3] net: unix: fix use-after-free in unix_dgram_poll()

2015-10-13 Thread Hannes Frederic Sowa
Hello, On Mon, Oct 12, 2015, at 21:41, Jason Baron wrote: > On 10/09/2015 10:38 AM, Hannes Frederic Sowa wrote: > > Hi, > > > > Jason Baron writes: > > > >> The unix_dgram_poll() routine calls sock_poll_wait() not only for the wait > >> queue associated with the socket s that we are poll'ing ag

Re: Infinite loop in ip6_fragment

2015-10-13 Thread Hannes Frederic Sowa
Hello, On Mon, Oct 12, 2015, at 11:26, Dmitry Vyukov wrote: > [] ip6_fragment+0x37e/0x9d0 net/ipv6/ip6_output.c:805 > [] ip6_finish_output+0xcd/0xe0 > net/ipv6/ip6_output.c:130 > [< inline >] NF_HOOK_COND include/linux/netfilter.h:236 > [] ip6_output+0x3f/0xe0 net/ipv6/ip6_output.c:14

Re: [RFC PATCH 1/2] perf: Add the flag sample_disable not to output data on samples

2015-10-13 Thread Sergei Shtylyov
Hello. On 10/12/2015 12:02 PM, Kaixu Xia wrote: In some scenarios we don't want to output trace data when sampling to reduce overhead. This patch adds the flag sample_disable to implement this function. By setting this flag and integrating with ebpf, we can control the data output process and g

Re: ICMPv6 too big Packet will makes the network unreachable

2015-10-13 Thread Hannes Frederic Sowa
Hello On Tue, Oct 13, 2015, at 09:09, Li RongQing wrote: > 1. Machine with 2001:1b70:82a8:18:650:65:0:2 address, and receive wrong > icmp packets > root@du1:~# ifconfig > eth10.650 Link encap:Ethernet HWaddr 74:c9:9a:a7:e5:88 > inet6 addr: fe80::76c9:9aff:fea7:e588/64 Scope:

[bug report or not] ping6 will lost packets when ping6 lots of ipv6 address

2015-10-13 Thread Li RongQing
1. in a machine, configure 3000 ipv6 address in one interface for i in {1..3000}; do ip -6 addr add 4001:5013::$i/0 dev eth0; done 2. in other machine, ping6 the upper configured ipv6 address, then lots of lost packets ip -6 addr add 4001:5013::0/64 dev eth0 for i in {1..2000}; do ping6 -q -c1

Re: simplify configfs attributes V2

2015-10-13 Thread Christoph Hellwig
On Mon, Oct 05, 2015 at 02:37:05PM -0700, Andrew Morton wrote: > > This series consolidates the code to implement configfs attributes > > by providing the ->show and ->store method in common code and using > > container_of in the methods to access the containing structure. > > > > This reduces sou

Re: Some ICMP-Reply messages don't arrive in User Space in recent Kernels

2015-10-13 Thread Hannes Frederic Sowa
On Tue, Oct 13, 2015, at 08:47, Jörg Pommnitz wrote: > Hello all, > I'm moving an application from 2.6.23 (yes, it's ancient; that's why > we are moving) to 3.18LTS. The application monitors multiple network > links to the same target with ping packets. The different links are > selected either by

Re: Some ICMP-Reply messages don't arrive in User Space in recent Kernels

2015-10-13 Thread Jörg Pommnitz
Hannes, thanks for your reply. It was indeed rp_filter (found it myself). What changed were the default settings in Ubuntu (07.04 to 14.04). Regards Joerg 2015-10-13 15:18 GMT+02:00 Hannes Frederic Sowa : > On Tue, Oct 13, 2015, at 08:47, Jörg Pommnitz wrote: >> Hello all, >> I'm moving an appl

Re: Fwd: Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro

2015-10-13 Thread Kenneth Lee
On Tue, Oct 13, 2015 at 03:06:21PM +0800, huangdaode wrote: > Date: Tue, 13 Oct 2015 15:06:21 +0800 > From: huangdaode > To: Kenneth Lee > Subject: Fwd: Re: [PATCH net-next v2 1/2] hisilicon net: removes the once > HANDEL_TX_MSG macro > Message-ID: <561cad6d.2060...@hisilicon.com> > >--

Re: [net-next 06/17] i40e: Convert CEE App TLV selector to IEEE selector

2015-10-13 Thread Sergei Shtylyov
Hello. On 10/13/2015 8:53 AM, Jeff Kirsher wrote: From: Greg Bowers Changes the parsing of CEE App TLVs to fill in the App selector in struct i40e_dcbx_config with the IEEE App selector so the caller doesn't have to consider whether the App came from a CEE or IEEE DCBX negotiation. Change-ID

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-13 Thread Richard Cochran
Now that I am starting to understand what this code is trying to achieve... On Mon, Oct 12, 2015 at 11:45:19AM -0700, Christopher S. Hall wrote: > The modification to the original patch accomodates these > slow devices by adding the option of providing an ART value outside > of the retry loop and

Re: [PATCH v4 3/4] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping

2015-10-13 Thread Richard Cochran
On Mon, Oct 12, 2015 at 11:45:21AM -0700, Christopher S. Hall wrote: > > +struct ptp_sys_offset_precise { > + unsigned int rsv[4];/* Reserved for future use. */ > + struct ptp_clock_time dev; > + struct ptp_clock_time sys; > +}; > + Please put the reserved field at the bottom. A

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-13 Thread Scott Feldman
On Tue, Oct 13, 2015 at 12:30 AM, Jiri Pirko wrote: > Tue, Oct 13, 2015 at 08:53:45AM CEST, sfel...@gmail.com wrote: >>On Mon, Oct 12, 2015 at 11:21 PM, Jiri Pirko wrote: >>> Tue, Oct 13, 2015 at 08:03:46AM CEST, john.fastab...@gmail.com wrote: On 15-10-12 10:44 PM, Jiri Pirko wrote: > Tu

Re: [PATCH net-next 0/4] tcp: better smp listener behavior

2015-10-13 Thread Eric Dumazet
On Tue, 2015-10-13 at 12:01 +0200, Tobias Klauser wrote: > csumudp6 and csumtcp6 for trafgen are now availble in the netsniff-ng > git as of commit 19c15748 ("trafgen: Add checksum helpers for TCP/UDP > over IPv6"). Awesome, I tested it and it is working properly. Thanks Tobias ! -- To unsubsc

Re: Fwd: Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro

2015-10-13 Thread Arnd Bergmann
On Tuesday 13 October 2015 21:27:12 Kenneth Lee wrote: > > Hi, Arnd, > > Thank you for the comment. Yes, the io_base is a security problem, we > will fix it in coming patch soon. > > But can we keep the sysfs? The interface from hnae is not used only by > ethernet driver but also by Open Data Pl

Re: ICMPv6 too big Packet will makes the network unreachable

2015-10-13 Thread Hannes Frederic Sowa
On Tue, Oct 13, 2015, at 09:09, Li RongQing wrote: > 4. route information will enter the faulty state after Wait 600 > seconds, > >root@du1:~# ip route get 2001:1b70:82a8:18:650:65:0:2 >local 2001:1b70:82a8:18:650:65:0:2 dev lo proto none src > 2001:1b70:82a8:18:650:65:0:2 metric 0 e

Re: [PATCH net-next] switchdev: enforce no pvid flag in vlan ranges

2015-10-13 Thread Vivien Didelot
On Oct. Tuesday 13 (42) 11:31 AM, Ido Schimmel wrote: > Mon, Oct 12, 2015 at 08:36:25PM IDT, vivien.dide...@savoirfairelinux.com > wrote: > >Hi guys, > > > >On Oct. Monday 12 (42) 02:01 PM, Nikolay Aleksandrov wrote: > >> From: Nikolay Aleksandrov > >> > >> We shouldn't allow BRIDGE_VLAN_INFO_PV

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

2015-10-13 Thread Steffen Klassert
Hi David. On Mon, Oct 12, 2015 at 12:49:29PM -0600, David Ahern wrote: > On 10/9/15 11:27 AM, David Ahern wrote: > > > >The attached patch applied to Linus' tree works for me. Currently the > >above change is not in his tree, so I added it to this patch. Once you > >confirm that it works for you I

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-13 Thread Jiri Pirko
Tue, Oct 13, 2015 at 04:07:31PM CEST, sfel...@gmail.com wrote: >On Tue, Oct 13, 2015 at 12:30 AM, Jiri Pirko wrote: >> Tue, Oct 13, 2015 at 08:53:45AM CEST, sfel...@gmail.com wrote: >>>On Mon, Oct 12, 2015 at 11:21 PM, Jiri Pirko wrote: Tue, Oct 13, 2015 at 08:03:46AM CEST, john.fastab...@gm

[PATCH net-next 4/6] net: dsa: mv88e6xxx: implement port_fdb_dump

2015-10-13 Thread Vivien Didelot
Implement the port_fdb_dump DSA operation. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 1 + drivers/net/dsa/mv88e6352.c | 1 + drivers/net/dsa/mv88e6xxx.c | 65 + drivers/net/dsa/mv88e6xxx.h | 3 +++ 4 files changed, 70 insertion

[PATCH net-next 6/6] net: dsa: remove port_fdb_getnext

2015-10-13 Thread Vivien Didelot
No driver implements port_fdb_getnext anymore, and port_fdb_dump is preferred anyway, so remove this function from DSA. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 3 --- net/dsa/slave.c | 25 + 2 files changed, 1 insertion(+), 27 deletions(-) diff --git a/i

[PATCH net-next 0/4] Mellanox driver update, Oct 13 2015

2015-10-13 Thread Or Gerlitz
Hi Dave, This series contains two more patches from Eli, patch from Majd to support PCI error handlers and a fix from Jack to mlx4 VFs when probed without a provisioned mac address. The patch set applied on top of net-next commit bbb300e "Merge branch 'bridge-vlan'" Or. Eli Cohen (2): net/ml

[PATCH net-next 2/4] net/mlx5_core: Add pci error handlers to mlx5_core driver

2015-10-13 Thread Or Gerlitz
From: Majd Dibbiny This patch implement the pci_error_handlers for mlx5_core which allow the driver to recover from PCI error. Once an error is detected in the PCI, the mlx5_pci_err_detected is called and it: 1) Marks the device to be in 'Internal Error' state. 2) Dispatches an event to the mlx5

[PATCH net-next 4/4] net/mlx4_core: Replace VF zero mac with random mac in mlx4_core

2015-10-13 Thread Or Gerlitz
From: Jack Morgenstein By design, when no default MAC addresses are set in the Hypervisor for VFs, the VFs are passed zero-macs. When such a MAC is received by the VF, it generates a random MAC address and registers that MAC address with the Hypervisor. This random mac generation is currently do

[PATCH net-next 1/4] net/mlx5_core: Fix internal error detection conditions

2015-10-13 Thread Or Gerlitz
From: Eli Cohen The detection of a fatal condition has been updated to take into account the state reported by the device or by detecting an all ones read of the firmware version which indicates that the device is not accessible. Signed-off-by: Eli Cohen Signed-off-by: Or Gerlitz --- drivers/

[PATCH net-next 3/4] net/mlx5_core: Wait for FW readiness on startup

2015-10-13 Thread Or Gerlitz
From: Eli Cohen On device initialization, wait till firmware indicates that that it is done with initialization before proceeding to initialize the device. Also update initialization segment layout to match driver/firmware interface definitions. Signed-off-by: Eli Cohen Signed-off-by: Or Gerli

[PATCH net-next 1/6] net: dsa: mv88e6xxx: write VID outside of VTU Get Next code

2015-10-13 Thread Vivien Didelot
There is no need to write the VLAN ID before every Get Next operation, since the VTU VID register is not cleared between calls. Move the VID write call in a _mv88e6xxx_vtu_vid_write function outside of _mv88e6xxx_vtu_getnext so future code could call VTU Get Next multiple times and save a few regi

[PATCH net-next 2/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code

2015-10-13 Thread Vivien Didelot
There is no need to write the MAC address before every Get Next operation, since ATU MAC registers are not cleared between calls. Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext so future code could call ATU Get Next multiple times and save a few register access. --- driv

[PATCH net-next 5/6] net: dsa: mv88e6xxx: remove port_fdb_getnext

2015-10-13 Thread Vivien Didelot
Now that port_fdb_dump is implemented and even simpler, get rid of port_fdb_getnext. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 1 - drivers/net/dsa/mv88e6352.c | 1 - drivers/net/dsa/mv88e6xxx.c | 73 - drivers/net/dsa/mv88e6xxx

[PATCH net-next 0/6] net: dsa: implement port_fdb_dump in drivers

2015-10-13 Thread Vivien Didelot
Not all switch chips provide a Get Next kind of operation to dump FDB entries. It is preferred to let the driver handle the dump operation the way it works best for the chip. Thus, drop port_fdb_getnext and implement the port_fdb_dump operation in DSA, which pushes the switchdev FDB dump callback d

[PATCH net-next 3/6] net: dsa: add port_fdb_dump function

2015-10-13 Thread Vivien Didelot
Not all switch chips support a Get Next operation to iterate on its FDB. So add a more simple port_fdb_dump function for them. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 5 + net/dsa/slave.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/include/net/dsa.h b/include/net/

[PATCH net-next 1/1] tipc: eliminate risk of stalled link synchronization

2015-10-13 Thread Jon Maloy
In commit 6e498158a827 ("tipc: move link synch and failover to link aggregation level") we introduced a new mechanism for performing link failover and synchronization. We have now detected a bug in this mechanism. During link synchronization we use the arrival of any packet on the tunnel link to

pull-request: can-next 2015-09-17

2015-10-13 Thread Marc Kleine-Budde
n-next.git tags/linux-can-next-for-4.4-20151013 for you to fetch changes up to 42160a041db89807691b2a3fbf42e36a98b6019e: can: at91: remove at91_can_data (2015-10-13 17:42:35 +0200) linux-can-next-for-4.

Re: [bug report or not] ping6 will lost packets when ping6 lots of ipv6 address

2015-10-13 Thread Martin KaFai Lau
On Tue, Oct 13, 2015 at 08:46:49PM +0800, Li RongQing wrote: > 1. in a machine, configure 3000 ipv6 address in one interface > > for i in {1..3000}; do ip -6 addr add 4001:5013::$i/0 dev eth0; done > > > 2. in other machine, ping6 the upper configured ipv6 address, then > lots of lost packets > > i

RE: [PATCH v8 1/3] if_link: Add control trust VF

2015-10-13 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Hiroshi Shimamoto Sent: Thursday, August 27, 2015 11:58 PM To: Or Gerlitz ; Alexander Duyck ; Skidmore, Donald C ; Rose, Gregory V ; Kirsher, Jeffrey T ; intel-wired-...@lists.osuosl

RE: [PATCH v8 2/3] ixgbe: Add new ndo to trust VF

2015-10-13 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Hiroshi Shimamoto Sent: Thursday, August 27, 2015 11:59 PM To: Or Gerlitz ; Alexander Duyck ; Skidmore, Donald C ; Rose, Gregory V ; Kirsher, Jeffrey T ; intel-wired-...@lists.osuosl

RE: [Intel-wired-lan] [PATCH v8 3/3] ixgbe, ixgbevf: Add new mbox API xcast mode

2015-10-13 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Hiroshi Shimamoto Sent: Thursday, August 27, 2015 11:59 PM To: Or Gerlitz ; Alexander Duyck ; Skidmore, Donald C ; Rose, Gregory V ; Kirsher, Jeffrey T ; intel-wired-...@lists.osuosl

Re: [PATCH net-next 0/6] net: dsa: implement port_fdb_dump in drivers

2015-10-13 Thread Vivien Didelot
On Oct. Tuesday 13 (42) 11:42 AM, Vivien Didelot wrote: > Not all switch chips provide a Get Next kind of operation to dump FDB entries. > It is preferred to let the driver handle the dump operation the way it works > best for the chip. Thus, drop port_fdb_getnext and implement the port_fdb_dump >

[PATCH net-next] route: fib_validate_source remove the <= RT_SCOPE_HOST test

2015-10-13 Thread Xin Long
commit fe3edf45792a ("ipv4: Remove all RTCF_DIRECTSRC handliing."). Before this commit, we had a tristate: < 0: error 0: ok 1: ok and set RTCF_DIRECTSRC But now we only care about 0 or < 0. Signed-off-by: Xin Long --- net/ipv4/fib_frontend.c | 14 +++--- 1 file changed, 3 insertions(+)

[PATCH net-next v2 6/6] net: dsa: remove port_fdb_getnext

2015-10-13 Thread Vivien Didelot
No driver implements port_fdb_getnext anymore, and port_fdb_dump is preferred anyway, so remove this function from DSA. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 3 --- net/dsa/slave.c | 25 + 2 files changed, 1 insertion(+), 27 deletions(-) diff --git a/i

[PATCH net-next v2 2/6] net: dsa: mv88e6xxx: write VID outside of VTU Get Next code

2015-10-13 Thread Vivien Didelot
There is no need to write the VLAN ID before every Get Next operation, since the VTU VID register is not cleared between calls. Move the VID write call in a _mv88e6xxx_vtu_vid_write function outside of _mv88e6xxx_vtu_getnext so future code could call VTU Get Next multiple times and save a few regi

[PATCH net-next v2 5/6] net: dsa: mv88e6xxx: remove port_fdb_getnext

2015-10-13 Thread Vivien Didelot
Now that port_fdb_dump is implemented and even simpler, get rid of port_fdb_getnext. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 1 - drivers/net/dsa/mv88e6352.c | 1 - drivers/net/dsa/mv88e6xxx.c | 73 - drivers/net/dsa/mv88e6xxx

[PATCH net-next v2 1/6] net: dsa: add port_fdb_dump function

2015-10-13 Thread Vivien Didelot
Not all switch chips support a Get Next operation to iterate on its FDB. So add a more simple port_fdb_dump function for them. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 5 + net/dsa/slave.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/include/net/dsa.h b/include/net/

[PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code

2015-10-13 Thread Vivien Didelot
There is no need to write the MAC address before every Get Next operation, since ATU MAC registers are not cleared between calls. Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext so future code could call ATU Get Next multiple times and save a few register access. --- driv

[PATCH net-next v2 4/6] net: dsa: mv88e6xxx: implement port_fdb_dump

2015-10-13 Thread Vivien Didelot
Implement the port_fdb_dump DSA operation. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 1 + drivers/net/dsa/mv88e6352.c | 1 + drivers/net/dsa/mv88e6xxx.c | 65 + drivers/net/dsa/mv88e6xxx.h | 3 +++ 4 files changed, 70 insertion

[PATCH net-next v2 0/6] net: dsa: implement port_fdb_dump in drivers

2015-10-13 Thread Vivien Didelot
Not all switch chips provide a Get Next kind of operation to dump FDB entries. It is preferred to let the driver handle the dump operation the way it works best for the chip. Thus, drop port_fdb_getnext and implement the port_fdb_dump operation in DSA, which pushes the switchdev FDB dump callback d

[PATCH net 1/1] tipc: eliminate risk of stalled link synchronization

2015-10-13 Thread Jon Maloy
In commit 6e498158a827 ("tipc: move link synch and failover to link aggregation level") we introduced a new mechanism for performing link failover and synchronization. We have now detected a bug in this mechanism. During link synchronization we use the arrival of any packet on the tunnel link to

Re: [PATCH net-next 2/4] net/mlx5_core: Add pci error handlers to mlx5_core driver

2015-10-13 Thread kbuild test robot
Hi Majd, [auto build test WARNING on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Or-Gerlitz/net-mlx5_core-Fix-internal-error-detection-conditions/20151013-234855 repr

Re: [PATCH net-next] route: fib_validate_source remove the <= RT_SCOPE_HOST test

2015-10-13 Thread kbuild test robot
Hi Xin, [auto build test WARNING on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Xin-Long/route-fib_validate_source-remove-the-RT_SCOPE_HOST-test/20151014-004206 config: cris-etrax-100l

Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code

2015-10-13 Thread Florian Fainelli
On 13/10/15 09:46, Vivien Didelot wrote: > There is no need to write the MAC address before every Get Next > operation, since ATU MAC registers are not cleared between calls. > > Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext > so future code could call ATU Get Next multi

Re: [PATCH net-next V15 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-13 Thread Thomas F Herbert
Pravin, Thanks for the review. On 10/13/15 7:47 AM, Pravin Shelar wrote: On Sat, Oct 10, 2015 at 4:40 PM, Thomas F Herbert wrote: Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nest

RE: [PATCH] netlink: trim skb to exact size to avoid MSG_TRUNC

2015-10-13 Thread Arad, Ronen
>-Original Message- >From: Thomas Graf [mailto:tg...@suug.ch] >Sent: Tuesday, October 13, 2015 1:56 AM >To: Arad, Ronen >Cc: netdev@vger.kernel.org >Subject: Re: [PATCH] netlink: trim skb to exact size to avoid MSG_TRUNC > >On 10/12/15 at 06:15pm, Ronen Arad wrote: >> The available room i

Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code

2015-10-13 Thread Vivien Didelot
On Oct. Tuesday 13 (42) 10:35 AM, Florian Fainelli wrote: > On 13/10/15 09:46, Vivien Didelot wrote: > > There is no need to write the MAC address before every Get Next > > operation, since ATU MAC registers are not cleared between calls. > > > > Move the _mv88e6xxx_atu_mac_write call outside of _

Re: [PATCH net-next V15 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-13 Thread Pravin Shelar
On Tue, Oct 13, 2015 at 10:39 AM, Thomas F Herbert wrote: > Pravin, > > Thanks for the review. > > > On 10/13/15 7:47 AM, Pravin Shelar wrote: >> >> On Sat, Oct 10, 2015 at 4:40 PM, Thomas F Herbert >> wrote: >>> >>> Add support for 802.1ad including the ability to push and pop double >>> tagged

Re: NULL pointer dereference in rt6_get_cookie()

2015-10-13 Thread Martin KaFai Lau
On Sat, Oct 10, 2015 at 03:24:37PM +0200, Phil Sutter wrote: > The conditional at the start of the function evaluates true, since > 'rt->rt6i_flags & RTF_PCPU' is non-zero. Hi Phil, can you try the following patch and capture the dmesg output to confirm the value of rt->rt6i_flags and the rt->dst.f

Re: [4.1.3-rt8] [report][cpuhotplug] BUG: spinlock bad magic on CPU#0, sh/137

2015-10-13 Thread Grygorii Strashko
On 10/12/2015 11:16 AM, Thomas Gleixner wrote: > On Fri, 9 Oct 2015, Grygorii Strashko wrote: >> I can constantly see below error report with 4.1 RT-kernel on TI ARM dra7-evm >> if I'm trying to unplug cpu1: >> >> [ 57.737589] CPU1: shutdown >> [ 57.767537] BUG: spinlock bad magic on CPU#0, sh/

Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code

2015-10-13 Thread Florian Fainelli
On 13/10/15 11:11, Vivien Didelot wrote: > On Oct. Tuesday 13 (42) 10:35 AM, Florian Fainelli wrote: >> On 13/10/15 09:46, Vivien Didelot wrote: >>> There is no need to write the MAC address before every Get Next >>> operation, since ATU MAC registers are not cleared between calls. >>> >>> Move the

Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code

2015-10-13 Thread Vivien Didelot
On Oct. Tuesday 13 (42) 12:46 PM, Vivien Didelot wrote: > There is no need to write the MAC address before every Get Next > operation, since ATU MAC registers are not cleared between calls. > > Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext > so future code could call ATU

Re: [PATCH] i40evf: fix 32 bit build warnings

2015-10-13 Thread Jeff Kirsher
On Tue, 2015-10-13 at 13:37 +0200, Arnd Bergmann wrote: > This is the majority of all build warnings we get on allmodconfig > (both i386 and arm), > so it would be really nice to have it fixed before 4.3. For all I can > tell, the > patch still applies on your branch too, but see below for the reba

Re: [PATCH] i40evf: fix 32 bit build warnings

2015-10-13 Thread Jeff Kirsher
On Tue, 2015-10-13 at 13:37 +0200, Arnd Bergmann wrote: > This is the majority of all build warnings we get on allmodconfig > (both i386 and arm), > so it would be really nice to have it fixed before 4.3. For all I can > tell, the > patch still applies on your branch too, but see below for the reba

Re: NULL pointer dereference in rt6_get_cookie()

2015-10-13 Thread Phil Sutter
Hi Martin, On Tue, Oct 13, 2015 at 11:14:43AM -0700, Martin KaFai Lau wrote: > On Sat, Oct 10, 2015 at 03:24:37PM +0200, Phil Sutter wrote: > > The conditional at the start of the function evaluates true, since > > 'rt->rt6i_flags & RTF_PCPU' is non-zero. > Hi Phil, can you try the following patch

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-13 Thread Thomas Gleixner
On Tue, 13 Oct 2015, Richard Cochran wrote: > On Tue, Oct 13, 2015 at 09:51:02AM +0200, Thomas Gleixner wrote: > > > > You are restricting the problem space to this particular use > > case. There are other use cases where PTP is not available or not the > > relevant reference, but you still want

Re: [PATCH net-next] route: fib_validate_source remove the <= RT_SCOPE_HOST test

2015-10-13 Thread Julian Anastasov
Hello, On Wed, 14 Oct 2015, Xin Long wrote: > commit fe3edf45792a ("ipv4: Remove all RTCF_DIRECTSRC handliing."). > > Before this commit, we had a tristate: > < 0: error > 0: ok > 1: ok and set RTCF_DIRECTSRC > > But now we only care about 0 or < 0. Not true, __mkroute_input()

Re: [PATCH] i40evf: fix 32 bit build warnings

2015-10-13 Thread Jesse Brandeburg
On Tue, 13 Oct 2015 13:37:04 +0200 Arnd Bergmann wrote: > On Monday 12 October 2015 23:18:21 you wrote: > > On Wed, 2015-10-07 at 22:13 +0200, Arnd Bergmann wrote: > > > Jesse Brandeburg fixed a bug for 32-bit systems in the i40e driver > > > in commit 9c70d7cebfec5 ("i40e: fix 32 bit build warni

  1   2   >