On Sun, Nov 15, 2015 at 11:36 PM, Ondrej Zary
wrote:
> Add support for IP1000A chips to dl2k driver.
> IP1000A chip looks like a TC9020 with integrated PHY.
>
> This allows IP1000A chips to work reliably because the ipg driver is
> buggy - it loses packets under load and then completely stops
> tr
On Fri, Nov 13, 2015 at 4:06 PM, Ivan Vecera wrote:
>
> Remove rsstable array and its initialization from be_set_rss_hash_opts().
> The array became unused after "e255787 be2net: Support for configurable
> RSS hash key". The initial RSS table is now filled and stored for later
> usage during Rx qu
On Fri, Nov 13, 2015 at 3:22 PM, Ivan Vecera wrote:
> The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get
> the current size of registers for ethtool registers dump. The size
> is stored in data_read but only when the returned status is 0 otherwise
> it is uninitialized thus random
On 11/16/2015 09:57 AM, Sathya Perla wrote:
On Fri, Nov 13, 2015 at 3:22 PM, Ivan Vecera wrote:
The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get
the current size of registers for ethtool registers dump. The size
is stored in data_read but only when the returned status is 0 ot
This patch explains the occasion of "hisilcon,mdio" and
"hisilicon,hns-mdio" according to Arnd's comments.
and reformat it according to comments from Rob.
chang log:
v2:
1) reformat the style.
2) make it more clearity.
v1:
initial version.
Signed-off-by: huangdaode
---
Documentation/dev
Hello,
I am looking to offload bond interfaces to hardware for forwarding. Linux
allows for configuring
a variety of parameters on bonds or slave interfaces. Not all configurations
can be offloaded to
hardware. For example, certain hardware cannot support bonds with mode of
adaptive load b
On Monday 16 November 2015 17:38:24 huangdaode wrote:
> This patch explains the occasion of "hisilcon,mdio" and
> "hisilicon,hns-mdio" according to Arnd's comments.
> and reformat it according to comments from Rob.
>
> chang log:
>
> v2:
> 1) reformat the style.
> 2) make it more clearity.
>
From: Markus Elfring
Date: Mon, 16 Nov 2015 10:40:11 +0100
Another update suggestion was taken into account after a patch was applied
from static source code analysis.
Markus Elfring (2):
Delete an unnecessary check before the function call "kfree_skb"
One function call less in mISDN_sock_se
From: Markus Elfring
Date: Mon, 16 Nov 2015 10:10:53 +0100
The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers
From: Markus Elfring
Date: Mon, 16 Nov 2015 10:30:29 +0100
The kfree_skb() function was called in one case by the
mISDN_sock_sendmsg() function during error handling even if a call of
the _l2_alloc_skb() function returned a null pointer.
This implementation detail could be improved by the introd
rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op,
but when CONFIG_NET_SWITCHDEV is off, it returns an error.
Fix that by returning the given unmodified idx.
A similar fix was 0890cf6cb6ab ("switchdev: fix return value of
switchdev_port_fdb_dump in case of error") but fo
On Thu, Nov 12, 2015, at 17:35, Jason A. Donenfeld wrote:
> Drivers like vxlan use the recently introduced
> udp_tunnel_xmit_skb/udp_tunnel6_xmit_skb APIs. udp_tunnel6_xmit_skb
> makes use of ip6tunnel_xmit, and ip6tunnel_xmit, after sending the
> packet, updates the struct stats using the usual
>
From: Markus Elfring
Date: Mon, 16 Nov 2015 11:17:55 +0100
The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers
> So maybe add some wrapper that does a pr_info then
> a pr_debug for the second and subsequent uses like:
>
That seems like a bad idea - one might be tricked into think that one
saw the current data, but the actually current data is later hidden.
johannes
--
To unsubscribe from this list: send
Mon, Nov 16, 2015 at 10:52:48AM CET, dra...@endocode.com wrote:
>rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op,
>but when CONFIG_NET_SWITCHDEV is off, it returns an error.
>
>Fix that by returning the given unmodified idx.
>
>A similar fix was 0890cf6cb6ab ("switchdev:
Fix the following warning:
CC net/core/rtnetlink.o
net/core/rtnetlink.c: In function ‘rtnl_fill_ifinfo’:
net/core/rtnetlink.c:1308:1: warning: the frame size of 2864 bytes is larger
than 2048 bytes [-Wframe-larger-than=]
}
^
By declaring the huge stack allocations as static. We can do s
From: Markus Elfring
Date: Mon, 16 Nov 2015 12:23:23 +0100
The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
On Sunday 15 November 2015 16:58:33 Grant Zhang wrote:
>
> Have you tried the two patches Eric mentioned? One of my 4.1.11 server
> just hanged with very similar stack trace and I am wondering whether the
> aforementioned patches would help.
Sorry, Grant - I'm sticking to 3.14.xx for now.
best r
o While the driver is in the middle of a MB completion processing
and it receives a spurious MB interrupt, it is mistaken as a good MB
completion interrupt leading to premature completion of the next MB
request. Fix the driver to guard against this by checking the current
state of MB processing and
On Sat, Nov 14, 2015 at 01:26:53AM +0100, Daniel Borkmann wrote:
> During review I noticed that the icache range we're flushing should
> start at header already and not at ctx.image.
>
> Reason is that after 55309dd3d4cd ("net: bpf: arm: address randomize
> and write protect JIT code"), we also wa
From: Markus Elfring
Date: Mon, 16 Nov 2015 12:46:41 +0100
The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
driver
On Mon, Nov 16, 2015 at 11:40:55AM +, Mark Rutland wrote:
> On Sat, Nov 14, 2015 at 01:26:53AM +0100, Daniel Borkmann wrote:
> > During review I noticed that the icache range we're flushing should
> > start at header already and not at ctx.image.
> >
> > Reason is that after 55309dd3d4cd ("net
From: Markus Elfring
Date: Mon, 16 Nov 2015 13:12:25 +0100
The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
driver
By default the driver allowed incorrect frames to be received. What is
worse the code does not handle very short frames correctly. The FCS
length is unconditionally subtracted, and the underflow can cause
skb_put to be called with large number after implicit cast to unsigned.
And indeed, an skb_ove
From: Markus Elfring
Date: Mon, 16 Nov 2015 13:30:37 +0100
The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
In case of invalid number_destination_params we were returning error but
we missed releasing cmd. Lets check for the number of parameter before
allocating memory so that we don't have a memory leak.
Signed-off-by: Sudip Mukherjee
---
net/nfc/nci/core.c | 6 +++---
1 file changed, 3 insertions(+)
From: Markus Elfring
Date: Mon, 16 Nov 2015 13:50:23 +0100
The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers
Jiri,
on 4.4-rc1 running on an s390x box (so qeth OSA network cards as real NICs) I
get errors like:
[ 10.940523] Ebtables v2.0 registered
[ 11.685609] bridge: automatic filtering via arp/ip/ip6tables has been
deprecated. Update your scripts to load br_netfilter if you need this.
[ 11.686
On Mon, Nov 16, 2015 at 02:00:32PM +0100, Christian Borntraeger wrote:
>
> on 4.4-rc1 running on an s390x box (so qeth OSA network cards as real NICs) I
> get errors like:
>
> [ 10.940523] Ebtables v2.0 registered
> [ 11.685609] bridge: automatic filtering via arp/ip/ip6tables has been
> de
Hello!
> > If device probe fails, driver remains bound to the PCI device. However,
> > driver data has been reset to NULL. This causes crash upon dereferencing
> > it in nicvf_remove()
> >
> > Signed-off-by: Pavel Fedin
>
> Applied, thanks.
Thank you very much, however i've just found one mor
Mon, Nov 16, 2015 at 02:19:55PM CET, mkube...@suse.cz wrote:
>On Mon, Nov 16, 2015 at 02:00:32PM +0100, Christian Borntraeger wrote:
>>
>> on 4.4-rc1 running on an s390x box (so qeth OSA network cards as real NICs)
>> I get errors like:
>>
>> [ 10.940523] Ebtables v2.0 registered
>> [ 11.685
If device probe fails, driver remains bound to the PCI device. However,
driver data has been reset to NULL. This causes crash upon dereferencing
it in nicvf_remove()
Signed-off-by: Pavel Fedin
---
v1 => v2:
- Do the test in nicvf_remove(), this allows to cover more situations
---
drivers/net/eth
On 11/16/2015 02:19 PM, Michal Kubecek wrote:
> On Mon, Nov 16, 2015 at 02:00:32PM +0100, Christian Borntraeger wrote:
>>
>> on 4.4-rc1 running on an s390x box (so qeth OSA network cards as real NICs)
>> I get errors like:
>>
>> [ 10.940523] Ebtables v2.0 registered
>> [ 11.685609] bridge: aut
On 11/16/2015 02:25 PM, Jiri Pirko wrote:
> Mon, Nov 16, 2015 at 02:19:55PM CET, mkube...@suse.cz wrote:
>> On Mon, Nov 16, 2015 at 02:00:32PM +0100, Christian Borntraeger wrote:
>>>
>>> on 4.4-rc1 running on an s390x box (so qeth OSA network cards as real NICs)
>>> I get errors like:
>>>
>>> [
Hello.
On 16/11/15 13:57, SF Markus Elfring wrote:
From: Markus Elfring
Date: Mon, 16 Nov 2015 13:50:23 +0100
The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle
list_next_entry has been defined in list.h, so I replace list_entry_next
with it.
Signed-off-by: Geliang Tang
---
net/ceph/messenger.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
index 9981039..b1d1489 100644
--- a/net/ce
From: Pavel Fedin
Date: Mon, 16 Nov 2015 16:21:06 +0300
> Thank you very much, however i've just found one more case where i
> still get this crash. I should have done this from the beginning,
> but please revert it in your repo, i'm sending v2, which covers more
> cases. The new case is feedin
From: Pavel Fedin
Date: Mon, 16 Nov 2015 16:22:26 +0300
> If device probe fails, driver remains bound to the PCI device. However,
> driver data has been reset to NULL. This causes crash upon dereferencing
> it in nicvf_remove()
>
> Signed-off-by: Pavel Fedin
> ---
> v1 => v2:
> - Do the test in
In some cases the crash is caused by nicvf_remove() being called from
outside. For example, if we try to feed the device to vfio after the
probe has failed for some reason. So, move the check to better place.
Signed-off-by: Pavel Fedin
---
drivers/net/ethernet/cavium/thunder/nicvf_main.c | 13 ++
commit 5d9a07b0de512b77bf28d2401e5fe3351f00a240 ("vhost: relax used
address alignment") fixed the alignment for the used virtual address,
but not for the physical address used for logging.
That's a mistake: alignment should clearly be the same for virtual and
physical addresses,
Signed-off-by: Mi
On Sun, 2015-11-15 at 16:58 -0800, Grant Zhang wrote:
> Hi Patrick,
>
> Have you tried the two patches Eric mentioned? One of my 4.1.11 server
> just hanged with very similar stack trace and I am wondering whether the
> aforementioned patches would help.
>
> Thanks,
linux-4.1.12 definitely con
On Mon, Nov 16, 2015 at 05:38:24PM +0800, huangdaode wrote:
> This patch explains the occasion of "hisilcon,mdio" and
> "hisilicon,hns-mdio" according to Arnd's comments.
> and reformat it according to comments from Rob.
>
> chang log:
>
> v2:
> 1) reformat the style.
> 2) make it more cleari
In case multiple writes to a unix stream socket race we could end up in a
situation where we pre-allocate a new skb for use in unix_stream_sendpage
but have to free it again in the locked section because another skb
has been appended meanwhile, which we must use. Accidentally we didn't
clear the po
Mon, Nov 16, 2015 at 10:29:12AM CET, pjonn...@broadcom.com wrote:
>Hello,
>
>I am looking to offload bond interfaces to hardware for forwarding. Linux
>allows for configuring
>a variety of parameters on bonds or slave interfaces. Not all configurations
>can be offloaded to
>hardware. For exa
Fra: Kristine Krarup
Sendt: 16. november 2015 15:58
Emne: Donation
cash grant to you by a kind hearted Family , send an email to them now
requesting more information (sessil_malcol...@outlook.com)
Thank you
--
To unsubscribe from this list: send the line "unsubsc
On Thu 12-11-15 18:41:32, Johannes Weiner wrote:
> Socket memory can be a significant share of overall memory consumed by
> common workloads. In order to provide reasonable resource isolation in
> the unified hierarchy, this type of memory needs to be included in the
> tracking/accounting of a cgro
On 15-11-16 07:30 AM, Jiri Pirko wrote:
> Mon, Nov 16, 2015 at 10:29:12AM CET, pjonn...@broadcom.com wrote:
>> Hello,
>>
>> I am looking to offload bond interfaces to hardware for forwarding. Linux
>> allows for configuring
>> a variety of parameters on bonds or slave interfaces. Not all
>> co
On 15-11-15 01:01 AM, Jiri Pirko wrote:
> Sun, Nov 15, 2015 at 06:51:28AM CET, john.fastab...@gmail.com wrote:
>> On 15-11-14 01:39 AM, Jiri Pirko wrote:
>>> Thu, Nov 12, 2015 at 05:02:18PM CET, pjonn...@broadcom.com wrote:
Packet forwarding to/from bond interfaces is done in software.
>>
On Mon, 2015-11-16 at 16:25 +0100, Hannes Frederic Sowa wrote:
> In case multiple writes to a unix stream socket race we could end up in a
> situation where we pre-allocate a new skb for use in unix_stream_sendpage
> but have to free it again in the locked section because another skb
> has been app
On 16/11/2015 07:07, Eric Dumazet wrote:
On Sun, 2015-11-15 at 16:58 -0800, Grant Zhang wrote:
Hi Patrick,
Have you tried the two patches Eric mentioned? One of my 4.1.11 server
just hanged with very similar stack trace and I am wondering whether the
aforementioned patches would help.
Thanks,
** CID 1056375: Error handling issues (CHECKED_RETURN)
/drivers/net/ethernet/mellanox/mlx5/core/cq.c: 133 in mlx5_core_create_cq()
*** CID 1056375: Error handling issues (CHECKED_RETURN)
/
On Sat, Nov 14, 2015 at 07:33:10PM +0300, Vladimir Davydov wrote:
> On Thu, Nov 12, 2015 at 06:41:24PM -0500, Johannes Weiner wrote:
> > Move the jump-label from sock_update_memcg() and sock_release_memcg()
> > to the callsite, and so eliminate those function calls when socket
> > accounting is not
Hello Eric
2015-11-12, 09:26:42 -0800, Eric Dumazet wrote:
> Note that the following patch (and corresponding part for ipv6) might
> also have solve the issue ?
>
> This would supposedly save some cycles when MSG_PEEK is used and user
> provides short buffers.
Your patch looks correct to me, fee
On Fri, 2015-10-09 at 19:33 +0200, Daniel Borkmann wrote:
> On 10/09/2015 04:35 AM, Alexei Starovoitov wrote:
> > On 10/8/15 5:50 PM, Devon H. O'Dell wrote:
> >>> with the amount of skb_sender_cpu_clear() all over the code base
> >>> >I wonder whether there is a better solution to all of these.
> >
the OUTMCAST stat is double incremented, getting bumped once in the mcast code
itself, and again in the common ip output path. Remove the mcast bump, as its
not needed
Validated by the reporter, with good results
Signed-off-by: Neil Horman
Reported-by: Claus Jensen
CC: Claus Jensen
CC: David
A recent flaw in the netdev feature setting resulted in warnings
like this one from VLAN interfaces:
WARNING: CPU: 1 PID: 4975 at net/core/dev.c:2419
skb_warn_bad_offload+0xbc/0xcb()
: caps=(0x001b5820, 0x001b5829) len=2782 data_len=0
gso_size=1348 gso_type=16 ip_summed=3
The
On Mon, Nov 16, 2015 at 04:59:25PM +0100, Michal Hocko wrote:
> On Thu 12-11-15 18:41:32, Johannes Weiner wrote:
> > Socket memory can be a significant share of overall memory consumed by
> > common workloads. In order to provide reasonable resource isolation in
> > the unified hierarchy, this type
This adds a driver for the Aurora VLSI NB8800 Ethernet controller.
It is an almost complete rewrite of a driver originally found in
a Sigma Designs 2.6.22 tree.
Signed-off-by: Mans Rullgard
---
Changes:
- Use napi_gro_receive()
- Ignore xmit_more if using last tx descriptor
- Perform tx cleanup f
On Sun, Nov 15, 2015 at 04:54:57PM +0300, Vladimir Davydov wrote:
> On Thu, Nov 12, 2015 at 06:41:33PM -0500, Johannes Weiner wrote:
> > Let the networking stack know when a memcg is under reclaim pressure
> > so that it can clamp its transmit windows accordingly.
> >
> > Whenever the reclaim effi
From: "Jason A. Donenfeld"
Date: Thu, 12 Nov 2015 17:35:58 +0100
> Drivers like vxlan use the recently introduced
> udp_tunnel_xmit_skb/udp_tunnel6_xmit_skb APIs. udp_tunnel6_xmit_skb
> makes use of ip6tunnel_xmit, and ip6tunnel_xmit, after sending the
> packet, updates the struct stats using the
From: Mans Rullgard
Date: Thu, 12 Nov 2015 18:41:12 +
> This adds support for the Vitesse VSC8601 PHY. Generic functions are
> used for everything except interrupt handling.
>
> Signed-off-by: Mans Rullgard
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
th
From: Mans Rullgard
Date: Thu, 12 Nov 2015 17:40:20 +
> Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt mode"
> added interrupt support for the 8031 PHY but left out the other two
> chips supported by this driver.
>
> This patch sets the .ack_interrupt and .config_intr funct
hi,
I'm debugging an issue on the Broadcom parts (using unimac-mdio.c as
the mdio bus) where i occasionally see MDIO bus read failures, which
causes phy.c to transition the PHY to PHY_HALTED. It stays in this
state until the link is bounced.
So, what's the expectation to handle this and recover f
On Mon, Nov 16, 2015 at 8:17 PM, David Miller wrote:
> So another fix could have been to do local_bh_disable() in the
> udp_tunnel6_xmit_skb() helper.
This would have fixed one problem, but everywhere
udp_tunnel_xmit_skb() (4, not 6) is called, iptunnel_xmit_stats is
called right after it, so the
From: Yang Shi
Date: Thu, 12 Nov 2015 13:57:00 -0800
> BPF fp should point to the top of the BPF prog stack. The original
> implementation made it point to the bottom incorrectly.
> Move A64_SP to fp before reserve BPF prog stack space.
>
> CC: Zi Shen Lim
> CC: Xi Wang
> Signed-off-by: Yang S
From: Yang Shi
Date: Thu, 12 Nov 2015 14:07:46 -0800
> commit 338d4f49d6f7114a017d294ccf7374df4f998edc
> ("arm64: kernel: Add support for Privileged Access Never") includes sysreg.h
> into futex.h and uaccess.h. But, the inline assembly used by asm/sysreg.h is
> incompatible with llvm so it will
From: Daniel Borkmann
Date: Sat, 14 Nov 2015 01:26:53 +0100
> During review I noticed that the icache range we're flushing should
> start at header already and not at ctx.image.
>
> Reason is that after 55309dd3d4cd ("net: bpf: arm: address randomize
> and write protect JIT code"), we also want
From: Pavel Fedin
Date: Fri, 13 Nov 2015 09:46:59 +0300
> On certain hardware after software reboot the chip may get stuck and fail
> to reinitialize during reset. This can be fixed by ensuring that PHY is
> reset too.
>
> Old PHY resetting method required operational MDIO interface, therefore
>
From: Yoshihiro Kaneko
Date: Fri, 13 Nov 2015 19:24:49 +0900
> From: Masaru Nagai
>
> When RX/TX interrupt for Network Control queue and Best Effort queue
> is issued at the same time, the interrupt mask of Network Control
> queue will be reset when the mask of Best Effort queue is set.
> This
From: Ivan Vecera
Date: Fri, 13 Nov 2015 11:36:58 +0100
> Signed-off-by: Ivan Vecera
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Ivan Vecera
Date: Fri, 13 Nov 2015 11:36:57 +0100
> Remove rsstable array and its initialization from be_set_rss_hash_opts().
> The array became unused after "e255787 be2net: Support for configurable
> RSS hash key". The initial RSS table is now filled and stored for later
> usage during Rx
On 11/13/2015 6:39 PM, Z Lim wrote:
Yang, I noticed another thing...
On Fri, Nov 13, 2015 at 10:09 AM, Yang Shi wrote:
Save and restore FP/LR in BPF prog prologue and epilogue, save SP to FP
in prologue in order to get the correct stack backtrace.
However, ARM64 JIT used FP (x29) as eBPF fp r
On 16/11/15 11:29, Adrian Chadd wrote:
> hi,
>
> I'm debugging an issue on the Broadcom parts (using unimac-mdio.c as
> the mdio bus) where i occasionally see MDIO bus read failures, which
> causes phy.c to transition the PHY to PHY_HALTED. It stays in this
> state until the link is bounced.
Ther
Hi David & Folks,
I have a virtual device driver that does some fancy processing of
packets in ndo_start_xmit before forwarding them onward out of a
tunnel elsewhere. In order to make that fancy processing fast, I have
AVX and AVX2 implementations. This means I need to use the FPU.
So, I do the u
From: Ido Schimmel
Date: Fri, 13 Nov 2015 13:06:12 +0200
> When NET_SWITCHDEV=n, switchdev_port_attr_set simply returns EOPNOTSUPP.
> In this case we should not emit errors and warnings to the kernel log.
>
> Reported-by: Sander Eikelenboom
> Fixes: 0bc05d585d38 ("switchdev: allow caller to exp
From: Nikolay Aleksandrov
Date: Fri, 13 Nov 2015 14:54:01 +0100
> From: Nikolay Aleksandrov
>
> When __netdev_update_features() was updated to ensure some features are
> disabled on new lower devices, an error was introduced for devices which
> don't have the ndo_set_features() method set. Befo
From: Nikolay Aleksandrov
Date: Fri, 13 Nov 2015 15:20:24 +0100
> From: Nikolay Aleksandrov
>
> If ndo_set_features fails __netdev_update_features() will return -1 but
> this is wrong because it is expected to return 0 if no features were
> changed (see netdev_update_features()), which will cau
From: Daniele Palmas
Date: Fri, 13 Nov 2015 18:01:21 +0100
> Since Dell DW5580 is a 3G modem, this patch adds the device as a
> mobile broadband adapter
>
> Signed-off-by: Daniele Palmas
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to m
On 16 November 2015 at 11:48, Florian Fainelli wrote:
> On 16/11/15 11:29, Adrian Chadd wrote:
>> hi,
>>
>> I'm debugging an issue on the Broadcom parts (using unimac-mdio.c as
>> the mdio bus) where i occasionally see MDIO bus read failures, which
>> causes phy.c to transition the PHY to PHY_HALT
From: Shrikrishna Khare
Date: Fri, 13 Nov 2015 15:42:10 -0800
> Signed-off-by: Shrikrishna Khare
> Reported-by: Masao Uebayashi
> Signed-off-by: Bhavesh Davda
You guys really have to stop targetting simple, straightforward,
bug fixes at net-next. That is not appropriate.
Bug fixes should ta
From: Julia Lawall
Date: Sat, 14 Nov 2015 11:06:57 +0100
> This pci_error_handlers structure is never modified, like all the other
> pci_error_handlers structures, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
Applied.
--
To unsubscribe from thi
From: Julia Lawall
Date: Sat, 14 Nov 2015 11:06:53 +0100
> This pci_error_handlers structure is never modified, like all the other
> pci_error_handlers structures, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
Applied.
--
To unsubscribe from thi
From: Ben Cartwright-Cox
Date: Sat, 14 Nov 2015 15:13:58 +
> Sending ICMP packets with raw sockets ends up in the SNMP counters
> logging the type as the first byte of the IPv4 header rather than
> the ICMP header. This is fixed by adding the IP Header Length to
> the casting into a icmphdr s
On 16/11/15 12:05, Adrian Chadd wrote:
> On 16 November 2015 at 11:48, Florian Fainelli wrote:
>> On 16/11/15 11:29, Adrian Chadd wrote:
>>> hi,
>>>
>>> I'm debugging an issue on the Broadcom parts (using unimac-mdio.c as
>>> the mdio bus) where i occasionally see MDIO bus read failures, which
>>>
From: Yoshihiro Kaneko
Date: Sun, 15 Nov 2015 21:34:42 +0900
> From: Masaru Nagai
>
> This driver does not handle the AVB-DMAC Receive FIFO Warning interrupt
> now, so the interrupt should not be enabled.
>
> Signed-off-by: Masaru Nagai
> Signed-off-by: Yoshihiro Kaneko
Applied, thanks.
--
I'm starting to grow quite weary of these "unnecessary check" changes.
Sometimes it is better to have them, either because the path is a hot
path or some atomic sequence is involved.
But there is never harm in them being there.
All of this is a matter of taste, of course. But one thing I know
From: Yuval Mintz
Date: Sun, 15 Nov 2015 15:02:16 +0200
> Commit 05cc5a39ddb7 "bnx2x: add vlan filtering offload" introduced
> a regression in regard for vlans for 57710, 57711 adapters -
> Loading 8021q module on a machine with such an adapter would cause
> a null pointer dereference, as the dri
Hi folks,
A few tunnel devices, like geneve or vxlan, are using
udp_tunnel_xmit_skb, or related functions for transmitting packets,
and are doing the usual FIB lookup to get the dst entry. I see a lot
of code like this:
if (rt->dst.dev == dev) {
netdev_dbg(
From: Dragos Tatulea
Date: Mon, 16 Nov 2015 10:52:48 +0100
> rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op,
> but when CONFIG_NET_SWITCHDEV is off, it returns an error.
>
> Fix that by returning the given unmodified idx.
>
> A similar fix was 0890cf6cb6ab ("switchd
From: Rajesh Borundia
Date: Mon, 16 Nov 2015 05:58:47 -0500
> + } else {
> + if (atomic_read(&mbx->rsp_status) != rsp_status)
> + qlcnic_83xx_notify_mbx_response(mbx);
Here we go with more of some "We don't understand what atomic_t's
actually do"...
atomic_re
From: "Jason A. Donenfeld"
Date: Mon, 16 Nov 2015 20:52:28 +0100
> This works fine with, say, iperf3 in TCP mode. The AVX performance
> is great. However, when using iperf3 in UDP mode, irq_fpu_usable()
> is mostly false! I added a dump_stack() call to see why, except
> nothing looks strange; the
On (11/16/15 21:14), Jason A. Donenfeld wrote:
>
> But what about in devices for which self-routing might actually be
> useful? For example, let's say that if an incoming skb is headed for
> dst X, it gets encapsulated and sent to dst A, and for dst Y it gets
> encapsulated and sent to dst B, and
From: Hannes Frederic Sowa
Date: Mon, 16 Nov 2015 12:05:03 +0100
> By declaring the huge stack allocations as static. We can do so
> because we hold rtnl.
Look across the tree, this is an idiom copied all over the place.
If putting a rtnl_link_stats64 object on the stack is truly a
problem, we h
From: Hannes Frederic Sowa
Date: Mon, 16 Nov 2015 16:25:56 +0100
> In case multiple writes to a unix stream socket race we could end up in a
> situation where we pre-allocate a new skb for use in unix_stream_sendpage
> but have to free it again in the locked section because another skb
> has been
When we have multiple stacked vlan devices all of which have
turned off REORDER_HEADER flag, the untag operation does not
locate the ethernet addresses correctly for nested vlans.
The reason is that in case of REORDER_HEADER flag being off,
the outer vlan headers are put back and the mac_len is adj
A while ago Phil Sutter brought up an issue with vlans without
REORDER_HEADER and bridges. The problem was that if a vlan
without REORDER_HEADER was a port in the bridge, the bridge ended
up forwarding corrupted packets that still contained the vlan header.
The same issue exists for bridge mode ma
When a vlan is configured with REORDER_HEADER set to 0, the vlan
header is put back into the packet and makes it appear that
the vlan header is still there even after it's been processed.
This posses a problem for bridge and macvlan ports. The packets
passed to those device may be forwarded and at
From: Mans Rullgard
Date: Mon, 16 Nov 2015 18:23:35 +
> +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi)
"i" is passed in as a signed int here, but:
> +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len)
...
> + err = nb8800_alloc_r
Hi Sowmini,
Neat. Though, in my case, I'm not actually just prepending a header.
I'm doing some more substantial transformations of a packet. And this
needs to work with v4 too. So I'm not sure implementing a v6 spec will
help with things. I need to identify the right mechanism inside the
kernel t
Hi David,
On Mon, Nov 16, 2015 at 9:32 PM, David Miller wrote:
> Network device driver transmit executes with software interrupts
> disabled.
>
> Therefore on x86, you cannot use the FPU.
That is extremely problematic for me. Is there a way to make this not
so? A driver flag that would allow thi
1 - 100 of 148 matches
Mail list logo
