Re: [PATCH v2 net-next 2/2] ravb: add device tree support for r8a779[123]

2015-12-02 Thread Rob Herring
On Wed, Dec 02, 2015 at 02:58:33PM +0900, Simon Horman wrote: > Simply document new compatibility strings. > As a previous patch adds a generic R-Car Gen2 compatibility string > there appears to be no need for a driver updates. > > Signed-off-by: Simon Horman Acked-by: Rob Herring > > --- > v

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-12-02 Thread Lorenzo Colitti
On Tue, Dec 1, 2015 at 11:53 AM, Tom Herbert wrote: > This is awesome! The only thing I would suggest is to make > sock_destroy a proto_op so that it can be called from within the > kernel. This should be preferred to externally calling tcp_done > (hopefully we can unexport that symbol then). I'm

Re: [patch net-next 00/26] bonding/team offload + mlxsw implementation

2015-12-02 Thread Andrew Lunn
> Another question relates to users bonding/teaming netdevice ports from > different HW switches We need to be precises here. DSA allows for a cluster of switches which are interconnected via switch ports. In this setup, the Marvell switches allows ports of different switches to be members of a t

Re: [patch net-next 24/26] mlxsw: spectrum: Implement LAG port join/leave

2015-12-02 Thread Jiri Pirko
Wed, Dec 02, 2015 at 03:26:27PM CET, go...@cumulusnetworks.com wrote: >On Wed, Dec 02, 2015 at 03:10:22PM +0100, Jiri Pirko wrote: >> Wed, Dec 02, 2015 at 03:01:32PM CET, go...@cumulusnetworks.com wrote: >> >On Tue, Dec 01, 2015 at 02:49:02PM +0100, Jiri Pirko wrote: >> >> From: Jiri Pirko >> >>

Re: [PATCH] xprtrdma: add missing curly braces, set rc to zero on non-zero

2015-12-02 Thread Anna Schumaker
On 11/24/2015 06:11 PM, Colin King wrote: > From: Colin Ian King > > Add the missing curly braces so that rc is only set to zero when > it is non-zero. Without this minor fix, rc is set to zero even > when it is zero, which is slightly redundant. > > Detected with smatch static analysis. Thank

[PATCH net] pppox: use standard module auto-loading feature

2015-12-02 Thread Guillaume Nault
* Register PF_PPPOX with pppox module rather than with pppoe, so that pppoe doesn't get loaded for any PF_PPPOX socket. * Register PX_PROTO_* with standard MODULE_ALIAS_NET_PF_PROTO() instead of using pppox's own naming scheme. * While there, add auto-loading feature for pptp. Sign

Re: [PATCH net] openvswitch: fix hangup on vxlan/gre/geneve device deletion

2015-12-02 Thread Flavio Leitner
On Tue, Dec 01, 2015 at 06:33:36PM +0100, Paolo Abeni wrote: > Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference > to the underlying tunnel device, but never released it when such > device is deleted. > Deleting the underlying device via the ip tool cause the kernel to > hangup in

Re: [PATCH net] pppox: use standard module auto-loading feature

2015-12-02 Thread Guillaume Nault
On Wed, Dec 02, 2015 at 04:27:39PM +0100, Guillaume Nault wrote: > * Register PF_PPPOX with pppox module rather than with pppoe, > so that pppoe doesn't get loaded for any PF_PPPOX socket. > > * Register PX_PROTO_* with standard MODULE_ALIAS_NET_PF_PROTO() > instead of using pppox's ow

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-12-02 Thread Tom Herbert
On Wed, Dec 2, 2015 at 7:18 AM, Lorenzo Colitti wrote: > On Tue, Dec 1, 2015 at 11:53 AM, Tom Herbert wrote: >> This is awesome! The only thing I would suggest is to make >> sock_destroy a proto_op so that it can be called from within the >> kernel. This should be preferred to externally calling

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

2015-12-02 Thread Gregory CLEMENT
Hi, On mer., déc. 02 2015, Gregory CLEMENT wrote: >> >> So far the issue may have been not noticed, because in every IO driver >> using mvebu_mbus_dram_info for configuring MBUS windows, there's >> following substraction: >> (cs->size - 1) & 0xf000 >> >> I think there are two options: >>

Re: [net-next 13/15] ixgbe: Handle extended IPv6 headers in tx path

2015-12-02 Thread Alexander Duyck
On 12/02/2015 04:31 AM, Jeff Kirsher wrote: From: Mark Rustad Check for and handle IPv6 extended headers so that Tx checksum offload can be done. Thanks to Tom Herbert for noticing this problem. Note that the goto back to process the final protocol value can never result in a loop, because it c

[PATCH 1/4] net: bfin_mac: Use platform_register/unregister_drivers()

2015-12-02 Thread Thierry Reding
From: Thierry Reding These new helpers simplify implementing multi-driver modules and properly handle failure to register one driver by unregistering all previously registered drivers. Signed-off-by: Thierry Reding --- Applies on top of next-20151127. drivers/net/ethernet/adi/bfin_mac.c | 14

[PATCH 4/4] net: mv643xx: Use platform_register/unregister_drivers()

2015-12-02 Thread Thierry Reding
From: Thierry Reding These new helpers simplify implementing multi-driver modules and properly handle failure to register one driver by unregistering all previously registered drivers. Signed-off-by: Thierry Reding --- Applies on top of next-20151127. drivers/net/ethernet/marvell/mv643xx_eth.

[PATCH 3/4] net: mpc52xx: Use platform_register/unregister_drivers()

2015-12-02 Thread Thierry Reding
From: Thierry Reding These new helpers simplify implementing multi-driver modules and properly handle failure to register one driver by unregistering all previously registered drivers. Signed-off-by: Thierry Reding --- Applies on top of next-20151127. drivers/net/ethernet/freescale/fec_mpc52x

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-12-02 Thread Lorenzo Colitti
On Thu, Dec 3, 2015 at 1:12 AM, Tom Herbert wrote: > The in kernel caller would already have a pointer to the socket so the > call would just be sk->sk_prot->destroy(sk). That call should make its > way down to same backend function in TCP that the diag path would use. > We need this in the kernel

[PATCH 2/4] net: bcm63xx: Use platform_register/unregister_drivers()

2015-12-02 Thread Thierry Reding
From: Thierry Reding These new helpers simplify implementing multi-driver modules and properly handle failure to register one driver by unregistering all previously registered drivers. Signed-off-by: Thierry Reding --- Applies on top of next-20151127. drivers/net/ethernet/broadcom/bcm63xx_ene

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-12-02 Thread Hannes Frederic Sowa
On Wed, Dec 2, 2015, at 04:50, Tom Herbert wrote: > On Tue, Dec 1, 2015 at 7:49 AM, Hannes Frederic Sowa > wrote: > > On Tue, Dec 1, 2015, at 16:44, John W. Linville wrote: > >> On Mon, Nov 30, 2015 at 09:26:51PM -0800, Tom Herbert wrote: > >> > On Mon, Nov 30, 2015 at 5:28 PM, Jesse Gross wrote:

Re: [PATCH 3/6] net: thunderx: Increase transmit queue length

2015-12-02 Thread Sunil Kovvuri
> > If the performance increase is 4 %, then surely using twice more memory > is not worth it. I haven't mentioned anywhere that i am seeing 4% increase in performance. Anyways as said already i will recheck and resubmit. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the b

[PATCH V6 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-12-02 Thread Salil Mehta
This patchset adds support of Hisilicon Hip06 SoC to the existing HNS ethernet driver. The changes in the driver are mainly due to changes in the DMA descriptor provided by the Hip06 ethernet hardware. These changes need to co-exist with already present Hip05 DMA descriptor and its operating funct

[PATCH V6 net-next 5/5] net:hns: Add the init code to disable Hip06 "Hardware VLAN assist"

2015-12-02 Thread Salil Mehta
This patch adds the initializzation code to disable the hardware vlan support for VLAN Tag stripping by default for now. Proper support of "hardware VLAN assitance" feature would soon come in the next coming patches. Signed-off-by: Salil Mehta --- PATCH V6: - No change over the earlier patch P

[PATCH V6 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver

2015-12-02 Thread Salil Mehta
This patch adds the support of "RSS (Receive Side Scaling)" feature provided by the Hip06 ethernet hardware to the HNS ethernet driver. This feature helps in distributing the different flows (mapped as hash by hardware using Toeplitz Hash) to different Queues asssociated with the processor cores.

[PATCH V6 net-next 0/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-12-02 Thread Salil Mehta
This PATCH V6 addresses the review comments provided by David Miller over the existing use of ENABLE/DISABLE hash defines with the code. These hash defines are doing a similar job as implicit type bool would do. So these are kind of duplicate and are redundant. PATCH V5: This PATCH addresses the r

[PATCH V6 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support HNS Driver

2015-12-02 Thread Salil Mehta
This patch adds the support of "TSO (TCP Segment Offload)" feature provided by the Hip06 ethernet hardware to the HNS ethernet driver. Enabling this feature would help offload the TCP Segmentation process to the Hip06 ethernet hardware. This eventually would help in saving precious cpu cycles. Si

[PATCH V6 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS

2015-12-02 Thread Salil Mehta
From: Salil This patch adds the support of ethtool TSO option to support Hip06 SoC to HNS Signed-off-by: Salil Mehta Signed-off-by: lisheng --- PATCH V6/V5: - No change over the previous patch PATCH V4: This fixes the comments given by Sergei Shtylyov over the PATCH V3: Link: https://lkml.o

Re: [PATCH 3/6] net: thunderx: Increase transmit queue length

2015-12-02 Thread Eric Dumazet
On Wed, 2015-12-02 at 22:20 +0530, Sunil Kovvuri wrote: > > > > If the performance increase is 4 %, then surely using twice more memory > > is not worth it. > I haven't mentioned anywhere that i am seeing 4% increase in performance. Yes, this is the complain I made : No numbers, just a patch incr

[no subject]

2015-12-02 Thread Smith, Wayne L
This's Sgt Monica, I ve a proposal for you; contact email: sgt.monica...@outlook.com-- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-12-02 Thread Salil Mehta
On 11/30/2015 7:50 PM, David Miller wrote: From: Salil Mehta Date: Thu, 26 Nov 2015 07:14:06 + -#define ENABLE (0x1) -#define DISABLE(0x0) +#define ENABLE 0x1 +#define DISABLE0x0 Defining such common macros names for such incredibly simple

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-12-02 Thread Tom Herbert
On Wed, Dec 2, 2015 at 8:30 AM, Lorenzo Colitti wrote: > On Thu, Dec 3, 2015 at 1:12 AM, Tom Herbert wrote: >> The in kernel caller would already have a pointer to the socket so the >> call would just be sk->sk_prot->destroy(sk). That call should make its >> way down to same backend function in T

Re: Kernel 4.1.12 crash

2015-12-02 Thread Guillaume Nault
On Mon, Nov 30, 2015 at 09:42:08PM +0100, Guillaume Nault wrote: > On Mon, Nov 30, 2015 at 04:03:37PM +0100, Guillaume Nault wrote: > > Yes, it most likely was introduced by 287f3a943fef ("pppoe: Use > > workqueue to die properly when a PADT is received"). I still have to > > figure out why. > > I

Re: Increasing skb->mark size

2015-12-02 Thread David Miller
From: David Ahern Date: Tue, 1 Dec 2015 21:42:45 -0800 > On 12/1/15 6:58 PM, Andi Kleen wrote: - skb_iff is either skb->dev->iff or 0. so it could be replaced with a single bit flag for the 0 case. >>> >>> ... and that one wouldn't work on ingress. >> >> Please explain. > > skb->dev is

Re: [patch net-next 07/26] net: add possibility to pass information about upper device via notifier

2015-12-02 Thread Jiri Pirko
Wed, Dec 02, 2015 at 09:17:35AM CET, gerlitz...@gmail.com wrote: >On Wed, Dec 2, 2015 at 9:54 AM, Jiri Pirko wrote: >> Wed, Dec 02, 2015 at 06:28:35AM CET, gerlitz...@gmail.com wrote: >>>On Tue, Dec 1, 2015 at 3:48 PM, Jiri Pirko wrote: From: Jiri Pirko Sometimes the drivers and o

Re: [PATCH 3/6] net: thunderx: Increase transmit queue length

2015-12-02 Thread David Miller
From: Sunil Kovvuri Date: Wed, 2 Dec 2015 11:18:43 +0530 >>The driver should successfully recover from out of memory situations >> and not stop RX/TX completely. > This memory allocation is while interface bringup/initialization and not > during > packet I/O. > >>Don't put this off as not "rela

Re: [patch net-next 24/26] mlxsw: spectrum: Implement LAG port join/leave

2015-12-02 Thread David Miller
From: Or Gerlitz Date: Wed, 2 Dec 2015 07:47:51 +0200 > On Tue, Dec 1, 2015 at 3:49 PM, Jiri Pirko wrote: >> Implement basic procedures for joining/leaving port to/from LAG. That >> includes HW setup of collector, core LAG mapping setup. >> >> Signed-off-by: Jiri Pirko >> --- >> drivers/net/et

Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2015-12-02 Thread David Miller
From: David Decotigny Date: Tue, 1 Dec 2015 22:00:58 -0800 > There is a set of conversion routines ulong[]<->u32[] to address this > 32/64-bit compat issue. And it's extremely ugly. There is nothing stopping you from adding bitmap_set32() et al. helpers to facilitate things. -- To unsubscribe f

Re: [patch net-next 24/26] mlxsw: spectrum: Implement LAG port join/leave

2015-12-02 Thread Jiri Pirko
Wed, Dec 02, 2015 at 06:30:07PM CET, da...@davemloft.net wrote: >From: Or Gerlitz >Date: Wed, 2 Dec 2015 07:47:51 +0200 > >> On Tue, Dec 1, 2015 at 3:49 PM, Jiri Pirko wrote: >>> Implement basic procedures for joining/leaving port to/from LAG. That >>> includes HW setup of collector, core LAG map

[PATCH 0/2] mvneta: implement ethtool autonegotiation control

2015-12-02 Thread Stas Sergeev
These 2 patches add an ability to control the autonegotiation via ethtool. For example: ethtool -s eth0 autoneg off ethtool -s eth0 autoneg on This is needed if you want to connect the mvneta's MII to different switches or PHYs: the ones the do support the in-band status, and the ones that do not

[PATCH 1/2] mvneta: consolidate autoneg enabling

2015-12-02 Thread Stas Sergeev
This moves autoneg-related bit manipulations to the single place. CC: Thomas Petazzoni CC: netdev@vger.kernel.org CC: linux-ker...@vger.kernel.org Signed-off-by: Stas Sergeev --- drivers/net/ethernet/marvell/mvneta.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) dif

[PATCH 3.19.y-ckt 069/164] can: Use correct type in sizeof() in nla_put()

2015-12-02 Thread Kamal Mostafa
3.19.8-ckt11 -stable review patch. If anyone has any objections, please let me know. -- From: Marek Vasut commit 562b103a21974c2f9cd67514d110f918bb3e1796 upstream. The sizeof() is invoked on an incorrect variable, likely due to some copy-paste error, and this might result in

[PATCH 2/2] mvneta: implement ethtool autonegotiation control

2015-12-02 Thread Stas Sergeev
This patch allows to do ethtool -s eth0 autoneg off ethtool -s eth0 autoneg on to disable or enable autonegotiation at run-time. Without that functionality, the only way to control the autonegotiation is to modify the device tree. This is needed if you plan to use the same kernel with different e

Re: Asterisk deadlocks since Kernel 4.1

2015-12-02 Thread Philipp Hahn
Hi, Am 02.12.2015 um 10:45 schrieb Stefan Priebe - Profihost AG: > here are the results. > > It works with 4.1. > It works with 4.2. > It does not work with 4.1.13. the patches were first commitet in v4.3-rc3 and appear as backports only since v4.2.3 and v4.1.10 > git bisect tells me it stopped

Re: Asterisk deadlocks since Kernel 4.1

2015-12-02 Thread Philipp Hahn
Hi, Am 02.12.2015 um 12:40 schrieb Hannes Frederic Sowa: > Cool, thanks a lot. Does this patch make a difference? > > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c > index 59651af..278e94c 100644 > --- a/net/netlink/af_netlink.c > +++ b/net/netlink/af_netlink.c > @@ -1137,7 +11

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-12-02 Thread Joe Stringer
On 29 November 2015 at 05:06, Haggai Eran wrote: > On 14/11/2015 08:45, Joe Stringer wrote: >> On 13 November 2015 at 06:46, Or Gerlitz wrote: >>> > On Fri, Nov 13, 2015 at 10:14 AM, Joe Stringer >>> > wrote: >>> > >> I don't follow the logic. You observed one flow which matched on >>

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-12-02 Thread Joe Stringer
On 29 November 2015 at 05:37, Or Gerlitz wrote: > On Thu, Nov 19, 2015 at 5:40 PM, Or Gerlitz wrote: >> On Sat, Nov 14, 2015 at 8:45 AM, Joe Stringer wrote: >>> On 13 November 2015 at 06:46, Or Gerlitz wrote: On Fri, Nov 13, 2015 at 10:14 AM, Joe Stringer wrote: >> > I agree tha

Re: [RFC PATCH] af_unix: fix entry locking in unix_dgram_recvmsg

2015-12-02 Thread David Miller
From: Rainer Weikusat Date: Tue, 01 Dec 2015 17:02:33 + > Rainer Weikusat writes: > > [...] > >> Insofar I understand the comment in this code block correctly, >> >> err = mutex_lock_interruptible(&u->readlock); >> if (unlikely(err)) { >> /* recvmsg() in non

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-12-02 Thread Jesse Gross
On Wed, Dec 2, 2015 at 9:52 AM, Joe Stringer wrote: > On 29 November 2015 at 05:06, Haggai Eran wrote: >> On 14/11/2015 08:45, Joe Stringer wrote: >>> On 13 November 2015 at 06:46, Or Gerlitz wrote: > On Fri, Nov 13, 2015 at 10:14 AM, Joe Stringer > wrote: > > >> I don't fol

[PATCH net-next 2/3] vxlan: move IPv6 outpute route calculation to a function

2015-12-02 Thread Jiri Benc
Will be used also for ndo_fill_metadata_dst. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 45 +++-- 1 file changed, 35 insertions(+), 10 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 085d0c5b82b7..2945cf7f9c73 100644 ---

[PATCH net-next 3/3] vxlan: support ndo_fill_metadata_dst also for IPv6

2015-12-02 Thread Jiri Benc
Fill the metadata correctly even when tunneling over IPv6. Also, check that the provided metadata is of an address family that is supported by the tunnel. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 50 +- 1 file changed, 29 insertions(+), 2

[PATCH net-next 0/3] vxlan: IPv6 fill_metadata_dst support

2015-12-02 Thread Jiri Benc
This adds IPv6 support to ndo_fill_metadata_dst in vxlan together with restructuring to avoid duplicate code. Jiri Benc (3): vxlan: consolidate output route calculation vxlan: move IPv6 outpute route calculation to a function vxlan: support ndo_fill_metadata_dst also for IPv6 drivers/net/v

[PATCH net-next 1/3] vxlan: consolidate output route calculation

2015-12-02 Thread Jiri Benc
The code for output route lookup is duplicated for ndo_start_xmit and ndo_fill_metadata_dst. Move it to a common function. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 49 + 1 file changed, 29 insertions(+), 20 deletions(-) diff --git a/driv

Re: Asterisk deadlocks since Kernel 4.1

2015-12-02 Thread Hannes Frederic Sowa
Hello, On Wed, Dec 2, 2015, at 18:15, Philipp Hahn wrote: > Hi, > > Am 02.12.2015 um 10:45 schrieb Stefan Priebe - Profihost AG: > > here are the results. > > > > It works with 4.1. > > It works with 4.2. > > It does not work with 4.1.13. > > the patches were first commitet in v4.3-rc3 and appe

Re: [PATCH net-next v7] mpls: support for dead routes

2015-12-02 Thread Robert Shearman
On 02/12/15 06:18, Roopa Prabhu wrote: From: Roopa Prabhu Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is curre

Re: [PATCH net-next 3/3] vxlan: support ndo_fill_metadata_dst also for IPv6

2015-12-02 Thread kbuild test robot
Hi Jiri, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jiri-Benc/vxlan-IPv6-fill_metadata_dst-support/20151203-021449 config: x86_64-randconfig-i0-201548 (attached as .config) reproduce: # save the attached .config to linux build tree

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-12-02 Thread Tom Herbert
On Wed, Dec 2, 2015 at 8:35 AM, Hannes Frederic Sowa wrote: > On Wed, Dec 2, 2015, at 04:50, Tom Herbert wrote: >> On Tue, Dec 1, 2015 at 7:49 AM, Hannes Frederic Sowa >> wrote: >> > On Tue, Dec 1, 2015, at 16:44, John W. Linville wrote: >> >> On Mon, Nov 30, 2015 at 09:26:51PM -0800, Tom Herbert

Re: [PATCH V6 net-next 5/5] net:hns: Add the init code to disable Hip06 "Hardware VLAN assist"

2015-12-02 Thread Sergei Shtylyov
Hello. On 12/02/2015 07:52 PM, Salil Mehta wrote: This patch adds the initializzation code to disable the hardware vlan support for VLAN Tag stripping by default for now. Proper support of "hardware VLAN assitance" feature would soon come in the next coming patches. Signed-off-by: Salil Mehta

[patch net-next v2 16/28] team: implement lower state change propagation

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Let netdev notifier listeners know about link-up and port-enable state changes. Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c ind

[patch net-next v2 04/28] net: add netif_is_team_master helper

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Similar to other helpers, caller can use this to find out if device is team master. Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 1 + include/linux/netdevice.h | 8 2 files changed, 9 insertions(+) diff --git a/drivers/net/team/team.c b/drivers/net/team/

[patch net-next v2 09/28] net: add possibility to pass information about upper device via notifier

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Sometimes the drivers and other code would find it handy to know some internal information about upper device being changed. So allow upper-code to pass information down to notifier listeners during linking. Signed-off-by: Jiri Pirko --- v1->v2: - change "is upper info" to "upp

[patch net-next v2 14/28] net: introduce lower state changed info structure for LAG lowers

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko This is shared info structure for bonding and team. Serves to pass down info about link state and port activity to notification listeners. Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/netdevice.h

[patch net-next v2 01/28] net: dev: Check CHANGEUPPER notifier return value

2015-12-02 Thread Jiri Pirko
From: Ido Schimmel switchdev drivers reflect the newly requested topology to hardware when CHANGEUPPER is received, after software links were already formed. However, the operation can fail and user will not be notified, as the return value of the notifier is not checked. Add this check and roll

[patch net-next v2 00/28] bonding/team offload + mlxsw implementation

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko This patchset introduces needed infrastructure for link aggregation offload - for both team and bonding. It also implements the offload in mlxsw driver. Particulary, this patchset introduces possibility for upper driver (bond/team/bridge/..) to pass type-specific info down to no

[patch net-next v2 18/28] bonding: implement lower state change propagation

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Let netdev notifier listeners know about link and slave state change. Signed-off-by: Jiri Pirko --- drivers/net/bonding/bond_main.c | 10 ++ include/net/bonding.h | 7 +++ 2 files changed, 17 insertions(+) diff --git a/drivers/net/bonding/bond_main.c b/

[patch net-next v2 05/28] net: add netif_is_team_port helper

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Similar to other helpers, caller can use this to find out if device is team port. Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index cfb56e0..e7eca8f 10064

[patch net-next v2 12/28] bonding: fill-up LAG changeupper info struct and pass it along

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Initialize netdev_lag_upper_info structure by TX type according to current bonding mode and pass it along via netdev_master_upper_dev_link. Signed-off-by: Jiri Pirko --- v1->v2: -added mode broadcast suggested by Nik --- drivers/net/bonding/bond_main.c | 45 +++

[patch net-next v2 20/28] mlxsw: spectrum: Add set_rx_mode ndo stub

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Add just a stub for now. This allows to pass check in dev_ifsioc, SIOCADDMULTI and SIOCDELMULTI cases. Teamd is using these to add LACP slow MAC. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 5 + 1 file changed, 5 insertions(+) diff --git

[patch net-next v2 08/28] net: propagate upper priv via netdev_master_upper_dev_link

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Eliminate netdev_master_upper_dev_link_private and pass priv directly as a parameter of netdev_master_upper_dev_link. Signed-off-by: Jiri Pirko --- drivers/net/bonding/bond_main.c | 2 +- drivers/net/team/team.c | 2 +- drivers/net/vrf.c | 2 +- includ

[patch net-next v2 06/28] net: add netif_is_lag_master helper

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Some code does not mind if the master is bond or team and treats them the same, as generic LAG. Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index e7eca8f.

[patch net-next v2 22/28] mlxsw: pci: Implement LAG processing for received packets

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Completion queue element for receive queue provides information if the packet was received via LAG port. Extract this info and pass it along to core. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/pci.c | 19 --- drivers/net/ethernet/mellanox

[patch net-next v2 28/28] mlxsw: spectrum: Implement LAG tx enabled lower state change

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Enabling/disabling TX on a LAG port means enabling/disabling distribution in our HW. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 81 +- 1 file changed, 79 insertions(+), 2 deletions(-) diff --git a/drivers/net/etherne

[patch net-next v2 25/28] mlxsw: reg: Add definition of LAG unicast record for SFN register

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko LAG-related records have specific format in SFN register. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h b/drivers/net

[patch net-next v2 21/28] mlxsw: core: Add support for packets received from LAG port

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Lower layer (pci) has information if the packet is received via LAG port. If that is the case, it fills up rx_info accordingly. However upper layer does not care about lag_id/port_index for received packets so convert it to local_port before passing it up. For that conversion, la

[patch net-next v2 26/28] mlxsw: spectrum: Implement LAG port join/leave

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Implement basic procedures for joining/leaving port to/from LAG. That includes HW setup of collector, core LAG mapping setup. Signed-off-by: Jiri Pirko --- v1->v2: - return NOTIFY_BAD in case join/leave fails as requested by Andy - change BUG_ON to WARN_ON as suggested by Or an

[patch net-next v2 24/28] mlxsw: reg: Add definition of LAG unicast record for SFD register

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko LAG-related records have specific format in SFD register. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 79 +++ 1 file changed, 71 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h b/d

[patch net-next v2 23/28] mlxsw: reg: Add link aggregation configuration registers definitions

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Add definitions of SLDR, SLCR2, SLCOR registers that are used to configure LAG. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 293 ++ 1 file changed, 293 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg

[patch net-next v2 13/28] net: introduce change lower state notifier

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko When lower device like bonding slave, team/bridge port, etc changes its state, it is useful for others to notice this change. Currently this is implemented specificly for bonding as NETDEV_BONDING_INFO notifier. This patch aims to replace this specific usage and make this more ge

[patch net-next v2 07/28] net: add netif_is_lag_port helper

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Some code does not mind if a device is bond slave or team port and treats them the same, as generic LAG ports. Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h

[patch net-next v2 02/28] net: Add support for CHANGEUPPER notifier error injection

2015-12-02 Thread Jiri Pirko
From: Ido Schimmel Since CHANGEUPPER can now fail, add support for it in the newly introduced netdev notifier error injection infrastructure. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- v1->v2: -new patch --- Documentation/fault-injection/notifier-error-inject.txt | 1 + lib/net

[patch net-next v2 27/28] mlxsw: spectrum: Implement FDB add/remove/dump for LAG

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Implement FDB offloading for lagged ports, including learning LAG FDB entries, adding/removing static FDB entries and dumping existing LAG FDB entries. Signed-off-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 182 + 1 file changed,

[patch net-next v2 15/28] team: rtnl_lock for options set

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko During options set, there will be needed to hold rtnl_mutex in order to safely call netdev notifiers. Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/tea

[patch net-next v2 03/28] bonding: add 802.3ad support for 100G speeds

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Similar to other speeds, add 100G to bonding 802.3ad code. Signed-off-by: Jiri Pirko --- drivers/net/bonding/bond_3ad.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c index 940e2eb

[patch net-next v2 11/28] team: fill-up LAG changeupper info struct and pass it along

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Initialize netdev_lag_upper_info structure by TX type according to current team mode and pass it along via netdev_master_upper_dev_link. Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 23 --- drivers/net/team/team_mode_activebacku

[patch net-next v2 19/28] bonding: set inactive flags on release

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Be correct and symmetric to enslave and set inactive flags during release. That gives LAG offload drivers - lower state change listeners - possibility to do proper cleanup. Signed-off-by: Jiri Pirko --- drivers/net/bonding/bond_main.c | 2 ++ 1 file changed, 2 insertions(+) d

[patch net-next v2 17/28] bonding: allow notifications for bond_set_slave_link_state

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko Similar to state notifications. We allow caller to indicate if the notification should happen now or later, depending on if he holds rtnl mutex or not. Introduce bond_slave_link_notify function (similar to bond_slave_state_notify) which is later on called with rtnl mutex and goe

[patch net-next v2 10/28] net: add info struct for LAG changeupper

2015-12-02 Thread Jiri Pirko
From: Jiri Pirko This struct will be shared by bonding and team to pass internal information to notifier listeners. Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h i

[PATCH net-next 1/1] tipc: fix node reference count bug

2015-12-02 Thread Jon Maloy
Commit 5405ff6e15f40f2f ("tipc: convert node lock to rwlock") introduced a bug to the node reference counter handling. When a message is successfully sent in the function tipc_node_xmit(), we return directly after releasing the node lock, instead of continuing and decrementing the node reference co

Re: [patch net-next v2 02/28] net: Add support for CHANGEUPPER notifier error injection

2015-12-02 Thread Nikolay Aleksandrov
On 12/02/2015 09:07 PM, Jiri Pirko wrote: > From: Ido Schimmel > > Since CHANGEUPPER can now fail, add support for it in the newly > introduced netdev notifier error injection infrastructure. > > Signed-off-by: Ido Schimmel > Signed-off-by: Jiri Pirko > --- > v1->v2: > -new patch > --- > Docu

Re: [patch net-next v2 01/28] net: dev: Check CHANGEUPPER notifier return value

2015-12-02 Thread Nikolay Aleksandrov
On 12/02/2015 09:07 PM, Jiri Pirko wrote: > From: Ido Schimmel > > switchdev drivers reflect the newly requested topology to hardware when > CHANGEUPPER is received, after software links were already formed. > However, the operation can fail and user will not be notified, as the > return value of

Re: [patch net-next v2 12/28] bonding: fill-up LAG changeupper info struct and pass it along

2015-12-02 Thread Nikolay Aleksandrov
On 12/02/2015 09:07 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Initialize netdev_lag_upper_info structure by TX type according to > current bonding mode and pass it along via netdev_master_upper_dev_link. > > Signed-off-by: Jiri Pirko > --- > v1->v2: > -added mode broadcast suggested by Nik >

Re: [PATCH v4 net 0/6] Marvell Armada XP/370/38X Neta fixes

2015-12-02 Thread David Miller
From: Gregory CLEMENT Date: Wed, 02 Dec 2015 09:16:06 +0100 > Hi David, > > On mer., déc. 02 2015, David Miller wrote: > >> From: Marcin Wojtas >> Date: Mon, 30 Nov 2015 13:27:40 +0100 >> >>> I'm sending v4 with corrected commit log of the last patch, in order >>> to avoid possible conflict

Re: [net-next 00/17][pull request] Intel Wired LAN Driver Updates 2015-12-01

2015-12-02 Thread David Miller
From: Jeff Kirsher Date: Wed, 2 Dec 2015 00:25:18 -0800 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ker

Re: [RESEND PATCH] arm64: bpf: add 'store immediate' instruction

2015-12-02 Thread David Miller
From: Will Deacon Date: Wed, 2 Dec 2015 09:15:18 + > On Tue, Dec 01, 2015 at 02:20:40PM -0800, Shi, Yang wrote: >> On 11/30/2015 2:24 PM, Yang Shi wrote: >> >aarch64 doesn't have native store immediate instruction, such operation >> >has to be implemented by the below instruction sequence: >>

Re: pull-request: mac80211 2015-11-26

2015-12-02 Thread David Miller
From: Johannes Berg Date: Wed, 02 Dec 2015 10:46:50 +0100 >> >> A small set of fixes for 4.4: >>  * remove NL80211_FEATURE_FULL_AP_CLIENT_STATE again, it >>    was broken and needs more work, we'll enable it for 4.5 >>  * fix call_r

Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

2015-12-02 Thread David Miller
From: Joe Perches Date: Wed, 02 Dec 2015 02:12:29 -0800 > On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: >> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: >> > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string >> > building") >> > added defective output when I40E_FLAG_V

Re: [PATCH v2 0/5] net: thunderx: Miscellaneous fixes

2015-12-02 Thread David Miller
I'm not even looking at this patch series while it still causes unresolved bugs. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ipsec impact on performance

2015-12-02 Thread Sowmini Varadhan
On (12/02/15 12:41), David Laight wrote: > You are getting 0.7 Gbps with ass-ccm-a-128, scale the esp-null back to > that and it would use 7/18*71 = 27% of the cpu. > So 69% of the cpu in the a-128 case is probably caused by the > encryption itself. > Even if the rest of the code cost nothing you'd

Re: [PATCH v2 4/5] net: thunderx: Switchon carrier only upon interface link up

2015-12-02 Thread David Miller
From: Pavel Fedin Date: Wed, 02 Dec 2015 14:30:37 +0300 > Hello again! > >> Subject: RE: [PATCH v2 4/5] net: thunderx: Switchon carrier only upon >> interface link up >> >> Just a reminder, we have issue with this one too, which is not addressed >> yet. > > I have examined the problem tho

Re: ipsec impact on performance

2015-12-02 Thread Tom Herbert
On Wed, Dec 2, 2015 at 12:50 PM, Sowmini Varadhan wrote: > On (12/02/15 12:41), David Laight wrote: >> You are getting 0.7 Gbps with ass-ccm-a-128, scale the esp-null back to >> that and it would use 7/18*71 = 27% of the cpu. >> So 69% of the cpu in the a-128 case is probably caused by the >> encr

Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

2015-12-02 Thread Joe Perches
On Wed, 2015-12-02 at 15:48 -0500, David Miller wrote: > From: Joe Perches 02 Dec 2015 02:12:29 -0800 > > On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: > >> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > >> > Noticed-by: Sergei Shtylyov   > >> Don't you mean Reported-by?  I am no

[P.A. Semi] Does the ethernet interface work on your Electra, Chitra, Nemo, and Athena board?

2015-12-02 Thread Christian Zigotzky
Hi Michael, Thanks a lot for your answer. We tested some vanilla mainline 4.3 kernels on an Electra reference board. Additionally we tested some patched 4.3 kernels on our Nemo boards. It would be really fantastic, if you could fix the problem. Cheers, Christian On 02 December 2015 at 09:1

Re: ipsec impact on performance

2015-12-02 Thread Sowmini Varadhan
On (12/02/15 13:07), Tom Herbert wrote: > That's easy enough to add to flow dissector, but is SPI really > intended to be used an L4 entropy value? We would need to consider the yes. To quote https://en.wikipedia.org/wiki/Security_Parameter_Index "This works like port numbers in TCP and UDP connec

Re: ipsec impact on performance

2015-12-02 Thread Tom Herbert
On Wed, Dec 2, 2015 at 1:12 PM, Sowmini Varadhan wrote: > On (12/02/15 13:07), Tom Herbert wrote: >> That's easy enough to add to flow dissector, but is SPI really >> intended to be used an L4 entropy value? We would need to consider the > > yes. To quote https://en.wikipedia.org/wiki/Security_Par

<    1   2   3   >