Hi Guillaume,
can you explain why you moved ppp to rtnetlink device handling?
Benefits, etc.?
Does anything change when using NetworkManager/ModemManager/pppd for
my network setup/handling (here: Ubuntu/precise AMD64)?
Thanks in advance.
Regards,
- Sedat -
P.S.: Coming soon... Not (only) in th
This patch tries to implement an device IOTLB for vhost. This could be
used with for co-operation with userspace(qemu) implementation of
iommu for a secure DMA environment in guest.
The idea is simple. When vhost meets an IOTLB miss, it will request
the assistance of userspace to do the translatio
On Thu, Dec 31, 2015 at 03:08:53PM +0900, Tetsuo Handa wrote:
> Willy Tarreau wrote:
> > On Wed, Dec 30, 2015 at 09:58:42AM +0100, Hannes Frederic Sowa wrote:
> > > The MSG_PEEK code should not be harmful and the patch is good as is. I
> > > first understood from the published private thread, that
Hi, all
Thanks for the reply from Jeff.
V2: Based on feedback from Jeff Kirsher, it is not appropriate to continue
in the function ixgbe_watchdog_link_is_up without link_speed since this will
make some virtual NICs not work well.
V3: Based on feedback from Emil Tantilov, the time span b
From: Zhu Yanjun
According to the suggestions from Rustad, Mark D, to all the slave
interfaces, the link_speed and link_up should be synchronized since
the time span between link_up and link_speed will make some virtual
NICs not work well, such as a bonding driver in 802.3ad mode.
Signed-off-by
2015-12-31 13:42 GMT+09:00 Jeff Kirsher :
> Please send this to intel-wired-...@lists.osuosl.org mailing list, or
> at least CC the list since all Wired Ethernet Intel driver patches are
> handled through that list.
Thanks for the info.
I just sent it.
--
To unsubscribe from this list: send the li
Willy Tarreau wrote:
> On Wed, Dec 30, 2015 at 09:58:42AM +0100, Hannes Frederic Sowa wrote:
> > The MSG_PEEK code should not be harmful and the patch is good as is. I
> > first understood from the published private thread, that it is possible
> > for a program to exceed the rlimit of fds. But th
From: Andrew Lunn
Date: Wed, 30 Dec 2015 16:28:24 +0100
> This patchset add ethtool support for reading statistics from the PHY.
> The Marvell and Micrel Phys are then extended to report receiver
> packet errors and idle errors.
>
> v2:
> Fix linking when phylib is not enabled.
> v3:
> Inlin
> -Original Message-
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Wednesday, December 30, 2015 11:13 PM
> To: Shaohui Xie
> Cc: David Miller; Florian Fainelli; netdev
> Subject: Re: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics
> counters
>
> On Wed, Dec 30, 2015 at 04
On Thu, 2015-12-31 at 13:04 +0800, zyjzyj2...@gmail.com wrote:
> From: Zhu Yanjun
>
> According to the suggestions from Rustad, Mark D, to all the slave
> interfaces, the link_speed and link_up should be synchronized since
> the time span between link_up and link_speed will make some virtual
> N
On 12/31/2015 01:17 PM, Jeff Kirsher wrote:
On Thu, 2015-12-31 at 13:04 +0800, zyjzyj2...@gmail.com wrote:
Thanks for the suggestions from Rustad, Mark D.
According to his suggestions, the logs and source code are
simplified.
I find it funny that this email (no patch) is got the correct subject
On Thu, 2015-12-31 at 13:04 +0800, zyjzyj2...@gmail.com wrote:
> Thanks for the suggestions from Rustad, Mark D.
> According to his suggestions, the logs and source code are
> simplified.
I find it funny that this email (no patch) is got the correct subject,
yet the updated patch you sent does not
From: Zhu Yanjun
According to the suggestions from Rustad, Mark D, to all the slave
interfaces, the link_speed and link_up should be synchronized since
the time span between link_up and link_speed will make some virtual
NICs not work well, such as a bonding driver in 802.3ad mode.
Signed-off-by
Hi, all
Thanks for the suggestions from Rustad, Mark D.
According to his suggestions, the logs and source code are simplified.
Zhu Yanjun
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger
On Wed, Dec 30, 2015 at 4:09 AM, Takuma Ueba wrote:
> I210 device IPv6 autoconf test sometimes fails,
> because DAD NS for link-local is not transmitted.
> This packet is silently dropped.
> This problem is seen only GbE environment.
>
> igb_watchdog_task link up detection continues to the followi
On 12/29/2015 11:16 PM, Alexei Starovoitov wrote:
> On Tue, Dec 29, 2015 at 10:44:31PM -0500, Doug Ledford wrote:
>> On 12/29/2015 10:43 PM, Alexei Starovoitov wrote:
>>> On Mon, Dec 28, 2015 at 08:26:44PM -0500, Doug Ledford wrote:
On 12/28/2015 05:20 PM, Daniel Borkmann wrote:
> On 12/28
On Wed, Dec 30, 2015 at 08:51:12AM -0500, Eric Dumazet wrote:
> From: Eric Dumazet
>
> Backport of this upstream commit into stable kernels :
> 89c22d8c3b27 ("net: Fix skb csum races when peeking")
> exposed a bug in udp stack vs MSG_PEEK support, when user provides
> a buffer smaller than skb pa
On Wed, Dec 30, 2015 at 6:30 AM, Jacob Siverskog
wrote:
> On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet wrote:
>> How often can you trigger this bug ?
>
> Ok. I don't have a good repro to trigger it unfortunately, I've seen it just a
> few times when bringing up/down network interfaces. Does the
Em 30-12-2015 19:57, Eric Dumazet escreveu:
On Wed, 2015-12-30 at 15:44 -0500, David Miller wrote:
It is more fun than waiting longer for the more limited uses of it to
trigger problems.
I cannot be convinced that using it in more places in order to find
and fix more bugs is a bad thing.
I'm
From: Xin Long
Date: Tue, 29 Dec 2015 17:49:25 +0800
> In sctp_close, sctp_make_abort_user may return NULL because of memory
> allocation failure. If this happens, it will bypass any state change
> and never free the assoc. The assoc has no chance to be freed and it
> will be kept in memory with
On Wed, 2015-12-30 at 15:44 -0500, David Miller wrote:
> It is more fun than waiting longer for the more limited uses of it to
> trigger problems.
>
> I cannot be convinced that using it in more places in order to find
> and fix more bugs is a bad thing.
>
> I'm sorry if a lot of bug fixes in a
From: Kalle Valo
Date: Mon, 28 Dec 2015 13:47:43 +0200
> here's one more pull request, a bit late due to holidays but I hope this
> still makes it to 4.4. Just two small fixes to iwlwifi, nothing else.
Pulled, thanks Kalle.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
From: Nicolai Stange
Date: Tue, 29 Dec 2015 13:29:55 +0100
> Fixes: ceb5d58b2170 ("net: fix sock_wake_async() rcu protection")
>
> Commit ceb5d58b2170 ("net: fix sock_wake_async() rcu protection") from
> the current 4.4 release cycle introduced a new flags member in
> struct socket_wq and moved
From: Jeff Kirsher
Date: Tue, 29 Dec 2015 19:23:21 -0800
> This series contains updates to ixgbe and ixgbevf.
Pulled, happy holidays Jeff.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vge
From: Sathya Perla
Date: Wed, 30 Dec 2015 01:28:55 -0500
> The following patch set contains some feature additions, code
> re-organization and cleanup and a few non-critical fixes. Pls
> consider applying this to the net-next tree. Thanks.
Series applied, thanks.
--
To unsubscribe from this list
Hello,
The following program leads to leak of multiple objects allocated in
sctp_datamsg_from_user:
// autogenerated by syzkaller (http://github.com/google/syzkaller)
#include
#include
#include
#include
#include
long r[50];
int main()
{
memset(r, -1, sizeof(r));
r[0] = sys
Hello,
The following program leads to a leak of struct lapb_cb:
// autogenerated by syzkaller (http://github.com/google/syzkaller)
#include
#include
#include
#include
int main()
{
syscall(SYS_mmap, 0x2000ul, 0x1ul, 0x3ul, 0x32ul,
0xul, 0x0ul);
int fd =
On Wed, Dec 30, 2015 at 09:42:27PM +0100, Dmitry Vyukov wrote:
> Hello,
>
> The following program leads to a leak of two sock objects:
Damn, Dmitry ;-)
If no one takes care of it by then, I'll look into it next week, thanks.
Marcelo
--
To unsubscribe from this list: send the line "unsubscribe
From: Eric Dumazet
Date: Wed, 30 Dec 2015 14:11:20 -0500
> Let see how funny it will be then.
It is more fun than waiting longer for the more limited uses of it to
trigger problems.
I cannot be convinced that using it in more places in order to find
and fix more bugs is a bad thing.
I'm sorry
Hello,
The following program leads to a leak of two sock objects:
// autogenerated by syzkaller (http://github.com/google/syzkaller)
#include
#include
#include
#include
#include
int fd;
void *thr(void *arg)
{
memcpy((void*)0x2000bbbe,
"\x0a\x00\x33\xdc\x14\x4d\x5b\xd1\x00\x00\x00\x
On 15-12-30 12:26 PM, Jesper Dangaard Brouer wrote:
> On Wed, 30 Dec 2015 09:52:49 -0800
> John Fastabend wrote:
>
>> The net sched infrastructure has a gso ptr that points to skb structs
>> that have failed to be enqueued by the device driver.
>
> What about fixing up the naming "gso" to someth
From: Eric Dumazet
Date: Wed, 30 Dec 2015 14:03:43 -0500
> You sure can disagree with me, but calling my opinion 'incredily
> stupid' is not wise.
I think fundamentally giving facilities less rather than more coverage
is not a smart approach at all.
If the code is that bad that people are disco
On Fri, 25 Dec 2015 11:12:15 +0800
Hangbin Liu wrote:
> Signed-off-by: Hangbin Liu
Both applied, thank you
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.ht
On Tue, 22 Dec 2015 17:31:34 +0900
Lorenzo Colitti wrote:
>
> +static int kill_inet_sock(const struct sockaddr_nl *addr,
> + struct nlmsghdr *h, void *arg)
> +{
> + struct inet_diag_msg *d = NLMSG_DATA(h);
> + struct inet_diag_arg *diag_arg = arg;
> + struct rtnl_handle
On Mon, 28 Dec 2015 18:47:51 -0500
Nathaniel W Filardo wrote:
> Hallo netdev@,
>
> I had occasion to want to programmatically wait for an interface to become
> available from within a shell script, but found there to be no off-the-shelf
> tool for such a thing. Could this patch be considered fo
On Wed, 30 Dec 2015 09:52:49 -0800
John Fastabend wrote:
> The net sched infrastructure has a gso ptr that points to skb structs
> that have failed to be enqueued by the device driver.
What about fixing up the naming "gso" to something else like "requeue",
in the process (or by an pre-patch) ?
On Wed, Dec 30, 2015 at 10:30 AM, Souptick Joarder wrote:
> On Wed, Dec 30, 2015 at 10:35 PM, Bjorn Andersson wrote:
>> On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder
>> wrote:
>>>
>>> HI Bjorn,
>>>
>>> On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson wrote:
>>> > Make the addr parameter co
On Wed, 2015-12-30 at 15:32 -0200, Marcelo Ricardo Leitner wrote:
> On Wed, Dec 30, 2015 at 12:19:39PM -0500, Eric Dumazet wrote:
> > On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote:
> >
> > > besides, this patchset will use transport hashtable to replace
> > > association hashtable to lookup wi
On Wed, 2015-12-30 at 12:50 -0500, David Miller wrote:
> From: Eric Dumazet
> Date: Wed, 30 Dec 2015 11:55:25 -0500
>
> > On Wed, 2015-12-30 at 10:11 -0500, Dave Jones wrote:
> >> On Wed, Dec 30, 2015 at 10:38:56AM +0100, Daniel Borkmann wrote:
> >>
> >> > Given that this drop doesn't strictly
zyjzyj2...@gmail.com wrote:
> From: Zhu Yanjun
>
> According to the suggestion from Rustad, Mark D, this behavior perhaps
> is more related to the copper phy. But to make fiber phy more robust,
> to all the interfaces as a slave interface, the link_speed and link_up
> is synchronized.
>
> Signe
On Wed, 2015-12-30 at 12:52 -0500, David Miller wrote:
> From: Eric Dumazet
> Date: Wed, 30 Dec 2015 12:19:39 -0500
>
> > Switching SCTP to rhashtable at this moment is premature, it is
> > still moving fast.
>
> I completely, and totally, disagree.
>
> rhashtable actually _needs_ a strong acti
On 12/30/2015 12:50 PM, David Miller wrote:
> From: Eric Dumazet
> Date: Wed, 30 Dec 2015 11:55:25 -0500
>
>> On Wed, 2015-12-30 at 10:11 -0500, Dave Jones wrote:
>>> On Wed, Dec 30, 2015 at 10:38:56AM +0100, Daniel Borkmann wrote:
>>>
>>> > Given that this drop doesn't strictly need to be cause
On Wed, Dec 30, 2015 at 10:35 PM, Bjorn Andersson wrote:
> On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder
> wrote:
>>
>> HI Bjorn,
>>
>> On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson wrote:
>> > Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save
>> > clients from having to
On 2015-12-30 03:39, ebied...@xmission.com wrote:
Pablo Neira Ayuso writes:
On Mon, Dec 28, 2015 at 09:05:03PM +0100, Sander Eikelenboom wrote:
Hi,
Running a 4.4.0-rc6 kernel i encountered the warning below.
Cc'ing Eric Biederman.
@Sander, could you provide a way to reproduce this?
I am
On 15-12-30 09:55 AM, John Fastabend wrote:
> Now that pfifo_fast is using the alf_queue data structures we can
> dequeue multiple skbs and save some overhead.
>
> This works because the bulk dequeue logic accepts skb lists already.
>
> Signed-off-by: John Fastabend
> ---
oops I didn't mean to
On Thu, 2015-09-24 at 14:09 -0700, David Miller wrote:
> From: Pravin B Shelar
> Date: Tue, 22 Sep 2015 12:57:53 -0700
>
> > VXLAN device can receive skb with checksum partial. But the checksum
> > offset could be in outer header which is pulled on receive. This results
> > in negative checksum o
From: Eric Dumazet
Date: Wed, 30 Dec 2015 09:17:42 -0500
> On Wed, 2015-12-30 at 15:42 +0300, Stas Sergeev wrote:
>> 29.12.2015 18:22, Sowmini Varadhan пишет:
>> > Do you have admin control over the ubuntu router?
>> > If yes, you might want to check the shared_media [#] setting
>> > on that rou
Now that pfifo_fast is using the alf_queue data structures we can
dequeue multiple skbs and save some overhead.
This works because the bulk dequeue logic accepts skb lists already.
Signed-off-by: John Fastabend
---
include/net/sch_generic.h |2 +-
net/sched/sch_generic.c | 30 ++
The sch_mq qdisc creates a sub-qdisc per tx queue which are then
called for independently for enqueue and dequeue operations. However
statistics are aggregated and pushed up to the "master" qdisc.
This patch adds support for any of the sub-qdiscs to be per cpu
statistic qdiscs. To handle this case
Reporting qlen when qlen is per cpu requires aggregating the per
cpu counters. This adds a helper routine for this.
Signed-off-by: John Fastabend
---
include/net/sch_generic.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/include/net/sch_generic.h b/include/net/sch_gener
This converts the pfifo_fast qdisc to use the alf_queue enqueue
and dequeue routines then sets the NOLOCK bit.
This also removes the logic used to pick the next band to dequeue
from and instead just checks each alf_queue for packets from
top priority to lowest. This might need to be a bit more cle
Enable dflt qdisc support for per cpu stats before this patch a
dflt qdisc was required to use the global statistics qstats and
bstats.
Signed-off-by: John Fastabend
---
net/sched/sch_generic.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/net/sc
This is a bit interesting because it means sch_direct_xmit will
return a positive value which causes the dequeue/xmit cycle to
continue only when a specific cpu has a qlen > 0.
However checking each cpu for qlen will break performance so
its important to note that qdiscs that set the no lock bit n
The per cpu qstats support was added with per cpu bstat support
which is currently used by the ingress qdisc. This patch adds
a set of helpers needed to make other qdiscs that use qstats
per cpu as well.
Signed-off-by: John Fastabend
---
include/net/sch_generic.h | 39 +
The net sched infrastructure has a gso ptr that points to skb structs
that have failed to be enqueued by the device driver.
This can happen when multiple cores try to push a skb onto the same
underlying hardware queue resulting in lock contention. This case is
handled by a cpu collision handler ha
The qdisc_reset operation depends on the qdisc lock at the moment
to halt any additions to gso_skb and statistics while the list is
free'd and the stats zeroed.
Without the qdisc lock we can not guarantee another cpu is not in
the process of adding a skb to one of the "cells". Here are the
two cas
From: Eric Dumazet
Date: Wed, 30 Dec 2015 12:19:39 -0500
> Switching SCTP to rhashtable at this moment is premature, it is
> still moving fast.
I completely, and totally, disagree.
rhashtable actually _needs_ a strong active user like one of the
protocol socket hashes.
It's a step backwards to
When a qdisc is using per cpu stats only the bstats are being
freed. This also free's the qstats.
Signed-off-by: John Fastabend
---
net/sched/sch_generic.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index e82a1ad..1
This patch adds a flag for queueing disciplines to indicate
the stack does not need to use the qdisc lock to protect
operations. This can be used to build lockless scheduling
algorithms and improving performance.
The flag is checked in the tx path and the qdisc lock is
only taken if it is not set.
Initial implementation of an array based lock free queue. This works
is originally done by Jesper Dangaard Brouer and I've grabbed it made
only minor tweaks at the moment and plan to use it with the 'tc'
subsystem although it is general enough to be used elsewhere.
Certainly this implementation ca
Hi,
This is a first take at removing the qdisc lock on the xmit path
where qdiscs actually have queues of skbs. The ingress qdisc
which is already lockless was "easy" at least in the sense that
we did not need any lock-free data structures to hold skbs.
The series here is experimental at the mome
From: Eric Dumazet
Date: Wed, 30 Dec 2015 11:57:31 -0500
> I am against using rhashtable in SCTP (or TCP) at this stage, given the
> number of bugs we have with it.
Come on Eric, we've largely dealt with all of these problems. I haven't
seen a serious report in a while.
--
To unsubscribe from t
From: Eric Dumazet
Date: Wed, 30 Dec 2015 11:55:25 -0500
> On Wed, 2015-12-30 at 10:11 -0500, Dave Jones wrote:
>> On Wed, Dec 30, 2015 at 10:38:56AM +0100, Daniel Borkmann wrote:
>>
>> > Given that this drop doesn't strictly need to be caused by filter code,
>> > it would be nice if you could
From: Sathya Perla
Date: Wed, 30 Dec 2015 11:57:18 +0530
> On Wed, Dec 30, 2015 at 2:20 AM, David Miller wrote:
>>
>> Please fix the problems reported by the kbuild test robot, they happened
>> when I tried to build this too.
>
> David, the test robot is complaining that all values of the enum
On Wed, Dec 30, 2015 at 11:50:46PM +0800, Xin Long wrote:
...
> +void sctp_hash_transport(struct sctp_transport *t)
> +{
> + struct sctp_sockaddr_entry *addr;
> + struct sctp_hash_cmp_arg arg;
> +
> + addr = list_entry(t->asoc->base.bind_addr.address_list.next,
> +
Hi,
On 12/30/2015 07:15 PM, Nicholas Krause wrote:
> This fixes error handling in the function iwl_pcie_enqueue_hcmd
> by checking if all calls to the function wl_pcie_txq_build_tfd
> have failed by returning a error code and if so jump to the goto
> label out from the cleaning up of acquired res
On Wed, Dec 30, 2015 at 12:19:39PM -0500, Eric Dumazet wrote:
> On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote:
>
> > besides, this patchset will use transport hashtable to replace
> > association hashtable to lookup with rhashtable api. get transport
> > first then get association by t->asoc.
On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote:
> besides, this patchset will use transport hashtable to replace
> association hashtable to lookup with rhashtable api. get transport
> first then get association by t->asoc. and also it will make tcp
> style work better.
SCTP already has a hash
On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder wrote:
>
> HI Bjorn,
>
> On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson wrote:
> > Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save
> > clients from having to cast away a const qualifier.
> >
> > Signed-off-by: Bjorn Andersson
Hello Kalle Valo,
On 12/30/2015 05:15 PM, Kalle Valo wrote:
Uri Mashiach writes:
Fix the below Oops when trying to modprobe wlcore_spi.
The oops occurs because the wl1271_power_{off,on}()
function doesn't check the power() function pointer.
[ 23.401447] Unable to handle kernel NULL pointer
On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote:
> tranport hashtbale will replace the association hashtable to do the
> lookup for transport, and then get association by t->assoc, rhashtable
> apis will be used because of it's resizable, scalable and using rcu.
>
> lport + rport + paddr will be
On Wed, 2015-12-30 at 10:11 -0500, Dave Jones wrote:
> On Wed, Dec 30, 2015 at 10:38:56AM +0100, Daniel Borkmann wrote:
>
> > Given that this drop doesn't strictly need to be caused by filter code,
> > it would be nice if you could pin the location down where the packet gets
> > dropped exactly
HI Bjorn,
On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson wrote:
> Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save
> clients from having to cast away a const qualifier.
>
> Signed-off-by: Bjorn Andersson
> ---
> include/net/mac80211.h | 2 +-
> 1 file changed, 1 insertion(+)
>-Original Message-
>From: zhuyj [mailto:zyjzyj2...@gmail.com]
>Sent: Wednesday, December 30, 2015 12:20 AM
>To: Tantilov, Emil S; Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson,
>Shannon; Wyborny, Carolyn; Skidmore, Donald C; Allan, Bruce W; Ronciak,
>John; Williams, Mitch A; intel-wired-..
Since kzalloc can be failed in memory pressure,
it needs to be handled, otherwise NULL dereference could be happened
Signed-off-by: Insu Yun
---
drivers/net/wireless/mwifiex/sdio.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/net/wireless/mwifiex/sdio.c
b/drivers/net
sctp_endpoint_lookup_assoc is called in the protection of sock lock
there is no need to call local_bh_disable in this function. so remove
them.
Signed-off-by: Xin Long
Signed-off-by: Marcelo Ricardo Leitner
---
net/sctp/endpointola.c | 17 +
1 file changed, 1 insertion(+), 16 de
Traversal the transport rhashtable, get the association only once through
the condition assoc->peer.primary_path != transport.
Signed-off-by: Xin Long
Signed-off-by: Marcelo Ricardo Leitner
---
net/sctp/proc.c | 316 +++-
1 file changed, 173 i
tranport hashtbale will replace the association hashtable to do the
lookup for transport, and then get association by t->assoc, rhashtable
apis will be used because of it's resizable, scalable and using rcu.
lport + rport + paddr will be the base hashkey to locate the chain,
with net to protect on
apply lookup apis to two functions, for __sctp_endpoint_lookup_assoc
and __sctp_lookup_association, it's invoked in the protection of sock
lock, it will be safe, but sctp_lookup_association need to call
rcu_read_lock() and to detect the t->dead to protect it.
Signed-off-by: Xin Long
Signed-off-by
transport hashtable will replace the association hashtable,
so association hashtable is not used in sctp any more, so
drop the codes about that.
Signed-off-by: Xin Long
Signed-off-by: Marcelo Ricardo Leitner
---
include/net/sctp/sctp.h| 21
include/net/sctp/structs.h | 5 -
for telecom center, the usual case is that a server is connected by thousands
of clients. but if the server with only one enpoint(udp style) use the same
sport and dport to communicate with every clients, and every assoc in server
will be hashed in the same chain of global assoc hashtable due to cu
> This is an API consolidation only. Bool initializations should
> use true and false thus bool tests don't need an explicit comparison.
>
> Signed-off-by: Nicholas Mc Guire
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe n
Jacob Siverskog writes:
> On Tue, Dec 29, 2015 at 9:08 PM, David Miller wrote:
>> From: Rainer Weikusat
>> Date: Tue, 29 Dec 2015 19:42:36 +
>>
>>> Jacob Siverskog writes:
This should fix a NULL pointer dereference I encountered (dump
below). Since __skb_unlink is called while wal
> This is an API consolidation only. The use of kmalloc + memset to 0
> is equivalent to kzalloc.
>
> Signed-off-by: Nicholas Mc Guire
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to major
Ethernet PHYs can maintain statistics, for example errors while idle
and receive errors. Add an ethtool mechanism to retrieve these
statistics, using the same model as MAC statistics.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
include/linux/phy.h | 6
include/ua
This patchset add ethtool support for reading statistics from the PHY.
The Marvell and Micrel Phys are then extended to report receiver
packet errors and idle errors.
v2:
Fix linking when phylib is not enabled.
v3:
Inline helpers into ethtool.c, so fixing when phylib is a module.
v4:
Add mis
The PHY counters receiver errors and errors while idle.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
drivers/net/phy/micrel.c | 96
1 file changed, 96 insertions(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
The PHY counters receiver errors and errors while idle.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
drivers/net/phy/marvell.c | 135 ++
1 file changed, 135 insertions(+)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvel
Uri Mashiach writes:
> Fix the below Oops when trying to modprobe wlcore_spi.
> The oops occurs because the wl1271_power_{off,on}()
> function doesn't check the power() function pointer.
>
> [ 23.401447] Unable to handle kernel NULL pointer dereference at
> virtual address
> [ 23.409
On Wed, Dec 30, 2015 at 04:24:40AM +, Shaohui Xie wrote:
> > Subject: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics
> > counters
> > +static int marvell_probe(struct phy_device *phydev) {
> > + struct marvell_priv *priv;
> > +
> > + priv = devm_kzalloc(&phydev->dev, sizeof(*p
On Wed, Dec 30, 2015 at 10:38:56AM +0100, Daniel Borkmann wrote:
> Given that this drop doesn't strictly need to be caused by filter code,
> it would be nice if you could pin the location down where the packet gets
> dropped exactly. Perhaps dropwatch or perf with '-e skb:kfree_skb -a -g
> dhc
On Wed, Dec 30, 2015 at 4:17 AM, Geert Uytterhoeven
wrote:
> Hi David,
>
> On Wed, Dec 30, 2015 at 2:48 AM, David Miller wrote:
>> From: Heiko Stübner
>> Date: Tue, 29 Dec 2015 23:27:55 +0100
>>> Am Dienstag, 29. Dezember 2015, 15:53:14 schrieb David Miller:
You have to submit this series p
On Wed, Dec 30, 2015 at 9:30 AM, Jacob Siverskog
wrote:
> On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet wrote:
>> At this point corruption already happened.
>> We can not possibly detect every possible corruption caused by bugs
>> elsewhere in the kernel and just 'recover' at this point.
>> We m
Andy Shevchenko writes:
> On Tue, Dec 29, 2015 at 10:17 PM, Insu Yun wrote:
>
> Empty commit message?
Yeah, no empty commit log, please.
And then you submit a new version remember to add v2, v3 and so on:
http://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb
On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet wrote:
> On Wed, Dec 30, 2015 at 6:14 AM, Jacob Siverskog
> wrote:
>
>> Ok. Thanks for your feedback. How do you believe the issue could be
>> solved? Investigating it gives:
>>
>> static inline void __skb_unlink(struct sk_buff *skb, struct sk_buff_he
On Wed, 2015-12-30 at 15:42 +0300, Stas Sergeev wrote:
> 29.12.2015 18:22, Sowmini Varadhan пишет:
> > Do you have admin control over the ubuntu router?
> > If yes, you might want to check the shared_media [#] setting
> > on that router for the interfaces with overlapping subnets.
> > (it is on by
On Wed, 2015-12-30 at 12:32 +0100, Nicolai Stange wrote:
> Andy Lutomirski writes:
>
> > On recent v4.4-rc releases, I can't run emacs. No, really, running
> > "emacs" in a GNOME 3 session makes gnome-shell think that emacs is
> > running, but no window is drawn, and the overall system UI is a b
From: Eric Dumazet
Backport of this upstream commit into stable kernels :
89c22d8c3b27 ("net: Fix skb csum races when peeking")
exposed a bug in udp stack vs MSG_PEEK support, when user provides
a buffer smaller than skb payload.
In this case,
skb_copy_and_csum_datagram_iovec(skb, sizeof(str
On Wed, Dec 30, 2015 at 6:14 AM, Jacob Siverskog
wrote:
> Ok. Thanks for your feedback. How do you believe the issue could be
> solved? Investigating it gives:
>
> static inline void __skb_unlink(struct sk_buff *skb, struct sk_buff_head
> *list)
> {
> struct sk_buff *next, *prev;
>
> list->qlen-
> > Another idea would be to add the amount of memory used to manage the fds
> > to sock_rmem/wmem but I don't see any advantages or disadvantages.
>
> Compared to the impact of the pending data in pipes themselves in flight,
> this would remain fairly minimal.
The true size of the memory pinned
1 - 100 of 119 matches
Mail list logo
