RE: [PATCH V6 0/8] introduce Hyper-V VM Socket(hv_sock)

2016-02-13 Thread Dexuan Cui
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf > Of Dexuan Cui > Sent: Tuesday, January 26, 2016 17:40 > ... > Dexuan Cui (8): > Drivers: hv: vmbus: add a helper function to set a channel's pending > send size > Drivers: hv: vmbus: define the new offer type

Re: [PATCH v2 net] bonding: don't use stale speed and duplex information

2016-02-13 Thread Ding Tianhong
On 2016/2/9 4:10, Jay Vosburgh wrote: > > There is presently a race condition between the bonding periodic > link monitor and the updating of a slave's speed and duplex. The former > occurs on a periodic basis, and the latter in response to a driver's > calling of netif_carrier_on. > >

Re: i40e: Kernel unaligned access due to 'struct i40e_dma_mem' being 'packed'

2016-02-13 Thread tndave
On 01/30/2016 04:17 AM, tndave wrote: On 01/27/2016 10:56 PM, David Miller wrote: From: tndave Date: Wed, 27 Jan 2016 17:50:14 -0800 Hi, i40e driver has 'struct i40e_dma_mem' defined with 'packed' directive causing kernel unaligned errors on sparc (when 40e_allocate_dma_mem_d() is being

Re: [RFC][PATCH 00/10] Add trace event support to eBPF

2016-02-13 Thread Alexei Starovoitov
On Fri, Feb 12, 2016 at 10:11:18AM -0600, Tom Zanussi wrote: > Hi, > > As promised in previous threads, this patchset shares some common > functionality with the hist triggers code and enables trace events to > be accessed from eBPF programs. great that you've started working on BPF! > It needs

[PATCH] i40e: remove redundant check on vsi->active_vlans

2016-02-13 Thread Colin King
From: Colin Ian King active_vlans is an unsigned long array, hence a null check on this array is superfluous and can be removed. Detected with static analysis by smatch: drivers/net/ethernet/intel/i40e/i40e_debugfs.c:386 i40e_dbg_dump_vsi_seid() warn: this array is probably non-NULL. 'vsi->

Re: Bonding MAC failover behavior with VLAN interfaces

2016-02-13 Thread John Valko
On 02/12/2016 03:58 PM, Jay Vosburgh wrote: John Valko wrote: Hi all, I have observed the following on CentOS 6 using the 2.6.32-573.8.1.el6.x86_64 kernel as well as Ubuntu 15.10 with 4.2.0-25-generic.. I have not yet tried with a vanilla kernel but with the large time/distro gap it didn't se

Re: [PATCH] net: ipv6: Make address flushing on ifdown optional

2016-02-13 Thread David Ahern
grrr changed the subject in send-email editor which dropped it. obviously this is for net-next On 2/13/16 11:23 PM, David Ahern wrote: Currently, all ipv6 addresses are flushed when the interface is configured down, including global, static addresses: $ ip -6 addr add dev eth1 2000:11

[PATCH] net: ipv6: Make address flushing on ifdown optional

2016-02-13 Thread David Ahern
Currently, all ipv6 addresses are flushed when the interface is configured down, including global, static addresses: $ ip -6 addr add dev eth1 2000:11:1:1::1/64 $ ip addr show dev eth1 3: eth1: mtu 1500 qdisc noop state DOWN group default qlen 1000 link/ether 02:04:11:22:33:0

Re: [PATCH net] bridge: fix regression in ageing time

2016-02-13 Thread Ido Schimmel
Fri, Feb 12, 2016 at 11:31:09PM IST, step...@networkplumber.org wrote: Hi, >This fixes a regression in the bridge ageing time caused by: > >commit c62987bbd8a1 ("bridge: push bridge setting ageing_time down to >switchdev") > >There are users of Linux bridge which use the feature that if ageing t

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V2

2016-02-13 Thread John Holland
Hello, The Intel i211 LOM pcie ethernet controllers' iNVM operates as an OTP and has no externel EEPROM interface [1]. The following allows the driver to pickup the MAC address from a device tree blob when CONFIG_OF has been enabled. [1] http://www.intel.com/content/www/us/en/embedded/produ

Re: [PATCH RFC 1/3] net: bridge: log state when setting it

2016-02-13 Thread Vivien Didelot
Hi Ido, Ido Schimmel writes: > Fri, Feb 12, 2016 at 11:34:18PM IST, vivien.dide...@savoirfairelinux.com > wrote: > > Hi Vivien, > >>Every call to br_set_state is followed by a call to br_log_state. >>Directly call it within br_set_state instead. >> >>Signed-off-by: Vivien Didelot >>--- > > May

Re: [PATCH RFC 2/3] net: bridge: set forwarding state on port removal

2016-02-13 Thread Vivien Didelot
Hi Ido, Ido Schimmel writes: > Fri, Feb 12, 2016 at 11:34:19PM IST, vivien.dide...@savoirfairelinux.com > wrote: > > Hi Vivien, > >>When a port leaves a bridge, the bridge layer puts its STP state to >>Disabled. If the port is part of an hardware switch, the mode needs to >>be set to Forwarding

Re: [PATCH RFC 2/3] net: bridge: set forwarding state on port removal

2016-02-13 Thread Ido Schimmel
Fri, Feb 12, 2016 at 11:34:19PM IST, vivien.dide...@savoirfairelinux.com wrote: Hi Vivien, >When a port leaves a bridge, the bridge layer puts its STP state to >Disabled. If the port is part of an hardware switch, the mode needs to >be set to Forwarding in order to restore communication with the

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-13 Thread Diego Viola
On Fri, Feb 12, 2016 at 6:17 AM, Diego Viola wrote: > On Wed, Feb 10, 2016 at 7:36 PM, Diego Viola wrote: >> On Wed, Feb 10, 2016 at 2:19 AM, Diego Viola wrote: >>> Hi Guo, >>> >>> I have an x86 computer with this network card: >>> >>> 02:00.0 Ethernet controller: JMicron Technology Corp. JMC260

Re: [PATCH net-next 3/4] net: dsa: mv88e6xxx: check hardware VLAN in use

2016-02-13 Thread Sergei Shtylyov
On 02/13/2016 10:53 PM, Vivien Didelot wrote: The DSA drivers now have access to the VLAN prepare phase and the bridge net_device. It is easier to check for overlapping bridges from within the driver. Thus add such check in mv88e6xxx_port_vlan_prepare. Signed-off-by: Vivien Didelot --- driv

Re: [PATCH RFC 1/3] net: bridge: log state when setting it

2016-02-13 Thread Ido Schimmel
Fri, Feb 12, 2016 at 11:34:18PM IST, vivien.dide...@savoirfairelinux.com wrote: Hi Vivien, >Every call to br_set_state is followed by a call to br_log_state. >Directly call it within br_set_state instead. > >Signed-off-by: Vivien Didelot >--- Maybe I'm missing something, but there are other ins

Re: [PATCH net-next 3/4] net: dsa: mv88e6xxx: check hardware VLAN in use

2016-02-13 Thread Vivien Didelot
Hi Sergei, Sergei Shtylyov writes: > Hello. > > On 2/12/2016 8:09 PM, Vivien Didelot wrote: > >> The DSA drivers now have access to the VLAN prepare phase and the bridge >> net_device. It is easier to check for overlapping bridges from within >> the driver. Thus add such check in mv88e6xxx_port_

Re: [PATCH net-next 2/4] net: dsa: pass bridge down to drivers

2016-02-13 Thread Florian Fainelli
2016-02-12 9:09 GMT-08:00 Vivien Didelot : > Some DSA drivers may or may not support multiple software bridges on top > of an hardware switch. > > It is more convenient for them to access the bridge's net_device for > finer configuration. > > Removing the need to craft and access a bitmask also sim

Re: [PATCH net-next 3/4] net: dsa: mv88e6xxx: check hardware VLAN in use

2016-02-13 Thread Sergei Shtylyov
Hello. On 2/12/2016 8:09 PM, Vivien Didelot wrote: The DSA drivers now have access to the VLAN prepare phase and the bridge net_device. It is easier to check for overlapping bridges from within the driver. Thus add such check in mv88e6xxx_port_vlan_prepare. Signed-off-by: Vivien Didelot ---

[PATCH] net: macb: Add support for phy-handle binding

2016-02-13 Thread Nathan Rossi
This patch adds support for the 'phy-handle' binding which allows for a system to specifically select a phy which can be attached via any MDIO bus available in the system. Signed-off-by: Nathan Rossi Cc: Nicolas Ferre --- drivers/net/ethernet/cadence/macb.c | 58 ++--

Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO

2016-02-13 Thread Sudip Mukherjee
On Saturday 13 February 2016 03:42 PM, Geert Uytterhoeven wrote: On Fri, Feb 12, 2016 at 11:18 AM, Sudip Mukherjee wrote: The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing with the error: drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_se

[PATCH v2] net: phy: spi_ks8995: add dependency on GPIO

2016-02-13 Thread Sudip Mukherjee
The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing with the error: drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' GPIO is now used to res

Re: [PATCH 1/4] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip

2016-02-13 Thread Joachim Eastwood
On 3 February 2016 at 15:54, Alexandre TORGUE wrote: > stm324xx family chips support Synopsys MAC 3.510 IP. > This patch adds settings for logical glue logic: > -clocks > -mode selection MII or RMII. > > Signed-off-by: Alexandre TORGUE > > diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig

Re: [net-next PATCH V2 0/3] net: mitigating kmem_cache free slowpath

2016-02-13 Thread Tilman Schmidt
Hi Jesper, Am 08.02.2016 um 13:14 schrieb Jesper Dangaard Brouer: > Introduce new API napi_consume_skb(), that hides/handles bulk freeing > for the caller. The drivers simply need to use this call when freeing > SKBs in NAPI context, e.g. replacing their calles to dev_kfree_skb() / > dev_consume_

Re: [PATCH] dscc4: Undefined signed int shift

2016-02-13 Thread David Miller
From: Michael McConville Date: Fri, 5 Feb 2016 20:46:25 -0500 > My analysis in the below mail applies, although the second part is > unnecessary because i isn't used in arithmetic operations here: > > https://marc.info/?l=openbsd-tech&m=145377854103866&w=2 > > Thanks for your time. > > Signed-

Re: [PATCH net] net: dsa: mv88e6xxx: fix software VLAN deletion

2016-02-13 Thread David Miller
From: Vivien Didelot Date: Fri, 5 Feb 2016 14:04:39 -0500 > The current bridge code calls switchdev_port_obj_del on a VLAN port even > if the corresponding switchdev_port_obj_add call returned -EOPNOTSUPP. > > If the DSA driver doesn't return -EOPNOTSUPP for a software port VLAN in > its port_v

Re: [PATCH net] net: dsa: mv88e6xxx: do not leave reserved VLANs

2016-02-13 Thread David Miller
From: Vivien Didelot Date: Fri, 5 Feb 2016 14:07:14 -0500 > BRIDGE_VLAN_FILTERING automatically adds a newly bridged port to the > VLAN with the bridge's default_pvid. > > The mv88e6xxx driver currently reserves VLANs 4000+ for unbridged ports > isolation. When a port joins a bridge, it leaves

Re: [PATCH] net: cavium: liquidio: fix check for in progress flag

2016-02-13 Thread David Miller
From: Colin King Date: Fri, 5 Feb 2016 16:30:39 + > From: Colin Ian King > > smatch detected a suspicious looking bitop condition: > > drivers/net/ethernet/cavium/liquidio/lio_main.c:2529 > handle_timestamp() warn: suspicious bitop condition > > (skb_shinfo(skb)->tx_flags | SKBTX_IN_PR

Re: [PATCH net] hv_netvsc: Restore needed_headroom request

2016-02-13 Thread David Miller
From: Vitaly Kuznetsov Date: Fri, 5 Feb 2016 17:29:08 +0100 > Commit c0eb454034aa ("hv_netvsc: Don't ask for additional head room in the > skb") got rid of needed_headroom setting for the driver. With the change I > hit the following issue trying to use ptkgen module: > > [ 57.522021] kernel

Re: [PATCH v3 net 0/7] mvneta fixes for SMP

2016-02-13 Thread David Miller
From: Gregory CLEMENT Date: Thu, 4 Feb 2016 22:09:22 +0100 > Following this bug report: > http://thread.gmane.org/gmane.linux.ports.arm.kernel/468173 and the > suggestions from Russell King, I reviewed all the code involving > multi-CPU. It ended with this series of patches which should improve

Re: [PATCH net-next] r8169:fix system hange problem.

2016-02-13 Thread David Miller
From: Chunhao Lin Date: Fri, 5 Feb 2016 02:28:00 +0800 > There are typos in setting RTL8168H hardware parameters. If system install > another version driver that may cuase system hang. > > Signed-off-by: Chunhao Lin Applied to 'net'.

Re: [PATCH 3/3] net: mvpp2: Return correct error codes

2016-02-13 Thread David Miller
From: Amitoj Kaur Chawla Date: Thu, 4 Feb 2016 19:25:26 +0530 > The return value of kzalloc on failure of allocation of memory should > be -ENOMEM and not -1. > > Found using Coccinelle. A simplified version of the semantic patch > used is: ... > This function may also return -1 after calling m

Re: [PATCHv2] vsock: Fix blocking ops call in prepare_to_wait

2016-02-13 Thread David Miller
From: Laura Abbott Date: Thu, 4 Feb 2016 10:50:45 -0800 > We receoved a bug report from someone using vmware: ... > transport->stream_enqueue may call copy_to_user so it should > not be called inside a prepare_to_wait. Narrow the scope of > the prepare_to_wait to avoid the bad call. This also a

Re: [PATCH net] ipv4: fix memory leaks in ip_cmsg_send() callers

2016-02-13 Thread David Miller
From: Eric Dumazet Date: Thu, 04 Feb 2016 06:23:28 -0800 > From: Eric Dumazet > > Dmitry reported memory leaks of IP options allocated in > ip_cmsg_send() when/if this function returns an error. > > Callers are responsible for the freeing. > > Many thanks to Dmitry for the report and diagnost

Re: [PATCH 2/3] ibmveth: Return correct error codes

2016-02-13 Thread David Miller
From: Amitoj Kaur Chawla Date: Thu, 4 Feb 2016 19:25:19 +0530 > The return value of kmalloc and kcalloc on failure of allocation of > memory should be -ENOMEM and not -1. > > Found using Coccinelle. A simplified version of the semantic patch > used is: ... > The two call sites only check that t

Re: [PATCH 1/3] net: cavium: liquidio: Return correct error code

2016-02-13 Thread David Miller
From: Amitoj Kaur Chawla Date: Thu, 4 Feb 2016 19:25:13 +0530 > The return value of vmalloc on failure of allocation of memory should > be -ENOMEM and not -1. > > Found using Coccinelle. A simplified version of the semantic patch > used is: ... > The single call site of the containing function

Re: [PATCH net v2] bonding: Fix ARP monitor validation

2016-02-13 Thread David Miller
From: Jay Vosburgh Date: Tue, 02 Feb 2016 13:35:56 -0800 > > The current logic in bond_arp_rcv will accept an incoming ARP for > validation if (a) the receiving slave is either "active" (which includes > the currently active slave, or the current ARP slave) or, (b) there is a > currently a

Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO

2016-02-13 Thread Geert Uytterhoeven
On Fri, Feb 12, 2016 at 11:18 AM, Sudip Mukherjee wrote: > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing > with the error: > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function > 'gpiod_set_value' > drivers/net/phy/spi_ks8995.c:477:19: error: impli