[PATCH net 3/3] sctp: remove the unused sctp_datamsg_free()

2016-02-14 Thread Xin Long
Since commit 8b570dc9f7b6 ("sctp: only drop the reference on the datamsg after sending a msg") used sctp_datamsg_put in sctp_sendmsg, instead of sctp_datamsg_free, this function has no use in sctp. So we will remove it. Signed-off-by: Xin Long ---

[PATCH net 2/3] sctp: remove rcu_read_lock in sctp_seq_dump_remote_addrs()

2016-02-14 Thread Xin Long
sctp_seq_dump_remote_addrs is only called by sctp_assocs_seq_show() and it has been protected by rcu_read_lock that is from rhashtable_walk_start(). So we will remove this one. Signed-off-by: Xin Long --- net/sctp/proc.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH net 1/3] sctp: move rcu_read_lock from __sctp_lookup_association to sctp_lookup_association

2016-02-14 Thread Xin Long
__sctp_lookup_association() is only invoked by sctp_v4_err() and sctp_rcv(), both which run on the rx BH, and it has been protected by rcu_read_lock [see ip_local_deliver_finish() / ipv6_rcv()]. So we can move it to sctp_lookup_association, only let sctp_lookup_association use rcu_read_lock.

[PATCH net 0/3] sctp: some cleanups for sctp

2016-02-14 Thread Xin Long
There are some unused function and redundant rcu locks should be removed. Xin Long (3): sctp: move rcu_read_lock from __sctp_lookup_association to sctp_lookup_association sctp: remove rcu_read_lock in sctp_seq_dump_remote_addrs() sctp: remove the unused sctp_datamsg_free()

Re: [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode

2016-02-14 Thread Mugunthan V N
On Saturday 13 February 2016 06:15 AM, David Rivshin (Allworx) wrote: > From: David Rivshin > > The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes, > and silently handled any other values as if MII was specified. In a > case where the PHY mode was

Re: wlcore: Fix regression in wlcore_set_partition()

2016-02-14 Thread Ross Green
On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo wrote: > >> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a >> regression causing the wlcore to time out and go into recovery. Reverting the >> changes regarding write of the last partition size brings

[PATCH] l2tp: Fix error creating L2TP tunnels

2016-02-14 Thread Mark Tomlinson
A previous commit (33f72e6) added notification via netlink for tunnels when created/modified/deleted. If the notification returned an error, this error was returned from the tunnel function. If there were no listeners, the error code ESRCH was returned, even though having no listeners is not an

[PATCH] net: fix bridge multicast packet checksum validation

2016-02-14 Thread Linus Lüssing
We need to update the skb->csum after pulling the skb, otherwise checksum validation will fail. This fixes multicast packet loss for bridges and splats like the following: [...] [ 43.986968] eth0: hw csum failure [ 43.990344] CPU: 3 PID: 0 Comm: swapper/3 Not tainted 4.4.0 #2 [ 43.996193]

linux-next: build warning after merge of the net-next tree

2016-02-14 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: net/ipv4/igmp.c: In function 'igmp_group_added': net/ipv4/igmp.c:1227:14: warning: unused variable 'net' [-Wunused-variable] struct net *net = dev_net(in_dev->dev); ^

Re: [PATCH net-next v1 1/8] skbuff: store hash type in socket buffer...

2016-02-14 Thread Tom Herbert
On Fri, Feb 12, 2016 at 11:13 AM, Paul Durrant wrote: > ...rather than a boolean merely indicating a canonical L4 hash. > > skb_set_hash() takes a hash type (from enum pkt_hash_types) as an > argument but information is lost since only a single bit in the skb > stores

[PATCH net-next] core: remove unneded headers for net cgroup controllers.

2016-02-14 Thread Rami Rosen
commit 3ed80a6 (cgroup: drop module support) made including module.h redundant in the net cgroup controllers, netclassid_cgroup.c and netprio_cgroup.c. This patch removes them. Signed-off-by: Rami Rosen --- net/core/netclassid_cgroup.c | 1 - net/core/netprio_cgroup.c

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-14 Thread Diego Viola
On Sat, Feb 13, 2016 at 6:38 PM, Diego Viola wrote: > On Fri, Feb 12, 2016 at 6:17 AM, Diego Viola wrote: >> On Wed, Feb 10, 2016 at 7:36 PM, Diego Viola wrote: >>> On Wed, Feb 10, 2016 at 2:19 AM, Diego Viola

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-14 Thread Richard Weinberger
Diego, On Sun, Feb 14, 2016 at 9:16 PM, Diego Viola wrote: > Can someone please help? as I wrote on IRC, please wait at least a full week. -- Thanks, //richard

[PATCH] phy: marvell: Fix reg-init bug on 88E1510

2016-02-14 Thread Clemens Gruber
The function marvell_of_reg_init was called too late, in m88e1510_config_aneg. This function was not reached, due to the phy state machine being stuck at waiting for interrupts (which were not enabled and off by default on the 88E1510) It lead to the ethernet link not coming up at boot. This

Re: [PATCH] phy: marvell: Fix reg-init bug on 88E1510

2016-02-14 Thread Andrew Lunn
On Sun, Feb 14, 2016 at 09:31:25PM +0100, Clemens Gruber wrote: > The function marvell_of_reg_init was called too late, in > m88e1510_config_aneg. This function was not reached, due to the phy > state machine being stuck at waiting for interrupts (which were not > enabled and off by default on the

Re: [PATCH net-next v1 0/8] xen-netback: support toeplitz hashing

2016-02-14 Thread Tom Herbert
On Fri, Feb 12, 2016 at 5:59 PM, Paul Durrant wrote: >> -Original Message- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: 12 February 2016 16:42 >> To: Paul Durrant >> Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org >> Subject: Re: [PATCH

Re: [PATCH net-next v1 7/8] xen-netback: pass toeplitz hash value to the frontend

2016-02-14 Thread Tom Herbert
On Fri, Feb 12, 2016 at 11:13 AM, Paul Durrant wrote: > My recent patch to include/xen/interface/io/netif.h defines a new extra > info type that can be used to pass toeplitz hash values between backend > and VM frontend. > > This patch adds code to xen-netback to pass

Re: [PATCH net-next v1 6/8] xen-netback: add an implementation of toeplitz hashing...

2016-02-14 Thread Tom Herbert
On Fri, Feb 12, 2016 at 11:13 AM, Paul Durrant wrote: > ...for receive-side packets. > > My recent patch to include/xen/interface/io/netif.h defines a set of > control messages that can be used by a VM frontend driver to configure > toeplitz hashing of receive-side

Re: [PATCH] phy: marvell: Fix reg-init bug on 88E1510

2016-02-14 Thread Clemens Gruber
On Sun, Feb 14, 2016 at 09:48:22PM +0100, Andrew Lunn wrote: > On Sun, Feb 14, 2016 at 09:31:25PM +0100, Clemens Gruber wrote: > > The function marvell_of_reg_init was called too late, in > > m88e1510_config_aneg. This function was not reached, due to the phy > > state machine being stuck at

Re: [PATCH] Revert "net: phy: turn carrier off on phy attach"

2016-02-14 Thread Clemens Gruber
On Fri, Feb 12, 2016 at 10:56:04AM -0800, Florian Fainelli wrote: > On 12/02/16 10:01, Clemens Gruber wrote: > > Commit 113c74d83eef ("net: phy: turn carrier off on phy attach") breaks > > the eth0 link coming up on all my i.MX6Q boards with a Marvell 88E1510. > > If I then do a ifconfig eth0

Re: [PATCH V4 3/8] net/ethtool: introduce a new ioctl for per queue setting

2016-02-14 Thread Ben Hutchings
On Mon, 2016-02-08 at 02:45 -0500, Kan Liang wrote: > From: Kan Liang > > Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting. > The following patches will enable some SUB_COMMANDs for per queue > setting. > > Signed-off-by: Kan Liang

Re: [PATCH V4 4/8] net/ethtool: support get coalesce per queue

2016-02-14 Thread Ben Hutchings
On Mon, 2016-02-08 at 02:45 -0500, Kan Liang wrote: > From: Kan Liang > > This patch implements sub command ETHTOOL_GCOALESCE for ioctl > ETHTOOL_PERQUEUE. It introduces an interface get_per_queue_coalesce to > get coalesce of each masked queue from device driver. Then the

Re: [PATCH] Revert "net: phy: turn carrier off on phy attach"

2016-02-14 Thread Florian Fainelli
On February 14, 2016 10:25:30 AM PST, Clemens Gruber wrote: >On Fri, Feb 12, 2016 at 10:56:04AM -0800, Florian Fainelli wrote: >> On 12/02/16 10:01, Clemens Gruber wrote: >> > Commit 113c74d83eef ("net: phy: turn carrier off on phy attach") >breaks >> > the eth0 link

Re: [PATCH V4 6/8] i40e: queue-specific settings for interrupt moderation

2016-02-14 Thread Ben Hutchings
On Mon, 2016-02-08 at 02:45 -0500, Kan Liang wrote: [...] > --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > @@ -1849,23 +1849,37 @@ static int i40e_set_phys_id(struct net_device *netdev, >   * 125us (8000 interrupts per second) ==

Re: [PATCH V4 5/8] net/ethtool: support set coalesce per queue

2016-02-14 Thread Ben Hutchings
On Mon, 2016-02-08 at 02:45 -0500, Kan Liang wrote: > From: Kan Liang > > This patch implements sub command ETHTOOL_SCOALESCE for ioctl > ETHTOOL_PERQUEUE. It introduces an interface set_per_queue_coalesce to > set coalesce of each masked queue to device driver. The wanted

[PATCH/RFC v5 net-next] ravb: Add dma queue interrupt support

2016-02-14 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (error, gPTP) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network control rx/tx) This patch improve efficiency of the interrupt

[PATCH 0/2] Kill useless *switch* defaults in the Renesas Ethernet drivers

2016-02-14 Thread Sergei Shtylyov
Hello. Here's a set of 2 patches against DaveM's 'net-next.git' repo removing often used *default* cases doing nothing. [1/2] ravb: kill useless *switch* defaults [2/2] sh_eth: kill useless *switch* defaults MBR, Sergei

[PATCH 1/2] ravb: kill useless *switch* defaults

2016-02-14 Thread Sergei Shtylyov
The driver has the *default* case doing nothing in the *switch* statement with an integer expression -- remove it. Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/ravb_main.c |2 -- 1 file changed, 2 deletions(-) Index:

[PATCH 2/2] sh_eth: kill useless *switch* defaults

2016-02-14 Thread Sergei Shtylyov
The driver often has the *default* cases doing nothing in the *switch* statements with the integer expressions -- remove them. Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 12 1 file changed, 12 deletions(-)

[net-next] macvlan: convert to use IFF_NO_QUEUE

2016-02-14 Thread Zhang Shengju
Use IFF_NO_QUEUE to indicate that a device can run without a qdisc. Signed-off-by: Zhang Shengju --- drivers/net/macvlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 94e6888..426a2cc

Re: [PATCH net] bridge: fix regression in ageing time

2016-02-14 Thread Ido Schimmel
Fri, Feb 12, 2016 at 11:31:09PM IST, step...@networkplumber.org wrote: >This fixes a regression in the bridge ageing time caused by: > >commit c62987bbd8a1 ("bridge: push bridge setting ageing_time down to >switchdev") > >There are users of Linux bridge which use the feature that if ageing time