[net:master 66/72] drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:700:1: warning: 'vpdstrtou16.constprop' uses dynamic stack allocation

2016-02-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: d07c0278da1f4cfc91c3d46d0d07a0d13a949892 commit: 1003e19c466dc37812b5f88b2d5308ee63bb3fa0 [66/72] cxgb3: fix up vpd strings for kstrto*() config: s390-allmodconfig (attached as .config) reproduce: wget

Re: [PATCH] Bluetooth: hci_core: Avoid mixing up req_complete and req_complete_skb

2016-02-19 Thread Johan Hedberg
Hi Douglas, On Fri, Feb 19, 2016, Douglas Anderson wrote: > In commit 44d271377479 ("Bluetooth: Compress the size of struct > hci_ctrl") we squashed down the size of the structure by using a union > with the assumption that all users would use the flag to determine > whether we had a req_complete

Re: [PATCH net 0/3] bnxt_en: Phy related fixes.

2016-02-19 Thread Michael Chan
On Fri, Feb 19, 2016 at 8:40 PM, David Miller wrote: > From: Michael Chan > Date: Fri, 19 Feb 2016 19:43:18 -0500 > >> 3 small patches to fix PHY related code. > > Series applied, thanks Michael. > > Although I'm not so sure how wise it is to not

RE: [PATCH] xen-netfront: set real_num_tx_queues to zreo avoid to trigger BUG_ON

2016-02-19 Thread Gonglei (Arei)
Hi, Thanks for rapid feedback :) > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, February 20, 2016 12:37 PM > > From: Gonglei > Date: Sat, 20 Feb 2016 09:27:26 +0800 > > > It's possible for a race condition to exist between xennet_open() and > >

[PATCH iproute2] bridge: add support for dynamic fdb entries

2016-02-19 Thread Roopa Prabhu
From: Roopa Prabhu This patch is a follow up to the recently added 'static' fdb option. It introduces a new option 'dynamic' which adds dynamic fdb entries with NUD_REACHABLE. $bridge fdb add 00:01:02:03:04:06 dev eth0 master dynamic $bridge fdb show

Re: pull request [net]: batman-adv 20160216

2016-02-19 Thread Antonio Quartulli
On Fri, Feb 19, 2016 at 03:37:18PM -0500, David Miller wrote: > And thanks for the heads up about the potential merge issues, I'll watch > for that. > Hi David, actually I just realized that the patches that will create the conflict are not yet in net-next, but they are still pending in my

Re: [PATCH net-next 0/3] bpf_get_stackid() and stack_trace map

2016-02-19 Thread David Miller
From: Alexei Starovoitov Date: Wed, 17 Feb 2016 19:58:56 -0800 > This patch set introduces new map type to store stack traces and > corresponding bpf_get_stackid() helper. ... Series applied, thanks Alexei.

Re: [PATCHv3 net 5/5] nfp: don't trust netif_running() in debug code

2016-02-19 Thread David Miller
From: Jakub Kicinski Date: Thu, 18 Feb 2016 20:38:13 + > Since change_mtu() can fail and leave us with netif_running() > returning true even though all rings were freed - we should > look at NFP_NET_CFG_CTRL_ENABLE flag to determine if device > is really opened.

Re: [PATCH net] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-19 Thread David Miller
From: Chunhao Lin Date: Thu, 18 Feb 2016 22:57:07 +0800 > There will be a log spam when there is no cable plugged. > Please refer to following links. > https://bugzilla.kernel.org/show_bug.cgi?id=104351 > https://bugzilla.kernel.org/show_bug.cgi?id=107421 > > This issue is

Re: [PATCH net] af_unix: Don't use continue to re-execute unix_stream_read_generic loop

2016-02-19 Thread David Miller
From: Rainer Weikusat Date: Thu, 18 Feb 2016 12:39:46 + > The unix_stream_read_generic function tries to use a continue statement > to restart the receive loop after waiting for a message. This may not > work as intended as the caller might use a recvmsg

Re: [PATCH] net: bcmgenet: Fix internal PHY link state

2016-02-19 Thread David Miller
From: Jaedon Shin Date: Fri, 19 Feb 2016 13:48:50 +0900 > The PHY link state is not chaged in GENETv2 caused by the previous > commit 49f7a471e4d1 ("net: bcmgenet: Properly configure PHY to ignore > interrupt") was set to PHY_IGNORE_INTERRUPT in bcmgenet_mii_probe(). > >

Re: [PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino

2016-02-19 Thread David Miller
From: Cong Wang Date: Fri, 19 Feb 2016 16:21:14 -0800 > On Thu, Feb 18, 2016 at 5:27 PM, Dmitry V. Levin wrote: >> The value passed by unix_diag_get_exact to unix_lookup_by_ino has type >> __u32, but unix_lookup_by_ino's argument ino has type int,

Re: [PATCH net-next] net: use skb_postpush_rcsum instead of own implementations

2016-02-19 Thread David Miller
From: Daniel Borkmann Date: Sat, 20 Feb 2016 00:29:30 +0100 > Replace individual implementations with the recently introduced > skb_postpush_rcsum() helper. > > Signed-off-by: Daniel Borkmann Applied, thanks Daniel.

Re: [PATCH net 0/3] bnxt_en: Phy related fixes.

2016-02-19 Thread David Miller
From: Michael Chan Date: Fri, 19 Feb 2016 19:43:18 -0500 > 3 small patches to fix PHY related code. Series applied, thanks Michael. Although I'm not so sure how wise it is to not fail an ->open() if the PHY settings fail.

Re: [PATCH] xen-netfront: set real_num_tx_queues to zreo avoid to trigger BUG_ON

2016-02-19 Thread David Miller
From: Gonglei Date: Sat, 20 Feb 2016 09:27:26 +0800 > It's possible for a race condition to exist between xennet_open() and > talk_to_netback(). After invoking netfront_probe() then other > threads or processes invoke xennet_open (such as NetworkManager) > immediately

Re: [Patch net-next] phy: marvell/micrel: Fix Unpossible condition

2016-02-19 Thread David Miller
From: Andrew Lunn Date: Sat, 20 Feb 2016 00:35:29 +0100 > commit 2b2427d06426 ("phy: micrel: Add ethtool statistics counters") > from Dec 30, 2015, leads to the following static checker > warning: > > drivers/net/phy/micrel.c:609 kszphy_get_stat() > warn:

[PATCH 1/1] net-next: do not store needed_headroom in ip_tunnel_xmit

2016-02-19 Thread Francesco Ruggeri
Misconfigurations can result in local tunnel loops being created. __dev_queue_xmit catches packets caught in a loop and drops them, but the affected tunnels' needed_headroom can be corrupted in the process as it is recursively updated. The script below can be used to create a loop between two

Re: [PATCH V7 0/8] ethtool per queue parameters support

2016-02-19 Thread David Miller
From: Kan Liang Date: Fri, 19 Feb 2016 09:23:58 -0500 > Modern network interface controllers usually support multiple receive > and transmit queues. Each queue may have its own parameters. For > example, Intel XL710/X710 hardware supports per queue interrupt > moderation.

Re: [PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5]

2016-02-19 Thread David Miller
From: Ken Kawasaki Date: Sat, 20 Feb 2016 10:57:06 +0900 > > The MAC address of FMV-J182 is stored at buf[5]. > > Signed-off-by: Ken Kawasaki This is an extremely poor and misleading description of your change. The original code was accessing

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-19 Thread Jesse Gross
On Fri, Feb 19, 2016 at 4:14 PM, Tom Herbert wrote: > On Fri, Feb 19, 2016 at 4:08 PM, Jesse Gross wrote: >> On Fri, Feb 19, 2016 at 3:10 PM, Alex Duyck wrote: >>> On Fri, Feb 19, 2016 at 1:53 PM, Jesse Gross wrote:

Re: [PATCH net-next] net: use skb_postpush_rcsum instead of own implementations

2016-02-19 Thread Alexei Starovoitov
On Sat, Feb 20, 2016 at 12:29:30AM +0100, Daniel Borkmann wrote: > Replace individual implementations with the recently introduced > skb_postpush_rcsum() helper. > > Signed-off-by: Daniel Borkmann nice follow up to f8ffad69c9f8 indeed. Acked-by: Alexei Starovoitov

[PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5]

2016-02-19 Thread Ken Kawasaki
The MAC address of FMV-J182 is stored at buf[5]. Signed-off-by: Ken Kawasaki --- --- linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c.orig 2016-02-19 20:48:40.143852346 +0900 +++ linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c 2016-02-20

[PATCH] xen-netfront: set real_num_tx_queues to zreo avoid to trigger BUG_ON

2016-02-19 Thread Gonglei
It's possible for a race condition to exist between xennet_open() and talk_to_netback(). After invoking netfront_probe() then other threads or processes invoke xennet_open (such as NetworkManager) immediately may trigger BUG_ON(). Besides, we also should reset real_num_tx_queues in

Re: [PATCH V7 0/8] ethtool per queue parameters support

2016-02-19 Thread David Miller
From: Jeff Kirsher Date: Fri, 19 Feb 2016 13:50:18 -0800 > Dave, I have pretty much cleared out my i40e queue of patches, so I am > fine if you want to apply the entire series (of course after proper > review) :-) Ok, thanks Jeff.

Re: [PATCH] bgmac: support Ethernet device on BCM47094 SoC

2016-02-19 Thread David Miller
From: Rafał Miłecki Date: Fri, 19 Feb 2016 22:26:48 +0100 > Are you applying it to net-next? It way my intention, sorry if I was > supposed to make it more clear. You are always supposed to specify this explicitly, in the Subject line, after PATCH, like "[PATCH net-next]

[Patch net-next] net_sched: add network namespace support for tc actions

2016-02-19 Thread Cong Wang
Currently tc actions are stored in a per-module hashtable, therefore are visible to all network namespaces. This is probably the last part of the tc subsystem which is not aware of netns now. This patch makes them per-netns, several tc action API's need to be adjusted for this. The tc action API

[PATCH net 1/3] bnxt_en: Poll link at the end of __bnxt_open_nic().

2016-02-19 Thread Michael Chan
From: Michael Chan When shutting down the NIC, we shutdown async event processing before freeing all the rings. If there is a link change event during reset, the driver may miss it and the link state may be incorrect after the NIC is re-opened. Poll the link at the end of

[PATCH net 3/3] bnxt_en: Failure to update PHY is not fatal condition.

2016-02-19 Thread Michael Chan
From: Michael Chan If we fail to update the PHY, we should print a warning and continue. The current code to exit is buggy as it has not freed up the NIC resources yet. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2

[PATCH net 2/3] bnxt_en: Remove unnecessary call to update PHY settings.

2016-02-19 Thread Michael Chan
From: Michael Chan Fix bnxt_update_phy_setting() to check the correct parameters when determining whether to update the PHY. Requested line speed/duplex should only be checked for forced speed mode. This avoids unnecessary link interruptions when loading the driver.

[PATCH net 0/3] bnxt_en: Phy related fixes.

2016-02-19 Thread Michael Chan
3 small patches to fix PHY related code. Michael Chan (3): bnxt_en: Poll link at the end of __bnxt_open_nic(). bnxt_en: Remove unnecessary call to update PHY settings. bnxt_en: Failure to update PHY is not fatal condition. drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 - 1 file

Re: [PATCH next v3 1/3] ipvlan: scrub skb before routing in L3 mode.

2016-02-19 Thread Cong Wang
On Thu, Feb 18, 2016 at 5:06 PM, Mahesh Bandewar wrote: > On Thu, Feb 18, 2016 at 4:44 PM, Cong Wang wrote: >> On Thu, Feb 18, 2016 at 4:39 PM, Mahesh Bandewar wrote: >>> [snip] > - skb_dst_drop(skb); > +

Re: [PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino

2016-02-19 Thread Cong Wang
On Thu, Feb 18, 2016 at 5:27 PM, Dmitry V. Levin wrote: > The value passed by unix_diag_get_exact to unix_lookup_by_ino has type > __u32, but unix_lookup_by_ino's argument ino has type int, which is not > a problem yet. > However, when ino is compared with sock_i_ino return

Loan @ 3% Rate offer. Reply if interested.

2016-02-19 Thread loan
--

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-19 Thread Tom Herbert
On Fri, Feb 19, 2016 at 4:08 PM, Jesse Gross wrote: > On Fri, Feb 19, 2016 at 3:10 PM, Alex Duyck wrote: >> On Fri, Feb 19, 2016 at 1:53 PM, Jesse Gross wrote: >>> On Fri, Feb 19, 2016 at 11:26 AM, Alexander Duyck

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-19 Thread Jesse Gross
On Fri, Feb 19, 2016 at 3:10 PM, Alex Duyck wrote: > On Fri, Feb 19, 2016 at 1:53 PM, Jesse Gross wrote: >> On Fri, Feb 19, 2016 at 11:26 AM, Alexander Duyck >> wrote: >>> This patch series makes it so that we enable the outer Tx

[Patch net] net_sched: fix memory leaks when rmmod tc action modules

2016-02-19 Thread Cong Wang
We only release the memory of the hashtable itself, not its entries inside. We need to do both. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- include/net/act_api.h | 5 - net/sched/act_api.c | 32 +--- 2 files

Re: [PATCH net-next] net: use skb_postpush_rcsum instead of own implementations

2016-02-19 Thread Tom Herbert
On Fri, Feb 19, 2016 at 3:29 PM, Daniel Borkmann wrote: > Replace individual implementations with the recently introduced > skb_postpush_rcsum() helper. > > Signed-off-by: Daniel Borkmann Acked-by: Tom Herbert Looks like some

[Patch net-next] phy: marvell/micrel: Fix Unpossible condition

2016-02-19 Thread Andrew Lunn
commit 2b2427d06426 ("phy: micrel: Add ethtool statistics counters") from Dec 30, 2015, leads to the following static checker warning: drivers/net/phy/micrel.c:609 kszphy_get_stat() warn: unsigned 'val' is never less than zero. drivers/net/phy/micrel.c 602 static u64

[PATCH net-next] net: use skb_postpush_rcsum instead of own implementations

2016-02-19 Thread Daniel Borkmann
Replace individual implementations with the recently introduced skb_postpush_rcsum() helper. Signed-off-by: Daniel Borkmann --- net/core/skbuff.c | 4 +--- net/ipv6/reassembly.c | 6 ++ net/openvswitch/actions.c | 8 +++-

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-19 Thread Alex Duyck
On Fri, Feb 19, 2016 at 1:53 PM, Jesse Gross wrote: > On Fri, Feb 19, 2016 at 11:26 AM, Alexander Duyck wrote: >> This patch series makes it so that we enable the outer Tx checksum for IPv4 >> tunnels by default. This makes the behavior consistent with how

[PATCH] Bluetooth: hci_core: Avoid mixing up req_complete and req_complete_skb

2016-02-19 Thread Douglas Anderson
In commit 44d271377479 ("Bluetooth: Compress the size of struct hci_ctrl") we squashed down the size of the structure by using a union with the assumption that all users would use the flag to determine whether we had a req_complete or a req_complete_skb. Unfortunately we had a case in

Re: [PATCH v2 3/3] net: netcp: rework the code for get/set sw_data in dma desc

2016-02-19 Thread Arnd Bergmann
On Friday 19 February 2016 17:21:57 Murali Karicheri wrote: > >> get_pkt_info(_buf, , _desc, ndesc); > >> -get_sw_data((u32 *)_ptr, _len, ndesc); > >> +/* warning We are retrieving the virtual ptr in the > >> sw_data > >> + * field as a 32bit

Re: [PATCH v2 3/3] net: netcp: rework the code for get/set sw_data in dma desc

2016-02-19 Thread Murali Karicheri
On 02/19/2016 03:55 PM, Arnd Bergmann wrote: > On Friday 19 February 2016 12:58:44 Murali Karicheri wrote: >> SW data field in descriptor can be used by software to hold private >> data for the driver. As there are 4 words available for this purpose, >> use separate macros to place it or retrieve

[PATCH net-next 4/6] bpf: try harder on clones when writing into skb

2016-02-19 Thread Daniel Borkmann
When we're dealing with clones and the area is not writeable, try harder and get a copy via pskb_expand_head(). Replace also other occurences in tc actions with the new skb_try_make_writable(). Reported-by: Ashhad Sheikh Signed-off-by: Daniel Borkmann

[PATCH net-next 2/6] bpf: add generic bpf_csum_diff helper

2016-02-19 Thread Daniel Borkmann
For L4 checksums, we currently have bpf_l4_csum_replace() helper. It's currently limited to handle 2 and 4 byte changes in a header and feeds the from/to into inet_proto_csum_replace{2,4}() helpers of the kernel. When working with IPv6, for example, this makes it rather cumbersome to deal with,

[PATCH net-next 5/6] bpf: fix csum update in bpf_l4_csum_replace helper for udp

2016-02-19 Thread Daniel Borkmann
When using this helper for updating UDP checksums, we need to extend this in order to write CSUM_MANGLED_0 for csum computations that result into 0 as sum. Reason we need this is because packets with a checksum could otherwise become incorrectly marked as a packet without a checksum. Likewise, if

[PATCH net-next 6/6] bpf: don't emit mov A,A on return

2016-02-19 Thread Daniel Borkmann
While debugging with bpf_jit_disasm I noticed emissions of 'mov %eax,%eax', and found that this comes from BPF_RET | BPF_A translations from classic BPF. Emitting this is unnecessary as BPF_REG_A is mapped into BPF_REG_0 already, therefore only emit a mov when immediates are used as return value.

[PATCH net-next 0/6] BPF updates

2016-02-19 Thread Daniel Borkmann
This set contains various updates for eBPF, i.e. the addition of a generic csum helper function and other misc bits that mostly improve existing helpers and ease programming with eBPF on cls_bpf. For more details, please see individual patches. Set is rebased on top of

[PATCH net-next 1/6] bpf: add new arg_type that allows for 0 sized stack buffer

2016-02-19 Thread Daniel Borkmann
Currently, when we pass a buffer from the eBPF stack into a helper function, the function proto indicates argument types as ARG_PTR_TO_STACK and ARG_CONST_STACK_SIZE pair. If R contains the former, then R must be of the latter type. Then, verifier checks whether the buffer points into eBPF

Re: [PATCH V7 8/8] i40e/ethtool: support coalesce setting by queue

2016-02-19 Thread Jeff Kirsher
On Fri, 2016-02-19 at 09:24 -0500, Kan Liang wrote: > From: Kan Liang > > This patch implements set_per_queue_coalesce for i40e driver. > > Signed-off-by: Kan Liang > --- >  drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +++ >  1 file changed,

Re: [PATCH V7 6/8] i40e: queue-specific settings for interrupt moderation

2016-02-19 Thread Jeff Kirsher
On Fri, 2016-02-19 at 09:24 -0500, Kan Liang wrote: > From: Kan Liang > > For i40e driver, each vector has its own ITR register. However, there > are no concept of queue-specific settings in the driver proper. Only > global variable is used to store ITR values. That will

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-19 Thread Jesse Gross
On Fri, Feb 19, 2016 at 11:26 AM, Alexander Duyck wrote: > This patch series makes it so that we enable the outer Tx checksum for IPv4 > tunnels by default. This makes the behavior consistent with how we were > handling this for IPv6. In addition I have updated the internal

Re: [PATCH V7 0/8] ethtool per queue parameters support

2016-02-19 Thread Jeff Kirsher
On Fri, 2016-02-19 at 09:23 -0500, Kan Liang wrote: > Modern network interface controllers usually support multiple receive > and transmit queues. Each queue may have its own parameters. For > example, Intel XL710/X710 hardware supports per queue interrupt > moderation. However, current ethtool

[PATCH V7 0/8] ethtool per queue parameters support

2016-02-19 Thread Kan Liang
Modern network interface controllers usually support multiple receive and transmit queues. Each queue may have its own parameters. For example, Intel XL710/X710 hardware supports per queue interrupt moderation. However, current ethtool does not support per queue parameters option. User has to set

[PATCH V7 2/8] test_bitmap: unit tests for lib/bitmap.c

2016-02-19 Thread Kan Liang
From: David Decotigny This is mainly testing bitmap construction and conversion to/from u32[] for now. Tested: qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- lib/Kconfig.debug | 8 +

[PATCH V7 4/8] net/ethtool: support get coalesce per queue

2016-02-19 Thread Kan Liang
From: Kan Liang This patch implements sub command ETHTOOL_GCOALESCE for ioctl ETHTOOL_PERQUEUE. It introduces an interface get_per_queue_coalesce to get coalesce of each masked queue from device driver. Then the interrupt coalescing parameters will be copied back to user

[PATCH V7 7/8] i40e/ethtool: support coalesce getting by queue

2016-02-19 Thread Kan Liang
From: Kan Liang This patch implements get_per_queue_coalesce for i40e driver. Signed-off-by: Kan Liang --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH V7 8/8] i40e/ethtool: support coalesce setting by queue

2016-02-19 Thread Kan Liang
From: Kan Liang This patch implements set_per_queue_coalesce for i40e driver. Signed-off-by: Kan Liang --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH V7 6/8] i40e: queue-specific settings for interrupt moderation

2016-02-19 Thread Kan Liang
From: Kan Liang For i40e driver, each vector has its own ITR register. However, there are no concept of queue-specific settings in the driver proper. Only global variable is used to store ITR values. That will cause problems especially when resetting the vector. The specific

[PATCH V7 3/8] net/ethtool: introduce a new ioctl for per queue setting

2016-02-19 Thread Kan Liang
From: Kan Liang Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting. The following patches will enable some SUB_COMMANDs for per queue setting. Signed-off-by: Kan Liang Reviewed-by: Ben Hutchings ---

[PATCH V7 1/8] lib/bitmap.c: conversion routines to/from u32 array

2016-02-19 Thread Kan Liang
From: David Decotigny Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic way. Tested: unit tests (next patch) on qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny Reviewed-by: Ben Hutchings

[PATCH V7 5/8] net/ethtool: support set coalesce per queue

2016-02-19 Thread Kan Liang
From: Kan Liang This patch implements sub command ETHTOOL_SCOALESCE for ioctl ETHTOOL_PERQUEUE. It introduces an interface set_per_queue_coalesce to set coalesce of each masked queue to device driver. The wanted coalesce information are stored in "data" for each masked

Re: [net-next PATCH 2/2] VXLAN: Support outer IPv4 Tx checksums by default

2016-02-19 Thread Jesse Gross
On Fri, Feb 19, 2016 at 12:27 PM, Tom Herbert wrote: > I would also note RFC7348 specifies: > > UDP Checksum: It SHOULD be transmitted as zero. ... > > The RFC doesn't provide any rationale as to why this is a SHOULD > (neither is there any discussion as to whether this

Re: [PATCH] bgmac: support Ethernet device on BCM47094 SoC

2016-02-19 Thread Rafał Miłecki
On 19 February 2016 at 21:37, David Miller wrote: > From: Rafał Miłecki > Date: Wed, 17 Feb 2016 07:48:28 +0100 > >> It needs very similar workarounds to the one on BCM4707. It was tested >> on D-Link DIR-885L home router. >> >> Signed-off-by: Rafał Miłecki

RE: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-19 Thread Bryan.Whitehead
Thanks Andrew, Your tips are much appreciated. Bryan

Re: [PATCH v1 1/4] net: ti: netcp: restore get/set_pad_info() functionality

2016-02-19 Thread Arnd Bergmann
On Friday 19 February 2016 13:01:59 Murali Karicheri wrote: > > > I have just send v2. I will investigate your original patch that added > regression this afternoon and respond with my observation as soon as > my investigation is complete. Thanks. > I assume, you are trying to make the change >

Re: [PATCH 1/1] ser_gigaset: use container_of() instead of detour

2016-02-19 Thread David Miller
From: Paul Bolle Date: Thu, 18 Feb 2016 21:29:08 +0100 > The purpose of gigaset_device_release() is to kfree() the struct > ser_cardstate that contains our struct device. This is done via a bit of > a detour. First we make our struct device's driver_data point to the >

Re: [PATCH v2 1/3] net: ti: netcp: restore get/set_pad_info() functionality

2016-02-19 Thread Arnd Bergmann
On Friday 19 February 2016 12:58:42 Murali Karicheri wrote: > The commit 899077791403 ("netcp: try to reduce type confusion in > descriptors") introduces a regression in Kernel 4.5-rc1 and it breaks > get/set_pad_info() functionality. > > The TI NETCP driver uses pad0 and pad1 fields of

Re: [PATCH v2 2/3] soc: ti: knav_dma: rename pad in struct knav_dma_desc to sw_data

2016-02-19 Thread Arnd Bergmann
On Friday 19 February 2016 12:58:43 Murali Karicheri wrote: > Rename the pad to sw_data as per description of this field in the hardware > spec(refer sprugr9 from www.ti.com). Latest version of the document is > at http://www.ti.com/lit/ug/sprugr9h/sprugr9h.pdf and section 3.1 > Host Packet

Re: [net-next 10/16] i40e: add check for null VSI

2016-02-19 Thread David Miller
From: "Underwood, JohnX" Date: Fri, 19 Feb 2016 19:51:39 + > Sorry, folks. I was confused. The patch looked familiar, but I > wasn't able to find the email where I originally sent it out. Please stop top-posting Quote the relevant material, then add your

Re: [PATCH v2 3/3] net: netcp: rework the code for get/set sw_data in dma desc

2016-02-19 Thread Arnd Bergmann
On Friday 19 February 2016 12:58:44 Murali Karicheri wrote: > SW data field in descriptor can be used by software to hold private > data for the driver. As there are 4 words available for this purpose, > use separate macros to place it or retrieve the same to/from > descriptors. Also do type cast

Re: pull-request: wireless-drivers 2016-02-18

2016-02-19 Thread David Miller
From: Kalle Valo Date: Thu, 18 Feb 2016 17:28:14 +0200 > I have some important fixes I would like to get 4.5 still, more info in > the signed tag. Please let me know if you have problems. Pulled, thanks.

Re: [PATCH v2 1/1] cxgb3: fix up vpd strings for kstrto*()

2016-02-19 Thread David Miller
From: Steve Wise Date: Thu, 18 Feb 2016 06:34:24 -0800 > The vpd strings are left justified, in a fixed length array, with possible > trailing white space and no NUL. So fix them up before calling kstrto*(). > > This is a recent regression which causes cxgb3 to

Re: [PATCH net-next] hv_netvsc: add software transmit timestamp support

2016-02-19 Thread David Miller
From: Simon Xiao Date: Wed, 17 Feb 2016 16:43:59 -0800 > Enable skb_tx_timestamp in hyperv netvsc. > > Signed-off-by: Simon Xiao > Reviewed-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang Applied.

Re: [PATCH net-next] ipv6: pass up EMSGSIZE msg for UDP socket in Ipv6

2016-02-19 Thread David Miller
From: Wei Wang Date: Wed, 17 Feb 2016 13:58:22 -0800 > From: Wei Wang > > In ipv4, when the machine receives a ICMP_FRAG_NEEDED message, the > connected UDP socket will get EMSGSIZE message on its next read from the > socket. > However, this is not

Re: [PATCH V6 0/8] ethtool per queue parameters support

2016-02-19 Thread David Miller
From: Kan Liang Date: Thu, 18 Feb 2016 07:39:48 -0500 > Modern network interface controllers usually support multiple receive > and transmit queues. Each queue may have its own parameters. For > example, Intel XL710/X710 hardware supports per queue interrupt > moderation.

Re: [PATCH net-next] be2net: Fix pcie error recovery in case of NIC+RoCE adapters

2016-02-19 Thread David Miller
From: Padmanabh Ratnakar Date: Thu, 18 Feb 2016 03:09:34 +0530 > Interrupts registered by RoCE driver are not unregistered when > msix interrupts are disabled during error recovery causing a > crash. Detach the adapter instance from RoCE driver when error > is

Re: [PATCH] tipc: unlock in error path

2016-02-19 Thread David Miller
From: Insu Yun Date: Wed, 17 Feb 2016 11:47:35 -0500 > tipc_bcast_unlock need to be unlocked in error path. > > Signed-off-by: Insu Yun Applied.

Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-19 Thread David Miller
From: Paolo Abeni Date: Wed, 17 Feb 2016 19:30:01 +0100 > the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be > correctly controlled.") changed the default xmit checksum setting > for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not > set into

Re: [PATCH] bgmac: support Ethernet device on BCM47094 SoC

2016-02-19 Thread David Miller
From: Rafał Miłecki Date: Wed, 17 Feb 2016 07:48:28 +0100 > It needs very similar workarounds to the one on BCM4707. It was tested > on D-Link DIR-885L home router. > > Signed-off-by: Rafał Miłecki This patch doesn't apply, I get rejects.

Re: pull request [net]: batman-adv 20160216

2016-02-19 Thread David Miller
From: Antonio Quartulli Date: Tue, 16 Feb 2016 23:01:25 +0800 > this pull request is intended for net. > > Two of the fixes included in this patchset prevent a wrong memory > access - it was triggered when removing an object from a list > after it was already free'd due to bad

Re: [PATCH] rtnl: RTM_GETNETCONF: fix wrong return value

2016-02-19 Thread David Miller
From: Anton Protopopov Date: Tue, 16 Feb 2016 21:43:16 -0500 > An error response from a RTM_GETNETCONF request can return the positive > error value EINVAL in the struct nlmsgerr that can mislead userspace. > > Signed-off-by: Anton Protopopov

Re: [PATCH net-next,V2] net: macb: make magic-packet property generic

2016-02-19 Thread David Miller
From: Sergio Prado Date: Tue, 16 Feb 2016 21:10:45 -0200 > As requested by Rob Herring on patch > https://patchwork.ozlabs.org/patch/580862/. > > This is a new property that it's still in net-next and has never been > used in production, so we are not breaking

Re: [PATCH net] net: make netdev_for_each_lower_dev safe for device removal

2016-02-19 Thread David Miller
From: David Ahern Date: Wed, 17 Feb 2016 12:01:10 -0700 > On 2/17/16 10:00 AM, Nikolay Aleksandrov wrote: >> From: Nikolay Aleksandrov >> >> When I used netdev_for_each_lower_dev in commit bad531623253 ("vrf: >> remove slave queue and

Re: [net-next PATCH 1/2] GENEVE: Support outer IPv4 Tx checksums by default

2016-02-19 Thread Tom Herbert
On Fri, Feb 19, 2016 at 11:26 AM, Alexander Duyck wrote: > This change makes it so that if UDP CSUM is not specified we will default > to enabling it. The main motivation behind this is the fact that with the > use of outer checksum we can greatly improve the performance for

Re: [net-next PATCH 2/2] VXLAN: Support outer IPv4 Tx checksums by default

2016-02-19 Thread Tom Herbert
On Fri, Feb 19, 2016 at 11:26 AM, Alexander Duyck wrote: > This change makes it so that if UDP CSUM is not specified we will default > to enabling it. The main motivation behind this is the fact that with the > use of outer checksum we can greatly improve the performance for

Re: [PATCH net-next 0/2] bridge: mdb: add support for extended attributes

2016-02-19 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 18 Feb 2016 21:51:26 +0100 > I just thought this version is a middle ground between the two solutions and > still doesn't break user-space while being extensible. Ok, I'll apply this series, thanks for taking me through your

Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-19 Thread Andrew Lunn
On Fri, Feb 19, 2016 at 07:29:46PM +, bryan.whiteh...@microchip.com wrote: > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Tuesday, February 16, 2016 5:16 PM > > > > You are already 1/2 way to a DSA driver, since you have a MAC driver. So i > > agree with David, do it right and add a

RE: [net-next 10/16] i40e: add check for null VSI

2016-02-19 Thread Underwood, JohnX
Sorry, folks. I was confused. The patch looked familiar, but I wasn't able to find the email where I originally sent it out. -Original Message- From: Kirsher, Jeffrey T Sent: Friday, February 19, 2016 11:49 AM To: David Miller; Underwood, JohnX Cc: netdev@vger.kernel.org;

Re: [net-next 10/16] i40e: add check for null VSI

2016-02-19 Thread Jeff Kirsher
On Fri, 2016-02-19 at 14:41 -0500, David Miller wrote: > From: "Underwood, JohnX" > Date: Fri, 19 Feb 2016 19:15:53 + > > > ACK > > You should never top-post on this mailing list. > > But in this specific case it is even more important. > > So just in case it is

Re: [PATCH v2] bpf: grab rcu read lock for bpf_percpu_hash_update

2016-02-19 Thread David Miller
From: Sasha Levin Date: Fri, 19 Feb 2016 13:53:10 -0500 > bpf_percpu_hash_update() expects rcu lock to be held and warns if it's not, > which pointed out a missing rcu read lock. > > Fixes: 15a07b338 ("bpf: add lookup/update support for per-cpu hash and array > maps") >

Re: [net-next 10/16] i40e: add check for null VSI

2016-02-19 Thread David Miller
From: "Underwood, JohnX" Date: Fri, 19 Feb 2016 19:15:53 + > ACK You should never top-post on this mailing list. But in this specific case it is even more important. So just in case it is not clear: Please, pretty please, DO NOT top-post ACKs to patches

RE: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-19 Thread Bryan.Whitehead
> From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Tuesday, February 16, 2016 5:16 PM > > You are already 1/2 way to a DSA driver, since you have a MAC driver. So i > agree with David, do it right and add a simple DSA driver. > Andrew, I've done a little research on DSA. I've read

[net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-19 Thread Alexander Duyck
This patch series makes it so that we enable the outer Tx checksum for IPv4 tunnels by default. This makes the behavior consistent with how we were handling this for IPv6. In addition I have updated the internal flags for these tunnels so that we use a ZERO_CSUM_TX flag for IPv4 which should

[net-next PATCH 1/2] GENEVE: Support outer IPv4 Tx checksums by default

2016-02-19 Thread Alexander Duyck
This change makes it so that if UDP CSUM is not specified we will default to enabling it. The main motivation behind this is the fact that with the use of outer checksum we can greatly improve the performance for GENEVE tunnels on hardware that doesn't know how to parse them. Signed-off-by:

[net-next PATCH 2/2] VXLAN: Support outer IPv4 Tx checksums by default

2016-02-19 Thread Alexander Duyck
This change makes it so that if UDP CSUM is not specified we will default to enabling it. The main motivation behind this is the fact that with the use of outer checksum we can greatly improve the performance for VXLAN tunnels on devices that don't know how to parse tunnel headers.

[PATCH net] Driver: Vmxnet3: Update Rx ring 2 max size

2016-02-19 Thread Shrikrishna Khare
Device emulation supports max size of 4096. Signed-off-by: Shrikrishna Khare Signed-off-by: Bhavesh Davda --- drivers/net/vmxnet3/vmxnet3_defs.h | 2 +- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

RE: [net-next 10/16] i40e: add check for null VSI

2016-02-19 Thread Underwood, JohnX
ACK -Original Message- From: Kirsher, Jeffrey T Sent: Friday, February 19, 2016 1:54 AM To: da...@davemloft.net Cc: Underwood, JohnX; netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; jogre...@redhat.com; Kirsher, Jeffrey T Subject: [net-next 10/16] i40e: add check for

Re: [PATCH v2] bpf: grab rcu read lock for bpf_percpu_hash_update

2016-02-19 Thread Daniel Borkmann
On 02/19/2016 07:53 PM, Sasha Levin wrote: bpf_percpu_hash_update() expects rcu lock to be held and warns if it's not, which pointed out a missing rcu read lock. Fixes: 15a07b338 ("bpf: add lookup/update support for per-cpu hash and array maps") Signed-off-by: Sasha Levin

Re: [PATCH v2] bpf: grab rcu read lock for bpf_percpu_hash_update

2016-02-19 Thread Alexei Starovoitov
On Fri, Feb 19, 2016 at 01:53:10PM -0500, Sasha Levin wrote: > bpf_percpu_hash_update() expects rcu lock to be held and warns if it's not, > which pointed out a missing rcu read lock. > > Fixes: 15a07b338 ("bpf: add lookup/update support for per-cpu hash and array > maps") > Signed-off-by: Sasha

  1   2   >