Re: [net-next PATCH V3 1/3] net: adjust napi_consume_skb to handle none-NAPI callers

2016-03-10 Thread Jesper Dangaard Brouer
On Thu, 10 Mar 2016 20:21:55 +0300 Sergei Shtylyov wrote: > > --- a/net/core/skbuff.c > > +++ b/net/core/skbuff.c > > @@ -801,9 +801,9 @@ void napi_consume_skb(struct sk_buff *skb, int budget) > > if (unlikely(!skb)) > > return; > > > > - /* if budget is 0 assume netpoll w/ IRQ

[PATCHv2 (net.git) 1/2] Revert "stmmac: Fix 'eth0: No PHY found' regression"

2016-03-10 Thread Giuseppe Cavallaro
This reverts commit 88f8b1bb41c6208f81b6a480244533ded7b59493. due to problems on GeekBox and Banana Pi M1 board when connected to a real transceiver instead of a switch via fixed-link. Signed-off-by: Giuseppe Cavallaro Cc: Gabriel Fernandez Cc: Andreas Färber Cc: Frank Schäfer Cc: Dinh Nguyen

[PATCHv2 (net.git) 2/2] stmmac: fix MDIO settings

2016-03-10 Thread Giuseppe Cavallaro
Initially the phy_bus_name was added to manipulate the driver name but It was recently just used to manage the fixed-link and then to take some decision at run-time inside the main (for example to skip EEE). So the patch uses the is_pseudo_fixed_link and removes removes the phy_bus_name variable no

[PATCHv2 (net.git) 0/2] stmmac: MDIO fixes

2016-03-10 Thread Giuseppe Cavallaro
These two patches are to fix the recent regressions raised when test the stmmac on some platforms due to broken MDIO management. V2: use is_pseudo_fixed_link Giuseppe Cavallaro (2): Revert "stmmac: Fix 'eth0: No PHY found' regression" stmmac: fix MDIO settings drivers/net/ethernet/stmicro/s

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-10 Thread Ramesh Shanmugasundaram
Hi Oliver, Marc, > On 03/08/2016 01:48 PM, Ramesh Shanmugasundaram wrote: > > >> In fact you provided a CAN driver which is "CAN-FD-only". > > > > Yes. That's the status of current submission. (...) > > > > I did try this option earlier but there are two problems with this > method. > > > > 1)

RE: [PATCH net v2 0/2] qlcnic fixes

2016-03-10 Thread Rajesh Borundia
>-Original Message- >From: David Miller [mailto:da...@davemloft.net] >Sent: Friday, March 11, 2016 2:47 AM >To: Rajesh Borundia >Cc: netdev ; Dept-GE Linux NIC Dev gelinuxnic...@qlogic.com> >Subject: Re: [PATCH net v2 0/2] qlcnic fixes > >From: Rajesh Borundia >Date: Tue, 8 Mar 2016 02:39

[PATCH] kcm: fix variable type

2016-03-10 Thread Andrzej Hajda
Function skb_splice_bits can return negative values, its result should be assigned to signed variable to allow correct error checking. The problem has been detected using patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. Signed-off-by: Andrzej Hajda --- net/kcm/kcmsock.c | 2 +- 1

[PATCH net v2] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

2016-03-10 Thread Chunhao Lin
For pcie nic, after setting link speed and there is no link driver does not need to do phy reset until link up. For some pcie nics, to do this will also reset phy speed down counter and prevent phy from auto speed down. This patch fix the issue reported in following link. https://bugs.launchpad.

[PATCH v3 net-next 1/2] net: hns: fix return value of the function about rss

2016-03-10 Thread Kejian Yan
Both .get_rxfh and .get_rxfh are always return 0, it should return result from hardware when getting or setting rss. And the rss function should return the correct data type. Signed-off-by: Kejian Yan --- change log: PATCH v3: - This patch removes unused variable 'ret' to fix the build warning

[PATCH v3 net-next 0/2] net: hns: get and set RSS indirection table by using ethtool

2016-03-10 Thread Kejian Yan
When we use ethtool to retrieves or configure the receive flow hash indirection table, ethtool needs to call .get_rxnfc to get the ring number so this patchset implements the .get_rxnfc and fixes the bug that we can not get the tatal table each time. --- change log: PATCH v3: - This patchset fix

[PATCH v3 net-next 2/2] net: hns: fixes a bug of RSS

2016-03-10 Thread Kejian Yan
If trying to get receive flow hash indirection table by ethtool, it needs to call .get_rxnfc to get ring number first. So this patch implements the .get_rxnfc of ethtool. And the data type of rss_indir_table is u32, it has to be multiply by the width of data type when using memcpy. Signed-off-by:

Re: [V9fs-developer] [PATCH] net/9p: convert to new CQ API

2016-03-10 Thread Doug Ledford
On 03/08/2016 09:38 AM, Dominique Martinet wrote: > Christoph Hellwig wrote on Thu, Mar 03, 2016: >> New version with the nits fixed below. Now that checkpath started >> a stupid warning about not using tabs for indentation which I've >> ignored here and will take up in my usual fights against Joe

Re: [ovs-dev] [PATCH v2 net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-10 Thread pravin shelar
On Thu, Mar 10, 2016 at 8:14 AM, Samuel Gauthier wrote: > When we want to change a flow using netlink, we have to identify it to > be able to perform a lookup. Both the flow key and unique flow ID > (ufid) are valid identifiers, but we always have to specify the flow > key in the netlink message.

[net-next:master 1158/1168] net/sched/cls_flower.c:222:28: warning: cast from pointer to integer of different size

2016-03-10 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: e8ab563f4b2e51849a16d962c6235b81e429c0d7 commit: 5b33f48842fa1e13e9c0ea8cc59c1d0df19042db [1158/1168] net/flower: Introduce hardware offload support config: i386-randconfig-r0-201610 (attached as .config) re

Re: [PATCH net 4/6] net: hns: adds uc match for debug port

2016-03-10 Thread Daode Huang
On 2016/3/4 21:39, Sergei Shtylyov wrote: On 3/4/2016 4:09 AM, Daode Huang wrote: This patch adds uc match for debug port by: 1)Enables uc match of debug port when initializing gmac 2)Enables uc match of mac address register2 Signed-off-by: Daode Huang Signed-off-by: lipeng Lipeng is his

Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt

2016-03-10 Thread Daode Huang
On 2016/3/4 21:37, Sergei Shtylyov wrote: Hello. On 3/4/2016 4:09 AM, Daode Huang wrote: In V2 chip, when sending mamagement packets, the driver should config the port id to BD descs. Signed-off-by: Daode Huang Signed-off-by: Lisheng --- drivers/net/ethernet/hisilicon/hns/hnae.h

Re: [PATCH v2 net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-10 Thread Simon Horman
On Thu, Mar 10, 2016 at 05:14:59PM +0100, Samuel Gauthier wrote: > When we want to change a flow using netlink, we have to identify it to > be able to perform a lookup. Both the flow key and unique flow ID > (ufid) are valid identifiers, but we always have to specify the flow > key in the netlink m

Re: [PATCH net-next v5] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-10 Thread Eric Dumazet
On Thu, Mar 10, 2016 at 10:46 AM, Martin KaFai Lau wrote: > Per RFC4898, they count segments sent/received > containing a positive length data segment (that includes > retransmission segments carrying data). Unlike > tcpi_segs_out/in, tcpi_data_segs_out/in excludes segments > carrying no data (e.

Re: [PATCH nf-next v10 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Joe Stringer
On 11 March 2016 at 07:54, Jarno Rajahalme wrote: > Extend OVS conntrack interface to cover NAT. New nested > OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. > A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. > If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST i

Re: Micrel Phy - Is there a way to configure the Phy not to do 802.3x flow control?

2016-03-10 Thread Murali Karicheri
On 03/10/2016 02:38 PM, Murali Karicheri wrote: > On 03/10/2016 01:05 PM, Florian Fainelli wrote: >> On 10/03/16 08:48, Murali Karicheri wrote: >>> On 03/03/2016 07:16 PM, Florian Fainelli wrote: On 03/03/16 14:18, Murali Karicheri wrote: > Hi, > > We are using Micrel Phy in one of

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread Cyrill Gorcunov
On Thu, Mar 10, 2016 at 05:36:30PM -0500, David Miller wrote: > > > > Works like a charm! So David, what are the next steps then? > > Mind to gather all your patches into one (maybe)? > > I'll re-review all of the changes tomorrow and also look into ipv6 > masq, to see if it needs the same treatm

Re: [PATCH 0/2] sh_eth: fix couple of bugs in sh_eth_ring_format()

2016-03-10 Thread David Miller
From: Sergei Shtylyov Date: Fri, 11 Mar 2016 01:01:22 +0300 > On 03/11/2016 12:07 AM, David Miller wrote: > >>> Here's a set of 2 patches against DaveM's 'net.git' repo fixing two >>> bugs >>> in sh_eth_.ring_format()... >>> >>> [1/2] sh_eth: fix NULL pointer dereference in sh_eth_ring_f

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread David Miller
From: Cyrill Gorcunov Date: Fri, 11 Mar 2016 00:59:59 +0300 > On Fri, Mar 11, 2016 at 12:19:45AM +0300, Cyrill Gorcunov wrote: >> > >> > Oh yes they do, from masq's non-inet notifier. masq registers two >> > notifiers, one for generic netdev and one for inetdev. >> >> Thanks a huge David! I'll

Re: [PATCH nf-next v10 7/8] openvswitch: Delay conntrack helper call for new connections.

2016-03-10 Thread Jarno Rajahalme
Thanks for the reviews, Joe! Now we have acks for the patches 3-8, but not for 1 and 2 that touch netfilter proper. Who could review those? Jarno > On Mar 10, 2016, at 2:01 PM, Joe Stringer wrote: > > On 11 March 2016 at 07:54, Jarno Rajahalme wrote: >> There is no need to help connections

[patch net-next] mlxsw: pci: Implement reset done check

2016-03-10 Thread Jiri Pirko
From: Jiri Pirko Firmware now tells us that the reset is done by passing a magic value via register. Use it to shorten the wait in case this is supported. With old firmware, we still wait until the timeout is reached. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/pci.c | 15

Re: [PATCH nf-next v10 3/8] openvswitch: Add commentary to conntrack.c

2016-03-10 Thread Joe Stringer
On 11 March 2016 at 07:54, Jarno Rajahalme wrote: > This makes the code easier to understand and the following patches > more focused. > > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer

Re: [PATCH 0/2] sh_eth: fix couple of bugs in sh_eth_ring_format()

2016-03-10 Thread Sergei Shtylyov
On 03/11/2016 12:07 AM, David Miller wrote: Here's a set of 2 patches against DaveM's 'net.git' repo fixing two bugs in sh_eth_.ring_format()... [1/2] sh_eth: fix NULL pointer dereference in sh_eth_ring_format() [2/2] sh_eth: advance 'rxdesc' later in sh_eth_ring_format() Since Linus is l

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread Cyrill Gorcunov
On Fri, Mar 11, 2016 at 12:19:45AM +0300, Cyrill Gorcunov wrote: > > > > Oh yes they do, from masq's non-inet notifier. masq registers two > > notifiers, one for generic netdev and one for inetdev. > > Thanks a huge David! I'll test it just to be sure. Works like a charm! So David, what are the

Re: [PATCH nf-next v10 7/8] openvswitch: Delay conntrack helper call for new connections.

2016-03-10 Thread Joe Stringer
On 11 March 2016 at 07:54, Jarno Rajahalme wrote: > There is no need to help connections that are not confirmed, so we can > delay helping new connections to the time when they are confirmed. > This change is needed for NAT support, and having this as a separate > patch will make the following NAT

Re: [PATCH 1/3] dm9601: enable EP3 interrupt

2016-03-10 Thread Peter Korsgaard
> "Joseph" == Joseph CHANG writes: > Enable chip's EP3 interrupt to get the link-up notify soon > immediately. Sorry, what do you mean about 'soon immediately'? > + > +/* Always return 8-bytes data to host per interrupt-interval */ > +dm_write_reg(dev, DM_USB_CT

[PATCH] sctp: allow sctp_transmit_packet and others to use gfp

2016-03-10 Thread Marcelo Ricardo Leitner
Currently sctp_sendmsg() triggers some calls that will allocate memory with GFP_ATOMIC even when not necessary. In the case of sctp_packet_transmit it will allocate a linear skb that will be used to construct the packet and this may cause sends to fail due to ENOMEM more often than anticipated spec

Re: [PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing

2016-03-10 Thread Cong Wang
On Thu, Mar 10, 2016 at 1:47 AM, Nicolas Dichtel wrote: > Le 09/03/2016 22:49, Mahesh Bandewar a écrit : >> >> From: Mahesh Bandewar >> >> One of the major request (for enhancement) that I have received >> from various users of IPvlan in L3 mode is its inability to handle >> IPtables. >> >> While

Re: [PATCH net-next V3 00/10] cls_flower hardware offload support

2016-03-10 Thread David Miller
From: Amir Vadai Date: Tue, 8 Mar 2016 12:42:28 +0200 > Please see changes from V2 at the bottom. > > This patchset introduces cls_flower hardware offload support over ConnectX-4 > driver, more hardware vendors are welcome to use it too. ... Series applied, thanks for retaining detailed chang

Re: [PATCH V5 0/4] net-next: mediatek: add ethernet driver

2016-03-10 Thread David Miller
From: John Crispin Date: Tue, 8 Mar 2016 11:29:53 +0100 > This series adds support for the Mediatek ethernet core found on current ARM > based SoCs. The driver works on MT2701 and MT7623 SoCs > > Instead of trying to upstream everything at once I decided to concentrate on > the important parts

Re: [PATCH] net: dsa: Fix cleanup resources upon module removal

2016-03-10 Thread David Miller
From: Neil Armstrong Date: Tue, 8 Mar 2016 10:36:20 +0100 > The initial commit badly merged into the dsa_resume method instead > of the dsa_remove_dst method. > As consequence, the dst->master_netdev->dsa_ptr is not set to NULL on > removal and re-bind of the dsa device fails with error -17. >

Re: [PATCH net-next] net: dsa: mv88e6xxx: rework port state setter

2016-03-10 Thread David Miller
From: Vivien Didelot Date: Mon, 7 Mar 2016 18:24:17 -0500 > Apply a few non-functional changes on the port state setter: > > * add a dynamic debug message with state names to track changes > * explicit states checking instead of assuming their numeric values > * lock mutex only once when

Re: [PATCH net-next] net: dsa: mv88e6xxx: avoid writing the same mode

2016-03-10 Thread David Miller
From: Vivien Didelot Date: Mon, 7 Mar 2016 18:24:52 -0500 > There is no need to change the 802.1Q port mode for the same value. > Thus avoid such message: > > [ 401.954836] dsa dsa@0 lan0: 802.1Q Mode: Disabled (was Disabled) > > Signed-off-by: Vivien Didelot Applied.

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread Cyrill Gorcunov
On Thu, Mar 10, 2016 at 04:05:21PM -0500, David Miller wrote: > > > > and nobody calls for nf_ct_iterate_cleanup, no? > > Oh yes they do, from masq's non-inet notifier. masq registers two > notifiers, one for generic netdev and one for inetdev. Thanks a huge David! I'll test it just to be sure.

Re: [PATCH net-next 1/1] qede: Fix net-next "make ARCH=x86_64"

2016-03-10 Thread David Miller
From: Manish Chopra Date: Tue, 8 Mar 2016 04:09:44 -0500 > 'commit 55482edc25f0606851de42e73618f813f310d009 > ("qede: Add slowpath/fastpath support and enable hardware GRO")' > introduces below error when compiling net-next with "make ARCH=x86_64" > > drivers/built-in.o: In function `qede_rx_int

Re: [PATCH net] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

2016-03-10 Thread David Miller
From: Chunhao Lin Date: Tue, 8 Mar 2016 16:51:05 +0800 > For pcie nic, after setting link speed and thers is no link driver does not > need > to do phy reset untill link up. "there's", "until" > For some pcie nics, to do this will also reset phy speed down counter and > prevent > phy from au

Re: [net-next] arp: add macro to get drop_gratuitous_arp setting

2016-03-10 Thread David Miller
From: Zhang Shengju Date: Tue, 8 Mar 2016 07:53:50 + > Add macro IN_DEV_DROP_GRATUITOUS_ARP to facilitate getting > drop_gratuitous_arp value. > > Signed-off-by: Zhang Shengju As it's used in one location, I see zero value in this, sorry. I'm not applying this patch.

Re: [PATCH net v2 0/2] qlcnic fixes

2016-03-10 Thread David Miller
From: Rajesh Borundia Date: Tue, 8 Mar 2016 02:39:56 -0500 > This series adds following fixes. > > o While processing mailbox if driver gets a spurious mailbox > interrupt it leads into premature completion of a next > mailbox request. Added a guard against this by checking current > state

Re: [PATCH] include/net/inet_connection_sock.h: Use pr_devel() instead of pr_debug()

2016-03-10 Thread David Miller
From: Nick Wang Date: Tue, 8 Mar 2016 13:52:28 +0800 > File "inet_connection_sock.h" is a common share header that not can > be use for one module, so use pr_devel instead of pr_debug is OK. Not really, we only want these printks to do anything only when debug printk's are enabled. We don't w

Re: [PATCH net-next 0/4] cxgb4vf: Interrupt and queue configuration changes

2016-03-10 Thread David Miller
From: Hariprasad Shenai Date: Tue, 8 Mar 2016 10:50:16 +0530 > This series fixes some issues and some changes in the queue and interrupt > configuration for cxgb4vf driver. We need to enable interrupts before we > register our network device, so that we don't loose link up interrupts. > Allocate

Re: [PATCH net-next] net: dsa: mv88e6xxx: read then write PVID

2016-03-10 Thread David Miller
From: Vivien Didelot Date: Mon, 7 Mar 2016 18:24:39 -0500 > The port register 0x07 contains more options than just the default VID, > even though they are not used yet. So prefer a read then write operation > over a direct write. > > This also allows to keep track of the change through dynamic

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread Cong Wang
On Thu, Mar 10, 2016 at 11:55 AM, David Miller wrote: > Indeed, good catch. Therefore: > > 1) Keep the masq netdev notifier. That will flush the conntrack table >for the inetdev_destroy event. > > 2) Make the inetdev notifier only do something if inetdev->dead is >false. (ie. we are flu

Re: [PATCH 0/2] sh_eth: fix couple of bugs in sh_eth_ring_format()

2016-03-10 Thread David Miller
From: Sergei Shtylyov Date: Tue, 08 Mar 2016 01:33:38 +0300 >Here's a set of 2 patches against DaveM's 'net.git' repo fixing two bugs > in sh_eth_.ring_format()... > > [1/2] sh_eth: fix NULL pointer dereference in sh_eth_ring_format() > [2/2] sh_eth: advance 'rxdesc' later in sh_eth_ring_for

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread David Miller
From: Cyrill Gorcunov Date: Thu, 10 Mar 2016 23:13:51 +0300 > On Thu, Mar 10, 2016 at 03:03:11PM -0500, David Miller wrote: >> From: Cyrill Gorcunov >> Date: Thu, 10 Mar 2016 23:01:34 +0300 >> >> > On Thu, Mar 10, 2016 at 02:55:43PM -0500, David Miller wrote: >> >> > >> >> > Hmm, but inetdev_d

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread Cyrill Gorcunov
On Thu, Mar 10, 2016 at 11:13:51PM +0300, Cyrill Gorcunov wrote: > > > > Both notifiers are run in the inetdev_destroy() case. > > > > Maybe that's what you are missing. > > No :) Look, here is what I mean. Previously with your two patches > we've been calling nf-cleanup for every address, so we

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread Cyrill Gorcunov
On Thu, Mar 10, 2016 at 03:03:11PM -0500, David Miller wrote: > From: Cyrill Gorcunov > Date: Thu, 10 Mar 2016 23:01:34 +0300 > > > On Thu, Mar 10, 2016 at 02:55:43PM -0500, David Miller wrote: > >> > > >> > Hmm, but inetdev_destroy() is only called when NETDEV_UNREGISTER > >> > is happening and

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread David Miller
From: Cyrill Gorcunov Date: Thu, 10 Mar 2016 23:01:34 +0300 > On Thu, Mar 10, 2016 at 02:55:43PM -0500, David Miller wrote: >> > >> > Hmm, but inetdev_destroy() is only called when NETDEV_UNREGISTER >> > is happening and masq already registers a netdev notifier... >> >> Indeed, good catch. The

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread Cyrill Gorcunov
On Thu, Mar 10, 2016 at 02:55:43PM -0500, David Miller wrote: > > > > Hmm, but inetdev_destroy() is only called when NETDEV_UNREGISTER > > is happening and masq already registers a netdev notifier... > > Indeed, good catch. Therefore: > > 1) Keep the masq netdev notifier. That will flush the c

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread David Miller
From: Cong Wang Date: Thu, 10 Mar 2016 11:02:28 -0800 > On Thu, Mar 10, 2016 at 10:01 AM, David Miller wrote: >> I'm tempted to say that we should provide these notifier handlers with >> the information they need, explicitly, to handle this case. >> >> Most intdev notifiers actually want to know

Re: [PATCH] kcm: mark helper functions inline

2016-03-10 Thread David Miller
From: Arnd Bergmann Date: Thu, 10 Mar 2016 19:31:12 +0100 > The stub helper functions for the newly added kcm_proc_init/exit interfaces > are defined as 'static' in a header file, which leads to build warnings for > each file that includes them without calling them: > > include/net/kcm.h:183:12:

Re: [PATCH 1/2] net: thunderx: Set recevie buffer page usage count in bulk

2016-03-10 Thread David Miller
From: Sunil Kovvuri Date: Thu, 10 Mar 2016 23:57:48 +0530 > Difference between NIU driver and this patch is there it's > calculate split count, increment page count and then divide page into > buffers. Here it's divide page into buffers, have a counter which increments > at every split and then a

Re: Micrel Phy - Is there a way to configure the Phy not to do 802.3x flow control?

2016-03-10 Thread Murali Karicheri
On 03/10/2016 01:05 PM, Florian Fainelli wrote: > On 10/03/16 08:48, Murali Karicheri wrote: >> On 03/03/2016 07:16 PM, Florian Fainelli wrote: >>> On 03/03/16 14:18, Murali Karicheri wrote: Hi, We are using Micrel Phy in one of our board and wondering if we can force the

Re: net: use-after-free in recvmmsg

2016-03-10 Thread Arnaldo Carvalho de Melo
Em Thu, Mar 10, 2016 at 07:35:57PM +0100, Dmitry Vyukov escreveu: > On Tue, Jan 26, 2016 at 8:30 PM, Arnaldo Carvalho de Melo > wrote: > > Em Tue, Jan 26, 2016 at 08:27:48PM +0100, Dmitry Vyukov escreveu: > >> On Fri, Jan 22, 2016 at 10:16 PM, Arnaldo Carvalho de Melo > >> wrote: > >> > Em Fri,

Re:Money Clips

2016-03-10 Thread Tom
Dear Sir or Madam We have some stock of items. if you are retailer that will be good for you. No MOQ demand. prompt shipment. If you are interested pls do feel free to contact us Best whishes Tom

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread Cong Wang
On Thu, Mar 10, 2016 at 10:01 AM, David Miller wrote: > I'm tempted to say that we should provide these notifier handlers with > the information they need, explicitly, to handle this case. > > Most intdev notifiers actually want to know the individual addresses > that get removed, one by one. Tha

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

2016-03-10 Thread Dave Taht
>> regular fq_codel uses 1024 and there has not been much reason to >> change it. In the case of an AP which has more limited memory, 256 or >> 1024 would be a good setting, per station. I'd stick to 1024 for now. > > Do note that the 4096 is shared _across_ station-tid queues. It is not > per-stat

Re: [RFC -next 2/2] virtio_net: Read and use the advised MTU

2016-03-10 Thread Sergei Shtylyov
Hello. On 03/10/2016 05:28 PM, Aaron Conole wrote: This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it exists, read the advised MTU and use it. No proper error handling is provided for the case where a user changes the negotiated MTU. A future commit will add proper error

Re: [PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Jarno Rajahalme
Thanks for the reviews Joe! Comments below. > On Mar 9, 2016, at 7:47 PM, Joe Stringer wrote: > > Hi Jarno, > > Thanks for working on this. Mostly just a few style things around #ifdefs > below. > > On 9 March 2016 at 15:10, Jarno Rajahalme wrote: >> Extend OVS conntrack interface to cover N

[PATCH nf-next v10 6/8] openvswitch: Handle NF_REPEAT in conntrack action.

2016-03-10 Thread Jarno Rajahalme
Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --g

[PATCH nf-next v10 7/8] openvswitch: Delay conntrack helper call for new connections.

2016-03-10 Thread Jarno Rajahalme
There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno Rajaha

[PATCH nf-next v10 2/8] netfilter: Allow calling into nat helper without skb_dst.

2016-03-10 Thread Jarno Rajahalme
NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem for a later patch in the series ("openvswitch: Interface with NAT."). Simplify this by removing the check on skb_dst, as the checksum will be dealt with later in the stack. Suggested-by: Pravin Shelar Signed-of

[PATCH nf-next v10 3/8] openvswitch: Add commentary to conntrack.c

2016-03-10 Thread Jarno Rajahalme
This makes the code easier to understand and the following patches more focused. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c inde

[PATCH nf-next v10 4/8] openvswitch: Update the CT state key only after nf_conntrack_in().

2016-03-10 Thread Jarno Rajahalme
Only a successful nf_conntrack_in() call can effect a connection state change, so it suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer --- net/openvswitch/conntrack.c | 7 +

[PATCH nf-next v10 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new (non-committed

[PATCH nf-next v10 0/8] openvswitch: NAT support

2016-03-10 Thread Jarno Rajahalme
This series adds NAT support to openvswitch kernel module. A few changes are needed to the netfilter code to facilitate this (patches 1-2/8). Patches 3-7 make the openvswitch kernel module ready for the patch 8 that adds the NAT support by calling into netfilter NAT code from the openvswitch conn

[PATCH nf-next v10 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2016-03-10 Thread Jarno Rajahalme
Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +--- net/openvswitch/conntrack.c

[PATCH nf-next v10 5/8] openvswitch: Find existing conntrack entry after upcall.

2016-03-10 Thread Jarno Rajahalme
Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which this packet was already applied to. This is only to be called when there is evidence that the packet was already tracked and committed, but we lost the ct reference due to an userspace upcall. ovs_ct_find_exis

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread Cyrill Gorcunov
On Thu, Mar 10, 2016 at 01:01:38PM -0500, David Miller wrote: > From: Cyrill Gorcunov > Date: Thu, 10 Mar 2016 18:09:20 +0300 > > > On Thu, Mar 10, 2016 at 02:03:24PM +0300, Cyrill Gorcunov wrote: > >> On Thu, Mar 10, 2016 at 01:20:18PM +0300, Cyrill Gorcunov wrote: > >> > On Thu, Mar 10, 2016 at

[PATCH net-next v5] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-10 Thread Martin KaFai Lau
Per RFC4898, they count segments sent/received containing a positive length data segment (that includes retransmission segments carrying data). Unlike tcpi_segs_out/in, tcpi_data_segs_out/in excludes segments carrying no data (e.g. pure ack). The patch also updates the segs_in in tcp_fastopen_add

Re: [PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Jarno Rajahalme
> On Mar 10, 2016, at 4:00 AM, Thomas Graf wrote: > > On 03/09/16 at 07:47pm, Joe Stringer wrote: >> On 9 March 2016 at 15:10, Jarno Rajahalme wrote: >>> Extend OVS conntrack interface to cover NAT. New nested >>> OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. >>> A bar

Re: [PATCH nf-next v8 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2016-03-10 Thread Jarno Rajahalme
Thanks for pointing this out, v10, which hope is the final version, will have the cover letter back. Jarno > On Mar 10, 2016, at 1:16 AM, Or Gerlitz wrote: > > On Wed, Mar 9, 2016 at 2:24 AM, Jarno Rajahalme wrote: >> Remove the definition of IP_CT_NEW_REPLY from the kernel as it does >> no

Re: [PATCH 2/3] dm9601: manage eeprom to assure the chip for correct operation

2016-03-10 Thread Peter Korsgaard
> "Joseph" == Joseph CHANG writes: > Add to maintain variant eeprom adapters which may have not right > dm962x's format. > Signed-off-by: Joseph CHANG > +static void dm_render_begin(struct usbnet *dev) > +{ > +/* Render eeprom if need, WORD3 render, set D[15:14] 01b */ > +dm_

Re: net: use-after-free in recvmmsg

2016-03-10 Thread Dmitry Vyukov
On Tue, Jan 26, 2016 at 8:30 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 26, 2016 at 08:27:48PM +0100, Dmitry Vyukov escreveu: >> On Fri, Jan 22, 2016 at 10:16 PM, Arnaldo Carvalho de Melo >> wrote: >> > Em Fri, Jan 22, 2016 at 09:39:53PM +0100, Dmitry Vyukov escreveu: >> >> I am on commit

[PATCH] kcm: mark helper functions inline

2016-03-10 Thread Arnd Bergmann
The stub helper functions for the newly added kcm_proc_init/exit interfaces are defined as 'static' in a header file, which leads to build warnings for each file that includes them without calling them: include/net/kcm.h:183:12: error: 'kcm_proc_init' defined but not used [-Werror=unused-function

Re: [PATCH 1/2] net: thunderx: Set recevie buffer page usage count in bulk

2016-03-10 Thread Sunil Kovvuri
> > So calculate the modulus on the page split count and optimize the > increment ahead of time when possible, and for the sub page split > pieces do it one at a time. > Patch does almost the same with a negligible overhead of a counter for page->_count increment at a later time but still before HW

Re: Micrel Phy - Is there a way to configure the Phy not to do 802.3x flow control?

2016-03-10 Thread Florian Fainelli
On 10/03/16 08:48, Murali Karicheri wrote: > On 03/03/2016 07:16 PM, Florian Fainelli wrote: >> On 03/03/16 14:18, Murali Karicheri wrote: >>> Hi, >>> >>> We are using Micrel Phy in one of our board and wondering if we can force >>> the >>> Phy to disable flow control at start. I have a 1G etherne

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-10 Thread David Miller
From: Cyrill Gorcunov Date: Thu, 10 Mar 2016 18:09:20 +0300 > On Thu, Mar 10, 2016 at 02:03:24PM +0300, Cyrill Gorcunov wrote: >> On Thu, Mar 10, 2016 at 01:20:18PM +0300, Cyrill Gorcunov wrote: >> > On Thu, Mar 10, 2016 at 12:16:29AM +0300, Cyrill Gorcunov wrote: >> > > >> > > Thanks for explan

Re: [PATCH net-next v4] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-10 Thread Martin KaFai Lau
On Thu, Mar 10, 2016 at 09:43:18AM -0800, Eric Dumazet wrote: > On Thu, Mar 10, 2016 at 9:39 AM, Eric Dumazet wrote: > > On Thu, Mar 10, 2016 at 9:29 AM, Martin KaFai Lau wrote: > >> Per RFC4898, they count segments sent/received > >> containing a positive length data segment (that includes > >>

Re: [PATCH] b43: fix memory leak

2016-03-10 Thread Sudip Mukherjee
On Thursday 10 March 2016 11:13 PM, Michael Büsch wrote: On Fri, 19 Feb 2016 20:37:18 +0530 Sudip Mukherjee wrote: https://patchwork.kernel.org/patch/8049041/ I have an old laptop running on 800Mhz CPU. It has "Broadcom BCM4311 [14e4:4311] (rev 01)". I will try to test it on this weekend.

Re: [PATCH v2] phy: remove documentation of removed members of phy_device structure

2016-03-10 Thread Florian Fainelli
On 10/03/16 04:58, LABBE Corentin wrote: > Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed addr, > bus and dev member of the phy_device structure. > This patch remove the documentation about those members. > > Signed-off-by: LABBE Corentin Acked-by: Florian Fainelli -- Floria

Re: [PATCH 1/2] net: thunderx: Set recevie buffer page usage count in bulk

2016-03-10 Thread David Miller
From: Sunil Kovvuri Date: Thu, 10 Mar 2016 16:13:28 +0530 > Hi David, > > >>> So if you know ahead of time how the page will be split up, just >>> calculate that when you get the page and increment the page count >>> appropriately. >>> >>> That's what we do in the NIU driver. >> >> Thanks for t

Re: [PATCH] b43: fix memory leak

2016-03-10 Thread Michael Büsch
On Fri, 19 Feb 2016 20:37:18 +0530 Sudip Mukherjee wrote: > > https://patchwork.kernel.org/patch/8049041/ > > I have an old laptop running on 800Mhz CPU. It has "Broadcom BCM4311 > [14e4:4311] (rev 01)". > I will try to test it on this weekend. Any news on this one? -- Michael pgpLl72Z3

Re: [PATCH net-next v4] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-10 Thread Eric Dumazet
On Thu, Mar 10, 2016 at 9:39 AM, Eric Dumazet wrote: > On Thu, Mar 10, 2016 at 9:29 AM, Martin KaFai Lau wrote: >> Per RFC4898, they count segments sent/received >> containing a positive length data segment (that includes >> retransmission segments carrying data). Unlike >> tcpi_segs_out/in, tcp

Re: pull-request: can-next 2016-03-10,pull-request: can-next 2016-03-10

2016-03-10 Thread David Miller
From: Marc Kleine-Budde Date: Thu, 10 Mar 2016 10:33:28 +0100 > this is a pull request of 5 patch for net-next/master. > > Marek Vasut contributes 4 patches for the ifi CAN driver, which makes > it work on real hardware. There is one patch by Ramesh Shanmugasundaram > for the rcar_can driver tha

Re: [PATCH net-next v4] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-10 Thread Eric Dumazet
On Thu, Mar 10, 2016 at 9:29 AM, Martin KaFai Lau wrote: > Per RFC4898, they count segments sent/received > containing a positive length data segment (that includes > retransmission segments carrying data). Unlike > tcpi_segs_out/in, tcpi_data_segs_out/in excludes segments > carrying no data (e.g

Re: [PATCH net-next v4] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-10 Thread Yuchung Cheng
On Thu, Mar 10, 2016 at 9:29 AM, Martin KaFai Lau wrote: > Per RFC4898, they count segments sent/received > containing a positive length data segment (that includes > retransmission segments carrying data). Unlike > tcpi_segs_out/in, tcpi_data_segs_out/in excludes segments > carrying no data (e.g

[PATCH net-next v4] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-10 Thread Martin KaFai Lau
Per RFC4898, they count segments sent/received containing a positive length data segment (that includes retransmission segments carrying data). Unlike tcpi_segs_out/in, tcpi_data_segs_out/in excludes segments carrying no data (e.g. pure ack). The patch also updates the segs_in in tcp_fastopen_add

Re: [PATCH net-next 1/3] xen-netback: re-import canonical netif header

2016-03-10 Thread Wei Liu
On Thu, Mar 10, 2016 at 12:30:26PM +, Paul Durrant wrote: > The canonical netif header (in the Xen source repo) and the Linux variant > have diverged significantly. Recently much documentation has been added to > the canonical header which is highly useful for developers making > modifications

Re: [PATCH net-next 2/3] xen-netback: support multiple extra info fragments passed from frontend

2016-03-10 Thread Wei Liu
On Thu, Mar 10, 2016 at 12:30:27PM +, Paul Durrant wrote: > The code does not currently support a frontend passing multiple extra info > fragments to the backend in a tx request. The xenvif_get_extras() function > handles multiple extra_info fragments but make_tx_response() assumes there > is o

Re: [PATCH net-next 3/3] xen-netback: reduce log spam

2016-03-10 Thread Wei Liu
On Thu, Mar 10, 2016 at 12:30:28PM +, Paul Durrant wrote: > Remove the "prepare for reconnect" pr_info in xenbus.c. It's largely > uninteresting and the states of the frontend and backend can easily be > observed by watching the (o)xenstored log. > > Signed-off-by: Paul Durrant > Cc: Wei Liu

Re: [net-next PATCH V3 1/3] net: adjust napi_consume_skb to handle none-NAPI callers

2016-03-10 Thread Sergei Shtylyov
Hello. On 03/10/2016 05:59 PM, Jesper Dangaard Brouer wrote: Some drivers reuse/share code paths that free SKBs between NAPI and none-NAPI calls. Adjust napi_consume_skb to handle this use-case. Before, calls from netpoll (w/ IRQs disabled) was handled and indicated with a budget zero indicati

Re: Micrel Phy - Is there a way to configure the Phy not to do 802.3x flow control?

2016-03-10 Thread Murali Karicheri
On 03/03/2016 07:16 PM, Florian Fainelli wrote: > On 03/03/16 14:18, Murali Karicheri wrote: >> Hi, >> >> We are using Micrel Phy in one of our board and wondering if we can force the >> Phy to disable flow control at start. I have a 1G ethernet switch connected >> to Phy and the phy always enable

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

2016-03-10 Thread Dinh Nguyen
On Thu, Mar 10, 2016 at 3:13 AM, Giuseppe CAVALLARO wrote: > On 3/9/2016 5:31 PM, Dinh Nguyen wrote: >> >> On Wed, Mar 9, 2016 at 8:53 AM, Giuseppe CAVALLARO >> wrote: >>> >>> Hi Tomeu, Dinh, Andreas >>> >>> I need a sum and help from you to go ahead on the >>> tx timeout. >>> >>> The "stmmac: MD

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-10 Thread isdn
Am 10.03.2016 um 13:58 schrieb Paul Bolle: > Hi Karsten, > > On do, 2016-03-10 at 11:53 +0100, i...@linux-pingi.de wrote: >> mISDN with CAPI support works just fine with pppd and pppdcapiplugin >> and the CAPI works for all mISDN HW. > > In the mainline tree the mISDN and CAPI stacks are effectiv

Re: [PATCH] mrf24j40: fix security-enabled processing on inbound frames

2016-03-10 Thread Stefan Schmidt
Hello. On 29/02/16 20:49, Alan Ott wrote: On 02/18/2016 01:34 PM, zopieux wrote: Fix the MRF24J40 handling of security-enabled frames so it does not block upon receiving such frames. Signed-off-by: Alexander Aring Reported-by: Alexandre Macabies Tested-by: Alexandre Macabies --- When receiv

Re: [GIT PULL v2 0/4] IPVS Fixes for v4.5

2016-03-10 Thread Pablo Neira Ayuso
On Mon, Mar 07, 2016 at 12:03:30PM +0900, Simon Horman wrote: > Hi Pablo, > > please consider these IPVS fixes for v4.5 or > if it is too late please consider them for v4.6. Pulled into nf-next, thanks Simon!

  1   2   >