Re: [RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier

Hi Vivien, Sun, Mar 13, 2016 at 08:42:26AM IST, vivien.dide...@savoirfairelinux.com wrote: >Rework the netdev event handler, similar to what the Mellanox Spectrum >driver does, to eventually welcome NETDEV_PRECHANGEUPPER actions and use >netdev helpers, such as netif_is_bridge_master. >

Re: [PATCH RFC v2 00/32] Make DSA switches linux devices.

Hi Andrew, Florian, Andrew Lunn writes: > It probably means we need to turn slave.c and parts of dsa.c into a > library. Add a new dsa_v2.c file, containing the new binding > code. With things like having the switch devices instantiate there own > MDIO bus, fixed phys on a

[PATCH 3/3] libceph: use KMEM_CACHE macro

Use KMEM_CACHE() instead of kmem_cache_create() to simplify the code. Signed-off-by: Geliang Tang --- net/ceph/messenger.c | 10 ++ net/ceph/osd_client.c | 5 + 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/net/ceph/messenger.c

Re: [PATCH net-next 1/5] dsa: Rename mv88e6123_61_65 to mv88e6123 to be consistent

Andrew Lunn writes: > All the drivers support multiple chips, but mv88e6123_61_65 is the > only one that reflects this in its naming. Change it to be consistent > with the other drivers. > > Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot

Re: [RFC PATCH net-next 0/3] net: dsa: finer bridging control

Hi David, Vivien Didelot writes: > This patchset renames the bridging routines of the DSA layer, make the > unbridging routine return void, and rework the DSA netdev notifier handler, > similar to what the Mellanox Spectrum driver does. This is not an RFC,

[RFC PATCH net-next 2/3] net: dsa: make port_bridge_leave return void

netdev_upper_dev_unlink() which notifies NETDEV_CHANGEUPPER, returns void, as well as del_nbp(). So there's no advantage to catch an eventual error from the port_bridge_leave routine at the DSA level. Make this routine void for the DSA layer and its existing drivers. Signed-off-by: Vivien

[RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier

Rework the netdev event handler, similar to what the Mellanox Spectrum driver does, to eventually welcome NETDEV_PRECHANGEUPPER actions and use netdev helpers, such as netif_is_bridge_master. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 55

[RFC PATCH net-next 0/3] net: dsa: finer bridging control

This patchset renames the bridging routines of the DSA layer, make the unbridging routine return void, and rework the DSA netdev notifier handler, similar to what the Mellanox Spectrum driver does. Vivien Didelot (3): net: dsa: rename port_*_bridge routines net: dsa: make port_bridge_leave

[RFC PATCH net-next 1/3] net: dsa: rename port_*_bridge routines

Rename DSA port_join_bridge and port_leave_bridge routines to respectively port_bridge_join and port_bridge_leave in order to respect an implicit Port::Bridge namespace. Signed-off-by: Vivien Didelot --- Documentation/networking/dsa/dsa.txt | 4 ++--

Re: [PATCH 0/6] arc_emac: fixes the emac issues oand cleanup emac drivers

在 2016年03月12日 02:46, Sergei Shtylyov 写道: Hello. On 03/11/2016 05:48 PM, Caesar Wang wrote: [...] Hi Rob, David: PATCH[1/6-2/6]: > net: arc_emac: make the rockchip emac document more compatible net: arc_emac: add phy-reset-* are optional for device tree The patches change the rockchip

Re: [PATCH 3/6] net: arc_emac: support the phy reset for emac driver

Hi Sergei, 在 2016年03月12日 02:35, Sergei Shtylyov 写道: On 03/11/2016 01:55 PM, Caesar Wang wrote: This patch adds to support the emac phy reset. 1) phy-reset-gpios: The phy-reset-gpios is an optional property for arc emac device tree boot. Change the binding document to match the driver code.

Re: [PATCH 2/2] mISDN: Support DR6 indication in mISDNipac driver

Acked-by: Karsten Keil Am 13.03.2016 um 00:19 schrieb Maciej S. Szmigiero: > According to figure 39 in PEB3086 data sheet, version 1.4 this indication > replaces DR when layer 1 transition source state is F6. > > This fixes mISDN layer 1 getting stuck in F6 state in TE mode

Re: [PATCH 1/2] mISDN: Order IPAC register defines

Acked-by: Karsten Keil Am 13.03.2016 um 00:18 schrieb Maciej S. Szmigiero: > It looks like IPAC/ISAC chips register defines weren't in any particular > order. > > Order them by their number to make it easier to spot holes. > > Signed-off-by: Maciej S. Szmigiero

[PATCH] netfilter: fix race condition in ipset save and delete

netfilter: fix race condition in ipset save and delete This fix adds a new reference counter (ref_kernel) for the struct ip_set. The other reference counter (ref) is used to track references from the userspace and we need a separate counter to keep track of in-kernel references. Using the same

[PATCH net-next 2/2] ipv6: add support for stats via RTM_GETSTATS

From: Roopa Prabhu This patch is an example of adding af stats in RTM_GETSTATS. It adds a new nested IFLA_STATS_INET6 attribute for ipv6 af stats. stats attributes inside IFLA_STATS_INET6 nested attribute use the existing ipv6 stats attributes from ipv6 IFLA_PROTINFO

[PATCH net-next 0/2] rtnetlink: new message for stats

From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some cases when frequent polling for stats from

[PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some cases when frequent polling for stats from

Re: [patch net-next] rocker: move ageing_time from struct rocker to struct ofdpa

From: Jiri Pirko Date: Sat, 12 Mar 2016 12:03:27 +0100 > From: Jiri Pirko > > This is OF-DPA specific, used only there, similar to > ofdpa_port->ageing_time. So move it to OF-DPA code. > > Signed-off-by: Jiri Pirko Applied, thanks

Re: SYN flooding on port 80 + DMAR:[DMA Write] faults

Toralf Förster : > Today my server (64 bit hardened Gentoo kernel) was faced a SYN-flood attack. > I do wonder if the DMAR events points to an issue in the kernel ? Please send a compressed log including all 'fault addr' lines as well as the (module probe time) XID line

[PATCH 1/2] mISDN: Order IPAC register defines

It looks like IPAC/ISAC chips register defines weren't in any particular order. Order them by their number to make it easier to spot holes. Signed-off-by: Maciej S. Szmigiero --- drivers/isdn/hardware/mISDN/ipac.h | 40 +++--- 1 file

[PATCH 2/2] mISDN: Support DR6 indication in mISDNipac driver

According to figure 39 in PEB3086 data sheet, version 1.4 this indication replaces DR when layer 1 transition source state is F6. This fixes mISDN layer 1 getting stuck in F6 state in TE mode on Dialogic Diva 2.02 card (and possibly others) when NT deactivates it. Signed-off-by: Maciej S.

SYN flooding on port 80 + DMAR:[DMA Write] faults

Today my server (64 bit hardened Gentoo kernel) was faced a SYN-flood attack. I do wonder if the DMAR events points to an issue in the kernel ? Mar 12 21:56:51 ms-magpie kernel: [99582.831584] TCP: request_sock_TCP: Possible SYN flooding on port 80. Sending cookies. Check SNMP counters. Mar 12

[PATCH] sh_eth: kill useless initializers

Some of the local variable intializers in the driver turned out to be pointless, kill 'em. Signed-off-by: Sergei Shtylyov --- The patch is against the DaveM's 'net-next.git' repo. drivers/net/ethernet/renesas/sh_eth.c | 18 +- 1 file

[PATCH v2 3/3] of_mdio: use PTR_ERR_OR_ZERO()

PTR_ERR_OR_ZERO() is open coded in of_phy_register_fixed_link(), so just call it directly... Signed-off-by: Sergei Shtylyov Reviewed-by: Florian Fainelli Reviewed-by: Vladimir Zapolskiy --- Changes in version 2: - added

[PATCH v2 2/3] of_mdio: use IS_ERR_OR_NULL()

IS_ERR_OR_NULL() is open coded in of_mdiobus_register_phy(), so just call it directly... Signed-off-by: Sergei Shtylyov Reviewed-by: Florian Fainelli --- Changes in version 2: - removed the of_mdiobus_register_device() hunk; - added the

[PATCH v2 1/3] of_mdio: mdio_device_create() never returns NULL

mdio_device_create() never returns NULL, thus checking for it in of_mdiobus_register_device() is pointless... Suggested-by: Vladimir Zapolskiy Signed-off-by: Sergei Shtylyov --- Changes in version 2: - new patch. drivers/of/of_mdio.c |2

[PATCH v2 0/3] of_mdio: use IS_ERR_OR_NULL() and PTR_ERR_OR_ZERO()

Hello. Here's the set of 3 patches against DaveM's 'net-next.git' repo. They deal with some error checks in the device tree MDIO code... [1/3] of_mdio: mdio_device_create() never returns NULL [2/3] of_mdio: use IS_ERR_OR_NULL() [3/3] of_mdio: use PTR_ERR_OR_ZERO() MBR, Sergei

Re: [PATCH -next] bridge: fix potential use-after-free when hook returns QUEUE or STOLEN verdict

Hello. On 03/12/2016 01:14 PM, Florian Westphal wrote: Zefir Kurtisi reported kernel panic with an openwrt specific patch. However, it turns out that mainline has a similar bug waiting to happen. Once NF_HOOK() returns the skb is in undefined state and must not be used. Moreover, the okfn

Re: [PATCH net v3.16]r8169: Not enable/disable bus mastering when is enabled on BIOS

Hello. On 03/12/2016 09:33 AM, Corcodel Marian wrote: This patch not enable/disable bus mastering when is enabled on BIOS.. pci_disable_device function also disable bus mastering for, disable bus mastering is dedicate function. Signed-off-by: Corcodel Marian

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Ramesh, On 03/11/2016 08:14 AM, Ramesh Shanmugasundaram wrote: As we are fixing this issue in CAN dev.c, I'll remove this check in ndo_open and set CAN_CTRLMODE_FD flag in ctrlmode & remove the flag in ctrlmode_supported in the next v3 version of the patch. I posted a V2 version of that

[PATCH net v2 1/4] net: mvneta: Fix spinlock usage

In the previous patch, the spinlock was not initialized. While it didn't cause any trouble yet it could be a problem to use it uninitialized. The most annoying part was the critical section protected by the spinlock in mvneta_stop(). Some of the functions could sleep as pointed when activated

[PATCH net v2 2/4] net: mvneta: enable change MAC address when interface is up

From: Dmitri Epshtein Function eth_prepare_mac_addr_change() is called as part of MAC address change. This function check if interface is running. To enable change MAC address when interface is running: IFF_LIVE_ADDR_CHANGE flag must be set to dev->priv_flags field Fixes:

[PATCH net v2 4/4] net: mvneta: replace magic numbers by existing macros

From: Dmitri Epshtein Some literal values are actually already defined by macros, so let's use them. [gregory.clem...@free-electrons.com: split intial commit in two individual changes] Signed-off-by: Dmitri Epshtein Signed-off-by: Gregory CLEMENT

[PATCH net v2 0/4] Few mvneta fixes

Hi David, In this second version I split the last patch in two parts as requested. For the record the initial cover letter was: "here is a patch set of few fixes. Without the first one, a kernel configured with debug features ended to hang when the driver is built as a module and is removed.

[PATCH net v2 3/4] net: mvneta: fix error messages in mvneta_port_down function

From: Dmitri Epshtein This commit corrects error printing when shutting down the port. [gregory.clem...@free-electrons.com: split initial commit in two individual changes] Signed-off-by: Dmitri Epshtein Signed-off-by: Gregory CLEMENT

Re: [RFC PATCH net-next 2/2] phy: fixed-phy: Allow DT description of an MDIO bus and PHYs.

> One too many " here. > > > +- #address-cells = <1>; > > +- #size-cells = <0>; > > + > > +Child nodes represent PHYs on this mdio bus. Standard properties for > > +fixed links, 'speed', 'full-duplex', 'pause', 'asym-pause', > > +'link-gpios', as defined above are used. Additionally a 'reg'

Re: [PATCH net-next 5/5] phy: fixed: Fix removal of phys.

> > +void fixed_phy_unregister(struct phy_device *phy) > > +{ > > + phy_device_remove(phy); > > + > > + fixed_phy_del(phy->mdio.addr); > > fixed_phy_del() should also make sure that there is no dangling > link_update callback registered, even though this is not fatal, as it > checks whether

Re: [PATCH RFC v2 00/32] Make DSA switches linux devices.

> [snip] > > > > > The third switch is as you would expect, dsa,member = <0 2>; > > I like that representation. > ... > So does that mean you agree we do not need the DSA platform device > anymore :)? It looks like it can be done without the DSA platform device. My previous approach was to

Re: [v6, 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl

On Wed, Mar 09, 2016 at 06:08:50PM +0800, Yangbo Lu wrote: > Move mpc85xx.h to include/linux/fsl and rename it to svr.h as > a common header file. It has been used for mpc85xx and it will > be used for ARM-based SoC as well. > > Signed-off-by: Yangbo Lu From a glimpse, looks

Re: userns, netns, and quick physical memory consumption by unprivileged user

On 03/11/16 18:34 , Florian Westphal wrote: > Yuriy M. Kaminskiy wrote: >> BTW, all those hash/conntrack/etc default sizes was calculated from >> physical memory size in assumption there will be only *one* instance of >> those tables. Obviously, introduction of network

Re: [PATCH V7] netfilter: h323: avoid potential attack

On Sun, Feb 21, 2016 at 12:03:59AM +0800, Zhouyi Zhou wrote: > I think hackers chould build a malicious h323 packet to overflow > the pointer p which will panic during the memcpy(addr, p, len) > For example, he may fabricate a very large taddr->ipAddress.ip in > function get_h225_addr. > > To

Re: [PATCH net v3.16]r8169: Not enable/disable bus mastering when is enabled on BIOS

Corcodel Marian : [...] > For mee this patch is very important , decrease time to autonegociation > and start nic on full speed alltimes. Really ? The commit message did not tell much about it. How much did time decrease ? How did you measure it ? Against which

Re: userns, netns, and quick physical memory consumption by unprivileged user

On Fri, Mar 11, 2016 at 04:34:06PM +0100, Florian Westphal wrote: > Yuriy M. Kaminskiy wrote: > > BTW, all those hash/conntrack/etc default sizes was calculated from > > physical memory size in assumption there will be only *one* instance of > > those tables. Obviously,

Re: [PATCH net v3.16]r8169: Not enable/disable bus mastering when is enabled on BIOS

On Sat, 12 Mar 2016 10:44:01 +0100 Francois Romieu wrote: > Corcodel Marian : > > This patch not enable/disable bus mastering when is enabled on > > BIOS.. > > It bloats the driver without any benefit. > For mee this patch is very important ,

[patch net-next] rocker: move ageing_time from struct rocker to struct ofdpa

From: Jiri Pirko This is OF-DPA specific, used only there, similar to ofdpa_port->ageing_time. So move it to OF-DPA code. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.h | 1 - drivers/net/ethernet/rocker/rocker_main.c | 2 --

GOOD NEWS!!!

I,Mrs Gloria Donated $4,000,000.00 to you, Reply To glori...@foxmail.com for More details.

Re: [PATCH 2/3] net: hns: add Hisilicon RoCE support

On Fri, Mar 11, 2016 at 06:37:10PM +0800, Lijun Ou wrote: > It added hns_dsaf_roce_reset routine for roce driver. > RoCE is a feature of hns. > In hip06 SOC, in roce reset process, it's needed to configure > dsaf channel reset,port and sl map info. > > Signed-off-by: Lijun Ou

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

On Fri, Mar 11, 2016 at 06:37:09PM +0800, Lijun Ou wrote: > The driver for Hisilicon RoCE is a platform driver. > The driver will support mulitple versions of hardware. Currently only "v1" > for hip06 SOC is supported. > The driver includes two parts: common driver and hardware-specific >

Re: [PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support

On Fri, Mar 11, 2016 at 06:37:08PM +0800, Lijun Ou wrote: 1) It is redundant to write "infiniband" and "IB" in one title to mention relevant subsystem, since it is the same. Please take a look on the other submissions here on the list and use similar construction. 2) Please use version number

Re: [PATCHv3 (net.git) 2/2] stmmac: fix MDIO settings

Hi Giuseppe, Am 11.03.2016 um 14:33 schrieb Giuseppe Cavallaro: > Initially the phy_bus_name was added to manipulate the > driver name but It was recently just used to manage the > fixed-link and then to take some decision at run-time > inside the main (for example to skip EEE). > So the patch

[PATCH -next] bridge: fix potential use-after-free when hook returns QUEUE or STOLEN verdict

Zefir Kurtisi reported kernel panic with an openwrt specific patch. However, it turns out that mainline has a similar bug waiting to happen. Once NF_HOOK() returns the skb is in undefined state and must not be used. Moreover, the okfn must consume the skb to support async processing (NF_QUEUE).

Re: [PATCH net 0/3] bridge: ageing timer regression fix

Fri, Mar 11, 2016 at 09:04:48PM CET, da...@davemloft.net wrote: >From: Stephen Hemminger >Date: Tue, 8 Mar 2016 12:59:32 -0800 > >> This fixes regression in how ageing timer is managed. >> Backing out the change required fixing switch drivers as well. > >Series

Re: [PATCH net v3.16]r8169: Not enable/disable bus mastering when is enabled on BIOS

Corcodel Marian : > This patch not enable/disable bus mastering when is enabled on BIOS.. It bloats the driver without any benefit. -- Ueimor

Re: [PATCH v6 net-next 0/2] tcp: Redundant Data Bundling (RDB)

> On 10 Mar 2016, at 03:27, Yuchung Cheng wrote: > > So my question is still if thin-stream app has enough inflight to use > ack-triggered recovery. i.e., it has to send at least twice within an > RTT. > I see. The thin-stream app must send twice before an RTO in order to