[PATCH net-next] net/hsr: Fixed version field in ENUM

2016-04-20 Thread Peter Heise
New field (IFLA_HSR_VERSION) was added in the middle of an existing ENUM and would break kernel ABI, therefore moved to the end. Reported by Stephen Hemminger. Signed-off-by: Peter Heise --- include/uapi/linux/if_link.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/

AW: [PATCH net-next] net/hsr: Added support for HSR v1

2016-04-20 Thread Heise, Peter
Thanks for the advice Stephen, new patch submitted! -Ursprüngliche Nachricht- Von: David Miller [mailto:da...@davemloft.net] Gesendet: Dienstag, 19. April 2016 18:12 An: step...@networkplumber.org Cc: m...@pheise.de; arvid.bro...@alten.se; han...@stressinduktion.org; s...@queasysnail.ne

Re: [PATCH net-next 0/2] act_bpf, cls_bpf: send eBPF bytecode through

2016-04-20 Thread Quentin Monnet
Hi Daniel, Alexei, and many thanks for your answers, 2016-04-15 (11:44 UTC-0700) ~ Alexei Starovoitov: > On Fri, Apr 15, 2016 at 12:41:05PM +0200, Daniel Borkmann wrote: >> Hi Quentin, >> >> On 04/15/2016 12:07 PM, Quentin Monnet wrote: >>> When a new BPF traffic control filter or action is set up

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-20 Thread Johannes Berg
On Tue, 2016-04-19 at 19:53 -0600, David Ahern wrote: >  > The kernel can set a flag in the response that it acknowledges the > new  attribute/flag. I did that for filtering neigh dumps -- > 21fdd092acc7. > Hm, that works, but I think it requires writing extra code, which I was kinda trying to av

[PATCH v2 net 2/3] qede: Fix setting Skb network header

2016-04-20 Thread Manish Chopra
Skb's network header needs to be set before extracting IPv4/IPv6 headers from it. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qede/qed

[PATCH v2 net 3/3] qede: Fix single MTU sized packet from firmware GRO flow

2016-04-20 Thread Manish Chopra
In firmware assisted GRO flow there could be a single MTU sized segment arriving due to firmware aggregation timeout/last segment in an aggregation flow, which is not expected to be an actual gro packet. So If a skb has zero frags from the GRO flow then simply push it in the stack as non gso skb.

[PATCH v2 net 0/3] qede: Bug fixes

2016-04-20 Thread Manish Chopra
Hi David, This series fixes - * various memory allocation failure flows for fastpath * issues with respect to driver GRO packets handling V1->V2 * Send series against net instead of net-next. Please consider applying this series to "net" Thanks, Manish Manish Chopra (3): qede: Fix various

[PATCH v2 net 1/3] qede: Fix various memory allocation error flows for fastpath

2016-04-20 Thread Manish Chopra
This patch handles memory allocation failures for fastpath gracefully in the driver. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c | 140 --- 1 file changed, 85 insertions(+), 55 deletions(-) diff --git a/driver

Re: [PATCH v2] carl9170: Clarify kconfig text

2016-04-20 Thread Kalle Valo
Christian Lamparter writes: > On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: >> Christian Lamparter writes: >> >> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >> > >> >> Why even mention anything about a "special firmware" as the firmware is >> >> already available from li

[PATCHv2 bluetooth-next 02/10] 6lowpan: add 802.15.4 short addr slaac

2016-04-20 Thread Alexander Aring
This patch adds the autoconfiguration if a valid 802.15.4 short address is available for 802.15.4 6LoWPAN interfaces. Cc: David S. Miller Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy Signed-off-by: Alexander Aring --- include/net/addrconf.h | 3 +++ net/6

[PATCHv2 bluetooth-next 01/10] 6lowpan: add private neighbour data

2016-04-20 Thread Alexander Aring
This patch will introduce a 6lowpan neighbour private data. Like the interface private data we handle private data for generic 6lowpan and for link-layer specific 6lowpan. The current first use case if to save the short address for a 802.15.4 6lowpan neighbour. Cc: David S. Miller Signed-off-by:

[PATCHv2 bluetooth-next 00/10] 6lowpan: introduce basic 6lowpan-nd

2016-04-20 Thread Alexander Aring
Hi, this patch series introduces a layer for IPv6 neighbour discovery. At first it introduce the "ndisc_ops" to run a different handling for recv/send of NA/NS messages. The use case for such ndisc operation is RFC 6775 [0]. Which describes a different neighbour discovery handling for 6LoWPAN netw

[PATCHv2 bluetooth-next 08/10] ipv6: export ndisc functions

2016-04-20 Thread Alexander Aring
This patch exports some neighbour discovery functions which can be used by 6lowpan neighbour discovery ops functionality then. Cc: David S. Miller Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy Signed-off-by: Alexander Aring --- include/net/ndisc.h | 16

[PATCHv2 bluetooth-next 06/10] ndisc: add addr_len parameter to ndisc_fill_addr_option

2016-04-20 Thread Alexander Aring
This patch makes the address length as argument for the ndisc_fill_addr_option function. This is necessary to handle addresses which don't use dev->addr_len as address length. Cc: David S. Miller Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy Signed-off-by: Al

[PATCHv2 bluetooth-next 10/10] 6lowpan: add support for 802.15.4 short addr handling

2016-04-20 Thread Alexander Aring
This patch adds necessary handling for use the short address for 802.15.4 6lowpan. It contains support for IPHC address compression and new matching algorithmn to decide which link layer address will be used for 802.15.4 frame. Signed-off-by: Alexander Aring --- net/6lowpan/iphc.c | 167

[PATCHv2 bluetooth-next 07/10] ipv6: introduce neighbour discovery ops

2016-04-20 Thread Alexander Aring
This patch introduces neighbour discovery ops callback structure. The structure contains at first receive and transmit handling for NS/NA and userspace option field functionality. These callback offers 6lowpan different handling, such as 802.15.4 short address handling or RFC6775 (Neighbor Discove

[PATCHv2 bluetooth-next 09/10] 6lowpan: introduce 6lowpan-nd

2016-04-20 Thread Alexander Aring
This patch introduce different 6lowpan handling for receive and transmit NS/NA messages for the ipv6 neighbour discovery. The first use-case is for supporting 802.15.4 short addresses inside the option fields and handling for RFC6775 6CO option field as userspace option. Future handling: Also add

[PATCHv2 bluetooth-next 03/10] 6lowpan: remove ipv6 module request

2016-04-20 Thread Alexander Aring
Since we use exported function from ipv6 kernel module we don't need to request the module anymore to have ipv6 functionality. Signed-off-by: Alexander Aring --- net/6lowpan/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c index fbae31e..824d1bc

[PATCHv2 bluetooth-next 05/10] ndisc: add addr_len parameter to ndisc_opt_addr_data

2016-04-20 Thread Alexander Aring
This patch makes the address length as argument for the ndisc_opt_addr_data function. This is necessary to handle addresses which don't use dev->addr_len as address length. Cc: David S. Miller Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy Signed-off-by: Alexa

[PATCHv2 bluetooth-next 04/10] ndisc: add addr_len parameter to ndisc_opt_addr_space

2016-04-20 Thread Alexander Aring
This patch makes the address length as argument for the ndisc_opt_addr_space function. This is necessary to handle addresses which don't use dev->addr_len as address length. Cc: David S. Miller Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy Signed-off-by: Alex

RE: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs

2016-04-20 Thread Andrew Goodbody
> -Original Message- > From: Andrew Goodbody > Date: Mon, 18 Apr 2016 14:53:25 +0100 > > > This is a fix for a NULL pointer dereference from cpsw which is > > triggered by having two slave PHYs attached to a cpsw network device. > > The problem is due to only maintaining a single referenc

[PATCH 2/2] net: ethernet: davinci_emac: Fix platform_data overwrite

2016-04-20 Thread Neil Armstrong
When the DaVinci emac driver is removed and re-probed, the actual pdev->dev.platform_data is populated with an unwanted valid pointer saved by the previous davinci_emac_of_get_pdata() call, causing a kernel crash when calling priv->int_disable() in emac_int_disable(). Unable to handle kernel pagin

[PATCH net-next 4/4] ip6mr: align RTA_MFC_STATS on 64-bit

2016-04-20 Thread Nicolas Dichtel
Signed-off-by: Nicolas Dichtel --- net/ipv6/ip6mr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index a10e77103c88..bf678324fd52 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -2268,7 +2268,7 @@ static int __ip6mr_fill_mrout

[PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

2016-04-20 Thread Nicolas Dichtel
IS_ALIGN() returns true when the alignment is as expected. The pad attribute should be added only when the alignment is not 8. Fixes: 35c5845957c7 ("net: Add helpers for 64-bit aligning netlink attributes.") Signed-off-by: Nicolas Dichtel --- include/net/netlink.h | 2 +- 1 file changed, 1 inser

[PATCH net-next 3/4] ipmr: align RTA_MFC_STATS on 64-bit

2016-04-20 Thread Nicolas Dichtel
Signed-off-by: Nicolas Dichtel --- include/uapi/linux/rtnetlink.h | 1 + net/ipv4/ipmr.c| 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index ca764b5da86d..02baa5281bbf 100644 --- a/include/ua

[PATCH net-next 0/4] libnl: enhance API to ease 64bit alignment for attribute

2016-04-20 Thread Nicolas Dichtel
Here is a proposal to add more helpers in the libnetlink to manage 64-bit alignment issues. Note that this series was only tested on x86. The first patch is a fix (bug seen by code review only unless I've missed something). The second patch adds helpers and uses it for IFLA_STATS64. The last two

[PATCH net-next 2/4] libnl: add more helpers to align attribute on 64-bit

2016-04-20 Thread Nicolas Dichtel
Add use it to align IFLA_STATS64. Signed-off-by: Nicolas Dichtel --- include/net/netlink.h | 8 lib/nlattr.c | 107 ++ net/core/rtnetlink.c | 9 + 3 files changed, 117 insertions(+), 7 deletions(-) diff --git a/include/net/n

[PATCH 1/2] net: ethernet: davinci_emac: Fix Unbalanced pm_runtime_enable

2016-04-20 Thread Neil Armstrong
In order to avoid an Unbalanced pm_runtime_enable in the DaVinci emac driver when the device is removed and re-probed, and a pm_runtime_disable() call in davinci_emac_remove(). Actually, using unbind/bind on a TI DM8168 SoC gives : $ echo 4a12.ethernet > /sys/bus/platform/drivers/davinci_emac/

Re: [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto VMA

2016-04-20 Thread Luis R. Rodriguez
On Tue, Apr 19, 2016 at 01:33:58PM +0100, Chris Wilson wrote: > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 6ce2c31b9a81..9ef47329e8ae 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -3346,6 +3346,15 @@ static vo

Re: [PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-20 Thread Marek Vasut
On 04/20/2016 04:04 AM, Dinh Nguyen wrote: > > > On 04/19/2016 07:05 PM, Marek Vasut wrote: >> Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() >> in stmmac_main.c functions call devm_reset_control_get() to register an >> reset controller for the stmmac. This results in a

Re: [RFC PATCH v3 net-next 1/3] tcp: Make use of MSG_EOR in tcp_sendmsg and tcp_sendpage

2016-04-20 Thread Eric Dumazet
On Tue, 2016-04-19 at 23:24 -0700, Martin KaFai Lau wrote: > This patch adds an eor bit to the TCP_SKB_CB. When MSG_EOR > is passed to tcp_sendmsg/tcp_sendpage, the eor bit will > be set at the skb containing the last byte of the userland's > msg. The eor bit will prevent data from appending to t

Re: [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

2016-04-20 Thread Eric Dumazet
On Wed, 2016-04-20 at 10:57 +0200, Nicolas Dichtel wrote: > IS_ALIGN() returns true when the alignment is as expected. The pad > attribute should be added only when the alignment is not 8. > > Fixes: 35c5845957c7 ("net: Add helpers for 64-bit aligning netlink > attributes.") > Signed-off-by: Nico

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

2016-04-20 Thread Grygorii Strashko
On 04/20/2016 02:38 AM, David Rivshin (Allworx) wrote: > On Tue, 19 Apr 2016 18:43:39 -0400 (EDT) > David Miller wrote: > >> From: Grygorii Strashko >> Date: Tue, 19 Apr 2016 21:44:09 +0300 >> >>> May be you can send revert + your patch 1 (only fix for this issue). >>> >>> Dave, Does that sound

Re: [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto VMA

2016-04-20 Thread Chris Wilson
On Wed, Apr 20, 2016 at 11:10:54AM +0200, Luis R. Rodriguez wrote: > On Tue, Apr 19, 2016 at 01:33:58PM +0100, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/i915_gem.c > > b/drivers/gpu/drm/i915/i915_gem.c > > index 6ce2c31b9a81..9ef47329e8ae 100644 > > --- a/drivers/gpu/drm/i915/i915_

Re: [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

2016-04-20 Thread Nicolas Dichtel
Le 20/04/2016 11:33, Eric Dumazet a écrit : [snip] How have you tested your patch exactly ? As stated in the cover letter, I didn't test it. I guess David should have copied his original comment here. -* The nlattr header is 4 bytes in size, that's why we test -* if the skb->

drop all fragments inside tx queue if one gets dropped

2016-04-20 Thread Alexander Aring
Hi, On linux-wpan we had a discussion about setting the right tx_queue_len and came to some issues in 802.15.4 6LoWPAN networks. Our hardware parameters are: - Bandwidth: 250kb/s - One framebuffer at hardware side for transmit a frame. - MTU - 127 bytes (without mac headers) To provide 6LoW

Re: [PATCH net-next 0/2] act_bpf, cls_bpf: send eBPF bytecode through

2016-04-20 Thread Daniel Borkmann
Hi Quentin, On 04/20/2016 09:25 AM, Quentin Monnet wrote: 2016-04-15 (11:44 UTC-0700) ~ Alexei Starovoitov: On Fri, Apr 15, 2016 at 12:41:05PM +0200, Daniel Borkmann wrote: On 04/15/2016 12:07 PM, Quentin Monnet wrote: When a new BPF traffic control filter or action is set up with tc, the byt

Re: [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

2016-04-20 Thread Eric Dumazet
On Wed, 2016-04-20 at 11:44 +0200, Nicolas Dichtel wrote: > Le 20/04/2016 11:33, Eric Dumazet a écrit : > [snip] > > How have you tested your patch exactly ? > As stated in the cover letter, I didn't test it. You certainly can test this, by tweaking HAVE_EFFICIENT_UNALIGNED_ACCESS and adding anot

Re: [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

2016-04-20 Thread Nicolas Dichtel
Le 20/04/2016 11:57, Eric Dumazet a écrit : On Wed, 2016-04-20 at 11:44 +0200, Nicolas Dichtel wrote: Le 20/04/2016 11:33, Eric Dumazet a écrit : [snip] How have you tested your patch exactly ? As stated in the cover letter, I didn't test it. You certainly can test this, by tweaking HAVE_EF

[PATCH net-next 2/2] RDS: TCP: Call pskb_extract() helper function

2016-04-20 Thread Sowmini Varadhan
rds-stress experiments with request size 256 bytes, 8K acks, using 16 threads show a 40% improvment when pskb_extract() replaces the {skb_clone(..); pskb_pull(..); pskb_trim(..);} pattern in the Rx path, so we leverage the perf gain with this commit. Signed-off-by: Sowmini Varadhan --- net/rds/t

[PATCH net-next 0/2] pskb_extract() helper function.

2016-04-20 Thread Sowmini Varadhan
This patchset follows up on the discussion in https://www.mail-archive.com/netdev@vger.kernel.org/msg105090.html For RDS-TCP, we have to deal with the full gamut of nonlinear sk_buffs, including all the frag_list variants. Also, the parent skb has to remain unchanged, while the clone is queued fo

[PATCH net-next 1/2] skbuff: Add pskb_extract() helper function

2016-04-20 Thread Sowmini Varadhan
A pattern of skb usage seen in modules such as RDS-TCP is to extract `to_copy' bytes from the received TCP segment, starting at some offset `off' into a new skb `clone'. This is done in the ->data_ready callback, where the clone skb is queued up for rx on the PF_RDS socket, while the parent TCP seg

skb_at_tc_ingress helper breaks compilation of oot modules

2016-04-20 Thread Ingo Saitz
In Linux 4.5, when CONFIG_NET_CLS_ACT is defined, compilation of out of tree modules breaks with undeclared functions/constants. The culprit is: commit fdc5432a7b44ab7de17141beec19d946b9344e91 Author: Daniel Borkmann Date: Thu Jan 7 15:50:22 2016 +0100 net, sched: add skb_at_tc_ingress hel

Re: skb_at_tc_ingress helper breaks compilation of oot modules

2016-04-20 Thread Daniel Borkmann
On 04/20/2016 12:21 PM, Ingo Saitz wrote: In Linux 4.5, when CONFIG_NET_CLS_ACT is defined, compilation of out of tree modules breaks with undeclared functions/constants. The culprit is: commit fdc5432a7b44ab7de17141beec19d946b9344e91 Author: Daniel Borkmann Date: Thu Jan 7 15:50:22 2016 +010

Re: skb_at_tc_ingress helper breaks compilation of oot modules

2016-04-20 Thread Ingo Saitz
On Wed, Apr 20, 2016 at 12:38:11PM +0200, Daniel Borkmann wrote: > Hmm, your fail.c test case only contains '#include '? No, only when building oot modules (virtualbox, and I found batman-adv having the same issue), so I reduced it to the most simple test case. This actually builds a fail.ko on 4.

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

2016-04-20 Thread Eran Ben Elisha
Hi Sinan, We are working in Mellanox for a solution which removes the vmap call and allocate contiguous memory (using dma_alloc_coherent). Thanks, Eran On Tue, Apr 19, 2016 at 9:37 PM, Sinan Kaya wrote: > On 4/19/2016 2:22 PM, Christoph Hellwig wrote: >> What I think we need is something like

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto VMA

2016-04-20 Thread Daniel Vetter
On Wed, Apr 20, 2016 at 11:10:54AM +0200, Luis R. Rodriguez wrote: > Reason I ask is since I noticed a while ago a lot of drivers > were using info->fix.smem_start and info->fix.smem_len consistently > for their ioremap'd areas it might make sense instead to let the > internal framebuffer (register

[PATCH] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

2016-04-20 Thread Grygorii Strashko
Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW (am33/am43/am57/dr7/davinci) to ensure that related patches will go through dedicated linux-omap list. Also add Mugunthan as maintainer and myself as the reviewer. Cc: "David S. Miller" Cc: Mugunthan V N Cc: Richard Cochran Signed-off

[PATCH] net: phy: spi_ks8895: Don't leak references to SPI devices

2016-04-20 Thread Mark Brown
The ks8895 driver is using spi_dev_get() apparently just to take a copy of the SPI device used to instantiate it but never calls spi_dev_put() to free it. Since the device is guaranteed to exist between probe() and remove() there should be no need for the driver to take an extra reference to it so

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-20 Thread Jiri Benc
On Wed, 20 Apr 2016 09:32:20 +0200, Johannes Berg wrote: > 2) Use the new attribute flag with some required attribute for >    existing commands, so that older kernel will not find the required >    attribute and will reject the operation entirely. >    May or may not fall back to trying the operat

[PATCH net 2/4] net/mlx4_core: Avoid repeated calls to pci enable/disable

2016-04-20 Thread Or Gerlitz
From: Daniel Jurgens Maintain the PCI status and provide wrappers for enabling and disabling the PCI device. Performing the actions more than once without doing its opposite results in warning logs. This occurred when EEH hotplugged the device causing a warning for disabling an already disabled

[PATCH net 1/4] net/mlx4_core: Implement pci_resume callback

2016-04-20 Thread Or Gerlitz
From: Daniel Jurgens Move resume related activities to a new pci_resume function instead of performing them in mlx4_pci_slot_reset. This change is needed to avoid a hotplug during EEH recovery due to commit f2da4ccf8bd4 ("powerpc/eeh: More relaxed hotplug criterion"). Fixes: 2ba5fbd62b25 ('net/

[PATCH net 4/4] net/mlx4_en: Split SW RX dropped counter per RX ring

2016-04-20 Thread Or Gerlitz
From: Eran Ben Elisha Count SW packet drops per RX ring instead of a global counter. This will allow monitoring the number of rx drops per ring. In addition, SW rx_dropped counter was overwritten by HW rx_dropped counter, sum both of them instead to show the accurate value. Fixes: ab35da16

[PATCH net 0/4] Mellaox 40G driver fixes for 4.6-rc

2016-04-20 Thread Or Gerlitz
Hi Dave, With the fix for ARM bug being under the works, these are few other fixes for mlx4 we have ready to go. Eran addressed the problematic/wrong reporting of dropped packets, Daniel fixed some matters related to PPC EEH's and Jenny's patch makes sure VFs can't change the port's pause setti

[PATCH net 3/4] net/mlx4_core: Don't allow to VF change global pause settings

2016-04-20 Thread Or Gerlitz
From: Eugenia Emantayev Currently changing global pause settings is done via SET_PORT command with input modifier GENERAL. This command is allowed for each VF since MTU setting is done via the same command. Change the above to the following scheme: before passing the request to the FW, the PF wi

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-20 Thread Johannes Berg
On Wed, 2016-04-20 at 14:48 +0200, Jiri Benc wrote: > On Wed, 20 Apr 2016 09:32:20 +0200, Johannes Berg wrote: > > > > 2) Use the new attribute flag with some required attribute for > >    existing commands, so that older kernel will not find the > > required > >    attribute and will reject the o

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-20 Thread Jiri Benc
On Wed, 20 Apr 2016 15:17:08 +0200, Johannes Berg wrote: > Looks like you have this on a per-message basis. I thought it was > better on an attribute basis because that's really where the issue is. No problem. I'm not that happy with my patchset myself. Just wanted to point it out in case it's use

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

2016-04-20 Thread Sinan Kaya
On 4/19/2016 2:22 PM, Christoph Hellwig wrote: > What I think we need is something like the patch below. In the long > ru nwe should also kill the mlx4_buf structure which now is pretty > pointless. > It is been 1.5 years since I reported the problem. We came up with three different solutions th

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

2016-04-20 Thread Sinan Kaya
Apologies, Replied to an older post by mistake. I was trying to reply to Eran. >Hi Sinan, > >We are working in Mellanox for a solution which >removes the vmap call and allocate contiguous memory (using >dma_alloc_coherent). > >Thanks, >Eran > > >On 4/20/2016 9:35 AM, Sinan Kaya wrote: > On 4/19/

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

2016-04-20 Thread Timur Tabi
Sinan Kaya wrote: I'd like to see a version of the solution to get merged until Mellanox comes up with a better solution with another patch. Yes, I agree 100%. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation coll

RE: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

2016-04-20 Thread KY Srinivasan
> -Original Message- > From: Jeff Kirsher [mailto:jeffrey.t.kirs...@intel.com] > Sent: Tuesday, April 19, 2016 11:25 PM > To: KY Srinivasan ; da...@davemloft.net; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; >

[PATCH net-next] macvtap: add namespace support to the sysfs device class

2016-04-20 Thread Marc Angel
When creating macvtaps that are expected to have the same ifindex in different network namespaces, only the first one will succeed. The others will fail with a sysfs_warn_dup warning due to them trying to create the following sysfs link (with 'NN' the ifindex of macvtapX): /sys/class/macvtap/tapNN

Re: [PATCH] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

2016-04-20 Thread Tony Lindgren
* Grygorii Strashko [160420 04:26]: > Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW > (am33/am43/am57/dr7/davinci) to ensure that related patches > will go through dedicated linux-omap list. > > Also add Mugunthan as maintainer and myself as the reviewer. > > Cc: "David S. Miller"

[PATCH net-next] net: fix HAVE_EFFICIENT_UNALIGNED_ACCESS typos

2016-04-20 Thread Eric Dumazet
From: Eric Dumazet HAVE_EFFICIENT_UNALIGNED_ACCESS needs CONFIG_ prefix. Also add a comment in nla_align_64bit() explaining we have to add a padding if current skb->data is aligned, as it certainly can be confusing. Fixes: 35c5845957c7 ("net: Add helpers for 64-bit aligning netlink attributes."

[PATCH 0/1] Revert "Prevent NUll pointer dereference with two PHYs"

2016-04-20 Thread Andrew Goodbody
Revert this patch as not only did it use an unitialised member of a struct but there is also a pre-existing patch that does it better. Andrew Goodbody (1): Revert "Prevent NUll pointer dereference with two PHYs on cpsw" drivers/net/ethernet/ti/cpsw.c | 31 +++ 1 fil

[PATCH 1/1] Revert "Prevent NUll pointer dereference with two PHYs on cpsw"

2016-04-20 Thread Andrew Goodbody
This reverts commit cfe255600154f0072d4a8695590dbd194dfd1aeb This can result in a "Unable to handle kernel paging request" during boot. This was due to using an uninitialised struct member, data->slaves. --- drivers/net/ethernet/ti/cpsw.c | 31 +++ 1 file changed, 15 i

Re: [PATCH net-next] net: dsa: remove tag_protocol from dsa_switch

2016-04-20 Thread Andrew Lunn
On Mon, Apr 18, 2016 at 06:24:04PM -0400, Vivien Didelot wrote: > Having the tag protocol in dsa_switch_driver for setup time and in > dsa_switch_tree for runtime is enough. Remove dsa_switch's one. > > Signed-off-by: Vivien Didelot I had to think about this one for a minute. At the moment it is

Re: [PATCH net-next] net/hsr: Fixed version field in ENUM

2016-04-20 Thread David Miller
From: Peter Heise Date: Wed, 20 Apr 2016 09:08:29 +0200 > New field (IFLA_HSR_VERSION) was added in the middle of an existing > ENUM and would break kernel ABI, therefore moved to the end. > Reported by Stephen Hemminger. > > Signed-off-by: Peter Heise Applied, thanks.

[net-next PATCH v2 1/3] netdev_features: Fold NETIF_F_ALL_TSO into NETIF_F_GSO_SOFTWARE

2016-04-20 Thread Alexander Duyck
This patch folds NETIF_F_ALL_TSO into the bitmask for NETIF_F_GSO_SOFTWARE. The idea is to avoid duplication of defines since the only difference between the two was the GSO_UDP bit. Signed-off-by: Alexander Duyck --- include/linux/netdev_features.h |8 +++- 1 file changed, 3 insertions(

[net-next PATCH v2 2/3] veth: Update features to include all tunnel GSO types

2016-04-20 Thread Alexander Duyck
This patch adds support for the checksum enabled versions of UDP and GRE tunnels. With this change we should be able to send and receive GSO frames of these types over the veth pair without needing to segment the packets. Signed-off-by: Alexander Duyck --- drivers/net/veth.c |7 +++ 1 f

[net-next PATCH v2 3/3] net: Add support for IP ID mangling TSO in cases that require encapsulation

2016-04-20 Thread Alexander Duyck
This patch adds support for NETIF_F_TSO_MANGLEID if a given tunnel supports NETIF_F_TSO. This way if needed a device can then later enable the TSO with IP ID mangling and the tunnels on top of that device can then also make use of the IP ID mangling as well. Signed-off-by: Alexander Duyck --- n

[net-next PATCH v2 0/3] Feature tweaks/fixes follow-up to GSO partial patches

2016-04-20 Thread Alexander Duyck
This patch series is a set of minor fix-ups and tweaks following the GSO partial and TSO with IPv4 ID mangling patches. It mostly is just meant to make certain that if we have GSO partial support at the device we can make use of it from the far end of the tunnel. v2: Added cover page which was fo

Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs

2016-04-20 Thread David Miller
From: Andrew Goodbody Date: Wed, 20 Apr 2016 08:49:34 + > Sorry, I had no notification that this had happened. However I > thought that the plan was to revert v1 and go with David Rivshin's > patch instead. I'll see if I can create a revert in a little while. Yes, that's fine.

Re: [PATCH net 4/4] net/mlx4_en: Split SW RX dropped counter per RX ring

2016-04-20 Thread Eric Dumazet
On Wed, 2016-04-20 at 16:01 +0300, Or Gerlitz wrote: > From: Eran Ben Elisha > > Count SW packet drops per RX ring instead of a global counter. This > will allow monitoring the number of rx drops per ring. > > In addition, SW rx_dropped counter was overwritten by HW rx_dropped > counter, sum bot

Regression in next for smsc911x with tigthen lockdep checks

2016-04-20 Thread Tony Lindgren
t include/net/sock.h:1408 udp_queue_rcv_skb+0x398/0x640 Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc4-next-20160420 #1087 Hardware name: Generic OMAP36xx (Flattened Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0xb0/0xe4) [

Re: Regression in next for smsc911x with tigthen lockdep checks

2016-04-20 Thread Tony Lindgren
ry forgot to add Steve to Cc, added now. > Regards, > > Tony > > 8< > WARNING: CPU: 0 PID: 0 at include/net/sock.h:1408 > udp_queue_rcv_skb+0x398/0x640 > Modules linked in: > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc4-next-20160420 #108

Re: [PATCH net-next] net: fix HAVE_EFFICIENT_UNALIGNED_ACCESS typos

2016-04-20 Thread David Miller
From: Eric Dumazet Date: Wed, 20 Apr 2016 07:31:31 -0700 > From: Eric Dumazet > > HAVE_EFFICIENT_UNALIGNED_ACCESS needs CONFIG_ prefix. > > Also add a comment in nla_align_64bit() explaining we have > to add a padding if current skb->data is aligned, as it > certainly can be confusing. > > Fi

Re: [PATCH 1/1] Revert "Prevent NUll pointer dereference with two PHYs on cpsw"

2016-04-20 Thread Tony Lindgren
* Andrew Goodbody [160420 07:51]: > This reverts commit cfe255600154f0072d4a8695590dbd194dfd1aeb > > This can result in a "Unable to handle kernel paging request" > during boot. This was due to using an uninitialised struct member, > data->slaves. Missing Signed-off-by? This gets cpsw boards wo

[PATCH v2 1/1] Revert "Prevent NUll pointer dereference with two PHYs on cpsw"

2016-04-20 Thread Andrew Goodbody
This reverts commit cfe255600154f0072d4a8695590dbd194dfd1aeb This can result in a "Unable to handle kernel paging request" during boot. This was due to using an uninitialised struct member, data->slaves. Signed-off-by: Andrew Goodbody Tested-by: Tony Lindgren --- v2 No code change, added signo

[PATCH v2 0/1] Revert "Prevent NUll pointer dereference with two PHYs"

2016-04-20 Thread Andrew Goodbody
Revert this patch as not only did it use an unitialised member of a struct but there is also a pre-existing patch that does it better. V2 add signoff Andrew Goodbody (1): Revert "Prevent NUll pointer dereference with two PHYs on cpsw" drivers/net/ethernet/ti/cpsw.c | 31 +++---

Re: [PATCH net 4/4] net/mlx4_en: Split SW RX dropped counter per RX ring

2016-04-20 Thread Or Gerlitz
On 4/20/2016 5:56 PM, Eric Dumazet wrote: >Fixes: ab35da16 ('net/mlx4_en: Moderate ethtool callback to [...] ') >Signed-off-by: Eran Ben Elisha >Reported-by: Brenden Blanco >Signed-off-by: Saeed Mahameed >Signed-off-by: Or Gerlitz >--- Reported-by: Eric Dumazet (http://www.spinics.net/lists

Re: Regression in next for smsc911x with tigthen lockdep checks

2016-04-20 Thread Hannes Frederic Sowa
Hi, On 20.04.2016 17:01, Tony Lindgren wrote: > Looks like commit fafc4e1ea1a4 ("sock: tigthen lockdep checks for > sock_owned_by_user") in next causes a regression at least for > smsc911x with CONFIG_LOCKDEP. It keeps spamming with the following > message. Any ideas? Not yet, can you quickly sen

Fwd: Davicom DM9162 PHY supported in the kernel?

2016-04-20 Thread Amr Bekhit
(Sorry, repeat message due to the previous one being HTML) Hello, I'm using an embedded Linux board based on an AT91SAM9X25 that uses the Davicom DM9162IEP PHY chip. I'm struggling to get packets out on the wire and I'm suspecting that I might have an issue between the AT91 MAC and the PHY chip.

Re: Regression in next for smsc911x with tigthen lockdep checks

2016-04-20 Thread Tony Lindgren
* Hannes Frederic Sowa [160420 08:24]: > Hi, > > On 20.04.2016 17:01, Tony Lindgren wrote: > > Looks like commit fafc4e1ea1a4 ("sock: tigthen lockdep checks for > > sock_owned_by_user") in next causes a regression at least for > > smsc911x with CONFIG_LOCKDEP. It keeps spamming with the following

Re: [PATCH 1/3] e1000e: e1000e_cyclecounter_read(): incvalue is 32 bits, not 64

2016-04-20 Thread Denys Vlasenko
On 04/19/2016 10:57 PM, Jeff Kirsher wrote: > On Tue, 2016-04-19 at 14:34 +0200, Denys Vlasenko wrote: >> "incvalue" variable holds a result of "er32(TIMINCA) & >> E1000_TIMINCA_INCVALUE_MASK" >> and used in "do_div(temp, incvalue)" as a divisor. >> >> Thus, "u64 incvalue" declaration is probably a

[PATCH net-next v6] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some cases when frequent polling for stats from userspace is a common operation

Re: [PATCH v2 1/1] Revert "Prevent NUll pointer dereference with two PHYs on cpsw"

2016-04-20 Thread David Miller
From: Andrew Goodbody Date: Wed, 20 Apr 2016 16:14:51 +0100 > This reverts commit cfe255600154f0072d4a8695590dbd194dfd1aeb > > This can result in a "Unable to handle kernel paging request" > during boot. This was due to using an uninitialised struct member, > data->slaves. > > Signed-off-by: An

Re: [PATCH net-next v6] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-20 Thread David Miller
From: Roopa Prabhu Date: Wed, 20 Apr 2016 08:43:43 -0700 > This patch has been tested with mofified iproute2 ifstat. Can you please send me the patch you are using? I want to do some quick testing on sparc64 before I push this out. Thanks.

[PATCH iproute2 WIP] ifstat: use new RTM_GETSTATS api

2016-04-20 Thread Roopa Prabhu
From: Roopa Prabhu sample hacked up patch currently used for testing. needs re-work if ifstat will move to RTM_GETSTATS. Signed-off-by: Roopa Prabhu --- include/libnetlink.h | 6 ++ include/linux/if_link.h | 22 ++ include/linux/rtnetlink.h | 5 + lib/libne

Re: [PATCH] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

2016-04-20 Thread Grygorii Strashko
On 04/20/2016 05:23 PM, Tony Lindgren wrote: > * Grygorii Strashko [160420 04:26]: >> Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW >> (am33/am43/am57/dr7/davinci) to ensure that related patches >> will go through dedicated linux-omap list. >> >> Also add Mugunthan as maintainer and

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-20 Thread Saeed Mahameed
On Tue, Apr 19, 2016 at 8:39 PM, Mel Gorman wrote: > On Tue, Apr 19, 2016 at 06:25:32PM +0200, Jesper Dangaard Brouer wrote: >> On Mon, 18 Apr 2016 07:17:13 -0700 >> Eric Dumazet wrote: >> > > alloc_pages_exact() > We want to allocate 32 order-0 physically contiguous pages and to free each one o

Re: skb_at_tc_ingress helper breaks compilation of oot modules

2016-04-20 Thread Alexei Starovoitov
On Wed, Apr 20, 2016 at 12:38:11PM +0200, Daniel Borkmann wrote: > On 04/20/2016 12:21 PM, Ingo Saitz wrote: > >In Linux 4.5, when CONFIG_NET_CLS_ACT is defined, compilation of out of > >tree modules breaks with undeclared functions/constants. The culprit is: > > > >commit fdc5432a7b44ab7de17141bee

Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-20 Thread Saeed Mahameed
On Tue, Apr 19, 2016 at 10:06 PM, Alexander Duyck wrote: > This patch assumes that the mlx5 hardware will ignore existing IPv4/v6 > header fields for length and checksum as well as the length and checksum > fields for outer UDP headers. > > I have no means of testing this as I do not have any mlx5

[PATCH RFC net-next] net: dsa: Provide CPU port statistics to master netdev

2016-04-20 Thread Florian Fainelli
This patch overloads the DSA master netdev, aka CPU Ethernet MAC to also include switch-side statistics, which is useful for debugging purposes, when the switch is not properly connected to the Ethernet MAC (duplex mismatch, (RG)MII electrical issues etc.). We accomplish this by retaining the orig

Re: [PATCH net-next] net: dsa: remove tag_protocol from dsa_switch

2016-04-20 Thread Florian Fainelli
On 18/04/16 15:24, Vivien Didelot wrote: > Having the tag protocol in dsa_switch_driver for setup time and in > dsa_switch_tree for runtime is enough. Remove dsa_switch's one. > > Signed-off-by: Vivien Didelot Acked-by: Florian Fainelli -- Florian

Re: [PATCH] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

2016-04-20 Thread Tony Lindgren
* Grygorii Strashko [160420 09:19]: > On 04/20/2016 05:23 PM, Tony Lindgren wrote: > > * Grygorii Strashko [160420 04:26]: > >> Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW > >> (am33/am43/am57/dr7/davinci) to ensure that related patches > >> will go through dedicated linux-omap li

Re: Davicom DM9162 PHY supported in the kernel?

2016-04-20 Thread Florian Fainelli
Hi, On 20/04/16 08:21, Amr Bekhit wrote: > Hello, > > I'm using an embedded Linux board based on an AT91SAM9X25 that uses the > Davicom DM9162IEP PHY chip. I'm struggling to get packets out on the > wire and I'm suspecting that I might have an issue between the AT91 MAC > and the PHY chip. I've l

Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-20 Thread Alexander Duyck
On Wed, Apr 20, 2016 at 10:40 AM, Saeed Mahameed wrote: > On Tue, Apr 19, 2016 at 10:06 PM, Alexander Duyck wrote: >> This patch assumes that the mlx5 hardware will ignore existing IPv4/v6 >> header fields for length and checksum as well as the length and checksum >> fields for outer UDP headers.

Re: [PATCH net 4/4] net/mlx4_en: Split SW RX dropped counter per RX ring

2016-04-20 Thread Florian Fainelli
On 20/04/16 08:00, Or Gerlitz wrote: > On 4/20/2016 5:56 PM, Eric Dumazet wrote: >>> >Fixes: ab35da16 ('net/mlx4_en: Moderate ethtool callback to >>> [...] ') >>> >Signed-off-by: Eran Ben Elisha >>> >Reported-by: Brenden Blanco >>> >Signed-off-by: Saeed Mahameed >>> >Signed-off-by: Or Gerlitz >

[PATCH net-next 1/2] net: bcmsysport: use __napi_schedule_irqoff()

2016-04-20 Thread Florian Fainelli
Both bcm_sysport_tx_isr() and bcm_sysport_rx_isr() run in hard irq context, we do not need to block irq again. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bcms

  1   2   >