[PATCH v4 03/25] io-mapping: Specify mapping size for io_mapping_map_wc()

2016-04-25 Thread Chris Wilson
The ioremap() hidden behind the io_mapping_map_wc() convenience helper can be used for remapping multiple pages. Extend the helper so that future callers can use it for larger ranges. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Daniel Vetter Cc: Jani Nikula Cc: David Airlie Cc: Yishai

Re: codel: split into multiple files

2016-04-25 Thread Sedat Dilek
On 4/26/16, Michal Kazior wrote: > On 26 April 2016 at 08:09, Sedat Dilek wrote: >> Hi, >> >> I had a very quick view on net-next.git#master (up to commit >> fab7b629a82da1b59620470d13152aff975239f6). >> >> Commit in [1] aka "codel: split into multiple files" removed codel.h >> but [2] and [3] ha

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-25 Thread oulijun
On 2016/4/24 15:54, Leon Romanovsky wrote: > On Sat, Apr 23, 2016 at 06:26:47PM +0800, Lijun Ou wrote: >> This patch mainly setup hca for RoCE. it will do a series of >> initial works as follows: >> 1. init uar table, allocate uar resource >> 2. init pd table >> 3. init cq table >

Re: codel: split into multiple files

2016-04-25 Thread Michal Kazior
On 26 April 2016 at 08:09, Sedat Dilek wrote: > Hi, > > I had a very quick view on net-next.git#master (up to commit > fab7b629a82da1b59620470d13152aff975239f6). > > Commit in [1] aka "codel: split into multiple files" removed codel.h > but [2] and [3] have relicts to it. > Forgot to remove? code

Re: [PATCH 2/2] vhost: lockless enqueuing

2016-04-25 Thread Pankaj Gupta
Hi Jason, Overall patches look good. Just one doubt I have is below: > > We use spinlock to synchronize the work list now which may cause > unnecessary contentions. So this patch switch to use llist to remove > this contention. Pktgen tests shows about 5% improvement: > > Before: > ~130 pps

Re: codel: split into multiple files

2016-04-25 Thread Sedat Dilek
Hi, I had a very quick view on net-next.git#master (up to commit fab7b629a82da1b59620470d13152aff975239f6). Commit in [1] aka "codel: split into multiple files" removed codel.h but [2] and [3] have relicts to it. Forgot to remove? (Not sure if there exist more relicts.) Regards, - Sedat - [1]

Re: [PATCH] net: ethernet: davinci_emac: Fix devioctl while in fixed link

2016-04-25 Thread Mugunthan V N
On Monday 25 April 2016 11:11 PM, Neil Armstrong wrote: > When configured in fixed link, the DaVinci emac driver sets the > priv->phydev to NULL and further ioctl calls to the phy_mii_ioctl() > causes the kernel to crash. > > Cc: Brian Hutchinson > Fixes: 1bb6aa56bb38 ("net: davinci_emac: Add sup

Re: [PATCH net-next 0/3] ila: Support for checksum neutral translations

2016-04-25 Thread David Miller
From: Tom Herbert Date: Sat, 23 Apr 2016 11:46:54 -0700 > This patch set updates ILA to support draft-herbert-nvo3-ila-02. The > primary addition is support checksum neutral ILA translation. > This allows address to be performed and still keep any transport > layer checksums that include the addr

Re: [PATCH net] net/mlx4_en: fix spurious timestamping callbacks

2016-04-25 Thread David Miller
From: Eric Dumazet Date: Sat, 23 Apr 2016 11:35:46 -0700 > From: Eric Dumazet > > When multiple skb are TX-completed in a row, we might incorrectly keep > a timestamp of a prior skb and cause extra work. > > Fixes: ec693d47010e8 ("net/mlx4_en: Add HW timestamping (TS) support") > Signed-off-by

Re: [PATCH] net: dummy: remove note about being Y by default

2016-04-25 Thread David Miller
From: Ivan Babrou Date: Sat, 23 Apr 2016 12:58:03 + > Signed-off-by: Ivan Babrou Applied.

Re: [PATCH] net: tsi108: use NULL for pointer-typed argument

2016-04-25 Thread David Miller
From: Julia Lawall Date: Sat, 23 Apr 2016 11:07:02 +0200 > The first argument of pci_free_consistent has type struct pci_dev *, so use > NULL instead of 0. > > The semantic patch that performs this transformation is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > @@ > pci_free_consist

Re: [PATCH v2 net-next 00/13] net: hns: add support of debug dsaf device

2016-04-25 Thread David Miller
From: Yisen Zhuang Date: Sat, 23 Apr 2016 17:05:04 +0800 > There are two kinds of dsaf device in hns, one is for service ports, > contains crossbar in it, can work under different mode. Another is for > debug port, only can work under single port mode. The current code only > declares a dsaf devi

[PATCH 5/5] batman-adv: Fix broadcast/ogm queue limit on a removed interface

2016-04-25 Thread Antonio Quartulli
From: Linus Lüssing When removing a single interface while a broadcast or ogm packet is still pending then we will free the forward packet without releasing the queue slots again. This patch is supposed to fix this issue. Fixes: 6d5808d4ae1b ("batman-adv: Add missing hardif_free_ref in forw_pa

[PATCH 4/5] batman-adv: Reduce refcnt of removed router when updating route

2016-04-25 Thread Antonio Quartulli
From: Sven Eckelmann _batadv_update_route rcu_derefences orig_ifinfo->router outside of a spinlock protected region to print some information messages to the debug log. But this pointer is not checked again when the new pointer is assigned in the spinlock protected region. Thus is can happen that

[PATCH 2/5] batman-adv: init neigh node last seen field

2016-04-25 Thread Antonio Quartulli
From: Marek Lindner Signed-off-by: Marek Lindner [s...@narfation.org: fix conflicts with current version] Signed-off-by: Sven Eckelmann Signed-off-by: Antonio Quartulli --- net/batman-adv/originator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/originator.c b/net/batman

[PATCH 3/5] batman-adv: Deactivate TO_BE_ACTIVATED hardif on shutdown

2016-04-25 Thread Antonio Quartulli
From: Sven Eckelmann The shutdown of an batman-adv interface can happen with one of its slave interfaces still being in the BATADV_IF_TO_BE_ACTIVATED state. A possible reason for it is that the routing algorithm BATMAN_V was selected and batadv_schedule_bat_ogm was not yet called for this interfa

[PATCH 1/5] batman-adv: Check skb size before using encapsulated ETH+VLAN header

2016-04-25 Thread Antonio Quartulli
From: Sven Eckelmann The encapsulated ethernet and VLAN header may be outside the received ethernet frame. Thus the skb buffer size has to be checked before it can be parsed to find out if it encapsulates another batman-adv packet. Fixes: 420193573f11 ("batman-adv: softif bridge loop avoidance")

pull request [net]: batman-adv-0160426

2016-04-25 Thread Antonio Quartulli
Hi David, this is a batch intended for net. Changes are quite small, therefore I hope it is not a big deal to include them at this point of the release cycle. In this patchset you can find the following fixes: 1) check skb size to avoid reading beyond its border when delivering payloads, by S

[PATCH net-next V2] tuntap: calculate rps hash only when needed

2016-04-25 Thread Jason Wang
There's no need to calculate rps hash if it was not enabled. So this patch export rps_needed and check it before trying to get rps hash. Tests (using pktgen to inject packets to guest) shows this can improve pps about 13% (when rps is disabled). Before: ~115 pps After: ~130 pps Cc: Michae

Re: [PATCH net-next] tuntap: calculate rps hash only when needed

2016-04-25 Thread Jason Wang
On 04/26/2016 09:55 AM, Jason Wang wrote: > There's no need to calculate rps hash if it was not enabled. So this > patch export rps_needed and check it before trying to get rps > hash. Tests (using pktgen to inject packets to guest) shows this can > improve pps about 13% (when rps is disabled). >

Re: [PATCH] net: ipv6: Delete host routes on an ifdown

2016-04-25 Thread David Miller
From: Mike Manning Date: Tue, 26 Apr 2016 01:57:20 +0100 > It would be great if this could be reconsidered If you guys start ganging up on me, I will set you all to ignore. This is my last warning. Please respect my decision and try to shore up this change properly for 4.7.0 Thank you.

Re: [PATCH] net: ipv6: Delete host routes on an ifdown

2016-04-25 Thread David Miller
From: David Ahern Date: Mon, 25 Apr 2016 16:03:40 -0600 > Rather than focusing on my mistakes, why not see the commitment on > following through with this change? I do not question the amount of time and effort invested. I question whether the change was truly ready yet, and my conclusion right

RE: [v8, 1/7] Documentation: DT: update Freescale DCFG compatible

2016-04-25 Thread Yangbo Lu
Hi Mark, > -Original Message- > From: Mark Rutland [mailto:mark.rutl...@arm.com] > Sent: Friday, April 22, 2016 9:12 PM > To: Yangbo Lu > Cc: linux-...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.

Re: myri10ge: fix sleeping with bh disabled

2016-04-25 Thread Hyong-Youb Kim
On Mon, Apr 25, 2016 at 10:59:19AM +0200, Stanislaw Gruszka wrote: > napi_disable() can not be called with bh disabled, move locking just > around myri10ge_ss_lock_napi() . Acked-by: Hyong-Youb Kim Thanks. > > Patches fixes following bug: > > [ 114.278378] BUG: sleeping function called from

[PATCH] ps3_gelic: fix memcpy parameter

2016-04-25 Thread Christophe JAILLET
The size allocated for target->hwinfo and the number of bytes copied in it should be consistent. Signed-off-by: Christophe JAILLET --- Untested drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/toshiba/ps3_

Re: [PATCH net-next] tuntap: calculate rps hash only when needed

2016-04-25 Thread kbuild test robot
Hi, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jason-Wang/tuntap-calculate-rps-hash-only-when-needed/20160426-095825 config: xtensa-allyesconfig (attached as .config) compiler: reproduce: wget https://git.kernel.org/cgit/linux/kernel/git

linux-next: manual merge of the net-next tree with the net tree

2016-04-25 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got conflicts in: include/linux/ipv6.h net/ipv6/addrconf.c between commit: 841645b5f2df ("ipv6: Revert optional address flusing on ifdown.") from the net tree and commits: 607ea7cda631 ("net/ipv6/addrconf: simplify sysctl registrat

[PATCH 1/2] vhost: simplify work flushing

2016-04-25 Thread Jason Wang
We used to implement the work flushing through tracking queued seq, done seq, and the number of flushing. This patch simplify this by just implement work flushing through another kind of vhost work with completion. This will be used by lockless enqueuing patch. Signed-off-by: Jason Wang --- driv

[PATCH 2/2] vhost: lockless enqueuing

2016-04-25 Thread Jason Wang
We use spinlock to synchronize the work list now which may cause unnecessary contentions. So this patch switch to use llist to remove this contention. Pktgen tests shows about 5% improvement: Before: ~130 pps After: ~137 pps Signed-off-by: Jason Wang --- drivers/vhost/vhost.c | 52 +

[PATCH net-next] tuntap: calculate rps hash only when needed

2016-04-25 Thread Jason Wang
There's no need to calculate rps hash if it was not enabled. So this patch export rps_needed and check it before trying to get rps hash. Tests (using pktgen to inject packets to guest) shows this can improve pps about 13% (when rps is disabled). Before: ~115 pps After: ~130 pps Cc: Michae

Re: [PATCH] net: dsa: mv88e6xxx: fix uninitialized error return

2016-04-25 Thread Vivien Didelot
Hi Colin, Colin King writes: > From: Colin Ian King > > The error return err is not initialized and there is a possibility > that err is not assigned causing mv88e6xxx_port_bridge_join to > return a garbage error return status. Fix this by initializing err > to 0. > > Signed-off-by: Colin Ian K

System Administrator.

2016-04-25 Thread Bell, Jerry J
Suspicious sign in detected on your Mailbox Account, We noticed a recent login attempt from an unusual device or location. If this wasn’t you, please secure your account Now; CLICK HERE System Administrator.

Re: [PATCH] net: ipv6: Delete host routes on an ifdown

2016-04-25 Thread Mike Manning
On 04/25/2016 11:03 PM, David Ahern wrote: > On 4/25/16 2:42 PM, David Miller wrote: >> From: David Ahern >> Date: Mon, 25 Apr 2016 13:40:26 -0600 >> >>> It's unfortunate you want to take that action. Last week I came across >>> a prior attempt by Stephen to do this same thing -- keep IPv6 >>> add

Re: [PATCH v4 net-next 0/3] tcp: Make use of MSG_EOR in tcp_sendmsg

2016-04-25 Thread Soheil Hassas Yeganeh
On Mon, Apr 25, 2016 at 5:44 PM, Martin KaFai Lau wrote: > v4: > ~ Do not set eor bit in do_tcp_sendpages() since there is > no way to pass MSG_EOR from the userland now. > ~ Avoid rmw by testing MSG_EOR first in tcp_sendmsg(). > ~ Move TCP_SKB_CB(skb)->eor test to a new helper > tcp_skb_can_c

Re: [PATCH v4 net-next 3/3] tcp: Handle eor bit when fragmenting a skb

2016-04-25 Thread Soheil Hassas Yeganeh
On Mon, Apr 25, 2016 at 5:44 PM, Martin KaFai Lau wrote: > When fragmenting a skb, the next_skb should carry > the eor from prev_skb. The eor of prev_skb should > also be reset. > > Packetdrill script for testing: > ~~ > +0 `sysctl -q -w net.ipv4.tcp_min_tso_segs=10` > +0 `sysctl -q -w net.ip

Re: [PATCH v4 net-next 2/3] tcp: Handle eor bit when coalescing skb

2016-04-25 Thread Soheil Hassas Yeganeh
On Mon, Apr 25, 2016 at 5:44 PM, Martin KaFai Lau wrote: > This patch: > 1. Prevent next_skb from coalescing to the prev_skb if >TCP_SKB_CB(prev_skb)->eor is set > 2. Update the TCP_SKB_CB(prev_skb)->eor if coalescing is >allowed > > Packetdrill script for testing: > ~~ > +0 `sysctl -q

Re: [PATCH v4 net-next 1/3] tcp: Make use of MSG_EOR in tcp_sendmsg

2016-04-25 Thread Soheil Hassas Yeganeh
On Mon, Apr 25, 2016 at 5:44 PM, Martin KaFai Lau wrote: > This patch adds an eor bit to the TCP_SKB_CB. When MSG_EOR > is passed to tcp_sendmsg, the eor bit will be set at the skb > containing the last byte of the userland's msg. The eor bit > will prevent data from appending to that skb in the

Quote Request

2016-04-25 Thread Al Waleed Co.
Hi, My name is Al Waleed From Al Waleed trading company Dubai we got you recommendation from one of your customer, so we decided to order a product from you. Kindly get back to us if you can ship to us in Dubai so that we can get back to you with our products needed from you and other requirem

Re: [PATCH net-next 2/6] atl1c: remove private tx lock

2016-04-25 Thread Francois Romieu
Florian Westphal : > Francois Romieu wrote: [...] > > Play it safe and keep the implicit local_irq_{save / restore} call ? > > > > It may not be needed but it will help avoiding any unexpected regression > > report pointing at the NETDEV_TX_LOCKED removal change. > > I thought about that but it

Re: [PATCH v4 net-next 3/3] tcp: Handle eor bit when fragmenting a skb

2016-04-25 Thread Eric Dumazet
On Mon, 2016-04-25 at 14:44 -0700, Martin KaFai Lau wrote: > When fragmenting a skb, the next_skb should carry > the eor from prev_skb. The eor of prev_skb should > also be reset. Acked-by: Eric Dumazet

Re: [PATCH net-next] tc_act: export all user headers

2016-04-25 Thread Stephen Hemminger
On Mon, 25 Apr 2016 16:52:44 -0400 (EDT) David Miller wrote: > From: David Miller > Date: Mon, 25 Apr 2016 16:49:39 -0400 (EDT) > > > From: Stephen Hemminger > > Date: Fri, 22 Apr 2016 10:06:38 -0700 > > > >> The file tc_ife.h was missing from the export list. > >> Rather than continue to che

Re: [PATCH v4 net-next 2/3] tcp: Handle eor bit when coalescing skb

2016-04-25 Thread Eric Dumazet
On Mon, 2016-04-25 at 14:44 -0700, Martin KaFai Lau wrote: > This patch: > 1. Prevent next_skb from coalescing to the prev_skb if >TCP_SKB_CB(prev_skb)->eor is set > 2. Update the TCP_SKB_CB(prev_skb)->eor if coalescing is >allowed Acked-by: Eric Dumazet

Re: [PATCH] devlink: export header

2016-04-25 Thread Stephen Hemminger
On Mon, 25 Apr 2016 16:49:28 -0400 (EDT) David Miller wrote: > From: Stephen Hemminger > Date: Fri, 22 Apr 2016 09:55:17 -0700 > > > Export devlink.h when doing make headers install. > > I am going to investigate just doing all headers in the directory, > > but lets add missing piece for now. >

Re: [PATCH v4 net-next 1/3] tcp: Make use of MSG_EOR in tcp_sendmsg

2016-04-25 Thread Eric Dumazet
On Mon, 2016-04-25 at 14:44 -0700, Martin KaFai Lau wrote: > This patch adds an eor bit to the TCP_SKB_CB. When MSG_EOR > is passed to tcp_sendmsg, the eor bit will be set at the skb > containing the last byte of the userland's msg. The eor bit > will prevent data from appending to that skb in th

Re: [PATCH V3] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-25 Thread Marek Vasut
On 04/25/2016 08:11 PM, Joachim Eastwood wrote: > Hi Marek, Hi! > On 21 April 2016 at 14:11, Marek Vasut wrote: >> Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() >> in stmmac_main.c functions call devm_reset_control_get() to register an >> reset controller for the stmm

Re: [PATCH] net: ipv6: Delete host routes on an ifdown

2016-04-25 Thread Roopa Prabhu
On 4/25/16, 1:42 PM, David Miller wrote: > From: David Ahern > Date: Mon, 25 Apr 2016 13:40:26 -0600 > >> It's unfortunate you want to take that action. Last week I came across >> a prior attempt by Stephen to do this same thing -- keep IPv6 >> addresses. That prior attempt was reverted by commit

[PATCH 2/2 net] lan78xx: workaround of forced 100 Full/Half duplex mode error

2016-04-25 Thread Woojung.Huh
From: Woojung Huh At forced 100 Full & Half duplex mode, chip may fail to set mode correctly when cable is switched between long(~50+m) and short one. As workaround, set to 10 before setting to 100 at forced 100 F/H mode. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 29 ++

[PATCH 0/2 net] lan78xx: patch series

2016-04-25 Thread Woojung.Huh
From: Woojung Huh Woojung Huh (2): lan78xx: fix statistics counter error lan78xx: workaround of forced 100 Full/Half duplex mode error drivers/net/usb/lan78xx.c | 44 ++-- 1 file changed, 38 insertions(+), 6 deletions(-) -- 2.8.1

[PATCH 1/2 net] lan78xx: fix statistics counter error

2016-04-25 Thread Woojung.Huh
From: Woojung Huh Fix rx_bytes, tx_bytes and tx_frames error in netdev.stats. - rx_bytes counted bytes excluding size of struct ethhdr. - tx_packets didn't count multiple packets in a single urb - tx_bytes included 8 bytes of extra commands. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78

[PATCH] net: dsa: mv88e6xxx: fix uninitialized error return

2016-04-25 Thread Colin King
From: Colin Ian King The error return err is not initialized and there is a possibility that err is not assigned causing mv88e6xxx_port_bridge_join to return a garbage error return status. Fix this by initializing err to 0. Signed-off-by: Colin Ian King --- drivers/net/dsa/mv88e6xxx.c | 2 +-

Re: [PATCH] net: ipv6: Delete host routes on an ifdown

2016-04-25 Thread David Ahern
On 4/25/16 2:42 PM, David Miller wrote: From: David Ahern Date: Mon, 25 Apr 2016 13:40:26 -0600 It's unfortunate you want to take that action. Last week I came across a prior attempt by Stephen to do this same thing -- keep IPv6 addresses. That prior attempt was reverted by commit 73a8bd74e261

Re: [PATCH net v2 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

2016-04-25 Thread David Rivshin (Allworx)
On Mon, 25 Apr 2016 22:12:20 +0300 Grygorii Strashko wrote: > On 04/22/2016 06:45 PM, David Rivshin (Allworx) wrote: > > On Fri, 22 Apr 2016 16:03:34 +0300 > > Grygorii Strashko wrote: > > > >> On 04/21/2016 09:26 PM, David Rivshin (Allworx) wrote: > >>> From: David Rivshin > >>> > >>> The

[PATCH v4 net-next 1/3] tcp: Make use of MSG_EOR in tcp_sendmsg

2016-04-25 Thread Martin KaFai Lau
This patch adds an eor bit to the TCP_SKB_CB. When MSG_EOR is passed to tcp_sendmsg, the eor bit will be set at the skb containing the last byte of the userland's msg. The eor bit will prevent data from appending to that skb in the future. The change in do_tcp_sendpages is to honor the eor set d

[PATCH v4 net-next 0/3] tcp: Make use of MSG_EOR in tcp_sendmsg

2016-04-25 Thread Martin KaFai Lau
v4: ~ Do not set eor bit in do_tcp_sendpages() since there is no way to pass MSG_EOR from the userland now. ~ Avoid rmw by testing MSG_EOR first in tcp_sendmsg(). ~ Move TCP_SKB_CB(skb)->eor test to a new helper tcp_skb_can_collapse_to() (suggested by Soheil). ~ Add some packetdrill tests. v3:

[PATCH v4 net-next 3/3] tcp: Handle eor bit when fragmenting a skb

2016-04-25 Thread Martin KaFai Lau
When fragmenting a skb, the next_skb should carry the eor from prev_skb. The eor of prev_skb should also be reset. Packetdrill script for testing: ~~ +0 `sysctl -q -w net.ipv4.tcp_min_tso_segs=10` +0 `sysctl -q -w net.ipv4.tcp_no_metrics_save=1` +0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3 +0

[PATCH v4 net-next 2/3] tcp: Handle eor bit when coalescing skb

2016-04-25 Thread Martin KaFai Lau
This patch: 1. Prevent next_skb from coalescing to the prev_skb if TCP_SKB_CB(prev_skb)->eor is set 2. Update the TCP_SKB_CB(prev_skb)->eor if coalescing is allowed Packetdrill script for testing: ~~ +0 `sysctl -q -w net.ipv4.tcp_min_tso_segs=10` +0 `sysctl -q -w net.ipv4.tcp_no_metrics_

Re: [PATCH RFC net-next] net: dsa: Provide CPU port statistics to master netdev

2016-04-25 Thread Andrew Lunn
On Wed, Apr 20, 2016 at 10:58:21AM -0700, Florian Fainelli wrote: > This patch overloads the DSA master netdev, aka CPU Ethernet MAC to also > include switch-side statistics, which is useful for debugging purposes, > when the switch is not properly connected to the Ethernet MAC (duplex > mismatch,

Re: [RFC PATCH net] ipv6/ila: fix nlsize calculation for lwtunnel

2016-04-25 Thread David Miller
From: Nicolas Dichtel Date: Fri, 22 Apr 2016 17:58:02 +0200 > The handler 'ila_fill_encap_info' adds one attribute: ILA_ATTR_LOCATOR. > > Fixes: 65d7ab8de582 ("net: Identifier Locator Addressing module") > CC: Tom Herbert > Signed-off-by: Nicolas Dichtel > --- > > Tom, when I read the comment

Re: [PATCH 1/6] bus: Add shared MDIO bus framework

2016-04-25 Thread Andrew Lunn
Hi Pramod I took a closer look. I don't see why the current MDIO code should not be used, rather than adding a new framework. What you need for your Non Ethernet PHYs is that they are somehow probed. The current MDIO code will do that, based on the compatible string. An mdio device gets passed a

Re: [PATCH v2 net-next 0/2] pskb_extract() helper function.

2016-04-25 Thread David Miller
From: Sowmini Varadhan Date: Fri, 22 Apr 2016 18:36:34 -0700 > This patchset follows up on the discussion in > https://www.mail-archive.com/netdev@vger.kernel.org/msg105090.html > > For RDS-TCP, we have to deal with the full gamut of > nonlinear sk_buffs, including all the frag_list variants. >

Re: [PATCH net-next] tc_act: export all user headers

2016-04-25 Thread David Miller
From: David Miller Date: Mon, 25 Apr 2016 16:49:39 -0400 (EDT) > From: Stephen Hemminger > Date: Fri, 22 Apr 2016 10:06:38 -0700 > >> The file tc_ife.h was missing from the export list. >> Rather than continue to cherry-pick, just export all headers in the >> directory. >> >> Signed-off-by: S

[PATCH net-next 2/2] tcp: remove a redundant check for SKBTX_ACK_TSTAMP

2016-04-25 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh txstamp_ack in tcp_skb_cb is set iff the SKBTX_ACK_TSTAMP flag is set for an skb. Thus, it is not required to check shinfo->tx_flags if the txstamp_ack bit is checked. Remove the check on shinfo->tx_flags & SKBTX_ACK_TSTAMP, since it has already been checked using the

[PATCH net-next 1/2] tcp: remove an unnecessary check in tcp_tx_timestamp

2016-04-25 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh tcp_tx_timestamp() receives tsflags as a parameter. tsflags is initialized to sk->sk_tsflags and is overridden by control messages. As a result the "sk->sk_tsflags || tsflags" is the same expression as "tsflags" Remove the redundant check for sk->sk_tsflags in tcp_tx_

Re: [PATCH net-next] tc_act: export all user headers

2016-04-25 Thread David Miller
From: Stephen Hemminger Date: Fri, 22 Apr 2016 10:06:38 -0700 > The file tc_ife.h was missing from the export list. > Rather than continue to cherry-pick, just export all headers in the directory. > > Signed-off-by: Stephen Hemminger Applied.

Re: [PATCH] devlink: export header

2016-04-25 Thread David Miller
From: Stephen Hemminger Date: Fri, 22 Apr 2016 09:55:17 -0700 > Export devlink.h when doing make headers install. > I am going to investigate just doing all headers in the directory, > but lets add missing piece for now. > > Signed-off-by: Stephen Hemminger This is already exported in the 'net

Re: [PATCH] fq: add fair queuing framework

2016-04-25 Thread David Miller
From: Michal Kazior Date: Fri, 22 Apr 2016 14:20:13 +0200 > This works on the same implementation principle as > codel*.h, i.e. there's a generic header with > structures and macros and a implementation header > carrying function definitions to include in given, > e.g. driver or module. > > The

Re: [PATCH 0/2] codel: make it reuseable beyond qdiscs

2016-04-25 Thread David Miller
From: Michal Kazior Date: Fri, 22 Apr 2016 14:15:57 +0200 > There's an ongoing effort in fixing wireless > bufferbloat. As part of that fq_codel is being > ported into mac80211. To prevent code duplication > codel.h needs to be slightly modified before it > can be used in mac80211 (or other drive

Re: [PATCH] net: ipv6: Delete host routes on an ifdown

2016-04-25 Thread David Miller
From: David Ahern Date: Mon, 25 Apr 2016 13:40:26 -0600 > It's unfortunate you want to take that action. Last week I came across > a prior attempt by Stephen to do this same thing -- keep IPv6 > addresses. That prior attempt was reverted by commit > 73a8bd74e261. Cumulus, Brocade, and others clea

Re: [PATCH net-next] macsec: Convert to using IFF_NO_QUEUE

2016-04-25 Thread David Miller
From: Phil Sutter Date: Fri, 22 Apr 2016 14:02:42 +0200 > Signed-off-by: Phil Sutter Applied.

Re: [PATCH] cxgbi: fix uninitialized flowi6

2016-04-25 Thread David Miller
From: Jiri Benc Date: Fri, 22 Apr 2016 13:09:13 +0200 > ip6_route_output looks into different fields in the passed flowi6 structure, > yet cxgbi passes garbage in nearly all those fields. Zero the structure out > first. > > Fixes: fc8d0590d9142 ("libcxgbi: Add ipv6 api to driver") > Signed-off-b

Re: [PATCH net-next] route: move lwtunnel state to a single place

2016-04-25 Thread David Miller
From: Jiri Benc Date: Fri, 22 Apr 2016 12:40:02 +0200 > Commit 751a587ac9f9 ("route: fix breakage after moving lwtunnel state") > moved lwtstate to the end of dst_entry for 32bit archs. This makes it share > the cacheline with __refcnt which had an unkown effect on performance. For > this reason,

Re: [PATCH net-next v2 0/4] qed*: driver updates

2016-04-25 Thread David Miller
From: Yuval Mintz Date: Fri, 22 Apr 2016 08:41:00 +0300 > This patch series contains some ethtool-related enhancements. Series applied.

Re: [PATCH net-next] net: better drop monitoring in ip{6}_recv_error()

2016-04-25 Thread David Miller
From: Eric Dumazet Date: Thu, 21 Apr 2016 22:27:32 -0700 > From: Eric Dumazet > > We should call consume_skb(skb) when skb is properly consumed, > or kfree_skb(skb) when skb must be dropped in error case. > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH net-next] tcp: SYN packets are now simply consumed

2016-04-25 Thread David Miller
From: Eric Dumazet Date: Thu, 21 Apr 2016 22:13:01 -0700 > From: Eric Dumazet > > We now have proper per-listener but also per network namespace counters > for SYN packets that might be dropped. > > We replace the kfree_skb() by consume_skb() to be drop monitor [1] > friendly, and remove an ob

Re: [PATCH 4/5] mdio_bus: get_phy_device() doesn't return NULL anymore

2016-04-25 Thread Florian Fainelli
On 24/04/16 10:30, Sergei Shtylyov wrote: > Now that get_phy_device() no longer returns NULL on error, we don't need > to check for it... > > Signed-off-by: Sergei Shtylyov Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 5/5] of_mdio: get_phy_device() doesn't return NULL anymore

2016-04-25 Thread Florian Fainelli
On 24/04/16 10:31, Sergei Shtylyov wrote: > Now that get_phy_device() no longer returns NULL on error, we don't need > to check for it... > > Signed-off-by: Sergei Shtylyov Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 3/5] fixed_phy: get_phy_device() doesn't return NULL anymore

2016-04-25 Thread Florian Fainelli
On 24/04/16 10:29, Sergei Shtylyov wrote: > Now that get_phy_device() no longer returns NULL on error, we don't need > to check for it... > > Signed-off-by: Sergei Shtylyov Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 2/5] xgene: get_phy_device() doesn't return NULL anymore

2016-04-25 Thread Florian Fainelli
On 24/04/16 10:27, Sergei Shtylyov wrote: > Now that get_phy_device() no longer returns NULL on error, we don't need > to check for it... > > Signed-off-by: Sergei Shtylyov Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 1/5] phylib: don't return NULL from get_phy_device()

2016-04-25 Thread Florian Fainelli
On 24/04/16 10:25, Sergei Shtylyov wrote: > Arnd Bergmann asked that get_phy_device() returns either NULL or the error > value, not both on error. Do as he said, return ERR_PTR(-ENODEV) instead > of NULL when the PHY ID registers read as all ones. > > Suggested-by: Arnd Bergmann > Signed-off-b

[PATCH] ipv6: Revert optional address flusing on ifdown.

2016-04-25 Thread David Miller
This reverts the following three commits: 70af921db6f8835f4b11c65731116560adb00c14 799977d9aafbf0ca0b9c39b04cbfb16db71302c9 f1705ec197e705b79ea40fe7a2cc5acfa1d3bfac The feature was ill conceived, has terrible semantics, and has added nothing but regressions to the already fragile ipv6 stack. Fi

Re: [PATCH] net: ipv6: Delete host routes on an ifdown

2016-04-25 Thread David Ahern
On 4/25/16 1:26 PM, David Miller wrote: From: David Ahern Date: Thu, 21 Apr 2016 20:56:12 -0700 Dave: I realize this goes against your preference to keep routes cached on a down but this patch really emphasizes my point of all the dark corners to be handled. I've learned my les

Re: [PATCH] net: ipv6: Delete host routes on an ifdown

2016-04-25 Thread David Miller
From: David Ahern Date: Thu, 21 Apr 2016 20:56:12 -0700 > Dave: I realize this goes against your preference to keep routes cached > on a down but this patch really emphasizes my point of all the > dark corners to be handled. I've learned my lesson, I never should have put the origin

Re: [PATCH net-next] macvtap: add namespace support to the sysfs device class

2016-04-25 Thread Eric W. Biederman
Marc Angel writes: > When creating macvtaps that are expected to have the same ifindex > in different network namespaces, only the first one will succeed. > The others will fail with a sysfs_warn_dup warning due to them trying > to create the following sysfs link (with 'NN' the ifindex of macvtap

Re: [PATCH net v2 1/3] drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac config

2016-04-25 Thread Grygorii Strashko
On 04/22/2016 04:03 PM, Grygorii Strashko wrote: > On 04/21/2016 09:19 PM, David Rivshin (Allworx) wrote: >> From: David Rivshin >> >> Commit 9e42f715264ff158478fa30eaed847f6e131366b ("drivers: net: cpsw: add >> phy-handle parsing") saved the "phy-handle" phandle into a new cpsw_priv >> field. How

Re: [PATCH net v2 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

2016-04-25 Thread Grygorii Strashko
On 04/22/2016 06:45 PM, David Rivshin (Allworx) wrote: > On Fri, 22 Apr 2016 16:03:34 +0300 > Grygorii Strashko wrote: > >> On 04/21/2016 09:26 PM, David Rivshin (Allworx) wrote: >>> From: David Rivshin >>> >>> The phy-handle, phy_id, and fixed-link properties are mutually exclusive, >>> and onl

Re: [net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2016-04-25

2016-04-25 Thread David Miller
From: Jeff Kirsher Date: Mon, 25 Apr 2016 05:44:14 -0700 > This series contains updates to ixgbe and ixgbevf. Pulled, thanks Jeff.

Re: [PATCH net-next] macvtap: check minor when unregistering

2016-04-25 Thread Eric W. Biederman
Francesco Ruggeri writes: > macvtap_device_event(NETDEV_UNREGISTER) should check vlan->minor to > determine if it is being invoked in the context of a macvtap_newlink > that failed, for example in this code sequence: > > macvtap_newlink > macvlan_common_newlink > register_netdevice >

Re: [PATCH net-next] macvlan: fix failure during registration v3

2016-04-25 Thread Eric W. Biederman
Francesco Ruggeri writes: > If macvlan_common_newlink fails in register_netdevice after macvlan_init > then it decrements port->count twice, first in macvlan_uninit (from > register_netdevice or rollback_registered) and then again in > macvlan_common_newlink. > A similar problem may exist in the

Re: [PATCH net-next 0/9] netlink: align attributes when needed (patchset #2)

2016-04-25 Thread David Miller
From: Nicolas Dichtel Date: Mon, 25 Apr 2016 10:25:13 +0200 > This is the continuation (series #2) of the work done to align netlink > attributes when these attributes contain some 64-bit fields. > > In patch #3, I didn't modify the function ila_encap_nlsize(). I was waiting > feedback for this

Re: [PATCH v2 net-next] net: ethernet: enc28j60: add device tree support

2016-04-25 Thread Michael Heimpold
Hi, Am Monday 25 April 2016, 08:23:26 schrieb Rob Herring: > On Sun, Apr 24, 2016 at 11:28:03PM +0200, Michael Heimpold wrote: > > The following patch adds the required match table for device tree support > > (and while at, fix the indent). It's also possible to specify the > > MAC address in the

Re: [PATCH] [RFC] net: dsa: mv88e6xxx: Pre-initialize err in mv88e6xxx_port_bridge_join()

2016-04-25 Thread Vivien Didelot
Hi Geert, Geert Uytterhoeven writes: > Hi Vivien, > > On Mon, Apr 25, 2016 at 7:31 PM, Vivien Didelot > wrote: >> Geert Uytterhoeven writes: >>> On Mon, Apr 25, 2016 at 5:03 PM, Vivien Didelot >>> wrote: Geert Uytterhoeven writes: > drivers/net/dsa/mv88e6xxx.c: In function ‘mv88e6xx

Re: [PATCH RFC] b43: stop hardcoding LED behavior

2016-04-25 Thread Michael Büsch
On Mon, 25 Apr 2016 20:21:36 +0200 Lucas Stach wrote: > > Numbers please. Did you measure that is actually causes more > > _wakeups_? > > How many? > > The led work is placed in the mac80211 workqueue and LED updates only > > happen on behalf of mac80211 activities (by default). It only causes >

[net-next PATCH 5/8] mlx4: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-25 Thread Alexander Duyck
This patch assumes that the mlx4 hardware will ignore existing IPv4/v6 header fields for length and checksum as well as the length and checksum fields for outer UDP headers. Signed-off-by: Alexander Duyck --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 17 + 1 file changed

[net-next PATCH 7/8] mlx5e: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-25 Thread Alexander Duyck
This patch assumes that the mlx5 hardware will ignore existing IPv4/v6 header fields for length and checksum as well as the length and checksum fields for outer UDP headers. Signed-off-by: Alexander Duyck --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c |7 ++- 1 file changed, 6 ins

[net-next PATCH 8/8] mlx5e: Fix IPv6 tunnel checksum offload

2016-04-25 Thread Alexander Duyck
The mlx5 driver exposes support for TSO6 but not IPv6 csum for hardware encapsulated tunnels. This leads to issues as it triggers warnings in skb_checksum_help as it ends up being called as we report supporting the segmentation but not the checksumming for IPv6 frames. This patch corrects that an

[net-next PATCH 6/8] mlx4: Add support for inner IPv6 checksum offloads and TSO

2016-04-25 Thread Alexander Duyck
>From what I can tell the ConnectX-3 will support an inner IPv6 checksum and segmentation offload, however it cannot support outer IPv6 headers. For this reason I am adding the feature to the hw_enc_features and adding an extra check to the features_check call that will disable GSO and checksum of

[net-next PATCH 3/8] net: Fix netdev_fix_features so that TSO_MANGLEID is only available with TSO

2016-04-25 Thread Alexander Duyck
This change makes it so that we will strip the TSO_MANGLEID bit if TSO is not present. This way we will also handle ECN correctly of TSO is not present. Signed-off-by: Alexander Duyck --- net/core/dev.c |4 1 file changed, 4 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c i

[net-next PATCH 2/8] gso: Only allow GSO_PARTIAL if we can checksum the inner protocol

2016-04-25 Thread Alexander Duyck
This patch addresses a possible issue that can occur if we get into any odd corner cases where we support TSO for a given protocol but not the checksum or scatter-gather offload. There are few drivers floating around that setup their tunnels this way and by enforcing the checksum piece we can avoi

[net-next PATCH 4/8] vxlan: Add checksum check to the features check function

2016-04-25 Thread Alexander Duyck
We need to perform an additional check on the inner headers to determine if we can offload the checksum for them. Previously this check didn't occur so we would generate an invalid frame in the case of an IPv6 header encapsulated inside of an IPv4 tunnel. To fix this I added a secondary check to

[net-next PATCH 0/8] Fix Tunnel features and enable GSO partial for Mellanox adapters

2016-04-25 Thread Alexander Duyck
This patch series is meant to allow us to get the best performance possible for Mellanox ConnectX-3/4 adapters in terms of VXLAN tunnels. The first few patches address issues I found when just trying to collect performance numbers. Specifically I was unable to get rates of any more than 1 or 2 Mb

  1   2   >