Re: [PATCH v9 net-next 7/7] openvswitch: use ipgre tunnel rather than gretap tunnel

[CC Jiri Benc] On Thu, May 05, 2016 at 02:45:15PM -0700, pravin shelar wrote: > On Wed, May 4, 2016 at 12:36 AM, Simon Horman > wrote: > > This allows GRE tunnels to send and receive both > > layer 2 packets (packets with an ethernet header) and > > layer 3 packets (packets without an ethernet he

Re: [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

[CC Jiri Benc] On Thu, May 05, 2016 at 10:37:08AM -0700, pravin shelar wrote: > On Wed, May 4, 2016 at 12:36 AM, Simon Horman > wrote: > > From: Lorand Jakab > > > > Implementation of the pop_eth and push_eth actions in the kernel, and > > layer 3 flow support. > > > > This doesn't actually do a

Re: [PATCH v9 net-next 3/7] openvswitch: add support to push and pop mpls for layer3 packets

On Thu, May 05, 2016 at 10:35:52AM -0700, pravin shelar wrote: > On Wed, May 4, 2016 at 12:36 AM, Simon Horman > wrote: > > Allow push and pop mpls actions to act on layer 3 packets by teaching > > them not to access non-existent L2 headers of such packets. > > > > Signed-off-by: Simon Horman > >

Re: [PATCH net] net: bridge: fix old ioctl unlocked net device walk

From: Nikolay Aleksandrov Date: Wed, 4 May 2016 16:18:45 +0200 > get_bridge_ifindices() is used from the old "deviceless" bridge ioctl > calls which aren't called with rtnl held. The comment above says that it is > called with rtnl but that is not really the case. > Here's a sample output from a

Re: [PATCH] VSOCK: do not disconnect socket when peer has shutdown SEND only

From: Ian Campbell Date: Wed, 4 May 2016 14:21:53 +0100 > The peer may be expecting a reply having sent a request and then done a > shutdown(SHUT_WR), so tearing down the whole socket at this point seems > wrong and breaks for me with a client which does a SHUT_WR. > > Looking at other socket f

Re: [PATCH net] net/mlx4_en: Fix endianness bug in IPV6 csum calculation

From: Tariq Toukan Date: Wed, 4 May 2016 15:00:33 +0300 > From: Daniel Jurgens > > Use htons instead of unconditionally byte swapping nexthdr. On a little > endian systems shifting the byte is correct behavior, but it results in > incorrect csums on big endian architectures. > > Fixes: f8c64

Re: [PATCH v2 net-next] net/mlx4: Avoid wrong virtual mappings

From: Haggai Abramovsky Date: Wed, 4 May 2016 14:50:15 +0300 > The dma_alloc_coherent() function returns a virtual address which can > be used for coherent access to the underlying memory. On some > architectures, like arm64, undefined behavior results if this memory is > also accessed via virt

[PATCH net-next 6/7] samples/bpf: add 'pointer to packet' tests

parse_simple.c - packet parser exapmle with single length check that filters out udp packets for port 9 parse_varlen.c - variable length parser that understand multiple vlan headers, ipip, ipip6 and ip options to filter out udp or tcp packets on port 9. The packet is parsed layer by layer with mul

[PATCH net-next 2/7] bpf: direct packet access

Extended BPF carried over two instructions from classic to access packet data: LD_ABS and LD_IND. They're highly optimized in JITs, but due to their design they have to do length check for every access. When BPF is processing 20M packets per second single LD_ABS after JIT is consuming 3% cpu. Hence

[PATCH net-next 3/7] bpf: improve verifier state equivalence

since UNKNOWN_VALUE type is weaker than CONST_IMM we can un-teach verifier its recognition of constants in conditional branches without affecting safety. Ex: if (reg == 123) { .. here verifier was marking reg->type as CONST_IMM instead keep reg as UNKNOWN_VALUE } Two verifier states with UN

[PATCH net-next 5/7] bpf: add documentation for 'direct packet access'

explain how verifier checks safety of packet access and update email addresses. Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- Documentation/networking/filter.txt | 85 - 1 file changed, 83 insertions(+), 2 deletions(-) diff --git a/Document

[PATCH net-next 4/7] bpf: wire in data and data_end for cls_act_bpf

allow cls_bpf and act_bpf programs access skb->data and skb->data_end pointers. The bpf helpers that change skb->data need to update data_end pointer as well. The verifier checks that programs always reload data, data_end pointers after calls to such bpf helpers. We cannot add 'data_end' pointer to

[PATCH net-next 0/7] bpf: introduce direct packet access

This set of patches introduce 'direct packet access' from cls_bpf and act_bpf programs (which are root only). Current bpf programs use LD_ABS, LD_INS instructions which have to do 'if (off < skb_headlen)' for every packet access. It's ok for socket filters, but too slow for XDP, since single LD_AB

[PATCH net-next 7/7] samples/bpf: add verifier tests

add few tests for "pointer to packet" logic of the verifier Signed-off-by: Alexei Starovoitov --- samples/bpf/test_verifier.c | 80 + 1 file changed, 80 insertions(+) diff --git a/samples/bpf/test_verifier.c b/samples/bpf/test_verifier.c index 9eba8d1

[PATCH net-next 1/7] bpf: cleanup verifier code

cleanup verifier code and prepare it for addition of "pointer to packet" logic Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- kernel/bpf/verifier.c | 100 ++ 1 file changed, 53 insertions(+), 47 deletions(-) diff --git a/kernel/b

Re: [RFC PATCH net-next 20/20] net: dsa: mv88e6xxx: factorize the switch driver

> +config NET_DSA_MV88E6XXX > tristate "Marvell 88E6085/6095/6095F/6131 ethernet switch chip support" > depends on NET_DSA > - select NET_DSA_MV88E6XXX > select NET_DSA_TAG_EDSA > ---help--- > This enables support for the Marvell 88E6085/6095/6095F/6131 >

Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol

On Thu, May 05, 2016 at 06:41:03PM -0400, Vivien Didelot wrote: > 6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA. > Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all > other mv88e6xxx drivers. Hi Vivien You might as well remove net/dsa/tag_dsa.c as well

Re: [RFC PATCH net-next 14/20] net: dsa: mv88e6xxx: factorize VLAN Ethertype

On Thu, May 05, 2016 at 06:40:58PM -0400, Vivien Didelot wrote: > Only the 6131 driver was setting the VLAN Ethertype to 0x8100. Set it to > all models. > > Signed-off-by: Vivien Didelot > --- > drivers/net/dsa/mv88e6131.c | 9 - > drivers/net/dsa/mv88e6xxx.c | 8 > drivers/net/

Re: [RFC PATCH net-next 13/20] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL setup

On Thu, May 05, 2016 at 06:40:57PM -0400, Vivien Didelot wrote: > All switch models configure the GLOBAL_CONTROL register with slightly > differences. And as far as i know, we have no idea why. > Assume a common setup to enable the PHY Polling Unit if present, discard > packets with excessive co

Re: [RFC PATCH net-next 04/20] net: dsa: mv88e6xxx: factorize temperature access

> int mv88e6xxx_get_temp(struct dsa_switch *ds, int *temp) > { > struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > + int err; > + > + if (!mv88e6xxx_has(ps, MV88E6XXX_FLAG_TEMP)) > + return -EOPNOTSUPP; > + > + mutex_lock(&ps->smi_mutex); > > if (mv88e6xxx_

Re: [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU

> { > struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > int addr = mv88e6xxx_port_to_phy_addr(ps, port); > - int ret; > + int err; > > if (addr < 0) > return 0x; > > + We don't want an extra blank line. I'm surprised checkpatch did not warn about

Re: [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU

> -static int mv88e6xxx_ppu_access_get(struct mv88e6xxx_priv_state *ps) > +static int _mv88e6xxx_ppu_access_get(struct mv88e6xxx_priv_state *ps) Hi Vivien We agreed to stop adding _ to functions that assume the lock has been taken. Now that we check the lock is held in lowest level function, it q

Re: [PATCH nf-next 0/9] netfilter: remove per-netns conntrack tables, part 1

On 05/05/2016 06:36 PM, Florian Westphal wrote: Brian Haley wrote: I've seen cases where certain users are attacked, where the CT table is filled such that we start seeing "nf_conntrack: table full, dropping packet" messages (as expected). But other users continue to function normally, unaffec

Re: [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU

On Thu, May 05, 2016 at 06:40:45PM -0400, Vivien Didelot wrote: > Add a flags bitmap to the mv88e6xxx_info structure to help describing > features supported or not by a switch model. > > Add a MV88E6XXX_FLAG_PPU flag to describe switch models with a PHY > Polling Unit. This allows to merge PPU spe

[RFC PATCH net-next 00/20] net: dsa: mv88e6xxx: turn into monolithic driver

This patchset merges all mv88e6* drivers supported by the shared mv88e6xxx code into a single mv88e6xxx DSA switch driver. Some flags are added to describe the capabilities of a switch model, such as the presence of a PPU, EEPROM, some old or new registers, etc. First these flags are used to cond

[RFC PATCH net-next 10/20] net: dsa: mv88e6xxx: factorize ATU access

Add a MV88E6XXX_FLAG_ATU flag to identify switch models with an Address Translation Unit. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 4 drivers/net/dsa/mv88e6131.c | 12 drivers/net/dsa/mv88e6171.c | 12 drivers/net/dsa/mv88e6352.c | 18 ++

[RFC PATCH net-next 08/20] net: dsa: mv88e6xxx: factorize bridge support

Add MV88E6XXX_FLAG_PORTSTATE and MV88E6XXX_FLAG_VLANTABLE flags to identify switch models with required 802.1D operations. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 3 +++ drivers/net/dsa/mv88e6131.c | 13 + drivers/net/dsa/mv88e6171.c | 24

Re: [PATCH] tools: bpf_jit_disasm: check for klogctl failure

On 05/06/2016 12:39 AM, Colin King wrote: From: Colin Ian King klogctl can fail and return -ve len, so check for this and return NULL to avoid passing a (size_t)-1 to malloc. Signed-off-by: Colin Ian King [ would be nice to get Cc'ed in future ... ] Acked-by: Daniel Borkmann

Re: [RFC PATCH] gso: Replace SKB_GSO_IPIP and SKB_GSO_SIT with outer L3 types

On Thu, May 5, 2016 at 3:34 PM, Tom Herbert wrote: > I'm testing a similar change, it seems like a good idea. Okay, I wasn't sure if that was the case based on our last discussion. The bits for the drivers below more or less call out the drivers I am confident can handle V4 or V6 for tunnels. >

[RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU

Add a flags bitmap to the mv88e6xxx_info structure to help describing features supported or not by a switch model. Add a MV88E6XXX_FLAG_PPU flag to describe switch models with a PHY Polling Unit. This allows to merge PPU specific PHY access code in the share code. In the meantime, use unlocked reg

[RFC PATCH net-next 03/20] net: dsa: mv88e6xxx: factorize EEPROM access

Add a MV88E6XXX_FLAG_EEPROM flag to describe switch models featuring an EEPROM and distribute the EEPROM access routines to all models. In the meantime, change the static functions to use a mv88e6xxx_priv_state instead of a dsa_switch. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123

[RFC PATCH net-next 02/20] net: dsa: mv88e6xxx: factorize PHY indirect access

Some switch has dedicated SMI PHY Command and Data registers, used to indirectly access the PHYs, instead of direct access. Identify these switch models and make mv88e6xxx_phy_{read,write} generic enough to support every models. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 8

[PATCH net] netfilter: nf_conntrack: Use net_mutex for helper unregistration.

If a user loads nf_conntrack_ftp, sends FTP traffic through a network namespace, destroys that namespace then unloads the FTP helper module, then the kernel will crash. Florian's assessment of the bug: AFAIU following happens: 1. ct is created with ftp helper in netns x 2. netns x ge

[RFC PATCH net-next 07/20] net: dsa: mv88e6xxx: factorize registers access

Only 6131 was not supporting the port registers access yet. Assume such support and use the unlock access routines in the meantime. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6131.c | 2 ++ drivers/net/dsa/mv88e6xxx.c | 6 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff

[RFC PATCH net-next 06/20] net: dsa: mv88e6xxx: factorize EEE access

Add a MV88E6XXX_FLAG_EEE flag to describe switch models featuring Energy Efficient Ethernet. Use it to conditionally support such access in the common code. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 2 ++ drivers/net/dsa/mv88e6131.c | 2 ++ drivers/net/dsa/mv88e6171.c |

[RFC PATCH net-next 05/20] net: dsa: mv88e6xxx: factorize MAC address setting

Some switch models have a dedicated register for Switch MAC/WoF/WoL. This register, when present, is used to indirectly set the switch MAC address, instead of a direct write to 3 global registers. Identify this feature and share a common mv88e6xxx_set_addr function. Signed-off-by: Vivien Didelot

[RFC PATCH net-next 17/20] net: dsa: mv88e6xxx: factorize frames priorities

6131 is the only driver to setup the priority of IGMP/MLD snoop frames and ARP frames to the highest setting. Drop such change until we figure out a common configuration for all switch models. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6131.c | 18 -- 1 file changed,

[RFC PATCH net-next 11/20] net: dsa: mv88e6xxx: factorize switch reset

Add a MV88E6XXX_FLAG_PPU_ACTIVE flag to describe how to reset the switch, and merge the reset call to the common setup code. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 4 -- drivers/net/dsa/mv88e6131.c | 4 -- drivers/net/dsa/mv88e6171.c | 8 +-- drivers/net/dsa/mv88e6

[RFC PATCH net-next 14/20] net: dsa: mv88e6xxx: factorize VLAN Ethertype

Only the 6131 driver was setting the VLAN Ethertype to 0x8100. Set it to all models. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6131.c | 9 - drivers/net/dsa/mv88e6xxx.c | 8 drivers/net/dsa/mv88e6xxx.h | 7 +++ 3 files changed, 19 insertions(+), 5 deletions(-)

[RFC PATCH net-next 04/20] net: dsa: mv88e6xxx: factorize temperature access

Add MV88E6XXX_FLAG_TEMP and MV88E6XXX_FLAG_TEMP_LIMIT flags to describe switch models featuring a temperature access. Use them to centralize the access to the temperature feature. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 6 ++ drivers/net/dsa/mv88e6131.c | 6 ++

[RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol

6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA. Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all other mv88e6xxx drivers. Signed-off-by: Vivien Didelot --- drivers/net/dsa/Kconfig | 2 +- drivers/net/dsa/mv88e6131.c | 2 +- 2 files changed, 2 inse

[RFC PATCH net-next 15/20] net: dsa: mv88e6xxx: factorize GLOBAL_MONITOR_CONTROL setup

All switch drivers configure the GLOBAL_MONITOR_CONTROL register with slightly changes. Assume the setup of the upstream port, and configure it as the port to which ingress and egress and ARP monitor frames are to be sent. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 14 -

[RFC PATCH net-next 12/20] net: dsa: mv88e6xxx: factorize global setup

Every driver is calling mv88e6xxx_setup_global after mv88e6xxx_setup_common. Call the former in the latter. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 4 -- drivers/net/dsa/mv88e6131.c | 4 -- drivers/net/dsa/mv88e6171.c | 4 -- drivers/net/dsa/mv88e6352.c | 4 -- dr

[RFC PATCH net-next 13/20] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL setup

All switch models configure the GLOBAL_CONTROL register with slightly differences. Assume a common setup to enable the PHY Polling Unit if present, discard packets with excessive collisions, set the maximum frame size to 1632, and mask all interrupt sources. Signed-off-by: Vivien Didelot --- dr

[RFC PATCH net-next 16/20] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL_2 setup

All switch models setup the GLOBAL_CONTROL_2 register with slightly differences. Since the cascade mode is valid even in a single chip setup, factorize such configuration. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 15 --- drivers/net/dsa/mv88e6131.c | 16 --

[RFC PATCH net-next 20/20] net: dsa: mv88e6xxx: factorize the switch driver

Now that all drivers support the same set of functions and the same setup code, drop every model-specific DSA switch driver and replace them with a common mv88e6xxx driver. This merges the info tables into one, removes the function exports, the model-specific files, and update the defconfigs. Sig

[RFC PATCH net-next 09/20] net: dsa: mv88e6xxx: factorize VTU access

Add a MV88E6XXX_FLAG_VTU flag to indentify switch models with a VLAN Table Unit. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 5 + drivers/net/dsa/mv88e6131.c | 12 drivers/net/dsa/mv88e6171.c | 12 drivers/net/dsa/mv88e6352.c | 18 --

[RFC PATCH net-next 18/20] net: dsa: mv88e6xxx: factorize switch setup

Provide a shared mv88e6xxx_setup function to the drivers. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 16 +-- drivers/net/dsa/mv88e6131.c | 16 +-- drivers/net/dsa/mv88e6171.c | 16 +-- drivers/net/dsa/mv88e6352.c | 16 +-- drivers/net/dsa/mv88

[PATCH] tools: bpf_jit_disasm: check for klogctl failure

From: Colin Ian King klogctl can fail and return -ve len, so check for this and return NULL to avoid passing a (size_t)-1 to malloc. Signed-off-by: Colin Ian King --- tools/net/bpf_jit_disasm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/net/bpf_jit_disasm.c b/tools/net/bpf_ji

Re: [PATCH nf-next 0/9] netfilter: remove per-netns conntrack tables, part 1

Brian Haley wrote: > >>I've seen cases where certain users are attacked, where the CT table is > >>filled such that we start seeing "nf_conntrack: table full, dropping packet" > >>messages (as expected). But other users continue to function normally, > >>unaffected. Is this still the case - each

Re: [RFC PATCH] gso: Replace SKB_GSO_IPIP and SKB_GSO_SIT with outer L3 types

I'm testing a similar change, it seems like a good idea. On Thu, May 5, 2016 at 3:12 PM, Alexander Duyck wrote: > This patch removes SKB_GSO_IPIP and SKB_GSO_SIT and instead replaces them > with SKB_GSO_IPIPV4 and SKB_GSO_IPIPV6. The idea here is that SKB_GSO_IPIP > and SKB_GSO_SIT are actually

Re: [v10, 1/7] Documentation: DT: update Freescale DCFG compatible

On Thu, May 05, 2016 at 11:12:24AM +0800, Yangbo Lu wrote: > Update Freescale DCFG compatible with 'fsl,-dcfg' instead > of 'fsl,ls1021a-dcfg' to include more chips such as ls1021a, > ls1043a, and ls2080a. > > Signed-off-by: Yangbo Lu > --- > Changes for v8: > - Added this patch > Changes f

Re: [PATCH nf-next 0/9] netfilter: remove per-netns conntrack tables, part 1

On 05/05/2016 04:54 PM, Florian Westphal wrote: Brian Haley wrote: Openstack networking creates virtual routers using namespaces for isolation between users. VETH pairs are used to connect the interfaces on these routers to different networks, whether they are internal (private) or external (p

[RFC PATCH] gso: Replace SKB_GSO_IPIP and SKB_GSO_SIT with outer L3 types

This patch removes SKB_GSO_IPIP and SKB_GSO_SIT and instead replaces them with SKB_GSO_IPIPV4 and SKB_GSO_IPIPV6. The idea here is that SKB_GSO_IPIP and SKB_GSO_SIT are actually redundant as TCPV4 and TCPV6 were already representing the inner network header type. By reporting what the outer netwo

Re: [net-next PATCH v2 5/9] mlx4: Add support for UDP tunnel segmentation with outer checksum offload

On Thu, May 5, 2016 at 2:39 PM, Or Gerlitz wrote: > On Wed, May 4, 2016 at 7:06 PM, Alex Duyck wrote: >> On Wed, May 4, 2016 at 8:50 AM, Or Gerlitz wrote: >>> On 5/3/2016 6:29 PM, Alexander Duyck wrote: We split the one that would be a different size off via GSO. So we end up sen

Re: [PATCH v9 net-next 7/7] openvswitch: use ipgre tunnel rather than gretap tunnel

On Wed, May 4, 2016 at 12:36 AM, Simon Horman wrote: > This allows GRE tunnels to send and receive both > layer 2 packets (packets with an ethernet header) and > layer 3 packets (packets without an ethernet header). > > Signed-off-by: Simon Horman > --- > v9 > New Patch > --- > include/net/gre.h

Re: [net-next PATCH v2 5/9] mlx4: Add support for UDP tunnel segmentation with outer checksum offload

On Wed, May 4, 2016 at 7:06 PM, Alex Duyck wrote: > On Wed, May 4, 2016 at 8:50 AM, Or Gerlitz wrote: >> On 5/3/2016 6:29 PM, Alexander Duyck wrote: >>> >>> We split the one that would be a different size off via GSO. So we >>> end up sending up 2 frames to the device if there is going to be one

Re: [PATCH net-next v4] macvtap: add namespace support to the sysfs device class

From: Marc Angel Date: Thu, 5 May 2016 12:14:26 +0200 > When creating macvtaps that are expected to have the same ifindex > in different network namespaces, only the first one will succeed. > The others will fail with a sysfs_warn_dup warning due to them trying > to create the following sysfs li

Re: [PATCH 0/3] net-next: mediatek: improve phy support

Sorry, I'm not entertaining 3 seperate patch series for the same driver at one time. I'm removing all of these mediatek patches from my queue. Submit one series at a time please, thanks.

Re: [PATCH nf-next 0/9] netfilter: remove per-netns conntrack tables, part 1

Brian Haley wrote: > Openstack networking creates virtual routers using namespaces for isolation > between users. VETH pairs are used to connect the interfaces on these > routers to different networks, whether they are internal (private) or > external (public). In most cases NAT is done inside t

Re: mlx5 core/en oops in 4.6-rc6+

On Thu, May 5, 2016 at 8:16 PM, Doug Ledford wrote: > > That depends on which interface actually generated the oops. If it was > the base interface, then I don't manually set any special params on it. > If it's one of the vlan interfaces, then there is a NetworkManager > dispatcher script that is

Re: [PATCH nf-next 0/9] netfilter: remove per-netns conntrack tables, part 1

On 04/28/2016 01:13 PM, Florian Westphal wrote: [ CCing netdev so netns folks can have a look too ] This patch series removes the per-netns connection tracking tables. All conntrack objects are then stored in one global global table. This avoids the infamous 'vmalloc' when lots of namespaces ar

Re: [PATCH net-next 06/13] net: original ingress device index in PKTINFO

Hello, On Thu, 5 May 2016, David Ahern wrote: > On 5/5/16 2:41 AM, Julian Anastasov wrote: > > > + IPCB(skb)->iif = skb->skb_iif; > > > > For loopback traffic (including looped back multicast) > > this is now a zero :( Can inet_iif be moved to ip_rcv_finish > > instead? Still, we sp

Re: [PATCH net-next] vxlan: if_arp: introduce ARPHRD_VXLANGPE

On Thu, May 05, 2016 at 09:31:41PM +0200, Jiri Benc wrote: > On Thu, 5 May 2016 13:36:44 -0300, Thadeu Lima de Souza Cascardo wrote: > > Use ARPHRD_VXLANGPE to identify VxLAN GPE interfaces. This is going to be > > used > > to allow GPE interfaces to be added as openvswitch ports. > > What's wro

[PATCH net-next 2/2] net: original ingress device index in PKTINFO

Applications such as OSPF and BFD need the original ingress device not the VRF device; the latter can be derived from the former. To that end add the skb_iif to inet_skb_parm and set it in ipv4 code after clearing the skb control buffer similar to IPv6. From there the pktinfo can just pull it from

[PATCH net-next 1/2] net: l3mdev: Add hook in ip and ipv6

Currently the VRF driver uses the rx_handler to switch the skb device to the VRF device. Switching the dev prior to the ip / ipv6 layer means the VRF driver has to duplicate IP/IPv6 processing which adds overhead and makes features such as retaining the ingress device index more complicated than ne

[PATCH net-next 0/2] net: vrf: Fixup PKTINFO to return enslaved device index

Applications such as OSPF and BFD need the original ingress device not the VRF device; the latter can be derived from the former. To that end move the packet intercept from an rx handler that is invoked by __netif_receive_skb_core to the ipv4 and ipv6 receive processing. IPv6 already saves the s

Re: [PATCH] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

On 05/05/2016 12:19 PM, Wang YanQing wrote: We can't use kfree_skb in irq disable context, because spin_lock_irqsave make sure we are always in irq disable context, use dev_kfree_skb_irq instead of kfree_skb is better than dev_kfree_skb_any. This patch fix below kernel warning: [ 7612.095528] --

Re: [PATCH net-next] vxlan: if_arp: introduce ARPHRD_VXLANGPE

On Thu, 5 May 2016 13:36:44 -0300, Thadeu Lima de Souza Cascardo wrote: > Use ARPHRD_VXLANGPE to identify VxLAN GPE interfaces. This is going to be used > to allow GPE interfaces to be added as openvswitch ports. What's wrong with ARPHRD_NONE? I don't think we need a separate type for VXLAN-GPE.

Re: [PATCH] VSOCK: do not disconnect socket when peer has shutdown SEND only

On Wed, May 04, 2016 at 02:21:53PM +0100, Ian Campbell wrote: > The peer may be expecting a reply having sent a request and then done a > shutdown(SHUT_WR), so tearing down the whole socket at this point seems > wrong and breaks for me with a client which does a SHUT_WR. > > Looking at other socke

Re: [PATCH 2/3] net/mlx5e: make VXLAN support conditional

On Thursday 05 May 2016 19:44:36 Saeed Mahameed wrote: > On Wed, May 4, 2016 at 3:31 PM, Arnd Bergmann wrote: > > VXLAN can be disabled at compile-time or it can be a loadable > > module while mlx5 is built-in, which leads to a link error: > > > > drivers/net/built-in.o: In function `mlx5e_create_

Re: [PATCH net-next 14/14] ip4ip6: Support for GSO/GRO

On Thu, May 5, 2016 at 9:48 AM, Tom Herbert wrote: > On Wed, May 4, 2016 at 8:26 PM, Alexander Duyck > wrote: >> On Wed, May 4, 2016 at 6:20 PM, Eric Dumazet wrote: >>> On Wed, 2016-05-04 at 18:02 -0700, Tom Herbert wrote: Signed-off-by: Tom Herbert --- diff --git a/include/linux

Re: [PATCH v9 net-next 3/7] openvswitch: add support to push and pop mpls for layer3 packets

On Wed, May 4, 2016 at 12:36 AM, Simon Horman wrote: > Allow push and pop mpls actions to act on layer 3 packets by teaching > them not to access non-existent L2 headers of such packets. > > Signed-off-by: Simon Horman > --- > v9 > * New Patch > --- > net/openvswitch/actions.c | 22 +

Re: [PATCH 3/3] net-next: mediatek: add RX delay support

On 05/05/2016 14:13, Andrew Lunn wrote: > On Thu, May 05, 2016 at 11:17:36AM +0200, John Crispin wrote: >> If an external Gigabit PHY is connected to either of the MACs we need to >> tell the to use a RX delay. Not doing so will result in heavy packet loss >> and/or data corruption of RX traffic.

Re: [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

On Wed, May 4, 2016 at 12:36 AM, Simon Horman wrote: > From: Lorand Jakab > > Implementation of the pop_eth and push_eth actions in the kernel, and > layer 3 flow support. > > This doesn't actually do anything yet as no layer 2 tunnel ports are > supported yet. The original patch by Lorand was ag

[PATCH] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

We can't use kfree_skb in irq disable context, because spin_lock_irqsave make sure we are always in irq disable context, use dev_kfree_skb_irq instead of kfree_skb is better than dev_kfree_skb_any. This patch fix below kernel warning: [ 7612.095528] [ cut here ] [ 7612.0955

Re: mlx5 core/en oops in 4.6-rc6+

On 05/05/2016 12:42 PM, Saeed Mahameed wrote: > On Thu, May 5, 2016 at 7:00 PM, Doug Ledford wrote: >> Just had this pop up during testing, happened very soon after bootup: >> [ snip oops ] > Hi Doug, > > did you by change configure TC queues for the netdev ? i.e. dev->num_tc > 1 > if not i wo

Re: [PATCH 2/3] net/mlx5e: make VXLAN support conditional

On Wed, May 4, 2016 at 3:31 PM, Arnd Bergmann wrote: > VXLAN can be disabled at compile-time or it can be a loadable > module while mlx5 is built-in, which leads to a link error: > > drivers/net/built-in.o: In function `mlx5e_create_netdev': > ntb_netdev.c:(.text+0x106de4): undefined reference to

Re: [PATCH net-next 14/14] ip4ip6: Support for GSO/GRO

On Wed, May 4, 2016 at 8:26 PM, Alexander Duyck wrote: > On Wed, May 4, 2016 at 6:20 PM, Eric Dumazet wrote: >> On Wed, 2016-05-04 at 18:02 -0700, Tom Herbert wrote: >>> Signed-off-by: Tom Herbert >>> --- >>> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h >>> index 928b456..6a811fa

Re: mlx5 core/en oops in 4.6-rc6+

On Thu, May 5, 2016 at 7:00 PM, Doug Ledford wrote: > Just had this pop up during testing, happened very soon after bootup: > > [ 47.235925] BUG: unable to handle kernel NULL pointer dereference at > 01e8 > [ 47.245057] IP: [] mlx5e_sq_xmit+0x1c/0xd80 [mlx5_core] > [ 47.252822] P

[PATCH net-next] vxlan: if_arp: introduce ARPHRD_VXLANGPE

Use ARPHRD_VXLANGPE to identify VxLAN GPE interfaces. This is going to be used to allow GPE interfaces to be added as openvswitch ports. Signed-off-by: Thadeu Lima de Souza Cascardo Cc: Jiri Benc Cc: Simon Horman --- drivers/net/vxlan.c | 2 +- include/uapi/linux/if_arp.h | 1 + 2 file

Re: [PATCH net-next 01/14] gso: Remove arbitrary checks for unsupported GSO

On Thu, May 5, 2016 at 9:09 AM, Alexander Duyck wrote: > On Wed, May 4, 2016 at 7:59 PM, Alexander Duyck > wrote: >> On Wed, May 4, 2016 at 6:02 PM, Tom Herbert wrote: >>> In several gso_segment functions there are checks of gso_type against >>> a seemingly abitrary list of SKB_GSO_* flags. This

Re: [PATCH net-next 01/14] gso: Remove arbitrary checks for unsupported GSO

On Wed, May 4, 2016 at 7:59 PM, Alexander Duyck wrote: > On Wed, May 4, 2016 at 6:02 PM, Tom Herbert wrote: >> In several gso_segment functions there are checks of gso_type against >> a seemingly abitrary list of SKB_GSO_* flags. This seems like an >> attempt to identify unsupported GSO types, bu

Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support

On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote: > Recent new hardware has the ability to switch between tablet mode and > clamshell mode. To optimize WiFi performance, we want to be able to > use > different power table between modes. This patch adds a new netlink > message type and cfg802

mlx5 core/en oops in 4.6-rc6+

Just had this pop up during testing, happened very soon after bootup: [ 47.235925] BUG: unable to handle kernel NULL pointer dereference at 01e8 [ 47.245057] IP: [] mlx5e_sq_xmit+0x1c/0xd80 [mlx5_core] [ 47.252822] PGD 0 [ 47.255218] Oops: [#1] SMP [ 47.259070] Modules l

Re: [PATCH net-next 03/14] udp: Don't set skb->encapsulation with RCO

On Wed, May 4, 2016 at 7:42 PM, Alexander Duyck wrote: > On Wed, May 4, 2016 at 6:02 PM, Tom Herbert wrote: >> When RCO is in effect we want to ensure that the outer checksum is >> properly offloaded. Don't set skb->encapsulation in this case to >> ensure that checksum offload is later considered

Re: [PATCH net-next 03/14] udp: Don't set skb->encapsulation with RCO

On Thu, May 5, 2016 at 8:38 AM, Tom Herbert wrote: > On Wed, May 4, 2016 at 7:42 PM, Alexander Duyck > wrote: >> On Wed, May 4, 2016 at 6:02 PM, Tom Herbert wrote: >>> When RCO is in effect we want to ensure that the outer checksum is >>> properly offloaded. Don't set skb->encapsulation in this

[PATCH v2] rtlwifi: Remove double check for cnt_after_linked

rtl_lps_enter does two successive check for cnt_after_linked to make sure some time has elapsed after linked. The second check isn't necessary, because if cnt_after_linked is bigger than 5, it is bigger than 2 of course! This patch remove the second check code. Signed-off-by: Wang YanQing --- C

Re: [PATCH net-next 06/13] net: original ingress device index in PKTINFO

On 5/5/16 2:41 AM, Julian Anastasov wrote: Hello, On Wed, 4 May 2016, David Ahern wrote: Applications such as OSPF and BFD need the original ingress device not the VRF device; the latter can be derived from the former. To that end add the skb_iif to inet_skb_parm and set it in ipv4 co

Re: [net-next 08/15] i40e: Allow user to change input set mask for flow director

On 5/4/2016 8:22 PM, John Fastabend wrote: On 16-05-04 07:47 PM, Patil, Kiran wrote: On 4/26/2016 8:48 PM, David Miller wrote: From: Jeff Kirsher Date: Tue, 26 Apr 2016 13:55:41 -0700 From: Kiran Patil This patch implements feature, which allows user to change input set mask for flow direc

Re: [PATCH net-next 03/13] net: l3mdev: Allow send on enslaved interface

On 5/5/16 1:40 AM, Julian Anastasov wrote: diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 8c8c655bb2c4..a1f2830d8110 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2146,6 +2146,7 @@ struct rtable *__ip_route_output_key_hash(struct net *net, struct flowi4 *fl4, unsigned

Your mailbox is almost full

Self This e-mail address is now blocked from sending e-mail to other emails To keep your email active Click Here Service Desk

[patch 2/2] netxen: reversed condition in netxen_nic_set_link_parameters()

My static checker complains that we are using "autoneg" without initializing it. The problem is the ->phy_read() condition is reversed so we only set this on error instead of success. Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c b/drivers/net/eth

[patch] qede: uninitialized variable in qede_start_xmit()

"data_split" was never set to false. It's just uninitialized. Fixes: 2950219d87b0 ('qede: Add basic network device support') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index 60a61c3..d98f35e 100644 --- a

[patch] netxen: netxen_rom_fast_read() doesn't return -1

The error handling is broken here. netxen_rom_fast_read() returns zero on success and -EIO on error. It never returns -1. Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c index fd362b6..9c6eed

[patch] i40e: fix an uninitialized variable bug

We removed this initialization but it is required. Let's put it back. Fixes: 895106a577c4 ('i40e: trivial fixes') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_hmc.c index 5ebe12d..a7c7b1d 100644 --- a/drivers/net/et

[patch 1/2] netxen: fix error handling in netxen_get_flash_block()

My static checker complained that "v" can be used unintialized if netxen_rom_fast_read() returns -EIO. That function never actually returns -1. Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c inde

[PULL] virtio/qemu: fixes for 4.6

The following changes since commit c3b46c73264b03000d1e18b22f5caf63332547c9: Linux 4.6-rc4 (2016-04-17 19:13:32 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to e00f7bd221292b318d4d09c3f0

Re: A couple of questions about the SKB fragments

On (05/05/16 12:13), Edward Cree wrote: > On 05/05/16 08:40, Ilya Matveychikov wrote: > > > > While working with fragmented SKBs we've got stuck with the following: > > - is it possible for an SKB fragment in skb_shinfo(skb)->frag_list to > > be fragmented too (i.e. to have SKBs in frag_list)? > >

Re: [PATCH 00/12] net-next: mediatek: bug fixes and tx stall fixes

On Thu, May 05, 2016 at 11:26:13AM +0200, John Crispin wrote: > This series is a collection of fixes for bugs that we stumble across while > doing more performance testing and code level review. Hi John I just noticed the code uses kfree(mii_bus), rather than mdiobus_free(mii_bus). Andre

  1   2   >