[PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets

2016-06-07 Thread Shrikrishna Khare
The device emulation may send segCnt of 1 for LRO packets. Signed-off-by: Shrikrishna Khare Signed-off-by: Jin Heo --- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH net-next] net/mlx4_en: fix ethtool -x

2016-06-07 Thread Eric Dumazet
From: Eric Dumazet mlx4 RSS is limited to spread incoming packets to a power of two number of queues. An uniformly distibuted traffic would be split on queues 0 to N-1, N being a power of two, each queue having a 1/N weight. If number of RX queues is not a power of two,

[PATCH v2] udp reuseport: fix packet of same flow hashed to different socket

2016-06-07 Thread Su Xuemin
From: "Su, Xuemin" There is a corner case in which udp packets belonging to a same flow are hashed to different socket when hslot->count changes from 10 to 11: 1) When hslot->count <= 10, __udp_lib_lookup() searches udp_table->hash, and always passes 'daddr' to

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
> On Jun 7, 2016, at 9:22 PM, Alexander Duyck wrote: > > On Tue, Jun 7, 2016 at 12:48 PM, Philip Prindeville > wrote: >> From: Philip Prindeville >> >> In the presence of firewalls which improperly block

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Alexander Duyck
On Tue, Jun 7, 2016 at 12:48 PM, Philip Prindeville wrote: > From: Philip Prindeville > > In the presence of firewalls which improperly block ICMP Unreachable > (including Fragmentation Required) messages, Path MTU Discovery is >

Re: rhashtable - rhashtable_insert_fast failed

2016-06-07 Thread Herbert Xu
On Tue, Jun 07, 2016 at 04:47:28PM +0200, Helge Deller wrote: > On 07.06.2016 16:16, Herbert Xu wrote: > > On Tue, Jun 07, 2016 at 04:13:50PM +0200, Helge Deller wrote: > >> > >> What warnings do you mean specifically? Some specific CONFIG_ option ? > > > > Look for GFP_NOWARN in lib/rhashtable.c

RE: [bug discuss] fjes driver call trace warning, "PNP0C02" used in fjes seems like a bug,

2016-06-07 Thread Izumi, Taku
Dear Gab, > > > > I think that "PNP0C02" should be used to mark any motherboard > > reserved > > > > resource and not a specific network driver. > > > > It seems like a bug in the "fjes" driver. > > > > Extended Socket network device is a shared memory based high-speed > > network interface

Re: [PATCH] ping: ICMP error replies while errno < 0 is a hard error

2016-06-07 Thread YOSHIFUJI Hideaki
Hi, Jason A. Donenfeld wrote: > There are some odd conditions in which a device will return an error for > sendto, while at the same time an ICMP error response is generated. In > this case, with the current code, the packet is retransmitted in a > flood, which is not what anybody wants. In fact,

[net-next:master 105/106] DockBook: net/core/gen_stats.c:168: warning: No description found for parameter 'running'

2016-06-07 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 34fe76abbea5174e532681e420fb31139909efb4 commit: edb09eb17ed89eaa82a52dd306beac93e292b485 [105/106] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump reproduce: make htmldocs All warnings

linux-next: manual merge of the net-next tree with the net tree

2016-06-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/sched/act_police.c between commit: 53eb440f4ada ("net sched actions: introduce timestamp for firsttime use") from the net tree and commit: a03e6fe56971 ("act_police: fix a crash during removal") from the

[net-next:master 104/106] DockBook: include/linux/netdevice.h:1867: warning: No description found for parameter 'qdisc_running_key'

2016-06-07 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 34fe76abbea5174e532681e420fb31139909efb4 commit: f9eb8aea2a1e12fc2f584d1627deeb957435a801 [104/106] net_sched: transform qdisc running bit into a seqcount reproduce: make htmldocs All warnings (new ones

Re: [PATCH][RT] netpoll: Always take poll_lock when doing polling

2016-06-07 Thread Alison Chaiken
I wrote: >>We've applied Sebastian's commit "softirq: split timer softirqs out of >>ksoftirqd," which improved event loop stability substantially when we Sebastian Andrzej Siewior replied: >Why did you apply that one? You have 4.1.18-ti-rt so I don't know how >that works

Re: [PATCH 0/2] Netfilter/IPVS fixes for net

2016-06-07 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 7 Jun 2016 00:38:15 +0200 > The following patchset contains two Netfilter/IPVS fixes for your net > tree, they are: > > 1) Fix missing alignment in next offset calculation for standard >targets, introduced in the previous merge

Re: [PATCH net] tcp: record TLP and ER timer stats in v6 stats

2016-06-07 Thread David Miller
From: Yuchung Cheng Date: Mon, 6 Jun 2016 15:07:18 -0700 > The v6 tcp stats scan do not provide TLP and ER timer information > correctly like the v4 version . This patch fixes that. > > Fixes: 6ba8a3b19e76 ("tcp: Tail loss probe (TLP)") > Fixes: eed530b6c676 ("tcp: early

Re: [PATCH -next] cbq: remove only caller of qdisc->drop()

2016-06-07 Thread David Miller
From: Florian Westphal Date: Mon, 6 Jun 2016 23:20:27 +0200 > since initial revision of cbq in 2004 iproute2 never implemented > support for TCA_CBQ_OVL_STRATEGY, which is what needs to be set to > activate the class->drop() call (TC_CBQ_OVL_DROP strategy must be > set by

Re: [PATCH net] net: sched: fix tc_should_offload for specific clsact classes

2016-06-07 Thread David Miller
From: Daniel Borkmann Date: Mon, 6 Jun 2016 22:50:39 +0200 > When offloading classifiers such as u32 or flower to hardware, and the > qdisc is clsact (TC_H_CLSACT), then we need to differentiate its classes, > since not all of them handle ingress, therefore we must leave

Re: [PATCH net-next 2/2] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump

2016-06-07 Thread Cong Wang
On Mon, Jun 6, 2016 at 4:53 PM, Eric Dumazet wrote: > Really sounds overkill to care about these, as probably no one needs to > get a 'consistent view of all these counters in a snapshot'. > > Even as of today, the qlen/backlog pair is wrong. No one ever used these >

Re: [Patch net v2] act_police: fix a crash during removal

2016-06-07 Thread David Miller
From: Cong Wang Date: Mon, 6 Jun 2016 09:54:30 -0700 > The police action is using its own code to initialize tcf hash > info, which makes us to forgot to initialize a->hinfo correctly. > Fix this by calling the helper function tcf_hash_create() directly. > > This

Re: [PATCH net-next 0/2] net: sched: faster stats gathering

2016-06-07 Thread David Miller
From: Eric Dumazet Date: Mon, 6 Jun 2016 09:37:14 -0700 > A while back, I sent one RFC patch using lockless stats gathering > on 64bit arches. > > This patch series does it more cleanly, using a seqcount. > > Since qdisc/class stats are written at dequeue() time, > we can

[PATCH net-next v4 3/6] net: dsa: Provide a slave MII bus if needed

2016-06-07 Thread Florian Fainelli
Mimic what net/dsa/dsa.c does and provide a slave MII bus by default which will be created if the driver implements a phy_read method. Reviewed-by: Andrew Lunn Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli

[PATCH net-next v4 2/6] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask

2016-06-07 Thread Florian Fainelli
Some drivers rely on these two bitmasks to contain the correct values for them to successfully probe and initialize at drv->setup() time, calculate correct values to put in both masks as early as possible in dsa_get_ports_dn(). Reviewed-by: Andrew Lunn Signed-off-by: Florian

[PATCH net-next v4 1/6] net: dsa: Provide unique DSA slave MII bus names

2016-06-07 Thread Florian Fainelli
In case we have multiples trees and switches with the same index, we need to add another discriminating id: the switch tree. Reviewed-by: Andrew Lunn Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli ---

[PATCH net-next v4 0/6] net: dsa: misc improvements

2016-06-07 Thread Florian Fainelli
Hi all, This patch series builds on top of Andrew's "New DSA bind, switches as devices" patch set and does the following: - add a few helper functions/goodies for net/dsa/dsa2.c to be as close as possible from net/dsa/dsa.c in terms of what drivers can expect, in particular the slave MDIO

[PATCH net-next v4 4/6] net: dsa: Add initialization helper for CPU port ethtool_ops

2016-06-07 Thread Florian Fainelli
Add a helper function: dsa_cpu_port_ethtool_init() which initializes a custom ethtool_ops structure with custom DSA ethtool operations for CPU ports. This is a preliminary change to move the initialization outside of net/dsa/slave.c. Reviewed-by: Vivien Didelot

[PATCH net-next v4 6/6] net: dsa: bcm_sf2: Register our slave MDIO bus

2016-06-07 Thread Florian Fainelli
Register a slave MDIO bus which allows us to divert problematic read/writes towards conflicting pseudo-PHY address (30). Do no longer rely on DSA's slave_mii_bus, but instead provide our own implementation which offers more flexibility as to what to do, and when to register it. We need to

[PATCH net-next v4 5/6] net: dsa: Initialize CPU port ethtool ops per tree

2016-06-07 Thread Florian Fainelli
Now that we can properly support multiple distinct trees in the system, using a global variable: dsa_cpu_port_ethtool_ops is getting clobbered as soon as the second switch tree gets probed, and we don't want that. We need to move this to be dynamically allocated, and since we can't really be

Re: [PATCH net] fq_codel: return non zero qlen in class dumps

2016-06-07 Thread David Miller
From: Eric Dumazet Date: Mon, 06 Jun 2016 09:12:39 -0700 > From: Eric Dumazet > > We properly scan the flow list to count number of packets, > but John passed 0 to gnet_stats_copy_queue() so we report > a zero value to user space instead of the

Re: [PATCH net 0/2] cls_u32 hardware offload fixes

2016-06-07 Thread David Miller
From: Jakub Kicinski Date: Mon, 6 Jun 2016 16:16:46 +0100 > This set fixes two small issues with error codes I noticed > in cls_u32. Second patch could be viewed as user space API > change but that portion of API is not part of any release, > yet. > > Compile

Re: [PATCH][RESEND] gtp: #define _UAPI_LINUX_GTP_H_ and not _UAPI_LINUX_GTP_H__

2016-06-07 Thread David Miller
From: Colin King Date: Mon, 6 Jun 2016 16:08:41 +0100 > From: Colin Ian King > > Fix clang build warning: > > ./include/uapi/linux/gtp.h:1:9: warning: '_UAPI_LINUX_GTP_H_' is > used as a header guard here, followed by #define of a different

Re: [PATCH 01/12] net: mediatek: fix DQL support

2016-06-07 Thread Tom Herbert
On Tue, Jun 7, 2016 at 4:01 PM, David Miller wrote: > From: John Crispin > Date: Mon, 6 Jun 2016 08:43:13 +0200 > >> i think one solution would be to add some code to have 2 devices share >> the same dql instance. would that be an acceptable solution ? > >

Re: [PATCH net] l2tp: fix configuration passed to setup_udp_tunnel_sock()

2016-06-07 Thread David Miller
From: Guillaume Nault Date: Mon, 6 Jun 2016 13:48:02 +0200 > @@ -1581,7 +1581,7 @@ int l2tp_tunnel_create(struct net *net, int fd, int > version, u32 tunnel_id, u32 > /* Mark socket as an encapsulation socket. See net/ipv4/udp.c */ > tunnel->encap = encap; >

Re: [net-next PATCH 0/3] be2net: patch set

2016-06-07 Thread David Miller
From: Sathya Perla Date: Mon, 6 Jun 2016 07:22:07 -0400 > Hi David, the following patch set contains three non-critical fixes that > can go into the net-next tree. > > Patch 1 fixes the logic for provisioning queue pairs on VFs to take into > account the limit on

Re: [PATCH][V2] net: fec: fix spelling mistakes and add missing newline

2016-06-07 Thread David Miller
From: Colin King Date: Mon, 6 Jun 2016 09:21:44 +0100 > From: Colin Ian King > > trivial fix to spelling mistakes and add missing newline in pr_err > messages > > Signed-off-by: Colin Ian King Applied.

[PATCH net-next] ila: Perform only one translation in forwarding path

2016-06-07 Thread Tom Herbert
When setting up ILA in a router we noticed that the the encapsulation is invoked twice: once in the route input path and again upon route output. To resolve this we add a flag set_csum_neutral for the ila_update_ipv6_locator. If this flag is set and the checksum neutral bit is also set we assume

Terveisiä

2016-06-07 Thread Aspire Money Loan
Terveisiä,   Olen rouva Annie Ethan yksityiseltä lainanantajayhtiöllä tunnetaan Aspire Money Loan®. Tarjoamme kaikenlaisia laina 3% korolla. Jos olet tarvitsevat lainaa ystävällisesti yhteyttä kanssa alla tiedot. Koko nimi: sukupuoli: Maa: Osoite: Lainan määrä: Kesto: Puh: Odotamme

Re: [PATCH] netfilter/nflog: nflog-range does not truncate packets

2016-06-07 Thread Vishwanath Pai
On 06/06/2016 06:31 PM, Pablo Neira Ayuso wrote: > On Wed, Jun 01, 2016 at 08:23:54PM -0400, Vishwanath Pai wrote: >> netfilter/nflog: nflog-range does not truncate packets >> >> The --nflog-range parameter from userspace is ignored in the kernel and >> the entire packet is sent to the userspace.

[PATCH iproute2] tc: f_u32: Add support for skip_hw and skip_sw flags

2016-06-07 Thread Sridhar Samudrala
On devices that support TC U32 offloads, these flags enable a filter to be added only to HW or only to SW. skip_sw and skip_hw are mutually exclusive flags. By default without any flags, the filter is added to both HW and SW, but no error checks are done in case of failure to add to HW. With

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

2016-06-07 Thread David Miller
From: Michael Chan Date: Mon, 6 Jun 2016 02:37:13 -0400 > Fix a race condition and VLAN rx acceleration logic. Series applied.

Re: [PATCH 01/12] net: mediatek: fix DQL support

2016-06-07 Thread David Miller
From: John Crispin Date: Mon, 6 Jun 2016 08:43:13 +0200 > i think one solution would be to add some code to have 2 devices share > the same dql instance. would that be an acceptable solution ? You still need to address the issue of synchronization. dql purposefully doesn't

Re: [ldv-project] [net] libertas: potential race condition

2016-06-07 Thread James Cameron
On Tue, Jun 07, 2016 at 09:39:55AM -0500, Dan Williams wrote: > On Tue, 2016-06-07 at 13:30 +0400, Pavel Andrianov wrote: > > Hi! > > > > There is a potential race condition in  > > drivers/net/wireless/libertas/libertas.ko. > > In the function lbs_hard_start_xmit(..), line 159, a socket buffer >

Re: [Patch v3 2/5] fsl/qe: setup clock source for TDM mode

2016-06-07 Thread David Miller
From: Zhao Qiang Date: Mon, 6 Jun 2016 14:29:59 +0800 > Add tdm clock configuration in both qe clock system and ucc > fast controller. > > Signed-off-by: Zhao Qiang Applied.

Re: [Patch v3 1/5] fsl/qe: add rx_sync and tx_sync for TDM mode

2016-06-07 Thread David Miller
From: Zhao Qiang Date: Mon, 6 Jun 2016 14:29:58 +0800 > Rx_sync and tx_sync are used by QE-TDM mode, > add them to struct ucc_fast_info. > > Signed-off-by: Zhao Qiang Applied.

Re: [Patch v3 3/5] fsl/qe: Make regs resouce_size_t

2016-06-07 Thread David Miller
From: Zhao Qiang Date: Mon, 6 Jun 2016 14:30:00 +0800 > Signed-off-by: Zhao Qiang Applied.

Re: [Patch v3 4/5] fsl/qe: Add QE TDM lib

2016-06-07 Thread David Miller
From: Zhao Qiang Date: Mon, 6 Jun 2016 14:30:01 +0800 > QE has module to support TDM, some other protocols > supported by QE are based on TDM. > add a qe-tdm lib, this lib provides functions to the protocols > using TDM to configurate QE-TDM. > > Signed-off-by: Zhao Qiang

Re: [Patch v3 5/5] drivers/net: support hdlc function for QE-UCC

2016-06-07 Thread David Miller
From: Zhao Qiang Date: Mon, 6 Jun 2016 14:30:02 +0800 > The driver add hdlc support for Freescale QUICC Engine. > It support NMSI and TSA mode. > > Signed-off-by: Zhao Qiang Applied.

Re: [PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-06-07 Thread Alexei Starovoitov
On Tue, Jun 07, 2016 at 07:02:23PM +0530, Naveen N. Rao wrote: > PPC64 eBPF JIT compiler. > > Enable with: > echo 1 > /proc/sys/net/core/bpf_jit_enable > or > echo 2 > /proc/sys/net/core/bpf_jit_enable > > ... to see the generated JIT code. This can further be processed with >

Re: [PATCH net-next v3 4/6] net: dsa: Add initialization helper for CPU port ethtool_ops

2016-06-07 Thread Vivien Didelot
Florian Fainelli writes: > Add a helper function: dsa_cpu_port_ethtool_init() which initializes a > custom ethtool_ops structure with custom DSA ethtool operations for CPU > ports. This is a preliminary change to move the initialization outside > of net/dsa/slave.c. > >

Re: [PATCH v2 net-next 0/3] net sched action timestamp improvements

2016-06-07 Thread David Miller
From: Jamal Hadi Salim Date: Mon, 6 Jun 2016 06:32:52 -0400 > From: Jamal Hadi Salim > > Various aggregations of duplicated code, fixes and introduction of firstused > timestamp > > v2: add const for source time info per suggestion from Cong Series

Re: [PATCH net-next v3 3/6] net: dsa: Provide a slave MII bus if needed

2016-06-07 Thread Vivien Didelot
Florian Fainelli writes: > Mimic what net/dsa/dsa.c does and provide a slave MII bus by default > which will be created if the driver implements a phy_read method. > > Signed-off-by: Florian Fainelli Reviewed-by: Vivien Didelot

Re: [PATCH net-next] net/sched: cls_flower: Introduce support in SKIP SW flag

2016-06-07 Thread David Miller
From: Amir Vadai Date: Sun, 5 Jun 2016 17:11:18 +0300 > From: Amir Vadai > > In order to make a filter processed only by hardware, skip_sw flag > should be supplied. This is an addition to the already existing skip_hw > flag (filter will be processed by

Re: [PATCH net-next v10 4/5] openvswitch: add layer 3 flow/port support

2016-06-07 Thread pravin shelar
On Mon, Jun 6, 2016 at 7:46 PM, Simon Horman wrote: > On Thu, Jun 02, 2016 at 03:02:18PM -0700, pravin shelar wrote: >> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman >> wrote: > > [...] > >> > diff --git a/net/openvswitch/actions.c

Re: [PATCH net-next v10 3/5] openvswitch: add support to push and pop mpls for layer3 packets

2016-06-07 Thread pravin shelar
On Mon, Jun 6, 2016 at 7:51 PM, Simon Horman wrote: > On Thu, Jun 02, 2016 at 03:02:00PM -0700, pravin shelar wrote: >> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman >> wrote: >> > Allow push and pop mpls actions to act on layer 3 packets

Re: [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-07 Thread pravin shelar
On Mon, Jun 6, 2016 at 8:08 PM, Simon Horman wrote: > On Thu, Jun 02, 2016 at 03:01:47PM -0700, pravin shelar wrote: >> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman >> wrote: >> > * Set skb protocol based on contents of packet. I have

Re: [PATCH net-next 0/6] qed: IOV series - relax firmware requirements

2016-06-07 Thread David Miller
From: Yuval Mintz Date: Sun, 5 Jun 2016 13:11:10 +0300 > In order for VFs to work, current implementation demands that the VF's > requried storm firmware would be exactly the version that was loaded by > the PF, which is a very harsh requirement. > This patch series is

Re: [PATCH v2 net] fq_codel: fix NET_XMIT_CN behavior

2016-06-07 Thread David Miller
From: Eric Dumazet Date: Sat, 04 Jun 2016 12:55:13 -0700 > From: Eric Dumazet > > My prior attempt to fix the backlogs of parents failed. > > If we return NET_XMIT_CN, our parents wont increase their backlog, > so our qdisc_tree_reduce_backlog()

Re: [PATCH net-next] net: get rid of spin_trylock() in net_tx_action()

2016-06-07 Thread David Miller
From: Eric Dumazet Date: Sat, 04 Jun 2016 20:02:28 -0700 > From: Eric Dumazet > > Note: Tom Herbert posted almost same patch 3 months back, but for > different reasons. > > The reasons we want to get rid of this spin_trylock() are : > > 1) Under

Re: [PATCHv3 net 3/3] net: cls_u32: catch all hardware offload errors

2016-06-07 Thread Samudrala, Sridhar
On 6/7/2016 3:17 PM, Jakub Kicinski wrote: Errors reported by u32_replace_hw_hnode() were not propagated. Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena --- v3: - new patch Acked-by: Sridhar Samudrala

Re: [PATCHv3 net 2/3] net: cls_u32: be more strict about skip-sw flag

2016-06-07 Thread Samudrala, Sridhar
On 6/7/2016 3:17 PM, Jakub Kicinski wrote: Return an error if user requested skip-sw and the underlaying hardware cannot handle tc offloads (or offloads are disabled). Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena

Re: [PATCH] rxrpc: fix ptr_ret.cocci warnings

2016-06-07 Thread David Miller
From: kbuild test robot Date: Sun, 5 Jun 2016 07:17:19 +0800 > net/rxrpc/rxkad.c:1165:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > CC: David

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
On 06/07/2016 04:23 PM, Hannes Frederic Sowa wrote: On 07.06.2016 22:42, Philip Prindeville wrote: On 06/07/2016 02:23 PM, Hannes Frederic Sowa wrote: On Tue, Jun 7, 2016, at 21:48, Philip Prindeville wrote: static struct rtnl_link_ops ipgre_link_ops __read_mostly = { diff --git

Re: [PATCH net-next v3 5/6] net: dsa: Initialize CPU port ethtool ops per tree

2016-06-07 Thread Andrew Lunn
On Tue, Jun 07, 2016 at 03:13:35PM -0700, Florian Fainelli wrote: > On 06/07/2016 02:51 PM, Andrew Lunn wrote: > >> +int dsa_cpu_port_ethtool_setup(struct dsa_switch_tree *dst, > >> + struct dsa_switch *ds) > >> +{ > >> + struct net_device *master; > >> + struct

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Hannes Frederic Sowa
On 07.06.2016 22:42, Philip Prindeville wrote: > On 06/07/2016 02:23 PM, Hannes Frederic Sowa wrote: >> >> On Tue, Jun 7, 2016, at 21:48, Philip Prindeville wrote: >>> static struct rtnl_link_ops ipgre_link_ops __read_mostly = { >>> diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c >>>

[PATCHv3 net 3/3] net: cls_u32: catch all hardware offload errors

2016-06-07 Thread Jakub Kicinski
Errors reported by u32_replace_hw_hnode() were not propagated. Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena --- v3: - new patch net/sched/cls_u32.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff

[PATCHv3 net 0/3] cls_u32 hardware offload fixes

2016-06-07 Thread Jakub Kicinski
Hi! This set fixes three small issues with error codes I noticed in cls_u32. Second patch could be viewed as user space API change but that portion of API is not part of any release, yet. Very lightly tested. Jakub Kicinski (3): net: cls_u32: fix error code for invalid flags net: cls_u32:

[PATCHv3 net 1/3] net: cls_u32: fix error code for invalid flags

2016-06-07 Thread Jakub Kicinski
'err' variable is not set in this test, we would return whatever previous test set 'err' to. Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena Reviewed-by: Simon Horman Acked-by: Sridhar

[PATCHv3 net 2/3] net: cls_u32: be more strict about skip-sw flag

2016-06-07 Thread Jakub Kicinski
Return an error if user requested skip-sw and the underlaying hardware cannot handle tc offloads (or offloads are disabled). Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena Reviewed-by: Simon Horman

Re: [PATCH net-next v3 5/6] net: dsa: Initialize CPU port ethtool ops per tree

2016-06-07 Thread Florian Fainelli
On 06/07/2016 02:51 PM, Andrew Lunn wrote: >> +int dsa_cpu_port_ethtool_setup(struct dsa_switch_tree *dst, >> + struct dsa_switch *ds) >> +{ >> +struct net_device *master; >> +struct ethtool_ops *cpu_ops; >> + >> +master = ds->dst->master_netdev; > > You pass

Re: [PATCH net 0/3] RDS: TCP: socket locking RDS packet assembly fixes

2016-06-07 Thread David Miller
From: Sowmini Varadhan Date: Sat, 4 Jun 2016 13:59:57 -0700 > This three part patchset fixes bugs in synchronization between > rds_tcp_accept_one() and the rds-tcp send/recv path. > > Patch 1 ensures that the lock_sock() is taken appropriately > and the RDS

Re: [PATCH net-next 00/15] net/smc: Shared Memory Communications - RDMA

2016-06-07 Thread David Miller
In case my previous reply wasn't clear enough, I require that you provide a more accurate description of what the implications of this feature are. Namely, that important _CORE_ networking features are completely bypassed and unusable when SMC applies to a connection. Specifically, all packet

[PATCH net-next v2 1/3] bgmac: Bind net_device with backing device structure

2016-06-07 Thread Florian Fainelli
In preparation for allowing different helpers to be utilized against network devices created by the bgmac driver, make sure that we bind the net_device with core->dev. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bgmac.c | 1 + 1 file changed, 1

[PATCH net-next v2 2/3] bgmac: Add support for ethtool statistics

2016-06-07 Thread Florian Fainelli
Read the statistics from the BGMAC's builtin MAC and return them to user-space using the standard ethtool helpers. Signed-off-by: Florian Fainelli --- Changes in v2: - use strlcpy() - properly fix the latching of the hi/lo reads - remove redundant cast

[PATCH net-next v2 0/3] net: bgmac: Misc improvements

2016-06-07 Thread Florian Fainelli
Hi David, Rafal, Hauke, Felix, This patch series add minor changes to the bgmac driver: - properly bind net_device with its backing device structure such that we can locate the device using common helper functions - add support for ethtool statistics reading the HW MIB counters which is

[PATCH net-next v2 3/3] bgmac: Maintain some netdev statistics

2016-06-07 Thread Florian Fainelli
Add a few netdev statistics to report transmitted and received bytes and packets and a few obvious errors. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bgmac.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH net-next v3 5/6] net: dsa: Initialize CPU port ethtool ops per tree

2016-06-07 Thread Andrew Lunn
> +int dsa_cpu_port_ethtool_setup(struct dsa_switch_tree *dst, > +struct dsa_switch *ds) > +{ > + struct net_device *master; > + struct ethtool_ops *cpu_ops; > + > + master = ds->dst->master_netdev; You pass in dst as a parameter, and then don't use it! >

Re: [PATCH net] bpf, trace: use READ_ONCE for retrieving file ptr

2016-06-07 Thread David Miller
From: Daniel Borkmann Date: Sat, 4 Jun 2016 20:50:59 +0200 > In bpf_perf_event_read() and bpf_perf_event_output(), we must use > READ_ONCE() for fetching the struct file pointer, which could get > updated concurrently, so we must prevent the compiler from potential >

Re: [PATCH V3 1/2] vhost_net: stop polling socket during rx processing

2016-06-07 Thread David Miller
From: Jason Wang Date: Wed, 1 Jun 2016 01:56:33 -0400 > We don't stop rx polling socket during rx processing, this will lead > unnecessary wakeups from under layer net devices (E.g > sock_def_readable() form tun). Rx will be slowed down in this > way. This patch avoids this

Re: [PATCH net-next v3 3/6] net: dsa: Provide a slave MII bus if needed

2016-06-07 Thread Andrew Lunn
On Tue, Jun 07, 2016 at 02:06:53PM -0700, Florian Fainelli wrote: > Mimic what net/dsa/dsa.c does and provide a slave MII bus by default > which will be created if the driver implements a phy_read method. > > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn

Re: [PATCH net-next v3 2/6] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask

2016-06-07 Thread Andrew Lunn
On Tue, Jun 07, 2016 at 02:06:52PM -0700, Florian Fainelli wrote: > Some drivers rely on these two bitmasks to contain the correct values > for them to successfully probe and initialize at drv->setup() time, > calculate correct values to put in both masks as early as possible in >

Re: [PATCH net v2] sfc: report supported link speeds on SFP connections

2016-06-07 Thread Jarod Wilson
On Mon, Jun 06, 2016 at 02:55:29PM -0400, Jarod Wilson wrote: > On Mon, Jun 06, 2016 at 05:29:30PM +0100, Bert Kenward wrote: > > 7000-series SFC NICs connected with an SFP+ module currently fail to > > report any supported link speeds. > > > > Reported-by: Jarod Wilson > >

[PATCH net-next v3 6/6] net: dsa: bcm_sf2: Register our slave MDIO bus

2016-06-07 Thread Florian Fainelli
Register a slave MDIO bus which allows us to divert problematic read/writes towards conflicting pseudo-PHY address (30). Do no longer rely on DSA's slave_mii_bus, but instead provide our own implementation which offers more flexibility as to what to do, and when to register it. We need to

[PATCH net-next v3 5/6] net: dsa: Initialize CPU port ethtool ops per tree

2016-06-07 Thread Florian Fainelli
Now that we can properly support multiple distinct trees in the system, using a global variable: dsa_cpu_port_ethtool_ops is getting clobbered as soon as the second switch tree gets probed, and we don't want that. We need to move this to be dynamically allocated, and since we can't really be

[PATCH net-next v3 0/6] net: dsa: misc improvements

2016-06-07 Thread Florian Fainelli
Hi all, This patch series builds on top of Andrew's "New DSA bind, switches as devices" patch set and does the following: - add a few helper functions/goodies for net/dsa/dsa2.c to be as close as possible from net/dsa/dsa.c in terms of what drivers can expect, in particular the slave MDIO

[PATCH net-next v3 1/6] net: dsa: Provide unique DSA slave MII bus names

2016-06-07 Thread Florian Fainelli
In case we have multiples trees and switches with the same index, we need to add another discriminating id: the switch tree. Reviewed-by: Andrew Lunn Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli ---

[PATCH net-next v3 3/6] net: dsa: Provide a slave MII bus if needed

2016-06-07 Thread Florian Fainelli
Mimic what net/dsa/dsa.c does and provide a slave MII bus by default which will be created if the driver implements a phy_read method. Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/dsa/dsa2.c

[PATCH net-next v3 4/6] net: dsa: Add initialization helper for CPU port ethtool_ops

2016-06-07 Thread Florian Fainelli
Add a helper function: dsa_cpu_port_ethtool_init() which initializes a custom ethtool_ops structure with custom DSA ethtool operations for CPU ports. This is a preliminary change to move the initialization outside of net/dsa/slave.c. Signed-off-by: Florian Fainelli ---

[PATCH net-next v3 2/6] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask

2016-06-07 Thread Florian Fainelli
Some drivers rely on these two bitmasks to contain the correct values for them to successfully probe and initialize at drv->setup() time, calculate correct values to put in both masks as early as possible in dsa_get_ports_dn(). Signed-off-by: Florian Fainelli ---

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
On 06/07/2016 02:23 PM, Hannes Frederic Sowa wrote: On Tue, Jun 7, 2016, at 21:48, Philip Prindeville wrote: static struct rtnl_link_ops ipgre_link_ops __read_mostly = { diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c index d8f5e0a..95649eb 100644 --- a/net/ipv4/ip_tunnel.c +++

[PATCH iproute2] net-next: Add support for GRE ignore-df knob

2016-06-07 Thread Philip Prindeville
From: Philip Prindeville In the presence of firewalls which improperly block ICMP Unreachable (including Fragmentation Required) messages, Path MTU Discovery is prevented from working. The workaround is to handle IPv4 payloads opaquely, ignoring the DF bit. There

Re: [PATCH] RDS: IB: Remove deprecated create_workqueue

2016-06-07 Thread Santosh Shilimkar
Hi, On 6/7/2016 12:33 PM, Bhaktipriya Shridhar wrote: alloc_workqueue replaces deprecated create_workqueue(). Since the driver is infiniband which can be used as block device and the workqueue seems involved in regular operation of the device, so a dedicated workqueue has been used with

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Hannes Frederic Sowa
On Tue, Jun 7, 2016, at 21:48, Philip Prindeville wrote: > static struct rtnl_link_ops ipgre_link_ops __read_mostly = { > diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c > index d8f5e0a..95649eb 100644 > --- a/net/ipv4/ip_tunnel.c > +++ b/net/ipv4/ip_tunnel.c > @@ -682,7 +682,7 @@ void

[PATCH] net: cavium: liquidio: Remove deprecated create_workqueue

2016-06-07 Thread Bhaktipriya Shridhar
alloc_workqueue replaces deprecated create_workqueue(). A dedicated workqueue has been used since the workitem viz (>txq_status_wq.wk.work which maps to octnet_poll_check_txq_status) is involved in a brief poll routine for checking transmit queue status and is an intergral part of normal device

[PATCH] libertas_tf: Remove create_workqueue

2016-06-07 Thread Bhaktipriya Shridhar
alloc_workqueue replaces deprecated create_workqueue(). A dedicated workqueue has been used since the workitem (viz >cmd_work per priv, which maps to lbtf_cmd_work) is involved in actual command processing and may be used on a memory reclaim path. The workitems require forward progress under

Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable

2016-06-07 Thread Jes Sorensen
Jes Sorensen writes: > Colin King writes: >> From: Colin Ian King >> >> path_b_ok is being assigned but immediately after path_a_ok is being >> compared to the value 0x03. This appears to be a typo on the >> variable

[PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
From: Philip Prindeville In the presence of firewalls which improperly block ICMP Unreachable (including Fragmentation Required) messages, Path MTU Discovery is prevented from working. A workaround is to handle IPv4 payloads opaquely, ignoring the DF bit--as is

[PATCH] mlxsw: core: Remove deprecated create_workqueue

2016-06-07 Thread Bhaktipriya Shridhar
alloc_workqueue replaces deprecated create_workqueue(). A dedicated workqueue has been used since the workqueue mlxsw_wq is used for FDB notif. processing with workitems that are involved in normal device operation && because it's a network device which can be depended upon during memory reclaim.

Re: [PATCH 2/2] ARM: dts: imx6: tag boards that have the HW workaround for ERR006687

2016-06-07 Thread Joshua Clayton
On Thu, 02 Jun 2016 10:25:06 +0200 Lucas Stach wrote: > Am Mittwoch, den 01.06.2016, 17:17 +0100 schrieb Russell King - ARM > Linux: > > On Wed, Jun 01, 2016 at 05:29:43PM +0200, Lucas Stach wrote: > > > @@ -97,6 +97,7 @@ > > > phy-reset-gpios = < 31 0>; > > >

[PATCH] RDS: IB: Remove deprecated create_workqueue

2016-06-07 Thread Bhaktipriya Shridhar
alloc_workqueue replaces deprecated create_workqueue(). Since the driver is infiniband which can be used as block device and the workqueue seems involved in regular operation of the device, so a dedicated workqueue has been used with WQ_MEM_RECLAIM set to guarantee forward progress under memory

Re: [PATCH net-next v2 5/5] net: dsa: bcm_sf2: Register our slave MDIO bus

2016-06-07 Thread Florian Fainelli
On 06/07/2016 12:11 PM, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > With the legacy interface it is tricky. When would you call such a remove/tairdown function when using the old binding? >>> >>> That'd go in dsa_switch_destroy I guess, but it just

Re: [PATCH net-next v2 5/5] net: dsa: bcm_sf2: Register our slave MDIO bus

2016-06-07 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> > With the legacy interface it is tricky. When would you call such a >> > remove/tairdown function when using the old binding? >> >> That'd go in dsa_switch_destroy I guess, but it just covers the case >> where the whole DSA code is unloaded...

[PATCH] brcmfmac: slightly simplify building interface combinations

2016-06-07 Thread Rafał Miłecki
This change reorders some operations in brcmf_setup_ifmodes in hope to make it simpler: 1) It allocates arrays right before filling them. This way it's easier to follow requested array length as it's immediately followed by code filling it. It's easier to check e.g. why we need 4 entries for

  1   2   >