Re: [PATCH 1/1] tracing, bpf: Implement function bpf_probe_write

On Wed, Jul 13, 2016 at 01:31:57PM -0700, Sargun Dhillon wrote: > > > On Wed, 13 Jul 2016, Alexei Starovoitov wrote: > > > On Wed, Jul 13, 2016 at 03:36:11AM -0700, Sargun Dhillon wrote: > >> Provides BPF programs, attached to kprobes a safe way to write to > >> memory referenced by probes.

Re: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

From: Jiri Pirko Date: Thu, 14 Jul 2016 11:37:28 +0200 > From: Jiri Pirko > > Turned on that driver->owner which is struct module is not available when > modules are disabled. Better to depend on a driver name which is > always available. > > Reported-by:

Re: [patch net-next 2/2] devlink: fix trace format string

From: Jiri Pirko Date: Thu, 14 Jul 2016 11:37:29 +0200 > From: Arnd Bergmann > > Including devlink.h on ARM and probably other 32-bit architectures results in > a harmless warning: > > In file included from ../include/trace/define_trace.h:95:0, >

Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

From: Jiri Pirko Date: Thu, 14 Jul 2016 08:28:19 +0200 > Thu, Jul 14, 2016 at 08:18:45AM CEST, christophe.jail...@wanadoo.fr wrote: >>'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong. >>Return an explicit error code (-ENOENT) instead. >> > > This is fo

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > This is a driver for the ENA family of networking devices. > > Signed-off-by: Netanel Belgazal > --- > > Notes: ... > - Increase driver version to 1.0.2 ... > +static void

Re: [PATCH v8 04/11] net/mlx4_en: add support for fast rx drop bpf program

On Thu, Jul 14, 2016 at 09:25:43AM +0200, Jesper Dangaard Brouer wrote: > > I would really really like to see the XDP program associated with the > RX ring queues, instead of a single XDP program covering the entire NIC. > (Just move the bpf_prog pointer to struct mlx4_en_rx_ring) > > So, why is

[PATCH 1/2] wan/fsl_ucc_hdlc: remove reduplicative freed memory 'uhdlc_priv'

'uhdlc_priv' has freed twice, drop the first one. Signed-off-by: Zhao Qiang --- drivers/net/wan/fsl_ucc_hdlc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index 19174ac..e2b225d 100644 ---

Re: pull-request: wireless-drivers-next 2016-07-13

Hi, [auto build test ERROR on wireless-drivers-next/master] [cannot apply to v4.7-rc7 next-20160714] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Kalle-Valo/pull-request-wireless-drivers-next

[PATCH 2/2] wan/fsl_ucc_hdlc: rewrite error handling to make it clearer

It was used err_xxx for labeled statement, it is not easy to understand, now use free_xxx for labeled statement. Signed-off-by: Zhao Qiang --- drivers/net/wan/fsl_ucc_hdlc.c | 55 +- 1 file changed, 27 insertions(+), 28 deletions(-)

[PATCH/RFC] packet: fix sock_tx_timestamp() in packet_snd() via sendto syscall

Since the sendto syscall doesn't have msg_control buffer, the sock_tx_timestamp() in packet_snd() cannot work correctly because the socks.fsflags is set to 0. So, this patch sets the fsflags from sk.sk_tsflags if the msg_control buffer doesn't exist. Fixes: c14ac9451c34 ("sock: enable

Re: [PATCH 1/2] net: ethernet: ll_temac: use phydev from struct net_device

From: Philippe Reynes Date: Thu, 14 Jul 2016 01:48:51 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one

Re: [PATCH 2/2] net: ethernet: ll_temac: use phy_ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Thu, 14 Jul 2016 01:48:52 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: pull-request: wireless-drivers-next 2016-07-13

From: Kalle Valo Date: Wed, 13 Jul 2016 21:29:13 +0300 > here's a pull request for net-next. This time there are few conflicts > due to the cfg80211 scan API changes, and one of them is easy to miss, > so please pay extra attention to them. Otherwise there's not nothing >

Re: [PATCH v3 6/8] thunderbolt: Networking state machine

On Thu, Jul 14, 2016 at 7:28 AM, Amir Levy wrote: > Negotiation states that a peer goes through in order to establish > the communication with the second peer. > This includes communication with upper layer and additional > infrastructure support to communicate with the

Re: [RFC PATCH v2 08/10] net: sched: pfifo_fast use alf_queue

On 16-07-14 08:11 AM, Jesper Dangaard Brouer wrote: > On Wed, 13 Jul 2016 23:23:12 -0700 > John Fastabend wrote: > >> This converts the pfifo_fast qdisc to use the alf_queue enqueue and >> dequeue routines then sets the NOLOCK bit. > > Should have said skb_array, not

Re: [RFC PATCH v2 08/10] net: sched: pfifo_fast use alf_queue

On 16-07-14 04:42 PM, Alexei Starovoitov wrote: > On Wed, Jul 13, 2016 at 11:23:12PM -0700, John Fastabend wrote: >> This converts the pfifo_fast qdisc to use the alf_queue enqueue and >> dequeue routines then sets the NOLOCK bit. >> >> This also removes the logic used to pick the next band to

Re: [RFC PATCH v2 08/10] net: sched: pfifo_fast use alf_queue

On Wed, Jul 13, 2016 at 11:23:12PM -0700, John Fastabend wrote: > This converts the pfifo_fast qdisc to use the alf_queue enqueue and > dequeue routines then sets the NOLOCK bit. > > This also removes the logic used to pick the next band to dequeue from > and instead just checks each alf_queue

Re: [PATCH] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, do segmentation even for non IPSKB_FORWARDED skbs

Hello, On Thu, Jul 14, 2016, at 16:13, Shmulik Ladkani wrote: > Hi, > > On Thu, 14 Jul 2016 15:12:07 +0200, han...@stressinduktion.org wrote: > > I liked the fact that setting IPSKB_FORWARDED was only contained in > > vxlan and as such wouldn't have as much impact. It was more logically > > easy

Re: [PATCH] bonding: set carrier off for devices created through netlink

From: Beniamino Galvani Date: Wed, 13 Jul 2016 18:25:08 +0200 > Commit e826eafa65c6 ("bonding: Call netif_carrier_off after > register_netdevice") moved netif_carrier_off() from bond_init() to > bond_create(), but the latter is called only for initial default > devices and

Re: [PATCH] dt: bindings: Add a generic ethernet device binding

From: Hans de Goede Date: Wed, 13 Jul 2016 12:20:04 +0200 > On some boards (android tablets) different batches use different sdio > wifi modules. This is not a problem since sdio is a discoverable bus, > so we only need to describe and activate the mmc controller in dt and >

Re: [PATCH net-next 3/9] net: dsa: mv88e6xxx: extract device mapping

Hi David, all, kbuild test robot writes: > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Vivien-Didelot/net-dsa-mv88e6xxx-STP-and-Global-2-cleanup/20160707-210537 > config: i386-allmodconfig (attached as .config) > compiler:

Re: [net-next PATCH 0/3] pktgen samples: new scripts and removing older samples

From: Jesper Dangaard Brouer Date: Wed, 13 Jul 2016 22:05:59 +0200 > This patchset is adding some pktgen sample scripts that I've been > using for a while[1], and they seams to relevant for more people. > > Patchset also remove some of the older style pktgen samples. > > [1]

[PATCH 2/2] net: ethernet: pasemi_mac: use phy_ethtool_{get|set}_link_ksettings

There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/pasemi/pasemi_mac_ethtool.c | 28 + 1 files changed, 2

[PATCH 1/2] net: ethernet: pasemi_mac: use phydev from struct net_device

The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phy in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

Re: [patch] net/mlx5: missing error code in esw_create_offloads_fdb_table()

On Wed, Jul 13, 2016 at 02:40:26PM +0300, Or Gerlitz wrote: > On 7/13/2016 2:19 PM, Matan Barak wrote: > >I'm not sure EINVAL is the right error here though. > >Maybe -ENOTSUPP is a bit more appropriate here. > > I agree, Dan, can you please change to be along Matan's suggestion? Or, Dan already

[iproute PATCH] tc: ematch: Ignore all-zero mask value when printing filters

The optional mask which may be added to int values is considered by the kernel only if it is non-zero, therefore tc should only then also print it. Without this, not passing a mask value like so: | # tc filter add dev d0 parent 8001: \ | basic match meta\(vlan eq 1\) \ | classid

Re: [PATCH] virtio-net: Remove more stack DMA

From: Andy Lutomirski Date: Thu, 14 Jul 2016 13:21:46 -0700 > On Tue, Jul 12, 2016 at 10:40 AM, David Miller wrote: >> From: Andy Lutomirski >> Date: Mon, 11 Jul 2016 14:30:28 -0700 >> >>> DaveM, is it okay for this to go in via -tip?

Re: [PATCH net-next V2 00/10] Mellanox 100G mlx5 Bulk flow statistics and SRIOV TC offloads

From: Saeed Mahameed Date: Thu, 14 Jul 2016 10:32:36 +0300 > This series from Amir and Or deals with two enhancements for the mlx5 TC > offloads. ... > V2: > - Fixed compilation warning. Series apppied, thanks.

Re: [PATCH v5 01/32] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

From: Andy Lutomirski Date: Thu, 14 Jul 2016 12:10:45 -0700 > On Mon, Jul 11, 2016 at 1:53 PM, Andy Lutomirski wrote: >> SMP does ECB crypto on stack buffers. This is complicated and >> fragile, and it will not work if the stack is virtually allocated. >>

Re: [PATCH v5 01/32] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

Hi Andy, >> SMP does ECB crypto on stack buffers. This is complicated and >> fragile, and it will not work if the stack is virtually allocated. >> >> Switch to the crypto_cipher interface, which is simpler and safer. > > Hi Dave- > > It looks like we're delaying virtually mapped stacks to

Re: [PATCH] virtio-net: Remove more stack DMA

On Tue, Jul 12, 2016 at 10:40 AM, David Miller wrote: > From: Andy Lutomirski > Date: Mon, 11 Jul 2016 14:30:28 -0700 > >> DaveM, is it okay for this to go in via -tip? > > Sure. Looks like the series that depends on this is getting delayed to 4.9. Could

[PATCH iproute 4/5] gre6: Support for fou encapsulation

Signed-off-by: Tom Herbert --- ip/link_gre6.c | 101 + 1 file changed, 101 insertions(+) diff --git a/ip/link_gre6.c b/ip/link_gre6.c index bddfc0f..e18132e 100644 --- a/ip/link_gre6.c +++ b/ip/link_gre6.c @@ -38,6

[PATCH iproute 3/5] ip6tnl: Support for fou encapsulation

Signed-off-by: Tom Herbert --- ip/link_ip6tnl.c | 92 +++- 1 file changed, 91 insertions(+), 1 deletion(-) diff --git a/ip/link_ip6tnl.c b/ip/link_ip6tnl.c index 8a31d0d..0c2eb05 100644 --- a/ip/link_ip6tnl.c +++

[PATCH iproute 5/5] fou: Allowing configuring IPv6 listener

Signed-off-by: Tom Herbert --- ip/ipfou.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ip/ipfou.c b/ip/ipfou.c index 2a6ae17..d584a02 100644 --- a/ip/ipfou.c +++ b/ip/ipfou.c @@ -25,8 +25,8 @@ static void usage(void) { -

[PATCH iproute 2/5] ila: Support for configuring ila to use netfilter hook

Signed-off-by: Tom Herbert --- ip/Makefile| 2 +- ip/ip.c| 3 +- ip/ip_common.h | 1 + ip/ipila.c | 259 + 4 files changed, 263 insertions(+), 2 deletions(-) create mode 100644 ip/ipila.c diff

[PATCH iproute 1/5] ila: Support for checksum neutral translation

Add configuration of ila LWT tunnels for checksum mode including checksum neutral translation. Signed-off-by: Tom Herbert --- ip/iproute_lwtunnel.c | 57 +-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git

[PATCH iproute 0/5] iproute: ila and fou additions

Patch set includes: - Allow configuring checksum mode for ila LWT (e.g. configure checksum neutral - Configuration for performing ila translations using netfilter hook - fou encapsulation for ip6tnl and gre6 - fou listener for IPv6 *** SUBJECT HERE *** *** BLURB HERE *** Tom Herbert (5):

Re: [PATCH v2 3/3] netfilter: replace list_head with single linked list

Pablo Neira Ayuso wrote: > On Tue, Jul 12, 2016 at 11:32:21AM -0400, Aaron Conole wrote: > > The netfilter hook list never uses the prev pointer, and so can be > > trimmed to be a smaller singly-linked list. > > struct list_head list; > > > > @@ -161,8 +167,6 @@

Re: [PATCH v5 01/32] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

On Mon, Jul 11, 2016 at 1:53 PM, Andy Lutomirski wrote: > SMP does ECB crypto on stack buffers. This is complicated and > fragile, and it will not work if the stack is virtually allocated. > > Switch to the crypto_cipher interface, which is simpler and safer. Hi Dave- It looks

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

Hi, Amir, >This patch is the communication with the FW. >The network functionality is added in the next patches in the series >and with it, more messages from FW. >Indeed this function always returns true in this patch, >but while writing it, I predicted that the network functionality will

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

On Thu, Jul 14 2016, 06:08 PM, Rosen, Rami wrote: > Hi Amir, Hi Rami, > Here are my 2 cents: > > This method always returns true, should be void (unless you will change > PDF_ERROR_NOTIFICATION or other pdf values to return false), and > likewise its invocation should not check return value. >

[PATCH] r8152: add MODULE_VERSION

ethtool -i provides a driver version that is hard coded. Export the same value via "modinfo". Signed-off-by: Grant Grundler --- drivers/net/usb/r8152.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index

Re: [patch] net/mlx5: missing error code in esw_create_offloads_fdb_table()

On 7/13/2016 2:19 PM, Matan Barak wrote: I'm not sure EINVAL is the right error here though. Maybe -ENOTSUPP is a bit more appropriate here. I agree, Dan, can you please change to be along Matan's suggestion? Or.

[PATCH net-next 4/4] net: bridge: remove _deliver functions and consolidate forward code

Before this patch we had two flavors of most forwarding functions - _forward and _deliver, the difference being that the latter are used when the packets are locally originated. Instead of all this function pointer passing and code duplication, we can just pass a boolean noting that the packet was

[PATCH net-next 3/4] net: bridge: drop skb2/skb0 variables and use a local_rcv boolean

Currently if the packet is going to be received locally we set skb0 or sometimes called skb2 variables to the original skb. This can get confusing and also we can avoid one conditional on the fast path by simply using a boolean and passing it around. Thanks to Roopa for the name suggestion.

[PATCH net-next 0/4] net: bridge: simplify receive path and consolidate forwarding paths

Hi all, This set tries to simplify the receive and forwarding paths. Patch 01 is a trivial style adjustment, patch 02 removes one conditional from the unicast fast path, patch 03 removes another conditional and more imporantly removes the skb0/skb2 ambiguity about locally receiving the skb and

[PATCH net-next 1/4] net: bridge: minor style adjustments in br_handle_frame_finish

Trivial style changes in br_handle_frame_finish. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_input.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c index

[PATCH net-next 2/4] net: bridge: rearrange flood vs unicast receive paths

This patch removes one conditional from the unicast path by using the fact that skb is NULL only when the packet is multicast or is local. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_input.c | 29 ++--- 1 file changed, 14

Re: [PATCH nf-next v2 1/3] netfilter: bridge: add and use br_nf_hook_thresh

Pablo Neira Ayuso writes: > On Tue, Jul 12, 2016 at 11:32:19AM -0400, Aaron Conole wrote: >> +/* recursively invokes nf_hook_slow (again), skipping already-called >> + * hooks (< NF_BR_PRI_BRNF). >> + * >> + * Called with rcu read lock held. >> + */ >> +int

Re: [PATCH v2 3/3] netfilter: replace list_head with single linked list

On Tue, Jul 12, 2016 at 11:32:21AM -0400, Aaron Conole wrote: > The netfilter hook list never uses the prev pointer, and so can be > trimmed to be a smaller singly-linked list. > > In addition to having a more light weight structure for hook traversal, > struct net becomes 5568 bytes (down from

[PATCH 1/2] net: ethernet: xilinx: axienet: use phydev from struct net_device

The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phy in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

[PATCH 2/2] net: ethernet: xilinx: axienet: use phy_ethtool_{get|set}_link_ksettings

There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 47 + 1 files changed, 2

Re: [PATCH nf-next v2 2/3] netfilter: call nf_hook_state_init with rcu_read_lock held

Pablo Neira Ayuso wrote: > > diff --git a/net/bridge/netfilter/ebt_redirect.c > > b/net/bridge/netfilter/ebt_redirect.c > > index 20396499..2e7c4f9 100644 > > --- a/net/bridge/netfilter/ebt_redirect.c > > +++ b/net/bridge/netfilter/ebt_redirect.c > > @@ -24,7 +24,7 @@

Re: [patch net-next 2/2] devlink: fix trace format string

On Thu, 14 Jul 2016 10:07:38 -0700 Randy Dunlap wrote: > On 07/14/16 02:37, Jiri Pirko wrote: > > From: Arnd Bergmann > > > > Including devlink.h on ARM and probably other 32-bit architectures results > > in > > a harmless warning: > > > > In file

Re: [PATCH nf-next v2 2/3] netfilter: call nf_hook_state_init with rcu_read_lock held

On Tue, Jul 12, 2016 at 11:32:20AM -0400, Aaron Conole wrote: > From: Florian Westphal > > This makes things simpler because we can store the head of the list > in the nf_state structure without worrying about concurrent add/delete > of hook elements from the list. This is

Re: [PATCH nf-next v2 1/3] netfilter: bridge: add and use br_nf_hook_thresh

On Tue, Jul 12, 2016 at 11:32:19AM -0400, Aaron Conole wrote: > +/* recursively invokes nf_hook_slow (again), skipping already-called > + * hooks (< NF_BR_PRI_BRNF). > + * > + * Called with rcu read lock held. > + */ > +int br_nf_hook_thresh(unsigned int hook, struct net *net, > +

Re: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

On Thu, 14 Jul 2016 10:07:33 -0700 Randy Dunlap wrote: > On 07/14/16 02:37, Jiri Pirko wrote: > > From: Jiri Pirko > > > > Turned on that driver->owner which is struct module is not available when > > modules are disabled. Better to depend on a driver

Re: [patch net-next 2/2] devlink: fix trace format string

On 07/14/16 02:37, Jiri Pirko wrote: > From: Arnd Bergmann > > Including devlink.h on ARM and probably other 32-bit architectures results in > a harmless warning: > > In file included from ../include/trace/define_trace.h:95:0, > from

Re: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

On 07/14/16 02:37, Jiri Pirko wrote: > From: Jiri Pirko > > Turned on that driver->owner which is struct module is not available when > modules are disabled. Better to depend on a driver name which is > always available. > > Reported-by: Randy Dunlap >

Re: [PATCH net-next 3/5] RDS: TCP: Enable multipath RDS for TCP

On 7/14/2016 3:51 AM, Sowmini Varadhan wrote: Use RDS probe-ping to compute how many paths may be used with the peer, and to synchronously start the multiple paths. If mprds is supported, hash outgoing traffic to one of multiple paths in rds_sendmsg() when multipath RDS is supported by the

Re: [iproute PATCH v2] ip-macsec.8: fix typo in 'examples' section

On Tue, 2016-07-12 at 17:28 +0200, Davide Caratti wrote: > fix wrong 'device' keyword in 'ip link add device eth0' > > changes since v1: > while at it, add missing description of 'validate' keyword and remove > spurious bracket near 'encrypt' keyword. Also, wrong 'es' and 'encoding' > keywords in

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On 2016/07/14 08:22, Matt Wilson wrote: [...] > > Dave and Benjamin, > > Do you want to see the interrupt moderation extensions to ethtool and > the sysfs nodes removed before this lands in net-next? Or should > Netanel remove the sysfs bits until we can extend the ethtool > interfaces to cover

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jul 14, 2016 at 09:08:03AM -0700, Benjamin Poirier wrote: > On 2016/07/14 08:22, Matt Wilson wrote: > [...] > > > > Dave and Benjamin, > > > > Do you want to see the interrupt moderation extensions to ethtool and > > the sysfs nodes removed before this lands in net-next? Or should > >

[PATCH net-next v2 3/3] bpf: avoid stack copy and use skb ctx for event output

This work addresses a couple of issues bpf_skb_event_output() helper currently has: i) We need two copies instead of just a single one for the skb data when it should be part of a sample. The data can be non-linear and thus needs to be extracted via bpf_skb_load_bytes() helper first, and then

[PATCH net-next v2 0/3] BPF event output helper improvements

This set adds improvements to the BPF event output helper to support non-linear data sampling, here specifically, for skb context. For details please see individual patches. The set is based against net-next tree. v1 -> v2: - Integrated and adapted Peter's diff into patch 1, updated the

[PATCH net-next v2 2/3] bpf, perf: split bpf_perf_event_output

Split the bpf_perf_event_output() helper as a preparation into two parts. The new bpf_perf_event_output() will prepare the raw record itself and test for unknown flags from BPF trace context, where the __bpf_perf_event_output() does the core work. The latter will be reused later on from

[PATCH net-next v2 1/3] perf, events: add non-linear data support for raw records

This patch adds support for non-linear data on raw records. It extends raw records to have one or multiple fragments that will be written linearly into the ring slot, where each fragment can optionally have a custom callback handler to walk and extract complex, possibly non-linear data. If a

[PATCH net] vlan: use a valid default mtu value for vlan over macsec

macsec can't cope with mtu frames which need vlan tag insertion, and vlan device set the default mtu equal to the underlying dev's one. By default vlan over macsec devices use invalid mtu, dropping all the large packets. This patch adds a netif helper to check if an upper vlan device needs mtu

[PATCH net] tcp: enable per-socket rate limiting of all 'challenge acks'

From: Jason Baron The per-socket rate limit for 'challenge acks' was introduced in the context of limiting ack loops: commit f2b2c582e824 ("tcp: mitigate ACK loops for connections as tcp_sock") And I think it can be extended to rate limit all 'challenge acks' on a per-socket

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > This is a driver for the ENA family of networking devices. > > Signed-off-by: Netanel Belgazal > --- > > Notes: > Changes in v3: > - Fix compilation warning for 32bit systems. [kbuild test

[PATCH net-next] rxrpc: checking for IS_ERR() instead of NULL

From: Dan Carpenter The rxrpc_lookup_peer() function returns NULL on error, it never returns error pointers. Fixes: 8496af50eb38 ('rxrpc: Use RCU to access a peer's service connection tree') Signed-off-by: Dan Carpenter Signed-off-by: David

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

On Thursday, July 14, 2016 5:15:06 PM CEST Andrew Lunn wrote: > On Thu, Jul 14, 2016 at 04:33:26PM +0200, Arnd Bergmann wrote: > > On Thursday, July 14, 2016 4:29:43 PM CEST Philipp Zabel wrote: > > > + > > > + - micrel,fiber-mode: If present the PHY is configured to operate in > > > fiber mode >

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

On Thu, Jul 14, 2016 at 04:33:26PM +0200, Arnd Bergmann wrote: > On Thursday, July 14, 2016 4:29:43 PM CEST Philipp Zabel wrote: > > + > > + - micrel,fiber-mode: If present the PHY is configured to operate in fiber > > mode > > + > > + Some PHYs, such as the KSZ8041FTL variant, support

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

> +static int ksz8041_config_init(struct phy_device *phydev) > +{ > + /* Limit supported and advertised modes in fiber mode */ > + if (of_property_read_bool(phydev->mdio.dev.of_node, "fxen")) { > + phydev->dev_flags |= MICREL_PHY_FXEN; > + phydev->supported &=

Re: [RFC PATCH v2 08/10] net: sched: pfifo_fast use alf_queue

On Wed, 13 Jul 2016 23:23:12 -0700 John Fastabend wrote: > This converts the pfifo_fast qdisc to use the alf_queue enqueue and > dequeue routines then sets the NOLOCK bit. Should have said skb_array, not alf_queue ;-) > This also removes the logic used to pick the

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

Hi Amir, Here are my 2 cents: This method always returns true, should be void (unless you will change PDF_ERROR_NOTIFICATION or other pdf values to return false), and likewise its invocation should not check return value. > +static bool nhi_msg_from_icm_analysis(struct tbt_nhi_ctxt

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

Hi Tomas, Thanks for your comments. On Thu, Jul 14 2016, 03:44 PM, Winkler, Tomas wrote: > > +/* NHI genetlink commands */ > > +enum { > > + NHI_CMD_UNSPEC, > > + NHI_CMD_SUBSCRIBE, > > + NHI_CMD_UNSUBSCRIBE, > > + NHI_CMD_QUERY_INFORMATION, > > + NHI_CMD_MSG_TO_ICM, > > +

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

Am Donnerstag, den 14.07.2016, 16:33 +0200 schrieb Arnd Bergmann: > On Thursday, July 14, 2016 4:29:43 PM CEST Philipp Zabel wrote: > > + > > + - micrel,fiber-mode: If present the PHY is configured to operate in fiber > > mode > > + > > + Some PHYs, such as the KSZ8041FTL variant, support

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

On Thursday, July 14, 2016 4:29:43 PM CEST Philipp Zabel wrote: > + > + - micrel,fiber-mode: If present the PHY is configured to operate in fiber > mode > + > + Some PHYs, such as the KSZ8041FTL variant, support fiber mode, enabled > + by the FXEN boot strapping pin. It can't be

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

> > Hi Philipp > > > > Could you use a more descriptive property name? "micrel,enable-fiber"? > > "micrel,fiber-mode" ? Sure, Thanks, Andrew

[PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

We can't detect the FXEN (fiber mode) bootstrap pin, so configure it via a boolean device tree property "micrel,fiber-mode". If it is enabled, auto-negotiation is not supported. The only available modes are 100base-fx (full duplex and half duplex). Signed-off-by: Philipp Zabel

Re: [PATCH -next] rxrpc: Fix error handling in af_rxrpc_init()

David Miller wrote: > > From: Wei Yongjun > > > > security initialized after alloc workqueue, so we should exit security > > before destroy workqueue in the error handing. > > > > Fixes: 648af7fca159 ("rxrpc: Absorb the rxkad security

Re: [RFC PATCH v3] net: sched: convert qdisc linked list to hashtable

[ added CCs ] On Tue, 12 Jul 2016, kbuild test robot wrote: > Hi, > > [auto build test ERROR on net/master] > [also build test ERROR on v4.7-rc7 next-20160711] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: >

Re: [PATCH] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, do segmentation even for non IPSKB_FORWARDED skbs

Hi, On Thu, 14 Jul 2016 15:12:07 +0200, han...@stressinduktion.org wrote: > I liked the fact that setting IPSKB_FORWARDED was only contained in > vxlan and as such wouldn't have as much impact. It was more logically > easy to review for me actually. I agree here. It is rather safe and to the

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

Hi Andrew, Am Donnerstag, den 14.07.2016, 15:37 +0200 schrieb Andrew Lunn: > On Thu, Jul 14, 2016 at 12:18:48PM +0200, Philipp Zabel wrote: > > We can't detect the FXEN (fiber mode) bootstrap pin, so configure > > it via a boolean device tree property "fxen". > > Hi Philipp > > Could you use a

[PATCH 2/5] cdc-acm: use the common parser

This introduces the common parser for extra CDC headers now that it no longer depends on usbnet. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 69 +++-- 1 file changed, 10 insertions(+), 59 deletions(-) diff --git

[PATCH 0 / 5] move the common CDC parser

Experience has shown that making all CDC drivers depend on usbnet is not practical, because some of them are not network drivers. So this patch moves the common parser from usbnet into the messages helpers of usbcore. The rest of the series applies it to the non-network CDC drivers. I hope it can

[PATCH 1/5] usbnet: move the CDC parser into USB core

The dependencies were impossible to handle preventing drivers for CDC devices not which are not network drivers from using the common parser. Signed-off-by: Oliver Neukum --- drivers/net/usb/usbnet.c | 138 drivers/usb/core/message.c

[PATCH 3/5] cdc-acm: cleanup error handling

A small update to unify error handling during probe(). Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 70bd642..1857fad

[PATCH 5/5] cdc-acm: beautify probe()

This removes some overly long lines by renaming variables and giving them local scope. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 44 1 file changed, 24 insertions(+), 20 deletions(-) diff --git

[PATCH 4/5] cdc-wdm: use the common CDC parser

Now that the common parser resides in USB core, it can be used for CDC-WDM. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-wdm.c | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/drivers/usb/class/cdc-wdm.c

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

On Thu, Jul 14, 2016 at 12:18:48PM +0200, Philipp Zabel wrote: > We can't detect the FXEN (fiber mode) bootstrap pin, so configure > it via a boolean device tree property "fxen". Hi Philipp Could you use a more descriptive property name? "micrel,enable-fiber"? Andrew

[PATCH 1/2] net: ethernet: tc35815: use phydev from struct net_device

The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phy in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

Hi Sergei, Am Donnerstag, den 14.07.2016, 14:35 +0300 schrieb Sergei Shtylyov: > Hello. > > On 7/14/2016 1:18 PM, Philipp Zabel wrote: > > > We can't detect the FXEN (fiber mode) bootstrap pin, so configure > > it via a boolean device tree property "fxen". If it is enabled, > > auto-negotiation

[PATCH 2/2] net: ethernet: tc35815: use phy_ethtool_{get|set}_link_ksettings

There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/toshiba/tc35815.c | 18 ++ 1 files changed, 2 insertions(+), 16

Re: [PATCH] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, do segmentation even for non IPSKB_FORWARDED skbs

Hello Shmulik, On Wed, Jul 13, 2016, at 16:00, Shmulik Ladkani wrote: > Hi Florian, Hannes, > > On Tue, 12 Jul 2016 08:56:56 +0300 Shmulik Ladkani > wrote: > > On Sat, 9 Jul 2016 15:22:30 +0200 Florian Westphal wrote: > > > > > > > > >

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

> > Firmware-based (a.k.a ICM - Intel Connection Manager) controller is > used for establishing and maintaining the Thunderbolt Networking > connection. We need to be able to communicate with it. > > Signed-off-by: Amir Levy > --- > drivers/thunderbolt/Makefile |

Re: [PATCH] wlcore/wl18xx: mesh: added initial mesh support for wl8

"Machani, Yaniv" writes: > On Tue, Jun 28, 2016 at 13:41:35, Machani, Yaniv wrote: >> Guy; Johannes Berg; Arik Nemtsov; linux-wirel...@vger.kernel.org; >> netdev@vger.kernel.org >> Subject: [PATCH] wlcore/wl18xx: mesh: added initial mesh support for >> wl8 >> >> From: Maital

[PATCH] ixgbe: remove redundant check on ret_val

From: Colin Ian King The last check on ret_val is redundant since ret_val has not changed since the previous check, so remove it as it is extraneous. Signed-off-by: Colin Ian King --- drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 3 --- 1

Re: [Y2038] Fourth draft of the Y2038 design document

On Wednesday, July 13, 2016 7:38:25 PM CEST Deepa Dinamani wrote: > On Wed, Jul 13, 2016 at 1:40 PM, Deepa Dinamani > wrote: > >>> == Socket options == > >>> > >>> Like ioctl(), setsockopt()/getsockopt() has a few interfaces that are > >>> passing time data: > >>> > >>>

  1   2   >