[PATCH 6/6] mISDN: remove unused function

2016-09-23 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/isdn/mISDN/layer2.c:463:1: warning: no previous declaration for 'IsRR' [-Wmissing-declarations] In fact, this function is called by no one and not exported, so this patch removes it. Signed-off-by: Baoyou Xie --- drivers/isdn/mISDN/layer2

[PATCH 5/6] mISDN: mark symbols static where possible

2016-09-23 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/isdn/mISDN/layer2.c:120:1: warning: no previous declaration for 'l2headersize' [-Wmissing-declarations] drivers/isdn/mISDN/layer2.c:127:1: warning: no previous declaration for 'l2addrsize' [-Wmissing-declarations] drivers/isdn/mISDN/lay

[PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up

2016-09-23 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/isdn/hisax/hscx.c:175:1: warning: no previous prototype for 'open_hscxstate' [-Wmissing-prototypes] In fact, this function is declared in drivers/isdn/hisax/elsa_ser.c, but should be declard in a header file, thus can be recognized in other

[PATCH 3/6] isdn/hisax: add function declarations

2016-09-23 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/isdn/hisax/teles3.c:273:5: warning: no previous prototype for 'setup_teles3' [-Wmissing-prototypes] drivers/isdn/hisax/s0box.c:213:5: warning: no previous prototype for 'setup_s0box' [-Wmissing-prototypes] drivers/isdn/hisax/bkm_a4t.c:3

[PATCH 2/6] isdn/hardware/eicon: add missing header dependencies

2016-09-23 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/isdn/hardware/eicon/diva.c:655:6: warning: no previous prototype for 'xdiFreeFile' [-Wmissing-prototypes] In fact, this function is declared in drivers/isdn/hardware/eicon/helpers.h, so this patch adds missing header dependencies. Signed-of

[PATCH 1/6] isdn/eicon: add function declarations

2016-09-23 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/isdn/hardware/eicon/diddfunc.c:95:12: warning: no previous prototype for 'diddfunc_init' [-Wmissing-prototypes] drivers/isdn/hardware/eicon/s_4bri.c:128:6: warning: no previous prototype for 'start_qBri_hardware' [-Wmissing-prototypes]

RE: Alignment issues with freescale FEC driver

2016-09-23 Thread Andy Duan
From: David Miller Sent: Saturday, September 24, 2016 10:46 AM > To: e...@nelint.com > Cc: and...@lunn.ch; eduma...@google.com; Andy Duan > ; ota...@ossystems.com.br; > netdev@vger.kernel.org; troy.ki...@boundarydevices.com; > rmk+ker...@arm.linux.org.uk; cjb.sw.nos...@gmail.com; linux-arm- > ker

Re: [Intel-wired-lan] [PATCH net-next v2 2/2] i40e: fix setting debug parameter early

2016-09-23 Thread Alexander Duyck
On Fri, Sep 23, 2016 at 6:30 AM, Stefan Assmann wrote: > pf->msg_enable is a bitmask, therefore assigning the value of the > "debug" parameter is wrong. It is initialized again later in > i40e_sw_init() so it didn't cause any problem, except that we missed > early debug messages. Moved the initial

Re: [PATCH] Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

2016-09-23 Thread David Miller
From: Jaedon Shin Date: Sat, 24 Sep 2016 06:08:19 +0900 > This reverts commit 62469c76007e ("net: ethernet: bcmgenet: use phydev > from struct net_device") > > without this patch, we call twice bcmgenet_mii_reset, and that is intended: > - first time from bcmgenet_power_up() to make sure the PHY

Re: [Intel-wired-lan] [PATCH net-next v2 1/2] i40e: remove superfluous I40E_DEBUG_USER statement

2016-09-23 Thread Alexander Duyck
On Fri, Sep 23, 2016 at 6:30 AM, Stefan Assmann wrote: > This debug statement is confusing and never set in the code. Any debug > output should be guarded by the proper I40E_DEBUG_* statement which can > be enabled via the debug module parameter or ethtool. > Remove or convert the I40E_DEBUG_USER

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread David Miller
From: Eric Nelson Date: Fri, 23 Sep 2016 11:35:17 -0700 > From the i.MX6DQ reference manual, bit 7 of ENET_RACC says this: > > "RX FIFO Shift-16 > > When this field is set, the actual frame data starts at bit 16 of the first > word read from the RX FIFO aligning the Ethernet payload on a > 32-b

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread David Miller
From: Eric Nelson Date: Fri, 23 Sep 2016 10:33:29 -0700 > Since the hardware requires longword alignment for its' DMA transfers, > aligning the IP header will require a memcpy, right? I wish hardware designers didn't do this. There is no conflict between DMA alignment and properly offseting the

Re: [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb()

2016-09-23 Thread Alexander Duyck
On Fri, Sep 23, 2016 at 4:41 PM, Sowmini Varadhan wrote: > On (09/23/16 10:38), Alexander Duyck wrote: >> >> So basically what I was thinking is we do something like reserving >> NET_IP_ALIGN and continue writing headers to skb->data, but we force >> the tracking for the inner headers into frag[0]

Re: [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb()

2016-09-23 Thread Sowmini Varadhan
On (09/23/16 10:38), Alexander Duyck wrote: > > So basically what I was thinking is we do something like reserving > NET_IP_ALIGN and continue writing headers to skb->data, but we force > the tracking for the inner headers into frag[0] so that we can keep > the inner headers aligned without messin

Re: Modification to skb->queue_mapping affecting performance

2016-09-23 Thread Michael Ma
2016-09-16 15:00 GMT-07:00 Michael Ma : > 2016-09-16 12:53 GMT-07:00 Eric Dumazet : >> On Fri, 2016-09-16 at 10:57 -0700, Michael Ma wrote: >> >>> This is actually the problem - if flows from different RX queues are >>> switched to the same RX queue in IFB, they'll use different processor >>> conte

Re: [PATCH 2/3] bpf powerpc: implement support for tail calls

2016-09-23 Thread Daniel Borkmann
On 09/23/2016 10:35 PM, Naveen N. Rao wrote: Tail calls allow JIT'ed eBPF programs to call into other JIT'ed eBPF programs. This can be achieved either by: (1) retaining the stack setup by the first eBPF program and having all subsequent eBPF programs re-using it, or, (2) by unwinding/tearing dow

[PATCH] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-23 Thread chris.roth
From: Chris Roth From: Allan Chou Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller (Vendor=04b4 ProdID=3610). Patch verified on x64 linux kernel 4.7.4 system with the Kensington SD4600P USB-C Universal Dock with Power, which uses the Cypress GX3 SuperSpeed to Gigabi

[PATCH] netfilter: don't permit unprivileged writes to global state via sysctls

2016-09-23 Thread Jann Horn
This prevents the modification of nf_conntrack_max in unprivileged network namespaces. For unprivileged network namespaces, ip_conntrack_max is kept as a readonly sysctl in order to minimize potential compatibility issues. This patch should apply cleanly to the net tree. Signed-off-by: Jann Horn

[PATCH] hv_netvsc: fix comments

2016-09-23 Thread sthemmin
From: Stephen Hemminger Typo's and spelling errors. Also remove old comment from staging era. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv

Re: [PATCH net-next] Documentation: devicetree: fix typo in MediaTek ethernet device-tree binding

2016-09-23 Thread Rob Herring
On Fri, Sep 23, 2016 at 02:09:32PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > fix typo in > Documentation/devicetree/bindings/net/mediatek-net.txt > > Cc: devicet...@vger.kernel.org > Reported-by: Sergei Shtylyov > Signed-off-by: Sean Wang > --- > Documentation/devicetree/bind

Re: [PATCH net-next v2] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

2016-09-23 Thread Rob Herring
On Fri, Sep 23, 2016 at 02:04:09PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > add phy-mode "trgmii" to > Documentation/devicetree/bindings/net/ethernet.txt > > Cc: devicet...@vger.kernel.org > Reported-by: Sergei Shtylyov > Signed-off-by: Sean Wang > --- > Documentation/device

Re: [PATCH 3/3] bpf powerpc: add support for bpf constant blinding

2016-09-23 Thread Daniel Borkmann
On 09/23/2016 10:35 PM, Naveen N. Rao wrote: In line with similar support for other architectures by Daniel Borkmann. 'MOD Default X' from test_bpf without constant blinding: 84 bytes emitted from JIT compiler (pass:3, flen:7) d58a4688 + : 0: nop 4: nop 8: std r27,-40(

Re: [PATCH net] i40e: fix call of ndo_dflt_bridge_getlink()

2016-09-23 Thread Jeff Kirsher
On Fri, 2016-09-23 at 11:12 +0200, Nicolas Dichtel wrote: > Le 19/09/2016 à 18:14, Nicolas Dichtel a écrit : > > From: Huaibin Wang > >  > > Order of arguments is wrong. > > The wrong code has been introduced by commit 7d4f8d871ab1, but is > compiled > > only since commit 9df70b66418e. > >  > > No

Re: [RFC] net: store port/representative id in metadata_dst

2016-09-23 Thread John Fastabend
On 16-09-23 01:45 PM, Jakub Kicinski wrote: > On Fri, 23 Sep 2016 13:25:10 -0700, John Fastabend wrote: >> On 16-09-23 01:17 PM, Jakub Kicinski wrote: >>> On Fri, 23 Sep 2016 10:22:59 -0700, Samudrala, Sridhar wrote: On 9/23/2016 8:29 AM, Jakub Kicinski wrote: >> [...] >> [...]

Re: [PATCH] softirq: let ksoftirqd do its job

2016-09-23 Thread Peter Zijlstra
On Fri, Sep 23, 2016 at 06:51:04PM +0200, Jesper Dangaard Brouer wrote: > This is your git tree, right: > https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/ > > Doesn't look like you pushed it yet, or do I need to look at a specific > branch? I mainly work from a local quilt queue w

[PATCH] Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

2016-09-23 Thread Jaedon Shin
This reverts commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct net_device") without this patch, we call twice bcmgenet_mii_reset, and that is intended: - first time from bcmgenet_power_up() to make sure the PHY is initialized *before* we get to initialize the UniMAC, this is

Re: [net-next 5/5] PCI: disable FLR for 82579 device

2016-09-23 Thread Jeff Kirsher
On Fri, 2016-09-23 at 09:01 -0500, Bjorn Helgaas wrote: > On Thu, Sep 22, 2016 at 11:39:01PM -0700, Jeff Kirsher wrote: > > > > From: Sasha Neftin > > > > 82579 has a problem reattaching itself after the device is detached. > > The bug was reported by Redhat. The suggested fix is to disable > >

Re: [PATCH] net: bcmgenet: Fix EPHY reset in power up

2016-09-23 Thread Jaedon Shin
Hi Florian, > On 24 Sep 2016, at 1:54 AM, Florian Fainelli wrote: > > On 09/23/2016 08:04 AM, Jaedon Shin wrote: >> Hi Andrew, >> >> On 23 Sep 2016, at 11:06 PM, Andrew Lunn wrote: >>> >>> On Fri, Sep 23, 2016 at 10:20:04PM +0900, Jaedon Shin wrote: The bcmgenet_mii_reset() is always not

Re: [RFC] net: store port/representative id in metadata_dst

2016-09-23 Thread Jakub Kicinski
On Fri, 23 Sep 2016 13:25:10 -0700, John Fastabend wrote: > On 16-09-23 01:17 PM, Jakub Kicinski wrote: > > On Fri, 23 Sep 2016 10:22:59 -0700, Samudrala, Sridhar wrote: > >> On 9/23/2016 8:29 AM, Jakub Kicinski wrote: > [...] > [...] > >> > >> The 'accel' parameter in dev_queue_xmit_acce

[PATCH 1/2] bpf samples: fix compiler errors with sockex2 and sockex3

2016-09-23 Thread Naveen N. Rao
These samples fail to compile as 'struct flow_keys' conflicts with definition in net/flow_dissector.h. Fix the same by renaming the structure used in the sample. Signed-off-by: Naveen N. Rao --- samples/bpf/sockex2_kern.c | 10 +- samples/bpf/sockex3_kern.c | 8 samples/bpf/soc

[PATCH 2/2] bpf samples: update tracex5 sample to use __seccomp_filter

2016-09-23 Thread Naveen N. Rao
seccomp_phase1() does not exist anymore. Instead, update sample to use __seccomp_filter(). While at it, set max locked memory to unlimited. Signed-off-by: Naveen N. Rao --- I am not completely sure if __seccomp_filter is the right place to hook in. This works for me though. Please review. Thanks

Re: [PATCH net v2] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()

2016-09-23 Thread Lance Richardson
> From: "Sergei Shtylyov" > To: "Lance Richardson" , netdev@vger.kernel.org > Cc: "shmulik ladkani" , jb...@redhat.com > Sent: Friday, September 23, 2016 4:01:15 PM > Subject: Re: [PATCH net v2] ip6_gre: fix flowi6_proto value in > ip6gre_xmit_other() > > Hello. > > On 09/23/2016 10:50 PM, Lanc

[PATCH 3/3] bpf powerpc: add support for bpf constant blinding

2016-09-23 Thread Naveen N. Rao
In line with similar support for other architectures by Daniel Borkmann. 'MOD Default X' from test_bpf without constant blinding: 84 bytes emitted from JIT compiler (pass:3, flen:7) d58a4688 + : 0: nop 4: nop 8: std r27,-40(r1) c: std r28,-32(r1) 10: xor

[PATCH 2/3] bpf powerpc: implement support for tail calls

2016-09-23 Thread Naveen N. Rao
Tail calls allow JIT'ed eBPF programs to call into other JIT'ed eBPF programs. This can be achieved either by: (1) retaining the stack setup by the first eBPF program and having all subsequent eBPF programs re-using it, or, (2) by unwinding/tearing down the stack and having each eBPF program deal w

[PATCH 1/3] bpf powerpc: introduce accessors for using the tmp local stack space

2016-09-23 Thread Naveen N. Rao
While at it, ensure that the location of the local save area is consistent whether or not we setup our own stackframe. This property is utilised in the next patch that adds support for tail calls. Signed-off-by: Naveen N. Rao --- arch/powerpc/net/bpf_jit64.h | 16 +--- arch/powerpc/net/

Re: [RFC] net: store port/representative id in metadata_dst

2016-09-23 Thread John Fastabend
On 16-09-23 01:17 PM, Jakub Kicinski wrote: > On Fri, 23 Sep 2016 10:22:59 -0700, Samudrala, Sridhar wrote: >> On 9/23/2016 8:29 AM, Jakub Kicinski wrote: >>> On Fri, 23 Sep 2016 07:23:26 -0700, John Fastabend wrote: Yep, I like the idea in general. I had a slightly different approach in >>>

[PATCH] nfp: bpf: improve handling for disabled BPF syscall

2016-09-23 Thread Arnd Bergmann
I stumbled over a new warning during randconfig testing, with CONFIG_BPF_SYSCALL disabled: drivers/net/ethernet/netronome/nfp/nfp_net_offload.c: In function 'nfp_net_bpf_offload': drivers/net/ethernet/netronome/nfp/nfp_net_offload.c:263:3: error: '*((void *)&res+4)' may be used uninitialized in

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Uwe Kleine-König
Hello Russell, On Fri, Sep 23, 2016 at 07:37:25PM +0100, Russell King - ARM Linux wrote: > On Fri, Sep 23, 2016 at 11:26:18AM -0700, Eric Nelson wrote: > > So the question is: should we just live with this and acknowledge a > > performance penalty of bad alignment or do something about it? > > We

Re: [RFC] net: store port/representative id in metadata_dst

2016-09-23 Thread Jakub Kicinski
On Fri, 23 Sep 2016 10:22:59 -0700, Samudrala, Sridhar wrote: > On 9/23/2016 8:29 AM, Jakub Kicinski wrote: > > On Fri, 23 Sep 2016 07:23:26 -0700, John Fastabend wrote: > >> Yep, I like the idea in general. I had a slightly different approach in > >> mind though. If you look at __dev_queue_xmit(

[PATCH] mlx5: Add ndo_poll_controller() implementation

2016-09-23 Thread Calvin Owens
This implements ndo_poll_controller in net_device_ops for mlx5, which is necessary to use netconsole with this driver. Signed-off-by: Calvin Owens --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/ethernet/

[PATCH 2/3] mac80211: Export fq memory limit information in debugfs

2016-09-23 Thread Toke Høiland-Jørgensen
Add memory limit, usage and overlimit counter to per-PHY 'aqm' debugfs file. Signed-off-by: Toke Høiland-Jørgensen --- net/mac80211/debugfs.c | 8 1 file changed, 8 insertions(+) diff --git a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c index 8ca62b6..f56e2f4 100644 --- a/net/mac802

[PATCH 0/3] Add memory limits to fq.h and mac80211 TXQ

2016-09-23 Thread Toke Høiland-Jørgensen
This is a series of small patches to avoid OOM conditions on small wireless devices with the mac80211 intermediate TXQ structure. The current default limit in fq.h translates to up to 16 Mbytes of memory usage, which can be fatal to a device with 32 MBytes of total RAM. Rather than just change the

[PATCH 3/3] mac80211: Set lower memory limit for non-VHT devices

2016-09-23 Thread Toke Høiland-Jørgensen
Small devices can run out of memory from queueing too many packets. If VHT is not supported by the PHY, having more than 4 MBytes of total queue in the TXQ intermediate queues is not needed, and so we can safely limit the memory usage in these cases and avoid OOM. Signed-off-by: Toke Høiland-Jørge

[PATCH 1/3] fq.h: Port memory limit mechanism from fq_codel

2016-09-23 Thread Toke Høiland-Jørgensen
The reusable fairness queueing implementation (fq.h) lacks the memory usage limit that the fq_codel qdisc has. This means that small devices (e.g. WiFi routers) can run out of memory when flooded with a large number of packets. This ports the memory limit feature from fq_codel to fq.h. Signed-off-

Re: [PATCH net v2] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()

2016-09-23 Thread Sergei Shtylyov
Hello. On 09/23/2016 10:50 PM, Lance Richardson wrote: Similar to commit 3be07244b733 ("ip6_gre: fix flowi6_proto value in xmit path"), set flowi6_proto to IPPROTO_GRE for output route lookup. Up until now, ip6gre_xmit_other() has set flowi6_proto to a bogus value. This affected output route l

Re: [PATCH net] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()

2016-09-23 Thread Shmulik Ladkani
On Fri, 23 Sep 2016 15:52:24 -0400 (EDT) Lance Richardson wrote: > > From: "Shmulik Ladkani" > > Suggesting to add: > > > > Up until now, 'ip6gre_xmit_other' has set flowi6_proto to a bogus value. > > This affects output route lookup upon xmit of non ipv4/ipv6 packets on a > > ip6gretap device,

Re: [PATCH net] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()

2016-09-23 Thread Lance Richardson
> From: "Shmulik Ladkani" > To: "Lance Richardson" > Cc: netdev@vger.kernel.org > Sent: Friday, September 23, 2016 3:00:36 PM > Subject: Re: [PATCH net] ip6_gre: fix flowi6_proto value in > ip6gre_xmit_other() > > On Fri, 23 Sep 2016 12:54:59 -0400 Lance Richardson > wrote: > > Similar to comm

[PATCH net v2] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()

2016-09-23 Thread Lance Richardson
Similar to commit 3be07244b733 ("ip6_gre: fix flowi6_proto value in xmit path"), set flowi6_proto to IPPROTO_GRE for output route lookup. Up until now, ip6gre_xmit_other() has set flowi6_proto to a bogus value. This affected output route lookup for packets sent on an ip6gretap device in cases wher

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-23 Thread Larry Finger
On 09/23/2016 01:27 PM, Joe Perches wrote: Help along debugging by showing what switch/case variable is not being processed in these messages. Signed-off-by: Joe Perches Acked-by: Larry Finger Thanks, Larry

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-23 Thread Joe Perches
On Fri, 2016-09-23 at 13:59 -0500, Larry Finger wrote: > I'm not familiar with the %#x format. What does it do? Outputs SPECIAL prefix, it's the same as "0x%x" lib/vsprintf.c: #define SPECIAL 64 /* prefix hex with "0x", octal with "0" */

Re: [PATCH] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-23 Thread Greg KH
On Fri, Sep 23, 2016 at 12:24:50PM -0600, chris.r...@usask.ca wrote: > From: Chris Roth > > Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet > Bridge Controller (Vendor=04b4 ProdID=3610). > > Patch verified on x64 linux kernel 4.7.4 system with the > Kensington SD4600P USB-C Universal

Re: [PATCH net] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()

2016-09-23 Thread Shmulik Ladkani
On Fri, 23 Sep 2016 12:54:59 -0400 Lance Richardson wrote: > Similar to commit 3be07244b733 ("ip6_gre: fix flowi6_proto value in > xmit path"), set flowi6_proto to IPPROTO_GRE for output route lookup. Suggesting to add: Up until now, 'ip6gre_xmit_other' has set flowi6_proto to a bogus value. Thi

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-23 Thread Larry Finger
On 09/23/2016 01:27 PM, Joe Perches wrote: Help along debugging by showing what switch/case variable is not being processed in these messages. Signed-off-by: Joe Perches Joe, You beat me to the patch. No problem as this one looks OK; however, I'm not familiar with the %#x format. What does

Re: [PATCH] netns: move {inc,dec}_net_namespaces into #ifdef

2016-09-23 Thread Eric W. Biederman
Arnd Bergmann writes: > With the newly enforced limit on the number of namespaces, > we get a build warning if CONFIG_NETNS is disabled: > > net/core/net_namespace.c:273:13: error: 'dec_net_namespaces' defined but not > used [-Werror=unused-function] > net/core/net_namespace.c:268:24: error: 'in

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Eric Nelson
Thanks Russell, On 09/23/2016 11:37 AM, Russell King - ARM Linux wrote: > On Fri, Sep 23, 2016 at 11:26:18AM -0700, Eric Nelson wrote: >> So the question is: should we just live with this and acknowledge a >> performance penalty of bad alignment or do something about it? > > Well, I've no interes

[PATCH] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-23 Thread chris.roth
From: Chris Roth Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller (Vendor=04b4 ProdID=3610). Patch verified on x64 linux kernel 4.7.4 system with the Kensington SD4600P USB-C Universal Dock with Power, which uses the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge C

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Eric Nelson
Thanks Russell, On 09/23/2016 11:30 AM, Russell King - ARM Linux wrote: > On Fri, Sep 23, 2016 at 08:13:01PM +0200, Andrew Lunn wrote: >>> Since the hardware requires longword alignment for its' DMA transfers, >>> aligning the IP header will require a memcpy, right? >> >> The vf610 FEC has an SHIF

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Russell King - ARM Linux
On Fri, Sep 23, 2016 at 11:26:18AM -0700, Eric Nelson wrote: > So the question is: should we just live with this and acknowledge a > performance penalty of bad alignment or do something about it? Well, I've no interest in trying to do anything with the FEC driver anymore, as I'll just generate ano

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Russell King - ARM Linux
On Fri, Sep 23, 2016 at 08:13:01PM +0200, Andrew Lunn wrote: > > Since the hardware requires longword alignment for its' DMA transfers, > > aligning the IP header will require a memcpy, right? > > The vf610 FEC has an SHIFT16 bit in register ENETx_TACC, which inserts > two padding bits on transmit

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Eric Nelson
Thanks Andrew. On 09/23/2016 11:13 AM, Andrew Lunn wrote: >> Since the hardware requires longword alignment for its' DMA transfers, >> aligning the IP header will require a memcpy, right? > > The vf610 FEC has an SHIFT16 bit in register ENETx_TACC, which inserts > two padding bits on transmit. EN

[PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-23 Thread Joe Perches
Help along debugging by showing what switch/case variable is not being processed in these messages. Signed-off-by: Joe Perches --- drivers/net/wireless/realtek/rtlwifi/core.c | 3 ++- drivers/net/wireless/realtek/rtlwifi/pci.c | 3 ++- drivers/net/wireless/realtek/rtlwifi/ps

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Eric Nelson
Thanks Russell, On 09/23/2016 10:37 AM, Russell King - ARM Linux wrote: > On Fri, Sep 23, 2016 at 10:19:50AM -0700, Eric Nelson wrote: >> Oddly, it does prevent the vast majority (90%+) of the alignment errors. >> >> I believe this is because the compiler is generating an ldm instruction >> when t

Re: [PATCH net-next 08/15] rxrpc: Fix call timer

2016-09-23 Thread David Howells
Sergei Shtylyov wrote: > > + if (call->timer.expires != t || !timer_pending(&call->timer)) { > > mod_timer(&call->timer, t); > > } > >CodingStyle: {} not needed now. See patch 11. David

Re: [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of scheduled resend by ACK parser

2016-09-23 Thread David Howells
Sergei Shtylyov wrote: > > case RXRPC_ACK_TYPE_NACK: > > if (anno_type == RXRPC_TX_ANNO_NAK) > > continue; > > + if (anno_type == RXRPC_TX_ANNO_RETRANS) > > + continue; > >Why not fold the

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Andrew Lunn
> Since the hardware requires longword alignment for its' DMA transfers, > aligning the IP header will require a memcpy, right? The vf610 FEC has an SHIFT16 bit in register ENETx_TACC, which inserts two padding bits on transmit. ENETx_RACC has the same. What about your hardware? Andrew

Re: [PATCH RFC 0/2] ila: ilarouter bpf code for tc and xdp

2016-09-23 Thread Jesper Dangaard Brouer
On Fri, 23 Sep 2016 10:16:33 -0700 Alexei Starovoitov wrote: > From: Aaron Yue > > Jesper, > > here is old email and cover letter that didn't make it to the list > due to vger outage (I guess). > The verifier patch that Aaron is talking about has landed long ago. > > The dataplane of ILA rou

Re: [PATCH net-next 08/15] rxrpc: Fix call timer

2016-09-23 Thread Sergei Shtylyov
On 09/23/2016 06:16 PM, David Howells wrote: Fix the call timer in the following ways: (1) If call->resend_at or call->ack_at are before or equal to the current time, then ignore that timeout. (2) If call->expire_at is before or equal to the current time, then don't set the timer a

Re: [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of scheduled resend by ACK parser

2016-09-23 Thread Sergei Shtylyov
Hello. On 09/23/2016 06:16 PM, David Howells wrote: When rxrpc_input_soft_acks() is parsing the soft-ACKs from an ACK packet, it updates the Tx packet annotations in the annotation buffer. If a soft-ACK is an ACK, then we overwrite unack'd, nak'd or to-be-retransmitted states and that is fine;

Re: device-tree support for writing to phy registers?

2016-09-23 Thread Florian Fainelli
On 09/23/2016 10:36 AM, Tim Harvey wrote: > On Fri, Sep 23, 2016 at 9:29 AM, Florian Fainelli > wrote: >> On 09/23/2016 08:40 AM, Tim Harvey wrote: >>> Greetings, >>> >>> I've got a TI DP83867 GbE phy that requires some register writes to >>> configure its refclock output. Is there a generic devi

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Russell King - ARM Linux
On Fri, Sep 23, 2016 at 10:19:50AM -0700, Eric Nelson wrote: > Oddly, it does prevent the vast majority (90%+) of the alignment errors. > > I believe this is because the compiler is generating an ldm instruction > when the ntohl() call is used, but I'm stumped about why these aren't > generating f

Re: [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb()

2016-09-23 Thread Alexander Duyck
On Fri, Sep 23, 2016 at 10:20 AM, Sowmini Varadhan wrote: > On (09/23/16 07:17), Alexander Duyck wrote: >> >> Is this basically about, e.g., putting the vxlanhdr in its own >> >> skb_frag_t, or something else? >> > >> > Yes, and this way skb_header_pointer() is forced to do a memcpy. > : >> For

Re: device-tree support for writing to phy registers?

2016-09-23 Thread Tim Harvey
On Fri, Sep 23, 2016 at 9:29 AM, Florian Fainelli wrote: > On 09/23/2016 08:40 AM, Tim Harvey wrote: >> Greetings, >> >> I've got a TI DP83867 GbE phy that requires some register writes to >> configure its refclock output. Is there a generic device-tree API for >> writing to raw registers or is th

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Eric Nelson
Hi Eric, On 09/23/2016 10:19 AM, Eric Nelson wrote: > Thanks Eric, > > On 09/23/2016 09:54 AM, Eric Dumazet wrote: >> On Fri, Sep 23, 2016 at 9:43 AM, Eric Nelson wrote: >>> >>> Hello all, >>> >>> We're seeing alignment issues from the ethernet stack on an i.MX6UL board: >>> >>> > > > >>> >>>

Re: [RFC] net: store port/representative id in metadata_dst

2016-09-23 Thread Samudrala, Sridhar
On 9/23/2016 8:29 AM, Jakub Kicinski wrote: On Fri, 23 Sep 2016 07:23:26 -0700, John Fastabend wrote: On 16-09-23 05:55 AM, Jakub Kicinski wrote: On Fri, 23 Sep 2016 11:06:09 +0200, Jiri Benc wrote: On Fri, 23 Sep 2016 08:34:29 +0200, Jiri Pirko wrote: So if I understand that correctly, thi

Re: [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb()

2016-09-23 Thread Sowmini Varadhan
On (09/23/16 07:17), Alexander Duyck wrote: > >> Is this basically about, e.g., putting the vxlanhdr in its own > >> skb_frag_t, or something else? > > > > Yes, and this way skb_header_pointer() is forced to do a memcpy. : > For Tx it all becomes a bit trickier since it would likely require us >

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Eric Nelson
Thanks Eric, On 09/23/2016 09:54 AM, Eric Dumazet wrote: > On Fri, Sep 23, 2016 at 9:43 AM, Eric Nelson wrote: >> >> Hello all, >> >> We're seeing alignment issues from the ethernet stack on an i.MX6UL board: >> >> >> >> - id = ntohl(*(__be32 *)&iph->id); >> - flush = (u16)((ntohl(*(__be32 *)i

[PATCH RFC 1/2] samples/bpf: ilarouter for tc

2016-09-23 Thread Alexei Starovoitov
From: Aaron Yue From: Aaron Yue Requires a userspace program to insert ila mappings to the ila map. Signed-off-by: Aaron Yue Signed-off-by: Aaron Yue --- samples/bpf/Makefile | 1 + samples/bpf/ila.h | 80 + samples/bpf/ilarouter_tc.c | 124

[PATCH RFC 2/2] samples/bpf: ilarouter for xdp

2016-09-23 Thread Alexei Starovoitov
From: Aaron Yue From: Aaron Yue Requires a userspace program to insert ila mappings and mac addresses to the ila map. Needs a verifier patch to directly allow access to the pkt from the bpf map. Signed-off-by: Aaron Yue Signed-off-by: Aaron Yue --- samples/bpf/Makefile| 1 + sample

[PATCH RFC 0/2] ila: ilarouter bpf code for tc and xdp

2016-09-23 Thread Alexei Starovoitov
From: Aaron Yue Jesper, here is old email and cover letter that didn't make it to the list due to vger outage (I guess). The verifier patch that Aaron is talking about has landed long ago. The dataplane of ILA router is very short and simple. Control plane is very different matter. It's not rea

[PATCH net] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()

2016-09-23 Thread Lance Richardson
Similar to commit 3be07244b733 ("ip6_gre: fix flowi6_proto value in xmit path"), set flowi6_proto to IPPROTO_GRE for output route lookup. Since the correct proto is already set in the tunnel flowi6 template via commit 252f3f5a1189 ("ip6_gre: Set flowi6_proto as IPPROTO_GRE in xmit path."), simply d

Re: [PATCH] net: bcmgenet: Fix EPHY reset in power up

2016-09-23 Thread Florian Fainelli
On 09/23/2016 08:04 AM, Jaedon Shin wrote: > Hi Andrew, > > On 23 Sep 2016, at 11:06 PM, Andrew Lunn wrote: >> >> On Fri, Sep 23, 2016 at 10:20:04PM +0900, Jaedon Shin wrote: >>> The bcmgenet_mii_reset() is always not running in power up sequence >>> after 'commit 62469c76007e ("net: ethernet: bc

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread Eric Dumazet
On Fri, Sep 23, 2016 at 9:43 AM, Eric Nelson wrote: > > Hello all, > > We're seeing alignment issues from the ethernet stack on an i.MX6UL board: > > root@mx6ul:~# cat /proc/cpu/alignment > User: 0 > System: 470010 (inet_gro_receive+0x104/0x278) > > This seems to be related to the ip header alignm

Re: [PATCH] softirq: let ksoftirqd do its job

2016-09-23 Thread Jesper Dangaard Brouer
On Fri, 23 Sep 2016 13:53:33 +0200 Peter Zijlstra wrote: > On Fri, Sep 23, 2016 at 01:35:59PM +0200, Daniel Borkmann wrote: > > On 09/02/2016 08:39 AM, David Miller wrote: > > > > > >I'm just kind of assuming this won't go through my tree, but I can take > > >it if that's what everyone agrees t

Re: [PATCH] fs/select: add vmalloc fallback for select(2)

2016-09-23 Thread Jason Baron
Hi, On 09/23/2016 03:24 AM, Nicholas Piggin wrote: On Fri, 23 Sep 2016 14:42:53 +0800 "Hillf Danton" wrote: The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows with the number of fds passed. We had a customer report page allocation failures of order-4 for this allocat

Alignment issues with freescale FEC driver

2016-09-23 Thread Eric Nelson
Hello all, We're seeing alignment issues from the ethernet stack on an i.MX6UL board: root@mx6ul:~# cat /proc/cpu/alignment User: 0 System: 470010 (inet_gro_receive+0x104/0x278) This seems to be related to the ip header alignment, and there was much discussion in mailing list threads [1] and [2]

Re: device-tree support for writing to phy registers?

2016-09-23 Thread Florian Fainelli
On 09/23/2016 08:40 AM, Tim Harvey wrote: > Greetings, > > I've got a TI DP83867 GbE phy that requires some register writes to > configure its refclock output. Is there a generic device-tree API for > writing to raw registers or is that something that would be need to be > added to a specific phy

[PATCH] netns: move {inc,dec}_net_namespaces into #ifdef

2016-09-23 Thread Arnd Bergmann
With the newly enforced limit on the number of namespaces, we get a build warning if CONFIG_NETNS is disabled: net/core/net_namespace.c:273:13: error: 'dec_net_namespaces' defined but not used [-Werror=unused-function] net/core/net_namespace.c:268:24: error: 'inc_net_namespaces' defined but not

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-23 Thread Shmulik Ladkani
On Fri, 23 Sep 2016 08:48:33 -0400 Jamal Hadi Salim wrote: > > Even today, one may create loops using existing 'egress redirect', > > e.g. this rediculously errorneous construct: > > > > # ip l add v0 type veth peer name v0p > > # tc filter add dev v0p parent : basic \ > > action mirred

device-tree support for writing to phy registers?

2016-09-23 Thread Tim Harvey
Greetings, I've got a TI DP83867 GbE phy that requires some register writes to configure its refclock output. Is there a generic device-tree API for writing to raw registers or is that something that would be need to be added to a specific phy driver with a device-tree binding? There is a DP83867

Re: [RFC] net: store port/representative id in metadata_dst

2016-09-23 Thread Jakub Kicinski
On Fri, 23 Sep 2016 07:23:26 -0700, John Fastabend wrote: > On 16-09-23 05:55 AM, Jakub Kicinski wrote: > > On Fri, 23 Sep 2016 11:06:09 +0200, Jiri Benc wrote: > >> On Fri, 23 Sep 2016 08:34:29 +0200, Jiri Pirko wrote: > >>> So if I understand that correctly, this would need some "shared netde

Re: [PATCH V3 1/3] Documentation: devicetree: add qca8k binding

2016-09-23 Thread Rob Herring
On Thu, Sep 15, 2016 at 04:26:39PM +0200, John Crispin wrote: > Add device-tree binding for ar8xxx switch families. > > Cc: devicet...@vger.kernel.org > Signed-off-by: John Crispin > --- > Changes in V2 > * fixup example to include phy nodes and corresponding phandles > * add a note explaining wh

[PATCH net-next 10/15] rxrpc: Don't call the tx_ack tracepoint if don't generate an ACK

2016-09-23 Thread David Howells
rxrpc_send_call_packet() is invoking the tx_ack tracepoint before it checks whether there's an ACK to transmit (another thread may jump in and transmit it). Fix this by only invoking the tracepoint if we get a valid ACK to transmit. Further, only allocate a serial number if we're going to actuall

[PATCH net-next 03/15] rxrpc: Make sure sendmsg() is woken on call completion

2016-09-23 Thread David Howells
Make sure that sendmsg() gets woken up if the call it is waiting for completes abnormally. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |1 + 1 file changed, 1 insertion(+) diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h index b13754a6dd7a..808ab750dc6b 100644 --

[PATCH net-next 05/15] rxrpc: Use before_eq() and friends to compare serial numbers

2016-09-23 Thread David Howells
before_eq() and friends should be used to compare serial numbers (when not checking for (non)equality) rather than casting to int, subtracting and checking the result. Signed-off-by: David Howells --- net/rxrpc/input.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/r

[PATCH net-next 11/15] rxrpc: Add a tracepoint for the call timer

2016-09-23 Thread David Howells
Add a tracepoint to log call timer initiation, setting and expiry. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 36 net/rxrpc/ar-internal.h | 13 - net/rxrpc/call_event.c |7 --- net/rxrpc/call_object.c

[PATCH net-next 09/15] rxrpc: Pass the last Tx packet marker in the annotation buffer

2016-09-23 Thread David Howells
When the last packet of data to be transmitted on a call is queued, tx_top is set and then the RXRPC_CALL_TX_LAST flag is set. Unfortunately, this leaves a race in the ACK processing side of things because the flag affects the interpretation of tx_top and also allows us to start receiving reply da

[PATCH net-next 00/15] rxrpc: Bug fixes and tracepoints

2016-09-23 Thread David Howells
can be found here also: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160923 David --- David Howells (15): rxrpc: Preset timestamp

[PATCH net-next 12/15] rxrpc: Add data Tx tracepoint and adjust Tx ACK tracepoint

2016-09-23 Thread David Howells
Add a tracepoint to log transmission of DATA packets (including loss injection). Adjust the ACK transmission tracepoint to include the packet serial number and to line this up with the DATA transmission display. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 50 +

[PATCH net-next 01/15] rxrpc: Preset timestamp on Tx sk_buffs

2016-09-23 Thread David Howells
Set the timestamp on sk_buffs holding packets to be transmitted before queueing them because the moment the packet is on the queue it can be seen by the retransmission algorithm - which may see a completely random timestamp. If the retransmission algorithm sees such a timestamp, it may retransmit

[PATCH net-next 13/15] rxrpc: Add a tracepoint to log injected Rx packet loss

2016-09-23 Thread David Howells
Add a tracepoint to log received packets that get discarded due to Rx packet loss. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 21 + net/rxrpc/input.c| 11 +-- 2 files changed, 26 insertions(+), 6 deletions(-) diff --git a/include

  1   2   3   >