[net-next 14/15] i40e: don't configure zero-size RSS table

2016-09-24 Thread Jeff Kirsher
From: Mitch Williams In some rare cases, we might get a VSI with no queues. In this case, we cannot configure RSS on this VSI as it will try to divide by zero when configuring the lookup table. Change-ID: I6ae173a7dd3481a081e079eb10eb80275de2adb0 Signed-off-by: Mitch Williams Tested-by: Andrew

[net-next 07/15] i40e/i40evf: Changed version to 1.6.16

2016-09-24 Thread Jeff Kirsher
From: Bimmy Pujari Signed-off-by: Bimmy Pujari Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/et

[net-next 05/15] i40e: check conflicting ntuple/sideband rules when re-enabling ATR

2016-09-24 Thread Jeff Kirsher
From: Jacob Keller In i40e_fdir_check_and_reenable(), the driver performs some checks to determine whether it is safe to re-enable FD Sideband and FD ATR support. The current check will only determine if there is available space in the flow director table. However, this ignores the fact that ATR

[net-next 10/15] i40e: Fix Flow Director raw_buf cleanup

2016-09-24 Thread Jeff Kirsher
From: Alexander Duyck The Tx cleanup flow was incorrectly assuming it could check for the flow director bits after it had unmapped the buffer. However in this case it results in us trying to free a raw_buf as though it is an sk_buff. To fix this I am moving up the flag test for the FD_SB bit so

[net-next 12/15] i40e: Split Flow Director descriptor config into separate function

2016-09-24 Thread Jeff Kirsher
From: Alexander Duyck In an effort to improve code readability I am splitting the Flow Director filter configuration out into a separate function like we have done for the standard xmit path. The general idea is to provide a single block of code that translates the flow specification into a prop

[net-next 15/15] i40evf: support queue-specific settings for interrupt moderation

2016-09-24 Thread Jeff Kirsher
From: Jacob Keller In commit a75e8005d506f3 ("i40e: queue-specific settings for interrupt moderation") the i40e driver gained support for setting interrupt moderation values per queue. This patch adds support for this feature to the i40evf driver as well. In addition, a few changes are made to th

[net-next 02/15] i40e: fix deleting mac filters

2016-09-24 Thread Jeff Kirsher
From: Alan Brady There exists a bug in which deleting a mac filter does not actually occur. The driver reports that the filter has been deleted with no error. The problem occurs because the wrong cmd_flag is passed to the firmware when deleting the filter. The firmware reports an error back to

[net-next 08/15] i40e: Increase minimum number of allocated VSI

2016-09-24 Thread Jeff Kirsher
From: Akeem Abodunrin This patch increases minimum number of allocated VSIs, so as to resolve failure adding VSI for VF when 64-VFs assigned to a PF. The driver supports up to 128 VFs per device, users can decide to enable up to 64-VFs on a single PF, especially 2 X 40 devices. In that scenario,

[net-next 04/15] i40e: cleanup ATR auto_disable_flags use

2016-09-24 Thread Jeff Kirsher
From: Jacob Keller Some locations that disable ATR accidentally used the "full" disable by disabling the flag in the standard flags field. This incorrectly forces ATR off permanently instead of temporarily disabling it. In addition, some code locations accidentally set the ATR flag enabled when t

[net-next 09/15] i40evf: enable adaptive interrupt throttling

2016-09-24 Thread Jeff Kirsher
From: Mitch Williams All of the code to support adaptive interrupt throttling is already in the interrupt handler, it just needs to be enabled. Fill out the data structures properly to make it happen. Single-flow traffic tests may show slightly lower throughput, but interrupts per second will dro

[net-next 11/15] i40e/i40evf: Add txring_txq function to match fm10k and ixgbe

2016-09-24 Thread Jeff Kirsher
From: Alexander Duyck This patch adds a txring_txq function which allows us to convert a i40e_ring/i40evf_ring to a netdev_tx_queue structure. This way we can avoid having to make a multi-line function call for all the spots that need access to this. Change-ID: Ic063b71d8b92ea406d2c32e798c8e2b0

[net-next 03/15] i40e: add encap csum VF offload flag

2016-09-24 Thread Jeff Kirsher
From: Preethi Banala Add ENCAP_CSUM offload negotiation flag. Currently VF assumes checksum offload for encapsulated packets is supported by default. Going forward, this feature needs to be negotiated with PF before advertising to the stack. Hence, we need a flag to control it. This is in regards

[net-next 13/15] i40e: Strip out debugfs hook for Flow Director filter programming

2016-09-24 Thread Jeff Kirsher
From: Alexander Duyck This interface was only ever meant for debug only. Since it is not supposed to be here we are removing it. Change-ID: Id771a1e5e7d3e2b4b7f56591b61fb48c921e1d04 Signed-off-by: Alexander Duyck Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/

[net-next 06/15] i40e: removing unreachable code

2016-09-24 Thread Jeff Kirsher
From: Henry Tieman The return value from i40e_shutdown_adminq() is always 0 (I40E_SUCCESS). So, the test for non-0 will never be true. Cleanup by removing the test and debug print statement. Change-ID: Ie51e8e37515c3e3a6a9ff26fa951d0e5e24343c1 Signed-off-by: Henry Tieman Tested-by: Andrew Bower

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2016-09-24

2016-09-24 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Harshitha removes the ability to set or advertise X722 to 100 Mbps, since it is not supported, so we should not be able to advertise or set the NIC to 100 Mbps. Alan fixes an issue where deleting a MAC filter did not really delete the filter i

[net-next 01/15] i40e: Remove 100 Mbps SGMII support for X722

2016-09-24 Thread Jeff Kirsher
From: Harshitha Ramamurthy This patch fixes the problem where driver shows 100 Mbps as a supported speed, and allows it to be configured for advertising on X722 devices. This patch fixes the problem by not setting the 100 Mbps SGMII flag for X722 devices. Without this patch, the user incorrectly

[PATCH] net: bcmgenet: remove unused function in bcmgenet.c

2016-09-24 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/net/ethernet/broadcom/genet/bcmgenet.c:2763:5: warning: no previous prototype for 'bcmgenet_hfb_add_filter' [-Wmissing-prototypes] In fact, this function is implemented in drivers/net/ethernet/broadcom/genet/bcmgenet.c, but be called by no o

[PATCH] cxgb4: mark symbols static where possible

2016-09-24 Thread Baoyou Xie
We get 10 warnings when building kernel with W=1: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:304:5: warning: no previous prototype for 'cxgb4_dcb_enabled' [-Wmissing-prototypes] drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:194:5: warning: no previous prototype for 'setup_sge_queues_uld' [-

[PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static

2016-09-24 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, b

[PATCH] ixgbe: mark symbols static where possible

2016-09-24 Thread Baoyou Xie
We get 2 warnings when building kernel with W=1: drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes] drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning: no previous prototype for 'ixgbe_led_off_t_x550em

Re: [PATCH][V2] mlxsw: spectrum: remove redundant check if err is zero

2016-09-24 Thread Ido Schimmel
On Sat, Sep 24, 2016 at 06:03:38PM -0700, Colin King wrote: > From: Colin Ian King > > There is an earlier check and return if err is non-zero, so > the check to see if it is zero is redundant in every iteration > of the loop and hence the check can be removed. > > Signed-off-by: Colin Ian King

[PATCH net-next] Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

2016-09-24 Thread Florian Fainelli
This reverts commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct net_device") because it causes GENETv1/2/3 adapters to expose the following behavior after an ifconfig down/up sequence: PING fainelli-linux (10.112.156.244): 56 data bytes 64 bytes from 10.112.156.244: seq=1 ttl=61

Re: [PATCH net] Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

2016-09-24 Thread Florian Fainelli
On 09/24/2016 07:51 PM, Florian Fainelli wrote: > > > On 09/24/2016 05:10 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Sat, 24 Sep 2016 12:58:30 -0700 >> >>> There is already a commit: >>> >>> Revert "net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings" >>> >>> whic

Re: [PATCH net] Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

2016-09-24 Thread Florian Fainelli
On 09/24/2016 05:10 PM, David Miller wrote: > From: Florian Fainelli > Date: Sat, 24 Sep 2016 12:58:30 -0700 > >> There is already a commit: >> >> Revert "net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings" >> >> which should make this apply cleanly to "net" now. > > But look at

[PATCH] ipv6 addrconf: implement RFC7559 router solicitation backoff

2016-09-24 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This implements: https://tools.ietf.org/html/rfc7559 Backoff is performed according to RFC3315 section 14: https://tools.ietf.org/html/rfc3315#section-14 Signed-off-by: Maciej Żenczykowski --- include/net/if_inet6.h | 1 + net/ipv6/addrconf.c| 31 +++

Re: [PATCH 5/7] ipv6 addrconf: implement RFC7559 router solicitation backoff

2016-09-24 Thread Maciej Żenczykowski
Ok, so that seems to have all sorts of __divdi3 or __aeabi_ldivmod undefined errors on 32-bit platforms (ie. arm/m68k/i386).

[PATCH][V2] mlxsw: spectrum: remove redundant check if err is zero

2016-09-24 Thread Colin King
From: Colin Ian King There is an earlier check and return if err is non-zero, so the check to see if it is zero is redundant in every iteration of the loop and hence the check can be removed. Signed-off-by: Colin Ian King --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 10 +- 1

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-24 Thread Cong Wang
On Fri, Sep 23, 2016 at 8:40 AM, Shmulik Ladkani wrote: > On Fri, 23 Sep 2016 08:48:33 -0400 Jamal Hadi Salim wrote: >> > Even today, one may create loops using existing 'egress redirect', >> > e.g. this rediculously errorneous construct: >> > >> > # ip l add v0 type veth peer name v0p >> > # t

Re: [PATCH net] Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

2016-09-24 Thread David Miller
From: Florian Fainelli Date: Sat, 24 Sep 2016 12:58:30 -0700 > There is already a commit: > > Revert "net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings" > > which should make this apply cleanly to "net" now. But look at net-next, it got re-added there. This is going to be a bi

Re: [PATCH net-next] gre: use nla_get_be32() to extract flowinfo

2016-09-24 Thread David Miller
From: Lance Richardson Date: Sat, 24 Sep 2016 14:01:04 -0400 > Eliminate a sparse endianness mismatch warning, use nla_get_be32() to > extract a __be32 value instead of nla_get_u32(). > > Signed-off-by: Lance Richardson Applied.

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-24 Thread Cong Wang
On Thu, Sep 22, 2016 at 10:11 PM, Shmulik Ladkani wrote: > Was wondering why it's missing, googled a bit with no meaningful > results, so speculated the following: > > Some time long ago, initial 'mirred' purpose was to facilitate ifb. > Therefore 'egress redirect' was implemented. Jamal probably

Re: [PATCH] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-24 Thread David Miller
From: Chris Roth Date: Sat, 24 Sep 2016 10:59:04 -0600 > Due to my lack of familiarity with the how git send-email works, I've > unintentionally had my name listed as the first 'from' whereas I > intended Allan Chou to be listed as the first 'from' in the patch. If > anyone can correct this on my

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-24 Thread Cong Wang
On Thu, Sep 22, 2016 at 6:21 AM, Shmulik Ladkani wrote: > From: Shmulik Ladkani > > Up until now, 'action mirred' supported only egress actions (either > TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). > > This patch implements the corresponding ingress actions > TCA_INGRESS_REDIR and TCA_INGRESS_MIRROR.

[PATCH net-next 2/8] rxrpc: Send an immediate ACK if we fill in a hole

2016-09-24 Thread David Howells
Send an immediate ACK if we fill in a hole in the buffer left by an out-of-sequence packet. This may allow the congestion management in the peer to avoid a retransmission if packets got reordered on the wire. Signed-off-by: David Howells --- net/rxrpc/input.c | 10 +- 1 file changed,

[PATCH net-next 3/8] rxrpc: Include the last reply DATA serial number in the final ACK

2016-09-24 Thread David Howells
In a client call, include the serial number of the last DATA packet of the reply in the final ACK. Signed-off-by: David Howells --- net/rxrpc/recvmsg.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/rxrpc/recvmsg.c b/net/rxrpc/recvmsg.c index a7458c398b9e..038a

[PATCH net-next 5/8] rxrpc: Delay the resend timer to allow for nsec->jiffies conv error

2016-09-24 Thread David Howells
When determining the resend timer value, we have a value in nsec but the timer is in jiffies which may be a million or more times more coarse. nsecs_to_jiffies() rounds down - which means that the resend timeout expressed as jiffies is very likely earlier than the one expressed as nanoseconds from

[PATCH net-next 6/8] rxrpc: Generate a summary of the ACK state for later use

2016-09-24 Thread David Howells
Generate a summary of the Tx buffer packet state when an ACK is received for use in a later patch that does congestion management. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h | 14 ++ net/rxrpc/input.c | 45 ++--- 2 file

[PATCH net-next 8/8] rxrpc: Implement slow-start

2016-09-24 Thread David Howells
Implement RxRPC slow-start, which is similar to RFC 5681 for TCP. A tracepoint is added to log the state of the congestion management algorithm and the decisions it makes. Notes: (1) Since we send fixed-size DATA packets (apart from the final packet in each phase), counters and calculation

[PATCH net-next 1/8] rxrpc: Send an ACK after every few DATA packets we receive

2016-09-24 Thread David Howells
Send an ACK if we haven't sent one for the last two packets we've received. This keeps the other end apprised of where we've got to - which is important if they're doing slow-start. We do this in recvmsg so that we can dispatch a packet directly without the need to wake up the background thread.

[PATCH net-next 7/8] rxrpc: Schedule an ACK if the reply to a client call appears overdue

2016-09-24 Thread David Howells
If we've sent all the request data in a client call but haven't seen any sign of the reply data yet, schedule an ACK to be sent to the server to find out if the reply data got lost. If the server hasn't yet hard-ACK'd the request data, we send a PING ACK to demand a response to find out whether we

[PATCH net-next 4/8] rxrpc: Reinitialise the call ACK and timer state for client reply phase

2016-09-24 Thread David Howells
Clear the ACK reason, ACK timer and resend timer when entering the client reply phase when the first DATA packet is received. New ACKs will be proposed once the data is queued. The resend timer is no longer relevant and we need to cancel ACKs scheduled to probe for a lost reply. Signed-off-by: D

[PATCH v5 07/16] IB/pvrdma: Add helper functions

2016-09-24 Thread Adit Ranadive
This patch adds helper functions to store guest page addresses in a page directory structure. The page directory pointer is passed down to the backend which then maps the entire memory for the RDMA object by traversing the directory. We add some more helper functions for converting to/from RDMA sta

[PATCH v5 10/16] IB/pvrdma: Add UAR support

2016-09-24 Thread Adit Ranadive
This patch adds the UAR support for the paravirtual RDMA device. The UAR pages are MMIO pages from the virtual PCI space. We define offsets within this page to provide the fast data-path operations. Reviewed-by: Yuval Shaia Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Adity

[PATCH v5 09/16] IB/pvrdma: Add support for Completion Queues

2016-09-24 Thread Adit Ranadive
This patch adds the support for creating and destroying completion queues on the paravirtual RDMA device. Reviewed-by: Yuval Shaia Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by: Bryan Tan Signed-off-by: Adit Ranadive --- Changes v4->v5: - Updat

[PATCH v5 13/16] IB/pvrdma: Add the main driver module for PVRDMA

2016-09-24 Thread Adit Ranadive
This patch adds the support to register a RDMA device with the kernel RDMA stack as well as a kernel module. This also initializes the underlying virtual PCI device. Reviewed-by: Yuval Shaia Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by: Bryan Tan

[PATCH v5 05/16] IB/pvrdma: Add functions for Verbs support

2016-09-24 Thread Adit Ranadive
This patch implements the remaining Verbs functions registered with the core RDMA stack. Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by: Bryan Tan Signed-off-by: Adit Ranadive --- Changes v4->v5: - Update include for headers in UAPI folder. - Re

[PATCH v5 11/16] IB/pvrdma: Add support for memory regions

2016-09-24 Thread Adit Ranadive
This patch adds support for creating and destroying memory regions. The PVRDMA device supports User MRs, DMA MRs (no Remote Read/Write support), Fast Register MRs. Reviewed-by: Yuval Shaia Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by: Bryan Tan

[PATCH net-next 0/8] rxrpc: Implement slow-start and other bits

2016-09-24 Thread David Howells
ux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160924 David --- David Howells (8): rxrpc: Send an ACK after every few DATA packets we receive rxrpc: Send an immedi

[PATCH v5 03/16] IB/pvrdma: Add virtual device RDMA structures

2016-09-24 Thread Adit Ranadive
This patch adds the various Verbs structures that we support in the virtual RDMA device. We have re-mapped the ones from the RDMA core stack to make sure we can maintain compatibility with our backend. Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by:

[PATCH v5 06/16] IB/pvrdma: Add paravirtual rdma device

2016-09-24 Thread Adit Ranadive
This patch adds the main device-level structures and functions to be used to provide RDMA functionality. Also, we define conversion functions from the IB core stack structures to the device-specific ones. Reviewed-by: Yuval Shaia Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by:

[PATCH v5 16/16] MAINTAINERS: Update for PVRDMA driver

2016-09-24 Thread Adit Ranadive
Add maintainer info for the PVRDMA driver. Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by: Bryan Tan Signed-off-by: Adit Ranadive --- Changes v4->v5: - Added pvrdma files to common UAPI folder. --- MAINTAINERS | 9 + 1 file changed, 9 in

[PATCH v5 12/16] IB/pvrdma: Add Queue Pair support

2016-09-24 Thread Adit Ranadive
This patch adds the ability to create, modify, query and destroy QPs. The PVRDMA device supports RC, UD and GSI QPs. Reviewed-by: Yuval Shaia Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by: Bryan Tan Signed-off-by: Adit Ranadive --- Changes v4->v

[PATCH v5 15/16] IB: Add PVRDMA driver

2016-09-24 Thread Adit Ranadive
This patch updates the InfiniBand subsystem to build the PVRDMA driver. Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by: Bryan Tan Signed-off-by: Adit Ranadive --- drivers/infiniband/Kconfig | 1 + drivers/infiniband/hw/Makefile | 1 + 2 files

[PATCH v5 08/16] IB/pvrdma: Add device command support

2016-09-24 Thread Adit Ranadive
This patch enables posting Verb requests and receiving responses to/from the backend PVRDMA emulation layer. Reviewed-by: Yuval Shaia Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by: Bryan Tan Signed-off-by: Adit Ranadive --- Changes v4->v5: - Mo

[PATCH v5 14/16] IB/pvrdma: Add Kconfig and Makefile

2016-09-24 Thread Adit Ranadive
This patch adds a Kconfig and Makefile for the PVRDMA driver. Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by: Bryan Tan Signed-off-by: Adit Ranadive --- Changes v3->v4: - Enforced dependency on VMXNet3 --- drivers/infiniband/hw/pvrdma/Kconfig |

[PATCH v5 00/16] Add Paravirtual RDMA Driver

2016-09-24 Thread Adit Ranadive
Hi Doug, others, This patch series adds a driver for a paravirtual RDMA device. The device is developed for VMware's Virtual Machines and allows existing RDMA applications to continue to use existing Verbs API when deployed in VMs on ESXi. We recently did a presentation in the OFA Workshop [1] reg

[PATCH v5 01/16] vmxnet3: Move PCI Id to pci_ids.h

2016-09-24 Thread Adit Ranadive
The VMXNet3 PCI Id will be shared with our paravirtual RDMA driver. Moved it to the shared location in pci_ids.h. Suggested-by: Leon Romanovsky Acked-by: Bjorn Helgaas Reviewed-by: Yuval Shaia Signed-off-by: Adit Ranadive --- drivers/net/vmxnet3/vmxnet3_int.h | 3 +-- include/linux/pci_ids.h

[PATCH v5 02/16] IB/pvrdma: Add user-level shared functions

2016-09-24 Thread Adit Ranadive
We share some common structures with the user-level driver. This patch adds those structures and shared functions to traverse the QP/CQ rings. Reviewed-by: Yuval Shaia Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by: Bryan Tan Signed-off-by: Adit R

[PATCH v5 04/16] IB/pvrdma: Add the paravirtual RDMA device specification

2016-09-24 Thread Adit Ranadive
This patch describes the main specification of the underlying virtual RDMA device. The pvrdma_dev_api header file defines the Verbs commands and their parameters that can be issued to the device backend. Reviewed-by: Yuval Shaia Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by:

[PATCH 2/2] brcmfmac: compile fws(ignal) code only with BCDC support enabled

2016-09-24 Thread Rafał Miłecki
From: Rafał Miłecki It's not needed by the other (msgbuf) protocol, so let's save some size and compile it conditionally. Signed-off-by: Rafał Miłecki --- .../wireless/broadcom/brcm80211/brcmfmac/Makefile | 4 +- .../broadcom/brcm80211/brcmfmac/fwsignal.h | 59 ++

[PATCH 1/2] brcmfmac: initialize fws(ignal) for BCDC protocol only

2016-09-24 Thread Rafał Miłecki
From: Rafał Miłecki There are two protocols used by Broadcom FullMAC devices: BCDC and msgbuf. They use different ways for (some part of) communication with the firmware. Firmware Signaling is required for the first one only (BCDC). So far we were always initializing fws and always calling it's

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jes Sorensen
Joe Perches writes: > On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: >> On 09/24/2016 12:32 PM, Joe Perches wrote: > [] >> o Reindent all the switch/case blocks to a more normal >> kernel style (git diff -w would show no changes here) >> That sounds like busy work to me, but if you want

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: > On 09/24/2016 12:32 PM, Joe Perches wrote: [] > o Reindent all the switch/case blocks to a more normal > kernel style (git diff -w would show no changes here) > That sounds like busy work to me, but if you want to do it, go ahead. It's rea

Huge static buffer in liquidio

2016-09-24 Thread Denys Vlasenko
Hello, I would like to discuss this commit: commit d3d7e6c65f75de18ced10a98595a847f9f95f0ce Author: Raghu Vatsavayi Date: Tue Jun 21 22:53:07 2016 -0700 liquidio: Firmware image download This patch has firmware image related changes for: firmware release upon failure, support lat

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jes Sorensen
Larry Finger writes: > On 09/24/2016 12:32 PM, Joe Perches wrote: >> Is there any value in that or is Jes' work going to make >> doing any or all of this unnecessary and futile? > > That is not yet determined. The only driver that is to be replaced at > this point is rtl8192cu. Jes only has USB I/

[PATCH net] Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

2016-09-24 Thread Florian Fainelli
This reverts commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct net_device") because it causes GENETv1/2/3 adapters to expose the following behavior after an ifconfig down/up sequence: PING fainelli-linux (10.112.156.244): 56 data bytes 64 bytes from 10.112.156.244: seq=1 ttl=61

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Larry Finger
On 09/24/2016 12:32 PM, Joe Perches wrote: (adding Jes Sorensen to recipients) On Sat, 2016-09-24 at 11:35 -0500, Larry Finger wrote: I have patches that makes HAL_DEF_WOWLAN be a no-op for the rest of the drivers, and one that sets the enum values for that particular statement to hex values. I

[PATCH v3] bpf: Set register type according to is_valid_access()

2016-09-24 Thread Mickaël Salaün
This prevent future potential pointer leaks when an unprivileged eBPF program will read a pointer value from its context. Even if is_valid_access() returns a pointer type, the eBPF verifier replace it with UNKNOWN_VALUE. The register value that contains a kernel address is then allowed to leak. Mor

[PATCH net-next] gre: use nla_get_be32() to extract flowinfo

2016-09-24 Thread Lance Richardson
Eliminate a sparse endianness mismatch warning, use nla_get_be32() to extract a __be32 value instead of nla_get_u32(). Signed-off-by: Lance Richardson --- net/ipv6/ip6_gre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index 397e1ed.

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
(adding Jes Sorensen to recipients) On Sat, 2016-09-24 at 11:35 -0500, Larry Finger wrote: > I have patches that makes HAL_DEF_WOWLAN be a no-op for the rest of the > drivers,  > and one that sets the enum values for that particular statement to hex > values. I  > also looked at the other large

Re: [PATCH] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-24 Thread Chris Roth
Due to my lack of familiarity with the how git send-email works, I've unintentionally had my name listed as the first 'from' whereas I intended Allan Chou to be listed as the first 'from' in the patch. If anyone can correct this on my behalf, I would appreciate it. Regards, Chris On Sat, Sep 24,

Re: [Intel-wired-lan] [PATCH net-next v2 1/2] i40e: remove superfluous I40E_DEBUG_USER statement

2016-09-24 Thread Alexander Duyck
On Sat, Sep 24, 2016 at 4:13 AM, Stefan Assmann wrote: > On 24.09.2016 04:48, Alexander Duyck wrote: >> On Fri, Sep 23, 2016 at 6:30 AM, Stefan Assmann wrote: >>> This debug statement is confusing and never set in the code. Any debug >>> output should be guarded by the proper I40E_DEBUG_* stateme

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Larry Finger
On 09/24/2016 11:15 AM, Joe Perches wrote: On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote: Would it make sense to explicitly set the enum values, or add them as comments, to make such look-ups easier? If you want to create enum->#ENUM structs and "const char *" lookup functions, please

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote: > Would it make sense to explicitly set the enum values, or add them as > comments, to make such look-ups easier? If you want to create enum->#ENUM structs and "const char *" lookup functions, please be my guest. otherwise, hex is at least a

[PATCH 7/7] ipv6 addrconf: change default MAX_RTR_SOLICITATIONS from 3 to -1 (unlimited)

2016-09-24 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This changes: /proc/sys/net/ipv6/conf/all/router_solicitations /proc/sys/net/ipv6/conf/default/router_solicitations from 3 to unlimited. This is the https://tools.ietf.org/html/rfc7559 recommended default. Signed-off-by: Maciej Żenczykowski --- include/net/addrco

[PATCH 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

2016-09-24 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Accessible via: /proc/sys/net/ipv6/conf/*/router_solicitation_max_interval For now we default it to the same value as the normal interval. Signed-off-by: Maciej Żenczykowski --- include/linux/ipv6.h | 1 + include/net/addrconf.h| 1 + include/uapi/linux/

[PATCH 5/7] ipv6 addrconf: implement RFC7559 router solicitation backoff

2016-09-24 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This implements: https://tools.ietf.org/html/rfc7559 Backoff is performed according to RFC3315 section 14: https://tools.ietf.org/html/rfc3315#section-14 Signed-off-by: Maciej Żenczykowski --- include/net/if_inet6.h | 1 + net/ipv6/addrconf.c| 31 +++

[PATCH 6/7] ipv6 addrconf: change default RTR_SOLICITATION_MAX_INTERVAL from 4s to 1h

2016-09-24 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This changes: /proc/sys/net/ipv6/conf/all/router_solicitation_max_interval /proc/sys/net/ipv6/conf/default/router_solicitation_max_interval from 4 seconds to 1 hour. This is the https://tools.ietf.org/html/rfc7559 recommended default. Signed-off-by: Maciej Żenczyko

[PATCH 2/7] ipv6 addrconf: remove addrconf_sysctl_hop_limit()

2016-09-24 Thread Maciej Żenczykowski
From: Maciej Żenczykowski replace with extra1/2 magic Signed-off-by: Maciej Żenczykowski --- net/ipv6/addrconf.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 11fa1a5564d4..3a835495fb53 100644 --- a/ne

[PATCH 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

2016-09-24 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This allows setting /proc/sys/net/ipv6/conf/*/router_solicitations to -1 meaning an unlimited number of retransmits. Signed-off-by: Maciej Żenczykowski --- net/ipv6/addrconf.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/net/ipv6/addr

[PATCH 1/7] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl

2016-09-24 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv6/addrconf.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 2f1f5d439788..11fa1a5564d4 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf

Implement rfc7559 ipv6 router solicitation backoff

2016-09-24 Thread Maciej Żenczykowski

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jean Delvare
Hi Joe, Larry, On Fri, 23 Sep 2016 12:02:43 -0700, Joe Perches wrote: > On Fri, 2016-09-23 at 13:59 -0500, Larry Finger wrote: > > I'm not familiar with the %#x format. What does it do? > > Outputs SPECIAL prefix, it's the same as "0x%x" > > lib/vsprintf.c: > #define SPECIAL 64

Re: [PATCH 0/3] net: fec: updates to align IP header

2016-09-24 Thread Eric Nelson
On 09/24/2016 08:09 AM, Andy Duan wrote: > From: Eric Nelson Sent: Saturday, September 24, 2016 10:42 > PM >> To: netdev@vger.kernel.org >> Cc: li...@arm.linux.org.uk; and...@lunn.ch; Andy Duan >> ; ota...@ossystems.com.br; >> eduma...@google.com; troy.ki...@boundarydevices.com; >> da...@davemlof

RE: [PATCH 0/3] net: fec: updates to align IP header

2016-09-24 Thread Andy Duan
From: Eric Nelson Sent: Saturday, September 24, 2016 10:42 PM > To: netdev@vger.kernel.org > Cc: li...@arm.linux.org.uk; and...@lunn.ch; Andy Duan > ; ota...@ossystems.com.br; > eduma...@google.com; troy.ki...@boundarydevices.com; > da...@davemloft.net; u.kleine-koe...@pengutronix.de; Eric Nelson

[PATCH 3/3] net: fec: align IP header in hardware

2016-09-24 Thread Eric Nelson
The FEC receive accelerator (RACC) supports shifting the data payload of received packets by 16-bits, which aligns the payload (IP header) on a 4-byte boundary, which is, if not required, at least strongly suggested by the Linux networking layer. Without this patch, a huge number of alignment faul

[PATCH 2/3] net: fec: remove QUIRK_HAS_RACC from i.mx27

2016-09-24 Thread Eric Nelson
According to the i.MX27 reference manual, this SoC does not have support for the receive accelerator (RACC) register at offset 0x1C4. http://cache.nxp.com/files/32bit/doc/ref_manual/MCIMX27RM.pdf Signed-off-by: Eric Nelson --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file cha

[PATCH 1/3] net: fec: remove QUIRK_HAS_RACC from i.mx25

2016-09-24 Thread Eric Nelson
According to the i.MX25 reference manual, this SoC does not have support for the receive accelerator (RACC) register at offset 0x1C4. http://www.nxp.com/files/dsp/doc/ref_manual/IMX25RM.pdf Signed-off-by: Eric Nelson --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insert

[PATCH 0/3] net: fec: updates to align IP header

2016-09-24 Thread Eric Nelson
This patch series is the outcome of investigation into very high numbers of alignment faults on kernel 4.1.33 from the linux-fslc tree: https://github.com/freescale/linux-fslc/tree/4.1-1.0.x-imx The first two patches remove support for the receive accelerator (RACC) from the i.MX25 and i.MX27

Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up

2016-09-24 Thread Sergei Shtylyov
Hello. On 9/24/2016 8:24 AM, Baoyou Xie wrote: We get 1 warning when building kernel with W=1: drivers/isdn/hisax/hscx.c:175:1: warning: no previous prototype for 'open_hscxstate' [-Wmissing-prototypes] In fact, this function is declared in drivers/isdn/hisax/elsa_ser.c, but should be declard

Re: [PATCH net v2] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()

2016-09-24 Thread David Miller
From: Lance Richardson Date: Fri, 23 Sep 2016 15:50:29 -0400 > Similar to commit 3be07244b733 ("ip6_gre: fix flowi6_proto value in > xmit path"), set flowi6_proto to IPPROTO_GRE for output route lookup. > > Up until now, ip6gre_xmit_other() has set flowi6_proto to a bogus value. > This affected

Re: [PATCH] hv_netvsc: fix comments

2016-09-24 Thread David Miller
From: sthem...@exchange.microsoft.com Date: Fri, 23 Sep 2016 17:08:17 -0700 > From: Stephen Hemminger > > Typo's and spelling errors. Also remove old comment from staging era. > > Signed-off-by: Stephen Hemminger Applied to net-next. Please properly specify "[PATCH net-next]" or "[PATCH net]

Re: [PATCH v2 0/2] BQL support and fix for a regression issue

2016-09-24 Thread David Miller
From: sunil.kovv...@gmail.com Date: Fri, 23 Sep 2016 14:42:26 +0530 > From: Sunil Goutham > > These patches add byte queue limit support and also fixes a regression > issue introduced by commit > 'net: thunderx: Use netdev's name for naming VF's interrupts' > > Changes from v1: > - As suggested

Re: [PATCH] cxgb4: fix -ve error check on a signed iq

2016-09-24 Thread David Miller
From: Colin King Date: Fri, 23 Sep 2016 14:45:13 +0100 > -static unsigned int get_filter_steerq(struct net_device *dev, > +static int get_filter_steerq(struct net_device *dev, > struct ch_filter_specification *fs) If you change the location of the openning par

Re: [PATCH] mlxsw: spectrum: remove redundant check if err is zero

2016-09-24 Thread David Miller
From: Colin King Date: Fri, 23 Sep 2016 12:02:45 +0100 > From: Colin Ian King > > There is an earlier check and return if err is non-zero, so > the check to see if it is zero is redundant in every iteration > of the loop and hence the check can be removed. > > Signed-off-by: Colin Ian King A

Re: Alignment issues with freescale FEC driver

2016-09-24 Thread Eric Nelson
Hi David, On 09/23/2016 07:43 PM, David Miller wrote: > From: Eric Nelson > Date: Fri, 23 Sep 2016 10:33:29 -0700 > >> Since the hardware requires longword alignment for its' DMA transfers, >> aligning the IP header will require a memcpy, right? > > I wish hardware designers didn't do this. >

Re: [PATCH net-next] Documentation: devicetree: fix typo in MediaTek ethernet device-tree binding

2016-09-24 Thread David Miller
From: Date: Fri, 23 Sep 2016 14:09:32 +0800 > From: Sean Wang > > fix typo in > Documentation/devicetree/bindings/net/mediatek-net.txt > > Cc: devicet...@vger.kernel.org > Reported-by: Sergei Shtylyov > Signed-off-by: Sean Wang Applied.

Re: [PATCH net-next v2] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

2016-09-24 Thread David Miller
From: Date: Fri, 23 Sep 2016 14:04:09 +0800 > From: Sean Wang > > add phy-mode "trgmii" to > Documentation/devicetree/bindings/net/ethernet.txt > > Cc: devicet...@vger.kernel.org > Reported-by: Sergei Shtylyov > Signed-off-by: Sean Wang Applied.

Re: [PATCH net-next 00/15] rxrpc: Bug fixes and tracepoints

2016-09-24 Thread David Miller
From: David Howells Date: Fri, 23 Sep 2016 16:15:17 +0100 > Here are a bunch of bug fixes: ... > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20160923 Pulled, thanks David.

Re: [net-next 00/10][pull request] 10GbE Intel Wired LAN Driver Updates 2016-09-23

2016-09-24 Thread David Miller
From: Jeff Kirsher Date: Fri, 23 Sep 2016 00:51:33 -0700 > This series contains updates to ixgbe and ixgbevf. Pulled, thanks Jeff.

  1   2   >