[PATCH] ethtool: add register dump support for fjes driver

2016-10-17 Thread Taku Izumi
From: Taku This patch adds the register dump format for FUJITSU Extended Network device like the following: # ethtool -d es0 0x: OWNER_EPID(Owner EPID) 0x0001 0x0004: MAX_EP(Maximum EP) 0x0008 0x0010: DCTL (Device C

[PATCH] net: hip04: Remove superfluous ether_setup after alloc_etherdev

2016-10-17 Thread Tobias Klauser
There is no need to call ether_setup after alloc_ethdev since it was already called there. Signed-off-by: Tobias Klauser --- drivers/net/ethernet/hisilicon/hip04_eth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-17 Thread Johannes Berg
On Sat, 2016-10-15 at 18:16 +0100, Ard Biesheuvel wrote: > The CCM code goes out of its way to perform the CTR encryption of the > MAC using the subordinate CTR driver. To this end, it tweaks the > input and output scatterlists so the aead_req 'odata' and/or > 'auth_tag' fields [which may live on t

Re: [PATCH net-next 1/2] net: phy: Add Speed downshift set driver for Microsemi PHYs.

2016-10-17 Thread Raju Lakkaraju
Hi Andrew, Thank you for code review and comments. On Fri, Oct 14, 2016 at 02:12:32PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > On Fri, Oct 14, 2016 at 05:10:32PM +0530, Raju Lakkaraju wrote: > > From: Raju Lakkaraju > > > > For operation in cabling environments that are incompatible wi

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-17 Thread Ard Biesheuvel
On 17 October 2016 at 08:28, Johannes Berg wrote: > On Sat, 2016-10-15 at 18:16 +0100, Ard Biesheuvel wrote: >> The CCM code goes out of its way to perform the CTR encryption of the >> MAC using the subordinate CTR driver. To this end, it tweaks the >> input and output scatterlists so the aead_req

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-17 Thread Johannes Berg
On Mon, 2016-10-17 at 08:37 +0100, Ard Biesheuvel wrote: >  > Could we get a statement first whether it is supported to allocate > aead_req (and other crypto req structures) on the stack? Well, we haven't heard from Herbert :) > If not, then > we have our work cut out for us. But if it is, I'd r

Re: hello

2016-10-17 Thread Alexander Alemayhu
On Fri, Oct 14, 2016 at 05:18:10PM +0800, maowenan wrote: > i want to subscribe this mail, thank you very much. > Try sending subscribe netdev to majord...@vger.kernel.org

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-17 Thread Ard Biesheuvel
On 17 October 2016 at 08:47, Johannes Berg wrote: > On Mon, 2016-10-17 at 08:37 +0100, Ard Biesheuvel wrote: >> >> Could we get a statement first whether it is supported to allocate >> aead_req (and other crypto req structures) on the stack? > > Well, we haven't heard from Herbert :) > >> If not,

[PATCH] mac80211: move struct aead_req off the stack

2016-10-17 Thread Johannes Berg
From: Johannes Berg Some crypto implementations (such as the generic CCM wrapper in crypto/) use scatterlists to map fields of private data in their struct aead_req. This means these data structures cannot live in the vmalloc area, which means that they cannot live on the stack (with CONFIG_VMAP_

Re: Hello

2016-10-17 Thread Alexander Alemayhu
On Fri, Oct 14, 2016 at 05:17:36PM +0800, yuehaibing wrote: > subscribe linux-kernel > Try sending subscribe linux-kernel to majord...@vger.kernel.org

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-17 Thread Johannes Berg
On Mon, 2016-10-17 at 08:50 +0100, Ard Biesheuvel wrote: > I just realised that patch should probably use > aead_request_alloc/aead_request_free [and drop the memset]. That also > fixes the latent bug where the alignment of the req ctx is not take > into account. Good point, I'll fix that up. >

Re: linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561: poor error checking ?

2016-10-17 Thread Luca Coelho
Hi David, On Mon, 2016-10-17 at 07:40 +, David Binderman wrote: > Hello there, > > linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561]: (style) > Checking if unsigned variable 'len' is less than zero. > > Source code is > > len = min((size_t)le32_to_cpu(rsp->len) << 2,

[PATCH v2] mac80211: move struct aead_req off the stack

2016-10-17 Thread Johannes Berg
From: Johannes Berg Some crypto implementations (such as the generic CCM wrapper in crypto/) use scatterlists to map fields of private data in their struct aead_req. This means these data structures cannot live in the vmalloc area, which means that they cannot live on the stack (with CONFIG_VMAP_

[PATCH v3] mac80211: move extra crypto data off the stack

2016-10-17 Thread Johannes Berg
From: Johannes Berg As the stack can (on x86-64) now be virtually mapped rather than using "normal" kernel memory, Sergey noticed mac80211 isn't using the SG APIs correctly by putting on-stack buffers into SG tables. This leads to kernel crashes. Fix this by allocating a bit of per-CPU memory fo

Re: [PATCH v3] mac80211: move extra crypto data off the stack

2016-10-17 Thread Johannes Berg
[snip] Sorry, this went out by mistake. johannes

[PATCH v3] mac80211: move struct aead_req off the stack

2016-10-17 Thread Johannes Berg
From: Johannes Berg Some crypto implementations (such as the generic CCM wrapper in crypto/) use scatterlists to map fields of private data in their struct aead_req. This means these data structures cannot live in the vmalloc area, which means that they cannot live on the stack (with CONFIG_VMAP_

Re: [PATCH v3] mac80211: move struct aead_req off the stack

2016-10-17 Thread Ard Biesheuvel
On 17 October 2016 at 09:03, Johannes Berg wrote: > From: Johannes Berg > > Some crypto implementations (such as the generic CCM wrapper in crypto/) > use scatterlists to map fields of private data in their struct aead_req. > This means these data structures cannot live in the vmalloc area, which

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-17 Thread Raju Lakkaraju
Hi Andrew, Thank you for code review and comments. On Fri, Oct 14, 2016 at 02:02:28PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > On Fri, Oct 14, 2016 at 05:10:33PM +0530, Raju Lakkaraju wrote: > > From: Raju Lakkaraju > > > > VSC8531 Fast Link Failure 2 feature enables the PHY to indic

[PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Johannes Berg
From: Johannes Berg As the stack can (on x86-64) now be virtually mapped rather than using "normal" kernel memory, Sergey noticed mac80211 isn't using the SG APIs correctly by putting on-stack buffers into SG tables. This leads to kernel crashes. Fix this by allocating the extra fields dynamical

introduce IPV6_PKTINFO_L2 socket-option?

2016-10-17 Thread Alexander Aring
Hi all, I am currently writing some userspace UDP Software for 6LoWPAN subsystem. It will use UDP IPv6 sockets, the 6LoWPAN adaptation will be done at kernelspace. My problem is currently the following: I need per recvmsg(2) the used source link-layer address for the incoming UDP packet which u

Re: Need help with mdiobus_register and phy

2016-10-17 Thread Zefir Kurtisi
On 10/15/2016 08:28 PM, Timur Tabi wrote: > Andrew Lunn wrote: >> 1) Take the SerDes power down out of the suspend code for the at803x. >> >> 2) Assume MII_PHYID1/2 registers are not guaranteed to be available >> when the PHY is powered down. So get_phy_id should first read >> MII_BMCR. If it gets

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Ard Biesheuvel
On 17 October 2016 at 09:33, Johannes Berg wrote: > From: Johannes Berg > > As the stack can (on x86-64) now be virtually mapped rather than > using "normal" kernel memory, Sergey noticed mac80211 isn't using > the SG APIs correctly by putting on-stack buffers into SG tables. > This leads to kern

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Ard Biesheuvel
On 17 October 2016 at 10:14, Ard Biesheuvel wrote: > On 17 October 2016 at 09:33, Johannes Berg wrote: >> From: Johannes Berg >> >> As the stack can (on x86-64) now be virtually mapped rather than >> using "normal" kernel memory, Sergey noticed mac80211 isn't using >> the SG APIs correctly by pu

Re: [PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags

2016-10-17 Thread Jesper Nilsson
On Thu, Oct 13, 2016 at 01:20:16AM +0100, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages() and > replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit > in callers as use of this flag can result in surprising behaviour (an

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Johannes Berg
> Apologies for going back and forth on this, but it appears there may > be another way to deal with this. > > First of all, we only need this handling for the authenticated data, Are you sure b_0/j_0 aren't needed? We pass those to aead_request_set_crypt(), and I wasn't sure what that really di

Re: [PATCH 10/10] mm: replace access_process_vm() write parameter with gup_flags

2016-10-17 Thread Jesper Nilsson
On Thu, Oct 13, 2016 at 01:20:20AM +0100, Lorenzo Stoakes wrote: > This patch removes the write parameter from access_process_vm() and replaces > it > with a gup_flags parameter as use of this function previously _implied_ > FOLL_FORCE, whereas after this patch callers explicitly pass this flag. >

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Ard Biesheuvel
On 17 October 2016 at 10:23, Johannes Berg wrote: > >> Apologies for going back and forth on this, but it appears there may >> be another way to deal with this. >> >> First of all, we only need this handling for the authenticated data, > > Are you sure b_0/j_0 aren't needed? We pass those > to aea

[PATCH iproute2 2/2] tc filters: fix filters to display handle when deleted even when no option

2016-10-17 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Fix a few stylistic things that hurt my eyes while at it. Signed-off-by: Jamal Hadi Salim --- tc/f_basic.c| 6 +++--- tc/f_bpf.c | 6 +++--- tc/f_cgroup.c | 7 +++ tc/f_flow.c | 4 ++-- tc/f_flower.c | 5 +++-- tc/f_fw.c | 38 +

[PATCH iproute2 1/2] tc filters: display handle in events when a filter is deleted

2016-10-17 Thread Jamal Hadi Salim
From: Jamal Hadi Salim An event being displayed via "tc mon" should display the filter handle. The filter handle is a required parameter when deleting a filter and therefore the delete event should mimic/mirror the command sent. A simple test, run tc monitor on one window, on another try adding a

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Johannes Berg
On Mon, 2016-10-17 at 10:30 +0100, Ard Biesheuvel wrote: > Yes. But as I replied, setting the req size is not supported atm, > although it is reasonable to demand a way to allocate additional data > in the request specifically for this issue. So let's proceed with the > aead_request_alloc/free pat

Re: [PATCH] mac80211_hwsim: suggest nl80211 instead of wext driver in documentation

2016-10-17 Thread Johannes Berg
On Mon, 2016-10-17 at 00:39 +0200, Linus Lüssing wrote: > For mac80211_hwsim interfaces, suggest to use wpa_supplicant with the > more modern, netlink based driver instead of wext. Makes sense, applied. > Actually, I wasn't even able to make a connection with the > configuration > files and infor

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Ard Biesheuvel
> On 17 Oct 2016, at 10:35, Johannes Berg wrote: > >> On Mon, 2016-10-17 at 10:30 +0100, Ard Biesheuvel wrote: >> >> Yes. But as I replied, setting the req size is not supported atm, >> although it is reasonable to demand a way to allocate additional data >> in the request specifically for thi

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Ard Biesheuvel
> On 17 Oct 2016, at 10:35, Johannes Berg wrote: > >> On Mon, 2016-10-17 at 10:30 +0100, Ard Biesheuvel wrote: >> >> Yes. But as I replied, setting the req size is not supported atm, >> although it is reasonable to demand a way to allocate additional data >> in the request specifically for thi

Re: net/ipv6: potential deadlock in do_ipv6_setsockopt

2016-10-17 Thread Baozeng Ding
Applied the patch to my test tree. I will tell you the result a few days later. Thank you. On 2016/10/17 2:50, Cong Wang wrote: > On Sun, Oct 16, 2016 at 6:34 AM, Baozeng Ding wrote: >> Possible unsafe locking scenario: >> >>CPU0CPU1 >>

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Johannes Berg
> > Well, if your other patch to make it OK to be on-stack would be > > applied instead, this wouldn't make much sense either :) > > > > Yes but that one only fixes ccm not gcm Yes, but we can do the same for GCM, no? > > In this particular patch, we could reduce the size of the struct, > > bu

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Ard Biesheuvel
> On 17 Oct 2016, at 10:54, Johannes Berg wrote: > > >>> Well, if your other patch to make it OK to be on-stack would be >>> applied instead, this wouldn't make much sense either :) >>> >> >> Yes but that one only fixes ccm not gcm > > Yes, but we can do the same for GCM, no? > No, not re

Re: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-17 Thread Jamal Hadi Salim
Some comments: IIUC, the main struggle seems to be whether the redirect to dummy0 is useful or not? i.e instead of just letting the packets go up the stack on eth1? It seems like sflowd needs to read off eth1 via packet socket? To be backward compatible - supporting that approach seems sensible.

Re: linux-next: manual merge of the net tree with Linus' tree

2016-10-17 Thread Mintz, Yuval
> Today's linux-next merge of the net tree got a conflict in: >   drivers/net/ethernet/qlogic/Kconfig > between commit: >   2e0cbc4dd077 ("qedr: Add RoCE driver framework") > from Linus' tree and commit: >   0189efb8f4f8 ("qed*: Fix Kconfig dependencies with INFINIBAND_QEDR") > from the net t

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-17 Thread Raju Lakkaraju
Hi Florian/Andrew, Thank you for review comments. On Thu, Oct 06, 2016 at 03:57:32AM -0700, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On 09/28/2016 01:24 PM, Andrew Lunn wrote: > >> static int vsc85xx_wol_set(struct phy_device *phydev, > >> struct ethtool_wolinfo *

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-17 Thread Raju Lakkaraju
Hi Andrew, Thank you for code review and valuable comments. On Wed, Sep 28, 2016 at 10:24:51PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > + reg_val = phy_read(phydev, MSCC_PHY_BYPASS_CONTROL); > > + if ((mdix == ETH_TP_MDI) || (mdix == ETH_TP_MDI_X)) { > > + reg_val

Re: [PATCH iproute2 net-next] bridge: vlan: remove wrong stats help

2016-10-17 Thread Stephen Hemminger
On Wed, 12 Oct 2016 15:02:28 +0200 Nikolay Aleksandrov wrote: > When I did the per-vlan stats iproute2 support, I left out a hunk from a > previous version of the patch that was using a special subcommand "stats". > Since the latest version uses the -s switch remove the help for the stats > subco

Re: [PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices

2016-10-17 Thread Stephen Hemminger
On Fri, 14 Oct 2016 18:28:42 -0700 David Ahern wrote: > > /** > + * netdev_has_upper_dev_all - Check if device is linked to an upper device > + * @dev: device > + * @upper_dev: upper device to check > + * > + * Find out if a device is linked to specified upper device and return true > + * in c

Re: [PATCH iproute2] tc: cls_bpf: handle skip_sw and skip_hw flags

2016-10-17 Thread Stephen Hemminger
On Wed, 12 Oct 2016 16:46:36 +0100 Jakub Kicinski wrote: > Add support for controling hardware offload using (now standard) > skip_sw and skip_hw flags in cls_bpf. > > Signed-off-by: Jakub Kicinski Applied

[PATCH net-next 0/2] Move to BPF selftests

2016-10-17 Thread Daniel Borkmann
This set improves the test_verifier and test_maps suite and moves it over to a new BPF selftest directory, so we can keep improving it under kernel selftest umbrella. This also integrates a test script for checking test_bpf.ko under various JIT options. Thanks! Daniel Borkmann (2): bpf: add var

[PATCH net-next 1/2] bpf: add various tests around spill/fill of regs

2016-10-17 Thread Daniel Borkmann
Add several spill/fill tests. Besides others, one that performs xadd on the spilled register, one ldx/stx test where different types are spilled from two branches and read out from common path. Verfier does handle all correctly. Signed-off-by: Daniel Borkmann --- samples/bpf/test_verifier.c | 11

Re: [PATCH iproute2] bridge: add support for the multicast flood flag

2016-10-17 Thread Stephen Hemminger
On Thu, 13 Oct 2016 17:54:20 +0200 Nikolay Aleksandrov wrote: > Recently a new per-port flag was added which controls the flooding of > unknown multicast, this patch adds support for controlling it via iproute2. > It also updates the man pages with information about the new flag. > > Signed-off-

Re: [PATCH iproute2] devlink: Convert conditional in dl_argv_handle_port() to switch()

2016-10-17 Thread Stephen Hemminger
On Sun, 9 Oct 2016 10:14:18 +0800 Hangbin Liu wrote: > Discovered by Phil's covscan. The final return statement is never reached. > This is not inherently clear from looking at the code, so change the > conditional to a switch() statement which should clarify this. > > CC: Phil Sutter > Signed

Re: [PATCH net-next 1/2] net: phy: Add Speed downshift set driver for Microsemi PHYs.

2016-10-17 Thread Florian Fainelli
On October 17, 2016 12:31:54 AM PDT, Raju Lakkaraju wrote: >Hi Andrew, > >Thank you for code review and comments. > >On Fri, Oct 14, 2016 at 02:12:32PM +0200, Andrew Lunn wrote: >> EXTERNAL EMAIL >> >> >> On Fri, Oct 14, 2016 at 05:10:32PM +0530, Raju Lakkaraju wrote: >> > From: Raju Lakkaraju

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-17 Thread Raju Lakkaraju
Hi Florian/Andrew, Thank you for review comments. On Thu, Oct 06, 2016 at 04:09:56AM -0700, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On 10/05/2016 12:18 AM, Andrew Lunn wrote: > + phydev->mdix = ETH_TP_MDI_AUTO; > >>> > >>> Humm, interesting. The only other driver supporting mdix

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-17 Thread Florian Fainelli
On October 17, 2016 1:13:14 AM PDT, Raju Lakkaraju wrote: >Hi Andrew, > >Thank you for code review and comments. > >On Fri, Oct 14, 2016 at 02:02:28PM +0200, Andrew Lunn wrote: >> EXTERNAL EMAIL >> >> >> > On Fri, Oct 14, 2016 at 05:10:33PM +0530, Raju Lakkaraju wrote: >> > From: Raju Lakkaraju

[PATCH net-next v12 2/9] openvswitch: add mac_proto field to the flow key

2016-10-17 Thread Jiri Benc
Use a hole in the structure. We support only Ethernet so far and will add a support for L2-less packets shortly. We could use a bool to indicate whether the Ethernet header is present or not but the approach with the mac_proto field is more generic and occupies the same number of bytes in the struc

[PATCH net-next v12 3/9] openvswitch: pass mac_proto to ovs_vport_send

2016-10-17 Thread Jiri Benc
We'll need it to alter packets sent to ARPHRD_NONE interfaces. Change do_output() to use the actual L2 header size of the packet when deciding on the minimum cutlen. The assumption here is that what matters is not the output interface hard_header_len but rather the L2 header of the particular pack

[PATCH net-next v12 9/9] openvswitch: use ipgre tunnel rather than gretap tunnel

2016-10-17 Thread Jiri Benc
From: Simon Horman This allows GRE tunnels to send and receive both layer 2 packets (packets with an ethernet header) and layer 3 packets (packets without an ethernet header). Signed-off-by: Simon Horman Signed-off-by: Jiri Benc --- v12: removed the non-gre hunks (now part of previous patches

[PATCH net-next v12 1/9] openvswitch: use hard_header_len instead of hardcoded ETH_HLEN

2016-10-17 Thread Jiri Benc
On tx, use hard_header_len while deciding whether to refragment or drop the packet. That way, all combinations are calculated correctly: * L2 packet going to L2 interface (the L2 header len is subtracted), * L2 packet going to L3 interface (the L2 header is included in the packet lenght), * L3 p

[PATCH net-next v12 7/9] openvswitch: add Ethernet push and pop actions

2016-10-17 Thread Jiri Benc
It's not allowed to push Ethernet header in front of another Ethernet header. It's not allowed to pop Ethernet header if there's a vlan tag. This preserves the invariant that L3 packet never has a vlan tag. Based on previous versions by Lorand Jakab and Simon Horman. Signed-off-by: Lorand Jakab

[PATCH net-next v12 8/9] openvswitch: allow L3 netdev ports

2016-10-17 Thread Jiri Benc
Allow ARPHRD_NONE interfaces to be added to ovs bridge. Based on previous versions by Lorand Jakab and Simon Horman. Signed-off-by: Lorand Jakab Signed-off-by: Simon Horman Signed-off-by: Jiri Benc --- net/openvswitch/vport-netdev.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(

[PATCH net-next v12 6/9] openvswitch: netlink: support L3 packets

2016-10-17 Thread Jiri Benc
Extend the ovs flow netlink protocol to support L3 packets. Packets without OVS_KEY_ATTR_ETHERNET attribute specify L3 packets; for those, the OVS_KEY_ATTR_ETHERTYPE attribute is mandatory. Push/pop vlan actions are only supported for Ethernet packets. Based on previous versions by Lorand Jakab a

[PATCH net-next v12 0/9] openvswitch: support for layer 3 encapsulated packets

2016-10-17 Thread Jiri Benc
At the core of this patch set is removing the assumption in Open vSwitch datapath that all packets have Ethernet header. Support for layer 3 GRE tunnels is also added by this patchset. The implementation relies on the presence of pop_eth and push_eth actions in datapath flows to facilitate adding

[PATCH net-next v12 4/9] openvswitch: support MPLS push and pop for L3 packets

2016-10-17 Thread Jiri Benc
Update Ethernet header only if there is one. Signed-off-by: Jiri Benc --- net/openvswitch/actions.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index dc8bb97e2258..064cbcb7b0c5 100644 --- a/net/open

[PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-17 Thread Jiri Benc
Support receiving, extracting flow key and sending of L3 packets (packets without an Ethernet header). Note that even after this patch, non-Ethernet interfaces are still not allowed to be added to bridges. Similarly, netlink interface for sending and receiving L3 packets to/from user space is not

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Ard Biesheuvel
On 17 October 2016 at 11:02, Ard Biesheuvel wrote: > > >> On 17 Oct 2016, at 10:54, Johannes Berg wrote: >> >> Well, if your other patch to make it OK to be on-stack would be applied instead, this wouldn't make much sense either :) >>> >>> Yes but that one only fixes ccm not gcm >>

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Johannes Berg
On Mon, 2016-10-17 at 14:06 +0100, Ard Biesheuvel wrote: >  > Actually, while I think it will be worthwhile going forward to > implement such an 'auxiliary data' feature in a generic way, I still > think we should address the issue at hand without too much > complication. > > If we pedal back to t

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Ard Biesheuvel
On 17 October 2016 at 14:16, Johannes Berg wrote: > On Mon, 2016-10-17 at 14:06 +0100, Ard Biesheuvel wrote: >> >> Actually, while I think it will be worthwhile going forward to >> implement such an 'auxiliary data' feature in a generic way, I still >> think we should address the issue at hand wit

Re: [PATCH v4] mac80211: move extra crypto data off the stack

2016-10-17 Thread Johannes Berg
> Indeed. And it keeps the clutter inside the aes_xxx.c files, which > could easily be updated in the future to use some auxdata feature if > it ever materializes. > > I think it would help this code, but also the ESP code you pointed > out, to have some kind of 'ordered synchronous' CRYPTO_xxx f

ATENCIÓN;

2016-10-17 Thread administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de corre

[PATCH 2/7] net: ethernet: nb8800: Fix module autoload

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ $ modinfo dri

[PATCH 0/7] net: Fix module autoload for several platform drivers

2016-10-17 Thread Javier Martinez Canillas
Hello David, I noticed that module autoload won't be working in a bunch of platform drivers in the net subsystem and this patch series contains the fixes. Best regards, Javier Javier Martinez Canillas (7): net: nps_enet: Fix module autoload net: ethernet: nb8800: Fix module autoload net:

[PATCH 1/7] net: nps_enet: Fix module autoload

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo drive

[PATCH 5/7] net: hisilicon: Fix hns_mdio module autoload for OF registration

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo drive

[PATCH 3/7] net: hns: Fix hns_dsaf module autoload for OF registration

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo drive

[PATCH 7/7] net: dsa: bcm_sf2: Fix module autoload for OF registration

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo drive

[PATCH v4] mac80211: move struct aead_req off the stack

2016-10-17 Thread Ard Biesheuvel
From: Johannes Berg Some crypto implementations (such as the generic CCM wrapper in crypto/) use scatterlists to map fields of private data in their struct aead_req. This means these data structures cannot live in the vmalloc area, which means that they cannot live on the stack (with CONFIG_VMAP_

[PATCH 6/7] net: dsa: b53: Fix module autoload

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo drive

Re: ethtool.h compile warning on c++

2016-10-17 Thread Ivan Vecera
Dne 14.10.2016 v 21:46 Ben Greear napsal(a): I am getting warnings about sign missmatch. Maybe make SPEED_UNKNOWN be ((__u32)(0x)) ? The 0xU could be better. Ivan

Re: [PATCH 2/7] net: ethernet: nb8800: Fix module autoload

2016-10-17 Thread Måns Rullgård
Javier Martinez Canillas writes: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE()

Re: [PATCH v4] mac80211: move struct aead_req off the stack

2016-10-17 Thread Johannes Berg
On Mon, 2016-10-17 at 15:05 +0100, Ard Biesheuvel wrote: > From: Johannes Berg That really ought to have been you - I think I may have lost that by accident. I'll change it. > In addition, take care not to put any of our own stack allocations > into > scatterlists. This involves reserving some e

Re: [PATCH] net: Require exact match for TCP socket lookups if dif is l3mdev

2016-10-17 Thread David Miller
From: David Ahern Date: Sun, 16 Oct 2016 20:02:52 -0700 > Currently, socket lookups for l3mdev (vrf) use cases can match a socket > that is bound to a port but not a device (ie., a global socket). If the > sysctl tcp_l3mdev_accept is not set this leads to ack packets going out > based on the main

[PATCH 4/7] net: qcom/emac: Fix module autoload for OF registration

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo drive

Re: [PATCH net-next] ila: Don't use dest cache when gateway is set

2016-10-17 Thread David Miller
From: Tom Herbert Date: Sun, 16 Oct 2016 21:25:35 -0700 > If the gateway is set on an ILA route we don't need to bother with using > the destination cache in the ILA route. Translation does not change the > routing in this case so we can stick with orig_output in the lwstate > output function. >

Re: [PATCH] net: hip04: Remove superfluous ether_setup after alloc_etherdev

2016-10-17 Thread David Miller
From: Tobias Klauser Date: Mon, 17 Oct 2016 09:22:04 +0200 > There is no need to call ether_setup after alloc_ethdev since it was > already called there. > > Signed-off-by: Tobias Klauser Applied to net-next, thanks.

[PATCH] fjes: fix format string for trace output

2016-10-17 Thread Arnd Bergmann
phys_addr_t may be wider than a pointer and has to be printed using the special %pap format string, as pointed out by this new warning. arch/x86/include/../../../drivers/net/fjes/fjes_trace.h: In function ‘trace_raw_output_fjes_hw_start_debug_req’: arch/x86/include/../../../drivers/net/fjes/fjes_

Re: [PATCH RFC] ixgbe: ixgbe_atr() must check if network header is available in headlen

2016-10-17 Thread Duyck, Alexander H
On Sat, 2016-10-15 at 17:31 -0400, Sowmini Varadhan wrote: > For some Tx paths (e.g., tpacket_snd()), ixgbe_atr may be > passed down an sk_buff that has the network and transport > header in the paged data, so it needs to make sure these > headers are available in the headlen bytes to calculate the

Re: [PATCH 4/7] net: qcom/emac: Fix module autoload for OF registration

2016-10-17 Thread Timur Tabi
Javier Martinez Canillas wrote: If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. B

Re: [PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices

2016-10-17 Thread David Miller
From: Stephen Hemminger Date: Mon, 17 Oct 2016 05:21:21 -0700 > You should write this more succinctly as: > > static bool __netdev_has_upper_dev(struct net_device *upper_dev, void *data) > { > struct net_device *dev = data; > > return upper_dev == dev; > } > > bool netdev_has_upper

[PATCH 1/9] ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)

2016-10-17 Thread David Lebrun
Implement minimal support for processing of SR-enabled packets as described in https://tools.ietf.org/html/draft-ietf-6man-segment-routing-header-02. This patch implements the following operations: - Intermediate segment endpoint: incrementation of active segment and rerouting. - Egress for SR-enc

[PATCH 0/9] net: add support for IPv6 Segment Routing

2016-10-17 Thread David Lebrun
Segment Routing (SR) is a source routing paradigm, architecturally defined in draft-ietf-spring-segment-routing-09 [1]. The IPv6 flavor of SR is defined in draft-ietf-6man-segment-routing-header-02 [2]. The main idea is that an SR-enabled packet contains a list of segments, which represent mandato

[PATCH 3/9] ipv6: sr: add support for SRH encapsulation and injection with lwtunnels

2016-10-17 Thread David Lebrun
This patch creates a new type of interfaceless lightweight tunnel (SEG6), enabling the encapsulation and injection of SRH within locally emitted packets and forwarded packets. >From a configuration viewpoint, a seg6 tunnel would be configured as follows: ip -6 ro ad fc00::1/128 via encap seg6

[PATCH 4/9] ipv6: sr: add core files for SR HMAC support

2016-10-17 Thread David Lebrun
This patch adds the necessary functions to compute and check the HMAC signature of an SR-enabled packet. Two HMAC algorithms are supported: hmac(sha1) and hmac(sha256). In order to avoid dynamic memory allocation for each HMAC computation, a per-cpu ring buffer is allocated for this purpose. Sign

[PATCH 2/9] ipv6: sr: add code base for control plane support of SR-IPv6

2016-10-17 Thread David Lebrun
This patch adds the necessary hooks and structures to provide support for SR-IPv6 control plane, essentially the Generic Netlink commands that will be used for userspace control over the Segment Routing kernel structures. The genetlink commands provide control over two different structures: tunnel

[PATCH 8/9] ipv6: sr: add support for SRH injection through setsockopt

2016-10-17 Thread David Lebrun
This patch adds support for per-socket SRH injection with the setsockopt system call through the IPPROTO_IPV6, IPV6_RTHDR options. The SRH is pushed through the ipv6_push_nfrag_opts function. Signed-off-by: David Lebrun --- net/ipv6/exthdrs.c | 67 ++

[PATCH -next] net: wan: slic_ds26522: Use module_spi_driver to simplify the code

2016-10-17 Thread Wei Yongjun
From: Wei Yongjun module_spi_driver() makes the code simpler by eliminating boilerplate code. Signed-off-by: Wei Yongjun --- drivers/net/wan/slic_ds26522.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/wan/slic_ds26522.c b/drivers/net/wan/slic_ds

[PATCH 6/9] ipv6: sr: add calls to verify and insert HMAC signatures

2016-10-17 Thread David Lebrun
This patch enables the verification of the HMAC signature for transiting SR-enabled packets, and its insertion on encapsulated/injected SRH. Signed-off-by: David Lebrun --- net/ipv6/exthdrs.c | 6 ++ net/ipv6/seg6_iptunnel.c | 13 + 2 files changed, 19 insertions(+) diff

[PATCH 5/9] ipv6: sr: implement API to control SR HMAC structures

2016-10-17 Thread David Lebrun
This patch provides an implementation of the genetlink commands to associate a given HMAC key identifier with an hashing algorithm and a secret. It also provides a per-interface sysctl called seg6_require_hmac, allowing a user-defined policy for processing HMAC-signed SR-enabled packets. A value of

[PATCH -next] net: wan: slic_ds26522: Remove .owner field for driver

2016-10-17 Thread Wei Yongjun
From: Wei Yongjun Remove .owner field if calls are used which set it automatically. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Wei Yongjun --- drivers/net/wan/slic_ds26522.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wan/slic_ds26522.c

[PATCH 7/9] ipv6: add source address argument for ipv6_push_nfrag_opts

2016-10-17 Thread David Lebrun
This patch prepares for insertion of SRH through setsockopt(). The new source address argument is used when an HMAC field is present in the SRH, which must be filled. The HMAC signature process requires the source address as input text. Signed-off-by: David Lebrun --- include/net/ipv6.h| 3 +

[PATCH 9/9] ipv6: sr: add documentation file for per-interface sysctls

2016-10-17 Thread David Lebrun
This patch adds documentation for some SR-related per-interface sysctls. Signed-off-by: David Lebrun --- Documentation/networking/seg6-sysctl.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/networking/seg6-sysctl.txt diff --git a/Documentation/net

Re: [PATCH net] net: pktgen: remove rcu locking in pktgen_change_name()

2016-10-17 Thread David Miller
From: Eric Dumazet Date: Sat, 15 Oct 2016 17:50:49 +0200 > From: Eric Dumazet > > After Jesper commit back in linux-3.18, we trigger a lockdep > splat in proc_create_data() while allocating memory from > pktgen_change_name(). > > This patch converts t->if_lock to a mutex, since it is now only

Re: [PATCH 1/9] ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)

2016-10-17 Thread David Miller
From: David Lebrun Date: Mon, 17 Oct 2016 16:42:22 +0200 > +/* > + * SRH > + */ > +struct ipv6_sr_hdr { > + __u8nexthdr; > + __u8hdrlen; > + __u8type; > + __u8segments_left; > + __u8first_segment; > + __be16 flags; > + __u8reserved; > + > +

Re: [PATCH 2/9] ipv6: sr: add code base for control plane support of SR-IPv6

2016-10-17 Thread David Lebrun
On 10/17/2016 05:00 PM, David Miller wrote: > Please ordre local variables from longest to shortest line (AKA reverse > christmas tree layout). > > Please audit your entire submission for this problem. > >> +val = (struct in6_addr *)nla_data(info->attrs[SEG6_ATTR_DST]); > > Please remove all

Re: [PATCH 1/9] ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)

2016-10-17 Thread David Lebrun
On 10/17/2016 04:57 PM, David Miller wrote: > Please don't use packed, it results in extremely inefficient code on > several architectures. > > You can simply declare the flags as two 8-bit pieces and all will work > out fine. Noted, will do signature.asc Description: OpenPGP digital signature

  1   2   3   >